Re: [edk2] nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2

2019-02-19 Thread Gerd Hoffmann
Hi, > (2) If I change the cmdline to "lun=5", then the exchange is: Not supported (by the usb protocol). The protocol has a control message to query the number of devices (grep for GetMaxLun in qemu). LUNs are not allowed to be sparse. So, with a single storage device the LUN must be zero.

Re: [edk2] nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2

2019-02-19 Thread Laszlo Ersek
On 02/19/19 09:49, Gerd Hoffmann wrote: > Hi, > >> (2) If I change the cmdline to "lun=5", then the exchange is: > > Not supported (by the usb protocol). > > The protocol has a control message to query the number of devices (grep > for GetMaxLun in qemu). LUNs are not allowed to be sparse. S

Re: [edk2] [Patch] BaseTools: Fixed a bug in Vpd handling

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Monday, February 18, 2019 5:50 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Fixed a bug in Vpd handling > >If there are multiple sku used in a platform and >gEfiMdeModuleP

Re: [edk2] [Patch] BaseTools: Fix a ParseDevPathValue function issue.

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Feng, Bob C >Sent: Saturday, February 16, 2019 11:38 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] BaseTools: Fix a ParseDevPathValue function

Re: [edk2] [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Saturday, February 16, 2019 10:55 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function > >MaxSizeUserSet is missing in Pcd deepcopy fun

Re: [edk2] [Patch] BaseTools: Fixed a code bug for Pcd Array.

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Feng, Bob C >Sent: Saturday, February 16, 2019 1:54 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] BaseTools: Fixed a code bug for Pcd Array. >

[edk2] [PATCH v2 2/2] MdePkg/UefiDevicePathLibDevicePathProtocol: Add sanity check for FilePath device path

2019-02-19 Thread Jian J Wang
> v2: fix wrong detection of FilePath device path REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1497 Current implementation of IsDevicePathValid() is not enough for type of MEDIA_FILEPATH_DP, which has NULL-terminated string in the device path. This patch add a simple NULL character check a

[edk2] [PATCH v2 0/2] Add sanity check for FilePath device path

2019-02-19 Thread Jian J Wang
> v2: fix wrong detection of FilePath device path REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1497 Tests - Pass specific DevicePathLib test cases - Boot shell - Boot to Fedora 26 (Qemu/x64) - Boot to Ubuntu 18.04 (Qemu/x64) - Boot to Windows 10 (Qemu/x64) - Boot to Windows 7 (Qemu/x64) J

Re: [edk2] [PATCH v2 0/2] Add sanity check for FilePath device path

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian >J Wang >Sent: Tuesday, February 19, 2019 5:22 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [PATCH v2 0/2] Add sanity check for FilePath device path > >> v2: fix wr

[edk2] [PATCH v2 1/2] MdePkg/UefiDevicePathLib: Add sanity check for FilePath device path

2019-02-19 Thread Jian J Wang
> v2: fix wrong detection of FilePath device path REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1497 Current implementation of IsDevicePathValid() is not enough for type of MEDIA_FILEPATH_DP, which has NULL-terminated string in the device path. This patch add a simple NULL character check a

Re: [edk2] [PATCH] UefiCpuPkg/SecCore: Wrong Debug Information for SecCore

2019-02-19 Thread Ni, Ray
Chasel, Please change the two FindAndReportEntryPoints() calls in SecStartupPhase2() so that their line length doesn't exceed 120. With the modification, Reviewed-by: Ray Ni > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, February 19, 2019 3:44 PM > To: edk2-devel@lists.01.o

Re: [edk2] [PATCH v2 1/2] MdePkg/UefiDevicePathLib: Add sanity check for FilePath device path

2019-02-19 Thread Ni, Ray
> -Original Message- > From: Wang, Jian J > Sent: Tuesday, February 19, 2019 5:22 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Ni, Ray ; Kinney, > Michael D > Subject: [PATCH v2 1/2] MdePkg/UefiDevicePathLib: Add sanity check for > FilePath device path > > > v2: fix wrong dete

Re: [edk2] [PATCH v2] IntelSiliconPkg/MicrocodeUpdateDxe: Error message enhancement

2019-02-19 Thread Ni, Ray
> -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, February 19, 2019 3:57 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [PATCH v2] IntelSiliconPkg/MicrocodeUpdateDxe: Error message > enhancement > > The error message of ExtendedTableCount i

Re: [edk2] [PATCH v2 1/2] MdePkg/UefiDevicePathLib: Add sanity check for FilePath device path

2019-02-19 Thread Wang, Jian J
Hi Ray, > -Original Message- > From: Ni, Ray > Sent: Tuesday, February 19, 2019 5:34 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > > Subject: RE: [PATCH v2 1/2] MdePkg/UefiDevicePathLib: Add sanity check for > FilePath device path > > > > > ---

[edk2] [PATCH 0/2] Allow use of ArmPlatformPkg NOR flash driver in StandaloneMM

2019-02-19 Thread Jagadeesh Ujja
In-Reply-To: This patch series refactors Arm Platform NorFlashDxe driver and extends it to be usable in StandaloneMM mode as well. This will be then useable on platforms that use StandaloneMM to implement secure EFI variables with NOR flash as the non-volatile storage. Jagadeesh Ujja (2): Ar

[edk2] [PATCH 2/2] ArmPlatformPkg/NorFlash: Allow reusability as a MM driver

2019-02-19 Thread Jagadeesh Ujja
Adapt the NorFlash driver to be used as a MM_STANDALONE driver to allow access to NOR flash for code executing in MM_STANDALONE mode. This allows storing of EFI variables on NOR flash which is accessible only via the MM STANDALONE mode software. Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH 1/2] ArmPlatformPkg/NorFlash: Refactor Nor Flash DXE driver

2019-02-19 Thread Jagadeesh Ujja
To allow the ArmPlatformPkg NOR flash driver to be reusable with StandaloneMM, refactor the DXE specfic portions into a separate file. This will then allow the common portions to be reused in StandaloneMM. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja ---

[edk2] [PATCH V3] BaseTools:BaseTools supports to the driver combination.

2019-02-19 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1520 To save the image size without the compression, more than one drivers can be combined into single one. When more than one drivers are combined, their depex will be AND together. Below is the example to combine BootManagerPolicyDxe into DriverH

[edk2] [PATCH] BaseTools:Fixed build failure when specifying multiple BUILDTARGET

2019-02-19 Thread Fan, ZhijuX
With Python3, the dict.value() method returns an iterator. If a dictionary is updated while an iterator on its keys is used, a RuntimeError is generated. Converting the iterator to a list() forces a copy of the mutable keys in an immutable list which can be safely iterated. Cc: Bob Feng Cc: Limin

[edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

2019-02-19 Thread Jagadeesh Ujja
In preparation for providing a standalone MM based non-secure variable runtime driver, factor out some portions that are specific to the traditional driver, mainly related to locating variable arch protocol and variable write arch protocol, which are not required to be located when using standalone

Re: [edk2] [PATCH v2 1/2] MdePkg/UefiDevicePathLib: Add sanity check for FilePath device path

2019-02-19 Thread Ni, Ray
> -Original Message- > From: Wang, Jian J > Sent: Tuesday, February 19, 2019 6:12 PM > To: Ni, Ray ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > > Subject: RE: [PATCH v2 1/2] MdePkg/UefiDevicePathLib: Add sanity check for > FilePath device path > > Hi Ray, > > > -

Re: [edk2] [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

2019-02-19 Thread Gao, Liming
Ray: In PI spec, TEMPORARY_RAM_SUPPORT_PPI is described as an optional PPI that is only required for platforms that may have side effects when both Temporary RAM and Permanent RAM are enabled. If a platform does not have any side effects when both Temporary RAM and Permanent RAM are enab

Re: [edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

2019-02-19 Thread Ard Biesheuvel
Hello Jagadeesh, On Tue, 19 Feb 2019 at 11:47, Jagadeesh Ujja wrote: > > In preparation for providing a standalone MM based non-secure variable > runtime driver, factor out some portions that are specific to the > traditional driver, mainly related to locating variable arch protocol > and variabl

[edk2] [Patch] BaseTools: Fix a bug about Structure PCD

2019-02-19 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1535 If there is Hii Structure Pcd, build will fail, root cause is that there is an incorrect variable access method used in code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Sour

Re: [edk2] [Patch] BaseTools: Remove unused txt files

2019-02-19 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Friday, February 15, 2019 10:32 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Remove unused txt files externals.txt is to refer to the bin

Re: [edk2] [PATCH] BaseTools:Fixed build failure when specifying multiple BUILDTARGET

2019-02-19 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, February 19, 2019 6:56 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:Fixed build failure when specifying multiple BUILDTARGET With Python3, the dict.value() method

Re: [edk2] [PATCH edk2-platforms 0/2] Platform/RaspberryPi3: add RNG support

2019-02-19 Thread Leif Lindholm
On Sat, Feb 16, 2019 at 11:34:20AM +0100, Ard Biesheuvel wrote: > Add a RNG driver for the BCM283x and wire it up for the Raspberry Pi 3 > platform so that the random number generator is accessible to the OS > loader via the EFI_RNG_PROTOCOL. This is used by the KASLR implementation > in the arm64

Re: [edk2] [PATCH V3] BaseTools:BaseTools supports to the driver combination.

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Fan, ZhijuX > Sent: Tuesday, February 19, 2019 6:47 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2][PATCH V3] BaseTools:BaseTools supports to the driver > combination. > > BZ:https://bugzilla.tianocore.org/show_b

Re: [edk2] [PATCH edk2-platforms 0/2] Platform/RaspberryPi3: add RNG support

2019-02-19 Thread Ard Biesheuvel
On Tue, 19 Feb 2019 at 15:44, Leif Lindholm wrote: > > On Sat, Feb 16, 2019 at 11:34:20AM +0100, Ard Biesheuvel wrote: > > Add a RNG driver for the BCM283x and wire it up for the Raspberry Pi 3 > > platform so that the random number generator is accessible to the OS > > loader via the EFI_RNG_PROT

[edk2] [Patch] BaseTools: replace Sdict with OrderedDict in UPT

2019-02-19 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1504 Sdict class is removed on the commit 174a9d3cc8f74f7a731ac5f16ce6864c8eb359ec but there are still some py files import it. This patch is to use collections.OrderedDict to replace Sdict. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH] ShellPkg: add array index check for shell delay option

2019-02-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhichao Gao > Sent: Monday, February 18, 2019 12:28 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH] ShellPkg: add array index check for s

[edk2] [Patch V2] BaseTools: replace Sdict with OrderedDict in UPT

2019-02-19 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1504 V2: import OrderredDict as Sdict in Misc.py instead updating all the py files. Sdict class is removed on the commit 174a9d3cc8f74f7a731ac5f16ce6864c8eb359ec but there are still some py files import it. This patch is to use collections.Orde

Re: [edk2] [Patch V2] BaseTools: replace Sdict with OrderedDict in UPT

2019-02-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Feng, Bob C > Sent: Tuesday, February 19, 2019 7:44 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > ; Carsey, Jaben > Subject: [Patch V2] BaseTools: replace Sdict with OrderedDict in UPT > Importance: High > > BZ:

Re: [edk2] [PATCH] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-02-19 Thread Ashish Singhal
Hello Mike/Lao, Were you able to have a look at this? Thanks Ashish -Original Message- From: Ashish Singhal Sent: Monday, February 4, 2019 1:16 PM To: edk2-devel@lists.01.org Cc: michael.d.kin...@intel.com; liming@intel.com; Ashish Singhal Subject: [PATCH] MdePkg/UefiLib: Simplif

Re: [edk2] [PATCH 2/2] ArmPlatformPkg/NorFlash: Allow reusability as a MM driver

2019-02-19 Thread Ard Biesheuvel
Hello Jagadeesh, On Tue, 19 Feb 2019 at 11:32, Jagadeesh Ujja wrote: > > Adapt the NorFlash driver to be used as a MM_STANDALONE driver to > allow access to NOR flash for code executing in MM_STANDALONE mode. > This allows storing of EFI variables on NOR flash which is accessible > only via the M

[edk2] [PATCH v2] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

2019-02-19 Thread Jeff Brasen
From: Edgar Handal REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1537 Use 16-bit and 32-bit IO widths for SDMMC MMIO to prevent all register accesses from being split up into 8-bit accesses. The SDHCI specification states that the registers shall be accessible in byte, word, and double wo

Re: [edk2] [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

2019-02-19 Thread Jordan Justen
On 2019-02-18 18:46:24, Ni, Ray wrote: > Jordan, > I find many real platforms do not implement the temporary ram migration > PPI and rely on the PeiCore migration logic. > So perhaps TemporaryRamMigration PPI was added to help platform to > destroy the temporary RAM (CAR in x86 platform). I guess

Re: [edk2] [PATCH] OvmfPkg/Sec: Clear the Cache Disable flag in the CR0 register

2019-02-19 Thread Jordan Justen
On 2019-02-18 04:17:26, Laszlo Ersek wrote: > On 02/18/19 11:10, Jordan Justen wrote: > > Clear the CD (Cache Disable) flag in the CR0 register. When the VM > > implements the CD flag, this can substantially decrease the time it > > takes to decompress the firmware volumes. > > > > Contributed-und

Re: [edk2] [PATCH] OvmfPkg/Sec: Clear the Cache Disable flag in the CR0 register

2019-02-19 Thread Andrew Fish via edk2-devel
> On Feb 18, 2019, at 5:23 AM, Laszlo Ersek wrote: > > generic comment (applies to all NASM usage I guess): > > On 02/18/19 11:10, Jordan Justen wrote: > >> +mov eax, cr0 >> +and eax, ~(1 << 30) >> +mov cr0, eax > >> +mov rax, cr0 >> +and eax, ~(1 <<

Re: [edk2] [PATCH] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-02-19 Thread Kinney, Michael D
Ashish, Thanks for looking at simplifying this logic again. I have not had a chance to run the size analysis yet. I will get back to you in a couple of days. Thanks, Mike > -Original Message- > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > Sent: Tuesday, February 19, 2019 8:

Re: [edk2] [PATCH] OvmfPkg/Sec: Clear the Cache Disable flag in the CR0 register

2019-02-19 Thread Jordan Justen
On 2019-02-18 05:23:28, Laszlo Ersek wrote: > generic comment (applies to all NASM usage I guess): > > On 02/18/19 11:10, Jordan Justen wrote: > > > +mov eax, cr0 > > +and eax, ~(1 << 30) > > +mov cr0, eax > > > +mov rax, cr0 > > +and eax, ~(1 << 30) > > +

Re: [edk2] [PATCH 06/10] OvmfPkg/Sec: Disable optimizations for TemporaryRamMigration

2019-02-19 Thread Brian J. Johnson
On 2/18/19 3:32 AM, Ard Biesheuvel wrote: On Mon, 18 Feb 2019 at 10:08, Jordan Justen wrote: On 2019-02-17 23:53:01, Ard Biesheuvel wrote: On Mon, 18 Feb 2019 at 05:12, Jordan Justen wrote: This needs an explanation why optimization needs to be disabled. I'm not sure this is required.

Re: [edk2] [PATCH 06/10] OvmfPkg/Sec: Disable optimizations for TemporaryRamMigration

2019-02-19 Thread Jordan Justen
On 2019-02-19 14:50:13, Brian J. Johnson wrote: > On 2/18/19 3:32 AM, Ard Biesheuvel wrote: > > On Mon, 18 Feb 2019 at 10:08, Jordan Justen > > wrote: > >> > >> On 2019-02-17 23:53:01, Ard Biesheuvel wrote: > >>> On Mon, 18 Feb 2019 at 05:12, Jordan Justen > >>> wrote: > > >>> > >>> This n

Re: [edk2] [PATCHv2 1/1] MdeModulePkg/SdMmcPciHcDxe Fix eMMC HS400 switch sequence

2019-02-19 Thread Wu, Hao A
Thanks Mateusz, Reviewed-by: Hao Wu And pushed via commit 68c67d3a2a33261e41ff0123129b4e9759617f71. Best Regards, Hao Wu > -Original Message- > From: Albecki, Mateusz > Sent: Monday, February 18, 2019 7:12 PM > To: edk2-devel@lists.01.org > Cc: Albecki, Mateusz; Wu, Hao A > Subject: [P

Re: [edk2] [PATCH v2] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

2019-02-19 Thread Wu, Hao A
Thanks Jeff. Reviewed-by: Hao Wu And pushed via commit f168816c49e388dcd097dd62d766d63f73aaabb3. Best Regards, Hao Wu > -Original Message- > From: Jeff Brasen [mailto:jbra...@nvidia.com] > Sent: Wednesday, February 20, 2019 1:07 AM > To: edk2-devel@lists.01.org > Cc: Edgar Handal; Jeff

Re: [edk2] [PATCH] BaseTools:PCD value error in structure pcd sku case.

2019-02-19 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Monday, February 18, 2019 5:53 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:PCD value error in structure pcd sku case. Defined 2 PCDs(Test4 & Test401) and 2 SKUs(DEFAULT & _), th

Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option

2019-02-19 Thread Laszlo Ersek
Hi Dandan, On 02/15/19 09:51, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1398 > > According to PI1.7 Spec, report extended data describing an > EFI_STATUS return value along with > EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR and > EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED status

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

2019-02-19 Thread Wu, Hao A
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Sunday, February 03, 2019 8:39 PM > To: Wu, Hao A > Cc: Jeff Brasen; edk2-devel@lists.01.org; Edgar Handal; Marcin Wojtas > Subject: Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit > IO width

[edk2] Intel Platforms in Bugzilla

2019-02-19 Thread Kubacki, Michael A
Hi Mike, The devel-MinPlatform branch in the edk2-platforms repo is being used to develop Intel platform code. We plan to move this work to the master branch in edk2-platforms after a refactor in the MinPlatformPkg. There's a need to submit feature requests and bugs against this code now. Do y

Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option

2019-02-19 Thread Laszlo Ersek
On 02/20/19 02:19, Laszlo Ersek wrote: > Hi Dandan, > > On 02/15/19 09:51, Dandan Bi wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1398 >> >> According to PI1.7 Spec, report extended data describing an >> EFI_STATUS return value along with >> EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR

Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option

2019-02-19 Thread Ni, Ray
Laszlo, Thanks for catching this. GenPerformMemoryTest() in MdeModulePkg\Universal\MemoryTest\GenericMemoryTestDxe\LightMemoryTest.c uses the same technics as you suggested. I give up to propose another option: having pack(1) for the new status structure. > -Original Message- > From: L

Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option

2019-02-19 Thread Bi, Dandan
Hi Laszlo, Thanks for catching this issue. I am sorry that I didn't consider the alignment issue when working on this patch. Thanks, Dandan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, February 20, 2019

Re: [edk2] [PATCH] SecurityPkg/TcgConfigDxe: Allow enabling TPM 1.2 device from disabled state.

2019-02-19 Thread Yao, Jiewen
Thanks for the enhancement. Reviewed-by: jiewen@intel.com > -Original Message- > From: Gonzalez Del Cueto, Rodrigo > Sent: Monday, February 4, 2019 2:07 PM > To: edk2-devel@lists.01.org > Cc: Gonzalez Del Cueto, Rodrigo ; > Zhang, Chao B ; Yao, Jiewen > > Subject: [PATCH] SecurityPkg

[edk2] [PATCH] BaseTools:Build fail if define [DEPEX] in library inf

2019-02-19 Thread Fan, ZhijuX
When define [DEPEX] in lib inf to build, it will fail and report" gUefiOvmfPkgTokenSpaceGuid.test1 used in [Depex] section should be used as FixedAtBuild type and VOID* datum type in the module." But we define this PCD to FixedAtBuild type and VOID* datum type indeed. DEC: [PcdsFixedAtBuild] gUefi

[edk2] [PATCH v2 2/6] MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib

2019-02-19 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem for DXE ResetSystemLib. So the consumer of ResetSystemLib can use this API to reset system with additional reset data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni

[edk2] [PATCH v2 1/6] MdeModulePkg: change the function name ResetSystem

2019-02-19 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Change the function name form ResetSystem to EfiRuntimeResetSystem. Because ResetSystem and EfiResetSystem would be used in ResetSystemLib and RuntimeLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc

[edk2] [PATCH v2 0/6] ResetSystemLib changings

2019-02-19 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem in ResetSystemLib. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 Implement a runtime library instance of ResetSystemLib base on the new changing. Contributed-under: TianoCore Contribution Agreement 1.1 Sign

[edk2] [PATCH v2 3/6] MdeModulePkg: Add a new API ResetSystem for Null version

2019-02-19 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem for BaseResetSystemLibNull to be in accord with other instances. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Liming Gao --- .../BaseResetSystemLibNull.c

[edk2] [PATCH v2 5/6] MdeModulePkg: Add a runtime library instance of ResetSystemLib

2019-02-19 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 Implement a runtime library instance of ResetSystemLib. It would use a internal point instead of gRT and convert it depend on gEfiEventVirtualAddressChangeGuid. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao G

[edk2] [PATCH v2 4/6] MdeModulePkg: Add the new API ResetSystem in the head file

2019-02-19 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add the new API ResetSystem in the related head file so that the consumer can use it through the combination of library instance and head file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni C

[edk2] [PATCH v2 6/6] MdeModulePkg: Add the runtime ResetSystemLib in MdeModulePkg.dsc

2019-02-19 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 Add the runtime library instance of ResetSystemLib in MdeModulePkg.dsc to make sure it can build pass. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Liming Gao --- MdeModulePkg/MdeModul

Re: [edk2] [PATCH 2/2] ArmPlatformPkg/NorFlash: Allow reusability as a MM driver

2019-02-19 Thread Jagadeesh Ujja
On Tue, Feb 19, 2019 at 10:14 PM Ard Biesheuvel wrote: > > Hello Jagadeesh, > Hi Ard, Thank you for your valuable comments. Will do the appropriate changes based on your comments and publish in the next patchset Regards, Jagadeesh > On Tue, 19 Feb 2019 at 11:32, Jagadeesh Ujja wrote: > > > > Ad

Re: [edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

2019-02-19 Thread Jagadeesh Ujja
hi Ard, On Tue, Feb 19, 2019 at 6:55 PM Ard Biesheuvel wrote: > > Hello Jagadeesh, > > On Tue, 19 Feb 2019 at 11:47, Jagadeesh Ujja wrote: > > > > In preparation for providing a standalone MM based non-secure variable > > runtime driver, factor out some portions that are specific to the > > tradi

[edk2] [edk2-announce] Community Meeting Minutes

2019-02-19 Thread stephano
An HTML version is available here: https://www.tianocore.org/minutes/Community-2019-02.html Github Pull Requests - We are still considering Github as a possible platform for patch review. There are two issues we'd like to overcome: 1. comprehensive email notifications or ba

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-19 Thread stephano
On 2/19/2019 10:23 PM, stephano wrote: Groups.io - Laszlo and I will evaluate Groups.io, however initial impressions is that this will work as a communication platform going forward. We'd like to use this for design discussions and as a replacement for our current mailing

[edk2] [PATCH v2] UefiCpuPkg/Microcode: Fix incorrect checksum issue for extended table

2019-02-19 Thread Chen A Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1020 The following Microcode payload format is define in SDM spec. Payload: |MicrocodeHeader|MicrocodeBinary|ExtendedHeader|ExtendedTable|. When we verify the CheckSum32 with ExtendedTable, we should use the fields of ExtendedTable to replace cor

[edk2] [PATCH edk2-non-osi v2 1/8] Hisilicon/D06: Remove PCI enumeration dependency from SAS driver

2019-02-19 Thread Ming Huang
SAS controller is always existed, so accessing SAS register don't depend on PciBusDxe (pci enumeration). Modify SAS driver remove the dependence on pci enumeration. This patch is done to improve boot times. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Pla

[edk2] [PATCH edk2-non-osi v2 0/8] Upload D0x binary modules

2019-02-19 Thread Ming Huang
Main Changes since v1 : 1 Add some header files to edk2-non-osi; Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: 1902-non-osi-v2 Ming Huang (8): Hisilicon/D06: Remove PCI enumeration dependency from SAS driver Hisilicon/D0x: Update PlatformSysCtrlLi

[edk2] [PATCH edk2-non-osi v2 3/8] Hisilicon/D06: Update Mbigen and gic RAS register

2019-02-19 Thread Ming Huang
As chip group suggestions, update Mbigen and gic RAS configuration flow. Add below flow: 1 Reset Mbigen; 2 Disable Mbigen clock; 3 Deassert reset Mbigen; 4 Enable Mbigen clock; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/Drivers/Ra

[edk2] [PATCH edk2-non-osi v2 5/8] Hisilicon/D06: Use new flash layout

2019-02-19 Thread Ming Huang
In new flash layout, BIOS fd change from offset 1M to 8M in 16M spi flash. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/CustomData.Fv | Bin 0 -> 65536 bytes Platform/Hisilicon/D06/Library/OemAddress

[edk2] [PATCH edk2-non-osi v2 4/8] Hisilicon/D06: Support PCIe local RAS

2019-02-19 Thread Ming Huang
Add some registers configuration in PcieRasInitDxe and add PCIe local RAS interrupt handle in trusted firmware to support PCIe local RAS. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D06/Drivers/PcieRasInitDx

[edk2] [PATCH edk2-non-osi v2 2/8] Hisilicon/D0x: Update PlatformSysCtrlLib binary

2019-02-19 Thread Ming Huang
As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 context. PI specifies 'BSP' for Boot-strap Processor, as the one executing all of the EDK2 code. It then uses 'AP' to refer to Additional Processors, which can be assigned tasks using the EFI_MP_SERVICES_PROTOCOL. In a TianoCore c

[edk2] [PATCH edk2-non-osi v2 6/8] Hisilicon/D06: Fix numa node wrong issue

2019-02-19 Thread Ming Huang
Numa informations are acquired from HOB that build from memory initialization module. Correct numa informations to match booting from TA(Totem A or super cpu cluster A). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/MemoryInitPei/Mem

[edk2] [PATCH edk2-non-osi v2 7/8] Hisilicon/D06: Add Setup Item "Support DPC"

2019-02-19 Thread Ming Huang
Add setup item "Support DPC" to enable or disable PCIe DPC (Downstream Port Containment). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi | Bin 232832 -> 226784 bytes 1 file

[edk2] [PATCH edk2-non-osi v2 8/8] Hisilicon/D0x: Add some header files

2019-02-19 Thread Ming Huang
As interfaces exposed only by implementations in edk2-non-osi, so move some header files from edk2-platforms to edk2-non-osi. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Include/Library/IpmiCmdLib.h | 110 +++ S

[edk2] [PATCH edk2-platforms v2 03/18] Hisilicon/D06: Fix access variable fail issue

2019-02-19 Thread Ming Huang
From: Jason Zhang BmcWdtEnable is a field of OemConfigData structure, need have runtime service attribution if use it during exit boot service Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr |

[edk2] [PATCH edk2-platforms v2 01/18] Hisilicon/D0x: Add DriverHealthManagerDxe

2019-02-19 Thread Ming Huang
DriverHealthManagerDxe Collect driver health form of third party drivers to repair no healthy card. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D03/D03.dsc | 1 + Platform/Hisilicon/D05/D05.dsc | 1 + Platfo

[edk2] [PATCH edk2-platforms v2 04/18] Hisilicon/D06: Drop the leading 0 (0x0 -> 0x)

2019-02-19 Thread Ming Huang
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 24 ++-- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.a

[edk2] [PATCH edk2-platforms v2 08/18] Hisilicon/D06: Use HCCS speed with 2.6G

2019-02-19 Thread Ming Huang
Follow chip team suggestion, HCCS(Huawei Cache-Coherent System) may be unstable while speed is 3.0G, so use 2.6G to avoid some unstable stress issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Include/Library/OemMiscLib.h

[edk2] [PATCH edk2-platforms v2 02/18] Hisilicon/D06: Optimize SAS driver for reducing boot time

2019-02-19 Thread Ming Huang
SAS controller is always existed, so accessing SAS register don't depend on PciBusDxe (pci enumeration). Move the SAS module early in D06.fdf for dispatching SAS driver early. This can avoid wait in BDS normally and reduce boot time. This change is only valid after the update to SasDriverDxe in ed

[edk2] [PATCH edk2-platforms v2 00/18] Fix issues and improve D0x

2019-02-19 Thread Ming Huang
Main Changes since v1 : 1 Submit separate patch to drop the leading 0 for Hi1620Pci.asl; 2 Add Fix USB crash issue patch; 3 Modify some code style issues; 4 Drop "Use CalculateCrc16 in BaseLib" patch; 5 Refactor "Remove SerdesLib" patch; 6 Add patch for move some header files to edk2-non-osi/; Cod

[edk2] [PATCH edk2-platforms v2 05/18] Hisilicon/D06: Add more PCIe port INT-x support

2019-02-19 Thread Ming Huang
Since NVMe riser width is 6*X4, need add the related port's INT-x support to match OS driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 37 +++- 1 file changed, 36 insertio

[edk2] [PATCH edk2-platforms v2 06/18] Hisilicon/D06: Add OemGetCpuFreq to encapsulate difference

2019-02-19 Thread Ming Huang
From: xingjiang tang Implementation OemGetCpuFreq() to get cpu frequency from cpld to encapsulate project difference, for some projects don't support get cpu frequency by this way. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/Incl

[edk2] [PATCH edk2-platforms v2 11/18] Hisilicon/D06: Add Setup Item "Support DPC" and delete some PCIe menus

2019-02-19 Thread Ming Huang
Add setup item "Support DPC" to enable or disable PCIe DPC (Downstream Port Containment). The pcie menu is suppressed for original code as these menus are not ready. This patch remove the suppression for pcie menu, so delete these menus for now. Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH edk2-platforms v2 09/18] Hisilicon/D06: Add PCI_OSC_SUPPORT

2019-02-19 Thread Ming Huang
Add PCI_OSC_SUPPORT for remaining host bridges to remove fail output in kernel: [ 103.478893] acpi PNP0A08:01: _OSC failed (AE_NOT_FOUND); Add PCI_OSC_SUPPORT_HOTPLUG to rewrite _OSC of PCI0 and PCI6. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon

[edk2] [PATCH edk2-platforms v2 07/18] Hisilicon/D0x: Rename StartupAp() function

2019-02-19 Thread Ming Huang
As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 context. PI specifies 'BSP' for Boot-strap Processor, as the one executing all of the EDK2 code. It then uses 'AP' to refer to Additional Processors, which can be assigned tasks using the EFI_MP_SERVICES_PROTOCOL. In a TianoCore c

[edk2] [PATCH edk2-platforms v2 15/18] Hisilicon/D06: Fix USB crash issue(4079)

2019-02-19 Thread Ming Huang
Last patch "Modify IORT" change revision id of node type 2 to 1, and 4.19 later kernel will judge the revision id to get root pci bridge DMA informations from IORT. As Hi1620 USB 2.0 don't support 64 bit DMA, but the DMA attribute get from IORT node type 2 is 64 bit. So add _DMA method in USB pci b

[edk2] [PATCH edk2-platforms v2 14/18] Hisilicon/D0x: Remove SP805 watchdog pcd

2019-02-19 Thread Ming Huang
SP805 watchdog is no used for D0x, so remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D03/D03.dsc | 3 --- Platform/Hisilicon/D05/D05.dsc

[edk2] [PATCH edk2-platforms v2 18/18] Hisilicon/D0x: Modify version to 19.02

2019-02-19 Thread Ming Huang
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D03/D03.dsc | 4 ++-- Platform/Hisilicon/D05/D05.dsc | 4 ++-- Platform/Hisilicon/D06/D06.dsc | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[edk2] [PATCH edk2-platforms v2 13/18] Hisilicon/D06: Remove SECURE_BOOT_ENABLE definition

2019-02-19 Thread Ming Huang
As secure boot is not ready, remove SECURE_BOOT_ENABLE and relative code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D06/D06.dsc | 12 Platform/Hisilicon/D06/D06.fdf | 11 --- 2 files c

[edk2] [PATCH edk2-platforms v2 17/18] Hisilicon/D0x: Delete some header files

2019-02-19 Thread Ming Huang
As some interfaces exposed only by implementations in edk2-non-osi, so delete corresponding header files and modify code to make build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/EarlyConfigPeim/EarlyConfigPeimD03.inf

[edk2] [PATCH edk2-platforms v2 16/18] Hisilicon/D0x: Remove and tidy some codes about SerdesLib

2019-02-19 Thread Ming Huang
As some definitions are about OemMiscLib, so move them from SerdesLib.h to OemMiscLib.h and drop some useless function definitions. After doing this, some unnecessary references can be removed for D03/D05. SerdesLib is useless for SmbiosMiscDxe and D06, so remove it and delete SerdesLib.h for D06.

[edk2] [PATCH edk2-platforms v2 10/18] Hisilicon/D06: Modify for IMP self-Adapte support

2019-02-19 Thread Ming Huang
As new IMP(Cortex-M7) firmware support self-adapte, so do not need BIOS to implement some function, remove useless funtions and report CPU0/CPU1 Nic NCL offset to IMP. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/Library/OemNicLib/O

[edk2] [PATCH edk2-platforms v2 12/18] Hisilicon/D06: Use new flash layout

2019-02-19 Thread Ming Huang
In new flash layout, BIOS fd change from offset 1M to 8M in 16M spi flash. Use the new CustomData.Fv which indicate the offset of fd and which flash area can be updated for BMC. This patch is relative with patch "Use new flash layout" in edk2-non-osi. Contributed-under: TianoCore Contribution Ag

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-19 Thread Ard Biesheuvel
On Fri, 15 Feb 2019 at 15:57, Pete Batard wrote: > > On 2019-02-15 14:39, Ard Biesheuvel wrote: > > On Fri, 15 Feb 2019 at 11:07, Ard Biesheuvel > > wrote: > >> > >> On Tue, 12 Feb 2019 at 19:14, Leif Lindholm > >> wrote: > >>> > >>> On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote:

Re: [edk2] Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages

2019-02-19 Thread Rebecca Cran via edk2-devel
On Thursday, 14 February 2019 12:23:05 MST Laszlo Ersek wrote: > The wikis on github are non-intuitive, if you intend to edit them in a > normal text editor, locally. I struggled a lot until I came up with the > list on top. (It's possible I relied on others' advice in that; I no > longer remember

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-19 Thread Rebecca Cran via edk2-devel
On Tuesday, 19 February 2019 23:23:59 MST stephano wrote: > Github Pull Requests > - > We are still considering Github as a possible platform for patch review. One thing I've not seen mentioned here is that there's an official command line tool for GitHub, named 'hub': https: