Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

Hi Hao, That is right. Also, I have addressed your comments and have submitted v2 patch. Thanks Ashish -Original Message- From: Wu, Hao A Sent: Tuesday, March 5, 2019 8:01 PM To: Ashish Singhal ; edk2-devel@lists.01.org Cc: eug...@hp.com Subject: RE: [PATCH]

Re: [edk2] [PATCH] UefiCpuPkg/Microcode.c: Add verification before calculate CheckSum32

This is a bug. I agree to add it into Q1 stable tag. Thanks Liming > -Original Message- > From: Ni, Ray > Sent: Tuesday, March 5, 2019 9:35 PM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: Dong, Eric ; Ni, Ray ; Chen, Chen > A > Subject: RE: [edk2] [PATCH] UefiCpuPkg/Microcode.c:

[edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146 Add DSDT and SSDT description in the help information. Depend on the implement of UefiShellAcpiViewCommandLib, the "acpiview" command support to show all present type in the system not only support the listed type in the help information. So

[edk2] Does ARM platform produce MP protocol?

Ard, Leif, I am a bit interested in how ARM platform supports the MP? PI Spec defines below protocol but I failed to find a driver in ARM platform producing this protocol. Or did I miss anything? typedef struct _EFI_MP_SERVICES_PROTOCOL { EFI_MP_SERVICES_GET_NUMBER_OF_PROCESSORS

Re: [edk2] [PATCH] UefiCpuPkg/Microcode.c: Add verification before calculate CheckSum32

Pushed @ 219e560c20034843ac9917146c60db99bd01b6f4. > -Original Message- > From: Gao, Liming > Sent: Wednesday, March 6, 2019 1:38 PM > To: Ni, Ray ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Chen, Chen A > > Subject: RE: [edk2] [PATCH] UefiCpuPkg/Microcode.c: Add verification > before

[edk2] FW: [PATCH] BaseTools:Guid.xref will change after increment build

Hi: The items to be added to the PcdList are "(PcdCName, TokenSpaceGuid, SkuName, DefaultStore, Dummy5)" "Dummy5" can distinguish PCDS with the same name, So the results are consistent except for the order change. Any question, please let me know. Thanks. Best Regards Fan Zhiju

Re: [edk2] Does ARM platform produce MP protocol?

On Wed, 6 Mar 2019 at 06:44, Ni, Ray wrote: > > Ard, Leif, > I am a bit interested in how ARM platform supports the MP? > PI Spec defines below protocol but I failed to find a driver in ARM platform > producing this protocol. > Or did I miss anything? > No you are right. We don't expose that on

[edk2] [Patch V2 0/1] Document: Update DEC spec to remove EDK related contents

V2: Update top level README to add update history. Feng, Bob C (1): Document: Update DEC spec to remove EDK related contents 2_dec_file_overview/210_pcd_usage.md | 4 +--- 2_dec_file_overview/25_[includes]_usage.md | 6 +-

[edk2] [Patch V2 1/1] Document: Update DEC spec to remove EDK related contents

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents from DEC spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 2_dec_file_overview/210_pcd_usage.md | 4 +---

[edk2] [Patch V2 1/1] Document: Update Build spec to remove EDK related contents

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents from Build spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 10_post-build_imagegen_stage_-_flash/103_build_intermediate_images.md | 3

[edk2] [Patch V2 0/1] Document: Update Build spec to remove EDK related

V2: Update the top level README to add the update history. Feng, Bob C (1): Document: Update Build spec to remove EDK related contents 10_post-build_imagegen_stage_-_flash/103_build_intermediate_images.md | 3 +-- 12_build_changes_and_customizations/README.md | 4

[edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Clarify explain of '-s'

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1153 The '-s' option of 'acpiview' do not support multiply invocation options. So clarify it for users. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ruiyu Ni Cc: Jaben Carsey Cc: Liming Gao ---

Re: [edk2] [PATCH] UefiCpuPkg/Microcode.c: Add verification before calculate CheckSum32

Liming, Do I need any approval from you side before pushing the commit? Thanks, Ray > -Original Message- > From: edk2-devel On Behalf Of Ni, Ray > Sent: Wednesday, March 6, 2019 10:15 AM > To: Chen, Chen A ; edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: Re: [edk2] [PATCH]

Re: [edk2] [PATCH] BaseTools:Guid.xref will change after increment build

Hi Zhiju, Since you changed a set() to a list, I think you need to check if the item is already in the list before appending it. Thanks, Bob -Original Message- From: Fan, ZhijuX Sent: Tuesday, March 5, 2019 4:48 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject:

Re: [edk2] [Patch v2 2/4] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

And suggest update the title to be like "UefiCpuPkg: Retire PcdCpuFeaturesUserConfiguration". Thanks, Star -Original Message- From: Zeng, Star Sent: Tuesday, March 5, 2019 5:55 PM To: Dong, Eric ; edk2-devel@lists.01.org Cc: Ni, Ray ; Laszlo Ersek (ler...@redhat.com) ; Gao, Liming ;

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Direct allocate buffer for Wake up Buffer.

Eric, I agree with the code change. It fixes the memtest86 problem through a very simple code change. But I think we do need a very meaningful comments to describe a such simple code change. Comments below: 1. Please make sure each line of commit message doesn't exceed 70. > -Original

Re: [edk2] [Patch v2 2/4] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

It should be an incompatible change to remove PcdCpuFeaturesUserConfiguration. Please add upgrade notes for it. I know upgrade notes for 2019 Q1 stable tag is at https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Notes. I do not know where is the link for 2019 Q1 stable tag.

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

Ashish, Thanks - I haven't forgotten. We are still doing tests with the 32-bit ADMA driver and running into issues on our newer platform - once we have those resolved we will test the patch. (We are seeing a strange issue where Read Multiple Block works but Write Multiple Block does not.)

[edk2] [Patch] Document: Add PCD flexible format value EBNF in Fdf.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=541 This patch is to add flexible PCD value format EBNF into Fdf spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu --- 3_edk_ii_fdf_file_format/32_fdf_definition.md | 25

[edk2] [PATCH] BaseTools:Guid.xref will change after increment build

the order of the data may change if set() is used Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Workspace/DscBuildData.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH 02/10] StandaloneMmPkg: drop

[edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

PI defines a few architected events that have significance in the MM context as well as in the non-secure DXE context. So register notify handlers for these events, and relay them into the standalone MM world. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 09/10] StandaloneMmPkg/Core: remove legacy boot support

Remove the support for booting 'legacy' (i.e., non-UEFI boot) OSes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- StandaloneMmPkg/Core/StandaloneMmCore.h | 22 StandaloneMmPkg/Core/StandaloneMmCore.c | 124 ++-- 2 files changed,

Re: [edk2] [PATCH 01/10] StandaloneMmPkg: drop redundant definition of gEfiMmConfigurationProtocolGuid

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH 01/10] StandaloneMmPkg: drop

[edk2] [PATCH 04/10] StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint driver

StandaloneMmDriverEntryPoint is implemented in MdePkg now, so let's drop the redundant StandaloneMmPkg version. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf | 41

[edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the first place since the value is implied by the context (it is never valid to set it to FALSE for standalone MM or TRUE for traditional MM). So drop it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard

[edk2] [PATCH 01/10] StandaloneMmPkg: drop redundant definition of gEfiMmConfigurationProtocolGuid

gEfiMmConfigurationProtocolGuid is already defined in MdePkg, so drop the duplicate definition from StandaloneMmPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- StandaloneMmPkg/StandaloneMmPkg.dec | 3 --- 1 file changed, 3 deletions(-) diff --git

[edk2] [PATCH 06/10] StandaloneMmPkg/Core: permit encapsulated firmware volumes

Standalone MM requires 4 KB section alignment for all images, so that strict permissions can be applied. Unfortunately, this results in a lot of wasted space, which is usually costly in the secure world environment that standalone MM is expected to operate in. So let's permit the standalone MM

[edk2] [PATCH 03/10] StandaloneMmPkg: switch to NULL DebugLib resolution

Building StandaloneMmPkg from its .DSC is mainly intended for build coverage, and so platform specific configuration such as UART addresses don't belong here. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- StandaloneMmPkg/StandaloneMmPkg.dsc | 11

[edk2] [PATCH 00/10] StandaloneMmPkg, ArmPkg: cleanups and improvements

This series is a further cleanup of the StandaloneMmPkg infrastructure used to implement UEFI secure boot on ARM systems. The first 5 patches are simple cleanups. Patch #6 adds support for dispatching a compressed firmware volume in the standalone MM context, so that all drivers except the core

[edk2] [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call

Sending DEBUG output to the serial port should only be done via DebugLib calls, which is in charge of initializing the serial port when appropriate. So drop the explicit SerialPortInitialize () invocation, and rely on normal constructor ordering to get the serial port into the appropriate state at

[edk2] [PATCH 08/10] StandaloneMmPkg/Core: drop support for dispatching FVs into MM

Remove the support that permits calls into the MM context to dispatch firmware volumes that are not part of the initial standalone MM firmware volume. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- StandaloneMmPkg/Core/StandaloneMmCore.h | 22

[edk2] [PATCH 07/10] StandaloneMmPkg/Core: dispatch all drivers at init time

Instead of deferring dispatch of the remaining MM drivers once the CPU driver has been dispatched, proceed and dispatch all drivers. This makes sense for standalone MM, since all dispatchable drivers should be present in the initial firmware volume anyway: dispatch of additional FVs originating in

Re: [edk2] [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

Ok with me. Get Outlook for iOS From: Ard Biesheuvel Sent: Tuesday, March 5, 2019 6:39 AM To: Wu, Hao A Cc: edk2-devel@lists.01.org; Eugene Cohen; Ashish Singhal Subject: Re: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3

Re: [edk2] [PATCH v3] StandaloneMmPkg/Library: Install Variable Arch Protocol

hi Jiewen, Achin On Mon, Mar 4, 2019 at 4:16 PM Ard Biesheuvel wrote: > > (add StandaloneMmPkg maintainers) > Please let me know if you have any comments on this patch > On Mon, 4 Mar 2019 at 09:54, Jagadeesh Ujja wrote: > > > > In a system implementing the variable store in MM, there are no

Re: [edk2] [PATCH] ShellPkg: Correct a parameter's name

Reviewed-by: Jaben Carsey > -Original Message- > From: Zhang, Shenglei > Sent: Monday, March 04, 2019 6:06 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH] ShellPkg: Correct a parameter's name > Importance: High > > The parameter FilePath of

Re: [edk2] [PATCH 0/3] Xen PCI passthrough fixes

Hi Igor, On 03/04/19 16:04, Igor Druzhinin wrote: > Igor Druzhinin (3): > OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge > aperture > OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64 > OvmfPkg/XenSupport: turn off address decoding before BAR sizing

Re: [edk2] [PATCH 03/10] StandaloneMmPkg: switch to NULL DebugLib resolution

Reviewed-by: jiewen@intel.com > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Achin Gupta > ; Supreeth Venkatesh > ; Yao, Jiewen ; > Leif Lindholm ; Jagadeesh

Re: [edk2] [PATCH 04/10] StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint driver

Reviewed-by: jiewen@intel.com > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Achin Gupta > ; Supreeth Venkatesh > ; Yao, Jiewen ; > Leif Lindholm ; Jagadeesh

Re: [edk2] [PATCH v3] StandaloneMmPkg/Library: Install Variable Arch Protocol

On Tue, Mar 5, 2019 at 7:39 PM Jagadeesh Ujja wrote: > Adding Achin, Jiewen > hi Jiewen, Achin > > On Mon, Mar 4, 2019 at 4:16 PM Ard Biesheuvel > wrote: > > > > (add StandaloneMmPkg maintainers) > > > Please let me know if you have any comments on this patch > > > On Mon, 4 Mar 2019 at 09:54,

Re: [edk2] [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

On Tue, 5 Mar 2019 at 03:18, Wu, Hao A wrote: > > > -Original Message- > > From: Wu, Hao A > > Sent: Tuesday, March 05, 2019 9:14 AM > > To: edk2-devel@lists.01.org > > Cc: Wu, Hao A; Eugene Cohen; Ard Biesheuvel; Ashish Singhal > > Subject: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix

Re: [edk2] [PATCH 09/10] StandaloneMmPkg/Core: remove legacy boot support

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH 09/10] StandaloneMmPkg/Core:

Re: [edk2] [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call

Reviewed-by: jiewen@intel.com > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Achin Gupta > ; Supreeth Venkatesh > ; Yao, Jiewen ; > Leif Lindholm ; Jagadeesh

Re: [edk2] [Patch] Document: Update DSC spec to remove EDK related contents

Reviewed-by: Jaben Carsey It's a lot of changes. It looks good to me. > -Original Message- > From: Feng, Bob C > Sent: Monday, March 04, 2019 7:49 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > ; Carsey, Jaben > Subject: [Patch] Document: Update DSC spec to remove

[edk2] [RFC] Change EDK II to BSD+Patent License

Hello, This RFC follows up on the proposal from Mark Doran to change the EDK II Project to a BSD+Patent License. https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html The review period for this license change is 30 days. If there is no unresolved feedback on April 9,

Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

On Tue, 5 Mar 2019 at 17:53, Felix Polyudov wrote: > > There is an architectural difference between EndOfDxe and SmmReadyToLock > events. > It's important to have both of them. > Here is what PI specification says: > == > Transition from the environment where all of the components are under the

Re: [edk2] [PATCH 06/10] StandaloneMmPkg/Core: permit encapsulated firmware volumes

Reviewed-by: jiewen@intel.com > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Achin Gupta > ; Supreeth Venkatesh > ; Yao, Jiewen ; > Leif Lindholm ; Jagadeesh

Re: [edk2] [PATCH 07/10] StandaloneMmPkg/Core: dispatch all drivers at init time

Reviewed-by: jiewen@intel.com > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Achin Gupta > ; Supreeth Venkatesh > ; Yao, Jiewen ; > Leif Lindholm ; Jagadeesh

Re: [edk2] [PATCH 08/10] StandaloneMmPkg/Core: drop support for dispatching FVs into MM

Reviewed-by: jiewen@intel.com > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Achin Gupta > ; Supreeth Venkatesh > ; Yao, Jiewen ; > Leif Lindholm ; Jagadeesh

Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

Hi In original SMM infrastructure, there are lots of interaction that SMM has to know the DXE status. In StandaloneMm, I don't expect we have many interaction. Is there any specific example? I am totally OK to add those. And I just want to know more usage. Reviewed-by: jiewen@intel.com

Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

On Tue, 5 Mar 2019 at 16:56, Yao, Jiewen wrote: > > Hi > In original SMM infrastructure, there are lots of interaction that SMM has to > know the DXE status. > > In StandaloneMm, I don't expect we have many interaction. Is there any > specific example? > > I am totally OK to add those. And I

Re: [edk2] [PATCH v3] StandaloneMmPkg/Library: Install Variable Arch Protocol

On Tue, 5 Mar 2019 at 17:15, Yao, Jiewen wrote: > > I look at the patch. I don’t have concern. > > Please go ahead. > Thank you Jiewen, I will take that as a reviewed-by and proceed with merging the patch once the hard freeze is over. > > -Original Message- > > From: Jagadeesh Ujja

Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

On Tue, 5 Mar 2019 at 17:04, Yao, Jiewen wrote: > > OK. To keep the compatibility of existing MM driver. That makes sense. > > If it is for security, I think EndOfDxe is the only point. > ReadyToBoot and ExitBootService cannot be used for security purpose. > OK, good to know. I will keep them

Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

For current X86 world, we do use both SmmReadyToLock and EndOfDxe, for almost all X86 platform. So, let me clarify: If we try to align with PI spec, we can add EndOfDxe/ReadyToBoot/ExitBootService. If we try to align with security, we can add EndOfDxe/SmmReadyToLock. It depends upon the what

Re: [edk2] [Patch] Document: Update Build spec to remove EDK related contents

Reviewed-by: Jaben Carsey > -Original Message- > From: Feng, Bob C > Sent: Monday, March 04, 2019 9:28 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > ; Carsey, Jaben > Subject: [Patch] Document: Update Build spec to remove EDK related > contents > Importance: High >

Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

There is an architectural difference between EndOfDxe and SmmReadyToLock events. It's important to have both of them. Here is what PI specification says: == Transition from the environment where all of the components are under the authority of the platform manufacturer to the environment where

Re: [edk2] [PATCH] UefiCpuPkg\PiSmmCpuDxeSmm: Save and restore CR2 only on-demand paging in SMM BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593 For every SMI occurrence, save and restore CR2 r

Hey Thanks for the patch. Would you please follow the EDKII patch format? Please refer to https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process And https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format Thank you Yao Jiewen > -Original

Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

OK. To keep the compatibility of existing MM driver. That makes sense. If it is for security, I think EndOfDxe is the only point. ReadyToBoot and ExitBootService cannot be used for security purpose. Then do we need SmmReadyToLock ? :-) Thank you Yao Jiewen > -Original Message- > From:

Re: [edk2] [PATCH v3] StandaloneMmPkg/Library: Install Variable Arch Protocol

I look at the patch. I don’t have concern. Please go ahead. Thank you Yao Jiewen > -Original Message- > From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com] > Sent: Tuesday, March 5, 2019 6:09 AM > To: Ard Biesheuvel > Cc: Achin Gupta ; Yao, Jiewen > ; Gao, Liming ; >

[edk2] [PATCH] UefiCpuPkg\PiSmmCpuDxeSmm: Save and restore CR2 only on-demand paging in SMM BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593 For every SMI occurrence, save and restore CR2 regis

--- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c index 3b0b3b52ac..5be4a2b020 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++

Re: [edk2] [RFC] Change EDK II to BSD+Patent License

Mr. Kinney, Wow.  Of all the many licenses I’ve read, this one takes the cake at having the highest confusion to words ratio for my reading comprehension level.  I’ll admit my level is a lot lower than some on this reflector.  Maybe if I knew the intent of this license

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

Andrew: BZ 1163 is to remove inline X86 assembly code in C source file. But, this patch is wrong. I have gave my comments to update this patch. The change is to reduce the duplicated implementation. It will be good on the code maintain. Recently, one patch has to update .c and .nasm both.

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

Shenglei, I was confused by the names of these patches. From a C point of view this is inline assembly: VOID EFIAPI CpuBreakpoint ( VOID ) { __asm__ __volatile__ ("int $3"); } These patches seem to be removing GAS and MASM assembly files, but not the inline assembly *.c files? We don't want

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

Liming, I agree .nasm files replacing .S/.asm files. But the use of inline assembly in C files for some primitives does produce much smaller/faster code. I would prefer that this BZ identify the specific functions that you think would provide better maintainability with no impact to size or

Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install TemporaryRamSupport PPI

On 2019-03-04 18:37:03, Ni, Ray wrote: > > > -Original Message- > > From: edk2-devel On Behalf Of Jordan > > Justen > > Sent: Sunday, March 3, 2019 5:45 AM > > To: Ni, Ray ; edk2-devel@lists.01.org > > Subject: Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install > > TemporaryRamSupport PPI

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

> On Mar 5, 2019, at 1:32 PM, Gao, Liming wrote: > > Andrew: > BZ 1163 is to remove inline X86 assembly code in C source file. But, this > patch is wrong. I have gave my comments to update this patch. > Why do we want to remove inline X86 assembly. As I mentioned it will lead to larger

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

Hi Ashish, One thing to confirm, for the updated checks within SdMmcPciHcDriverBindingStart(): > if ((Private->ControllerVersion[Slot] == SD_MMC_HC_CTRL_VER_300 && > Private->Capability[Slot].SysBus64V3 == 0) || > (Private->ControllerVersion[Slot] == SD_MMC_HC_CTRL_VER_400 && >

Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install TemporaryRamSupport PPI

> -Original Message- > From: edk2-devel On Behalf Of Jordan > Justen > Sent: Wednesday, March 6, 2019 5:48 AM > To: Ni, Ray ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Laszlo Ersek > > Subject: Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install > TemporaryRamSupport PPI > > On

Re: [edk2] [PATCH 0/3] Xen PCI passthrough fixes

On Mon, Mar 04, 2019 at 03:04:05PM +, Igor Druzhinin wrote: > Igor Druzhinin (3): Could you also CC xen-devel please? > OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge > aperture > OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64 >

Re: [edk2] [PATCH] UefiCpuPkg/Microcode.c: Add verification before calculate CheckSum32

Reviewed-by: Ray Ni > -Original Message- > From: edk2-devel On Behalf Of Chen A > Chen > Sent: Tuesday, March 5, 2019 8:21 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [edk2] [PATCH] UefiCpuPkg/Microcode.c: Add verification before > calculate CheckSum32 > > REF: