Re: [edk2] [PATCH V5 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-28 Thread Ni, Ray
Zhichao, For a PEIM, it may not be proper to have a global variable and update that global variable during execution. Because sometimes the PEIM runs from read-only SPI flash, the global variable cannot be updated. I see you have a check against NULL when using that global variable. How about

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Change BIOS version.

2019-03-28 Thread Zailiang Sun
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zailiang Sun Cc: David Wei Cc: Yi Qian --- Vlv2TbltDevicePkg/BiosId.env | 2 +- Vlv2TbltDevicePkg/BiosIdD.env| 2 +- Vlv2TbltDevicePkg/BiosIdR.env| 2 +- Vlv2TbltDevicePkg/BiosIdx64D.env | 2 +-

[edk2] [PATCH 3/3] MdeModulePkg/UfsPassThruDxe: Add UFS info protocol

2019-03-28 Thread Albecki, Mateusz
UFS host controller specification allows for implementation specific UIC programming to take place just after host controller enable and before device detection. Since there is no way for generic driver to anticipate implementation specific programming we add a UFS info protocol which allows the

[edk2] [PATCH 2/3] MdeModulePkg/UfsPassThruDxe: Refactor UFS device presence detection

2019-03-28 Thread Albecki, Mateusz
In current implementation we are checking for device presence every time we execute UIC command. To make UfsExecUicCommands more generic checking device presence has been moved to UfsDeviceDetection. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Hao Wu Signed-off-by: Albecki

Re: [edk2] [PATCH V5 14/17] MdeModulePkg: Add definitions for EDKII DEBUG PPI

2019-03-28 Thread Ni, Ray
Zhichao, I see you added library API called DebugVPrint. Why the interface in the PPI is called DebugBPrint? What does "B" stand for? Why invent a "B" but not use "V"? > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 28, 2019 4:10 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

2019-03-28 Thread Ryszard Knop
On Wed, 2019-03-27 at 16:32 +0100, Ard Biesheuvel wrote: > On Tue, 29 Jan 2019 at 14:55, Ryszard Knop < > ryszard.k...@linux.intel.com> wrote: > > +Team > > > > As it turns out, this driver is still broken for non-1:1 mapped DMA. > > In particular, I am hitting a crash on > >

Re: [edk2] Build SCT with edk2

2019-03-28 Thread Supreeth Venkatesh
Ashish, At-least for Compiling AArch64 SCT binary, I will be sending out a series of patches today/tomorrow. We plan to have a stable edk2-test build based on edk2-stable201903 tag before UEFI Spring plugfest 2019. Thanks for

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

2019-03-28 Thread Ard Biesheuvel
On Thu, 28 Mar 2019 at 11:46, Ryszard Knop wrote: > > On Wed, 2019-03-27 at 16:32 +0100, Ard Biesheuvel wrote: > > On Tue, 29 Jan 2019 at 14:55, Ryszard Knop < > > ryszard.k...@linux.intel.com> wrote: > > > +Team > > > > > > > As it turns out, this driver is still broken for non-1:1 mapped DMA. >

[edk2] [PATCH V5 06/17] MdePkg/DxeRuntimeDebugLibSerialPort: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 04/17] MdePkg/UefidebugLibConOut: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 07/17] MdePkg/UefiDebuglibDebugPortProtocol: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH V5 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 05/17] MdePkg/UefiDebugLibStdErr: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 00/17] Add new APIs DebugVPrint for DebugLib

2019-03-28 Thread Zhichao Gao
Add a new API DebugVPrint to all the instances of DebugLib. This API is added to provide a function who want to implement special debug function with '...' parameter. Add a PEIM to install gEdkiiDebugPpiGuid, and implement a PEI debug library instance base on it. All PEIMs except pei core type can

[edk2] [PATCH V5 01/17] MdePkg/DebugLib.h: Add new APIs for DebugLib

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs DebugVPrint and DebugBPrint prototype definition in the DebugLib header file. These APIs would expose a print routine with VaList parameter and BaseList parameter. Contributed-under: TianoCore

[edk2] [PATCH V5 02/17] MdePkg/BaseDebugLibNull: Add new APIs for DebugLib

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 03/17] MdePkg/BaseDebugLibSerialPort: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 17/17] MdeModulePkg: Add PEIM and lib to dsc file

2019-03-28 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549 Add the new PEIM DebugServicePei and library instance PeiDebugLibDebugPpi to dsc file to verify it can build correctly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Jian J Wang Cc: Hao Wu Cc:

[edk2] [PATCH V5 15/17] MdeModulePkg: Add a PEIM to install Debug PPI

2019-03-28 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549 Add a PEIM to install Debug PPI so that PEI debug library instance can locate gEdkiiDebugPpiGuid to implement the debug functions. Using this PPI can reduce the size of PEIMs which consume the debug library. Contributed-under: TianoCore

[edk2] [PATCH V5 13/17] MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 14/17] MdeModulePkg: Add definitions for EDKII DEBUG PPI

2019-03-28 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549 Add a debug PPI for PEI phase. This PPI will provide basic services of debug. PEI debug lib instance can use these services to implement debug function to reduce the PEIMs which consume the debug lib. Contributed-under: TianoCore

[edk2] [PATCH V5 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-28 Thread Zhichao Gao
From: Liming Gao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549 Add a PEI debug library instance PeiDebugLibDebugPpi base on DebugPpi. Using the combination of the DebugServicePei and this lib instance can reduce the image size of PEI drivers. Contributed-under: TianoCore

[edk2] [PATCH V5 12/17] IntelFramworkModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-28 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH V5 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-28 Thread Chiu, Chasel
No change from V4. Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 28, 2019 4:10 PM > To: edk2-devel@lists.01.org > Cc: Bret Barkelew ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner >

Re: [edk2] [PATCH V5 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-28 Thread Chiu, Chasel
No change from V4. Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 28, 2019 4:10 PM > To: edk2-devel@lists.01.org > Cc: Bret Barkelew ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner >

[edk2] [PATCH 2/2] CorebootPayloadPkg: Fix non - CRLF line endings

2019-03-28 Thread Agyeman
Replaced non CRLF line endings with CRLF Cc: Maurice Ma Cc: Benjamin You Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Agyeman --- .../PlatformHookLib/PlatformHookLib.inf| 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[edk2] [PATCH 1/2] CorebootModulePkg: Fix non - CRLF line endings

2019-03-28 Thread Agyeman
Replaced non CRLF line endings with CRLF Cc: Maurice Ma Cc: Benjamin You Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Agyeman --- CorebootModulePkg/Include/Coreboot.h | 32 +- .../BaseSerialPortLib16550.c | 2178 -

[edk2] [PATCH 1/3] MdeModulePkg/UfsPassThruDxe: Fix unaligned data transfer handling

2019-03-28 Thread Albecki, Mateusz
Since UFS spcification requiers the data buffer specified in PRDT to be DWORD aligned in size we had a code in UfsInitUtpPrdt that aligned the data buffer by rounding down the buffer size to DWORD boundary. This meant that for SCSI commands that wanted to perform unaligned data transfer(such as

[edk2] [PATCH 0/3] Implement UFS info protocol to pass additional UIC programming data from platform/silicon specific driver

2019-03-28 Thread Albecki, Mateusz
UFS specification allows for additional, implementation specific, programming to be done during host controller initialization. Since some hosts might require it to allow for device detection we add a way for platform/silicon specific code to pass required attributes and their values to generic

[edk2] [edk2-test][PATCH v1 08/30] RIVL/Protocol: Fix inf files for InternetProtocol4 tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../InternetProtocol4/Ip4/Ip4ENTSTest.inf | 30 +- .../Ip4Config/Ip4ConfigENTSTest.inf

[edk2] [edk2-test][PATCH v1 13/30] RIVL/Protocol: fix inf file for PXE protocol test.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../PXEBaseCode/PXEBaseCodeENTSTest.inf | 31 +-- 1 file changed, 15 insertions(+), 16

[edk2] [edk2-test][PATCH v1 14/30] RIVL/Protocol: Fix inf files for Simple Network protocol test.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../SimpleNetwork/SimpleNetworkENTSTest.inf | 31 +-- 1 file changed, 15 insertions(+), 16

[edk2] [edk2-test][PATCH v1 15/30] RIVL/Protocol: Fix inf files for Tcp4 protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../RIVL/Protocol/Tcp4/Tcp4/Tcp4ENTSTest.inf | 31 +-- .../Tcp4ServiceBindingENTSTest.inf

[edk2] [edk2-test][PATCH v1 16/30] RIVL/Protocol: Fix inf file for Tcp6 protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../RIVL/Protocol/Tcp6/Tcp6/Tcp6ENTSTest.inf | 30 +-- .../Tcp6ServiceBindingENTSTest.inf

[edk2] [edk2-test][PATCH v1 19/30] BootServices: Fix inf files for ImageServices dependency data files.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/Dependency/InvalidImage1/InvalidImage1.inf | 2 ++

[edk2] [edk2-test][PATCH v1 24/30] UEFI/Protocol: Remove struct and enum in Hii defines file.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in definition file when compiled against edk2 stable tag edk2-stable201903 to avoid mutliple definitions of structures and enumerations which conflict with MdePkg definitions. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh ---

Re: [edk2] [PATCH V5 14/17] MdeModulePkg: Add definitions for EDKII DEBUG PPI

2019-03-28 Thread Gao, Zhichao
B stand for BASE_LIST, we use B instead of V because of compatible issue. For VA_LIST, it may be a pointer or a structure depend on the compiler. If some PEIMs consume V version function and it is compiled by a different compiler, they may catch these issue. Thanks, Zhichao > -Original

[edk2] [edk2-test][PATCH v1 20/30] EFI/Protocol: Fix inf file for DebugSupport protocol test.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/DebugSupportBBTest.inf | 30 +-- 1 file changed, 14 insertions(+), 16

[edk2] [edk2-test][PATCH v1 22/30] EFI/Protocol: Fix inf files for DevicePath related protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/DevicePathBBTest.inf | 32

[edk2] [edk2-test][PATCH v1 23/30] EFI/Protocol: Fix inf files for HII related protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/HIIConfigAccessBBTest.inf| 30

[edk2] [edk2-test][PATCH v1 28/30] EFI/Protocol: Fix inf file for PxeBase dependency data.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../PxeBaseCode/BlackBoxTest/Dependency/Config/Config.inf | 2 ++ 1 file changed, 2 insertions(+)

[edk2] [edk2-test][PATCH v1 07/30] RIVL/Protocol: Fix inf files for Http protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../RIVL/Protocol/Http/Http/HttpENTSTest.inf | 31 +-- .../HttpServiceBindingENTSTest.inf

[edk2] [edk2-test][PATCH v1 18/30] RIVL/Protocol: Fix inf files for Udp6 protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../RIVL/Protocol/Udp6/Udp6/Udp6ENTSTest.inf | 31 +-- .../Udp6ServiceBindingENTSTest.inf

[edk2] [edk2-test][PATCH v1 21/30] EFI/Protocol: Fix inf files for Decompress protocol dependency data.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/Dependency/CompressedFile1/CompressedFile1.inf | 2 ++

[edk2] [edk2-test][PATCH v1 26/30] EFI/Protocol: Fix inf files for Pci protocol related dependency data.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../Protocol/PciIo/BlackBoxTest/Dependency/Config/Config.inf | 3 ++-

[edk2] [edk2-test][PATCH v1 27/30] EFI/Protocol: Fix inf file for LoadedImage protocol test.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/LoadedImageBBTest.inf| 27 ++- 1 file changed, 14 insertions(+), 13

[edk2] [edk2-test][PATCH v1 09/30] RIVL/Protocol: Fix inf files for Ip6 tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../InternetProtocol6/Ip6/Ip6ENTSTest.inf | 32 - .../Ip6Config/Ip6ConfigENTSTest.inf

[edk2] [edk2-test][PATCH v1 10/30] RIVL/Protocol: Fix inf files for Managed network protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../ManagedNetwork/MNP/MnpENTSTest.inf| 30 +--

[edk2] [edk2-test][PATCH v1 11/30] RIVL/Protocol: Fix inf files for Mtftp4 protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../Protocol/Mtftp4/Mtftp4/Mtftp4ENTSTest.inf | 31 +-- .../Mtftp4ServiceBindingENTSTest.inf

[edk2] [edk2-test][PATCH v1 12/30] RIVL/Protocol: Fix inf files for Mtftp6 protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../Protocol/Mtftp6/Mtftp6/Mtftp6ENTSTest.inf | 30 +- .../Mtftp6ServiceBindingENTSTest.inf

[edk2] [edk2-test][PATCH v1 17/30] RIVL/Protocol: Fix inf files for Udp4 protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../RIVL/Protocol/Udp4/Udp4/Udp4ENTSTest.inf | 31 +-- .../Udp4ServiceBindingENTSTest.inf

[edk2] [edk2-test][PATCH v1 25/30] EFI/Protocol: Fix inf files for SimpleText protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/SimpleTextInBBTest.inf | 27 -

[edk2] [edk2-test][PATCH v1 29/30] EFI/Protocol: Fix inf file for SimpleFileSystem protocol test.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/SimpleFileSystemBBTest.inf | 29 +++ 1 file changed, 17 insertions(+), 12

[edk2] [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protocol GUIDs in declaration file.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- uefi-sct/SctPkg/UEFI/UEFI.dec | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

2019-03-28 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ray > Sent: Thursday, March 28, 2019 6:50 PM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some > unused Guids > Importance: High > >

Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib

2019-03-28 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Friday, March 29, 2019 9:41 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib > > With Itanium architecture unsupported,

Re: [edk2] [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

2019-03-28 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Friday, March 29, 2019 9:41 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused > Guids > > ExtendedSalBootService.h,

Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib

2019-03-28 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ray > Sent: Thursday, March 28, 2019 6:50 PM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib > Importance: High > > Reviewed-by: Ray Ni > > >

[edk2] [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h

2019-03-28 Thread Shenglei Zhang
Mps.h is included in BdsPlatform.h but not actually used. So remove it. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 1 - 1 file changed,

Re: [edk2] [PATCH 00/10] Remove .S files for IA32 and X64 arch in MdePkg and UefiCpuPkg

2019-03-28 Thread Gao, Liming
Shenglei: There are still .S files in SourceLevelDebugPkg\Library\ and CryptoPkg\Library\IntrinsicLib directory. Please remove them. After remove them, please take https://bugzilla.tianocore.org/show_bug.cgi?id=881 to update nasm source code for XCODE optimization. Thanks Liming

[edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib

2019-03-28 Thread Shenglei Zhang
With Itanium architecture unsupported, gEfiSalSystemTableGuid and gEfiMpsTableGuid will be no longer used. https://bugzilla.tianocore.org/show_bug.cgi?id=1560 Cc: Jaben Carsey Cc: Ray Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

2019-03-28 Thread Shenglei Zhang
ExtendedSalBootService.h, ExtendedSalServiceClasses.h and McaInitPmi.h will be deleted. So remove the Guids defined in these Protocols. And also remove strings in uni file. https://bugzilla.tianocore.org/show_bug.cgi?id=1560 Cc: Jaben Carsey Cc: Ray Ni Contributed-under: TianoCore Contribution

[edk2] [PATCH 0/4] Remove IPF and related code

2019-03-28 Thread Shenglei Zhang
Itanium arch is not supported any longer. So remove IPF and related code. https://bugzilla.tianocore.org/show_bug.cgi?id=1560 Cc: Jaben Carsey Cc: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Shenglei Zhang (4):

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Change BIOS version.

2019-03-28 Thread Qian, Yi
Reviewed by Qian Yi Thanks Qian Yi > -Original Message- > From: Sun, Zailiang > Sent: Thursday, March 28, 2019 8:42 PM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Qian, Yi > Subject: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] > Vlv2TbltDevicePkg: Change BIOS version. > >

[edk2] [edk2-test][PATCH v1 03/30] IHV/Protocol: Fix inf files for IHV protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/IhvDevicePathBBTest.inf | 25 +++--- .../IhvSimpleFileSystemBBTest.inf

[edk2] [edk2-test][PATCH v1 04/30] RIVL/Protocol: Fix inf files for RIVL Arp protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../Arp/ArpENTSTest.inf | 30 +-- .../ArpServiceBindingENTSTest.inf

[edk2] [edk2-test][PATCH v1 06/30] RIVL/Protocol: Fix inf files for Dhcp6 protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../Protocol/Dhcp6/Dhcp6/Dhcp6ENTSTest.inf| 31 +--

[edk2] [edk2-test][PATCH v2] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2019-03-28 Thread Supreeth Venkatesh
From: Lokesh B V Some windows editors uses "\r\n" for line feed. While processing uefi sct testcase info file, the GenBin tool logic to skip line feed doesn't consider the presence of carraige return(\r) in line feed. So this results in incorrect format error. Fixed this issue by changing logic

[edk2] [edk2-test][PATCH v1 01/30] SctPkg/UEFI: Modify description files to ignore Ebc for AArch64.

2019-03-28 Thread Supreeth Venkatesh
1. Ignore Ebc protocol test cases for AArch64 temporarily. 2. Fix AARCH64_CC_FLAGS to remove direct inclusion of MdePkg/Include. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 18 --

[edk2] [edk2-test][PATCH v1 02/30] SctPkg: Ignore Ebc protocol test for AArch64.

2019-03-28 Thread Supreeth Venkatesh
1. Modify build scripts to ignore Ebc protocol tests temporarily. 2. Cosmetic changes to fix the text when sct is generated to correctly identify "UEFI SCT" and "IHV SCT". 3. Remove SctGuildLib as it is unused. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth

[edk2] [edk2-test][PATCH v1 05/30] RIVL/Protocol: Fix inf files for Dhcp4 protocol tests.

2019-03-28 Thread Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable tag edk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../Protocol/Dhcp4/Dhcp4/Dhcp4ENTSTest.inf| 30 +--

[edk2] [PATCH v6] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-03-28 Thread nkvangup
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593 For every SMI occurrence, save and restore CR2 register only when SMM on-demand paging support is enabled in 64 bit operation mode. This is not a bug but to have better improvement of code. Patch5 is updated with separate functions for Save

Re: [edk2] [PATCH v6] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-03-28 Thread Ni, Ray
> + if ((!mCpuSmmStaticPageTable) && (Cr2 != 0)) { Can the "Cr2 != 0" be removed? > -Original Message- > From: edk2-devel On Behalf Of > nkvangup > Sent: Friday, March 29, 2019 12:58 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric ; > Laszlo Ersek > Subject: [edk2]

[edk2] [PATCH] BaseTools:Coding problems caused by special characters

2019-03-28 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1670 During BaseTools compiling under Chinese or Japanese language Windows, python exception occurring. UnicodeDecodeError: 'ascii' codec can't decode byte 0xbd in position 3528: ordinal not in range(128) Cc: Bob Feng Cc: Liming Gao

Re: [edk2] [PATCH V5 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-28 Thread Gao, Zhichao
You are right. I didn't think about that. And I have change the variable to local and tested on open MinPlatform (Kabylake RVP3). It works fine. And also global variable make the system hang. Thanks, Zhichao > -Original Message- > From: Ni, Ray > Sent: Thursday, March 28, 2019 6:11 PM >

Re: [edk2] [PATCH v5] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-03-28 Thread Vanguput, Narendra K
Thanks Mike for the comments! I updated and send as PATCH v6. Please review. Thanks, Narendra > -Original Message- > From: Kinney, Michael D > Sent: Saturday, March 23, 2019 12:44 AM > To: Vanguput, Narendra K ; edk2- > de...@lists.01.org; Kinney, Michael D > Cc: Yao, Jiewen ; Dong,

Re: [edk2] [PATCH] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

2019-03-28 Thread Ni, Ray
Guo, Just to double confirm: UefiPayloadPkg will not require Legacy8254 timer support. The old packages Coreboot*Pkgs will be removed. Which means now only QEMU/OVMF needs the Legacy8254 support. Laszlo, Now since QEMU/OVMF is the only consumer of the Legacy8254 driver, do you agree that the

Re: [edk2] Build SCT with edk2

2019-03-28 Thread Udit Kumar
> It seems building SCT is supported with edk2 UDK2017 and not something SCT build fails on UDK2017 as well Below is patch suggested by Supreet with UDK2017 tmp/sct_workspace/edk2$ git diff diff --git a/BaseTools/Source/C/Makefiles/app.makefile b/BaseTools/Source/C/Makefiles/app.makefile