-
From: Justen, Jordan L
Sent: Tuesday, July 28, 2015 2:33 AM
To: Bi, Dandan; Dong, Eric; Gao, Liming; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup
browser pop-up message box
On 2015-07-26 23:57:27, Bi, Dandan wrote:
.../Universal
: Monday, July 27, 2015 2:31 PM
To: Bi, Dandan; Dong, Eric; Gao, Liming; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup
browser pop-up message box
On 2015-07-26 22:19:04, Dandan Bi wrote:
When load default value or save changes will pop up message box
To: Bi, Dandan <dandan...@intel.com>; edk2-de...@ml01.01.org
Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>
Subject: Re: [edk2] [patch 0/2] Connect all devices in UiApp if needed
On 06/16/16 03:37, Dandan Bi wrote:
> Do the connect all action in UiApp i
Reviewed-by: Dandan Bi <dandan...@intel.com>
-Original Message-
From: Zhang, Chao B
Sent: Thursday, June 16, 2016 2:26 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com>
Subject: [PATCH] SecurityPkg: SecurityPk
Hi Laszlo,
Thanks for your comments. I will update the related package.dsc files, and new
patch series will send out later.
Thanks,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, February 1, 2016 5:22 PM
To: Bi, Dandan
Cc: Zhang, Chao B; Dong
Reviewed-by: Dandan Bi <dandan...@intel.com>
-Original Message-
From: Zhang, Chao B
Sent: Friday, January 29, 2016 4:47 PM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Bi, Dandan; Zhang, Chao B
Subject: [PATCH] SecurityPkg: TcgConfigDxe: Move TPM state string update to
CallBack fu
1:45 PM
To: Bi, Dandan; Dong, Eric; ler...@redhat.com; edk2-devel@lists.01.org
Subject: RE: [patch 6/6] SecurityPkg:Use FileExplorerLib in SecureBootConfigDxe
Dandan:
1. The copyright head file change is not right.
2. Do we need to update NT32Pkg.dsc & Quark Platform dsc?
Other changes
Hi Cecil,
I have some comments for this patch:
For EFI_HII_IMAGE_DECODER_PROTOCOL:
(1) There is a typo, it is EFI_HII_IMAGE_DECODER_PROTOCOL not
EFI_HII_IMAGE_DECO(R)DER_PROTOCOL, please double check to remove all the
incorrect case.
(2) EFI_HII_IMAGE_DECODER_PROTOCOL_GUID is not
PM
To: Bi, Dandan; edk2-de...@ml01.01.org
Cc: Ard Biesheuvel; Dong, Eric
Subject: Re: [patch] ArmVirPkg: Add FileExplorerLib.inf to the dsc file
Dandan,
On 02/25/16 08:26, Dandan Bi wrote:
> Because SecureBootConfigDxe use FileExplorerLib now, but
> FileExplorerLib is not in the ds
Hi Liming,
Thanks for your comments! I will refine the patch and new version will send out
later.
Thanks,
Dandan
-Original Message-
From: Gao, Liming
Sent: Monday, February 22, 2016 5:52 PM
To: Bi, Dandan; edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: RE: [patch 2/2] MdeModulePkg
Hi Laszlo,
Thank you very much for giving me the comment and information! I will pay
attention to this!
Thanks,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, February 22, 2016 6:18 PM
To: Bi, Dandan; edk2-de...@ml01.01.org
Cc: Gao, Liming; Dong
Reviewed-by：Dandan Bi <dandan...@intel.com>
-Original Message-
From: Kinney, Michael D
Sent: Thursday, January 21, 2016 9:31 AM
To: edk2-devel@lists.01.org
Cc: Steele, Kelly; Bi, Dandan
Subject: [Patch] QuarkPlatformPkg/Quark.dsc: Update for rename of UI libraries
Rename
...@redhat.com]
Sent: Monday, March 21, 2016 4:29 PM
To: Gary Lin <g...@suse.com>; edk2-de...@ml01.01.org
Cc: Bi, Dandan <dandan...@intel.com>
Subject: Re: [edk2] [PATCH] SecurityPkg/SecureBootConfigDxe: Declare EFIAPI for
the ChooseFile handlers
Hi Gary,
On 03/21/16 09:00, Ga
For the series:
Reviewed-by: Dandan Bi <dandan...@intel.com>
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Monday, March 21, 2016 5:05 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Laszlo Ersek <ler...@redhat.com>
Subject: [PATC
Hi Laszlo,
Please help to commit these patches. Thanks!
Thanks,
Dandan
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Thursday, March 24, 2016 11:29 AM
To: Bi, Dandan <dandan...@intel.com>
Cc: edk2-de...@ml01.01.org; Laszlo Ersek <ler...@redhat.com>
Subjec
PM
To: Bi, Dandan <dandan...@intel.com>; edk2-de...@ml01.01.org
Cc: Qiu, Shumin <shumin@intel.com>; Dong, Eric <eric.d...@intel.com>;
Zhang, Chao B <chao.b.zh...@intel.com>
Subject: Re: [edk2] [PATCH v2] SecurityPkg: SecureBootConfigDxe: Enhance the
code logic
On 0
-
From: Sheng, Cecil (HPS SW) [mailto:cecil.sh...@hpe.com]
Sent: Wednesday, March 2, 2016 10:58 AM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>
Subject: RE: [edk2] [PATCH] MdePkg: Add UEFI2.6 HII
Hi Cecil,
I have some comments for this patch.
1. For HiiFontEx.h
(1) The members name in the structure of _EFI_HII_FONT_EX_PROTOCOL are not
consistent with spec:
In spec :
typedef struct _EFI_HII_FONT_EX_PROTOCOL {
EFI_HII_STRING_TO_IMAGE_EX
Liming:
Thanks for your comments! I will update the code and send a new version later.
Thanks,
Dandan
-Original Message-
From: Gao, Liming
Sent: Monday, April 25, 2016 3:22 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.d...@intel.com>
: [edk2] [patch] MdeModulePkg/DisplayEngine: Fix memory leak issues in
DisplayEngine
Cc: Qiu Shumin <shumin@intel.com>
Cc: Eric Dong <eric.d...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan...@intel.com>
Reviewed-by
cripts\PatchCheck.py) to check the patch.
Others are good to me.
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer
El-Haj-Mahmoud
Sent: Thursday, May 12, 2016 4:29 AM
To: edk2-de
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer
El-Haj-Mahmoud
Sent: Thursday, May 12, 2016 4:31 AM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D <michael.d.kin...@
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, July 19, 2016 10:27 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>
Subject: [PATCH] ShellPkg: Fix VS2010/2012 build failure
Contributed-unde
Of Jordan
Justen
Sent: Wednesday, February 8, 2017 2:49 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Laszlo Ersek <ler...@redhat.com>; Gao, Liming <liming@intel.com>
Subject: Re: [edk2] [patch] OvmfPkg/QemuBootOrderLib: Fix NOOPT build failure
On 2017-02-07 2
fix this issue.
https://bugzilla.tianocore.org/show_bug.cgi?id=358
Cc: Eric Dong <eric.d...@intel.com>
Cc: Liming Gao <liming@intel.com>
Cc: Wang Cloud <winggundu...@163.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan...@in
Our codes have already checked for "too few " case, and it will print " Too few
arguments" in this situation.
Thanks,
Dandan
-Original Message-
From: Carsey, Jaben
Sent: Thursday, September 1, 2016 12:12 AM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@
Ok! Thank you for your comments! I will send patch with V2 for review.
Thanks,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, September 22, 2016 9:07 AM
To: Bi, Dandan <dandan...@intel.com>
Cc: edk2-de...@ml01.01.org; Justen, Jo
Reviewed-by: Dandan Bi <dandan...@intel.com>
-Original Message-
From: Gao, Liming
Sent: Wednesday, September 21, 2016 10:39 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric <eric.d...@intel.com>; Bi, Dandan <dandan...@intel.com>
Subject: [Patch 2/3] MdeModulePkg HiiDatab
Reviewed-by: Dandan Bi <dandan...@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, September 21, 2016 10:39 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Dong, Eric <eric
Yes! I will correct them and send a V2 patch.
Thanks,
Dandan
-Original Message-
From: Long, Qin
Sent: Thursday, November 10, 2016 4:25 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Subject: RE: [patch] CryptoPkg/BaseCryptLib: Make comments cons
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, October 20, 2016 9:50 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Fu, Siyuan <siyuan...@intel.com>
Subject: [Patch] NetworkPkg: C
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Thursday, October 20, 2016 10:01 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>
Subject: [
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, October 20, 2016 10:01 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>
Subject: [PATCH 3/3] MdeModulePkg/HiiDatabaseDxe.inf: Correct the
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, October 25, 2016 10:18 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>
Subject: [PATCH v2 2/3] MdeModulePkg/GraphicsOutputDxe.inf: Correct the
p
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, November 15, 2016 9:57 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>
Subject: [PATCH] ShellPkg: #ifndef of header files should have postfix
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng Tian
Sent: Tuesday, November 15, 2016 1:10 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>
Subject: [
Got it ! I will enhance the logic! Thanks!
Regards,
Dandan
From: Yao, Jiewen
Sent: Friday, November 25, 2016 10:01 AM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Pete Batard <p...@akeo.ie>
Subject: RE: [patch] MdeModulePkg: Fix GCC build failure
Thanks
I a
ecurityPkg driver.
Thanks
Liming
-Original Message-
From: Bi, Dandan
Sent: Thursday, November 17, 2016 10:26 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming@intel.com>; Dong, Eric <eric.d...@intel.com>; Yao,
Jiewen <jiewen@intel.com>; Tian, Feng <feng
Yes, that's right! I will update it. Thanks!
Thanks,
Dandan
-Original Message-
From: Yao, Jiewen
Sent: Monday, November 21, 2016 9:29 AM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen@intel.com>
Subject: RE: [edk2] [patch]
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Zhang, Chao B
Sent: Friday, October 21, 2016 1:25 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Long, Qin <qin.l...@intel.com>; Zhang,
Chao B <chao.b.zh.
Reviewed-by: Dandan Bi <dandan...@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Thursday, December 8, 2016 4:17 PM
To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu...@intel.com>
Cc: Ard Biesheuvel
...@linaro.org]
Sent: Thursday, December 15, 2016 7:41 PM
To: Bi, Dandan <dandan...@intel.com>
Cc: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu...@intel.com>
Subject: Re: [patch 2/2] MdeModulePkg/NonDiscoverablePciDevice: Make variable
definition follow rule
On 15 December 2016 at 07:1
Yes, I will do the enhancements base on the latest codes and re-send patches.
Thanks,
Dandan
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, December 15, 2016 3:46 PM
To: Bi, Dandan <dandan...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com&
Got it ! I will submit a new patch. Thanks!
Regards,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Friday, December 9, 2016 8:58 AM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Subject: RE: [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after
decla
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang,
Chao B
Sent: Thursday, January 5, 2017 10:18 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Z
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Monday, January 9, 2017 10:06 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.z...@intel.com>; Bi, Dandan <dandan...@intel.com>; Yao,
Jiewen <jiewen@inte
Reviewed-by: Dandan Bi <dandan...@intel.com>
-Original Message-
From: Zhang, Chao B
Sent: Thursday, April 6, 2017 3:21 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com>
Subject: [PATCH] SecurityPkg: SecureBoo
Hi Liming,
It seems no need to change the comments in the implementation codes.
The comments in the implementation codes are correct.
Thanks,
Dandan
-Original Message-
From: Gao, Liming
Sent: Tuesday, March 14, 2017 12:23 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.
Star, thanks for detecting that. Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Thursday, June 29, 2017 10:45 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu
When the driver is loaded, LoadImage() installs EFI_HII_PACKAGE_LIST_PROTOCOL on
the image handle if the image contains HII resource.
So you can get the image package list through HiiPackageListProtocol,
And then add the image package list to HII database through NewPackageList API
in Database
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 5, 2017 2:49 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>
Subject: RE: [RFC v2 1/2] BaseTool/VfrCompile: Support Union t
Hi Ray,
I can update the logic in VfrCompiler to avoid using gUnionTypeStructure. New
patches will send out.
Thanks for your comments.
Regards,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 5, 2017 10:35 AM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.
Yes. I will remove it before checking in the codes. Thanks.
Regards,
Dandan
-Original Message-
From: Zeng, Star
Sent: Monday, June 19, 2017 12:55 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu...@intel.com>; Gao, Liming <liming@i
aeu...@outlook.com>; edk2-devel@lists.01.org
Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming
<liming....@intel.com>; Bi, Dandan <dandan...@intel.com>
Subject: RE: [PATCH v1] MdePkg: Add definitions for the SPI protocols
introduced in UEFI PI 1.6.
Marvin,
Thank y
Hi Laszlo,
When do you plan to push this patch? IA32 build is blocked for this issue now.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Sunday, September 10, 2017 8:13 AM
To: edk2-devel-01
Hi Wim Vervoorn,
Thanks for reporting this issue. It's a bug of current code and your solution
can fix it correctly.
But when the storage is NameValueType, for string opcode, current code also
calculate the string length incorrectly, the length should not include the
trailing terminator and
Hi Wim Vervoorn,
Current behavior of HiiSetToDefaults():
1. For Question has the specified type default value, will set the default
value to storage for the Question.
2. For Question without the specified type default, other type default value
can be shared.(such as: standard default doesn't
will be untouched with this call.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wim
Vervoorn
Sent: Friday, August 25, 2017 5:08 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Subject: Re: [edk2] HiiSetToDefaults be
LfReadData;
3. You could use patch check tool in BaseTools/Scripts/PatchCheck.py to verify
the format of your updates.
Thanks,
Dandan
-Original Message-
From: Bi, Dandan
Sent: Friday, September 15, 2017 4:22 PM
To: Ni, Ruiyu <ruiyu...@intel.com>; Marvin Häuser <ma
Reviewed-by: Bi Dandan <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Chen, Chen A
Sent: Tuesday, October 10, 2017 10:09 AM
To: edk2-devel@lists.01.org
Cc: Chen, Chen A <chen.a.c...@intel.com>; Bi, Dandan <dandan...@intel.com>;
Zhang, Chao B <c
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J
Wang
Sent: Thursday, November 23, 2017 9:19 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Dong,
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Friday, December 1, 2017 9:20 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.z...@intel.com>; Bi, Dandan <dandan...@intel.com>; Yao,
Jiewen <jiewen@intel
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thank you,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin
Häuser
Sent: Tuesday, October 31, 2017 8:12 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu...@intel.com>
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Wednesday, November 8, 2017 10:12 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming@intel.com>; Bi, Dandan <dandan...@intel.com>
Subj
Hi Star,
Thanks for your comments.
Yes, you are right. I will update the patch based on your comments.
Regards,
Dandan
-Original Message-
From: Zeng, Star
Sent: Friday, November 3, 2017 2:04 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric &
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Monday, November 6, 2017 8:51 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.z...@intel.com>; Bi, Dandan <dandan...@intel.com>; Yao,
Jiewen <jiewen@intel
Hi Pankaj Bansal,
Current SPI header files follow PI 1.6 Spec, if you find any issue in PI spec,
current process is to raise them to PIWG for discussion firstly, then PIWG will
discuss the issue and decide whether update the spec, at last update the code
if needed.
Thanks,
Dandan
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Tuesday, December 12, 2017 4:16 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.z...@intel.com>; Bi, Dandan <dandan...@intel.com>; Yao,
Jiewen <jiewen..
Thanks for your test work.
I have created a V2 patch which make the code logic more clean. Would you mind
to try the V2 patch in your environment?
Thanks,
Dandan
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Wednesday, May 9, 2018 10:32 AM
To: Bi, Dandan <dan
Hi Ray,
Thanks for your suggestion. But we have committed this patch yesterday. :(
I will pay more attention to the commit message in the future work.
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, May 10, 2018 11:34 AM
To: Gary Lin <g...@suse.com>; Bi,
Yes. We have submitted patch to fix it. Sorry for the inconvenience.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin
Sent: Tuesday, May 8, 2018 5:46 PM
To: Bi, Dandan <dandan...@intel.com>
Cc: edk2-devel@lists.01.org
to be handled in PEI phase(32bit), that's the main reason why
we allocate it below 4G.
Thanks,
Dandan
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, May 2, 2018 12:27 AM
To: Bi, Dandan <dandan...@intel.com>; Leif Lindholm <l
Reviewed-by: Dandan Bi <dandan...@intel.com>
And these changes are in SecurityPkg not MdePkg.
Please update the package name in the subject of the patch before commit.
Thanks,
Dandan
-Original Message-
From: Dong, Eric
Sent: Tuesday, May 22, 2018 1:51 PM
To: edk2-devel@lists.01.
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Dong, Eric
Sent: Tuesday, May 22, 2018 1:51 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>
Subject: [Patch 1/2] MdePkg/TcgStorage*.h: Fixed ECC reported issues.
C
; edk2-devel@lists.01.org; Gao, Liming
<liming....@intel.com>; Bi, Dandan <dandan...@intel.com>; Leif Lindholm
<leif.lindh...@linaro.org>; Kinney, Michael D <michael.d.kin...@intel.com>;
Zeng, Star <star.z...@intel.com>
Subject: Re: [edk2] [PATCH v2 4/
Mem(), the value may be
non-zero. That's the difference. It may impact the code to parse the table.
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Friday, May 25, 2018 10:45 AM
To: Bi, Dandan <dandan...@intel.com>; Ard Biesheuvel
<ard.biesheu...@linaro.org>; La
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 11, 2018 10:37 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure
The patch doesn't have functionality impact
Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Alexei
Fedorov
Sent: Tuesday, June 05, 2018 5:13 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Carsey, Jaben ; Ni, Ruiyu
Subject: Re: [edk2] [patch 2/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC
issues
Hi
Reviewed-by: Dandan Bi
Thanks for helping fix it.
Thanks,
Dandan
-Original Message-
From: dann frazier [mailto:da...@debian.org]
Sent: Wednesday, June 27, 2018 6:05 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Gao, Liming ; Ni,
Ruiyu
Subject: [PATCH] ShellPkg/dp: Correct case
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 2, 2018 4:57 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Gao, Liming ; Zeng,
Star
Subject: [edk2] [PATCH] MdeModulePkg
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 2, 2018 5:42 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Bi, Dandan ; Zeng,
Star
Subject: [edk2] [PATCH] MdeModulePkg
**/
VOID
EFIAPI
AsmWriteTr (
IN UINT16 Selector
);
With this update, Reviewed-by: Dandan Bi <dandan...@intel.com>
Regards,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Monday, December 25, 2017 9:07 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Monday, December 25, 2017 9:07 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Zeng, Star <star.z...@intel.com>; Dong,
Eric <eric.d...@intel
Hi Jian,
Could you add the "string" keyword before the string token when you commit the
patch. You can refer to other codes in the uni file.
With this update, Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Mon
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Monday, December 25, 2017 9:07 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Dong, Eric <eric.d...@intel.com>; Laszlo
Ersek <ler...@redhat
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Wang, Fan
Sent: Monday, December 25, 2017 10:46 AM
To: edk2-devel@lists.01.org
Cc: Wang, Fan <fan.w...@intel.com>; Bi, Dandan <dandan...@intel.com>
Subject: [Patch] MdeModulePkg/Net
Hi,
(1) If you want the string can only be set with the one in STR_STRING_CHECK,
you can add following codes within the string opcode:
inconsistentif prompt = STRING_TOKEN(STR_INVALID_IQN),
pushthis != stringref(STRING_TOKEN(STR_STRING_CHECK))
endif;
(2) If you want
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Thursday, January 11, 2018 9:02 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Dong, Eric <eric.d...@intel.com>; Laszlo
Ersek <ler...@redhat
, Star
Sent: Thursday, January 25, 2018 12:59 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Dong,
Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>; Zeng, Star
<star.z
patches if I need to reference it.
Thanks,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, January 24, 2018 11:45 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming
Reviewed-by: Dandan Bi <dandan...@intel.com>
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang,
Chao B
Sent: Saturday, February 3, 2018 11:12 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan...@intel.com>; Z
Thank you star. I will update them before committing the patches.
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Friday, February 9, 2018 4:31 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric
Thank you star. I will add comment before commit the patch.
Regards,
Dandan
-Original Message-
From: Zeng, Star
Sent: Wednesday, February 7, 2018 9:45 AM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek (ler..
Hi Laszlo,
Thanks for your comments. I will update the commit message.
Regards,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, February 7, 2018 4:17 PM
To: Zeng, Star <star.z...@intel.com>; Bi, Dandan <dandan...@intel.com>;
edk2
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zhang, Chao B
Sent: Saturday, July 28, 2018 1:35 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [Patch] SecurityPkgDSC: Fix 2 DSC build error
Error is caused by SHA384/SHA512 hash lib change in.
Cc: Bi Dandan
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 30, 2018 5:45 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Bi, Dandan
; Gao, Liming ; Zeng, Star
; Chen, Hesheng
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Thursday, July 26, 2018 6:17 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Yao, Jiewen ; Bi,
Dandan
Subject: [PATCH 1/6] MdeModulePkg CapsuleApp: Fix VS2012 build failure caused
by 5410502
The build
Hi Prabin,
Here is a simple introduction of current performance infrastructure in latest
Edk2 code base.
Hope it can have some help when you enable it.
https://github.com/dandanbi/edk2/wiki/Performance-Infrastructure
Thanks,
Dandan
-Original Message-
From: edk2-devel
this one.
Sorry for any inconvenience.
Thanks,
Dandan
From: Alexei Fedorov [mailto:alexei.fedo...@arm.com]
Sent: Monday, July 30, 2018 4:28 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Carsey, Jaben
Subject: Re: [patch 3/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS build
failure
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Monday, August 6, 2018 2:30 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH] ShellPkg/acpi: Fix XCODE5 X64 build failure
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off
1 - 100 of 147 matches
Mail list logo
