Re: [edk2] HII incompatibility between edk2 and iPXE?

On 15/04/16 12:00, Gao, Liming wrote: In UI, the question is shown to user, such as checkbox, oneof, orderlist, password. One HII driver exposes multiple questions. Those questions may refer to one buffer storage. For this usage, the C structure can be used as the buffer storage. Each

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 14/04/16 15:24, Andrew Fish wrote: It is hard to argue that using Hii to do simple things is kind of complex and hard to Grok. Not really. Three people on this list (myself, Laszlo, and Eric) all managed to independently make the exact same mistake. Either we're all incompetent, or

Re: [edk2] HII incompatibility between edk2 and iPXE?

. Thanks Liming From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Brown Sent: Thursday, April 14, 2016 7:47 PM To: Gao, Liming; Dong, Eric; Laszlo Ersek; Bi, Dandan Cc: Justen, Jordan L; edk2-devel-01; Ard Biesheuvel Subject: Re: [edk2] HII incompatibility between edk2

Re: [edk2] HII incompatibility between edk2 and iPXE?

> On Apr 14, 2016, at 4:23 AM, Michael Brown wrote: > > On 13/04/16 15:55, Andrew Fish wrote: >>> OK, but why? What is the concrete purpose of this, that could not be >>> achieved by more simply having multiple EFI_HII_CONFIG_ACCESS_PROTOCOL >>> instances? >> >> I think it

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 13/04/16 17:04, Gao, Liming wrote: UEFI spec Chapter 31 Human Interface Infrastructure Overview and Chapter section 2 Design discussion and Chapter 33 HII Configuration Processing and Browser Protocol section 2 Configuration Strings gives the details on UEFI HII design and Configuration

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 13/04/16 15:55, Andrew Fish wrote: OK, but why? What is the concrete purpose of this, that could not be achieved by more simply having multiple EFI_HII_CONFIG_ACCESS_PROTOCOL instances? I think it has to do with the limitation of one protocol per handle. If there are multiple instances

Re: [edk2] HII incompatibility between edk2 and iPXE?

: Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-devel-01 <edk2-de...@ml01.01.org>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: Re: [edk2] HII incompatibility between edk2 and iPXE? On 13/04/16 03:33, Dong, Eric wrote: >>>> Does the ConfigHdr hav

Re: [edk2] HII incompatibility between edk2 and iPXE?

> On Apr 13, 2016, at 3:51 AM, Michael Brown wrote: > > On 13/04/16 03:33, Dong, Eric wrote: > Does the ConfigHdr have any meaning for EFI_HII_CONFIG_ACCESS_PROTOCOL, > or is it just a pointless blob of noise? The GUID/NAME value in the ConfigHdr is get from

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 13/04/16 03:33, Dong, Eric wrote: Does the ConfigHdr have any meaning for EFI_HII_CONFIG_ACCESS_PROTOCOL, or is it just a pointless blob of noise? The GUID/NAME value in the ConfigHdr is get from the storage used in this driver. If one driver has more than one storage, the Guid + Name

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 04/13/16 04:33, Dong, Eric wrote: >> On 05/04/16 03:10, Dong, Eric wrote: On a separate but related note: The ConfigHdr portion of Request and Response seems to contain absolutely zero information by the time it reaches EFI_HII_CONFIG_ACCESS_PROTOCOL. As far as I can tell, it is

Re: [edk2] HII incompatibility between edk2 and iPXE?

> On 05/04/16 03:10, Dong, Eric wrote: > >> On a separate but related note: The ConfigHdr portion of Request and > >> Response seems to contain absolutely zero information by the time it > >> reaches EFI_HII_CONFIG_ACCESS_PROTOCOL. As far as I can tell, it is > >> meaningful only to

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 05/04/16 03:10, Dong, Eric wrote: On a separate but related note: The ConfigHdr portion of Request and Response seems to contain absolutely zero information by the time it reaches EFI_HII_CONFIG_ACCESS_PROTOCOL. As far as I can tell, it is meaningful only to EFI_HII_CONFIG_ROUTING_PROTOCOL

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 01/04/16 21:41, Laszlo Ersek wrote: I am (and was) aware of "MdeModulePkg/Universal/DriverSampleDxe", the same driver that Eric recommended as an example in this thread earlier. In my opinion, that driver is supremely over-sized and -cluttered to be usable as a learning tool. I'm glad

Re: [edk2] HII incompatibility between edk2 and iPXE?

> -Original Message- > From: Michael Brown [mailto:mc...@ipxe.org] > Sent: Saturday, April 02, 2016 12:50 AM > To: Laszlo Ersek; Dong, Eric; Bi, Dandan > Cc: Justen, Jordan L; edk2-devel-01; Ard Biesheuvel > Subject: Re: [edk2] HII incompatibility between edk2 and iPXE? &

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 04/01/16 18:49, Michael Brown wrote: > On 31/03/16 14:37, Michael Brown wrote: >>> In a nutshell, I think iPXE should: >>> - reflect the GUID / NAME / PATH triplet from the input to the output >>> verbatim, >>> - for each config knob requested, respond with >>> =. >>> >>> (See also: "if a

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 31/03/16 14:06, Dong, Eric wrote: 1. Enhance the Results string for ExtractConfig function like below: Request = “GUID===&…” Results = “GUIDValue1=Value2=Value3…” PS: Red string you can get from the input Request string. Blue string is the true value for each knob in your driver.

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 31/03/16 14:37, Michael Brown wrote: In a nutshell, I think iPXE should: - reflect the GUID / NAME / PATH triplet from the input to the output verbatim, - for each config knob requested, respond with =. (See also: "if a ConfigHdr is passed in with no request elements, all of the settings

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 03/31/16 15:37, Michael Brown wrote: > On 31/03/16 11:13, Laszlo Ersek wrote: >> Which translates to the following response string: >> >> GUID===> hex number>&=&=&...&= >> >> In a nutshell, I think iPXE should: >> - reflect the GUID / NAME / PATH triplet from the input to the output >>

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 31/03/16 11:13, Laszlo Ersek wrote: Which translates to the following response string: GUID===&=&=&...&= In a nutshell, I think iPXE should: - reflect the GUID / NAME / PATH triplet from the input to the output verbatim, - for each config knob requested, respond with =. (See also: "if a

Re: [edk2] HII incompatibility between edk2 and iPXE?

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 31, 2016 6:14 PM > To: Michael Brown; Dong, Eric; Bi, Dandan > Cc: edk2-devel-01; Justen, Jordan L; Ard Biesheuvel > Subject: Re: HII incompatibility between edk2 and iPXE? >

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 03/31/16 06:43, Michael Brown wrote: > On 31/03/16 02:17, Dong, Eric wrote: >>> Those sections of the UEFI spec are so badly written that I cannot begin >>> to guess what might count as either correct or incorrect. >>> >>> Could you please give a concrete example of what you think iPXE should

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 31/03/16 02:17, Dong, Eric wrote: Those sections of the UEFI spec are so badly written that I cannot begin to guess what might count as either correct or incorrect. Could you please give a concrete example of what you think iPXE should be returning here? We have a sample driver in

Re: [edk2] HII incompatibility between edk2 and iPXE?

Yes, we can also enhance Hiidatabase to not assert. From: Ni, Ruiyu Sent: Thursday, March 31, 2016 8:57 AM To: Dong, Eric; Laszlo Ersek; Bi, Dandan; Michael Brown Cc: Justen, Jordan L; edk2-devel-01; Ard Biesheuvel Subject: RE: HII incompatibility between edk2 and iPXE? Eric, Shall we also fix

Re: [edk2] HII incompatibility between edk2 and iPXE?

30, 2016 11:42 PM > To: Dong, Eric; Laszlo Ersek; Bi, Dandan > Cc: edk2-devel-01; Justen, Jordan L; Ard Biesheuvel > Subject: Re: HII incompatibility between edk2 and iPXE? > > On 30/03/16 16:09, Dong, Eric wrote: > > This error is caused by iPXE driver

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 30/03/16 16:27, Dong, Eric wrote: I download the iPXE code and check the hii related code. I'm very confused why you dynamic generate the ifr data? Why not use vfr file to descript the form data? Use vfr file is much easy than dynamic generate it. Also I found you use name/value store to

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 30/03/16 16:09, Dong, Eric wrote: This error is caused by iPXE driver not return the correct string in EFI_HII_CONFIG_ACCESS_PROTOCOL.ExtractConfig() function. Base on the spec requirement, if the function return success, the Results string should follow format. But the data returned by

Re: [edk2] HII incompatibility between edk2 and iPXE?

> On 29/03/16 16:20, Laszlo Ersek wrote: > > recent edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII > configuration settings available to OS runtime") seems to trigger an issue > between edk2 and iPXE. > > Thanks for debugging this! > > Is iPXE misbehaving here? At the time that I implemented

Re: [edk2] HII incompatibility between edk2 and iPXE?

This error is caused by iPXE driver not return the correct string in EFI_HII_CONFIG_ACCESS_PROTOCOL.ExtractConfig() function. Base on the spec requirement, if the function return success, the Results string should follow format. But the data returned by iPXE driver is not follow this rule, so

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 29/03/16 16:20, Laszlo Ersek wrote: recent edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII configuration settings available to OS runtime") seems to trigger an issue between edk2 and iPXE. Thanks for debugging this! Is iPXE misbehaving here? At the time that I implemented our HII