Re: [E-devel] Edje data speedup

2007-03-02 Thread The Rasterman
On Fri, 2 Mar 2007 09:12:54 -0600 "Nathan Ingersoll" <[EMAIL PROTECTED]> babbled: > On 3/2/07, Tilman Sauerbeck <[EMAIL PROTECTED]> wrote: > > > > IIRC there's one global "data" section, and every collection/group does > > have its own "data" section, too. So we can't get away with a single > > ha

Re: [E-devel] Edje data speedup

2007-03-02 Thread Nathan Ingersoll
On 3/2/07, Simon TRENY <[EMAIL PROTECTED]> wrote: > > Maybe the hash could be created only if there is a certain number of > items in the data section. For example, if there are more than 20 > items, you build the hash, otherwise you keep the linked-list. And that > could be applied for both global

Re: [E-devel] Edje data speedup

2007-03-02 Thread Simon TRENY
On Fri, 2 Mar 2007 09:12:54 -0600, "Nathan Ingersoll" <[EMAIL PROTECTED]> wrote : > On 3/2/07, Tilman Sauerbeck <[EMAIL PROTECTED]> wrote: > > > > IIRC there's one global "data" section, and every collection/group > > does have its own "data" section, too. So we can't get away with a > > single ha

Re: [E-devel] Edje data speedup

2007-03-02 Thread Nathan Ingersoll
On 3/2/07, Tilman Sauerbeck <[EMAIL PROTECTED]> wrote: > > IIRC there's one global "data" section, and every collection/group does > have its own "data" section, too. So we can't get away with a single > hash table. Not that it matters much :) Right, the proposed change was only for the global dat

Re: [E-devel] Edje data speedup

2007-03-02 Thread Nathan Ingersoll
On 3/2/07, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote: > On Thu, 1 Mar 2007 00:23:17 -0600 "Nathan Ingersoll" <[EMAIL PROTECTED]> > babbled: > > cool! nice work on the profiling. > > anyway - you hit a usage case i didn't expect/intend for the edje file data - > i > expected it to be

Re: [E-devel] Edje data speedup

2007-03-02 Thread Tilman Sauerbeck
Brian Mattern [2007-03-01 15:34]: > On Thu, Mar 01, 2007 at 09:35:13PM +0100, Tilman Sauerbeck wrote: > > ACK. I believe raster's reasoning for using lists in various spots that > > would intuitively like to be hashes was the size of the entries that are > > stored. IIRC evas/ecore_evas also use li

Re: [E-devel] Edje data speedup

2007-03-02 Thread The Rasterman
On Thu, 1 Mar 2007 00:23:17 -0600 "Nathan Ingersoll" <[EMAIL PROTECTED]> babbled: cool! nice work on the profiling. anyway - you hit a usage case i didn't expect/intend for the edje file data - i expected it to be used rarely so it wouldn't be a bottlneck. hashes are fairly big as they need to al

Re: [E-devel] Edje data speedup

2007-03-01 Thread Nathan Ingersoll
On 3/1/07, Tilman Sauerbeck <[EMAIL PROTECTED]> wrote: > > ACK. I believe raster's reasoning for using lists in various spots that > would intuitively like to be hashes was the size of the entries that are > stored. IIRC evas/ecore_evas also use lists to store key/value userdata. Is there extra st

Re: [E-devel] Edje data speedup

2007-03-01 Thread Brian Mattern
On Thu, Mar 01, 2007 at 09:35:13PM +0100, Tilman Sauerbeck wrote: > ACK. I believe raster's reasoning for using lists in various spots that > would intuitively like to be hashes was the size of the entries that are > stored. IIRC evas/ecore_evas also use lists to store key/value userdata. Yes, but

Re: [E-devel] Edje data speedup

2007-03-01 Thread Tilman Sauerbeck
Christopher Michael [2007-03-01 05:01]: > Nathan Ingersoll wrote: > > Doing some profiling, I noticed that I was seeing a fair amount of > > overhead (19.9% of the test apps completion time) coming from strcmp, > > and in particular from calls to edje_file_data_get. This isn't > > completely unexpe

Re: [E-devel] Edje data speedup

2007-03-01 Thread Brian Mattern
On Thu, Mar 01, 2007 at 08:13:19AM -0600, Nathan Ingersoll wrote: > On 3/1/07, Christopher Michael <[EMAIL PROTECTED]> wrote: > > > > Just my 2 cents, but with gains like that how can we NOT use a hash :) > > Right, we're going to use a hash one way or another, just a question > of if we want to b

Re: [E-devel] Edje data speedup

2007-03-01 Thread Nathan Ingersoll
On 3/1/07, Christopher Michael <[EMAIL PROTECTED]> wrote: > > Just my 2 cents, but with gains like that how can we NOT use a hash :) Right, we're going to use a hash one way or another, just a question of if we want to break the edje format to do it. :) > Such is the way with pre-alpha code...thi

Re: [E-devel] Edje data speedup

2007-03-01 Thread Christopher Michael
Nathan Ingersoll wrote: > Doing some profiling, I noticed that I was seeing a fair amount of > overhead (19.9% of the test apps completion time) coming from strcmp, > and in particular from calls to edje_file_data_get. This isn't > completely unexpected as EWL uses data keys in the edje to map widg