Re: [FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

2016-09-15 Thread Michael Niedermayer
On Thu, Sep 15, 2016 at 01:08:40PM -0700, Sasi Inguva wrote: > On Wed, Sep 14, 2016 at 1:57 PM, Michael Niedermayer > wrote: > > > On Wed, Sep 14, 2016 at 12:20:52AM -0700, Sasi Inguva wrote: > > > On Tue, Sep 13, 2016 at 4:39 PM, Sasi Inguva wrote: >

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Steven Liu
2016-09-16 1:08 GMT+08:00 Clément Bœsch : > On Fri, Sep 16, 2016 at 12:41:41AM +0800, Steven Liu wrote: > [...] > > update: > > > > Please attach a git-format-patch or use git-send-email. > Also, your mailer is mangling the inlined patch. > > > > > add a FF_OPT_FLAG_DEPRECATED define

[FFmpeg-devel] [PATCH] avutil/softfloat_ieee754: make all functions inline

2016-09-15 Thread James Almer
Removes "defined but not used" warnings Signed-off-by: James Almer --- libavutil/softfloat_ieee754.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavutil/softfloat_ieee754.h b/libavutil/softfloat_ieee754.h index f82397b..b8957fb 100644

Re: [FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-15 Thread Lou Logan
On Wed, 7 Sep 2016 14:27:07 +0200, Michael Niedermayer wrote: > yes one can ignore it but its alot more usefull if people keep in > mind that theres patchwork. The patch submission checklist is lengthy. I'm fine with an addition somewhere in doc/developer pointing out that it exists and how to

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flv muxer document into doc/muxers

2016-09-15 Thread Steven Liu
2016-09-16 3:11 GMT+08:00 Lou Logan : > On Thu, 15 Sep 2016 12:02:15 +0800, Steven Liu wrote: > > > From 0a62f9cb55df317c7c3df47d31e345cb9ad593d0 Mon Sep 17 00:00:00 2001 > > From: Steven Liu > > Date: Thu, 15 Sep 2016 11:59:35 +0800 > > Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] libavformat/webm_chunk: Option to specify HTTP header

2016-09-15 Thread Michael Niedermayer
On Thu, Sep 15, 2016 at 02:29:24PM -0700, Vignesh Venkatasubramanian wrote: > Add an option to specify HTTP header in the WebM Chunk Muxer (this > works the same way as the 'method' parameter in the HLS muxer). > > Signed-off-by: Vignesh Venkatasubramanian > --- >

[FFmpeg-devel] [PATCH] avformat/movenc: Make the packet check more tolerant

2016-09-15 Thread Michael Niedermayer
Depends-on "avformat/movenc: Check packet in mov_write_single_packet() too" Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/libavformat/movenc.c

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: Check packet in mov_write_single_packet() too

2016-09-15 Thread Michael Niedermayer
Fixes assertion failure Found-by: durandal117 Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2d8fc48..b704f49 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH 1/2] avformat/movenc: Factor check_pkt() out

2016-09-15 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 319ff57..2d8fc48 100644 --- a/libavformat/movenc.c +++

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Lukasz Marek
On 15.09.2016 23:36, Josh de Kock wrote: On 15/09/2016 22:28, Lukasz Marek wrote: On 15.09.2016 23:19, Moritz Barsnick wrote: On Thu, Sep 15, 2016 at 14:36:32 -0300, James Almer wrote: * SDL1 is old and effectively unmaintained. I understand this verbatim, but what is it supposed to mean?

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Hendrik Leppkes
On Thu, Sep 15, 2016 at 11:19 PM, Moritz Barsnick wrote: > On Thu, Sep 15, 2016 at 14:36:32 -0300, James Almer wrote: >> * SDL1 is old and effectively unmaintained. > > I understand this verbatim, but what is it supposed to mean? Has SDL1 > gotten rotten? Or more precisely: > >

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Hendrik Leppkes
On Thu, Sep 15, 2016 at 7:36 PM, James Almer wrote: > There have been some complains from developers about keeping both > SDL1 and SDL2 support at the same time even after all SDL1 code > has been already ported, and especially since it makes maintaining > ffplay more complex,

Re: [FFmpeg-devel] [PATCH] lavc/mpeg12dec.c: Read cc words field-wise, limit to cc_count and support extra field.

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 21:52 GMT+02:00 Jonathan Campbell : > Do you need me to upload a small 20-second clip of the VOB where > the garbled captions are visible? I believe it would be useful. Thank you, Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/webm_chunk: Option to specify HTTP header

2016-09-15 Thread Vignesh Venkatasubramanian
On Wed, Sep 14, 2016 at 8:46 AM, Carl Eugen Hoyos wrote: > > 2016-09-13 22:12 GMT+02:00 Vignesh Venkatasubramanian > : > > Add an option to specify HTTP header in the WebM Chunk Muxer > > > (this works the same way as the 'method' parameter

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Josh de Kock
On 15/09/2016 22:28, Lukasz Marek wrote: On 15.09.2016 23:19, Moritz Barsnick wrote: On Thu, Sep 15, 2016 at 14:36:32 -0300, James Almer wrote: * SDL1 is old and effectively unmaintained. I understand this verbatim, but what is it supposed to mean? Has SDL1 gotten rotten? Or more precisely:

[FFmpeg-devel] [PATCH] libavformat/webm_chunk: Option to specify HTTP header

2016-09-15 Thread Vignesh Venkatasubramanian
Add an option to specify HTTP header in the WebM Chunk Muxer (this works the same way as the 'method' parameter in the HLS muxer). Signed-off-by: Vignesh Venkatasubramanian --- libavformat/webm_chunk.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Lukasz Marek
On 15.09.2016 23:19, Moritz Barsnick wrote: On Thu, Sep 15, 2016 at 14:36:32 -0300, James Almer wrote: * SDL1 is old and effectively unmaintained. I understand this verbatim, but what is it supposed to mean? Has SDL1 gotten rotten? Or more precisely: - Has technology evolved, and the library

Re: [FFmpeg-devel] [PATCH v3 3/3] lavd: deprecate opengl outdev

2016-09-15 Thread Josh de Kock
On 15/09/2016 21:56, Lukasz Marek wrote: On 14.09.2016 19:53, Nicolas George wrote: Le sextidi 26 fructidor, an CCXXIV, Josh de Kock a écrit : This device depends on SDL which is deprecated. Signed-off-by: Josh de Kock If I understand correctly, SDL is only used in this

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Moritz Barsnick
On Thu, Sep 15, 2016 at 14:36:32 -0300, James Almer wrote: > * SDL1 is old and effectively unmaintained. I understand this verbatim, but what is it supposed to mean? Has SDL1 gotten rotten? Or more precisely: - Has technology evolved, and the library not kept up? - Is a long list of bugs

Re: [FFmpeg-devel] [PATCH v3 3/3] lavd: deprecate opengl outdev

2016-09-15 Thread Lukasz Marek
On 14.09.2016 19:53, Nicolas George wrote: Le sextidi 26 fructidor, an CCXXIV, Josh de Kock a écrit : This device depends on SDL which is deprecated. Signed-off-by: Josh de Kock If I understand correctly, SDL is only used in this device to set up a window and a context in

[FFmpeg-devel] [PATCH 3/6] lavc: Add a flag in AVPacket to discard packet after decoding. Discard frames after decoding based on the flag.

2016-09-15 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavcodec/avcodec.h | 6 ++ libavcodec/utils.c | 15 ++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 01f9b29..db1061d 100644 --- a/libavcodec/avcodec.h +++

[FFmpeg-devel] [PATCH 5/6] lavf/utils: Support av_index_search_timestamp in case of AVIndexEntry with discarded packets.

2016-09-15 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/utils.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index d605a96..f043bae 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1937,6 +1937,16 @@ int

[FFmpeg-devel] [PATCH 6/6] ffprobe.c: Indicate decode-but-discard packets when doing -show_packets.

2016-09-15 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- ffprobe.c | 3 +- tests/ref/fate/concat-demuxer-extended-lavf-mxf| 2 +- .../ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +- tests/ref/fate/concat-demuxer-simple1-lavf-mxf | 242

[FFmpeg-devel] [PATCH 2/6] avformat/avframe.h: Add a flag in AVIndexEntry to discard frame after decoding.

2016-09-15 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/avformat.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 21e505d..ae70cc8 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -814,6 +814,9 @@ typedef

[FFmpeg-devel] [PATCH 1/6] avutil/frame: Add a flag to discard frame after decode.

2016-09-15 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavutil/frame.c | 1 + libavutil/frame.h | 4 libavutil/version.h | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 662c20d..3c74931 100644 --- a/libavutil/frame.c +++

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add hevc mediacodec decoder

2016-09-15 Thread Matthieu Bouron
On Thu, Sep 15, 2016 at 04:57:42PM +0200, Matthieu Bouron wrote: > On Fri, Sep 09, 2016 at 04:46:25PM +0200, Matthieu Bouron wrote: > [...] > > Updated patch attached. It now checks if the hevc decoder supports the > > stream profile before using it. > > The patch depends on the following patch on

Re: [FFmpeg-devel] [PATCH] lavc/mpeg12dec.c: Read cc words field-wise, limit to cc_count and support extra field.

2016-09-15 Thread Jonathan Campbell
On 09/15/2016 12:31 PM, Carl Eugen Hoyos wrote: > 2016-09-15 20:49 GMT+02:00 Jonathan Campbell : > >> This updates the mpeg12dec.c DVD caption decoding to decode >> field-wise and handle caption packets with an extra field. It obeys >> the cc_count field, though

Re: [FFmpeg-devel] [PATCH] lavc/mpeg12dec.c: Read cc words field-wise, limit to cc_count and support extra field.

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 20:49 GMT+02:00 Jonathan Campbell : > This updates the mpeg12dec.c DVD caption decoding to decode > field-wise and handle caption packets with an extra field. It obeys > the cc_count field, though still validates the count like the prior code. Is there a

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flv muxer document into doc/muxers

2016-09-15 Thread Lou Logan
On Thu, 15 Sep 2016 12:02:15 +0800, Steven Liu wrote: > From 0a62f9cb55df317c7c3df47d31e345cb9ad593d0 Mon Sep 17 00:00:00 2001 > From: Steven Liu > Date: Thu, 15 Sep 2016 11:59:35 +0800 > Subject: [PATCH] doc/muxers: add flv muxer document into doc/muxers > > add

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

2016-09-15 Thread Michael Niedermayer
On Thu, Sep 15, 2016 at 03:47:49PM +0200, Carl Eugen Hoyos wrote: > 2016-09-15 15:42 GMT+02:00 Michael Niedermayer : > >> -{ AV_CODEC_ID_ADPCM_SWF, ('S' << 8) + 'F' }, > >> /* HACK/FIXME: Does Vorbis in WAV/AVI have an (in)official ID? */ > >> {

[FFmpeg-devel] [PATCH] lavc/mpeg12dec.c: Read cc words field-wise, limit to cc_count and support extra field.

2016-09-15 Thread Jonathan Campbell
I'm sorry if the previous posting was not recognized as a patch. This updates the mpeg12dec.c DVD caption decoding to decode field-wise and handle caption packets with an extra field. It obeys the cc_count field, though still validates the count like the prior code. I will start on a patch to

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread James Almer
On 9/15/2016 2:51 PM, Carl Eugen Hoyos wrote: > 2016-09-15 19:36 GMT+02:00 James Almer : >> There have been some complains from developers about keeping both >> SDL1 and SDL2 support at the same time even after all SDL1 code >> has been already ported, > > Didn't we all agree

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 19:36 GMT+02:00 James Almer : > There have been some complains from developers about keeping both > SDL1 and SDL2 support at the same time even after all SDL1 code > has been already ported, Didn't we all agree yesterday that this makes the transition less painful?

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Clément Bœsch
On Thu, Sep 15, 2016 at 02:36:32PM -0300, James Almer wrote: > There have been some complains from developers about keeping both > SDL1 and SDL2 support at the same time even after all SDL1 code > has been already ported, and especially since it makes maintaining > ffplay more complex, so seeing

[FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread James Almer
There have been some complains from developers about keeping both SDL1 and SDL2 support at the same time even after all SDL1 code has been already ported, and especially since it makes maintaining ffplay more complex, so seeing the waters are divided I think the best solution will be to vote.

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Clément Bœsch
On Fri, Sep 16, 2016 at 12:41:41AM +0800, Steven Liu wrote: [...] > update: > Please attach a git-format-patch or use git-send-email. Also, your mailer is mangling the inlined patch. > > add a FF_OPT_FLAG_DEPRECATED define for compile. > add a new variable for user_agent to give a deprecated

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Steven Liu
2016-09-16 0:35 GMT+08:00 Steven Liu : > ignore it please, i will fix some problem > > 2016-09-16 0:30 GMT+08:00 Steven Liu : > >> >> >> 2016-09-16 0:21 GMT+08:00 Clément Bœsch : >> >>> On Fri, Sep 16, 2016 at 12:04:34AM +0800, Steven

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Steven Liu
ignore it please, i will fix some problem 2016-09-16 0:30 GMT+08:00 Steven Liu : > > > 2016-09-16 0:21 GMT+08:00 Clément Bœsch : > >> On Fri, Sep 16, 2016 at 12:04:34AM +0800, Steven Liu wrote: >> > 2016-09-15 23:42 GMT+08:00 Clément Bœsch : >>

[FFmpeg-devel] exposing public API for chromium ffmpeg_demuxer.cc code

2016-09-15 Thread Paweł Hajdan
I've been working on making chromium work with system (unmodified and installed) ffmpeg, and there is some code currently using internal-only API, which is not available in that case:

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Steven Liu
2016-09-16 0:21 GMT+08:00 Clément Bœsch : > On Fri, Sep 16, 2016 at 12:04:34AM +0800, Steven Liu wrote: > > 2016-09-15 23:42 GMT+08:00 Clément Bœsch : > > > > > On Thu, Sep 15, 2016 at 05:39:25PM +0200, Nicolas George wrote: > > > > Le decadi 30 fructidor, an CCXXIV,

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Clément Bœsch
On Fri, Sep 16, 2016 at 12:04:34AM +0800, Steven Liu wrote: > 2016-09-15 23:42 GMT+08:00 Clément Bœsch : > > > On Thu, Sep 15, 2016 at 05:39:25PM +0200, Nicolas George wrote: > > > Le decadi 30 fructidor, an CCXXIV, Clement Boesch a écrit : > > > > Yes, surrounded by the #ifdefery so

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 18:04 GMT+02:00 Steven Liu : > are you mean like this? Imo, this is missing the (only relevant) change to doc/protocols.texi. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Steven Liu
2016-09-15 23:42 GMT+08:00 Clément Bœsch : > On Thu, Sep 15, 2016 at 05:39:25PM +0200, Nicolas George wrote: > > Le decadi 30 fructidor, an CCXXIV, Clement Boesch a écrit : > > > Yes, surrounded by the #ifdefery so it will go away with the option. > > > > > > Note: use av_strdup() to

Re: [FFmpeg-devel] [PATCH v2 2/4] ffplay: make copy for SDL1

2016-09-15 Thread James Almer
On 9/15/2016 11:54 AM, James Almer wrote: > On 9/15/2016 7:23 AM, Carl Eugen Hoyos wrote: >> 2016-09-15 12:19 GMT+02:00 Josh de Kock : >>> On 15/09/2016 10:58, Carl Eugen Hoyos wrote: 2016-09-15 10:39 GMT+02:00 Josh de Kock : >> > #include

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Clément Bœsch
On Thu, Sep 15, 2016 at 05:39:25PM +0200, Nicolas George wrote: > Le decadi 30 fructidor, an CCXXIV, Clement Boesch a écrit : > > Yes, surrounded by the #ifdefery so it will go away with the option. > > > > Note: use av_strdup() to transfer from one field to the other > > Another possibility

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Nicolas George
Le decadi 30 fructidor, an CCXXIV, Clement Boesch a écrit : > Yes, surrounded by the #ifdefery so it will go away with the option. > > Note: use av_strdup() to transfer from one field to the other Another possibility would be to implement AV_OPT_FLAG_DEPRECATED and let the options system itself

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Clément Bœsch
On Thu, Sep 15, 2016 at 11:27:02PM +0800, Steven Liu wrote: > 2016-09-15 23:03 GMT+08:00 Carl Eugen Hoyos : > > > 2016-09-15 16:40 GMT+02:00 Clément Bœsch : > > > > >> Carl Eugen's mean is apply this patch after the next release? > > > > > > You need to deprecate

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Steven Liu
2016-09-15 23:03 GMT+08:00 Carl Eugen Hoyos : > 2016-09-15 16:40 GMT+02:00 Clément Bœsch : > > >> Carl Eugen's mean is apply this patch after the next release? > > > > You need to deprecate the option with at least the classic #ifdefery > dance > > (git grep

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 16:40 GMT+02:00 Clément Bœsch : >> Carl Eugen's mean is apply this patch after the next release? > > You need to deprecate the option with at least the classic #ifdefery dance > (git grep FF_API for examples), and ideally by also printing a warning > when using the wrong

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add hevc mediacodec decoder

2016-09-15 Thread Matthieu Bouron
On Fri, Sep 09, 2016 at 04:46:25PM +0200, Matthieu Bouron wrote: [...] > Updated patch attached. It now checks if the hevc decoder supports the > stream profile before using it. > The patch depends on the following patch on the ml to work properly on > android < 24: > lavc/ffjni: do not error out

Re: [FFmpeg-devel] [PATCH 4/4] MAINTAINERS: update my entries

2016-09-15 Thread James Almer
On 9/15/2016 11:49 AM, Moritz Barsnick wrote: > On Wed, Sep 14, 2016 at 23:27:33 +0100, Josh de Kock wrote: >> - ffplay.c Marton Balint >> + ffplay.c Marton Balint, Josh de Kock >> + ffplay_sdl1.c Josh de Kock >

Re: [FFmpeg-devel] [PATCH 4/4] MAINTAINERS: update my entries

2016-09-15 Thread Moritz Barsnick
On Wed, Sep 14, 2016 at 23:27:33 +0100, Josh de Kock wrote: > - ffplay.c Marton Balint > + ffplay.c Marton Balint, Josh de Kock > + ffplay_sdl1.c Josh de Kock Since ffplay_sdl1.c was created as a copy (or

Re: [FFmpeg-devel] [PATCH v2 2/4] ffplay: make copy for SDL1

2016-09-15 Thread James Almer
On 9/15/2016 7:23 AM, Carl Eugen Hoyos wrote: > 2016-09-15 12:19 GMT+02:00 Josh de Kock : >> On 15/09/2016 10:58, Carl Eugen Hoyos wrote: >>> >>> 2016-09-15 10:39 GMT+02:00 Josh de Kock : > #include "config.h" + +#if HAVE_SDL2 >>> >>> >>> Sorry

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Clément Bœsch
On Thu, Sep 15, 2016 at 10:34:37PM +0800, Steven Liu wrote: > 2016-09-15 22:22 GMT+08:00 Carl Eugen Hoyos : > > > 2016-09-15 16:04 GMT+02:00 Steven Liu : > > > double user-agent option, same option, remove one. > > > > Looking at the documentation, the

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Steven Liu
2016-09-15 22:22 GMT+08:00 Carl Eugen Hoyos : > 2016-09-15 16:04 GMT+02:00 Steven Liu : > > double user-agent option, same option, remove one. > > Looking at the documentation, the patch is not ok as-is. > > I suggest to deprecate the option now, and

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 16:04 GMT+02:00 Steven Liu : > double user-agent option, same option, remove one. Looking at the documentation, the patch is not ok as-is. I suggest to deprecate the option now, and to remove it after the next release. Carl Eugen

Re: [FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Clément Bœsch
On Thu, Sep 15, 2016 at 10:04:48PM +0800, Steven Liu wrote: > double user-agent option, same option, remove one. > > Signed-off-by: Steven Liu > --- > libavformat/http.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/http.c b/libavformat/http.c >

[FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option

2016-09-15 Thread Steven Liu
double user-agent option, same option, remove one. Signed-off-by: Steven Liu --- libavformat/http.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index adb3d92..f2bfb17 100644 --- a/libavformat/http.c +++ b/libavformat/http.c

Re: [FFmpeg-devel] [PATCH] avfilter/af_amerge: add reorder_inputs option to be able to turn off reordering

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 15:46 GMT+02:00 Nicolas George : > Le decadi 30 fructidor, an CCXXIV, Carl Eugen Hoyos a écrit : >> Why not? >> Afair, I had tested it extensively before it was broken. > > Because "providing a value that is not available" and > "overriding a value" are two very

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec_h2645.c: drop executable permission

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 15:49 GMT+02:00 Moritz Barsnick : > Accidentally set in b93e2233155e6c1f0a074cad4135a70d9d2934d3. > > Signed-off-by: Moritz Barsnick > --- > libavcodec/qsvdec_h2645.c | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100755 =>

[FFmpeg-devel] [PATCH] libavcodec/qsvdec_h2645.c: drop executable permission

2016-09-15 Thread Moritz Barsnick
Accidentally set in b93e2233155e6c1f0a074cad4135a70d9d2934d3. Signed-off-by: Moritz Barsnick --- libavcodec/qsvdec_h2645.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 libavcodec/qsvdec_h2645.c diff --git a/libavcodec/qsvdec_h2645.c

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 15:42 GMT+02:00 Michael Niedermayer : >> -{ AV_CODEC_ID_ADPCM_SWF, ('S' << 8) + 'F' }, >> /* HACK/FIXME: Does Vorbis in WAV/AVI have an (in)official ID? */ >> { AV_CODEC_ID_VORBIS, ('V' << 8) + 'o' }, >> { AV_CODEC_ID_NONE,

Re: [FFmpeg-devel] [PATCH] avfilter/af_amerge: add reorder_inputs option to be able to turn off reordering

2016-09-15 Thread Nicolas George
Le decadi 30 fructidor, an CCXXIV, Carl Eugen Hoyos a écrit : > Why not? > Afair, I had tested it extensively before it was broken. Because "providing a value that is not available" and "overriding a value" are two very different tasks. Sometimes you have to specify the channel layout because

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

2016-09-15 Thread Michael Niedermayer
On Mon, Sep 12, 2016 at 12:52:49PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch "fixes" ticket #5829, I am happy if a better > solution can be found. > > Please comment, Carl Eugen > riff.c |1 - > 1 file changed, 1 deletion(-) > 6113805920f6fb418635029f2f600fcfe1c3fa88 >

Re: [FFmpeg-devel] [PATCH 1/2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-15 Thread Ronald S. Bultje
Hi, On Thu, Sep 15, 2016 at 9:32 AM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > > On Sep 15, 2016, at 2:45 PM, Ronald S. Bultje wrote: > > Hi Vittorio, > > On Thu, Sep 15, 2016 at 8:33 AM, Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > >> I agree we

Re: [FFmpeg-devel] [PATCH 1/2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-15 Thread Vittorio Giovara
> On Sep 15, 2016, at 2:45 PM, Ronald S. Bultje wrote: > > Hi Vittorio, > >> On Thu, Sep 15, 2016 at 8:33 AM, Vittorio Giovara >> wrote: >> I agree we should always be very very careful about automatic assignments, >> although this one seems

Re: [FFmpeg-devel] [PATCH 1/2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-15 Thread Ronald S. Bultje
Hi Vittorio, On Thu, Sep 15, 2016 at 8:33 AM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > I agree we should always be very very careful about automatic assignments, > although this one seems pretty safe. > > I don't think it's necessary, but if you prefer I can add a warning >

Re: [FFmpeg-devel] [PATCH 1/2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-15 Thread Vittorio Giovara
> Hi, On Wed, Sep 14, 2016 at 5:09 PM, Vittorio Giovara < vittorio.giovara at > gmail.com> wrote: > This is the assumption that is made in pixel format > conversion do > throughout the code (in particular swscale and > vf_colormatrix). > > Signed-off-by: Vittorio Giovara gmail.com> > --- >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-15 Thread Steven Liu
2016-09-14 6:51 GMT+08:00 Steven Liu : > > > 2016-09-14 2:53 GMT+08:00 Moritz Barsnick : > >> On Tue, Sep 13, 2016 at 11:25:39 +0800, Steven Liu wrote: >> > +int byterange_mode = hls->flags & (HLS_SINGLE_FILE) || >> hls->max_seg_size > 0; >>

Re: [FFmpeg-devel] [PATCH 1/2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-15 Thread Ronald S. Bultje
Hi, On Wed, Sep 14, 2016 at 5:09 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > This is the assumption that is made in pixel format conversion do > throughout the code (in particular swscale and vf_colormatrix). > > Signed-off-by: Vittorio Giovara > ---

Re: [FFmpeg-devel] [PATCH] avfilter/af_amerge: add reorder_inputs option to be able to turn off reordering

2016-09-15 Thread Carl Eugen Hoyos
2016-09-10 11:58 GMT+02:00 Nicolas George : > In other words, I strongly support an option to override the > channel layout detected from inputs, including to set it to > unknown whenever it makes sense. > > I do not know if "-channel_layout" is the right option for the job. Why

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

2016-09-15 Thread Carl Eugen Hoyos
Hi! 2016-09-14 22:50 GMT+02:00 Ronald S. Bultje : > > On Wed, Sep 14, 2016 at 1:46 PM, Carl Eugen Hoyos wrote: > >> 2016-09-14 19:21 GMT+02:00 Ronald S. Bultje : >> >> I wondered if somebody can easily fix muxing / demuxing which >> >> could be considered

Re: [FFmpeg-devel] [PATCH 0/4] ffplay and lavd SDL2 set

2016-09-15 Thread Josh de Kock
On 15/09/2016 11:11, Thomas Volkert wrote: [...] Yes, it is quite a bit of unnecessary overhead, but it's much cleaner than #ifdeffery in a single source file. In general, I don't like the idea of having 2 source files with almost the same content. This usually indicates to me that the code

Re: [FFmpeg-devel] [PATCH v2 2/4] ffplay: make copy for SDL1

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 12:19 GMT+02:00 Josh de Kock : > On 15/09/2016 10:58, Carl Eugen Hoyos wrote: >> >> 2016-09-15 10:39 GMT+02:00 Josh de Kock : >>> #include "config.h" >>> + >>> +#if HAVE_SDL2 >> >> >> Sorry if this should be obvious: >> What is the effect of this

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-15 Thread Michael Niedermayer
On Fri, Sep 09, 2016 at 05:26:03PM -0700, Brett Harrison wrote: > Here are the changes requested [...] > +static av_cold int parse_fontsize(AVFilterContext *ctx) > +{ > +DrawTextContext *s = ctx->priv; > +int err; > + > +if (s->fontsize_expr == NULL) > +return AVERROR(EINVAL);

Re: [FFmpeg-devel] [PATCH v2 2/4] ffplay: make copy for SDL1

2016-09-15 Thread Josh de Kock
On 15/09/2016 10:58, Carl Eugen Hoyos wrote: 2016-09-15 10:39 GMT+02:00 Josh de Kock : Signed-off-by: Josh de Kock --- Makefile | 1 + ffplay.c | 5 + ffplay.c => ffplay_sdl1.c | 0 3 files changed, 6 insertions(+)

Re: [FFmpeg-devel] [PATCH 0/4] ffplay and lavd SDL2 set

2016-09-15 Thread Thomas Volkert
On 15.09.2016 08:55, Josh de Kock wrote: On 14/09/2016 23:44, Thomas Volkert wrote: On 15.09.2016 00:27, Josh de Kock wrote: Hi, Resending this set with ffplay now having two versions, a SDL2 and a SDL1 version. I've integrated all comments up until now (hopefully). Josh Josh de Kock (3):

Re: [FFmpeg-devel] [PATCH] Fix target_level for EAC3.

2016-09-15 Thread Michael Niedermayer
On Fri, Sep 09, 2016 at 12:48:52PM -0700, Nikolas Bowe wrote: > Currently when using target_level with EAC3 it produces silence. This small > patch fixes target_level for decoding EAC3. > > Example: > ffmpeg -y -i /tmp/test.wav -acodec eac3 -dialnorm -14 -ac 6 -b:a 384000 > /tmp/test.m2ts >

Re: [FFmpeg-devel] [PATCH v2 2/4] ffplay: make copy for SDL1

2016-09-15 Thread Carl Eugen Hoyos
2016-09-15 10:39 GMT+02:00 Josh de Kock : > Signed-off-by: Josh de Kock > --- > Makefile | 1 + > ffplay.c | 5 + > ffplay.c => ffplay_sdl1.c | 0 > 3 files changed, 6 insertions(+) > copy ffplay.c => ffplay_sdl1.c (100%)

Re: [FFmpeg-devel] [PATCH 4/4] MAINTAINERS: update my entries

2016-09-15 Thread Michael Niedermayer
On Wed, Sep 14, 2016 at 11:27:33PM +0100, Josh de Kock wrote: > Signed-off-by: Josh de Kock > --- > MAINTAINERS | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Michael [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old

[FFmpeg-devel] [PATCH v2 1/4] lavd: Add SDL2 output device

2016-09-15 Thread Josh de Kock
Acked-by: Michael Niedermayer Signed-off-by: Josh de Kock --- Changelog| 1 + configure| 28 +++- libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/sdl2.c | 377

[FFmpeg-devel] [PATCH v2 2/4] ffplay: make copy for SDL1

2016-09-15 Thread Josh de Kock
Signed-off-by: Josh de Kock --- Makefile | 1 + ffplay.c | 5 + ffplay.c => ffplay_sdl1.c | 0 3 files changed, 6 insertions(+) copy ffplay.c => ffplay_sdl1.c (100%) diff --git a/Makefile b/Makefile index 8aa72fd..15ba3df 100644 ---

[FFmpeg-devel] [PATCH v2 3/4] ffplay: add SDL2 support

2016-09-15 Thread Josh de Kock
From: Marton Balint Tested-by: James Almer (Windows, mingw-w64) Signed-off-by: Josh de Kock --- Changelog | 1 + configure | 7 +- ffplay.c | 594 ++ 3 files changed, 251

Re: [FFmpeg-devel] [PATCH 0/4] ffplay and lavd SDL2 set

2016-09-15 Thread Josh de Kock
On 14/09/2016 23:44, Thomas Volkert wrote: On 15.09.2016 00:27, Josh de Kock wrote: Hi, Resending this set with ffplay now having two versions, a SDL2 and a SDL1 version. I've integrated all comments up until now (hopefully). Josh Josh de Kock (3): lavd: Add SDL2 output device ffplay: