Re: [FFmpeg-devel] [PATCH v5 1/8] avcodec/cbs_av1: Add tx mode enum values

2023-09-21 Thread Xiang, Haihao
On Wo, 2023-09-20 at 02:21 +, Xiang, Haihao wrote: > On Di, 2023-09-19 at 20:40 -0400, Neal Gompa wrote: > > On Mon, Sep 11, 2023 at 3:52 AM wrote: > > > > > > From: Fei Wang > > > > > > Signed-off-by: Fei Wang > > > --- > > >  libavcodec/av1.h | 7 +++ > > >  

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h266_syntax_template: Check num_output_layers_in_ols

2023-09-21 Thread Nuo Mi
On Fri, Sep 22, 2023 at 12:04 AM James Almer wrote: > On 9/19/2023 12:25 PM, Nuo Mi wrote: > > from the specification: > > For each OLS, there shall be at least one layer that is an output layer. > In other words, for any value of i in the range of 0 > > to TotalNumOlss − 1, inclusive, the value

Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects

2023-09-21 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12023-09-19): >> For now, this API is supposed to replace all the internal uses >> of reference counted objects in libavcodec; "internal" here >> means that the object is created in libavcodec and is never >> put directly in the hands of anyone outside of it.

Re: [FFmpeg-devel] [RFC PATCH 3/3] HACK: avformat: rawenc: allow to output a raw PRFT

2023-09-21 Thread Andreas Rheinhardt
Michael Niedermayer: > On Thu, Sep 21, 2023 at 02:17:00PM +0200, Clément Péron wrote: >> Output the producer reference time to a dirty raw output. >> >> Signed-off-by: Clément Péron >> --- >> libavformat/rawenc.c | 122 +++ >> 1 file changed, 122

Re: [FFmpeg-devel] [RFC PATCH 3/3] HACK: avformat: rawenc: allow to output a raw PRFT

2023-09-21 Thread Michael Niedermayer
On Thu, Sep 21, 2023 at 02:17:00PM +0200, Clément Péron wrote: > Output the producer reference time to a dirty raw output. > > Signed-off-by: Clément Péron > --- > libavformat/rawenc.c | 122 +++ > 1 file changed, 122 insertions(+) this breaks

Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects

2023-09-21 Thread Nicolas George
Andreas Rheinhardt (12023-09-19): > For now, this API is supposed to replace all the internal uses > of reference counted objects in libavcodec; "internal" here > means that the object is created in libavcodec and is never > put directly in the hands of anyone outside of it. > > It is intended to

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Paul B Mahol
On Thu, Sep 21, 2023 at 9:37 PM Nicolas George wrote: > Vittorio Giovara (12023-09-21): > > So this is an example of accusatory tone - discrediting the previous > author > > in order to make your arguments have more weight. It's a bad move and > > easily spottable, you should argue with better

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Nicolas George
Vittorio Giovara (12023-09-21): > So this is an example of accusatory tone - discrediting the previous author > in order to make your arguments have more weight. It's a bad move and > easily spottable, you should argue with better elements at your disposal, > not by claiming that I don't package

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Vittorio Giovara
On Thu, Sep 21, 2023 at 3:05 PM Nicolas George wrote: > Vittorio Giovara (12023-09-21): > > What about other developers' time for maintenance? > > Yes, what about it? > > How much time did YOU spend maintaining libavfilter or libavdevice? > Zero. > > How much time will you spend maintaining SDR?

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Paul B Mahol
On Thu, Sep 21, 2023 at 9:05 PM Nicolas George wrote: > Vittorio Giovara (12023-09-21): > > What about other developers' time for maintenance? > > Yes, what about it? > > How much time did YOU spend maintaining libavfilter or libavdevice? > Zero. > > How much time will you spend maintaining SDR?

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Nicolas George
Vittorio Giovara (12023-09-21): > What about other developers' time for maintenance? Yes, what about it? How much time did YOU spend maintaining libavfilter or libavdevice? Zero. How much time will you spend maintaining SDR? Zero. What does it change for you and everybody who thinks like you?

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Michael Niedermayer
Hi On Thu, Sep 21, 2023 at 05:33:54PM +0100, Kieran Kunhya via ffmpeg-devel wrote: > On Thu, Sep 21, 2023 at 5:21 PM Michael Niedermayer > wrote: > > OTOH If a majority of people are against the SDR code at the time of > > branching 6.1. Then i will make a separate release identical to 6.1 with

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Vittorio Giovara
On Thu, Sep 21, 2023 at 2:51 PM Nicolas George wrote: > Vittorio Giovara (12023-09-21): > > Good, if it's so isolated it can be moved to a separate library and we're > > arguing over nothing. > > Wasting Michael's time for the maintenance and users' time for > installing it in the process. That

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Nicolas George
Vittorio Giovara (12023-09-21): > Good, if it's so isolated it can be moved to a separate library and we're > arguing over nothing. Wasting Michael's time for the maintenance and users' time for installing it in the process. That is a completely stupid idea. > Will you stop with this accusatory

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Vittorio Giovara
On Thu, Sep 21, 2023 at 2:19 PM Nicolas George wrote: > Vittorio Giovara (12023-09-21): > > Because it adds maintenance burden and it's out of scope with the proejct > > The feature is isolated, so that is a lie. > Good, if it's so isolated it can be moved to a separate library and we're

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Nicolas George
Vittorio Giovara (12023-09-21): > Because it adds maintenance burden and it's out of scope with the proejct The feature is isolated, so that is a lie. > No thanks, feature creep is a bad mojo. “Creep” is your opinion, the opinion of somebody who we never see on users mailing lists by the way.

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Vittorio Giovara
On Thu, Sep 21, 2023 at 1:16 PM Nicolas George wrote: > Kieran Kunhya via ffmpeg-devel (12023-09-21): > > How on earth is it acceptable that you can publish your hobby project > > under the FFmpeg project name? > > How on earth is it acceptable that you continue bikeshedding a feature > that

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/osq: Check that pkt_offset does not exceed pkt size

2023-09-21 Thread Paul B Mahol
On Thu, Sep 21, 2023 at 8:09 PM Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6227491892887552 > Fixes: > 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6268561729126400 > Fixes: >

[FFmpeg-devel] [PATCH 6/6] avformat/mov: Check avif_info

2023-09-21 Thread Michael Niedermayer
Fixes: leak Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6674082962997248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCH 5/6] avcodec/jpegxl_parse: Cleanup on error in read_vlc_prefix()

2023-09-21 Thread Michael Niedermayer
Fixes: leak Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6167847715602432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpegxl_parser.c | 6 -- 1 file changed, 4

[FFmpeg-devel] [PATCH 4/6] avcodec/wavarc: Check k in decode_5elp()

2023-09-21 Thread Michael Niedermayer
regression since 18b2ecc24778140c2bc798ed64842dc8feb6dc3a Fixes: assertion failure Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6280165808013312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 3/6] avcodec/wavarc: Allocate AV_INPUT_BUFFER_PADDING_SIZE

2023-09-21 Thread Michael Niedermayer
Fixes: overread Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-5963163952349184 Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6048030137909248 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 2/6] avcodec/wavarc: Fix integer overflwo in do_stereo()

2023-09-21 Thread Michael Niedermayer
Fixes: signed integer overflow: 148676193 - -2006512262 cannot be represented in type 'int' Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-5963163952349184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 1/6] avcodec/osq: Check that pkt_offset does not exceed pkt size

2023-09-21 Thread Michael Niedermayer
Fixes: out of array access Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6227491892887552 Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6268561729126400 Fixes:

[FFmpeg-devel] [PATCH] avcodec/evc_ps: Fix leak on error

2023-09-21 Thread Andreas Rheinhardt
Regression since 4565747056a11356210ed8edcecb920105e40b60. Fixes Coverity ticket #1545072. Signed-off-by: Andreas Rheinhardt --- libavcodec/evc_ps.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/evc_ps.c b/libavcodec/evc_ps.c index 6f93f5b373..64d60f44e2

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Nicolas George
Kieran Kunhya via ffmpeg-devel (12023-09-21): > How on earth is it acceptable that you can publish your hobby project > under the FFmpeg project name? How on earth is it acceptable that you continue bikeshedding a feature that some users have been enthusiastically waiting for? > I have been

Re: [FFmpeg-devel] TRAC Spam

2023-09-21 Thread Michael Niedermayer
On Thu, Sep 21, 2023 at 08:52:42AM +0200, Michael Koch wrote: > The last username was "sharselune". she has been terminated thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient

Re: [FFmpeg-devel] TRAC Spam

2023-09-21 Thread Michael Niedermayer
Hi On Thu, Sep 21, 2023 at 08:52:42AM +0200, Michael Koch wrote: > The last username was "sharselune". > Can't we also delete the spam from the archive? > http://ffmpeg.org/pipermail/ffmpeg-trac/2023-September/067004.html > http://ffmpeg.org/pipermail/ffmpeg-trac/2023-September/067006.html >

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Paul B Mahol
On Thu, Sep 21, 2023 at 6:21 PM Michael Niedermayer wrote: > Hi all > > As the 6.1 release is upcoming and as it was previously stated by me that > sdr > will be part of 6.1. Heres some update of what i intend to do about that. > Very bold claim. > > People previously agreed to including a

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Kieran Kunhya via ffmpeg-devel
On Thu, Sep 21, 2023 at 5:21 PM Michael Niedermayer wrote: > OTOH If a majority of people are against the SDR code at the time of > branching 6.1. Then i will make a separate release identical to 6.1 with > the SDR code and of course also provide security support How on earth is it acceptable

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-21 Thread Michael Niedermayer
Hi all As the 6.1 release is upcoming and as it was previously stated by me that sdr will be part of 6.1. Heres some update of what i intend to do about that. People previously agreed to including a SDR input device in libavdevice with SDR in a seperate library. If the community and the SDR

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h266_syntax_template: Check num_output_layers_in_ols

2023-09-21 Thread James Almer
On 9/19/2023 12:25 PM, Nuo Mi wrote: from the specification: For each OLS, there shall be at least one layer that is an output layer. In other words, for any value of i in the range of 0 to TotalNumOlss − 1, inclusive, the value of NumOutputLayersInOls[ i ] shall be greater than or equal to 1

Re: [FFmpeg-devel] [RFC PATCH 0/3] Propagate PRFT side data

2023-09-21 Thread Clément Péron
Hi Kieran, On Thu, 21 Sept 2023 at 15:13, Kieran Kunhya wrote: > > On Thu, 21 Sept 2023, 13:17 Clément Péron, wrote: >> >> 4I have a project where I need to synchronize multiple RTSP cameras with >> other >> network sensors (sync with NTP or PTP). > > > Just be aware the clock of the vast

Re: [FFmpeg-devel] [RFC PATCH 0/3] Propagate PRFT side data

2023-09-21 Thread Kieran Kunhya
On Thu, 21 Sept 2023, 13:17 Clément Péron, wrote: > 4I have a project where I need to synchronize multiple RTSP cameras with > other > network sensors (sync with NTP or PTP). > Just be aware the clock of the vast majority of cameras have no relation to NTP or PTP so you will have drift and

Re: [FFmpeg-devel] FFmpeg release 6.1

2023-09-21 Thread Michael Niedermayer
On Wed, Sep 20, 2023 at 11:47:36PM +0100, Kieran Kunhya wrote: > > > > also iam not sure "experimental" is the right flag for code that has > > possible security issues. People might turn experimental on not realizing > > the security aspect. > > > > We should make this clear in the docs then.

[FFmpeg-devel] [RFC PATCH 3/3] HACK: avformat: rawenc: allow to output a raw PRFT

2023-09-21 Thread Clément Péron
Output the producer reference time to a dirty raw output. Signed-off-by: Clément Péron --- libavformat/rawenc.c | 122 +++ 1 file changed, 122 insertions(+) diff --git a/libavformat/rawenc.c b/libavformat/rawenc.c index f916db13a2..2953f07ec6 100644 ---

[FFmpeg-devel] [RFC PATCH 2/3] avcodec: rawenc: Forward PRFT frame data to packet

2023-09-21 Thread Clément Péron
Producer Reference time could be used in the muxing, propagate it. Signed-off-by: Clément Péron --- libavcodec/rawenc.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/rawenc.c b/libavcodec/rawenc.c index 8c577006d9..f238c8e165 100644 --- a/libavcodec/rawenc.c +++

[FFmpeg-devel] [RFC PATCH 1/3] frame: decode: propagate PRFT side data packet to frame

2023-09-21 Thread Clément Péron
Introduce a new AV_FRAME_DATA_PRFT to propagate Producer Reference Timestamp. Signed-off-by: Clément Péron --- libavcodec/decode.c | 1 + libavfilter/f_sidedata.c | 1 + libavutil/frame.c| 1 + libavutil/frame.h| 4 4 files changed, 7 insertions(+) diff --git

[FFmpeg-devel] [RFC PATCH 0/3] Propagate PRFT side data

2023-09-21 Thread Clément Péron
Dear FFMpeg contributors, I'm new to the FFMpeg code base and audio/video sync world, so forgive me in advance If my questions are a bit dumb. I have a project where I need to synchronize multiple RTSP cameras with other network sensors (sync with NTP or PTP). In my case, I used Ffmpeg to decode

Re: [FFmpeg-devel] FFmpeg release 6.1

2023-09-21 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: wtorek, 19 września 2023 21:16 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] FFmpeg release 6.1 > > On Tue, Sep 19, 2023 at 07:18:03PM +0200, Niklas Haas wrote: > >

Re: [FFmpeg-devel] [RFC PATCH 1/2] libavdevice/pipewiregrab: add pipewire based grab

2023-09-21 Thread Paul B Mahol
On Wed, Sep 20, 2023 at 8:41 PM Abhishek Ojha < abhishek.o...@savoirfairelinux.com> wrote: > This is an proof of concept for pipewire grab to enable screen capture > on wayland. Add a new Linux capture based on [1] PipeWire and the > [2] Desktop portal. > This new capture starts by asking the

[FFmpeg-devel] [PATCH] avradio/avdevice/sdrindev: -sdr_ant option

2023-09-21 Thread Peter Ross
Signed-off-by: Peter Ross --- For use with uhd device with run-time selectable antenna jack. libavdevice/sdrindev.c | 3 +++ libavformat/sdr.h | 1 + libavformat/sdrdemux.c | 1 + 3 files changed, 5 insertions(+) diff --git a/libavdevice/sdrindev.c b/libavdevice/sdrindev.c index

Re: [FFmpeg-devel] TRAC Spam

2023-09-21 Thread Michael Koch
The last username was "sharselune". Can't we also delete the spam from the archive? http://ffmpeg.org/pipermail/ffmpeg-trac/2023-September/067004.html http://ffmpeg.org/pipermail/ffmpeg-trac/2023-September/067006.html http://ffmpeg.org/pipermail/ffmpeg-trac/2023-September/067058.html