Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Nicolas George
Anton Khirnov (12023-04-24): > No actual explanation then. So I suppose what you mean is that different > rules apply to you and everyone else. No. I have said what I mean, I will not let you distort it to suit your needs. > I will, the overhead code required is trivial compared to the code

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Anton Khirnov
Quoting Nicolas George (2023-04-24 21:24:20) > Anton Khirnov (12023-04-24): > > I have no idea what you mean by this. > > Try a little harder. No actual explanation then. So I suppose what you mean is that different rules apply to you and everyone else. > > The only fact here is that the

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Nicolas George
Anton Khirnov (12023-04-24): > I have no idea what you mean by this. Try a little harder. > You keep using these words. I don't think they mean what you think they > mean. Yeah, Princess Bride references are a real boost to weak arguments. > The only fact here is that the quoted

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Anton Khirnov
Quoting Nicolas George (2023-04-24 20:31:49) > Anton Khirnov (12023-04-24): > > So when I wanted to make changes to libavfilter recently, you claimed > > your familiarity with the code makes you more qualified to judge > > readability. Now my familiarity with the code makes me LESS qualified. > >

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Paul B Mahol
On Mon, Apr 24, 2023 at 8:37 PM James Almer wrote: > On 4/24/2023 3:33 PM, Paul B Mahol wrote: > > On Mon, Apr 24, 2023 at 8:32 PM Nicolas George wrote: > > > >> Anton Khirnov (12023-04-24): > >>> So when I wanted to make changes to libavfilter recently, you claimed > >>> your familiarity with

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread James Almer
On 4/24/2023 3:33 PM, Paul B Mahol wrote: On Mon, Apr 24, 2023 at 8:32 PM Nicolas George wrote: Anton Khirnov (12023-04-24): So when I wanted to make changes to libavfilter recently, you claimed your familiarity with the code makes you more qualified to judge readability. Now my familiarity

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Paul B Mahol
On Mon, Apr 24, 2023 at 8:32 PM Nicolas George wrote: > Anton Khirnov (12023-04-24): > > So when I wanted to make changes to libavfilter recently, you claimed > > your familiarity with the code makes you more qualified to judge > > readability. Now my familiarity with the code makes me LESS

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Nicolas George
Anton Khirnov (12023-04-24): > So when I wanted to make changes to libavfilter recently, you claimed > your familiarity with the code makes you more qualified to judge > readability. Now my familiarity with the code makes me LESS qualified. > Curious. There is a difference between long-term

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Anton Khirnov
Quoting Nicolas George (2023-04-24 14:13:45) > Anton Khirnov (12023-04-24): > > What exactly is less readable? One variable gets its scope reduced, that > > is a win in my book. > > Having to remember if a field is in structure x or structure y s a net > loss that you do not see only because you

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Nicolas George
Anton Khirnov (12023-04-24): > What exactly is less readable? One variable gets its scope reduced, that > is a win in my book. Having to remember if a field is in structure x or structure y s a net loss that you do not see only because you just wrote the code and have everything freshly in mind.

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Anton Khirnov
Quoting Nicolas George (2023-04-24 13:59:43) > Anton Khirnov (12023-04-24): > > We'll have to disagree about this then. I belive lack of proper > > structure is currently the biggest problem in ffmpeg CLI. > > I do not disagree on this. But this patch does not help, it just makes > the code

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Nicolas George
Anton Khirnov (12023-04-24): > We'll have to disagree about this then. I belive lack of proper > structure is currently the biggest problem in ffmpeg CLI. I do not disagree on this. But this patch does not help, it just makes the code locally less readable. If it is to be useful at all, it is at

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Anton Khirnov
Quoting Nicolas George (2023-04-24 13:19:49) > Anton Khirnov (12023-04-24): > > Separating internal state from public interfaces is a fundamental notion > > of object-oriented programming and is completely orthogonal to that > > object being a part of a library or not. > > Using object-oriented

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Nicolas George
Anton Khirnov (12023-04-24): > Separating internal state from public interfaces is a fundamental notion > of object-oriented programming and is completely orthogonal to that > object being a part of a library or not. Using object-oriented programming to its fullest when it is not needed is a

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Anton Khirnov
Quoting Nicolas George (2023-04-24 12:20:00) > Anton Khirnov (12023-04-19): > > Start by moving OutputStream.filtered_frame to it, which really belong > > to the filtergraph rather than the output stream. > > What is the point of this? fftools/ffmpeg_filter: is not part of a > library, concepts

Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-24 Thread Nicolas George
Anton Khirnov (12023-04-19): > Start by moving OutputStream.filtered_frame to it, which really belong > to the filtergraph rather than the output stream. What is the point of this? fftools/ffmpeg_filter: is not part of a library, concepts of public/private do not apply, just put everything you

[FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-19 Thread Anton Khirnov
Start by moving OutputStream.filtered_frame to it, which really belong to the filtergraph rather than the output stream. --- fftools/ffmpeg.h | 1 - fftools/ffmpeg_filter.c | 31 ++- fftools/ffmpeg_mux.c | 1 - fftools/ffmpeg_mux_init.c | 4 4