Re: Confused about checkstyle use

Hi Alexander, Alexander Kiel wrote: Hi Vincent, Should the rule be disabled because of that? Having proper javadoc on at least public methods is very important. OTOH, this is actually not something Checkstyle can verify. How many methods in the code base have totally useless comments that

Re: Confused about checkstyle use

Hi Vincent, in Intellij Idea, I have also annoying yellow marks in my code. So if the common policy is to not violate any warning, I won't do that. Best Regards Alex - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net On Thu, 2009-10-01 at 10:41 +0100, Vincent Hennebert wrote:

Re: Confused about checkstyle use

Hi Max, First, I will respect every code style of FOP. Its just a matter of discussion. Really? That means commenting every public method even simple Getters and Setters? Yes. Simple Getter and Setters are the only place where you can publicly document private variables. (in most cases,

Re: Confused about checkstyle use

Hi Alexander, Alexander Kiel wrote: Hi Max, First, I will respect every code style of FOP. Its just a matter of discussion. Really? That means commenting every public method even simple Getters and Setters? Yes. Simple Getter and Setters are the only place where you can publicly

Re: Confused about checkstyle use

Hi Vincent, Should the rule be disabled because of that? Having proper javadoc on at least public methods is very important. OTOH, this is actually not something Checkstyle can verify. How many methods in the code base have totally useless comments that are there just to avoid a Checkstyle

Re: Confused about checkstyle use

] Sent: Sunday, September 27, 2009 4:55 PM To: fop-dev@xmlgraphics.apache.org Subject: Re: Confused about checkstyle use Hi Jonathan, did you use the checkstyle-5.0.xml from FOP or the default SUN profile? I'm currently not able to start IDEA, but two days ago as I downloaded the plugin, I

Re: Confused about checkstyle use

Hi Vincent, However, new committed code is not supposed to break any rule, neither warnings nor errors. Really? That means commenting every public method even simple Getters and Setters? Commenting equals(), hashCode() and toString()? I think, this would be only clutter. Best Regards Alex

RE: Confused about checkstyle use

Regards Alex -Original Message- From: Alexander Kiel [mailto:alexanderk...@gmx.net] Sent: Sunday, September 27, 2009 4:55 PM To: fop-dev@xmlgraphics.apache.org Subject: Re: Confused about checkstyle use Hi Jonathan, did you use the checkstyle-5.0.xml from FOP or the default SUN

Re: Confused about checkstyle use

Alex, 2009/9/28 Alexander Kiel alexanderk...@gmx.net: Hi Vincent, However, new committed code is not supposed to break any rule, neither warnings nor errors. Really? That means commenting every public method even simple Getters and Setters? Yes. Simple Getter and Setters are the only

Confused about checkstyle use

I've installed the Checkstyle plugin for IDEA and the current code when scanned by the plugin shows lots of Checkstyle errors. Here are some errors scanning BlockStackingLayoutManager.java: Missing package-info.java file (0:0) Line is longer than 80 characters. (18:0) First sentence

Re: Confused about checkstyle use

Hi Jonathan, did you use the checkstyle-5.0.xml from FOP or the default SUN profile? I'm currently not able to start IDEA, but two days ago as I downloaded the plugin, I noticed that the SUn profile was active and I had to define the FOP profile. And if you define the FOP profile, you will

RE: Confused about checkstyle use

: Sunday, September 27, 2009 4:55 PM To: fop-dev@xmlgraphics.apache.org Subject: Re: Confused about checkstyle use Hi Jonathan, did you use the checkstyle-5.0.xml from FOP or the default SUN profile? I'm currently not able to start IDEA, but two days ago as I downloaded the plugin, I noticed