DO NOT REPLY [Bug 49700] [PATCH] resolve compilation warnings

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49700 --- Comment #1 from Glenn Adams 2010-08-04 02:36:56 EDT --- Created an attachment (id=25839) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25839) Patch against revision 982124. Update patch file to add new file, FOPTextHandler

DO NOT REPLY [Bug 49700] [PATCH] resolve compilation warnings

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49700 Glenn Adams changed: What|Removed |Added Attachment #25838|0 |1 is obsolete|

DO NOT REPLY [Bug 49700] [PATCH] resolve compilation warnings

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49700 Glenn Adams changed: What|Removed |Added Attachment #25838|application/x-gzip |text/plain mime type|

DO NOT REPLY [Bug 49700] New: [PATCH] resolve compilation warnings

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49700 Summary: [PATCH] resolve compilation warnings Product: Fop Version: 1.1dev Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Co

Re: Complex Script Support - Trac Site Access

2010-08-03 Thread Glenn Adams
Vincent, Chris, et al. to clarify my earlier message, lest it be misread, i was not asking for (premature) commit access to FOP; i understand the ASF process, and have no issue with the fact that it will take time and contributions on my part to be deemed a candidate as committer; what i was doing

The complex script patch per se

2010-08-03 Thread Benson Margulies
I'm a bit confused at this point. Is there a barrier to committing the patch-to-far to the designated interim branch?

QR Barcode in FOP

2010-08-03 Thread Jayesh Nazre
We have a requirement to support QR barcode (it’s a 2D barcode type) in FOP. Does anyone know any open source product that works with FOP that generates QR barcode? FYI: barcode4j does not generate QR barcode or at least it’s not listed on their website. http://barcode4j.sourceforge.net/ Thanks f

Re: fixing and maintaining zero reported warnings policy?

2010-08-03 Thread Benson Margulies
It seems to me the following: Glenn, perhaps you could submit a separate de-warning patch or patches against trunk. That could be reviewed, applied, and downmerged into the complex script work. That might make this more manageable to the committers. I would also respectfully wonder if diffing the

Re: Complex Script Support - Trac Site Access

2010-08-03 Thread Glenn Adams
I added a Complex Scripts link under "Design Documents" heading in the FOP's wiki. G. On Tue, Aug 3, 2010 at 11:14 PM, Chris Bowditch wrote: > Glenn Adams wrote: > > Hi Glenn, > > > i hear you, but I prefer to use the mechanism I described, since I have >> control over it; until I am granted co

Re: DO NOT REPLY [Bug 49687] [PATCH] Complex Script Support

2010-08-03 Thread Glenn Adams
OK, I see from your output file that it is indeed working correctly for ArialUni, peforming both bidi and Arabic shaping, i.e., substitution of positional variants and ligatures. Would you agree? Or do you think something is amiss? G. On Tue, Aug 3, 2010 at 10:21 PM, Pascal Sancho wrote: > Glen

Re: fixing and maintaining zero reported warnings policy?

2010-08-03 Thread Glenn Adams
I don't plan to do any refactoring, just fixing warnings. The point of this is to be able to easily find new warnings introduced, and doing so is quite impractical with the current number of extant warnings. If we can get to a state of no warnings, then perhaps we can attempt to maintain that state

Re: fixing and maintaining zero reported warnings policy?

2010-08-03 Thread spepping
We have two outstanding branches. All changes you make in this work will, after they have been merged into trunk, be propagated to those branches. I would prefer to restrict the work to the new functionality, and not include other refactoring/correction of warnings. Although I admit that co

DO NOT REPLY [Bug 49695] [PATCH] Fop - replaced vars w UnitConv and GraphicsConstants

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49695 Joshua Marquart changed: What|Removed |Added Priority|P2 |P5 -- Configure bugmail: https:

DO NOT REPLY [Bug 49695] [PATCH] Fop - replaced vars w UnitConv and GraphicsConstants

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49695 --- Comment #1 from Joshua Marquart 2010-08-03 18:20:05 EDT --- Future similar patch to be applied to xmlgraphics. Also moved FOP reference to FOP UnitConv to use xmlgraphics UnitConv -- Configure bugmail: https://issues.apache.org/bugz

DO NOT REPLY [Bug 49695] New: [PATCH] Fop - replaced vars w UnitConv and GraphicsConstants

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49695 Summary: [PATCH] Fop - replaced vars w UnitConv and GraphicsConstants Product: Fop Version: all Platform: All OS/Version: All Status: NEW Severity:

Re: Complex Script Support - Trac Site Access

2010-08-03 Thread Chris Bowditch
Glenn Adams wrote: Hi Glenn, i hear you, but I prefer to use the mechanism I described, since I have control over it; until I am granted committer status, I don't have that control within ASF; i would be happy to transition when I am granted committer status; in the mean time, i will use the

DO NOT REPLY [Bug 44460] [PATCH] PDF Embedded files implementation

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44460 Jeremias Maerki changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: Complex Script Support - Trac Site Access

2010-08-03 Thread Glenn Adams
i hear you, but I prefer to use the mechanism I described, since I have control over it; until I am granted committer status, I don't have that control within ASF; i would be happy to transition when I am granted committer status; in the mean time, i will use the mechanism i described; regards, gl

Re: DO NOT REPLY [Bug 49687] [PATCH] Complex Script Support

2010-08-03 Thread Glenn Adams
(1) do you have all of the following fonts on your system? simpo.ttf, simbdo.ttf, arialuni.ttf? (2) if so, are they new versions, e.g., from Win7? (3) if so, then please send me info on the platform you are using and include the output PDF file so I may verify, also send any warnings/errors you rec

Re: fixing and maintaining zero reported warnings policy?

2010-08-03 Thread Glenn Adams
it may be difficult to agree on a particular checkstyles policy, and I really don't want to force creating or agreeing on such a policy, e.g., i don't like to break lines for some arbitrary limit and i use nested blocks and inline assignment, while others may not like that; however, i try to respec

Files in Jar

2010-08-03 Thread Eric Douglas
I'm using Eclipse if that matters. I'm trying to create a jar file containing my TTF files, so I can load them in at runtime from the classpath rather than worry about physical file paths. I would like to do the same for images. When I create a project it lets me put in any file type, but when I tr

RE: fixing and maintaining zero reported warnings policy?

2010-08-03 Thread Eric Douglas
I've wondered about that myself. I tried working with the Trunk and got countless warnings. They included dead code, deprecated methods, and unused assigned variables among other things. To sift through you could go into project specific compile options in Eclipse and tell it to ignore them if y

Re: fixing and maintaining zero reported warnings policy?

2010-08-03 Thread Vincent Hennebert
Hi Glenn, (Moving to general@ as maybe this is something we want to do at the XML Graphics project level. Please continue discussion there.) Thanks for bringing up this topic. I personally agree that a zero-warning policy would be A Good Thing. In theory newly committed code should have no Checks

Re: Complex Script Support - Trac Site Access

2010-08-03 Thread Vincent Hennebert
Hi Glenn, That sounds good but it would be preferable to work in the ASF area, mainly use FOP’s wiki: http://wiki.apache.org/xmlgraphics-fop/DeveloperPages Anyone can add content to the wiki, you just need to create an account. You can create a new page related to your work on complex scripts and

DO NOT REPLY [Bug 49687] [PATCH] Complex Script Support

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49687 --- Comment #12 from Pascal Sancho 2010-08-03 04:49:43 EDT --- (In reply to comment #8) Glenn, I do not get Character shaping when applying patch (against either trunk r981406 or Temp_ComplexScripts). The output is the same as FOP 1.0 wit

DO NOT REPLY [Bug 49687] [PATCH] Complex Script Support

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49687 --- Comment #11 from Glenn Adams 2010-08-03 04:45:56 EDT --- Created an attachment (id=25831) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25831) Simple test Arabic output PDF file. -- Configure bugmail: https://issues.apach

DO NOT REPLY [Bug 49687] [PATCH] Complex Script Support

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49687 Glenn Adams changed: What|Removed |Added Attachment #25827|0 |1 is obsolete|

fixing and maintaining zero reported warnings policy?

2010-08-03 Thread Glenn Adams
Would anyone mind if I submit a patch that fixes all the outstanding warnings, etc., reported during the build process and by checkstyles and findbugs on the trunk? More importantly, if I do this, is it possible to adhere to a zero tolerance policy on warnings for future commits? I find the 3000 o

DO NOT REPLY [Bug 49687] [PATCH] Complex Script Support

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49687 --- Comment #10 from Glenn Adams 2010-08-03 03:59:31 EDT --- For further documentation and issue tracking for this patch, see the following: https://skynav.trac.cvsdude.com/fop Regards, Glenn -- Configure bugmail: https://issues.apache.

Complex Script Support - Trac Site Access

2010-08-03 Thread Glenn Adams
In order to better communicate with those interested in this work, I have enabled an anonymous reas access to the following Trac site, with wiki, ticket, and report views enabled. https://skynav.trac.cvsdude.com/fop/wiki I will be using this site during the development process to aid in documenta

DO NOT REPLY [Bug 49687] [PATCH] Complex Script Support

2010-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49687 --- Comment #9 from Pascal Sancho 2010-08-03 03:14:45 EDT --- (In reply to comment #8) Glenn, build is OK, now. I didn't made Junit tests, I have to check my config before. Thx. -- Configure bugmail: https://issues.apache.org/bugzilla/us