Re: Confused about checkstyle use

Hi Vincent, in Intellij Idea, I have also annoying yellow marks in my code. So if the common policy is to not violate any warning, I won't do that. Best Regards Alex - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net On Thu, 2009-10-01 at 10:41 +0100, Vincent Hennebert wrote: > H

Re: Confused about checkstyle use

Hi Alexander, Alexander Kiel wrote: > Hi Vincent, > >> Should the rule be disabled because of that? Having proper javadoc on at >> least public methods is very important. OTOH, this is actually not >> something Checkstyle can verify. How many methods in the code base have >> totally useless comme

Re: Confused about checkstyle use

Hi Vincent, > Should the rule be disabled because of that? Having proper javadoc on at > least public methods is very important. OTOH, this is actually not > something Checkstyle can verify. How many methods in the code base have > totally useless comments that are there just to avoid a Checkstyle

Re: Confused about checkstyle use

Hi Alexander, Alexander Kiel wrote: > Hi Max, > > First, I will respect every code style of FOP. Its just a matter of > discussion. > >>> Really? That means commenting every public method even simple Getters >>> and Setters? >> Yes. Simple Getter and Setters are the only place where you can >> p

Re: Confused about checkstyle use

Hi Max, First, I will respect every code style of FOP. Its just a matter of discussion. > > Really? That means commenting every public method even simple Getters > > and Setters? > > Yes. Simple Getter and Setters are the only place where you can > publicly document private variables. (in most c

Re: Confused about checkstyle use

Alex, 2009/9/28 Alexander Kiel : > Hi Vincent, > >> However, new committed code is not supposed to break any rule, neither >> warnings nor errors. > > Really? That means commenting every public method even simple Getters > and Setters? Yes. Simple Getter and Setters are the only place where you c

RE: Confused about checkstyle use

rs point us to some info, why this "${samedir}" property did not work in IDEA? Best Regards Alex > -Original Message- > From: Alexander Kiel [mailto:alexanderk...@gmx.net] > Sent: Sunday, September 27, 2009 4:55 PM > To: fop-dev@xmlgraphics.apache.org > Subject: Re: Confused

Re: Confused about checkstyle use

Hi Vincent, > However, new committed code is not supposed to break any rule, neither > warnings nor errors. Really? That means commenting every public method even simple Getters and Setters? Commenting equals(), hashCode() and toString()? I think, this would be only clutter. Best Regards Alex

Re: Confused about checkstyle use

roup > InterSystems > > > -Original Message- > From: Alexander Kiel [mailto:alexanderk...@gmx.net] > Sent: Sunday, September 27, 2009 4:55 PM > To: fop-dev@xmlgraphics.apache.org > Subject: Re: Confused about checkstyle use > > Hi Jonathan, > > did you us

RE: Confused about checkstyle use

ml in FOP in the following way: Thanks again for your help!, Jonathan S. Levinson Senior Software Developer Object Group InterSystems -Original Message- From: Alexander Kiel [mailto:alexanderk...@gmx.net] Sent: Sunday, September 27, 2009 4:55 PM To: fop-dev@xmlgraphics.apache.org Subject:

Re: Confused about checkstyle use

Hi Jonathan, did you use the checkstyle-5.0.xml from FOP or the default SUN profile? I'm currently not able to start IDEA, but two days ago as I downloaded the plugin, I noticed that the SUn profile was active and I had to define the FOP profile. And if you define the FOP profile, you will pr