Thus said Martin Gagnon on Fri, 01 Nov 2013 06:52:33 -0400:
> It's ok for me, but I still think that specifying password in URL in
> interactive shell a bad idea. E.g. It got saved in shell command
> history.
I too stay away from passwords in command line shell commands and prefer
to use
Thus said Ron Wilson on Fri, 01 Nov 2013 12:10:19 -0400:
> Also, I would suggest that before prompting, Fossil determine if STDIN
> and (STDERR or STDOUT) are associate with a "console". If not, then
> Fossil is not running interactively.
The normal password prompting already checked for the p
Thus said Jan Nijtmans on Fri, 01 Nov 2013 16:53:24 +0100:
[Be aware that I have only been looking at the Fossil code for a short
time, so what I say may be inaccurate]
> 1) If a password is necessary and there is a saved password, use
> the saved password.
> 2) Otherwise, promp
On Fri, Nov 1, 2013 at 11:53 AM, Jan Nijtmans wrote:
> 2013/11/1 Richard Hipp :
> > As a QA exercise, I wonder if someone could list all of the "cases"
> together
> > with a terse description of how Fossil should handle each case. Such a
> list
> > would be enormously helpful (it seems to me) in
2013/11/1 Richard Hipp :
> I have followed the discussion only casually and have not gone into too much
> detail. But it does seem to me that there are in fact many "cases" here.
> As a QA exercise, I wonder if someone could list all of the "cases" together
> with a terse description of how Fossil
On Fri, Nov 1, 2013 at 10:34 AM, Andy Bradford wrote:
> There is one other case that needs addressing before it is complete
>
Thanks y'all for taking care of this issue, so that I can focus my
attention on other concerns (SQLite enhancements).
I have followed the discussion only casually a
Thus said Martin Gagnon on Fri, 01 Nov 2013 06:19:05 -0400:
> When I specify password from URL, it's because I don't want to be
> prompt for it, so it might be the same for the 'save password' prompt.
This thought did actually cross my mind. The question is whether or not
Fossil should as
Thus said Jan Nijtmans on Fri, 01 Nov 2013 11:11:10 +0100:
> I saw your latest commit (on "pending-review"), which apparently is
> meant to fix this. I tested it, and it works completely as I expect.
There is one other case that needs addressing before it is complete. I
sent out an email wit
2013/11/1 Martin Gagnon :
> It's ok for me, but I still think that specifying password in URL in
> interactive shell a bad idea. E.g. It got saved in shell command history.
I agree with that! But for people who DO specify the password
in the URL it's a problem: should this password be saved or n
Le 1 nov. 2013 06:38, "Jan Nijtmans" a écrit :
>
> 2013/11/1 Stephan Beal :
> > On Fri, Nov 1, 2013 at 11:19 AM, Martin Gagnon wrote:
> >>
> >> Personally, I think it shouldn't prompt to save password when
specifying
> >> it from URL. When using a interactive shell, it's better to let fossil
> >>
On Fri, Nov 1, 2013 at 11:38 AM, Jan Nijtmans wrote:
> The --once option is meant to disable saving the url/password,
> hence it also disables prompting in this case. That's what
> scripts should be using, and that's the only reliable way
> to prevent prompting.
>
That's certainly a fair argument
2013/11/1 Stephan Beal :
> On Fri, Nov 1, 2013 at 11:19 AM, Martin Gagnon wrote:
>>
>> Personally, I think it shouldn't prompt to save password when specifying
>> it from URL. When using a interactive shell, it's better to let fossil
>> prompt for the password, then it's time to ask to save it.
>
On Fri, Nov 1, 2013 at 11:19 AM, Martin Gagnon wrote:
> Personally, I think it shouldn't prompt to save password when specifying
> it from URL. When using a interactive shell, it's better to let fossil
> prompt for the password, then it's time to ask to save it.
>
FWIW: +1. Prompting in that cas
Le 1 nov. 2013 02:05, "Andy Bradford" a écrit :
>
> Thus said =?Big5?B?vEKq2qtG?= on Fri, 01 Nov 2013 13:55:50 +0800:
>
> > Great thanks, I was just wondering about that. I tried the fix and
> > works well for me, it now prompts for remembering password when
> > cloning with username+pa
2013/11/1 Andy Bradford :
> Seems the complete fix may not be as straightforward as I initially
> thought.
I saw your latest commit (on "pending-review"), which apparently is
meant to fix this. I tested it, and it works completely as I expect.
So +1 from me! Any objections?
Regards,
Hello,
I found the cause for why fossil sync --once does not use the
password embedded in the URL. sync.c calls user_select() after calling
url_parse(...), but user_select() has a call to url_parse(0, 0) which
effectively overwrites the g.urlPasswd variable:
if( zUrl==0 ){
z
16 matches
Mail list logo
