Update of bug #18396 (project freeciv):
Status:None = Fixed
Assigned to:None = jtn
Open/Closed:Open = Closed
Follow-up Comment #23, bug #18396 (project freeciv):
I wonder if line endings simply have to match those used when
freeciv.pot has been created (msgstrs collected)...
By accident, I found that that is the case, yes. However, relying on this
will be fraught when cross-compiling.
Follow-up Comment #24, bug #18396 (project freeciv):
Status of this ticket:
* Option translation fix is straightforward, committed, and will be in
2.3.0-RC2.
* Help translation is more involved:
** We know it's a line-ending issue.
** I found an issue with opening files in binary mode that came
Follow-up Comment #25, bug #18396 (project freeciv):
I wonder if line endings simply have to match those used when
freeciv.pot has been created (msgstrs collected)...
By accident, I found that that is the case, yes. However,
relying on this will be fraught when cross-compiling.
Ouch. Any
Follow-up Comment #26, bug #18396 (project freeciv):
I wonder if line endings simply have to match those used when
freeciv.pot has been created (msgstrs collected)...
By accident, I found that that is the case, yes. However,
relying on this will be fraught when cross-compiling.
Ouch. Any
Follow-up Comment #22, bug #18396 (project freeciv):
I wonder if line endings simply have to match those used when freeciv.pot has
been created (msgstrs collected)...
___
Reply to this item at:
http://gna.org/bugs/?18396
Follow-up Comment #15, bug #18396 (project freeciv):
Here's a patch patch which should fix the binary-mode thing I spotted in
fz_from_file(). As expected, makes no difference on Unix.
Can someone make a Windows S2_3 build with this patch, so we can see if it
helps with the help issue? Doesn't
Update of bug #18396 (project freeciv):
Planned Release: 2.3.1,2.4.0 = 2.3.0,2.4.0
___
Reply to this item at:
http://gna.org/bugs/?18396
___
Message sent
Follow-up Comment #16, bug #18396 (project freeciv):
Can someone make a Windows S2_3 build with this patch, so we can
see if it helps with the help issue?
I think I can. If I understand correctly, in addition to applying your patch
I should also unix2dos helpdata.txt? Or do I just leave it to
Follow-up Comment #17, bug #18396 (project freeciv):
in addition to applying your patch I should also unix2dos
helpdata.txt? Or do I just leave it to you?
I can do that bit myself. I'll test both ways round, of course.
___
Reply to
Follow-up Comment #18, bug #18396 (project freeciv):
Umh, did you attach wrong patch? File is named ...typos... (not anything
about binary mode) and contents seem to fit that name.
___
Reply to this item at:
http://gna.org/bugs/?18396
Follow-up Comment #19, bug #18396 (project freeciv):
Bother, sorry! Try this one.
(file #13687)
___
Additional Item Attachment:
File name: trunk-S2_3-bz2-binary-file.diff Size:1 KB
On 28 July 2011 23:59, Marko Lindqvist no-reply.invalid-addr...@gna.org wrote:
Follow-up Comment #16, bug #18396 (project freeciv):
Can someone make a Windows S2_3 build with this patch, so we can
see if it helps with the help issue?
I think I can.
Compiling... This time I'll test
On 29 July 2011 00:45, Marko Lindqvist cazf...@gmail.com wrote:
On 28 July 2011 23:59, Marko Lindqvist no-reply.invalid-addr...@gna.org
wrote:
Follow-up Comment #16, bug #18396 (project freeciv):
Can someone make a Windows S2_3 build with this patch, so we can
see if it helps with the help
Follow-up Comment #20, bug #18396 (project freeciv):
Trunk version attached.
If this doesn't solve the problem, then plan B is something along the lines
of patch #2843, but I don't think that's something I'd want to rush into RC2.
(file #13689)
Follow-up Comment #21, bug #18396 (project freeciv):
(one Windows build later)
Sadly, this patch doesn't appear to change the behaviour wrt the help
localisation :(
___
Reply to this item at:
http://gna.org/bugs/?18396
Marko Lindqvist writes:
On 28 July 2011 23:59, Marko Lindqvist no-reply.invalid-addr...@gna.org
wrote:
Can someone make a Windows S2_3 build with this patch, so we can
see if it helps with the help issue?
I think I can.
Compiling... This time I'll test providing all of freeciv in
Follow-up Comment #12, bug #18396 (project freeciv):
Looking at the code, the decision whether to open the file in
r (text) or rb (binary) mode seems to be in fz_from_file().
I'm slightly suspicious of this code [...]
That probably is the change that break things between 2.2 and
2.3. bz2
Follow-up Comment #9, bug #18396 (project freeciv):
Long term goal of always using Windows line endings on Windows would mean
that build process from tarball would need to convert text files. - Surely
this can be automated with unix2dos or similar?
Or should we provide .tar with unix line
Follow-up Comment #10, bug #18396 (project freeciv):
Long term goal of always using Windows line endings on Windows
would mean that build process from tarball would need to convert
text files. - Surely this can be automated with unix2dos or
similar?
Yes, conversion itself is almost trivial
Follow-up Comment #11, bug #18396 (project freeciv):
Opened separate ticket, patch #2829, for providing data files with native
line endings.
___
Reply to this item at:
http://gna.org/bugs/?18396
Follow-up Comment #3, bug #18396 (project freeciv):
Thanks for the settings patches :)
The help section does have odd fixed line endings, the English version too
(attached screenshots with a wide and a narrow window in Polish and a wide
window in English, but the narrow English window acts the
Follow-up Comment #4, bug #18396 (project freeciv):
I think the lack of localisation of Windows help is related to line endings,
and is a bit of a can of worms (so probably merits more ticket(s)).
I installed the standard 2.3.0-RC1 Windows installer (and also one of cproc's
pre-RC1 builds) and
Follow-up Comment #5, bug #18396 (project freeciv):
... in cazfi's S2_3 builds ... localisation doesn't seem to
work at all; maybe it's not compiled in
It's not compiled in as it wouldn't work with how these binaries are
installed. It's not easy task for me to enable localization support in
Follow-up Comment #6, bug #18396 (project freeciv):
(I haven't even thought about whether there's a problem with Mac-style line
endings. Are they still even relevant, or did they die with the classic Mac
OS?)
Yes, the Carriage Return went out with classic. OSX is built on a BSD
kernel, and
Follow-up Comment #7, bug #18396 (project freeciv):
Looking at the code, the decision whether to open the file in
r (text) or rb (binary) mode seems to be in fz_from_file().
I'm slightly suspicious of this code; it seems to me that if
HAVE_LIBBZ2 is defined, the probing code leaves b in the
Follow-up Comment #8, bug #18396 (project freeciv):
As my builds are cross-compiled from linux, text files originate from linux
svn checkout (or in some cases: export)
Long term goal of always using Windows line endings on Windows would mean
that build process from tarball would need to convert
URL:
http://gna.org/bugs/?18396
Summary: Translations for help and options not displayed
Project: Freeciv
Submitted by: hubkow
Submitted on: Fri 22 Jul 2011 01:35:42 PM CEST
Category: client-gtk-2.0
Additional Item Attachment, bug #18396 (project freeciv):
File name: untranslated-geological.PNGSize:400 KB
___
Reply to this item at:
http://gna.org/bugs/?18396
___
Message sent
Update of bug #18396 (project freeciv):
Planned Release: = 2.3.1,2.4.0
___
Follow-up Comment #1:
I can reproduce the options issues on Linux with the French localisation, and
I'm got a pretty
Follow-up Comment #2, bug #18396 (project freeciv):
Patches attached for settings bug. Help bug still a mystery. If it drags on,
we should split it into a separate ticket.
(file #13634, file #13635)
___
Additional Item Attachment:
File
31 matches
Mail list logo
