Update of patch #4832 (project freeciv):
Status: Ready For Test = Wont Do
___
Follow-up Comment #3:
Thinking about these criticisms, I won't apply this patch, as it makes more
sense to properly
Follow-up Comment #12, bug #22194 (project freeciv):
So, what should I do with this? Reduce movepoints to lowest terms:
* always?
* only in selected situations in the help, e.g. * Ignores terrain effects
(moving costs at most 1/3 MP per tile) even with 9 move_fragments?
* never?
* something else?
Follow-up Comment #13, bug #22194 (project freeciv):
only in selected situations
That's the only way to get it always right, I think. Isn't it quite simple by
adding boolean parameter for move_points_text()?
The only thing where I've noticed current code to be broken is the active unit
display
Follow-up Comment #5, bug #22136 (project freeciv):
Thank you for this general cleanup. I've had a look wrt things like bug #16188
and I think it's correct.
___
Reply to this item at:
http://gna.org/bugs/?22136
Update of patch #4831 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #4832 (project freeciv):
Open/Closed:Open = Closed
___
Reply to this item at:
http://gna.org/patch/?4832
___
Message sent
Update of bug #5 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
URL:
http://gna.org/patch/?4834
Summary: Check move_fragments and igter_cost 0 on ruleset
load
Project: Freeciv
Submitted by: jtn
Submitted on: Sun 22 Jun 2014 12:10:44 BST
Category: None
Priority: 5 -
Update of patch #4834 (project freeciv):
Status: In Progress = Ready For Test
___
Additional Item Attachment:
File name: trunk-movefrags-sanitycheck.patch Size:17 KB
File name:
Update of bug #22194 (project freeciv):
Status: Fixed = Ready For Test
___
Follow-up Comment #14:
only in selected situations
That's the only way to get it always right, I think. Isn't it
Follow-up Comment #2, bug #22167 (project freeciv):
We could use the Natural flag to distinguish river from
roads, and mix it in with the terrains, as on S2_4?
If I do this, I'd like to remove Cannot be built for natural extras as
clutter.
Should we enforce at ruleset load time that Natural
Follow-up Comment #3, bug #22167 (project freeciv):
For all unbuildable extras (whether Natural or not, and whether true
extras(trunk), or constituent pieces(2_5)), I think it makes sense to drop the
Cannot be built entry, and instead represent this in the build cost (shown
above the text in the
Follow-up Comment #5, patch #4819 (project freeciv):
Thanks for catching this! I've created bug #22232 for tracking (and follow-on
discussion).
___
Reply to this item at:
http://gna.org/patch/?4819
URL:
http://gna.org/bugs/?22232
Summary: Rulesave fails to save pythagorean_diagnonal==FALSE
for RS_DEFAULT_PYTHAGOREAN_DIAGONAL==TRUE sources
Project: Freeciv
Submitted by: persia
Submitted on: Mon 23 Jun 2014 12:20:10 AM JST
Follow-up Comment #1, bug #22230 (project freeciv):
Here are two backtraces showing crashes in pf_normal_map_move_cost, generated
from core dumps from Freeciv-web running SVN revision 25224.
#0 pf_normal_map_iterate_until (ptile=0x0, pfnm=0x25bf2c0) at
path_finding.c:684
pfm = 0x25bf2c0
Follow-up Comment #2, bug #22230 (project freeciv):
I've tried, but can't replicate the specific crash here, but I have been able
to get some other pathfinding crashes. All appear to involve ptile being NULL
(as do the three attached stacktraces), which can happen (at least) when
initialising
Follow-up Comment #2, patch #4799 (project freeciv):
This patch would benefit also from an update to doc/README.effects, removing
the IgWall comment from the Defend_Bonus explanation.
___
Reply to this item at:
Update of patch #4828 (project freeciv):
Status: Ready For Test = Done
Assigned to:None = cazfi
Open/Closed:Open = Closed
Follow-up Comment #3, patch #4799 (project freeciv):
- Updated to apply against curretn svn HEAD
- Updated README.effects
(file #21116)
___
Additional Item Attachment:
File name: IgWallRm-3.patch.bz2 Size:6 KB
Follow-up Comment #3, bug #22230 (project freeciv):
Here's a similar backtrace in the pathfinding code:
#0 0x004ce912 in aiferry_find_boat (ait=ait@entry=0x8c2980
ai_types, punit=punit@entry=0x24e3660,
cap=cap@entry=1, path=path@entry=0x0) at aiferry.c:555
radius = optimized
Update of patch #4824 (project freeciv):
Status: Ready For Test = Done
Assigned to:None = cazfi
Open/Closed:Open = Closed
Update of bug #7 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
URL:
http://gna.org/patch/?4835
Summary: Sdl2-client Coding Style corrections
Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 23 Jun 2014 03:17:27 AM EEST
Category: client-sdl2
Priority: 5 - Normal
URL:
http://gna.org/patch/?4836
Summary: Ignore nativity-providing extras for simple types
Project: Freeciv
Submitted by: persia
Submitted on: Mon 23 Jun 2014 09:27:10 AM JST
Category: ai
Priority: 5 -
Update of patch #4808 (project freeciv):
Status: Ready For Test = Done
Assigned to:None = cazfi
Open/Closed:Open = Closed
URL:
http://gna.org/patch/?4837
Summary: Use pathfinding to identify missile carrier risk
Project: Freeciv
Submitted by: persia
Submitted on: Mon 23 Jun 2014 09:35:09 AM JST
Category: ai
Priority: 5 -
URL:
http://gna.org/patch/?4838
Summary: Use UTYF_BADCITYDEFENDER in process_defender_want()
Project: Freeciv
Submitted by: persia
Submitted on: Mon 23 Jun 2014 09:43:47 AM JST
Category: ai
Priority: 5 -
URL:
http://gna.org/patch/?4839
Summary: Cleanups in dai_is_unit_tired_waiting_boat()
Project: Freeciv
Submitted by: persia
Submitted on: Mon 23 Jun 2014 09:50:19 AM JST
Category: ai
Priority: 5 - Normal
URL:
http://gna.org/patch/?4840
Summary: Automake-NG
Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 23 Jun 2014 04:12:09 AM EEST
Category: bootstrap
Priority: 5 - Normal
Status:
Update of patch #4814 (project freeciv):
Status: Ready For Test = Done
Assigned to:None = cazfi
Open/Closed:Open = Closed
Follow-up Comment #9, patch #4830 (project freeciv):
Thanks for the updates: this is lots cleaner and easier to work with.
Applies smoothly over r25244, and builds.
Naming:
Most of the rest of the codebase uses singular nouns for most purposes,
with plural nouns only used when specifically
Follow-up Comment #10, patch #4830 (project freeciv):
Oh, and I forgot, there probably ought be some way the ruleset author can
supply helptext for each multiplier, and a facility in client/helpdata.c to
parse that and display it in the online help.
URL:
http://gna.org/patch/?4841
Summary: Consider defense effects for any defender
Project: Freeciv
Submitted by: persia
Submitted on: Mon 23 Jun 2014 01:37:35 PM JST
Category: ai
Priority: 5 - Normal
33 matches
Mail list logo
