Follow-up Comment #1, bug #15305 (project freeciv):
good catch! It's best to free allocated memory within the code.
As I'm not so familiar with pointers and allocation of memory a question to
the functions used:
For both pointers (city_map_index and map.iterate_outwards_indices)
fc_realloc
It's really noticeable in Arabic and Hebrew, where writing order it
right to left. Having a left to right name in a middle of a
right-to-left sentence makes things a bit difficult to read, so it
seems like a good idea to me.
On Mon, Feb 8, 2010 at 11:31 AM, Sini Ruohomaa
Hi,
It appears that there might be a point in making default ruler names
translateable, since their spelling actually differs from one language
to the other. I haven't glimpsed at an up-to-date po file in quite a few
months so I assume they haven't become translateable just now. O:)
For example:
Follow-up Comment #3, bug #15104 (project freeciv):
Yes, and both patches were ready. Though I'm not sure I will be able to
commit before late February.
___
Reply to this item at:
http://gna.org/bugs/?15104
Follow-up Comment #4, bug #15104 (project freeciv):
Though I'm not sure I will be able to commit before late
February.
So I will probably commit it for you to have it included in 2.2.0...
___
Reply to this item at:
URL:
http://gna.org/bugs/?15309
Summary: fix tmap_y2str(); mixed up ysize and xsize
Project: Freeciv
Submitted by: syntron
Submitted on: Montag 08.02.2010 um 15:48
Category: general
Severity: 3 - Normal
URL:
http://gna.org/bugs/?15310
Summary: fix creation of tropical temperature range
Project: Freeciv
Submitted by: syntron
Submitted on: Montag 08.02.2010 um 15:49
Category: general
Severity: 3 - Normal
URL:
http://gna.org/bugs/?15311
Summary: update definition of ice_base_colatitude
Project: Freeciv
Submitted by: syntron
Submitted on: Montag 08.02.2010 um 15:51
Category: general
Severity: 3 - Normal
URL:
http://gna.org/bugs/?15312
Summary: add check for ptile == NULL within map_colatitude()
Project: Freeciv
Submitted by: syntron
Submitted on: Montag 08.02.2010 um 15:52
Category: general
Severity: 3 -
Update of bug #14944 (project freeciv):
Status:None = Ready For Test
Assigned to:None = syntron
Planned Release: 2.3.0 = 2.2.0
Follow-up Comment #7, bug #14944 (project freeciv):
It seems to be that I'm not able to change the settings for
this patch.
worked now ...
___
Reply to this item at:
http://gna.org/bugs/?14944
Follow-up Comment #3, patch #1444 (project freeciv):
Is it really such a slowdown to save a message in a string? I
don't know how often the settings code is called and how much
time one call needs ...
It is not that slow. But the code is called tons of times. Every time
someone connects,
Follow-up Comment #1, bug #15312 (project freeciv):
assert() should be depreciated in newer version. Prefer the log_assert_ret()
macro or RETURN_IF_FAIL() in S2_2.
(I'm currently working on a patch to remove all assert() calls).
___
Update of bug #15286 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #15290 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
URL:
http://gna.org/bugs/?15313
Summary: No way to airlift unit to/from allied cities
Project: Freeciv
Submitted by: pepeto
Submitted on: lundi 08.02.2010 à 15:54
Category: client
Severity: 2 - Minor
Update of bug #15313 (project freeciv):
Depends on: = patch #1189
___
Reply to this item at:
http://gna.org/bugs/?15313
___
Message posté
Update of patch #1189 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #9, patch #1200 (project freeciv):
Some comments:
Thanks for the comments. They are included in the attached patch.
(file #8000)
___
Additional Item Attachment:
File name: 20100208-trunk-game-settings-can-be-locked
Follow-up Comment #2, bug #15312 (project freeciv):
assert() should be depreciated in newer version. Prefer the
log_assert_ret() macro or RETURN_IF_FAIL() in S2_2.
I thought about this but did not know that to safely return? map_colatitude()
should return the colatitude. Should I use 0,
Follow-up Comment #4, patch #1444 (project freeciv):
OK; next try ... ;-)
replace char '**reject_msg' by 'char *reject_msg, size_t reject_msg_len'
use a new macro to check if reject_msg is NULL
(file #8002)
___
Additional Item
Follow-up Comment #3, bug #15305 (project freeciv):
I guess it wasn't a very good patch.
I would not say that. It is good to know that here a call to free() is
missing!
The original code was written by jdorje and glip back in 2004.
Hopefully they can tell us what is the right thing to do.
Follow-up Comment #3, bug #15291 (project freeciv):
I haven't actually looked at the tutorial scenario yet. Probably it wasn't
updated after the command key revamp (patch #1188). I'll commit your patch
soon, and add reviewing the tutorial for other issues to my list (although I
don't know if
Update of bug #15292 (project freeciv):
Status: Ready For Test = In Progress
___
Reply to this item at:
http://gna.org/bugs/?15292
___
Message sent
Update of bug #15292 (project freeciv):
Status: In Progress = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #15291 (project freeciv):
Status: Ready For Test = In Progress
___
Reply to this item at:
http://gna.org/bugs/?15291
___
Message sent
Update of bug #15291 (project freeciv):
Status: In Progress = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
URL:
http://gna.org/bugs/?15316
Summary: Refresh tutorial scenario for 2.2
Project: Freeciv
Submitted by: jtn
Submitted on: Monday 08/02/10 at 21:36
Category: docs
Severity: 3 - Normal
Update of patch #1401 (project freeciv):
Depends on: = bugs #15316
___
Reply to this item at:
http://gna.org/patch/?1401
___
Message sent
Follow-up Comment #10, patch #1200 (project freeciv):
Typo in civ2 ruleset:
; freeciv game settings for the civ1 ruleset
___
Reply to this item at:
http://gna.org/patch/?1200
___
Message
Follow-up Comment #3, bug #15312 (project freeciv):
Perhaps 'MAX_COLATITUDE / 2'
Seems a good compromise. Unfortunately, file #8001 appears to compile on
trunk only, not S2_2.
___
Reply to this item at:
http://gna.org/bugs/?15312
Follow-up Comment #5, patch #1444 (project freeciv):
Very big improvement!
One tip about the code: you can use _(string) as a c-format, no need to set
%s, (yes, it's not logical because it is also a value returned by a
function, but gcc allow it).
Maybe some message could be improved, notably
Update of bug #15314 (project freeciv):
Priority: 5 - Normal = 7 - High
___
Reply to this item at:
http://gna.org/bugs/?15314
___
Message posté
Follow-up Comment #4, bug #15305 (project freeciv):
In current branches like S2_2 and trunk, I can affirm you that now the game
and the map are freed in client side when the client is disconnected; so
using malloc would be correct nowadays. (I'm not sure about S2_1).
Update of bug #15315 (project freeciv):
Status:None = Ready For Test
Release: = trunk
Planned Release: = 2.3.0
Follow-up Comment #1, bug #15316 (project freeciv):
Yes, I found it too when working on the French translation.
___
Reply to this item at:
http://gna.org/bugs/?15316
___
Message posté
Follow-up Comment #5, bug #15305 (project freeciv):
Unfortunately, it seems it doesn't in server side...
___
Reply to this item at:
http://gna.org/bugs/?15305
___
Message posté via/par
Update of bug #15315 (project freeciv):
Status:None = Ready For Test
___
Reply to this item at:
http://gna.org/bugs/?15315
___
Message posté
Update of bug #15314 (project freeciv):
Category: client = client-gtk-2.0
Status:None = Ready For Test
Assigned to:None = pepeto
Planned Release:
URL:
http://gna.org/bugs/?15317
Summary: Confusing to refer to corruption as Waste in city
dialog popup
Project: Freeciv
Submitted by: jtn
Submitted on: Monday 08/02/10 at 23:09
Category: None
Severity: 3
Update of bug #15315 (project freeciv):
Assigned to:None = pepeto
Planned Release: = 2.3.0
___
Reply to this item at:
Update of bug #15317 (project freeciv):
Status:None = Ready For Test
Planned Release: = 2.2.0
___
Additional Item Attachment:
File name:
Follow-up Comment #1, bug #15317 (project freeciv):
It's theoretically possible to create food loss through the effects system
...and, I think, other output types like science/luxury. Same comment.
___
Reply to this item at:
Daniel Markstedt writes:
We have very nearly resolved all bugs targeted for 2.2.0 final
release. As a result, a Release Candidate for 2.2.0 scheduled is
planned to be released on February 14.
Is the creation of this release candidate intended to start a string
freeze?
Follow-up Comment #6, bug #15305 (project freeciv):
Here is my second attempt at a patch. This time around, the idea is to make
memory management for city.c : city_map_index and map.c :
map.iterate_outwards_indices work exactly the same way as it does for
map.tiles.
This time calls to realloc
URL:
http://gna.org/bugs/?15319
Summary: Military units don't make citizens quite unhappy
enough
Project: Freeciv
Submitted by: jtn
Submitted on: Tuesday 09/02/10 at 01:16
Category: None
Severity: 3 -
URL:
http://gna.org/patch/?1459
Summary: Help: clarify which buildings/wonders help with
military unhappiness
Project: Freeciv
Submitted by: jtn
Submitted on: Tuesday 09/02/10 at 02:50
Category: docs
Update of patch #1401 (project freeciv):
Depends on: = patch #1459
___
Reply to this item at:
http://gna.org/patch/?1401
___
Message sent
Update of bug #15317 (project freeciv):
Status: Ready For Test = None
Summary: Confusing to refer to corruption as Waste in city
dialog popup = Confusing to refer to non-shield loss (e.g. corruption) as
Waste
Update of bug #15317 (project freeciv):
Status:None = Ready For Test
Depends on: = patch #1459
___
Reply to this item at:
50 matches
Mail list logo
