[Freeciv-Dev] [bug #15498] crash in remove_trade_route() - fc_assert_action()?

2010-02-27 Thread Matthias Pfafferodt
URL: http://gna.org/bugs/?15498 Summary: crash in remove_trade_route() - fc_assert_action()? Project: Freeciv Submitted by: syntron Submitted on: Samstag 27.02.2010 um 13:54 Category: general Severity: 3

[Freeciv-Dev] [bug #15498] crash in remove_trade_route() - fc_assert_action()?

2010-02-27 Thread pepeto
Follow-up Comment #1, bug #15498 (project freeciv): Related question: I added an assert() call to fc_assert_fail() to get the core dump. How can / should I debug this without adding assert() again? Start with _-F_ to raise the SIG_ABRT signal, or _-F sig_ to raise the signal you want.

[Freeciv-Dev] [bug #15499] Wrong handle of the illness_trade stuff

2010-02-27 Thread pepeto
URL: http://gna.org/bugs/?15499 Summary: Wrong handle of the illness_trade stuff Project: Freeciv Submitted by: pepeto Submitted on: samedi 27.02.2010 à 13:30 Category: client Severity: 3 - Normal

[Freeciv-Dev] [bug #15499] Wrong handle of the illness_trade stuff

2010-02-27 Thread Matthias Pfafferodt
Follow-up Comment #1, bug #15499 (project freeciv): This was cased by me applying the patch to fast. I will create a fix for it. The tests affect the client capability, which will always return TRUE because we have this capability. The server would affect the server capability

[Freeciv-Dev] [bug #15499] Wrong handle of the illness_trade stuff

2010-02-27 Thread pepeto
Follow-up Comment #2, bug #15499 (project freeciv): The tests affect the client capability, which will always return TRUE because we have this capability. The server would affect the server capability (client.conn.capability). Is it enough to use 'client.conn.capability' in the test to do

[Freeciv-Dev] [patch #1222] function to access information for different radii

2010-02-27 Thread pepeto
Update of patch #1222 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?1222 ___ Message

[Freeciv-Dev] [bug #15484] Improve translation sq. mi., M tons, M goods, bulbs

2010-02-27 Thread Andrej Svininykh
Follow-up Comment #4, bug #15484 (project freeciv): I think and I agree with you. If used abbreviation for M tons and M goods ( млн. тон and млн. товаров in Russia) the plural form isn't necessary. For sq. mi. needs plural form (1 кв. миля, 2 кв. мили or 5 кв. миль). There is no

[Freeciv-Dev] [bug #15499] Wrong handle of the illness_trade stuff

2010-02-27 Thread Matthias Pfafferodt
Follow-up Comment #3, bug #15499 (project freeciv): still working on it. There are some strange things happening. I have compiled 2.2.0 and S2_2 with the patch and I'm trying to test the combination old server - new client. I added only an additional output line printing client.conn.capability

[Freeciv-Dev] [bug #15499] Wrong handle of the illness_trade stuff

2010-02-27 Thread pepeto
Follow-up Comment #4, bug #15499 (project freeciv): Somethere the server changed its capabilities ... ? I don't think so. I cannot reproduce, but I think you connected an old server just before and you are using non-initialized datas. The capability string of the server is set in

[Freeciv-Dev] [bug #15499] Wrong handle of the illness_trade stuff

2010-02-27 Thread pepeto
Follow-up Comment #5, bug #15499 (project freeciv): Ouch, I found what is wrong... handle_conn_info() overwrite with the server capability with our capability... ___ Reply to this item at: http://gna.org/bugs/?15499

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

2010-02-27 Thread Matthias Pfafferodt
(?) also be valid for trunk ___ File Attachments: --- Date: Samstag 27.02.2010 um 20:04 Name: 20100227-S2_2-do-not-change-the-status-of-the-connection-of-the-cl.patch Size: 920B

[Freeciv-Dev] [bug #15499] Wrong handle of the illness_trade stuff

2010-02-27 Thread Matthias Pfafferodt
window as well as in the illness popup patch attached (file #8311) ___ Additional Item Attachment: File name: 20100227-S2_2-fix-health-capability-check.patch Size:0 KB ___ Reply

[Freeciv-Dev] [bug #15499] Wrong handle of the illness_trade stuff

2010-02-27 Thread Matthias Pfafferodt
Update of bug #15499 (project freeciv): Depends on: = bugs #15500 ___ Reply to this item at: http://gna.org/bugs/?15499 ___ Nachricht

[Freeciv-Dev] [bug #15499] Wrong handle of the illness_trade stuff

2010-02-27 Thread Matthias Pfafferodt
Follow-up Comment #7, bug #15499 (project freeciv): Ouch, I found what is wrong... handle_conn_info() overwrite with the server capability with our capability... I needed a little bit longer to validate this fact ;-) A hack to prevent this can be found in bug #15500

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

2010-02-27 Thread pepeto
Follow-up Comment #1, bug #15500 (project freeciv): I would prefer the test if (pconn != client.conn). ___ Reply to this item at: http://gna.org/bugs/?15500 ___ Message posté via/par Gna!

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

2010-02-27 Thread Matthias Pfafferodt
the test if (pconn != client.conn). Done. Furthermore all data of the connection is included within the condition. Patch for S2_2 and trunk (file #8312) ___ Additional Item Attachment: File name: version2-20100227-S2_2-do-not-change

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

2010-02-27 Thread pepeto
Follow-up Comment #3, bug #15500 (project freeciv): Ouch, this is very dangerous, the client won't know anymore what is its current state (e.g. player target, observing state, etc)... This item really need more work. ___ Reply to this

[Freeciv-Dev] [bug #15328] Asked for the name of a city but you can't fund it

2010-02-27 Thread pepeto
Update of bug #15328 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15468] map_is_known_and_seen segfault

2010-02-27 Thread pepeto
Update of bug #15468 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15469] Received packet PLAYER_READY from non-player connection

2010-02-27 Thread pepeto
Update of bug #15469 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #6: Fix included by

[Freeciv-Dev] [bug #15480] Server start when connection leaves

2010-02-27 Thread pepeto
Update of bug #15480 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15456] api_actions_change_gold() crash

2010-02-27 Thread pepeto
Update of bug #15456 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1484] struct server_option

2010-02-27 Thread pepeto
Update of patch #1484 (project freeciv): Privacy: Public = Private Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1488] Remove g_return_if_fail

2010-02-27 Thread pepeto
Update of patch #1488 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15347] Bad drawing and floating point exception with trade route line drawing in SDL client

2010-02-27 Thread pepeto
Follow-up Comment #9, bug #15347 (project freeciv): I am sorry, I cannot reproduce this crash, even with 1680x1050 resolution. (I also noticed that long diagonal lines generated in stages during scrolling aren't pixel perfect; they look lumpy and occasionally don't join by a pixel or so.

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

2010-02-27 Thread Matthias Pfafferodt
; edit mode on / off; leave * (re)connect as player; leave * (re)connect using another user name; leave (file #8314) ___ Additional Item Attachment: File name: version3-20100227-S2_2-do-not-change-the-status-of-the-connection

[Freeciv-Dev] [bug #15477] Untranslated strings + wrong part of speech in scenario victory

2010-02-27 Thread Jacob Nevins
Update of bug #15477 (project freeciv): Status: Ready For Test = In Progress ___ Reply to this item at: http://gna.org/bugs/?15477 ___ Message sent

[Freeciv-Dev] [bug #15477] Untranslated strings + wrong part of speech in scenario victory

2010-02-27 Thread Jacob Nevins
Update of bug #15477 (project freeciv): Status: In Progress = Fixed Open/Closed:Open = Closed ___ Reply to this item at: