[Freeciv-Dev] [bug #15658] Crash (due to invalid character?)

2010-03-20 Thread pepeto

Follow-up Comment #1, bug #15658 (project freeciv):

See also bug #15552, bug #15377.


___

Reply to this item at:

  http://gna.org/bugs/?15658

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15658] Crash (due to invalid character?)

2010-03-20 Thread pepeto

Update of bug #15658 (project freeciv):

Category:None = client-gtk-2.0 
  Status:None = Confirmed  

___

Follow-up Comment #2:

 See also bug #15552, bug #15377.

Seems not linked, sorry.

 The game crashes.

Mine doesn't, but I have lot of pango warnings.


___

Reply to this item at:

  http://gna.org/bugs/?15658

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15624] [RFC] scripting: Sandbox Lua scripts

2010-03-20 Thread Ulrik Sverdrup

Follow-up Comment #4, bug #15624 (project freeciv):

Ok, no not really. Feel free to work on this. I will type up documentation
later. What will happen to 2.1? It looks like it is still using Lua 5.0 while
2.2 is using 5.1.

___

Reply to this item at:

  http://gna.org/bugs/?15624

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15644] Add server command to run freeciv script

2010-03-20 Thread Ulrik Sverdrup

Follow-up Comment #2, bug #15644 (project freeciv):

Yes, security is absolutely a concern. I didn't think about it before but:
Hack access makes sense for the free scripting command /lua. However in
reality we should allow this at CTRL access. Ideally, scripts can not
influence the server, only the game, so CTRL access would be more
consistent.

However, every security hole in our script runtime, turns into a remote hole
if we allow CTRL access to /lua. Here is an alternative idea to think about:

Allow triggers that are similar to the current signal.connect(..) approach.
You may register any function call as a custom-named trigger:

in ruleset or scenario script:

function create_new_player()
..
end
trigger.connect(createplayer, create_new_player)

---

Then we add a /trigger command. The gamemaster or anyone with CTRL access may
then say /trigger createnewplayer

So the ruleset may setup triggers like this, and they can be triggered at any
time. However it is not as flexible as /lua. Both could be implemented in
parallel, with /lua only having hack access. Of course, if we gain trust in
our security solution for the script runtime, we can put the free version
under CTRL access instead.

___

Reply to this item at:

  http://gna.org/bugs/?15644

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15624] [RFC] scripting: Sandbox Lua scripts

2010-03-20 Thread pepeto

Follow-up Comment #5, bug #15624 (project freeciv):

 Ok, no not really. Feel free to work on this. I will type up documentation
later.

I thought it was ready. It's a big security problem. Maybe documentation
could be done later.

 What will happen to 2.1? It looks like it is still using Lua 5.0
 while 2.2 is using 5.1.

It will stay like this.


___

Reply to this item at:

  http://gna.org/bugs/?15624

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15644] Add server command to run freeciv script

2010-03-20 Thread pepeto

Follow-up Comment #3, bug #15644 (project freeciv):

Probably the CTRL access is a bit too low for lot of things. Remember that
those command are available from vote (or if someone is alone on a server,
all votes pass). Notably to read a script from a file. Maybe will we have to
think about many lua command levels. Then HACK would have full access to the
functions, ADMIN a bit restricted and CTRL again more?


___

Reply to this item at:

  http://gna.org/bugs/?15644

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15658] Crash (due to invalid character?)

2010-03-20 Thread pepeto

Follow-up Comment #3, bug #15658 (project freeciv):

Seems really the same as bug #15377 finally.


___

Reply to this item at:

  http://gna.org/bugs/?15658

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15624] [RFC] scripting: Sandbox Lua scripts

2010-03-20 Thread Ulrik Sverdrup

Follow-up Comment #6, bug #15624 (project freeciv):

I agree that the security issue is very important. The caveat is that just
because we think it works doesn't mean that it does, security is hard,
especially with a runtime that we don't know so well :-)

Luckily, the lua runtime is very small. We can investigate not even loading
the os and io libraries, however that adds more code (and can only be done
with lua calls, not C calls in 5.1?).

What is important now is that all script code is executed inside our setfenv
environment, and that none of the remaining functions can give the script
access to the outside global environment (like getfenv, load, require, module
etc could do).

I have not investigated if there are any holes in tolua. The tolua module
(providing tolua.type that we need inside the restricted environment) has
also not been investigated.

Notice that we may replace all modules (string, table, math, coroutine
(should it be included?) and tolua) by tables that contain just the functions
we want, if we need to block out any of them.

___

Reply to this item at:

  http://gna.org/bugs/?15624

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15644] Add server command to run freeciv script

2010-03-20 Thread Ulrik Sverdrup

Follow-up Comment #4, bug #15644 (project freeciv):

Once the sanitized environment for scripts is implemented, there should be no
way to read scripts from a file or in any way interact with the OS, only the
game. Look at the proof-of-concept patch, the codestring given to /lua will
be interpreted inside the same namespace as the ruleset and scenario code.

___

Reply to this item at:

  http://gna.org/bugs/?15644

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15624] [RFC] scripting: Sandbox Lua scripts

2010-03-20 Thread pepeto

Update of bug #15624 (project freeciv):

  Status:  Ready For Test = In Progress
 Assigned to:  pepeto = englabenny 

___

Follow-up Comment #7:

I conclude, that I will leave this to you. Hopping you will return fast.


___

Reply to this item at:

  http://gna.org/bugs/?15624

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15592] All scenarios use (classic/*) in the name

2010-03-20 Thread pepeto

Update of bug #15592 (project freeciv):

Category:None = general
  Status:None = Wont Fix   
 Assigned to:None = pepeto 
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?15592

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15624] [RFC] scripting: Sandbox Lua scripts

2010-03-20 Thread Ulrik Sverdrup

Follow-up Comment #8, bug #15624 (project freeciv):

Be sure that by saying that security is hard, I don't mean that I can do it
better than you -- on the contrary, if we work together, this will be much
better. What I meant was: don't trust me yet, it's not so easy.

___

Reply to this item at:

  http://gna.org/bugs/?15624

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15458] create_unit_virtual() assert pplayer != NULL failed

2010-03-20 Thread pepeto

Update of bug #15458 (project freeciv):

Category:None = general
  Status:None = Wont Fix   
 Assigned to:None = pepeto 
 Open/Closed:Open = Closed 

___

Follow-up Comment #2:

Since bug #15456 is fixed, this is a galactic modpack problem.


___

Reply to this item at:

  http://gna.org/bugs/?15458

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15452] Russian translation for 2.2.0

2010-03-20 Thread pepeto

Update of bug #15452 (project freeciv):

 Assigned to:None = evyscr 


___

Reply to this item at:

  http://gna.org/bugs/?15452

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15652] Can't meet the Persians

2010-03-20 Thread Jacob Nevins

Follow-up Comment #1, bug #15652 (project freeciv):

I assume gavin was Winston Churchill.

Huh. I thought could reproduce this last night with latest S2_2 svn (r17122),
but now I can't reproduce it with either that same version or the 2.2.0
release. Can you reproduce it after loading the savegame?

If I load the game in freeciv-gtk2, /take Winston, start, go to the Nations
report, select Ardashir I (Persian), then I can pull down Diplomacy, select
Meet, and get a Diplomacy: Persians dialog. (But last night I'm sure Meet
was grayed out. Perhaps I just tripped over bug #15505, it was late.)

In this savegame, the Messages tab contains '*Ardashir I (AI)* We grow weary
of this constant bloodshed. May we suggest a cessation of hostilities?' (from
the event cache, for this turn). This suggests that at the point the game was
saved there may have been a Diplomacy: Persians dialog. That makes me
wonder about bug #15439 (fixed since 2.2.0), but I don't think open treaty
windows are preserved across save/load.

___

Reply to this item at:

  http://gna.org/bugs/?15652

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1541] [Metaticket] new savegame format

2010-03-20 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1541

 Summary: [Metaticket] new savegame format
 Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 20.03.2010 um 15:20
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

The current savegame.c file has some disadvantages. One the one hand there is
no structure, one the other hand loading a damaged savegame will kill the
server. This patch series adds a  savegame2.c file to freeciv. This file is a
rewrite of the old savegame file. Comments to additional movements of code or
renaming of variables within the save file are wellcome.

The file attached to this ticket contants all data. Important is the bash
script 'sg-test.bin'. It can be used to test the compability between the old
and new savegames. If you rename a savegame as 'sg-testme.sav.bz2', this file
will

* load 'sg-testme.sav.bz2' and save it in the old format
(sg-test01-old.sav.bz2)
* load 'sg-test01-old.sav.bz2' and save it in the new format
(sg-test02-new.sav.bz2)
* load 'sg-test02-new.sav.bz2' and save it in the old format
(sg-test03-old.sav.bz2)
* load 'sg-test01-old.sav.bz2' and save it in the old format
(sg-test04-old.sav.bz2)
* create diffs between 1-3, 1-4 and 3-4

The main differences are:

* no map for dead players are saved in the new format
* differences within the event log
* (sometimes) differences in the update time for tiles, this can also be
found in the diff 1-4 (only old format)





___

File Attachments:


---
Date: Samstag 20.03.2010 um 15:20  Name: savegame2.diff  Size: 216kB   By:
syntron

http://gna.org/patch/download.php?file_id=8576

___

Reply to this item at:

  http://gna.org/patch/?1541

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1542] remove check setting_is_changeable() from setting_*_validate()

2010-03-20 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1542

 Summary: remove check setting_is_changeable() from
setting_*_validate()
 Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 20.03.2010 um 15:22
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

setting_*_validate() should validate a setting also if it can not be applied
due to a not changeable setting



___

File Attachments:


---
Date: Samstag 20.03.2010 um 15:22  Name:
20100320-trunk-remove-check-setting_is_changeable-from-setting_-_v.diff 
Size: 4kB   By: syntron

http://gna.org/patch/download.php?file_id=8577

___

Reply to this item at:

  http://gna.org/patch/?1542

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1541] [Metaticket] new savegame format

2010-03-20 Thread Matthias Pfafferodt

Update of patch #1541 (project freeciv):

  Depends on: = patch #1542


___

Reply to this item at:

  http://gna.org/patch/?1541

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1543] new saving of settings

2010-03-20 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1543

 Summary: new saving of settings
 Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 20.03.2010 um 15:24
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

* save all game settings in a table (name, value, value at game start)
* used by new savegame format
* remove this from old (trunk) savegames



___

File Attachments:


---
Date: Samstag 20.03.2010 um 15:24  Name:
20100320-trunk-new-saving-of-settings.diff  Size: 11kB   By: syntron

http://gna.org/patch/download.php?file_id=8578

___

Reply to this item at:

  http://gna.org/patch/?1543

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1541] [Metaticket] new savegame format

2010-03-20 Thread Matthias Pfafferodt

Update of patch #1541 (project freeciv):

  Depends on: = patch #1543


___

Reply to this item at:

  http://gna.org/patch/?1541

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1544] default GAME_DEFAULT_TIMEOUTCOUNTER

2010-03-20 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1544

 Summary: default GAME_DEFAULT_TIMEOUTCOUNTER
 Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 20.03.2010 um 15:25
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:





___

File Attachments:


---
Date: Samstag 20.03.2010 um 15:25  Name:
20100320-trunk-default-GAME_DEFAULT_TIMEOUTCOUNTER.diff  Size: 1kB   By:
syntron

http://gna.org/patch/download.php?file_id=8579

___

Reply to this item at:

  http://gna.org/patch/?1544

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1541] [Metaticket] new savegame format

2010-03-20 Thread Matthias Pfafferodt

Update of patch #1541 (project freeciv):

  Depends on: = patch #1544


___

Reply to this item at:

  http://gna.org/patch/?1541

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15660] fix riveroverlay

2010-03-20 Thread Matthias Pfafferodt

URL:
  http://gna.org/bugs/?15660

 Summary: fix riveroverlay
 Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 20.03.2010 um 15:27
Category: None
Severity: 2 - Minor
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2.0
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

fix riveroverlay in savegame; it uses 'map.spe%02d%%03d' but it should be
'map.spe%02d_%%03d'



___

File Attachments:


---
Date: Samstag 20.03.2010 um 15:27  Name:
20100320-trunk-fix-riveroverlay-old-sg.diff  Size: 792B   By: syntron

http://gna.org/bugs/download.php?file_id=8580

___

Reply to this item at:

  http://gna.org/bugs/?15660

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1545] basic support for savegame version 2 with timing

2010-03-20 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1545

 Summary: basic support for savegame version 2 with timing
 Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 20.03.2010 um 15:28
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

* add saveold setting



___

File Attachments:


---
Date: Samstag 20.03.2010 um 15:28  Name:
20100320-trunk-basic-support-for-savegame-version-2-with-timing.diff  Size:
9kB   By: syntron

http://gna.org/patch/download.php?file_id=8581

___

Reply to this item at:

  http://gna.org/patch/?1545

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1541] [Metaticket] new savegame format

2010-03-20 Thread Matthias Pfafferodt

Update of patch #1541 (project freeciv):

  Depends on: = patch #1545


___

Reply to this item at:

  http://gna.org/patch/?1541

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1546] new savegame file

2010-03-20 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1546

 Summary: new savegame file
 Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 20.03.2010 um 15:30
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

add content to savegame2.c

* remove all optional capabilities
* sever settings in a separate block
* merge embassy/give_shared_vision into and diplstate
* save map data only for alive players



___

File Attachments:


---
Date: Samstag 20.03.2010 um 15:30  Name:
20100320-trunk-add-content-to-savegame2.c.diff  Size: 194kB   By: syntron

http://gna.org/patch/download.php?file_id=8582

___

Reply to this item at:

  http://gna.org/patch/?1546

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1541] [Metaticket] new savegame format

2010-03-20 Thread Matthias Pfafferodt

Update of patch #1541 (project freeciv):

  Depends on: = patch #1546


___

Reply to this item at:

  http://gna.org/patch/?1541

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1541] [Metaticket] new savegame format

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #1, patch #1541 (project freeciv):

test script for the new format

(file #8583)
___

Additional Item Attachment:

File name: sg-test.binSize:1 KB


___

Reply to this item at:

  http://gna.org/patch/?1541

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15661] Crash when disconnecting

2010-03-20 Thread pepeto

URL:
  http://gna.org/bugs/?15661

 Summary: Crash when disconnecting
 Project: Freeciv
Submitted by: pepeto
Submitted on: samedi 20.03.2010 à 14:34
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.1, 2.3.0

___

Details:

Client in trunk crash when leaving the server. It is due to the usage of some
control values which are already free, but not reset. Fix attached, also a
version for 2.2, although it doesn't crash in this branch.




___

File Attachments:


---
Date: samedi 20.03.2010 à 14:34  Name: trunk_control_init_free.diff  Size: 3
ko   By: pepeto

http://gna.org/bugs/download.php?file_id=8584
---
Date: samedi 20.03.2010 à 14:34  Name: trunk_control_init_free.diff  Size: 3
ko   By: pepeto

http://gna.org/bugs/download.php?file_id=8585

___

Reply to this item at:

  http://gna.org/bugs/?15661

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15661] Crash when disconnecting

2010-03-20 Thread pepeto

Additional Item Attachment, bug #15661 (project freeciv):

File name: S2_2_control_init_free.diffSize:3 KB


___

Reply to this item at:

  http://gna.org/bugs/?15661

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1235] [Metaticket] variable city radii

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #15, patch #1235 (project freeciv):

This patch series must be rebased again (patch #1529). I will do it today or
tomorrow. Is it OK to apply patch 1 to 5 after that?

patch #1230 (new savegame format) should be considered in connection with the
new savegame format (patch #1541). This way the old format can stay while the
changes go into the new one.

___

Reply to this item at:

  http://gna.org/patch/?1235

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15591] [10.5.8 PPC Mac] client doesn't start

2010-03-20 Thread anonymous

Follow-up Comment #7, bug #15591 (project freeciv):

I regret that I am not free to assist in beta testing a revised package.  The
installation is not intended for my benefit; hence why the access permission
*must* be correct.  

***
 The freetype library that is in the application bundle is permitted as
read  write for the user who installed the package, all others get No
Access.

Yes, this would account for the observed behaviour.

Permissions in /Application/ should be rw for the admin user  r for
all others (with certain rare exceptions).  

No access is occasionally picked up as a default permission when not in the
home directory tree.  This merely suggests that the package builder missed
this library when assigning correct permissions.

 The installer puts a Freeciv folder in ~/Documents/ for the user who
installed the package. 

For a Mac, the correct location for read only support files is in the
application package; but for user writable files, it is in
~/Library/Application Support/Freeciv/.  

User downloaded extensions should also go there, so that the user does not
need to call an administrator merely to use a new map or tile set. 
Canonically, the program should check both places for files.  But,
implementation might be eaiser if the files are copied to a user when they
first run the program.

~/Documents/ is customarily reserved for, err, documents.  

 In the meanwhile, this binary should  work when installed by the user who
intends to play the game.

No, it does not.  

Only admin users have write access in /Applications/.  Nor will it run if
installed to ~/Applications/, where users *do* have write access. 

___

Reply to this item at:

  http://gna.org/bugs/?15591

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1494] [Metaticket] merge longturn into mainline

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #2, patch #1494 (project freeciv):

 (c++) adding new player and changes to ./server/generator/startpos.c

this could possible be done in lua; see bug #15644

___

Reply to this item at:

  http://gna.org/patch/?1494

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [bug #15591] [10.5.8 PPC Mac] client doesn't start

2010-03-20 Thread David Lowe
On 20 Mar, 2010, at 7:57 AM, anonymous wrote:

 The installer puts a Freeciv folder in ~/Documents/ for the user who
 installed the package. 
 
 For a Mac, the correct location for read only support files is in the
 application package; but for user writable files, it is in
 ~/Library/Application Support/Freeciv/.  
 
 User downloaded extensions should also go there, so that the user does not
 need to call an administrator merely to use a new map or tile set. 
 Canonically, the program should check both places for files.  But,
 implementation might be eaiser if the files are copied to a user when they
 first run the program.
 
 ~/Documents/ is customarily reserved for, err, documents.  

I fully agree.  It seems wasteful of disk space to duplicate typically 
read only files into the home directory of every user who wishes to play the 
game.  For those who are making tilesets or whatever, i assume this would be 
handled by a link from their home folder to the application so that it can read 
in the new material.  I will have to research how this is handled in other OSs.

 In the meanwhile, this binary should  work when installed by the user who
 intends to play the game.
 
 No, it does not.  
 
 Only admin users have write access in /Applications/.  Nor will it run if
 installed to ~/Applications/, where users *do* have write access.

D'Oh!  I stand corrected.  I should have said 'All users with 
administrative rights.  After i get the kinks worked out of the fink build, i 
will look into making a binary - i have not heard any more from Napoleon XIV 
and assume he is no longer active.  When i do, i promise to make an 
installer-free 'drag-and-drop' package.

Sent from my MacBookPro

Aibohphobia: Fear of palindromes.  Aibophobia: Fear of cybernetic dogs.
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1226] add possibility to log the city map

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #7, patch #1226 (project freeciv):

rebased to current trunk (svn 16977)

(file #8587)
___

Additional Item Attachment:

File name: 20100320-trunk-add-possibility-to-log-the-city-map.diff Size:14 KB


___

Reply to this item at:

  http://gna.org/patch/?1226

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #8, patch #1330 (project freeciv):

updated patch (svn 16977)

* use 512 as max value for CITYMAP_WIDTH; this results in a 2/3 scaling for
the amplio tileset

(file #8588)
___

Additional Item Attachment:

File name: 20100320-trunk-update-city-dialog-for-gtk-2.0.diff Size:30 KB


___

Reply to this item at:

  http://gna.org/patch/?1330

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15660] fix riveroverlay

2010-03-20 Thread pepeto

Update of bug #15660 (project freeciv):

Category:None = general
  Status:None = Ready For Test 
 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?15660

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1264] add tech upkeep

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #6, patch #1264 (project freeciv):

I checked the code and moved the substraction of the bulbs needed as tech
upkeep after the city bulb production is added.

 What happens during anarchy? Currently you can loose several techs. IMO
tech upkeep should not apply then, like monetary upkeep is zero, too.

An additional patch which adds the effect Tech_Upkeep_Free can in some
minutes be found here.

 Should tech upkeep be allowed to be paid from stockpiled bulbs or should
freshly researched bulbs be required? The following pseudocode describes that
approach:

Here I'm for using the stockpiled bulbs as it is done for gold. This way a
little reserve is possible in dangerous times.

(file #8590)
___

Additional Item Attachment:

File name: 20100320-trunk-add-tech-upkeep.diff Size:12 KB


___

Reply to this item at:

  http://gna.org/patch/?1264

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1265] add text about the bulb upkeep in the science dialog

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #2, patch #1265 (project freeciv):

updated version

(file #8591)
___

Additional Item Attachment:

File name:
20100320-trunk-add-text-about-the-bulb-upkeep-in-the-science-dialog.diff
Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?1265

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1547] add effect EFT_TECHUPKEEP_FREE (Tech_Upkeep_Free)

2010-03-20 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1547

 Summary: add effect EFT_TECHUPKEEP_FREE (Tech_Upkeep_Free)
 Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 20.03.2010 um 19:59
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

suggested by Andreas anbe in patch #1264; free tech upkeep in anarchy



___

File Attachments:


---
Date: Samstag 20.03.2010 um 19:59  Name:
20100320-trunk-add-effect-EFT_TECHUPKEEP_FREE-Tech_Upkeep_Free.diff  Size:
6kB   By: syntron

http://gna.org/patch/download.php?file_id=8592

___

Reply to this item at:

  http://gna.org/patch/?1547

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1547] add effect EFT_TECHUPKEEP_FREE (Tech_Upkeep_Free)

2010-03-20 Thread Matthias Pfafferodt

Update of patch #1547 (project freeciv):

  Depends on: = patch #1264


___

Reply to this item at:

  http://gna.org/patch/?1547

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1542] remove check setting_is_changeable() from setting_*_validate()

2010-03-20 Thread pepeto

Follow-up Comment #1, patch #1542 (project freeciv):

The setting_is_changeable() must be added in setting_*_set() functions.


___

Reply to this item at:

  http://gna.org/patch/?1542

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1541] [Metaticket] new savegame format

2010-03-20 Thread pepeto

Follow-up Comment #2, patch #1541 (project freeciv):

 One the one hand there is no structure, one the other hand
 loading a damaged savegame will kill the server.

I doubt this is realizable without designing real game and map objects.

Did you already read things I wrote some times ago at
http://freeciv.wikia.com/wiki/User:Pepeto/Some_ideas_for_2.3


___

Reply to this item at:

  http://gna.org/patch/?1541

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15450] Error generating savegame names

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #17, bug #15450 (project freeciv):

 I made patch #1537 to help you for that. 

And I used it. New version of the patch is attached.

(file #8593)
___

Additional Item Attachment:

File name: 20100320-trunk-new-generation-of-savename.diff Size:7 KB


___

Reply to this item at:

  http://gna.org/bugs/?15450

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15450] Error generating savegame names

2010-03-20 Thread Matthias Pfafferodt

Update of bug #15450 (project freeciv):

  Dependency Removed: = patch #1490


___

Reply to this item at:

  http://gna.org/bugs/?15450

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15450] Error generating savegame names

2010-03-20 Thread Matthias Pfafferodt

Update of bug #15450 (project freeciv):

  Depends on: = patch #1537


___

Reply to this item at:

  http://gna.org/bugs/?15450

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1537] Utility to print custom format strings

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #4, patch #1537 (project freeciv):

nice patch! I used it for the generation of the savefile name. One small
remark: FC_END = CF_END in the comment to fc_vsnprintcf()

___

Reply to this item at:

  http://gna.org/patch/?1537

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs

2010-03-20 Thread Jason Dorje Short

Follow-up Comment #1, bug #15377 (project freeciv):

The catalan.ruleset is in utf8, in both S2_2 and trunk.  This is correct and
all characters are utf8.  It's loaded into the server where it remains utf-8.
 It's then sent over the network in utf-8.  It's received by the client and
converted by iconv into the client encoding which is also utf-8.  It's then
sent to gtk2 as utf8.

The isutf8 program can be used to confirm that files are in utf8.  All
ruleset, data, and code files should be in utf8.  In fact the only text files
that may be non-UTF8 within freeciv is the translations which have their
codeset listed at top (even these may be utf-8, which should be encouraged). 
But using this utility does not show up any invalid files.

So I dont see where this can be going wrong.  It could be caused by a bug in
windows GTK or windows iconv as i have heard this is not reproducable on
other platforms with the GTK2 client.  It might also be a bug in windows use
of iconv, if it is trying to convert it out of utf-8 for some reason, but in
that case the bug should probably show up on other platforms and other
rulesets.  Thirdly it could be an issue only triggered by 64bit; the other
bug reports windows7 64bit but this one just says windows vista.

I do notice the documentation on this is limited and in some cases incorrect.
 I'll make a patch to improve this.

-jason


___

Reply to this item at:

  http://gna.org/bugs/?15377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1541] [Metaticket] new savegame format

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #3, patch #1541 (project freeciv):

 Did you already read things I wrote some times ago at
http://freeciv.wikia.com/wiki/User:...

Yes I read this and one or two things are done:

* not killing the server on error
* remove old definitions
* sorting all the different modules into their own functions. starting with
this it should be possible to add code which allows to load only a certain
savegame version

At the moment I have no concept wrt the last point. How to do this ...

___

Reply to this item at:

  http://gna.org/patch/?1541

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15450] Error generating savegame names

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #18, bug #15450 (project freeciv):

version for S2_2

(file #8594)
___

Additional Item Attachment:

File name: 20100320-S2_2-new-generation-of-savename-S2_2.diff Size:7 KB


___

Reply to this item at:

  http://gna.org/bugs/?15450

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1537] Utility to print custom format strings

2010-03-20 Thread pepeto

Follow-up Comment #5, patch #1537 (project freeciv):

 One small remark: FC_END = CF_END in the comment to
 fc_vsnprintcf()

Good point.


(file #8595, file #8596)
___

Additional Item Attachment:

File name: trunk_fc_snprintcf4.diff   Size:11 KB
File name: S2_2_fc_snprintcf4.diffSize:11 KB


___

Reply to this item at:

  http://gna.org/patch/?1537

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15450] Error generating savegame names

2010-03-20 Thread pepeto

Update of bug #15450 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/bugs/?15450

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1537] Utility to print custom format strings

2010-03-20 Thread pepeto

Update of patch #1537 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/patch/?1537

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1542] remove check setting_is_changeable() from setting_*_validate()

2010-03-20 Thread Matthias Pfafferodt

Follow-up Comment #2, patch #1542 (project freeciv):

 The setting_is_changeable() must be added in setting_*_set() functions. 

Done.

(file #8597)
___

Additional Item Attachment:

File name:
20100320.1-trunk-remove-check-setting_is_changeable-from-setting_-_v.diff
Size:5 KB


___

Reply to this item at:

  http://gna.org/patch/?1542

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1532] Default ruleset script: Use consistent naming

2010-03-20 Thread pepeto

Update of patch #1532 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?1532

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1533] Invoke script error on duplicate connection in script_signal_connect

2010-03-20 Thread pepeto

Update of patch #1533 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?1533

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15617] Scripting: Default script, Ruleset script, and scenario share namespace

2010-03-20 Thread pepeto

Update of bug #15617 (project freeciv):

  Status:None = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?15617

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1539] struct astring clean up

2010-03-20 Thread pepeto

Update of patch #1539 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?1539

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1264] add tech upkeep

2010-03-20 Thread Andreas

Follow-up Comment #7, patch #1264 (project freeciv):

 I checked the code and moved the substraction of the bulbs needed as tech
upkeep after the city bulb production is added. 

Does this cover the case that the last city producing some bulbs just
finishes the current research project, so that there are no(t enough) bulbs
left in stock that could be used for paying bulb upkeep?

___

Reply to this item at:

  http://gna.org/patch/?1264

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15663] Custom Scenarios are not show in Start Scenario Game list

2010-03-20 Thread Ulrik Sverdrup

URL:
  http://gna.org/bugs/?15663

 Summary: Custom Scenarios are not show in Start Scenario
Game list
 Project: Freeciv
Submitted by: englabenny
Submitted on: lördag 2010-03-20 den 23:43
Category: general
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Start Scenario Game screen in the Gtk+ client does not include scenarios
from ~/.freeciv/scenarios

1. Most notably, scenarios saved with Save Scenario.. from the editor are not
listed in Start Scenario Game

2. The server command '/list scenarios' produces a different list, I don't
think it lists scenarios from ~/.freeciv/scenarios either! It includes lots
of savegames from ~/ though.




___

Reply to this item at:

  http://gna.org/bugs/?15663

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15665] Untranslated strings in SDL client

2010-03-20 Thread Jacob Nevins

URL:
  http://gna.org/bugs/?15665

 Summary: Untranslated strings in SDL client
 Project: Freeciv
Submitted by: jtn
Submitted on: Sunday 03/21/10 at 00:33
Category: client-sdl
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.2.0
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.1

___

Details:

Found some displayable strings not marked up for translation.

This change exposes 5 new strings for translators (the others are the same as
existing strings).



___

File Attachments:


---
Date: Sunday 03/21/10 at 00:33  Name: S2_2-sdl-untranslated-strings.diff 
Size: 6kB   By: jtn
S2_2/trunk r17127: mark more strings in SDL client for translation
http://gna.org/bugs/download.php?file_id=8600
---
Date: Sunday 03/21/10 at 00:33  Name: trunk-sdl-untranslated-strings.diff 
Size: 6kB   By: jtn
S2_2/trunk r17127: mark more strings in SDL client for translation
http://gna.org/bugs/download.php?file_id=8601

___

Reply to this item at:

  http://gna.org/bugs/?15665

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev