[Freeciv-Dev] [bug #16635] Observers cannot access the vote list

2010-09-05 Thread pepeto

URL:
  http://gna.org/bugs/?16635

 Summary: Observers cannot access the vote list
 Project: Freeciv
Submitted by: pepeto
Submitted on: dimanche 05.09.2010 à 10:33
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk, S2_2
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

Observers cannot access the vote list because they are not allowed to use the
_/vote_ command. I suggest to move this feature in _/list votes_, like in
warclient.





___

Reply to this item at:

  http://gna.org/bugs/?16635

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16636] Not /firstlevel connections cannot see what is the rulesetdir

2010-09-05 Thread pepeto

URL:
  http://gna.org/bugs/?16636

 Summary: Not /firstlevel connections cannot see what is the
rulesetdir
 Project: Freeciv
Submitted by: pepeto
Submitted on: dimanche 05.09.2010 à 10:35
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_2, trunk
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

Connections with lower access levels than _ctrl_ cannot see what is the
rulesetdir because they cannot issue the _/rulesetdir_ command. I suggest to
move this feature into _/show rulesetdir_, like in warclient.





___

Reply to this item at:

  http://gna.org/bugs/?16636

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1925] Numunu nation

2010-09-05 Thread Andrzej G.

Follow-up Comment #2, patch #1925 (project freeciv):

Native orthography isn't displayed. I exchanged one letter.

(file #10177)
___

Additional Item Attachment:

File name: numunu.ruleset Size:1 KB


___

Reply to this item at:

  http://gna.org/patch/?1925

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16639] fix assert in dbv_isset() at server exit

2010-09-05 Thread Matthias Pfafferodt

URL:
  http://gna.org/bugs/?16639

 Summary: fix assert in dbv_isset() at server exit
 Project: Freeciv
Submitted by: syntron
Submitted on: Sonntag 05.09.2010 um 17:06
Category: general
Severity: 3 - Normal
Priority: 3 - Low
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:


1: in dbv_isset() [bitvector.c::120]: assertion 'pdbv-vec != ((void *)0)'
failed.
1: Please report this message at https://gna.org/projects/freeciv/


player_map_free() was called before player_clear() but player_clear() still
needs the map data.



___

File Attachments:


---
Date: Sonntag 05.09.2010 um 17:06  Name:
20100905-05-trunk-fix-assert-in-dbv_isset-at-server-exit.patch  Size: 1kB  
By: syntron

http://gna.org/bugs/download.php?file_id=10178

___

Reply to this item at:

  http://gna.org/bugs/?16639

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1391] new code to generate stats (graphics)

2010-09-05 Thread Matthias Pfafferodt

Update of patch #1391 (project freeciv):

  Status:None = In Progress
 Assigned to:None = syntron

___

Follow-up Comment #9:

an update after a long time ...

changes:

* implement it as part of ./common
* it will replace the creation of ppm files
* addition engines using magicwand/gtk/sdl possible
* can be called from the server (implemented), from the client (TODO) or as
its own client (TODO)
* needs the colour definitions in the ruleset (player colours, terrain
colours, map overview colours)
* can the file ./data/misc/colors.png be generated on the fly by the clients?
Thus the colours for the players would be really independent. I think it
should be possible for the gtk and sdl clients at least.

how to test it:

* apply the patch
* start the server
* define an map image using 'mapimg define zoom=2'
* start the game ...
* use the script mapimg2anim.bin to generate an animated gif file

(file #10179)
___

Additional Item Attachment:

File name: 20100905-07-trunk-create-map-images.patch Size:103 KB


___

Reply to this item at:

  http://gna.org/patch/?1391

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16625] save chat message for the sender

2010-09-05 Thread pepeto

Update of bug #16625 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?16625

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16639] fix assert in dbv_isset() at server exit

2010-09-05 Thread pepeto

Update of bug #16639 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?16639

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1795] fix versions number handling for compatibility layer in savegame2.c

2010-09-05 Thread Matthias Pfafferodt

Update of patch #1795 (project freeciv):

  Dependency Removed: = patch #1778


___

Reply to this item at:

  http://gna.org/patch/?1795

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1778] [interface][ai] define the ai via the new interface

2010-09-05 Thread Matthias Pfafferodt

Update of patch #1778 (project freeciv):

  Status:  Ready For Test = Wont Do
 Open/Closed:Open = Closed 

___

Follow-up Comment #6:

due to the changes wrt the AI this patch is not working anymore. I did move
the part which saves the AI of the player into patch #1795 and close this
one.

___

Reply to this item at:

  http://gna.org/patch/?1778

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1795] fix versions number handling for compatibility layer in savegame2.c

2010-09-05 Thread Matthias Pfafferodt

Update of patch #1795 (project freeciv):

  Depends on: = patch #1927


___

Reply to this item at:

  http://gna.org/patch/?1795

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1795] update definition of the AI

2010-09-05 Thread Matthias Pfafferodt

Update of patch #1795 (project freeciv):

  Status: In Progress = Ready For Test 
 Summary: fix versions number handling for compatibility
layer in savegame2.c = update definition of the AI

___

Follow-up Comment #1:

update definition of the AI

* save the AI type of the player in the savefile (only for version 2)
* cleanup usage of server_create_player() and server_player_init()
* add compatibility function for loading old trunk savefiles
* fix versions number handling for compatibility layer in savegame2.c

(file #10182)
___

Additional Item Attachment:

File name: 20100905-06-trunk-update-definition-of-the-AI.patch Size:18 KB


___

Reply to this item at:

  http://gna.org/patch/?1795

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1928] remove save_ppm and -P option

2010-09-05 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1928

 Summary: remove save_ppm and -P option
 Project: Freeciv
Submitted by: syntron
Submitted on: Sonntag 05.09.2010 um 17:39
Category: general
Priority: 3 - Low
  Status: In Progress
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:





___

File Attachments:


---
Date: Sonntag 05.09.2010 um 17:39  Name:
20100905-06-trunk-remove-save_ppm-and-P-option.patch  Size: 6kB   By: syntron

http://gna.org/patch/download.php?file_id=10183

___

Reply to this item at:

  http://gna.org/patch/?1928

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1928] remove save_ppm and -P option

2010-09-05 Thread Matthias Pfafferodt

Update of patch #1928 (project freeciv):

  Depends on: = patch #1391


___

Reply to this item at:

  http://gna.org/patch/?1928

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1786] [ai] remove aidata.h from savegame2.c and savegame.c

2010-09-05 Thread Matthias Pfafferodt

Follow-up Comment #1, patch #1786 (project freeciv):

How should the AI data for the player/units/cities be loaded and saved? If it
should be done for each AI, this patch and patch #1784 need to be rebased to
current trunk. Or are there other plans? Marko?

___

Reply to this item at:

  http://gna.org/patch/?1786

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1795] save AI type in the savegame

2010-09-05 Thread Matthias Pfafferodt

Update of patch #1795 (project freeciv):

 Assigned to: syntron = None   
 Summary: update definition of the AI = save AI type in the
savegame

___

Follow-up Comment #2:

use a meaningful summary

___

Reply to this item at:

  http://gna.org/patch/?1795

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1391] new code to generate stats (graphics)

2010-09-05 Thread Matthias Pfafferodt

Follow-up Comment #11, patch #1391 (project freeciv):

and a second example showing how the AI gives and remove vision ...

(file #10185)
___

Additional Item Attachment:

File name: freeciv-M-bcfkutZ1Pid000-anim.gif Size:988 KB


___

Reply to this item at:

  http://gna.org/patch/?1391

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1391] new code to generate stats (graphics)

2010-09-05 Thread pepeto

Follow-up Comment #12, patch #1391 (project freeciv):

It looks great. Is there a way to keep borders out of the vision?


___

Reply to this item at:

  http://gna.org/patch/?1391

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1391] new code to generate stats (graphics)

2010-09-05 Thread Matthias Pfafferodt

Follow-up Comment #13, patch #1391 (project freeciv):

 It looks great. Is there a way to keep borders out of the
 vision? 

yes; see the help


 mapimg help
Available map image defintion options mapdef:
name  default  description
formatgif  image format ('gif', 'png', 'ppm', 'jpg')
show value  all  show players ('none', 'each', 'all', 'plrname',
'plrid', 'plrbv')
  plrname valueplayer name (if 'show=plrname')
  plrid value  player id (if 'show=plrid')
  plrbv value  player bitvector (if 'show=plrbv')
turns value   1  save each value turns (0 = no autosave)
zoom value2  zoom factor (1 = zoom = 5)
map map cub  definition of the map

The map string map can contain:
 - 'a' show area within borders
 - 'b' show borders
 - 'c' show cities
 - 'f' show fogofwar
 - 'k' show only known terrain
 - 't' full terrain
 - 'u' show units

'k' and 'f' are only available if the map is drawn for one player

Examples:
 'zoom=1:map=tcub:show=all:format=gif'
 'zoom=2:map=tcub:show=each:format=png'
 'zoom=1:map=tcub:show=plrname:plrname=Otto:format=gif'
 'zoom=3:map=cu:show=plrbv:plrbv=010011:format=jpg'
 'zoom=1:map=t:show=none:format=jpg'


___

Reply to this item at:

  http://gna.org/patch/?1391

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev



[Freeciv-Dev] [patch #1391] new code to generate stats (graphics)

2010-09-05 Thread pepeto

Follow-up Comment #14, patch #1391 (project freeciv):

I meant borders under fog of war when both 'f' and 'b' options are enabled.


___

Reply to this item at:

  http://gna.org/patch/?1391

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1391] new code to generate stats (graphics)

2010-09-05 Thread Matthias Pfafferodt

Follow-up Comment #15, patch #1391 (project freeciv):

 I meant borders under fog of war when both 'f' and 'b' options
 are enabled. 

This is not possible at the moment. There are some problems to solve:

* is it really needed? (or is it to much?)
* it is only possible if the data for only one player is displayed.
* at the moment all information of the server are used. For this the data in
the struct player_tile must be analysed (limited knowledge of the player).
* a rewrite of this code is needed (and planed!) to use it in the server and
the client. I think there should be a interface in the client to save a map
image on the client side.


___

Reply to this item at:

  http://gna.org/patch/?1391

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1929] Gothic nation

2010-09-05 Thread Andrzej G.

URL:
  http://gna.org/patch/?1929

 Summary: Gothic nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sunday 09/05/2010 at 19:00
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Adapted nationset of other author.



___

File Attachments:


---
Date: Sunday 09/05/2010 at 19:00  Name: gothic.ruleset  Size: 2kB   By:
artaxes

http://gna.org/patch/download.php?file_id=10186

___

Reply to this item at:

  http://gna.org/patch/?1929

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16613] Vision layer bug with editor

2010-09-05 Thread pepeto

Follow-up Comment #3, bug #16613 (project freeciv):

Attaching a version for trunk. I tested lot of issues but testing again would
be very welcome.


(file #10187)
___

Additional Item Attachment:

File name: trunk_vision_cleanup.diff  Size:46 KB


___

Reply to this item at:

  http://gna.org/bugs/?16613

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16413] Gold upkeep and Military unhappiness

2010-09-05 Thread Matthias Pfafferodt

Follow-up Comment #3, bug #16413 (project freeciv):

Did you test the upkeep problem? I'm also playing longturn and at the moment
I can't build a military unit because my city is to small to support it.

City size: 1
Possible military units: 1 (needs more testing; using shield upkeep)

___

Reply to this item at:

  http://gna.org/bugs/?16413

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16413] Gold upkeep and Military unhappiness

2010-09-05 Thread David Fernandez

Follow-up Comment #4, bug #16413 (project freeciv):

I'm not experienced user of svn patches and I found troubles to test this
patch, maybe you can help me.

When I try to patch the head version of the current trunk I receive this
error FAILED at 1746:

patch -p1 
/Parches/20100828-01-trunk-update-gold-upkeep-style-2-to-sell-alternatively-a-u.patch

patching file data/civ1/game.ruleset
patching file data/civ2/game.ruleset
patching file data/default/game.ruleset
patching file data/experimental/game.ruleset
patching file data/multiplayer/game.ruleset
patching file server/cityturn.c
Hunk #5 succeeded at 1694 (offset 2 lines).
Hunk #6 succeeded at 1703 (offset 2 lines).
Hunk #7 FAILED at 1746.
Hunk #8 succeeded at 1854 (offset 3 lines).
Hunk #9 succeeded at 1877 (offset 3 lines).
Hunk #10 succeeded at 1885 (offset 3 lines).
Hunk #11 succeeded at 1938 (offset 3 lines).


Do I need to test the patch over certain previous trunk version?
Or it might be something I'm doing wrong?

(let me know if there is other place more apropiate for such novice
questions)

___

Reply to this item at:

  http://gna.org/bugs/?16413

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16613] Vision layer bug with editor

2010-09-05 Thread pepeto

Update of bug #16613 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #4:

Attached second version for trunk and version for S2_2.


(file #10188, file #10189)
___

Additional Item Attachment:

File name: trunk_vision_cleanup2.diff Size:45 KB
File name: S2_2_vision_cleanup.diff   Size:43 KB


___

Reply to this item at:

  http://gna.org/bugs/?16613

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16623] netintf.c gcc warnings in net_lookup_service

2010-09-05 Thread George Koehler

Follow-up Comment #3, bug #16623 (project freeciv):

I found the reference. [url=http://tools.ietf.org/html/rfc3493]RFC
3493[/url], which defines IPv6 sockets, explains that 'The gethostbyname2()
function was deprecated in RFC 2553 and is no longer part of the basic API.'

I suppose that someone deleted gethostbyname2() from netdb.h, but left
gethostbyname2() in the library for backward compatibility with old programs.
Then the replacement of gethostbyname2() with getaddrinfo() might fix this
bug.



net_lookup_service() returns only one address, but getaddrinfo() returns a
linked list of addresses. I designed my patch for bug #15559 to use multiple
calls to net_lookup_service() to build an array of addresses. My idea is that
someone will replace the multiple calls to net_lookup_service() with a single
call to getaddrinfo().

___

Reply to this item at:

  http://gna.org/bugs/?16623

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16613] Vision layer bug with editor

2010-09-05 Thread pepeto

Follow-up Comment #5, bug #16613 (project freeciv):

The results of the first tests loading and running savegames pointing about
recent map bugs:
* bug #16613: S2_2(OK), trunk(OK)
* bug #16592: S2_2(OK), trunk(Ok but the server seems to fall in infinite
loop?)
* bug #14993: S2_2(cannot load), trunk(many failed assertions)
* bug #14836: S2_2(OK), trunk(OK)
* bug #14275: S2_2(OK, but AI trireme not moving?), trunk(OK)
* bug #14489: S2_2(OK) trunk(not working and lot of error messages)

There are probably here not related bugs...


___

Reply to this item at:

  http://gna.org/bugs/?16613

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1865] Omani nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1865 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?1865

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1866] Somalian nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1866 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?1866

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1878] Montenegrin and Yugoslav nations

2010-09-05 Thread J.M. Maalderink

Update of patch #1878 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?1878

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16413] Gold upkeep and Military unhappiness

2010-09-05 Thread David Fernandez

Follow-up Comment #5, bug #16413 (project freeciv):

Sorry me the double post, we post previous comment at same time.

I'm trying to apply the patch right now, but it is the first time I compile
the svn trunk version, and I advance slowly.

Did you test the upkeep problem? I'm also playing longturn and at the
moment I can't build a military unit because my city is to small to support
it.

City size: 1
Possible military units: 1 (needs more testing; using shield upkeep)

I'm not sure if I understood your post, does it mean that you already
included the population limit into the patch?
I'll verify it as soon as I can patch and compile it.


___

Reply to this item at:

  http://gna.org/bugs/?16413

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16413] Gold upkeep and Military unhappiness

2010-09-05 Thread David Fernandez

Follow-up Comment #6, bug #16413 (project freeciv):

Now I think I understood your post...

Yes, I have verified the upkeep problem. It is true that with shield upkeep
you can not create or rehome units if the city production is already 0.
Still, you can construct Bach's wonder (force content 2) and it would allow a
city with pop = 2 to send to war as much units as his production, without any
unhappiness under democracy.

Pop 2 city with railroads and mines can support a lot of units, arround 10 or
so. And that is much higher than the effect of police stations or Women
suffrage wonder.
Also, it is a known multiplayer trick/exploit to construct Shakespeare
theater (no unhappy) in a city with a lot of production and to rehome all
your attacking units to that city. It practically dissables the military
unhappiness by Democracy/Republic governments.

With gold upkeep is even worse, because there is no limit to the units you
can construct or rehome, even if your income is negative. It is logical, else
when you move the tax bar you would affect the max units per city.

That is why I suggest to use population as an alternative limit for both gold
and shield upkeep.


In my civ2-3 ruleset, I solved partially the exploit of force_content,
make_happy and no_unhappy, by replacing them by luxury bonuses in the central
tile of cities. Because luxuries can not remove the unhappiness caused by
military units (they are taken into account before), and at same time
luxuries can create other happy citizens to counter the citizens unhappy by
military units.
But I guess people do not like such changes in default ruleset.


Btw, I have been able to compile and execute the trunk, and I'm trying to
edit manually the file cityturn.c with your changes, to test them.
Current Trunk revision 17939 gives me this error message when I start new
game:

Please report this message at https://gna.org/projects/freeciv/
in can_player_build_unit_direct() [unittype.c::631]: assertion '((void *)0)
!= punittype' failed.


That is all, sorry me the long post.

___

Reply to this item at:

  http://gna.org/bugs/?16413

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1902] Apache nation

2010-09-05 Thread J.M. Maalderink

Follow-up Comment #4, patch #1902 (project freeciv):

There seems to be a problem with the UTF parsing, it doesn't display special
characters. Could you have a look into that?

___

Reply to this item at:

  http://gna.org/patch/?1902

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1899] Sicilian nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1899 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?1899

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1900] Yucatecan nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1900 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?1900

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1901] Micronesian nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1901 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?1901

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1905] Elamite nation

2010-09-05 Thread J.M. Maalderink

Follow-up Comment #3, patch #1905 (project freeciv):

I think that would be a bit anachronistic; the Elamites and the modern
inhabitants of Khuzestan are completely different people.

What about something in cuneiform? The word 'Elam' perhaps?

___

Reply to this item at:

  http://gna.org/patch/?1905

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1909] Ivoirian nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1909 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?1909

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16177] Patch for a new nation: Acadian

2010-09-05 Thread J.M. Maalderink

Update of bug #16177 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/bugs/?16177

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1923] Cossack nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1923 (project freeciv):

  Status:None = In Progress


___

Reply to this item at:

  http://gna.org/patch/?1923

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1925] Numunu nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1925 (project freeciv):

  Status:None = In Progress

___

Follow-up Comment #3:

Perhaps it would be better to call this nation Comanche instead of Numunu?
They are much better known as Comache than Numunu.

Perhaps it's a good idea to have a discussion about naming indigenous peoples
anyway, when we should use endonyms and when exonyms. At the moment it seems
to be a bit random (I'm responsible for that myself too).

___

Reply to this item at:

  http://gna.org/patch/?1925

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1925] Numunu nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1925 (project freeciv):

 Assigned to:None = mixcoatl   


___

Reply to this item at:

  http://gna.org/patch/?1925

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1923] Cossack nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1923 (project freeciv):

 Assigned to:None = mixcoatl   


___

Reply to this item at:

  http://gna.org/patch/?1923

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1921] Komi nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1921 (project freeciv):

  Status:None = In Progress
 Assigned to:None = mixcoatl   


___

Reply to this item at:

  http://gna.org/patch/?1921

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1929] Gothic nation

2010-09-05 Thread J.M. Maalderink

Update of patch #1929 (project freeciv):

  Status:None = In Progress
 Assigned to:None = mixcoatl   

___

Follow-up Comment #1:

Goths, sweet.

What about splitting this into Visigoths and Ostrogoths? That way we can use
the Spanish/French and Italian cities in their domains so we'd avoid the
problem that they initially were no urban culture.

Also they still need flags.

___

Reply to this item at:

  http://gna.org/patch/?1929

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1931] Newfoundland nation

2010-09-05 Thread J.M. Maalderink

URL:
  http://gna.org/patch/?1931

 Summary: Newfoundland nation
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Monday 09/06/2010 at 05:14
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Newfoundlanders

The emblem on the flag looks a bit silly (there was no .svg flag of the
Dominion of Newfoundland avaiable so I had to make one myself), but in game
it will be so small it won't be noticable.



___

File Attachments:


---
Date: Monday 09/06/2010 at 05:14  Name: newfoundland.svg  Size: 11kB   By:
mixcoatl

http://gna.org/patch/download.php?file_id=10193
---
Date: Monday 09/06/2010 at 05:14  Name: newfoundland.ruleset  Size: 3kB   By:
mixcoatl

http://gna.org/patch/download.php?file_id=10192

___

Reply to this item at:

  http://gna.org/patch/?1931

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1932] flag fix

2010-09-05 Thread J.M. Maalderink

URL:
  http://gna.org/patch/?1932

 Summary: flag fix
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Monday 09/06/2010 at 05:17
Category: art
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Some fixes to flags. Most of them are color or proportion corrections. The
Serbian flag has a coat of arms added.



___

File Attachments:


---
Date: Monday 09/06/2010 at 05:17  Name: flags.patch  Size: 430kB   By:
mixcoatl

http://gna.org/patch/download.php?file_id=10194

___

Reply to this item at:

  http://gna.org/patch/?1932

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1934] Bhutanese nation

2010-09-05 Thread J.M. Maalderink

URL:
  http://gna.org/patch/?1934

 Summary: Bhutanese nation
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Monday 09/06/2010 at 05:21
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Bhutan



___

File Attachments:


---
Date: Monday 09/06/2010 at 05:21  Name: bhutanese.ruleset  Size: 2kB   By:
mixcoatl

http://gna.org/patch/download.php?file_id=10196

___

Reply to this item at:

  http://gna.org/patch/?1934

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1935] Lorrain nation

2010-09-05 Thread J.M. Maalderink

URL:
  http://gna.org/patch/?1935

 Summary: Lorrain nation
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Monday 09/06/2010 at 05:22
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Lorrains



___

File Attachments:


---
Date: Monday 09/06/2010 at 05:22  Name: lorrain.ruleset  Size: 2kB   By:
mixcoatl

http://gna.org/patch/download.php?file_id=10197

___

Reply to this item at:

  http://gna.org/patch/?1935

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev