[Freeciv-Dev] [patch #2113] Consistency in German sub-national nations
URL:
http://gna.org/patch/?2113
Summary: Consistency in German sub-national nations
Project: Freeciv
Submitted by: mixcoatl
Submitted on: Tuesday 10/26/2010 at 06:50
Category: rulesets
Priority: 3 - Low
Status: Ready For Test
Privacy: Public
Assigned to: mixcoatl
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 2.3.0
___
Details:
Made sure that the same cities in different nationsets have the same names
(usually that meant removing or adding 'am some river', and took out some
cities that were included twice in the same nation. Abbreviations written in
full ('a.d.' to 'an der'). Some nations have some extra rulers and cities.
Plus some other minor edits
___
File Attachments:
---
Date: Tuesday 10/26/2010 at 06:50 Name: german_consistency.diff Size: 14kB
By: mixcoatl
http://gna.org/patch/download.php?file_id=10943
___
Reply to this item at:
http://gna.org/patch/?2113
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2108] Fix usage of the prefix find_ and the suffix _by_id in function names
Follow-up Comment #2, patch #2108 (project freeciv): please try the following command: patch -p1 ./0001-Harmonize-common-part-function-names-for.patch git adds one directory level to the path. Thus the option '-p1' is needed. ___ Reply to this item at: http://gna.org/patch/?2108 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2108] Fix usage of the prefix find_ and the suffix _by_id in function names
Follow-up Comment #3, patch #2108 (project freeciv): Yes, as Matthias said, you have to use the -p1 option. ___ Reply to this item at: http://gna.org/patch/?2108 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16956] 'topology' doesn't match anymore numbers
URL: http://gna.org/bugs/?16956 Summary: 'topology' doesn't match anymore numbers Project: Freeciv Submitted by: pepeto Submitted on: mardi 26.10.2010 à 11:06 Category: client Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: pepeto Originator Email: Open/Closed: Open Release: trunk Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: ... whereas client/connectdlg.c still assumes it does. Fix attached. ___ File Attachments: --- Date: mardi 26.10.2010 à 11:06 Name: trunk_connectdlg_set_topology.diff Size: 937 o By: pepeto http://gna.org/bugs/download.php?file_id=10944 ___ Reply to this item at: http://gna.org/bugs/?16956 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1301] [Metaticket] settings patch series
Update of patch #1301 (project freeciv): Depends on: = bugs #16956 ___ Reply to this item at: http://gna.org/patch/?1301 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16938] conflicts_with seems to have no effect
Update of bug #16938 (project freeciv): Status: Need Info = Confirmed ___ Follow-up Comment #3: I confirm that the canadian nation is picked whereas it is in conflict with other already picked nations and there are other available nations. ___ Reply to this item at: http://gna.org/bugs/?16938 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16935] People abuse taking your nation.
Update of bug #16935 (project freeciv): Status: Need Info = Works For Me Assigned to:None = pepeto Open/Closed:Open = Closed ___ Follow-up Comment #4: allowtake already prevents about this. ___ Reply to this item at: http://gna.org/bugs/?16935 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16923] elves nation
Update of bug #16923 (project freeciv): Status: Need Info = Works For Me Assigned to:None = pepeto Open/Closed:Open = Closed ___ Follow-up Comment #2: This appear clearly to be an installation problem. ___ Reply to this item at: http://gna.org/bugs/?16923 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16922] Freeciv manpage lists old email address
Update of bug #16922 (project freeciv): Category:None = docs Status:None = Need Info ___ Follow-up Comment #1: Also it points to http://bugs.freeciv.org/ for bug reporting. It should probably pick those values somewhere when installing it... Where are those values defined? ___ Reply to this item at: http://gna.org/bugs/?16922 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16920] Segfault when issuing huge goto
Update of bug #16920 (project freeciv): Planned Release: = 2.3.0 ___ Follow-up Comment #2: Well, I can get this into 2.3, whereas the whole stuff won't be done before 2.4. ___ Reply to this item at: http://gna.org/bugs/?16920 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16912] Not wall popup
Update of bug #16912 (project freeciv): Status: Need Info = Wont Fix Assigned to:None = pepeto Open/Closed:Open = Closed ___ Follow-up Comment #3: Options compatibility between old branches issues. ___ Reply to this item at: http://gna.org/bugs/?16912 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16903] Inconsistently singular/plural unit names cause improper grammar
Update of bug #16903 (project freeciv): Priority: 5 - Normal = 1 - Later ___ Follow-up Comment #2: Actually, this can be worse in other language when the form the verb or the adjectives depend of the subject gender and number. ___ Reply to this item at: http://gna.org/bugs/?16903 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16871] Having more AIs than nations segfaults at start
Update of bug #16871 (project freeciv): Category:None = general Status:None = In Progress ___ Follow-up Comment #2: Since bug #16857 is fixed, I cannot reproduce anymore. Can you? ___ Reply to this item at: http://gna.org/bugs/?16871 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16956] 'topology' doesn't match anymore numbers
Follow-up Comment #1, bug #16956 (project freeciv): I don't understand the report let alone the .diff but it seems to deal with 'isometric' and 'hex'... Does this have anything to do with the fact that if I want to create a tileset which is compatible with topologies 12-15 (iso-hex), I need to define is_isometric = 0 is_hex = 1 whereas for topologies 4-7 (isometric) is_isometric needs to be set to 1 ? ___ Reply to this item at: http://gna.org/bugs/?16956 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16957] multiplayer network games: when not online during turn, lose messages
URL: http://gna.org/bugs/?16957 Summary: multiplayer network games: when not online during turn, lose messages Project: Freeciv Submitted by: None Submitted on: Tuesday 10/26/2010 at 15:39 CEST Category: client Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: ephae...@gmx.net Open/Closed: Open Release: 2.2.1 Discussion Lock: Any Operating System: *BSD Planned Release: ___ Details: Note that this is a pre-2.2.1 bug and post-, too. It happens on all operating systems. When playing multiplayer games and you are not online at the time that the turn is calculated, you will lose messages. Basically all of them... Anything directed to the message window about game events like, city about to grow, suggest throttle, city grows to size X etc. etc. etc. will NOT be replayed upon reconnecting. Reproduce: start a 2 player game. turn done the first player, close first connection, turn done second player and stay online - server calculates the new turn. Reconnect first player. Note that this player is NOT informed about any advanced the civilization has made in the current turn. For later stages of the game with fixed size turns that sucks severely. Please replay the messages upon EVERY reconnect. ___ Reply to this item at: http://gna.org/bugs/?16957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16957] multiplayer network games: when not online during turn, lose messages
Update of bug #16957 (project freeciv): Category: client = general Severity: 4 - Important = 3 - Normal Operating System:*BSD = None Planned Release: = 2.2.4, 2.3.0 ___ Follow-up Comment #1: That's probably because the event cache is freed too early. Else, you can probably temporary fix the problem, setting 'ec_turns' to 2. ___ Reply to this item at: http://gna.org/bugs/?16957 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16956] 'topology' doesn't match anymore numbers
Follow-up Comment #2, bug #16956 (project freeciv): According to the test of tilesets (but not documented): * hex: hex_height = 0, hex_width 0. * iso-hex: hex_height 0, hex_width = 0. ___ Reply to this item at: http://gna.org/bugs/?16956 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16957] multiplayer network games: when not online during turn, lose messages
Follow-up Comment #3, bug #16957 (project freeciv): Sorry for my last message, it was for bug #16956. ___ Reply to this item at: http://gna.org/bugs/?16957 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16958] no messages for diplomat combat when in allied city
URL: http://gna.org/bugs/?16958 Summary: no messages for diplomat combat when in allied city Project: Freeciv Submitted by: None Submitted on: Tuesday 10/26/10 at 16:28 CEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.2.3 Discussion Lock: Any Operating System: Microsoft Windows Planned Release: ___ Details: When my diplomats are defending an allied city and the city is attacked by enemy diplomats I get no messages about the combat. Perhaps these messages go to the city owner. All I get is the messages about promotion when my diplomat has been successful. I do not know who the diplomat fought or how many times. This has occurred when I am offline - the combat messages for other military units are sent to the event cache. I have switched on the combat success and fail messages. It would be nice if both the city owner and the unit owner got messages about diplomat combat in an allied city. ___ Reply to this item at: http://gna.org/bugs/?16958 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2108] Fix usage of the prefix find_ and the suffix _by_id in function names
Follow-up Comment #4, patch #2108 (project freeciv): That did the trick - thanks. ___ Reply to this item at: http://gna.org/patch/?2108 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16940] Appending ruler titles
Update of bug #16940 (project freeciv): Assigned to:None = dmarks ___ Follow-up Comment #4: It's working as intended! I'll cook up a patch for the ruleset files. ___ Reply to this item at: http://gna.org/bugs/?16940 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16938] conflicts_with seems to have no effect
Update of bug #16938 (project freeciv): Status: Confirmed = Ready For Test Assigned to:None = pepeto Planned Release: = 2.2.4, 2.3.0 ___ Follow-up Comment #4: Actually, it didn't have no effect, but the effect was really low. The attached patch changes that the nations in conflicts are picked last. Moreover, most the nations in conflicts match the nations groups, less chance they are to be picked. In your ruleset, if you pick a nation in conflict with Canada, the 15th player will always pick Canada (last nation). (file #10945, file #10946) ___ Additional Item Attachment: File name: trunk_pick_a_nation.diff Size:6 KB File name: S2_2_pick_a_nation.diffSize:6 KB ___ Reply to this item at: http://gna.org/bugs/?16938 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16957] multiplayer network games: when not online during turn, lose messages
Follow-up Comment #4, bug #16957 (project freeciv): This is also a problem for solitaire games: when you load an auto-save, most messages will not be displayed. Setting Event cache to gives the desired behavior. This is such a useful change that i wish it was the default... ___ Reply to this item at: http://gna.org/bugs/?16957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16876] Player name duplication
Update of bug #16876 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Open/Closed:Open = Closed Planned Release: = 2.3.0 ___ Follow-up Comment #1: Fix attached for trunk/. It requires really too much work for 2.2. (file #10947) ___ Additional Item Attachment: File name: trunk_server_player_set_name.diff Size:19 KB ___ Reply to this item at: http://gna.org/bugs/?16876 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16876] Player name duplication
Update of bug #16876 (project freeciv): Open/Closed: Closed = Open ___ Reply to this item at: http://gna.org/bugs/?16876 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16959] Fighter paths are buggy
URL: http://gna.org/bugs/?16959 Summary: Fighter paths are buggy Project: Freeciv Submitted by: pepeto Submitted on: mardi 26.10.2010 à 18:27 Category: agents Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: Do some tests with the attached savegame. I don't know yet the cause. ___ File Attachments: --- Date: mardi 26.10.2010 à 18:27 Name: freeciv-T-Y-4000-manual.sav.gz Size: 118 ko By: pepeto http://gna.org/bugs/download.php?file_id=10948 ___ Reply to this item at: http://gna.org/bugs/?16959 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16959] Fighter paths are buggy
Update of bug #16959 (project freeciv): Status:None = Invalid Assigned to:None = pepeto Open/Closed:Open = Closed ___ Follow-up Comment #1: Sorry, just noticed that the strange moves of my fighters was due to the usage of a hex-iso topology using trident tileset. There is no such bug. ___ Reply to this item at: http://gna.org/bugs/?16959 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16960] newfoundland.ruleset not included in nation/Makefile.am
URL: http://gna.org/bugs/?16960 Summary: newfoundland.ruleset not included in nation/Makefile.am Project: Freeciv Submitted by: jtn Submitted on: Tuesday 10/26/10 at 20:11 Category: None Severity: 4 - Important Priority: 5 - Normal Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: trunk Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: Since patch #1931. This causes the server not to start after being run from its final location after make install. ___ File Attachments: --- Date: Tuesday 10/26/10 at 20:11 Name: trunk-newfoundland-install.diff Size: 375B By: jtn trunk r18303: add newfoundland.ruleset to nation/Makefile.am http://gna.org/bugs/download.php?file_id=10949 ___ Reply to this item at: http://gna.org/bugs/?16960 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16960] A couple of new nation files missing from Makefiles
Update of bug #16960 (project freeciv): Summary: newfoundland.ruleset not included in nation/Makefile.am = A couple of new nation files missing from Makefiles ___ Follow-up Comment #1: As well as newfoundland.ruleset not being included in nation/Makefile.am, I've found Apache flags from patch #1902 aren't included in flags/Makefile.am, causing a similar problem for the client. (file #10950) ___ Additional Item Attachment: File name: trunk-makefiles-missing-nations.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?16960 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16920] Segfault when issuing huge goto
Update of bug #16920 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #3: Attaching the 2 patches I was talking about at comment #1. (file #10951, file #10952) ___ Additional Item Attachment: File name: 0001-Improved-pf_-_map_iterate_until-functions.patch Size:3 KB File name: 0002-pf_danger_map_iterate-and-pf_fuel_map_iterate-are-no.patch Size:28 KB ___ Reply to this item at: http://gna.org/bugs/?16920 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2108] Fix usage of the prefix find_ and the suffix _by_id in function names
Update of patch #2108 (project freeciv): Assigned to:None = pepeto ___ Reply to this item at: http://gna.org/patch/?2108 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16872] Multiline strings with CR newlines incorrectly wrapped
Follow-up Comment #6, bug #16872 (project freeciv): Still open? ___ Reply to this item at: http://gna.org/bugs/?16872 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed
Update of patch #2077 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #3: Patch attached. Some additional design decisions: * rule_name added to: bases, city styles, governments, improvements, specialists, advances, terrains, resources, unit classes, unit types, and nations. ** Nations are the only kind of object which is checked for duplicate names when rulesets are loaded. Extended that to check for duplicate rule_name or untranslated vernacular name (but no cross-checks). * Not added to nation groups, since they have no kind of persistent existence, so can be renamed easily anyway. Side effects: * Fixes a bug where ruleset objects with qualified names weren't able to be translated on the client. The qualifier was stripped off before being sent over the network, so the client would end up trying to translate a string that wasn't necessarily in the po-file. This can be reproduced on trunk by looking at the Pick nation dialog in a non-English language; most nation groups and city styles are not translated (a few are because they happen to pick up the strings from real nations). ** S2_2 doesn't seem to suffer from this. I haven't investigated when it broke. * Loading a ruleset will now fail if any of the mentioned objects don't have a name entry (previously this would have caused bugs later). * Propagated trick of adding ; /* and ; */ from default/buildings.ruleset to other ruleset files to stop apostrophes in format comments from causing gettext warnings (alternative solution to bug #16464). (file #10953) ___ Additional Item Attachment: File name: trunk-allow-ruleset-rename.diff Size:77 KB ___ Reply to this item at: http://gna.org/patch/?2077 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16374] Typos in translatable strings
Update of bug #16374 (project freeciv): Summary: Typos in = Typos in translatable strings ___ Reply to this item at: http://gna.org/bugs/?16374 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16957] multiplayer network games: when not online during turn, lose messages
Follow-up Comment #5, bug #16957 (project freeciv): (original submitter) David Lowe: Setting Event cache to gives the desired behaviour Setting event cache to TWO? I hope this still is possible for games running already :) ___ Reply to this item at: http://gna.org/bugs/?16957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed
Follow-up Comment #4, patch #2077 (project freeciv): Fixes a bug where ruleset objects with qualified names weren't able to be translated on the client. The qualifier was stripped off before being sent over the network, so the client would end up trying to translate a string that wasn't necessarily in the po-file. This can be reproduced on trunk by looking at the Pick nation dialog in a non-English language; most nation groups and city styles are not translated (a few are because they happen to pick up the strings from real nations). I think that was my mistake when I added the file for name_translation. I didn't notice it. ___ Reply to this item at: http://gna.org/patch/?2077 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2111] Speclist cleanup
Follow-up Comment #1, patch #2111 (project freeciv): Second version of this patch: * Moved the speclist-related macros to utility/speclist.h. (file #10954) ___ Additional Item Attachment: File name: 0002-speclist.patchSize:52 KB ___ Reply to this item at: http://gna.org/patch/?2111 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed
Follow-up Comment #6, patch #2077 (project freeciv): In my opinion Qn_(untranslated_name()) test should create a fatal error for the ruleset. It should test rule_name() or untranslated_name() with the qualifier. Note, it doesn't check the translation neither... I'm not sure what you're referring to here. Do you mean the test for uniqueness in load_nation_names()? The intent behind those tests (after my changes) was twofold: (a) to avoid duplicate rule_names, which is clearly and unambiguously a fatal problem for the game itself, and (b) to avoid two separate game entities having the same user-visible string, which is more arguable. That's why I'm comparing after stripping off the qualifier with Qn() (and it's more or less equivalent to the old code). Comparing with the qualifier included could let through two identical-to-the-user nations, and I'm finding it hard to think of a reason why we'd ever want two nations with the same English string and different qualifiers. In any case I think most of the value in this check is to catch silly mistakes when adding new nations, such as forgetting to edit the name in the file you copied (which is I assume why we have this check for nations and nothing else). In that case, the qualifier likely won't be changed either, so a check with or without Qn_() will catch this class of error. As untranslated_name() is nearly not used and rule_name() is now a field of the name_translation structure, the pointer member (translated) should be useful to keep the start of the string to display to the user Qn(vernicular). I'm afraid I don't understand what you're suggesting here. I am also thinking about adding functions like dio_put_name_translation() and dio_get_name_translation() to handle them through the network. I did wonder about standardising the transport of rule/pretty names over the network. Note that those changes would also useful for the settings pretty and support names (which are actually name_translation and rule_name). That's a very good point. I hadn't thought of that, despite working on the options code recently. ___ Reply to this item at: http://gna.org/patch/?2077 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16957] multiplayer network games: when not online during turn, lose messages
Follow-up Comment #6, bug #16957 (project freeciv): Yes and yes. I was just suggesting that having ec_turns=1 seems sub-optimal for most folks and that changing it to 2 would be kind to newbies... or if the underlying problem of the event cache being freed too early is dealt with, then it could stay at 1. Changing the default is quicker, but early freeing of the cache may be causing other problems ___ Reply to this item at: http://gna.org/bugs/?16957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
