Re: [Freeciv-Dev] Ancients modpack (was: [task #7606] Setup freeciv 2.4 files in modpack.freeciv.org)

2012-08-09 Thread David Lowe
On 2012 Aug 8, at 6:06 AM, Marko Lindqvist wrote: Maybe it's time to introduce some kind of stars system to freeciv-modpack. Wouldn't that open us up to charges of favoritism and/or poor taste? If it comes down to somebody's personal opinion, there are going to be users who feel

[Freeciv-Dev] [bug #20038] Transform to water

2012-08-09 Thread David Lowe
Follow-up Comment #2, bug #20038 (project freeciv): I like Cazfi's idea, but let me throw in another possibility. Perhaps make the transformed tile conditional on whether it is adjacent to Lake/River or Ocean. If there is no water near then it should default to Lake. But maybe it is more

[Freeciv-Dev] [patch #3476] Alien World: Same trade from traderoutes regardless if cities are in same continent or not

2012-08-09 Thread Marko Lindqvist
Update of patch #3476 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #3394] Specenum user flag names

2012-08-09 Thread Marko Lindqvist
Update of patch #3394 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #3492] civ2civ3: Remove separate Geoengineer unit

2012-08-09 Thread Marko Lindqvist
URL: http://gna.org/patch/?3492 Summary: civ2civ3: Remove separate Geoengineer unit Project: Freeciv Submitted by: cazfi Submitted on: Thu 09 Aug 2012 03:03:56 PM EEST Category: rulesets Priority: 5 -

[Freeciv-Dev] [bug #20039] Check boolean effects correctly when calculating value of government

2012-08-09 Thread Marko Lindqvist
URL: http://gna.org/bugs/?20039 Summary: Check boolean effects correctly when calculating value of government Project: Freeciv Submitted by: cazfi Submitted on: Thu 09 Aug 2012 03:13:38 PM EEST Category: ai

[Freeciv-Dev] [patch #3493] Refer to README.ruleset_civ2civ3 in civ2civ3 ruleset description

2012-08-09 Thread Marko Lindqvist
URL: http://gna.org/patch/?3493 Summary: Refer to README.ruleset_civ2civ3 in civ2civ3 ruleset description Project: Freeciv Submitted by: cazfi Submitted on: Thu 09 Aug 2012 03:26:23 PM EEST Category: rulesets

[Freeciv-Dev] make distcheck (was: [patch #3475] Translate version tags received) from metaserver

2012-08-09 Thread Jacob Nevins
Marko Lindqvist writes: I've been trying to test that this does not break tarballs or installations, but every time during 'make distcheck' my computer completely freezes to the point I have to reboot. I assume that it's something broken in this system (It's known to have constant reliability

[Freeciv-Dev] [bug #20040] Scenarios (including tutorial) set citymindist=0

2012-08-09 Thread Jacob Nevins
URL: http://gna.org/bugs/?20040 Summary: Scenarios (including tutorial) set citymindist=0 Project: Freeciv Submitted by: jtn Submitted on: Thu Aug 9 17:57:44 2012 Category: None Severity: 3 - Normal

[Freeciv-Dev] [patch #3494] popup_incite_dialog(struct city *pcity, int cost) implementation

2012-08-09 Thread anonymous
URL: http://gna.org/patch/?3494 Summary: popup_incite_dialog(struct city *pcity, int cost) implementation Project: Freeciv Submitted by: None Submitted on: Thu 09 Aug 2012 05:37:38 PM UTC Category: client-qt

[Freeciv-Dev] [bug #20040] Scenarios (including tutorial) set citymindist=0

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #1, bug #20040 (project freeciv): I assume that all old savegames (with citymindist of 0) are affected, not only scenarios. Quite bad, actually. Has quite a big effect on any attempts to continue old game is 2.4. Reason to postpone beta1?

[Freeciv-Dev] [bug #20041] citymindist=0 loaded verbatim from old savefiles

2012-08-09 Thread Jacob Nevins
URL: http://gna.org/bugs/?20041 Summary: citymindist=0 loaded verbatim from old savefiles Project: Freeciv Submitted by: jtn Submitted on: Thu Aug 9 19:50:39 2012 Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #20040] Scenarios (including tutorial) set citymindist=0

2012-08-09 Thread Jacob Nevins
Follow-up Comment #2, bug #20040 (project freeciv): Blargh. But I'd rather not slip the release as I don't know when I'll get a clear run at it. I'll see if a quick low-risk fix is possible. Bug #20041. ___ Reply to this item at:

[Freeciv-Dev] [bug #20041] citymindist=0 loaded verbatim from old savefiles

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #1, bug #20041 (project freeciv): Would just coverting value 0 to current citymindist default (GAME_DEFAULT_CITYMINDIST = 2) be acceptable? ___ Reply to this item at: http://gna.org/bugs/?20041

[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-09 Thread Marko Lindqvist
URL: http://gna.org/patch/?3495 Summary: Starting with first city placed Project: Freeciv Submitted by: cazfi Submitted on: Thu 09 Aug 2012 10:32:46 PM EEST Category: None Priority: 5 - Normal

[Freeciv-Dev] [bug #20041] citymindist=0 loaded verbatim from old savefiles

2012-08-09 Thread Jacob Nevins
Update of bug #20041 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn ___ Follow-up Comment #2: The attached fix

[Freeciv-Dev] [bug #20040] Scenarios (including tutorial) set citymindist=0

2012-08-09 Thread Jacob Nevins
Update of bug #20040 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #3: Fix attached. Trunk tutorial wasn't affected since the rewrite (patch #3377). (file #16358,

[Freeciv-Dev] [bug #20041] citymindist=0 loaded verbatim from old savefiles

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #3, bug #20041 (project freeciv): Commit ASAP to get as much testing as possible, or wait for review as normal and commit just before release (or abort release)? It's so unlikely that someone less active, or someone new, happens to pop up just during the last hours of this

[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-09 Thread J. M. Gorbach
Follow-up Comment #1, patch #3495 (project freeciv): I used to insert in script.lua a function. function city_nation_swedish() local owner = find.player(0) local Stockholm = find.tile(208,93) create_city(owner, Stockholm, 'Stockholm') end function turn_cb(turn, year) if

[Freeciv-Dev] [patch #2624] Script-triggered climate change

2012-08-09 Thread Jacob Nevins
Follow-up Comment #4, patch #2624 (project freeciv): Huh. When this was moved into the 'edit' module (patch #2514), so was the enumeration, so now one needs to do edit.climate_change(edit.GLOBAL_WARMING, 50). On the one hand, I'd like to just write a bare GLOBAL_WARMING as the enum-like

[Freeciv-Dev] [bug #20041] citymindist=0 loaded verbatim from old savefiles

2012-08-09 Thread Marko Lindqvist
Update of bug #20041 (project freeciv): Category:None = general Assigned to: jtn = cazfi Planned Release: 2.4.0,2.5.0 = 2.4.0-beta1, 2.5.0

[Freeciv-Dev] [bug #20041] citymindist=0 loaded verbatim from old savefiles

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #4, bug #20041 (project freeciv): Reading the code this seems something that currently (beta1 at least) works. Note for future, though, that as it relies on value 0 to be present *after* settings are loaded, not only inside settings loading, this will break if we add loaded

[Freeciv-Dev] [bug #20043] On trunk, transforming any tile bordering lake turns lake to ocean

2012-08-09 Thread Jacob Nevins
URL: http://gna.org/bugs/?20043 Summary: On trunk, transforming any tile bordering lake turns lake to ocean Project: Freeciv Submitted by: jtn Submitted on: Thu Aug 9 23:37:24 2012 Category: None

[Freeciv-Dev] [bug #20043] On trunk, transforming any tile bordering lake turns lake to ocean

2012-08-09 Thread Jacob Nevins
Update of bug #20043 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-transform-to-lake.patch Size:13 KB

[Freeciv-Dev] [bug #20043] On trunk, transforming any tile bordering lake turns lake to ocean

2012-08-09 Thread Jacob Nevins
Update of bug #20043 (project freeciv): Release: trunk r = trunk r21766 ___ Reply to this item at: http://gna.org/bugs/?20043 ___ Message sent

[Freeciv-Dev] [bug #20038] Transform to water

2012-08-09 Thread Jacob Nevins
Update of bug #20038 (project freeciv): Planned Release: 2.5.0 = ___ Follow-up Comment #3: Simplest solution, possibly something we implement at least for the time we wait your model

[Freeciv-Dev] [task #7599] Windows packages for 2.4.0-beta1

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #11, task #7599 (project freeciv): the attached patch makes the installer Makefile build Freeciv with SQLite support. This would require also bug #20005 patch to achieve anything. I've had no chance to test this. Both patches have been submitted over 36h of review period ago,

[Freeciv-Dev] [bug #20038] Transform to water

2012-08-09 Thread Jacob Nevins
Follow-up Comment #4, bug #20038 (project freeciv): Perhaps make the transformed tile conditional on whether it is adjacent to Lake/River or Ocean. This ticket was originally about trying to find a general solution to have that effect without hardcoding assumptions about rulesets into the game

[Freeciv-Dev] [task #7606] Setup freeciv 2.4 files in modpack.freeciv.org

2012-08-09 Thread Marko Lindqvist
Update of task #7606 (project freeciv): Status: In Progress = Done Percent Complete: 0% = 100% Open/Closed:Open = Closed Planned Release:

[Freeciv-Dev] [patch #3485] Update lua-5.2 tree to version 5.2.1

2012-08-09 Thread Marko Lindqvist
Update of patch #3485 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #3496] Include localluaconf.h to lua-5.2 luaconf.h

2012-08-09 Thread Marko Lindqvist
URL: http://gna.org/patch/?3496 Summary: Include localluaconf.h to lua-5.2 luaconf.h Project: Freeciv Submitted by: cazfi Submitted on: Fri 10 Aug 2012 02:43:44 AM EEST Category: general Priority: 5 -

[Freeciv-Dev] [patch #3484] Tileset type definition

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #1, patch #3484 (project freeciv): - Updated documentation in README.graphics (file #16362) ___ Additional Item Attachment: File name: TilesetType-2.patchSize:10 KB

[Freeciv-Dev] [patch #3382] simplify buttons based on stock images

2012-08-09 Thread Marko Lindqvist
Update of patch #3382 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Follow-up Comment #1: r21770

[Freeciv-Dev] [patch #3482] Remove init_government from individual civ1/civ2 nations

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #4, patch #3482 (project freeciv): Last commit that referred to this ticket was about patch #3382 in reality. ___ Reply to this item at: http://gna.org/patch/?3482 ___

[Freeciv-Dev] [patch #2963] Use ferryboat system for trade

2012-08-09 Thread Jordi Negrevernis i Font
Follow-up Comment #10, patch #2963 (project freeciv): _Still needs to decide what to do with dai_is_unit_tired_waiting_boat(). It's counting time from caravan's original birth. Old units could not be reassigned to a mission, as they would give up immediately. _ This is trying to give some time

[Freeciv-Dev] [patch #2963] Use ferryboat system for trade

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #11, patch #2963 (project freeciv): It's counting time from caravan's original birth This is trying to give some time to the unit to find an intercontinental route and a transport to that city. I see that, but it's only giving time for newly created unit. It's always

[Freeciv-Dev] [bug #19952] City_Image decided client side

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #7, bug #19952 (project freeciv): - Added handling of pre-2.3 savegames (savegame.c) (file #16363) ___ Additional Item Attachment: File name: ServerSideCityImage-2.patchSize:6 KB

[Freeciv-Dev] [patch #3408] Server side scenario saving

2012-08-09 Thread Marko Lindqvist
Follow-up Comment #1, patch #3408 (project freeciv): - Set save reason as Scenario (file #16364) ___ Additional Item Attachment: File name: Scensave-2.patch Size:2 KB

[Freeciv-Dev] [bug #20044] Highest Peak in Scotland.

2012-08-09 Thread Marko Lindqvist
URL: http://gna.org/bugs/?20044 Summary: Highest Peak in Scotland. Project: Freeciv Submitted by: cazfi Submitted on: Fri 10 Aug 2012 04:34:30 AM EEST Category: None Severity: 3 - Normal

[Freeciv-Dev] [patch #3497] Save scenario information as first section in savegame

2012-08-09 Thread Marko Lindqvist
URL: http://gna.org/patch/?3497 Summary: Save scenario information as first section in savegame Project: Freeciv Submitted by: cazfi Submitted on: Fri 10 Aug 2012 04:42:26 AM EEST Category: general

[Freeciv-Dev] [patch #3497] Save scenario information as first section in savegame

2012-08-09 Thread Marko Lindqvist
Update of patch #3497 (project freeciv): Planned Release:2.4.0, 2.5.0 = 2.3.3, 2.4.0, 2.5.0 ___ Reply to this item at: http://gna.org/patch/?3497 ___ Message sent

[Freeciv-Dev] [bug #20045] assertion failed with civ2civ3 over S2_4

2012-08-09 Thread David Fernandez
URL: http://gna.org/bugs/?20045 Summary: assertion failed with civ2civ3 over S2_4 Project: Freeciv Submitted by: bardo Submitted on: vie 10 ago 2012 02:03:47 GMT Category: None Severity: 3 - Normal