[Freeciv-Dev] [bug #22111] 'non-pact diplstate in handle_player_cancel_pact' error in endless loop

2014-05-29 Thread anonymous 
URL:
  

 Summary: 'non-pact diplstate in handle_player_cancel_pact'
error in endless loop
 Project: Freeciv
Submitted by: None
Submitted on: Fri 30 May 2014 06:51:00 AM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: maecmp...@mail.ru
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

Hello,
I'm getting 'non-pact diplstate in handle_player_cancel_pact' error in endless
loop (last message repeated 2097152 times (total 4194304 repeats)) when I
click end turn. Save attached.

This could possibly happen in pact switch logic:

switch(old_type) {
  case DS_NO_CONTACT: /* possible if someone declares war on our ally */
  case DS_ARMISTICE:
  case DS_CEASEFIRE:
  case DS_PEACE:
new_type = DS_WAR;
break;
  case DS_ALLIANCE:
new_type = DS_ARMISTICE;
break;
  default:
log_error("non-pact diplstate in handle_player_cancel_pact");
return;
  }

Setting new_type = DS_WAR; in default instead of log_error can possibly solve
error. 



___

File Attachments:


---
Date: Fri 30 May 2014 06:51:00 AM UTC  Name:
freeciv-T0039-Y-2050-manual.sav.bz2  Size: 82kB   By: None



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20556] No way to disable hack access of new clients of local server with same user

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #3, bug #20556 (project freeciv):

> If you connect a second client to the server, it will get hack
> access.

Um... no? Server is not spawned by that client either.
Unless you mean compiling second client without --disable-client-hack, but one
would do that quite intentionally. Remember that this is not a security
feature, but debug/testing feature. It's actually a valid use-case to test
combination of hack and non-hack clients together.

> Why not using a server option (from command line) like
> "--hack"?

How spawned server could then tell the spawning client apart from others? Or,
assuming test involving both hack and non-hack clients, how does it know
should-allow-hack clients in general? That's why I think it should be in
client side.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20556] No way to disable hack access of new clients of local server with same user

2014-05-29 Thread pepeto 
Follow-up Comment #2, bug #20556 (project freeciv):

I don't think this is sufficient. If you connect a second client to the
server, it will get hack access.

Why not using a server option (from command line) like "--hack"?

I would expect that client get hack access on its spawn one, but not if
running the server separatly.

Maybe a second option for client side should be welcome to prevent to spawn
the server with "--hack"?


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17467] Fetched ini files temporary written to actual files

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #2, bug #17467 (project freeciv):

- Fixed crash in handling fz_FILEs created with fz_from_stream() 

(file #20861)
___

Additional Item Attachment:

File name: MemSecfile-2.patch Size:8 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21583] Client can connect to manually started server rather than its own spawned one

2014-05-29 Thread Marko Lindqvist 
Update of bug #21583 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #14:

Attached patch restores SO_REUSEADDR for lan scan sockets.

(file #20860)
___

Additional Item Attachment:

File name: LanScanSoReuseAddr.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22110] Border claiming base activity based on tile, not base, ownership

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Border claiming base activity based on tile, not
base, ownership
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 30 May 2014 02:34:00 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

is_border_source() checks if tile is owned to determine if base is active. It
should check if base is owned.

Fix attached.



___

File Attachments:


---
Date: Fri 30 May 2014 02:34:00 AM EEST  Name: BorderSourceBaseOwner.patch 
Size: 453B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22109] Editing Mode menu item does not get sensitive when player gets hack access

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Editing Mode menu item does not get sensitive when
player gets hack access
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 30 May 2014 02:12:43 AM EEST
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Edit -> Editing Mode does not get updated properly.

It's not getting sensitive or not sensitive when user access level changes. It
remains toggled if one exits one game with edit mode active and enters new
one.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20556] No way to disable hack access of new clients of local server with same user

2014-05-29 Thread Marko Lindqvist 
Update of bug #20556 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Planned Release: => 2.6.0  

___

Follow-up Comment #1:

Is attached patch sufficient?

It adds configure option --disable-client-hack. Behavior without this option
(client-hack enabled) remains exactly the same. With the option (client-hack
disabled) client will request hack access only if it has spawned the server
itself.

(file #20858)
___

Additional Item Attachment:

File name: ClientHack.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21583] Client can connect to manually started server rather than its own spawned one

2014-05-29 Thread Marko Lindqvist 
Update of bug #21583 (project freeciv):

  Status:   Fixed => In Progress
 Open/Closed:  Closed => Open   

___

Follow-up Comment #13:

Apparently *some* sockets should have SO_REUSEADDR while others not. Currently
lan announcements are broken as multiple games cannot open announcement
socket.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21514] Extra space in description of nameless rulesets

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #1, bug #21514 (project freeciv):

- Drop the word "template" from the description when its real named ruleset.

(file #20857)
___

Additional Item Attachment:

File name: RuleditTemplateNameSpace-2.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4734] Support versioning of custom rulesets

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #1, patch #4734 (project freeciv):

- freeciv-ruledit part implemented

(file #20856)
___

Additional Item Attachment:

File name: RulesetVersion-2.patch Size:11 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4734] Support versioning of custom rulesets

2014-05-29 Thread Marko Lindqvist 
Update of patch #4734 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3989] Build defenders for martial law needs

2014-05-29 Thread Marko Lindqvist 
Update of patch #3989 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21583] Client can connect to manually started server rather than its own spawned one

2014-05-29 Thread Marko Lindqvist 
Update of bug #21583 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22108] Gtk usage from client threads.

2014-05-29 Thread Marko Lindqvist 
Update of bug #22108 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Attached patches add gui function version_message(). gtk-clients direct
writing to actual output window to main thread from there. In other clients
it's just a wrapper around output window write.


(file #20854, file #20855)
___

Additional Item Attachment:

File name: VersionMessage.patch   Size:9 KB
File name: VersionMessage-S2_5.patch  Size:8 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21950] Game crash with popup message "Exhausted city and unit numbers!"

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #4, bug #21950 (project freeciv):

Either I had forgotten to send this patch, or it had some issue... sending now
for safekeeping at least.

I will recheck that in no place identity number is being placed to narrower
than 18 bit (32 bits in practice) variable.


(file #20853)
___

Additional Item Attachment:

File name: 18BitIdentity.patchSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #9, bug #22048 (project freeciv):

Opened bug #22108 about the wrong usage of gtk from metaserver thread.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22108] Gtk usage from client threads.

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Gtk usage from client threads.
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 11:49:09 PM EEST
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0, 2.6.0

___

Details:

>From bug 22048:
"However, are we violating rules for using Gtk+ in threads? The GDK3 docs say
"GTK+, however, is not thread safe. You should only use GTK+ and GDK from the
thread gtk_init() and gtk_main() were called on." (That's a Grk3 doc, but I
would be surprised if the same weren't also true of Gtk2.)"

Documentation makes it clear that writing the latest version check results to
output window should happen in main thread.

--

Also modpack installer thread usage should be checked -> will later open new
ticket.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22074] Vision not updated when city disbanded

2014-05-29 Thread Marko Lindqvist 
Update of bug #22074 (project freeciv):

 Planned Release: => 2.5.0, 2.6.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22081] Cumulative veteran effects for sea units (Port Facility vs Lighthouse, etc)?

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #1, bug #22081 (project freeciv):

1) I don't like handling this differently from land unit veterancy (Sun Tzu &
Barracks). Consistency.
2) Great Wonders are, in all supplied rulesets, made obsolete by "World" range
tech req (hardcoded behavior in 2.5, ruleset defined in 2.6). So it's also
part of other players' strategy to obsolete wonders, or at least not to avoid
obsoleting them. :-)

classic, experimental: Unlikely unless done deliberately, by *all* players or
with huge technological lead
multiplayer: consistency with Sun Tzu & Barracks
civ2civ3: *Someone* has Engineering, so wonder is obsolete
civ2: make consistent with Sun Tzu & Barracks


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22082] Lua disaster signal can't suppress message "We survived the disaster without serious damages."

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #2, bug #22082 (project freeciv):

In S2_5 we can't move it to lua as the signal does not tell if some of the
engine side effects fired.

So in S2_5 we should just get rid of the message.

In TRUNK we should at least pass boolean in lua signal telling if any of the
internal effects fired. It's more complicated question if we then use that
information in default.lua or ruleset specific script.lua.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4719] New disaster effect "ReducePopulationNoDestroy"

2014-05-29 Thread Marko Lindqvist 
Update of patch #4719 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Planned Release:   2.6.0 => 2.5.0, 2.6.0   

___

Follow-up Comment #1:

I think *not* destroying the city is better default (more in line with other
disaster effects) so attached patches take opposite approach.

- "ReducePopulation" is changed never to destroy the city (both S2_5 and
TRUNK)
- New "ReducePopDestroy" can destroy the city (TRUNK only)


(file #20851, file #20852)
___

Additional Item Attachment:

File name: ReduceDestroy.patchSize:6 KB
File name: ReduceNoDestroy-S2_5.patch Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4740] Classic ruleset name

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Classic ruleset name
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 10:41:13 PM EEST
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0, 2.6.0

___

Details:

Classic ruleset still internally claims to be "Default ruleset". Attached
patch renames it as "Classic ruleset" and adjusts also description
accordingly.



___

File Attachments:


---
Date: Thu 29 May 2014 10:41:13 PM EEST  Name: ClassicDescription.patch  Size:
558B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4739] Make civ2civ3 ruleset the default

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Make civ2civ3 ruleset the default
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 10:30:47 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

in freeciv-3.0




___

File Attachments:


---
Date: Thu 29 May 2014 10:30:47 PM EEST  Name: Civ2civ3Default.patch  Size:
843B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4738] Ruleset defined culture victory criteria

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Ruleset defined culture victory criteria
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 09:31:59 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Read culture victory criteria values from the ruleset.



___

File Attachments:


---
Date: Thu 29 May 2014 09:31:59 PM EEST  Name: RulesetCultureVic.patch  Size:
9kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4720] Random trait value

2014-05-29 Thread Marko Lindqvist 
Update of patch #4720 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4727] Rename 'player_research' to 'research'

2014-05-29 Thread pepeto 
Follow-up Comment #1, patch #4727 (project freeciv):

Patch updated against current trunk.

(file #20848)
___

Additional Item Attachment:

File name: rename_player_research2.patch.gz Size:12 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4707] Remove the 'goes_out_of_sight' field of the short_unit_info packet

2014-05-29 Thread pepeto 
Update of patch #4707 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22057] Diplomats cannot steal future technologies

2014-05-29 Thread pepeto 
Update of bug #22057 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4734] Support versioning of custom rulesets

2014-05-29 Thread Marko Lindqvist 
Update of patch #4734 (project freeciv):

  Status:  Ready For Test => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4737] Culture value to demograhics report

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Culture value to demograhics report
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 08:38:27 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add culture value to demographics report. Displayed by default as it's quite
crucial information when cultural victory is enabled (both knowing the
leader's score and ones own). OTOH most rulesets (at least currently) do not
have culture at all so having the report to always show 0 there is not ideal.



___

File Attachments:


---
Date: Thu 29 May 2014 08:38:27 PM EEST  Name: CultureDemographics.patch  Size:
3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4736] Culture victory

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Culture victory
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 08:12:32 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add cultural victory option. Currently hardcoded so that winner needs to have
more than three times as many culture points than the second best player, and
at least 1000 points (so that victory is not granted when first player gets
first culture points and others have 0).



___

File Attachments:


---
Date: Thu 29 May 2014 08:12:32 PM EEST  Name: CultureVictory.patch  Size: 3kB 
 By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4735] --with-modlist

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: --with-modlist
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 06:18:52 PM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add configure option "--with-modlist" to set default modpack list URL.

I need this, but I don't know if anybody else needs, so opinions about whether
its inclusion is acceptable or not welcome.

The use-case is making snapshot builds (crosser builds - see forum thread
http://forum.freeciv.org/f/viewtopic.php?f=9&t=9 ) and having separate modpack
list compatible with that particular build (freeciv revision).
The reason I'd rather have this as always available configure option and not
an local source modification is that I want to make builds from completely
unmodified sources. 1) more GPL compatible - build from locally modified
sources would require making those modified sources available. 2) Builds use
also --enable-svnrev to make exact freeciv revision number available
(important information when debugging problems users report). It doesn't
particularly like local modifications.



___

File Attachments:


---
Date: Thu 29 May 2014 06:18:52 PM EEST  Name: WithModlist.patch  Size: 1kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4733] Show ruleset name in "About Ruleset" help

2014-05-29 Thread Marko Lindqvist 
Update of patch #4733 (project freeciv):

 Planned Release:2.5.0, 2.6.0 => 2.4.3, 2.5.0, 2.6.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22089] Adjustable buy cost

2014-05-29 Thread Edgaras Šeputis 
Follow-up Comment #7, bug #22089 (project freeciv):

I agree with resolution issue.

Proposed patch is also very nice and intersting.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4734] Support versioning of custom rulesets

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Support versioning of custom rulesets
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 03:13:29 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add support for ruleset version information. Supplied rulesets are not setting
this as they are known to come from the same freeciv version as the binaries.
Version, if present, is displayed in "About Ruleset" help.



___

File Attachments:


---
Date: Thu 29 May 2014 03:13:29 PM EEST  Name: RulesetVersion.patch  Size: 8kB 
 By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4733] Show ruleset name in "About Ruleset" help

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Show ruleset name in "About Ruleset" help
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 02:19:15 PM EEST
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0, 2.6.0

___

Details:





___

File Attachments:


---
Date: Thu 29 May 2014 02:19:15 PM EEST  Name: RulesetNameHelp.patch  Size: 1kB
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4732] Display freeciv version in modpack installer

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #1, patch #4732 (project freeciv):

- Also in freeciv-mp-cli

(file #20839)
___

Additional Item Attachment:

File name: MpVersion-2.patch  Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4732] Display freeciv version in modpack installer

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Display freeciv version in modpack installer
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 01:30:29 PM EEST
Category: module installer
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0, 2.6.0

___

Details:

Show freeciv version number in freeciv-modpack.



___

File Attachments:


---
Date: Thu 29 May 2014 01:30:29 PM EEST  Name: MpVersion.patch  Size: 4kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4715] Print modpack notes on cli installer modpack list

2014-05-29 Thread Marko Lindqvist 
Update of patch #4715 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7670] S2_5 network protocol freeze

2014-05-29 Thread Marko Lindqvist 
Follow-up Comment #7, task #7670 (project freeciv):

> Thus I now propose 01-Jun as formal freeze date.

Reminder.


Nobody has objected so far, so I'm proceeding with the assumption that the
date holds.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22094] Multiplayer ruleset 'Cheating' AI doesn't have Max_Rates override

2014-05-29 Thread Marko Lindqvist 
Update of bug #22094 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #2:

Attached patch add Max_Rates effect for Cheating AI in multiplayer ruleset.
This can go in (esp. in S2_5) while I'm still a bit undecided which (branch
and ruleset -wise) copies of ai_effects.ruleset should be removed.

(file #20837)
___

Additional Item Attachment:

File name: MpCheatMaxRates.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22099] Re-enable tech loss in experimental ruleset (set 'techlossforgiveness' by default)

2014-05-29 Thread Jacob Nevins 
Update of bug #22099 (project freeciv):

 Assigned to: jtn => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22099] Re-enable tech loss in experimental ruleset (set 'techlossforgiveness' by default)

2014-05-29 Thread Marko Lindqvist 
Update of bug #22099 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

Attached patch sets techlossforgiveness to 15% in experimental ruleset.

(file #20836)
___

Additional Item Attachment:

File name: ExpTechlossForgiveness.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22078] Find City dialog opens non-expanded

2014-05-29 Thread Marko Lindqvist 
Update of bug #22078 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22106] Netfile dummy_write() return value assumes size unit to by single byte

2014-05-29 Thread Marko Lindqvist 
URL:
  

 Summary: Netfile dummy_write() return value assumes size unit
to by single byte
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 May 2014 11:46:50 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.3, 2.5.0, 2.6.0

___

Details:

dummy_write() returns number of elements received. As it should return number
of bytes handled, this works only as long as element size is one byte,

Fix attached.



___

File Attachments:


---
Date: Thu 29 May 2014 11:46:50 AM EEST  Name: DummySize.patch  Size: 508B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev