[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-09-18 Thread Marko Lindqvist
Update of bug #14037 (project freeciv): Status:None => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-09-16 Thread Marko Lindqvist
Follow-up Comment #13, bug #14037 (project freeciv): > Not teleporting units from transferred city to far away cities > but next to transferred city causes them to be inside borders of > new owner. What problems this will cause? It's already possible that units from other (home)cities are next t

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-09-16 Thread Marko Lindqvist
Follow-up Comment #12, bug #14037 (project freeciv): Having an argument with myself... > transfer_unit() should: > - If unit can still exist in the tile, or is in transport, it is > not moved We are talking about unit transfers as part of city transfer. City will remain, but under new owner. c

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-09-05 Thread Matthias Pfafferodt
Follow-up Comment #11, bug #14037 (project freeciv): updated patch; changes: * readd check for nearest city in disband_city() * remove city _after_ message to the player is send (city_name() is used) (file #6576) ___ Additional Item Atta

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-18 Thread Matthias Pfafferodt
Follow-up Comment #10, bug #14037 (project freeciv): I updated some low level functions for this patch. Please apply the following two patches: https://gna.org/patch/index.php?1253 https://gna.org/patch/index.php?1254 > transfer_unit() should: > - If unit can still exist in the tile, or is in

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-17 Thread Marko Lindqvist
Update of bug #14037 (project freeciv): Planned Release:None => 2.2.0 ___ Follow-up Comment #9: transfer_unit() should: - If unit can still exist in the tile, or is in transport, it is not mo

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-11 Thread Matthias Pfafferodt
Follow-up Comment #8, bug #14037 (project freeciv): > I decided to change it to a homeless unit. If no possible > homecity can be found, the current homecity is the last city > of this player ... This is perhaps not so good. It could be used to create homeless units if there are two players who

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-06 Thread Matthias Pfafferodt
Follow-up Comment #7, bug #14037 (project freeciv): rework changing of homecity / rehome of units and cities * rename transfer_unit() to rehome_unit() * merge transfer_city() and transfer_city_units() * no more teleport of units! some definitions for different functions: unit_change_homecity_h

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-06 Thread pepeto
Follow-up Comment #6, bug #14037 (project freeciv): There are 2 functions to don't confuse: transfer_unit() and unit_change_homecity_hanling(). In unit_change_homecity_hanling(), only a homecity change would be performed. So only the moving code would be removed. The other stuff is a part of t

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-06 Thread Matthias Pfafferodt
Follow-up Comment #5, bug #14037 (project freeciv): so the rehoming of units would look like the following (return code says if the unit survives): foreach unit of the city { if the city is disbanded (case 3. and 4.) { if unit can not survive at the old city tile { check in dist 1 fo

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-06 Thread pepeto
Follow-up Comment #4, bug #14037 (project freeciv): Actually, what I think is that units would change homecity not to the nearest city, but at the nearest city every of this units can be rehomed (then if the nearest city is inland, boats will be attached to the next coastal city). If a unit cann

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-06 Thread Matthias Pfafferodt
Follow-up Comment #3, bug #14037 (project freeciv): Thanks for action 6! Do you know other possible action, where units are rehomed / teleported? > However, for the the buf #14017, it would be very > strange a boot could be supported by an inland city. This is the reason for the allert in gna #

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-06 Thread pepeto
Follow-up Comment #2, bug #14037 (project freeciv): 6. city is taken by combat. => there is no more units in the city tile. => supported units change homecity to the nearest city (but are not teleported to there). However, for the the buf #14017, it would be very strange a boot could be supporte

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-06 Thread Matthias Pfafferodt
Follow-up Comment #1, bug #14037 (project freeciv): So this is not the wanted behaviour? I thought it strange, that the boot in gna #14017 was teleported to an (inland) city. What would be possible action which result in a change of the homecity of a unit? 1. unit is in a city and it should be

[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units

2009-08-06 Thread pepeto
URL: Summary: unit_change_homecity_handling() teleports units Project: Freeciv Submitted by: pepeto Submitted on: Thursday 07/30/2009 at 13:08 Category: general Severity: 3 - N