Re: [Freeciv-Dev] (PR#39898) Buffer overflow during autosave

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39898 > Thank you, loganjerry! I wish that we had more such detailed reports. Sounds like FORTIFY is a very useful feature! The next line after the memcpy needs room for the terminating '\0'. So, now I've made the array +3, instead of +1 or +2. A

[Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39895 > OK, great. Because the issue (borders appearing under foreign cities) was originally reported against 2.1, I made some extra effort to design for both 2.1 and 2.2. But there's more freedom with 2.2-only. The borders do expand gradually (

Re: [Freeciv-Dev] (PR#39888) Suggested expanded text for australian "legend"

2007-11-24 Thread Karl Goetz
http://bugs.freeciv.org/Ticket/Display.html?id=39888 > > http://bugs.freeciv.org/Ticket/Display.html?id=39888 > > > > On Nov 23, 2007 7:07 PM, Karl Goetz > <[EMAIL PROTECTED]> wrote: > > > http://bugs.freeciv.org/Ticket/Display.html?id=39888 > > > > hi, > > the current text is this: > > "Austra

Re: [Freeciv-Dev] (PR#39887) Australian housing style should be EU

2007-11-24 Thread Karl Goetz
http://bugs.freeciv.org/Ticket/Display.html?id=39887 > > http://bugs.freeciv.org/Ticket/Display.html?id=39887 > > > > On Nov 23, 2007 6:57 PM, Karl Goetz > <[EMAIL PROTECTED]> wrote: > > > http://bugs.freeciv.org/Ticket/Display.html?id=39887 > > > > hi, > > IMO the Australian's housing style sh

Re: [Freeciv-Dev] (PR#39891) [wishlist] research something by default

2007-11-24 Thread Karl Goetz
http://bugs.freeciv.org/Ticket/Display.html?id=39891 > > http://bugs.freeciv.org/Ticket/Display.html?id=39891 > > > > On Nov 23, 2007 7:29 PM, Karl Goetz > <[EMAIL PROTECTED]> wrote: > > > http://bugs.freeciv.org/Ticket/Display.html?id=39891 > > > > hi, > > on a new game of freeciv the game sit

Re: [Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-24 Thread Per I. Mathisen
http://bugs.freeciv.org/Ticket/Display.html?id=39895 > What is VISION_SITE_RUIN? - Per ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39900) Misnamed button in city report

2007-11-24 Thread Christian Knoke
http://bugs.freeciv.org/Ticket/Display.html?id=39900 > 2.1 SVN Nowadays, there is a button called "Update" in the city report, that opens the city window. It should be called "City Window" or the like. Christian -- Christian Knoke* * *http://cknoke.de * * * * * * * *

[Freeciv-Dev] (PR#39880) Right click GUI and Lepoard

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39880 > > [EMAIL PROTECTED] - Thu Nov 22 12:32:32 2007]: > > On Nov 22, 2007 12:54 PM, Daniel Markstedt <[EMAIL PROTECTED]> wrote: > > > I have been running the game in OS X and on BootCamp Windows XP. In > > > Leopard it first has to run X11 (whi

[Freeciv-Dev] (PR#39883) Gtk2 client tends to flake out after a while

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39883 > > [EMAIL PROTECTED] - Thu Nov 22 18:54:08 Playing a full game through with a memory leak program enabled (valgrind works here but is too slow for a full game) would be very revealing I think. > There is a fair amount of error reportage o

[Freeciv-Dev] (PR#39897) Suggestion: geographic location of cities

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39897 > > [guest - Fri Nov 23 18:43:31 2007]: > > Right now the city naming depends on the city placement, e.g. are there > rivers or mountains or cost fields nearby. > I have a new idea. How about attaching to each possible city name two > numbers

Re: [Freeciv-Dev] (PR#9722) fix charset problems in 1.14

2007-11-24 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=9722 > Some people still use 1.14 and I wouldn't rule out accepting simple bugfixes for it (or 2.0 of course). Anything complicated should be marked fixed-in-current-version or, if it's specifically tied to that branch (as in "1.14 has charset probl

[Freeciv-Dev] (PR#39885) Picks same nation twice from civil war list from same host nation

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39885 > It doesn't look the same as 17436. >From split_player() player_set_nation(cplayer, pick_a_nation(civilwar_nations, TRUE, FALSE, NOT_A_BARBARIAN)); The FALSE indicates that the is_available flag

[Freeciv-Dev] (PR#39837) Happiness in big empires

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39837 > > [guest - Mon Nov 05 15:18:53 2007]: > > Hi Freeciv Team > > I'm just wondering if it is a feature or really a bug. Plying freeciv > 2.1 for some days and found a difference in the happiness to the > previous encountered game behavior. > R

Re: [Freeciv-Dev] (PR#39887) Australian housing style should be EU

2007-11-24 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39887 > When the new city styles were created they weren't rigorously applied to every nation. If european style is more appropriate for australian nation then that should be fixed. -jason ___ Freeciv-

[Freeciv-Dev] (PR#39903) Bug with 'new citizen'

2007-11-24 Thread galen ostrag
http://bugs.freeciv.org/Ticket/Display.html?id=39903 > Hello, I think I have a little bug with the freeciv ver 2.1.0. When I put new citizen is 'artist' with the mark in a city, it don't work it's randomly scientists or $. And I have a question, I didn't find were we can see the traderoute(s)

[Freeciv-Dev] (PR#39901) Patch: Fix permission on open() call

2007-11-24 Thread
http://bugs.freeciv.org/Ticket/Display.html?id=39901 > open() with O_CREAT in its second argument needs to have a third argument Thanks, Brian Pepple Index: client/connectdlg_common.c === --- client/connectdlg_common.c (revision 14

[Freeciv-Dev] (PR#39902) Patch: Fix open() call permission

2007-11-24 Thread Brian Pepple
http://bugs.freeciv.org/Ticket/Display.html?id=39902 > This transaction appears to have no content open() with O_CREAT in its second argument needs to have a third argument specifying the mode. Please find the attached patch to correct this. Later, /B -- Brian Pepple <[EMAIL PROTECTED]> http:

Re: [Freeciv-Dev] (PR#39900) _Update button in city report

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39900 > Just renamed from "Popup" (PR#23078). Nobody complained (or otherwise commented) during the standard review period There's another similar button elsewhere named "Update City". Would that be better here? Probably the original authors

Re: [Freeciv-Dev] (PR#39901) Patch: Fix permission on open() call

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39901 > > open() with O_CREAT in its second argument needs to have a third argument > That's not accurate. Only when you wish to restrict the file mode mask. Without looking hard at this code, I don't see any reason we'd want to restrict the mask.

Re: [Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39895 > Per I. Mathisen wrote: > What is VISION_SITE_RUIN? > The value I reserved (several patches ago) for the civ3-like ruin left behind after a city is destroyed. It will be displayed per player, just like other non-owned cities. Whether you no

Re: [Freeciv-Dev] (PR#39883) Gtk2 client tends to flake out after a while

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39883 > Sadly, there are quite a few memory leaks in 2.1. I'd fixed one in the goto code just the other week. But I've fixed at least a dozen only in 2.2/trunk. Fixing the iterators and such was deemed too disruptive for 2.1. __

Re: [Freeciv-Dev] (PR#39887) Australian housing style should be EU

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39887 > Daniel is our de facto nation coordinator, and we await his decision. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39897) Suggestion: geographic location of cities

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39897 > When I submitted my Balkan city lists, I included lat/long and the time of founding in the comments. Someday, we could automatically sort the lists. ___ Freeciv-dev mailing list Freeciv-dev@gna.

[Freeciv-Dev] (PR#39611) BETA6 cannot find libggz

2007-11-24 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39611 > > [guest - Thu Nov 22 11:41:30 2007]: > > It's not as complicated as it seems to be :) > > Basically, AC_GGZ_CHECK is just a wrapper macro for all the other GGZ > macros. The individual macros work fine, but AC_GGZ_CHECK called > AC_GGZ_INI

[Freeciv-Dev] (PR#39611) BETA6 cannot find libggz

2007-11-24 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39611 > > [dmarks - Sun Nov 25 01:37:39 2007]: > > > [guest - Thu Nov 22 11:41:30 2007]: > > > > It's not as complicated as it seems to be :) > > > > Basically, AC_GGZ_CHECK is just a wrapper macro for all the other GGZ > > macros. The individual

Re: [Freeciv-Dev] (PR#39866) Tracking 2.1.1 release

2007-11-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39866 > Thought I'd report that the x11 client still compiles and runs. Unfortunately, I don't seem to remember how to get it running a game How are the other clients? ___ Freeciv-dev mailing list F

Re: [Freeciv-Dev] (PR#39866) Tracking 2.1.1 release

2007-11-24 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39866 > On 11/25/07, William Allen Simpson <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39866 > > > Thought I'd report that the x11 client still compiles and runs. > Unfortunately, I don't seem to remember how to get

Re: [Freeciv-Dev] (PR#39887) Australian housing style should be EU

2007-11-24 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39887 > On Nov 25, 2007 9:58 AM, William Allen Simpson <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39887 > > > Daniel is our de facto nation coordinator, and we await his decision. > > I'm actually the de jure natio

Re: [Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-24 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39895 > On 11/25/07, William Allen Simpson <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39895 > > > Per I. Mathisen wrote: > > What is VISION_SITE_RUIN? > > > The value I reserved (several patches ago) for the civ3-li

[Freeciv-Dev] (PR#39900) _Update button in city report

2007-11-24 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39900 > > [wsimpson - Sun Nov 25 00:20:20 2007]: > > Just renamed from "Popup" (PR#23078). Nobody complained (or otherwise > commented) during the standard review period There's another similar > button elsewhere named "Update City". Would th

Re: [Freeciv-Dev] (PR#39897) Suggestion: geographic location of cities

2007-11-24 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39897 > William Allen Simpson wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=39897 > > > When I submitted my Balkan city lists, I included lat/long and the time of > founding in the comments. Someday, we could automatically sort the lists.