Re: [Freeciv-Dev] (PR#39831) Training and combat help data

2007-12-31 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > Had to split the long lines, and remove references that aren't true in all rulesets, and use the correct local sz_strlcat(). I see the the entire rest of the file needs to be updated, too Committed trunk revision 14215. Committed S2_2 r

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-12-31 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > Joan Creus wrote: > I created this patch for the trunk last month. I have created now > another patch for the 2.1 branch. Since the string freeze seems to be > lifted, do you think that we could apply them? > > I am asking you because you

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-11 Thread Joan Creus
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > This transaction appears to have no content Good. "Promoted" sounds perfect in this context. Joan 2007/11/11, William Allen Simpson <[EMAIL PROTECTED]>: > > > http://bugs.freeciv.org/Ticket/Display.html?id=39831 > > > Joan Creus wrote: > >

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-10 Thread Randy Kramer
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > On Saturday 10 November 2007 10:26 am, Joan Creus wrote: > Sorry about the delay. I think you nailed it right here. I have adapted the > messages to include Eddie's and Randy's suggestions, and have added a > reference to the Lighthouse. Joa

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-10 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > Joan Creus wrote: > For land units, except Diplomats and Spies: > * Will be built as a veteran in cities with appropriate training facilities > (see Barracks and Sun Tzu.) May also become veteran if it defeats an enemy > unit. > In this mess

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-10 Thread Joan Creus
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > This transaction appears to have no content 2007/11/5, Eddie Anderson <[EMAIL PROTECTED]>: > > > > Instead of "certain cities", how about > > > > 1) "cities with appropriate training facilities", Sorry about the delay. I think you nail

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-04 Thread Eddie Anderson
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > "Joan Creus" <[EMAIL PROTECTED]> wrote: > >http://bugs.freeciv.org/Ticket/Display.html?id=39831 > > >I think you mean EFT_VETERAN_BUILD. That sounds right. >I would try to make it shorter, though. >I think your suggestion is g

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-04 Thread Joan Creus
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > I think you mean EFT_VETERAN_BUILD. I would try to make it shorter, though. I think your suggestion is great for the general manual, but here we are dealing with the individual unit help. The original sentence ("may become veteran throught tr

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-04 Thread Eddie Anderson
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > "Joan Creus" <[EMAIL PROTECTED]> wrote: > >http://bugs.freeciv.org/Ticket/Display.html?id=39831 > > >Good suggestion. I like it. Just one point: shouldn't it be "with Barracks" >instead of "with a Barracks"? I'm not a native English speaker,

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-03 Thread Joan Creus
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > Good suggestion. I like it. Just one point: shouldn't it be "with Barracks" instead of "with a Barracks"? I'm not a native English speaker, but it doesn't feel right. Can anybody improve on Randy's suggestion? Joan 2007/11/

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-02 Thread Randy Kramer
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > Joan, I'm not a developer, really just a lurker, well, and a tweaker--on looking at the messages you changed (thanks, btw), I wondered if they could be improved any further--see below. Maybe you can take them even further. regards, Rand