[Freeipa-devel] DNS Locations: fix an issue found by coverity

2016-06-27 Thread Martin Basti
Shame, shame, shame on me. I forgot how to python when I was writing that originally. Patch attached. https://fedorahosted.org/freeipa/ticket/2008 From fc0ba11ce71c5585874745764dbdcda4fa615e8c Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Mon, 27 Jun 2016 08

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

2016-06-24 Thread Martin Basti
On 24.06.2016 15:09, Martin Basti wrote: On 24.06.2016 14:59, Sumit Bose wrote: On Fri, Jun 24, 2016 at 02:00:24PM +0200, Martin Basti wrote: On 22.06.2016 23:20, Lukas Slebodnik wrote: On (22/06/16 11:57), Martin Basti wrote: On 09.06.2016 21:02, Martin Basti wrote: On 09.06.2016 14

Re: [Freeipa-devel] [PATCH] 959 mod_auth_gssapi: enable unique credential caches names

2016-06-24 Thread Martin Basti
On 24.06.2016 16:13, Martin Basti wrote: On 24.06.2016 16:03, Stanislav Laznicka wrote: On 06/24/2016 03:11 PM, Martin Basti wrote: On 23.06.2016 17:46, Robbie Harwood wrote: Petr Vobornik<pvobo...@redhat.com> writes: mod_auth_gssapi > 1.4.0 implements support for unique ccac

Re: [Freeipa-devel] [PATCH] 959 mod_auth_gssapi: enable unique credential caches names

2016-06-24 Thread Martin Basti
On 24.06.2016 16:03, Stanislav Laznicka wrote: On 06/24/2016 03:11 PM, Martin Basti wrote: On 23.06.2016 17:46, Robbie Harwood wrote: Petr Vobornik<pvobo...@redhat.com> writes: mod_auth_gssapi > 1.4.0 implements support for unique ccaches names. Excited to see this appear!

Re: [Freeipa-devel] [PATCH 0096] Add authentication indicators support to Host objects

2016-06-24 Thread Martin Basti
On 24.06.2016 15:11, Sumit Bose wrote: On Tue, Jun 21, 2016 at 02:25:49PM -0400, Nathaniel McCallum wrote: https://fedorahosted.org/freeipa/ticket/433 The patch works for me as expected, but the API.txt update is missing in the patch. bye, Sumit There are no updated managed permissions

Re: [Freeipa-devel] [PATCH] 959 mod_auth_gssapi: enable unique credential caches names

2016-06-24 Thread Martin Basti
On 23.06.2016 17:46, Robbie Harwood wrote: Petr Vobornik writes: mod_auth_gssapi > 1.4.0 implements support for unique ccaches names. Excited to see this appear! Sessions are not in use so there's no need to worry about a sweeper. This looks correct to me. Thanks

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

2016-06-24 Thread Martin Basti
On 24.06.2016 14:59, Sumit Bose wrote: On Fri, Jun 24, 2016 at 02:00:24PM +0200, Martin Basti wrote: On 22.06.2016 23:20, Lukas Slebodnik wrote: On (22/06/16 11:57), Martin Basti wrote: On 09.06.2016 21:02, Martin Basti wrote: On 09.06.2016 14:45, Martin Basti wrote: On 09.06.2016 14:42

Re: [Freeipa-devel] [PATCH] 0020 Enable password change extop to apply on virtual entry like the entry in compat tree

2016-06-24 Thread Martin Basti
On 22.06.2016 19:02, Alexander Bokovoy wrote: On Wed, 22 Jun 2016, thierry bordaz wrote: I think FreeIPA also needs to raise dependency to slapi-nis >= 0.56.0 for this. Testing with slapi-nis 0.56.0-2, successful update of password from compat tree users. Great, ACK! Pushed to master:

Re: [Freeipa-devel] [PATCH 0021][Tests] Fix failing ipatests/test_ipaserver/test_rpcserver.py

2016-06-24 Thread Martin Basti
On 24.06.2016 14:11, Oleg Fayans wrote: ACK On 06/24/2016 10:29 AM, Lenka Doudova wrote: Hi, attaching patch for one of the failing tests. Failure caused by an assertion that was no longer valid. Lenka Pushed to master: d64513f1ff89f49d216d229cd4f988a485f0acc4 -- Manage your

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

2016-06-24 Thread Martin Basti
On 22.06.2016 23:20, Lukas Slebodnik wrote: On (22/06/16 11:57), Martin Basti wrote: On 09.06.2016 21:02, Martin Basti wrote: On 09.06.2016 14:45, Martin Basti wrote: On 09.06.2016 14:42, Martin Basti wrote: On 09.06.2016 14:38, Lukas Slebodnik wrote: On (09/06/16 14:29), Martin Basti

Re: [Freeipa-devel] [PATCH] 498 Update Contributors.txt

2016-06-24 Thread Martin Basti
On 24.06.2016 08:24, Martin Kosek wrote: On 06/23/2016 07:39 PM, Lukas Slebodnik wrote: On (23/06/16 15:22), Martin Kosek wrote: Update .mailmap to fix wrong commit author and re-generate the Developer contributor list. -- Martin Kosek Manager, Software Engineering -

Re: [Freeipa-devel] [PATCH 0538-0540] DNS locations: epilogue

2016-06-24 Thread Martin Basti
On 23.06.2016 18:26, Petr Spacek wrote: On 23.6.2016 16:38, Martin Basti wrote: Patches attached. https://fedorahosted.org/freeipa/ticket/2008 freeipa-mbasti-0538-Revert-DNS-Locations-do-not-generate-location-record.patch From 28499422115cbfbb343033511319c7c8710e1ff5 Mon Sep 17 00:00

[Freeipa-devel] [PATCH 0542] ipa-getkeytab: increase LDAP timeout

2016-06-23 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5842 Patch attached. From d4092afc1dec882d6d49ae821a4da97f3fa8921e Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Thu, 23 Jun 2016 16:49:32 +0200 Subject: [PATCH] Increase ipa-getkeytab LDAP timeout to 100sec On slower ma

Re: [Freeipa-devel] [PATCH] 0061: webui: Add support for 'dns_update_system_records' command

2016-06-23 Thread Martin Basti
On 23.06.2016 09:57, Pavel Vomacka wrote: Hello, please review attached patch. Part of: https://fedorahosted.org/freeipa/ticket/5905 Works for me -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-23 Thread Martin Basti
On 23.06.2016 12:55, Lenka Doudova wrote: On 06/23/2016 10:30 AM, Martin Basti wrote: On 23.06.2016 06:55, Lenka Doudova wrote: On 06/22/2016 05:11 PM, Lenka Doudova wrote: On 06/22/2016 04:37 PM, Lenka Doudova wrote: On 06/22/2016 08:33 AM, Martin Basti wrote

[Freeipa-devel] [PATCH 0537] CA replica promotion: add proper CA DNS records

2016-06-23 Thread Martin Basti
patch attached. https://fedorahosted.org/freeipa/ticket/5966 From 78be21f8eedd2de79bddf6653363e2466485a19f Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 22 Jun 2016 12:20:09 +0200 Subject: [PATCH] CA replica promotion: add proper CA DNS records Update '

Re: [Freeipa-devel] [PATCH 0533] Server-del: fix system records removal

2016-06-23 Thread Martin Basti
On 23.06.2016 12:33, Petr Spacek wrote: On 20.6.2016 19:34, Martin Basti wrote: Patch attached. Services must be removed before records are updated ACK Pushed to master: 926462d335ea49857732f1cf2fd2a1956c5b57d8 -- Manage your subscription for the Freeipa-devel mailing list: https

Re: [Freeipa-devel] [PATCH 0049] Fix host principal password required in ipa-ca-install

2016-06-23 Thread Martin Basti
On 23.06.2016 08:52, Stanislav Laznicka wrote: On 06/23/2016 08:09 AM, Jan Cholasta wrote: On 22.6.2016 16:22, Stanislav Laznicka wrote: Hello, Please see the patch attached that fixes the issue from https://fedorahosted.org/freeipa/ticket/5965. The patch took me quite a while to create as

Re: [Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-23 Thread Martin Basti
On 23.06.2016 06:55, Lenka Doudova wrote: On 06/22/2016 05:11 PM, Lenka Doudova wrote: On 06/22/2016 04:37 PM, Lenka Doudova wrote: On 06/22/2016 08:33 AM, Martin Basti wrote: On 22.06.2016 07:37, Lenka Doudova wrote: On 06/21/2016 06:57 PM, Martin Basti wrote

Re: [Freeipa-devel] [PATCHES 0069-0077] support for proper Kerberos principal canonicalization

2016-06-23 Thread Martin Basti
On 23.06.2016 09:44, David Kupka wrote: On 22/06/16 18:56, Simo Sorce wrote: On Wed, 2016-06-22 at 18:36 +0200, Martin Babinsky wrote: On 06/22/2016 06:26 PM, Simo Sorce wrote: On Wed, 2016-06-22 at 09:46 +0200, Martin Babinsky wrote: On 10/05/2015 03:00 PM, Martin Babinsky wrote: These

Re: [Freeipa-devel] [PATCH] 0022 Topology plugins sigsev/heap corruption when adding a managed host

2016-06-22 Thread Martin Basti
On 22.06.2016 17:39, Ludwig Krispenz wrote: ACK. good catch, the fix is correct and hopefully fixes the heap corruption issues On 06/22/2016 05:30 PM, thierry bordaz wrote: https://fedorahosted.org/freeipa/ticket/5977 -- Red Hat GmbH,http://www.de.redhat.com/, Registered seat:

Re: [Freeipa-devel] [PATCH 0046] Don't fail in find/show methods if userCertificate is invalid

2016-06-22 Thread Martin Basti
On 10.06.2016 13:25, Stanislav Laznicka wrote: On 06/09/2016 04:32 PM, Rob Crittenden wrote: Fraser Tweedale wrote: On Thu, Jun 09, 2016 at 03:07:34PM +0200, Martin Basti wrote: On 09.06.2016 15:03, Martin Basti wrote: On 09.06.2016 15:02, Stanislav Laznicka wrote: On 06/09/2016 02:51 PM

Re: [Freeipa-devel] [PATCH 0163] server-del: handle missing server attributes when checking for last of role

2016-06-22 Thread Martin Basti
On 22.06.2016 15:47, Martin Babinsky wrote: On 06/22/2016 03:29 PM, Martin Babinsky wrote: On 06/22/2016 03:13 PM, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5960 self-NACK, this check needs some more hardening. This patch should fix the issue in more thorough

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

2016-06-22 Thread Martin Basti
On 09.06.2016 21:02, Martin Basti wrote: On 09.06.2016 14:45, Martin Basti wrote: On 09.06.2016 14:42, Martin Basti wrote: On 09.06.2016 14:38, Lukas Slebodnik wrote: On (09/06/16 14:29), Martin Basti wrote: On 09.06.2016 14:22, Alexander Bokovoy wrote: On Thu, 09 Jun 2016, Jakub

Re: [Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-22 Thread Martin Basti
On 22.06.2016 07:37, Lenka Doudova wrote: On 06/21/2016 06:57 PM, Martin Basti wrote: On 21.06.2016 15:39, Lenka Doudova wrote: Hi, attaching patch for failing location tests (ipatests/test_xmlrpc/test_location_plugin.py). Lenka Hello, 1) +expected_updates

Re: [Freeipa-devel] [Test][Patch-0043-0045] DNSSec key rotation test

2016-06-21 Thread Martin Basti
On 13.06.2016 14:42, Oleg Fayans wrote: Hi guys, Here is a test for dnssec key rotation mechanism. The full set of commands works perfectly when run manually (even in the mode of a full copy-pasting from the test). However, when run automatically, the test always fails as `dig +rrcomments

Re: [Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-21 Thread Martin Basti
On 21.06.2016 15:39, Lenka Doudova wrote: Hi, attaching patch for failing location tests (ipatests/test_xmlrpc/test_location_plugin.py). Lenka Hello, 1) +expected_updates={u'ipalocation_location': [location.idnsname_obj], +

Re: [Freeipa-devel] [PATCH 0535] Replica promotion: check if IPA domain is the right one

2016-06-21 Thread Martin Basti
On 21.06.2016 17:08, Petr Spacek wrote: On 21.6.2016 16:27, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5976 Client must have properly set domain to allow install replica Patch attached. ACK The CRITICAL message is awesome :-) master

Re: [Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}

2016-06-21 Thread Martin Basti
On 21.06.2016 16:44, Petr Vobornik wrote: On 06/16/2016 01:38 PM, Petr Spacek wrote: On 16.6.2016 12:09, Pavel Vomacka wrote: On 06/16/2016 12:06 PM, Pavel Vomacka wrote: Hello, please review attached patch. https://fedorahosted.org/freeipa/ticket/5905 Fixed commit message LGTM from

Re: [Freeipa-devel] [PATCH] Schema caching for thin client

2016-06-21 Thread Martin Basti
On 21.06.2016 16:51, Jan Cholasta wrote: On 21.6.2016 16:33, Martin Basti wrote: On 21.06.2016 16:24, Jan Cholasta wrote: On 21.6.2016 15:11, Jan Cholasta wrote: On 16.6.2016 09:12, David Kupka wrote: On 06/15/2016 08:15 PM, Petr Vobornik wrote: On 06/15/2016 02:36 PM, David Kupka wrote

Re: [Freeipa-devel] [PATCH 0043] Stop uninstaller from failing if a service can't be started

2016-06-21 Thread Martin Basti
On 14.06.2016 17:26, Stanislav Laznicka wrote: -signerd_service.start() +try: +signerd_service.start() +except Exception as e: +root_logger.error("Unable to start '{svcname}': {err}" +

Re: [Freeipa-devel] [PATCH] 497 Update Developers in Contributors.txt

2016-06-21 Thread Martin Basti
On 16.06.2016 15:55, Martin Kosek wrote: Since we are close to 4.4 release, let's add the latest contributors. (master branch should be enough). ACK Pushed to master: 858b74e66b529f4b7ff1c791e6101445b1d18174 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH] Schema caching for thin client

2016-06-21 Thread Martin Basti
On 21.06.2016 16:24, Jan Cholasta wrote: On 21.6.2016 15:11, Jan Cholasta wrote: On 16.6.2016 09:12, David Kupka wrote: On 06/15/2016 08:15 PM, Petr Vobornik wrote: On 06/15/2016 02:36 PM, David Kupka wrote: Hello! Schema caching for thin client is available here:

[Freeipa-devel] [PATCH 0535] Replica promotion: check if IPA domain is the right one

2016-06-21 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5976 Client must have properly set domain to allow install replica Patch attached. From c26362fcdd1e35ed736aeb1ed3d3ac2f6b336c87 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Tue, 21 Jun 2016 12:37:26 +0200 Subject:

Re: [Freeipa-devel] [PATCH] 0060: webui: Add dnsdefaultttl field on DNS Zone config page

2016-06-21 Thread Martin Basti
On 21.06.2016 15:56, Petr Spacek wrote: On 21.6.2016 15:50, Pavel Vomacka wrote: Hello, please review the attached patch. It is counterpart of: https://fedorahosted.org/freeipa/ticket/2956 ACK Pushed to master: 75d2f9fe06f9f7c8d9f1b882b631fed739d35c75 -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH] pylint fixes

2016-06-21 Thread Martin Basti
On 21.06.2016 08:38, Florence Blanc-Renaud wrote: On 06/20/2016 07:08 PM, Martin Basti wrote: On 20.06.2016 19:06, Martin Basti wrote: On 20.06.2016 12:00, Florence Blanc-Renaud wrote: On 06/09/2016 05:10 PM, Petr Spacek wrote: Hello, I've received a bunch of pylint fixes produced

Re: [Freeipa-devel] [PATCH 0134] DNS: Fix realm domains integration with DNS zone add

2016-06-21 Thread Martin Basti
On 20.06.2016 19:03, Martin Basti wrote: On 20.06.2016 14:35, Petr Spacek wrote: Hello, DNS: Fix realm domains integration with DNS zone add. Realmdomains integration into DNS commands pre-dates split of DNS forward zones and DNS master zones into two distinct commands

Re: [Freeipa-devel] [PATCH] 0054-55: WebUI: extend DNS and trust config pages

2016-06-21 Thread Martin Basti
On 21.06.2016 13:12, Pavel Vomacka wrote: Hello, please review attached patches - they extend DNS and trust config pages. https://fedorahosted.org/freeipa/ticket/5906 -- Pavel^3 Vomacka ACK master: * a7f937e82cd8fdfa457ef9ae7de227d7e2502c3b Extend DNS config page *

Re: [Freeipa-devel] [PATCH] 0059: webui: make 'Actions' strings translatable

2016-06-21 Thread Martin Basti
On 21.06.2016 13:09, Petr Vobornik wrote: On 06/21/2016 12:34 PM, Martin Basti wrote: On 20.06.2016 20:48, Pavel Vomacka wrote: Hello, please review attached patch. -- Pavel^3 Vomacka Functional ACK Code ACK Pushed to master: 13e0d2e4d1c0da055644d87f1b8a9465b2ef6dfa -- Manage

Re: [Freeipa-devel] [PATCH 0162] Do not update result of *-config-show with empty server attributes

2016-06-21 Thread Martin Basti
On 21.06.2016 12:57, Pavel Vomacka wrote: On 06/20/2016 03:35 PM, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5960 Hello, thank you for the patch, it works for me. But I didn't do the code review. -- Pavel^3 Vomacka code ACK Pushed to master:

Re: [Freeipa-devel] [WIP] Thin client

2016-06-21 Thread Martin Basti
On 21.06.2016 07:53, Jan Cholasta wrote: On 20.6.2016 19:56, Martin Basti wrote: On 20.06.2016 18:48, Martin Basti wrote: On 20.06.2016 16:42, Jan Cholasta wrote: On 20.6.2016 16:13, David Kupka wrote: On 28/04/16 14:45, Jan Cholasta wrote: Hi, I have pushed my thin client WIP branch

Re: [Freeipa-devel] [PATCH 0534] Updated translations for future IPA 4.4

2016-06-21 Thread Martin Basti
On 21.06.2016 11:39, Martin Babinsky wrote: On 06/21/2016 10:48 AM, Martin Basti wrote: Exported from zanata. Patch attached. I found no problem when building from master branch with the updated translations. ACK. Pushed to master: 0787af8d5a1a75e25f73cc632c4c7ebdd212ad02 -- Manage

Re: [Freeipa-devel] [PATCH 0135-0136] DNS: Warn about restart when default TTL setting DNS is change DNS: Support default TTL setting for master DNS zone

2016-06-21 Thread Martin Basti
On 21.06.2016 11:55, Petr Spacek wrote: On 21.6.2016 10:00, Petr Spacek wrote: On 20.6.2016 19:15, Martin Basti wrote: On 20.06.2016 18:32, Petr Spacek wrote: On 20.6.2016 18:05, Martin Basti wrote: On 20.06.2016 16:57, Petr Spacek wrote: Hello, DNS: Warn about restart when default TTL

Re: [Freeipa-devel] [PATCH] 0059: webui: make 'Actions' strings translatable

2016-06-21 Thread Martin Basti
On 20.06.2016 20:48, Pavel Vomacka wrote: Hello, please review attached patch. -- Pavel^3 Vomacka Functional ACK -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 0532] Fix possibly undefined variable

2016-06-20 Thread Martin Basti
On 20.06.2016 20:31, Alexander Bokovoy wrote: On Mon, 20 Jun 2016, Martin Basti wrote: Patch attached. From a073b44587a5b34c4f1de5742d54e7c547cd5821 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Mon, 20 Jun 2016 12:48:38 +0200 Subject: [PATCH] Fix po

Re: [Freeipa-devel] [PATCH 0137] DNS Locations: make ipa-ca record generation more robus

2016-06-20 Thread Martin Basti
On 20.06.2016 18:28, Petr Spacek wrote: Hello, DNS Locations: make ipa-ca record generation more robust __add_ca_records_from_hostname() now skips over DNS exceptions and retries resolution until timeout of 120 seconds is reached. Luckily current logic fails safe: In cases where resolution

Re: [Freeipa-devel] [WIP] Thin client

2016-06-20 Thread Martin Basti
On 20.06.2016 18:48, Martin Basti wrote: On 20.06.2016 16:42, Jan Cholasta wrote: On 20.6.2016 16:13, David Kupka wrote: On 28/04/16 14:45, Jan Cholasta wrote: Hi, I have pushed my thin client WIP branch to GitHub: <https://github.com/jcholast/freeipa/tree/trac-4739>. All comm

Re: [Freeipa-devel] [Patch-0046] Increased certmonger timeout to address ticket N 5758

2016-06-20 Thread Martin Basti
On 16.06.2016 10:29, Oleg Fayans wrote: With this change the certmonger timeout issue is no longer observed in abcd lab. ACK Pushed to: master: 0ba9e72057bd372a7cf8ee51d1521ec5d11069d5 ipa-4-3: 084340b1c513c874e259378c0e24008c8f0237ed -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [PATCH 0533] Server-del: fix system records removal

2016-06-20 Thread Martin Basti
Patch attached. Services must be removed before records are updated From 7c0d3bd3ff3f507ddcd92d7b2f8e2363696c4dba Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Mon, 20 Jun 2016 19:27:55 +0200 Subject: [PATCH] Server-del: fix system records removal Services on r

Re: [Freeipa-devel] [PATCH 0135-0136] DNS: Warn about restart when default TTL setting DNS is change DNS: Support default TTL setting for master DNS zone

2016-06-20 Thread Martin Basti
On 20.06.2016 18:32, Petr Spacek wrote: On 20.6.2016 18:05, Martin Basti wrote: On 20.06.2016 16:57, Petr Spacek wrote: Hello, DNS: Warn about restart when default TTL setting DNS is changed bind-dyndb-ldap 10.0 has to be restarted after each change to default TTL. https

Re: [Freeipa-devel] [PATCH] 0019 - 2 ipapwd_extop should take precedence over default DS plugin

2016-06-20 Thread Martin Basti
On 16.06.2016 22:29, Alexander Bokovoy wrote: On Thu, 16 Jun 2016, thierry bordaz wrote: The version DS 1.3.5.6 is now available. Here is the second version of the patch taking into account lower precedence for Schema Compat On 06/13/2016 06:01 PM, Alexander Bokovoy wrote: On Mon, 13 Jun

Re: [Freeipa-devel] [PATCH] pylint fixes

2016-06-20 Thread Martin Basti
On 20.06.2016 19:06, Martin Basti wrote: On 20.06.2016 12:00, Florence Blanc-Renaud wrote: On 06/09/2016 05:10 PM, Petr Spacek wrote: Hello, I've received a bunch of pylint fixes produced by upstream contributor who is not subscribed to the list so I'm resending them here. All credit

Re: [Freeipa-devel] [PATCH] pylint fixes

2016-06-20 Thread Martin Basti
On 20.06.2016 12:00, Florence Blanc-Renaud wrote: On 06/09/2016 05:10 PM, Petr Spacek wrote: Hello, I've received a bunch of pylint fixes produced by upstream contributor who is not subscribed to the list so I'm resending them here. All credit goes to Bárta Jan<55042ba...@sstebrno.eu>.

Re: [Freeipa-devel] [PATCH 0134] DNS: Fix realm domains integration with DNS zone add

2016-06-20 Thread Martin Basti
On 20.06.2016 14:35, Petr Spacek wrote: Hello, DNS: Fix realm domains integration with DNS zone add. Realmdomains integration into DNS commands pre-dates split of DNS forward zones and DNS master zones into two distinct commands. There was an forgotten condition in dnszone_add command which

[Freeipa-devel] [PATCH 0532] Fix possibly undefined variable

2016-06-20 Thread Martin Basti
Patch attached. From a073b44587a5b34c4f1de5742d54e7c547cd5821 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Mon, 20 Jun 2016 12:48:38 +0200 Subject: [PATCH] Fix possibly undefined variable in ipa_smb_conf_exists() There was missing else statement what may

Re: [Freeipa-devel] [PATCH 0135-0136] DNS: Warn about restart when default TTL setting DNS is change DNS: Support default TTL setting for master DNS zone

2016-06-20 Thread Martin Basti
On 20.06.2016 16:57, Petr Spacek wrote: Hello, DNS: Warn about restart when default TTL setting DNS is changed bind-dyndb-ldap 10.0 has to be restarted after each change to default TTL. https://fedorahosted.org/freeipa/ticket/2956 DNS: Support default TTL setting for master DNS zones

Re: [Freeipa-devel] [PATCH 0531] Fix undefined variable in replica install

2016-06-20 Thread Martin Basti
On 20.06.2016 13:44, Martin Basti wrote: Patch attached. https://fedorahosted.org/freeipa/ticket/5975 Discard this, Honza set patch independently because it was related to thin client -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo

Re: [Freeipa-devel] [PATCH] Fix minor typos

2016-06-20 Thread Martin Basti
On 19.06.2016 10:08, Yuri Chornoivan wrote: Hi, Just a fix for two minor typos: recors -> records recieve -> receive Thanks for fixing these typos. Best regards, Yuri Thanks! ACK master: * a95e0777ac64cc8edad152f189be5347117785ef Fix minor typos -- Manage your subscription for the

[Freeipa-devel] [PATCH 0531] Fix undefined variable in replica install

2016-06-20 Thread Martin Basti
Patch attached. https://fedorahosted.org/freeipa/ticket/5975 From 0995aa1cabff511899d5de03972ed96818a1495f Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Mon, 20 Jun 2016 12:35:45 +0200 Subject: [PATCH] Fix: undefined 'ipaconf' in replica promotion ipaconf va

Re: [Freeipa-devel] [PATCH 0161] Fix listing of enabled roles in `server-find`

2016-06-17 Thread Martin Basti
On 17.06.2016 16:21, Martin Babinsky wrote: There is an issue with outputting enabled roles in server-find regarding our lovely `--raw`, `--all` and `--no-member` options. This quick patch fixes that. ACK Added ticket to commit message https://fedorahosted.org/freeipa/ticket/5181

Re: [Freeipa-devel] [PATCH 0153-0158] move ipa-replica-manage del functionality into server-del

2016-06-17 Thread Martin Basti
On 17.06.2016 16:18, Martin Babinsky wrote: On 06/17/2016 03:56 PM, Martin Babinsky wrote: On 06/16/2016 12:45 PM, Martin Basti wrote: On 15.06.2016 15:29, Martin Babinsky wrote: On 06/15/2016 10:30 AM, Jan Cholasta wrote: Hi, On 12.6.2016 17:31, Martin Babinsky wrote: On 06/09/2016 08

Re: [Freeipa-devel] [PATCH 0105] Remove unused locking "context manager"

2016-06-17 Thread Martin Basti
On 17.06.2016 16:31, David Kupka wrote: Just dropping tiny piece of no longer used code. ACK Pushed to master: 45bb2ad045654c020fe6ac4e77ed2741cd35d717 Only master, feel free to open tickets if backport is needed -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0503-0513, 0515-0519, 0520-0528] DNS locations

2016-06-17 Thread Martin Basti
On 17.06.2016 18:00, Petr Spacek wrote: On 17.6.2016 17:05, Martin Basti wrote: On 17.06.2016 15:17, Petr Spacek wrote: On 17.6.2016 12:25, Martin Basti wrote: On 17.06.2016 08:46, Petr Spacek wrote: On 16.6.2016 22:14, Martin Basti wrote: On 16.06.2016 15:59, Petr Spacek wrote

Re: [Freeipa-devel] [PATCH 0503-0513, 0515-0519, 0520-0528] DNS locations

2016-06-17 Thread Martin Basti
On 17.06.2016 15:17, Petr Spacek wrote: On 17.6.2016 12:25, Martin Basti wrote: On 17.06.2016 08:46, Petr Spacek wrote: On 16.6.2016 22:14, Martin Basti wrote: On 16.06.2016 15:59, Petr Spacek wrote: On 16.6.2016 13:57, Martin Basti wrote: On 16.06.2016 12:09, Petr Spacek wrote

Re: [Freeipa-devel] [PATCH 0503-0513, 0515-0519, 0520-0528] DNS locations

2016-06-17 Thread Martin Basti
On 17.06.2016 15:17, Petr Spacek wrote: On 17.6.2016 12:25, Martin Basti wrote: On 17.06.2016 08:46, Petr Spacek wrote: On 16.6.2016 22:14, Martin Basti wrote: On 16.06.2016 15:59, Petr Spacek wrote: On 16.6.2016 13:57, Martin Basti wrote: On 16.06.2016 12:09, Petr Spacek wrote

Re: [Freeipa-devel] I plan to delete my FreeIPA COPR repos

2016-06-17 Thread Martin Basti
On 17.06.2016 10:33, Martin Kosek wrote: On 05/13/2016 01:43 PM, Martin Kosek wrote: Hi all, When we were starting building FreeIPA in the Fedora COPR service [1], the service did not support the organizations as it can do now and we did the official repos in my personal name space [2] as I

Re: [Freeipa-devel] [PATCH 0133] Require 389-ds-base >= 1.3.5.6

2016-06-16 Thread Martin Basti
On 16.06.2016 12:21, Ludwig Krispenz wrote: On 06/16/2016 12:14 PM, Petr Spacek wrote: On 16.6.2016 12:12, Ludwig Krispenz wrote: On 06/16/2016 12:00 PM, Petr Spacek wrote: Hello, Require 389-ds-base >= 1.3.5.6 Old DS handles LDAP filters incorrectly no. Old DS handles filters strictly

Re: [Freeipa-devel] [PATCH 0153-0158] move ipa-replica-manage del functionality into server-del

2016-06-16 Thread Martin Basti
On 15.06.2016 15:29, Martin Babinsky wrote: On 06/15/2016 10:30 AM, Jan Cholasta wrote: Hi, On 12.6.2016 17:31, Martin Babinsky wrote: On 06/09/2016 08:12 PM, Martin Babinsky wrote: These patches expand `server_del` to a full fledged IPA master killer in domain level 1. Due to 'server

Re: [Freeipa-devel] [freeipa-devel][PATCH] Added missing translation to automount.py method

2016-06-16 Thread Martin Basti
On 16.06.2016 08:31, Abhijeet Kasurde wrote: Hi All, Please review updated patch. On 06/15/2016 07:56 PM, Abhijeet Kasurde wrote: On 06/15/2016 07:29 PM, Martin Basti wrote: On 15.06.2016 11:13, Abhijeet Kasurde wrote: Hi All, Please review the attached patch. Fixes: https

Re: [Freeipa-devel] [PATCH] Fix minor typos

2016-06-16 Thread Martin Basti
On 16.06.2016 05:16, Petr Spacek wrote: On 15.6.2016 20:57, Yuri Chornoivan wrote: Hi, There are several minor typos in the new portion of FreeIPA code (see the patch attached). Thanks for fixing them. Thank *you* for fixing them! ACK Pushed to master:

Re: [Freeipa-devel] [PATCH 0041] Increase nsslapd-db-locks

2016-06-15 Thread Martin Basti
On 14.06.2016 16:27, Martin Basti wrote: On 09.06.2016 12:42, Stanislav Laznicka wrote: On 06/07/2016 08:56 AM, thierry bordaz wrote: On 06/06/2016 07:23 PM, Martin Basti wrote: On 03.06.2016 13:38, Stanislav Laznicka wrote: Hello, The attached patch implements solution to https

Re: [Freeipa-devel] [PATCH 0033] Fix CA being presented as running even if it weren't

2016-06-15 Thread Martin Basti
On 02.06.2016 19:21, Martin Basti wrote: On 31.05.2016 16:32, Stanislav Laznicka wrote: On 05/31/2016 11:40 AM, Stanislav Laznicka wrote: On 05/31/2016 10:22 AM, Stanislav Laznicka wrote: On 05/30/2016 12:54 PM, Jan Cholasta wrote: On 30.5.2016 12:36, Martin Basti wrote: On 26.05.2016

Re: [Freeipa-devel] [PATCH] 0021 slapi-nis should allow password update on a virtual entry

2016-06-15 Thread Martin Basti
On 15.06.2016 17:19, thierry bordaz wrote: Hello, This patch is for https://fedorahosted.org/freeipa/ticket/5955 Please put this link to commit message This is the last patch related "IdM user password change support for legacy client compat tree" * It requires DS > 1.3.5.5

Re: [Freeipa-devel] [PATCH] 0068 upgrade: do not try to start CA if not configured

2016-06-15 Thread Martin Basti
On 15.06.2016 17:19, Martin Basti wrote: On 15.06.2016 17:17, Martin Basti wrote: On 15.06.2016 16:41, Petr Spacek wrote: On 15.6.2016 14:18, Fraser Tweedale wrote: Attached patch fixes https://fedorahosted.org/freeipa/ticket/5958. The regression was introduced in fix for https

Re: [Freeipa-devel] [PATCH] 0068 upgrade: do not try to start CA if not configured

2016-06-15 Thread Martin Basti
On 15.06.2016 17:17, Martin Basti wrote: On 15.06.2016 16:41, Petr Spacek wrote: On 15.6.2016 14:18, Fraser Tweedale wrote: Attached patch fixes https://fedorahosted.org/freeipa/ticket/5958. The regression was introduced in fix for https://fedorahosted.org/freeipa/ticket/5868. It works

Re: [Freeipa-devel] [PATCH] 0068 upgrade: do not try to start CA if not configured

2016-06-15 Thread Martin Basti
On 15.06.2016 16:41, Petr Spacek wrote: On 15.6.2016 14:18, Fraser Tweedale wrote: Attached patch fixes https://fedorahosted.org/freeipa/ticket/5958. The regression was introduced in fix for https://fedorahosted.org/freeipa/ticket/5868. It works for me, ACK. Pushed to master:

Re: [Freeipa-devel] [freeipa-devel][PATCH] Added missing translation to automount.py method

2016-06-15 Thread Martin Basti
On 15.06.2016 11:13, Abhijeet Kasurde wrote: Hi All, Please review the attached patch. Fixes: https://fedorahosted.org/freeipa/ticket/5920 Thank you for the patch, Please follow this page for howto create internationalized strings:

Re: [Freeipa-devel] [PATCH 0159-0160] emancipate IPA NTP service into role

2016-06-15 Thread Martin Basti
On 15.06.2016 13:29, Petr Spacek wrote: On 15.6.2016 09:57, Martin Basti wrote: On 15.06.2016 09:55, Petr Vobornik wrote: On 06/14/2016 07:28 PM, Martin Basti wrote: On 14.06.2016 18:58, Martin Babinsky wrote: On 06/14/2016 05:06 PM, Martin Basti wrote: On 12.06.2016 17:37, Martin

Re: [Freeipa-devel] [PATCH] 0206 adtrust optimize forest root LDAP filter

2016-06-15 Thread Martin Basti
On 15.06.2016 09:02, Martin Babinsky wrote: On 06/14/2016 04:45 PM, Alexander Bokovoy wrote: On Tue, 07 Jun 2016, Alexander Bokovoy wrote: Hi, `ipa trust-find' command should only show trusted forest root domains The child domains should be visible via ipa trustdomain-find forest.root

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-15 Thread Martin Basti
On 14.06.2016 18:30, Petr Vobornik wrote: On 06/14/2016 10:17 AM, Pavel Vomacka wrote: On 06/14/2016 06:42 AM, Fraser Tweedale wrote: On Mon, Jun 13, 2016 at 07:48:58PM +0200, Pavel Vomacka wrote: On 06/13/2016 06:55 AM, Fraser Tweedale wrote: On Fri, Jun 10, 2016 at 04:34:33PM +0200,

Re: [Freeipa-devel] [PATCH 0159-0160] emancipate IPA NTP service into role

2016-06-15 Thread Martin Basti
On 15.06.2016 09:55, Petr Vobornik wrote: On 06/14/2016 07:28 PM, Martin Basti wrote: On 14.06.2016 18:58, Martin Babinsky wrote: On 06/14/2016 05:06 PM, Martin Basti wrote: On 12.06.2016 17:37, Martin Babinsky wrote: These two patches turn oft-neglected ntp service into a full fledged

Re: [Freeipa-devel] [PATCH 0159-0160] emancipate IPA NTP service into role

2016-06-14 Thread Martin Basti
On 12.06.2016 17:37, Martin Babinsky wrote: These two patches turn oft-neglected ntp service into a full fledged role whose status can be queried centrally. They should also enable generation of location-specific _ntp._udp records. Please note that NTP is LDAP-enabled by additional call

Re: [Freeipa-devel] [PATCH 0042] Removed dead code from LDAPRemoveReverseMember

2016-06-14 Thread Martin Basti
On 14.06.2016 16:37, Jan Cholasta wrote: On 14.6.2016 16:29, Martin Basti wrote: On 08.06.2016 14:17, Stanislav Laznicka wrote: On 06/07/2016 10:42 AM, Martin Basti wrote: On 07.06.2016 10:43, Jan Cholasta wrote: On 7.6.2016 10:22, Martin Basti wrote: On 07.06.2016 09:07, Jan

Re: [Freeipa-devel] [PATCH 0042] Removed dead code from LDAPRemoveReverseMember

2016-06-14 Thread Martin Basti
On 08.06.2016 14:17, Stanislav Laznicka wrote: On 06/07/2016 10:42 AM, Martin Basti wrote: On 07.06.2016 10:43, Jan Cholasta wrote: On 7.6.2016 10:22, Martin Basti wrote: On 07.06.2016 09:07, Jan Cholasta wrote: On 6.6.2016 18:29, Martin Basti wrote: On 03.06.2016 14:28, Stanislav

Re: [Freeipa-devel] [PATCH 0041] Increase nsslapd-db-locks

2016-06-14 Thread Martin Basti
On 09.06.2016 12:42, Stanislav Laznicka wrote: On 06/07/2016 08:56 AM, thierry bordaz wrote: On 06/06/2016 07:23 PM, Martin Basti wrote: On 03.06.2016 13:38, Stanislav Laznicka wrote: Hello, The attached patch implements solution to https://fedorahosted.org/freeipa/ticket/5914

Re: [Freeipa-devel] [PATCH 0501] Revert: switch /usr/bin/ipa to python3

2016-06-14 Thread Martin Basti
On 14.06.2016 13:05, Martin Babinsky wrote: On 06/14/2016 11:56 AM, Martin Basti wrote: On 14.06.2016 10:14, Martin Basti wrote: On 10.06.2016 10:57, Martin Basti wrote: On 10.06.2016 06:17, Jan Cholasta wrote: On 9.6.2016 20:57, Martin Basti wrote: Py3 support was enabled

Re: [Freeipa-devel] [PATCH 0494] Bump required version of pki-ca and pki-kra due bug in parsing '%' in DM password

2016-06-14 Thread Martin Basti
On 02.06.2016 09:26, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5690 Patch attached You can ignore this patch, dogtag version has been bumped by different patch -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo

Re: [Freeipa-devel] [PATCH 0501] Revert: switch /usr/bin/ipa to python3

2016-06-14 Thread Martin Basti
On 14.06.2016 10:14, Martin Basti wrote: On 10.06.2016 10:57, Martin Basti wrote: On 10.06.2016 06:17, Jan Cholasta wrote: On 9.6.2016 20:57, Martin Basti wrote: Py3 support was enabled prematurely, attached patches removes python3 from /usr/bin/ipa Notes: * ipa 4.3.x won't have

Re: [Freeipa-devel] [PATCH 0501] Revert: switch /usr/bin/ipa to python3

2016-06-14 Thread Martin Basti
On 10.06.2016 10:57, Martin Basti wrote: On 10.06.2016 06:17, Jan Cholasta wrote: On 9.6.2016 20:57, Martin Basti wrote: Py3 support was enabled prematurely, attached patches removes python3 from /usr/bin/ipa Notes: * ipa 4.3.x won't have enabled py3 * master (ipa 4.4+) will have

Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-14 Thread Martin Basti
On 14.06.2016 08:04, Stanislav Laznicka wrote: On 06/13/2016 10:15 AM, Petr Vobornik wrote: On 06/10/2016 06:31 PM, Stanislav Laznicka wrote: On 06/08/2016 02:06 PM, Florence Blanc-Renaud wrote: On 06/08/2016 10:07 AM, Petr Spacek wrote: On 7.6.2016 15:11, Stanislav Laznicka wrote: Hello,

Re: [Freeipa-devel] [PATCH 0103-4] installer: Fix single command replica install with --setup-dns

2016-06-13 Thread Martin Basti
On 09.06.2016 16:16, Martin Babinsky wrote: On 06/09/2016 08:16 AM, David Kupka wrote: Should go into master, ipa-4-3 and ipa-4-2. https://fedorahosted.org/freeipa/ticket/5945 Works for me, ACK Pushed to master: * 54318d1a2c5133fc3a735872b7edc3cfacb032f9 installer: positional_arguments

Re: [Freeipa-devel] [PATCHES 0146-0152] Server Roles v2

2016-06-13 Thread Martin Basti
On 13.06.2016 07:26, Jan Cholasta wrote: On 12.6.2016 17:29, Martin Babinsky wrote: On 06/10/2016 05:42 PM, Martin Babinsky wrote: On 06/10/2016 02:22 PM, Jan Cholasta wrote: On 9.6.2016 17:06, Martin Babinsky wrote: On 06/09/2016 03:54 PM, Petr Vobornik wrote: On 06/09/2016 01:02 PM,

Re: [Freeipa-devel] [PATCH 0503-0513] DNS locations

2016-06-13 Thread Martin Basti
On 13.06.2016 14:57, Martin Basti wrote: Patches attached. https://fedorahosted.org/freeipa/ticket/2008 Missing parts: dns-server config, some warnings from design, some corner, cleanup of old unused location records cases, this will be covered in future patches It should be 'corner

[Freeipa-devel] [PATCH 0503-0513] DNS locations

2016-06-13 Thread Martin Basti
2001 From: Martin Basti <mba...@redhat.com> Date: Tue, 7 Jun 2016 10:43:50 +0200 Subject: [PATCH 01/11] DNS Locations: add index for ipalocation attribute For performace ipalocation should be indexed because it is used by referint plugin https://fedorahosted.org/freeipa/ticket/2008 --- i

Re: [Freeipa-devel] [PATCH 0491] Fix: Local variable s_indent might be referenced before defined

2016-06-13 Thread Martin Basti
On 01.06.2016 16:13, Martin Babinsky wrote: On 06/01/2016 03:59 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5921 Patch attached. ACK Pushed to master: 493ae1e5028c6ce8a0888146ee3de6c798caa55f -- Manage your subscription for the Freeipa-devel mailing list: https

Re: [Freeipa-devel] [PATCH] 0051: webui: correct jslint warning

2016-06-13 Thread Martin Basti
On 13.06.2016 13:50, Martin Basti wrote: On 13.06.2016 12:20, Pavel Vomacka wrote: On 06/13/2016 12:00 PM, Pavel Vomacka wrote: Hello, I forgot to run jslint during the last review and there was one warning, so this patch fixes it. -- Pavel^3 Vomacka Added ticket to the commit

Re: [Freeipa-devel] [PATCH] 0051: webui: correct jslint warning

2016-06-13 Thread Martin Basti
On 13.06.2016 12:20, Pavel Vomacka wrote: On 06/13/2016 12:00 PM, Pavel Vomacka wrote: Hello, I forgot to run jslint during the last review and there was one warning, so this patch fixes it. -- Pavel^3 Vomacka Added ticket to the commit message. Would be nice to have covered

Re: [Freeipa-devel] [PATCH 0492] Translations: update ipa-4-3 translations

2016-06-13 Thread Martin Basti
On 13.06.2016 12:25, Martin Babinsky wrote: On 06/13/2016 11:48 AM, Martin Basti wrote: On 13.06.2016 09:33, Lukas Slebodnik wrote: On (09/06/16 12:32), Martin Basti wrote: On 07.06.2016 12:51, Martin Babinsky wrote: On 06/01/2016 05:10 PM, Martin Basti wrote: Patch attached. ACK

Re: [Freeipa-devel] [PATCH 0492] Translations: update ipa-4-3 translations

2016-06-13 Thread Martin Basti
On 13.06.2016 09:33, Lukas Slebodnik wrote: On (09/06/16 12:32), Martin Basti wrote: On 07.06.2016 12:51, Martin Babinsky wrote: On 06/01/2016 05:10 PM, Martin Basti wrote: Patch attached. ACK Pushed to ipa-4-3: 22fcf65cd1b674b21496b677818a8c75adcd70a6 I am not sure but it's very

Re: [Freeipa-devel] [PATCH] 0202 support UPNs for trusted domain users

2016-06-11 Thread Martin Basti
On 11.06.2016 16:13, Martin Babinsky wrote: On 06/09/2016 07:19 PM, Alexander Bokovoy wrote: On Thu, 09 Jun 2016, Martin Babinsky wrote: On 06/09/2016 06:46 PM, Alexander Bokovoy wrote: On Thu, 09 Jun 2016, Martin Babinsky wrote: On 06/07/2016 07:35 PM, Alexander Bokovoy wrote: On Tue, 07

<    1   2   3   4   5   6   7   8   9   10   >