[Freeipa-devel] [PATCH] 730-732 webui: Login pages usability improvements

2014-08-05 Thread Petr Vobornik
password view of login screen - re-implemented buttons hiding mechanism - switching between 'Reset Password' and 'Reset Password and Login' according to presence of value in OTP field https://fedorahosted.org/freeipa/ticket/4470 -- Petr Vobornik From 8c0afe1848a836c3aaa2be1a016e0ad3739b6009 Mon Sep 17

[Freeipa-devel] [PATCH] 733-735 webui: Better description for User authentication types

2014-08-05 Thread Petr Vobornik
://fedorahosted.org/freeipa/ticket/4471 -- Petr Vobornik From fa44465303b0fe70ef3da3c6e8f8109cbda288bb Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 24 Jul 2014 15:33:04 +0200 Subject: [PATCH] webui: better authentication types description Tooltips were added to User

[Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-05 Thread Petr Vobornik
is enhanced by making them disabled by default. [PATCH] 740 webui: fix group type padding -- Petr Vobornik From 171b0faeecd29c83282a7070d14864c3ad739dee Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 31 Jul 2014 14:36:17 +0200 Subject: [PATCH] webui: fix group type padding

[Freeipa-devel] [PATCH] 741 webui: add link to OTP token app

2014-08-05 Thread Petr Vobornik
but serves the purpose - it's not fully configurable, as decided at today's meeting, but a very simple plugin can hide or modify the message [1] https://fedorahosted.org/freeotp/ -- Petr Vobornik From 149966eea35264134b3091b94eb78f7ec3d3be95 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo

[Freeipa-devel] [PATCH] 717 webui-ci: fix reset password check

2014-07-31 Thread Petr Vobornik
This patch should fix recent CI failures. After login, CI checks if password needs a reset by checking if reset password fields are displayed. This check failed since login facet was removed from DOM after successful auth. Weakening the selector fixes it. -- Petr Vobornik From

Re: [Freeipa-devel] [PATCH] 710 webui: review pending operation after expired session

2014-07-29 Thread Petr Vobornik
On 28.7.2014 19:01, Endi Sukma Dewata wrote: On 7/28/2014 6:06 AM, Petr Vobornik wrote: Right now suppose I'm trying to delete a user, I have the delete dialog open and I let it sit until the session expires, then when I click Delete it will show me a login screen. Once I re-login, the dialog

Re: [Freeipa-devel] [PATCH] 715 webui: add bounce url to reset_password.html

2014-07-29 Thread Petr Vobornik
On 28.7.2014 19:08, Endi Sukma Dewata wrote: On 7/28/2014 3:58 AM, Petr Vobornik wrote: Just one thing, there is no pause between clicking the Reset button and the redirection, so the Password reset was successful. confirmation message might only appear very briefly. A possible alternative

Re: [Freeipa-devel] [PATCH] webui: 696 support wildcard attribute level rights

2014-07-28 Thread Petr Vobornik
On 25.7.2014 22:25, Endi Sukma Dewata wrote: On 7/21/2014 6:35 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/4380 You're right, there is an error. Attaching new version. The code is rewritten to be more comprehensible - use cases are in separate variables. ACK. The code

Re: [Freeipa-devel] [PATCH] 709 webui: fix nested items creation in dropdown list

2014-07-28 Thread Petr Vobornik
On 25.7.2014 22:25, Endi Sukma Dewata wrote: On 7/21/2014 6:51 AM, Petr Vobornik wrote: Items nested in other items were created in root list instead of nested list. Note: this feature is not used in current UI but it's likely to be used by a plugin ACK. Pushed to: ipa-4-0

Re: [Freeipa-devel] [PATCH] 711 webui: internet explorer fixes

2014-07-28 Thread Petr Vobornik
On 25.7.2014 22:26, Endi Sukma Dewata wrote: On 7/24/2014 11:36 AM, Petr Vobornik wrote: On 23.7.2014 15:17, Petr Vobornik wrote: Fixed: 1. IE doesn't support value 'initial' in CSS rule. 2. setting innerHTML='' also destroys content of child nodes in LoginScreen in IE - reattached buttons

Re: [Freeipa-devel] [PATCH] 712 webui: detach facet nodes

2014-07-28 Thread Petr Vobornik
On 25.7.2014 22:27, Endi Sukma Dewata wrote: On 7/23/2014 8:25 AM, Petr Vobornik wrote: Detach/attach facet nodes when switching facets instead of hiding/showing. Keeps dom-tree more simple. This patch is not really needed. I implemented it while testing something in IE. But it might have

Re: [Freeipa-devel] [PATCH] 713-714 webui: replace action_buttons with action_widget

2014-07-28 Thread Petr Vobornik
On 25.7.2014 22:27, Endi Sukma Dewata wrote: On 7/23/2014 8:26 AM, Petr Vobornik wrote: [PATCH] 713 webui: replace action_buttons with action_widget Simplify code base by reuse of 'disable' feature of button_widget. All occurrences of action-button which were disabled/enabled were replaced

Re: [Freeipa-devel] [PATCH] 715 webui: add bounce url to reset_password.html

2014-07-28 Thread Petr Vobornik
On 25.7.2014 22:27, Endi Sukma Dewata wrote: On 7/23/2014 9:59 AM, Petr Vobornik wrote: reset_password.html now redirects browser to URL specified in 'redirect' uri component (if present). The component has to be URI encoded. ie (in browser console): $ encodeURIComponent('http

Re: [Freeipa-devel] [PATCH] 710 webui: review pending operation after expired session

2014-07-28 Thread Petr Vobornik
On 25.7.2014 22:26, Endi Sukma Dewata wrote: On 7/23/2014 8:16 AM, Petr Vobornik wrote: Disable automatic re-execution of command after pending authentication. It's possible to enable it again globally by 'freeipa/config':`rpc_retry_auth`. https://fedorahosted.org/freeipa/ticket/4374

Re: [Freeipa-devel] [PATCH] 712 webui: detach facet nodes

2014-07-28 Thread Petr Vobornik
On 25.7.2014 22:27, Endi Sukma Dewata wrote: On 7/23/2014 8:25 AM, Petr Vobornik wrote: Detach/attach facet nodes when switching facets instead of hiding/showing. Keeps dom-tree more simple. This patch is not really needed. I implemented it while testing something in IE. But it might have

[Freeipa-devel] [PATCH] 716 baseldap: return 'none' attr level right as unicode string

2014-07-25 Thread Petr Vobornik
Returning non-unicode causes serialization into base64 which causes havoc in Web UI. https://fedorahosted.org/freeipa/ticket/4454 IMHO we should fix JSON-RPC serialization to encode non-unicode strings to normal JSON strings. -- Petr Vobornik From 1158e43ad6fd9107390f14a00b95c61ce489ff20

Re: [Freeipa-devel] [PATCH] 716 baseldap: return 'none' attr level right as unicode string

2014-07-25 Thread Petr Vobornik
On 25.7.2014 13:02, Alexander Bokovoy wrote: On Fri, 25 Jul 2014, Petr Vobornik wrote: Returning non-unicode causes serialization into base64 which causes havoc in Web UI. https://fedorahosted.org/freeipa/ticket/4454 ACK for this patch. Pushed to: master

Re: [Freeipa-devel] [PATCH] 711 webui: internet explorer fixes

2014-07-24 Thread Petr Vobornik
On 23.7.2014 15:17, Petr Vobornik wrote: Fixed: 1. IE doesn't support value 'initial' in CSS rule. 2. setting innerHTML='' also destroys content of child nodes in LoginScreen in IE - reattached buttons have no text. Should go into 4.0 Milestone Found an issue in the implementation, new

[Freeipa-devel] [PATCH] 710 webui: review pending operation after expired session

2014-07-23 Thread Petr Vobornik
to contain global webui config which could be overwritten by config configured on server, ie for disabling paging in large deployments. The server part doesn't exist yet. Other reason is to split ipa.js into more single-purpose files. -- Petr Vobornik From fa28c0fbf5451802d640fcb9a9cd09fc1b8082cc

[Freeipa-devel] [PATCH] 712 webui: detach facet nodes

2014-07-23 Thread Petr Vobornik
. Basically it simplifies DOM tree to contain nodes only for the active facet. Therefore ugly expressions like $('button .foobar') are much more performant. -- Petr Vobornik From 46e9b59f526a4beccba02dbe815f21c3aa688eaa Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 22 Jul

[Freeipa-devel] [PATCH] 713-714 webui: replace action_buttons with action_widget

2014-07-23 Thread Petr Vobornik
remaining action-button-disabled occurrences Buttons in hbactest check for 'action-button-disabled' but it's never set. https://fedorahosted.org/freeipa/ticket/4258 -- Petr Vobornik From 8151b70b2ac3cdc856c3e888eeb9cfd76a3ab140 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date

[Freeipa-devel] [PATCH] 715 webui: add bounce url to reset_password.html

2014-07-23 Thread Petr Vobornik
%2F%23!%2Fguide%2FDebugging -- https://my.freeipa.server/ipa/ui/reset_password.html?redirect=http%3A%2F%2Fpvoborni.fedorapeople.org%2Fdoc%2F%23!%2Fguide%2FDebugging https://fedorahosted.org/freeipa/ticket/4440 -- Petr Vobornik From 975c1afb4a96d699a43f9c68af343316659d7c6d Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 697-702 webui: usability improvements in attribute widget

2014-07-21 Thread Petr Vobornik
On 18.7.2014 00:06, Endi Sukma Dewata wrote: On 7/10/2014 8:02 AM, Petr Vobornik wrote: ACK. Comments below: == [PATCH] 699 webui: optimize (re)creation of option widget == There is a case where attributes widget can contain 1000 items. It's about 3000 nodes. It's slow in jQuery. Simple

Re: [Freeipa-devel] [PATCH] 703-707 webui: improvements in permission details page

2014-07-21 Thread Petr Vobornik
On 7/10/2014 7:38 AM, Petr Vobornik wrote: == [PATCH] 707 webui: disable ipapermbindruletype if permission in a privilege == User is not able to change Bind Rule Type if permission is already member of a privilege. Let's disable it and don't confuse user. If you open a permission, go

Re: [Freeipa-devel] [PATCH] 708 webui: fix disabled state of service's PAC type

2014-07-21 Thread Petr Vobornik
On 18.7.2014 00:09, Endi Sukma Dewata wrote: On 7/10/2014 7:38 AM, Petr Vobornik wrote: Nested options (MS-PAC and PAD) of service's PAC type should be disabled if no value is supplied (default value is Inherited from server configuration). That was not the case - regression. This patch fixes

Re: [Freeipa-devel] [PATCH] webui: 696 support wildcard attribute level rights

2014-07-21 Thread Petr Vobornik
On 18.7.2014 00:03, Endi Sukma Dewata wrote: On 7/10/2014 7:23 AM, Petr Vobornik wrote: Reproduction: * add 'extensibleObject' object class to target object https://fedorahosted.org/freeipa/ticket/4380 This is the original if-condition: (!rights !(that.flags.indexOf('w_if_no_aci

[Freeipa-devel] [PATCH] 709 webui: fix nested items creation in dropdown list

2014-07-21 Thread Petr Vobornik
Items nested in other items were created in root list instead of nested list. Note: this feature is not used in current UI but it's likely to be used by a plugin -- Petr Vobornik From 0f83a4bfb5d164f0fbd6d6520091fbea21887673 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com

Re: [Freeipa-devel] [PATCH 0058] Fix login password expiration detection with OTP

2014-07-21 Thread Petr Vobornik
instead of 1.11.5-5. Should we add version dependency = 1.11.5-5 to spec file? -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] webui: 696 support wildcard attribute level rights

2014-07-10 Thread Petr Vobornik
Reproduction: * add 'extensibleObject' object class to target object https://fedorahosted.org/freeipa/ticket/4380 -- Petr Vobornik From 908d39fdff8d91b5535e72e05410a7959f511613 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 19 Jun 2014 17:09:38 +0200 Subject: [PATCH

[Freeipa-devel] [PATCH] 697-702 webui: usability improvements in attribute widget

2014-07-10 Thread Petr Vobornik
removes an attr from effective attrs which is not in metadata. Without this it will disappear from the list and one has to add it manually through 'Add'. [PATCH] 702 webui: option_widget_base: sort options -- Petr Vobornik From b668671d78f6e23cf9a77371c59fd778fc262f61 Mon Sep 17 00:00:00 2001 From

[Freeipa-devel] [PATCH] 703-707 webui: improvements in permission details page

2014-07-10 Thread Petr Vobornik
to change Bind Rule Type if permission is already member of a privilege. Let's disable it and don't confuse user. -- Petr Vobornik From 854ff710b08f7b5e699be3b65b2919471ad250c6 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Mon, 7 Jul 2014 17:45:50 +0200 Subject: [PATCH

[Freeipa-devel] [PATCH] 708 webui: fix disabled state of service's PAC type

2014-07-10 Thread Petr Vobornik
comprehensible. -- Petr Vobornik From 39283e12d8f820842e9f3a8233c32779a298bafb Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 10 Jul 2014 12:02:51 +0200 Subject: [PATCH] webui: fix disabled state of service's PAC type Nested options (MS-PAC and PAD) of service's PAC type

Re: [Freeipa-devel] [PATCH] 697-702 webui: usability improvements in attribute widget

2014-07-10 Thread Petr Vobornik
There is an issue in patch #701, new version attached. On 10.7.2014 14:29, Petr Vobornik wrote: ticket: https://fedorahosted.org/freeipa/ticket/4253 == [PATCH] 697 webui: improve usability of attributes widget == Attributes widget layour was changed from tiny table which allowed to display

Re: [Freeipa-devel] [PATCH] 694 webui: new navigation structure

2014-07-04 Thread Petr Vobornik
On 4.7.2014 16:10, Petr Spacek wrote: On 4.7.2014 16:07, Martin Kosek wrote: On 07/03/2014 03:06 PM, Petr Vobornik wrote: On 3.7.2014 08:13, Fraser Tweedale wrote: On Wed, Jul 02, 2014 at 04:14:13PM +0200, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/4418 according to latest

Re: [Freeipa-devel] [PATCH] 694 webui: new navigation structure

2014-07-03 Thread Petr Vobornik
On 3.7.2014 08:13, Fraser Tweedale wrote: On Wed, Jul 02, 2014 at 04:14:13PM +0200, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/4418 according to latest proposal:http://www.redhat.com/archives/freeipa-devel/2014-June/msg00839.html -- Petr Vobornik Haven't run the webui tests

[Freeipa-devel] [PATCH] 695 webui: display messages contained in API responses

2014-07-03 Thread Petr Vobornik
, ...). -- Petr Vobornik From da9375212307e5a746e253a3d163e1eb8f3dbd75 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 3 Jul 2014 10:31:54 +0200 Subject: [PATCH] webui: display messages contained in API responses API responses can contain warnings in messages array

Re: [Freeipa-devel] [PATCH 0140] [PATCH 140/140] ipalib: Use DateTime parameter class for OTP token

2014-07-03 Thread Petr Vobornik
On 2.6.2014 18:35, Petr Vobornik wrote: On 14.1.2014 15:20, Petr Viktorin wrote: On 01/14/2014 09:33 AM, Jan Cholasta wrote: On 9.1.2014 16:32, Tomas Babej wrote: Hi, For ipatokennotbefore and ipatokennotafter attributes use DateTime parameter class instead of Str, since

Re: [Freeipa-devel] [PATCHES 0084-0086] NSEC3PARAM DNS record should be in DNS zone settings

2014-07-02 Thread Petr Vobornik
empty line +pattern_errmsg=_nsec3param_errmsg, + +), Unrelated: 5. IMO framework should be extended to support translations in `pattern_errmsg` -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCHES 0084-0086] NSEC3PARAM DNS record should be in DNS zone settings

2014-07-02 Thread Petr Vobornik
* 30551a8aa30dcd39b3ae4c2fe97a163620773730 Add NSEC3PARAM to zone settings * 01b95805ab1428e10c79abf70c9bc9e2baf9de21 NSEC3PARAM tests -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa

[Freeipa-devel] [PATCH] 694 webui: new navigation structure

2014-07-02 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/4418 according to latest proposal:http://www.redhat.com/archives/freeipa-devel/2014-June/msg00839.html -- Petr Vobornik From 97cc94163e8ae57058b07741c7d70e44697c113f Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 2 Jul 2014

Re: [Freeipa-devel] [PATCH] 680-682 webui: validation reporting improvements

2014-07-01 Thread Petr Vobornik
On 30.6.2014 16:23, Endi Sukma Dewata wrote: On 6/27/2014 3:54 AM, Petr Vobornik wrote: On 27.6.2014 09:48, Fraser Tweedale wrote: On Wed, Jun 25, 2014 at 06:58:52PM +0200, Petr Vobornik wrote: Patch 618 fixes a bug. Patches 680 and 681 were implemented along with it. They address pspacek's

Re: [Freeipa-devel] [PATCH 0078-0079] DNSSEC: Add TLSA record

2014-07-01 Thread Petr Vobornik
On 1.7.2014 10:11, Martin Basti wrote: On Mon, 2014-06-30 at 18:07 +0200, Petr Vobornik wrote: On 27.6.2014 14:55, Martin Basti wrote: On Thu, 2014-06-26 at 13:57 +0200, Petr Vobornik wrote: On 25.6.2014 14:35, Martin Basti wrote: On Wed, 2014-06-25 at 14:31 +0200, Martin Basti wrote

[Freeipa-devel] [PATCH] 693 webui-build: use /usr/share/java/js.jar instead of rhino.jar

2014-07-01 Thread Petr Vobornik
/usr/share/java/rhino.jar is a Fedora's symlink to /usr/share/java/js.jar Debian doesn't have it. Direct usage of upstream /usr/share/java/js.jar should work on both systems. -- Petr Vobornik From 2263d7daf9134c2495b19538a72893eab922d3c3 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo

Re: [Freeipa-devel] [PATCH] 692 webui: capitalize labels of undo and undo all buttons

2014-06-30 Thread Petr Vobornik
On 30.6.2014 09:13, Fraser Tweedale wrote: On Fri, Jun 27, 2014 at 02:11:47PM +0200, Petr Vobornik wrote: Make the label of these buttons consistent with other buttons which have capital first letters. -- Petr Vobornik From 7214242fb0c5accc45b6af476a8ff7e7b1a7883f Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 683-690 webui: OTP token sync

2014-06-30 Thread Petr Vobornik
On 28.6.2014 01:59, Endi Sukma Dewata wrote: On 6/26/2014 9:11 AM, Petr Vobornik wrote: This set of patches creates page(s) for OTP Token Sync. there are two options: 1. from login page by Sync OTP Token link. - user can navigate between those two pages 2. standalone page on `ipa/ui

Re: [Freeipa-devel] [PATCH] 691 webui-ci: fix action list action visibility and enablement assertion

2014-06-30 Thread Petr Vobornik
On 28.6.2014 02:04, Endi Sukma Dewata wrote: On 6/26/2014 9:15 AM, Petr Vobornik wrote: Fixes CA-less CI test fail The new html structure was not addressed properly. The new code is checking for the 'disabled' class in the list element, not the link element, is this correct? is_enabled

Re: [Freeipa-devel] [PATCH] 677 webui: support unlock user command

2014-06-30 Thread Petr Vobornik
On 27.6.2014 18:09, Endi Sukma Dewata wrote: On 6/24/2014 10:44 AM, Petr Vobornik wrote: Call user-unlock command from Web UI. It will unlock displayed user on current master. related to: https://fedorahosted.org/freeipa/ticket/2792 Looks like there's a server problem (ticket #4409

Re: [Freeipa-devel] [PATCH] 680-682 webui: validation reporting improvements

2014-06-30 Thread Petr Vobornik
On 30.6.2014 06:41, Fraser Tweedale wrote: On Fri, Jun 27, 2014 at 10:54:39AM +0200, Petr Vobornik wrote: On 27.6.2014 09:48, Fraser Tweedale wrote: On Wed, Jun 25, 2014 at 06:58:52PM +0200, Petr Vobornik wrote: Patch 618 fixes a bug. Patches 680 and 681 were implemented along

Re: [Freeipa-devel] [PATCH 0078-0079] DNSSEC: Add TLSA record

2014-06-30 Thread Petr Vobornik
On 27.6.2014 14:55, Martin Basti wrote: On Thu, 2014-06-26 at 13:57 +0200, Petr Vobornik wrote: On 25.6.2014 14:35, Martin Basti wrote: On Wed, 2014-06-25 at 14:31 +0200, Martin Basti wrote: Ticket https://fedorahosted.org/freeipa/ticket/4328#comment:12 Patches attached. Note: ACI

Re: [Freeipa-devel] [PATCH] 0611 install/ui/build: Build core.js

2014-06-30 Thread Petr Vobornik
On 30.6.2014 17:43, Petr Viktorin wrote: IPA wouldn't build for me because of a Makefile problem. This should solve the issue. ACK Pushed to master: dfbd7170e901bc597462191c219c0e2b45c09afa Sorry about that. -- Petr Vobornik ___ Freeipa-devel

Re: [Freeipa-devel] [PATCH] 680-682 webui: validation reporting improvements

2014-06-27 Thread Petr Vobornik
On 27.6.2014 09:48, Fraser Tweedale wrote: On Wed, Jun 25, 2014 at 06:58:52PM +0200, Petr Vobornik wrote: Patch 618 fixes a bug. Patches 680 and 681 were implemented along with it. They address pspacek's usability rant :). [PATCH] 680 webui: show notification instead of modal dialog

[Freeipa-devel] [PATCH] 692 webui: capitalize labels of undo and undo all buttons

2014-06-27 Thread Petr Vobornik
Make the label of these buttons consistent with other buttons which have capital first letters. -- Petr Vobornik From 7214242fb0c5accc45b6af476a8ff7e7b1a7883f Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 27 Jun 2014 13:59:11 +0200 Subject: [PATCH] webui: capitalize

Re: [Freeipa-devel] [PATCH] 670-675 webui: dns forward zones

2014-06-27 Thread Petr Vobornik
On 27.6.2014 06:34, Endi Sukma Dewata wrote: On 6/24/2014 9:39 AM, Petr Vobornik wrote: On 24.6.2014 13:02, Petr Vobornik wrote: ticket: https://fedorahosted.org/freeipa/ticket/4357 - patch 673 is compressed - CI patches functionally depends on #667, #668 == PATCH] 670 webui: add

Re: [Freeipa-devel] [PATCH] 678-679 webui: send API version in RPC requests and adapt to new response format

2014-06-27 Thread Petr Vobornik
On 27.6.2014 06:34, Endi Sukma Dewata wrote: On 6/25/2014 8:51 AM, Petr Vobornik wrote: ticket: https://fedorahosted.org/freeipa/ticket/4394 == [PATCH] 678 webui: send API version in RPC requests == Currently there is an incorrect behavior that server doesn't send datetime and dnsname data

Re: [Freeipa-devel] [PATCH] 677 webui: support unlock user command

2014-06-27 Thread Petr Vobornik
On 24.6.2014 17:44, Petr Vobornik wrote: Call user-unlock command from Web UI. It will unlock displayed user on current master. related to: https://fedorahosted.org/freeipa/ticket/2792 This effort has a new ticket: https://fedorahosted.org/freeipa/ticket/4407 Updated patch attached

Re: [Freeipa-devel] Planning FreeIPA 4.0 GA

2014-06-27 Thread Petr Vobornik
true: http://www.redhat.com/archives/freeipa-devel/2014-January/msg00069.html Simo. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] Reorganization of Web UI navigation items

2014-06-27 Thread Petr Vobornik
On 2.6.2014 15:59, Petr Vobornik wrote: Hi List, the purpose if this mail is to start a discussion about reorganization of navigation items. Users are not fond of such change so we should come up with a solution which would last for some time. Problem: UX recommendation is that one menu level

Re: [Freeipa-devel] [PATCH] 676 rpcserver: fix local vs utc time comparison

2014-06-26 Thread Petr Vobornik
On 25.6.2014 17:36, Jan Cholasta wrote: Hi, On 24.6.2014 16:02, Petr Vobornik wrote: login_password did not work properly in timezones other than +0h because local time was compared with utc time. ACK. pushed to master: 1c94edd3a09711d85ba099bd815c0bdd8f0210c1 rpcserver: fix local vs utc

Re: [Freeipa-devel] [PATCH] 659-666 Support of password reset with OTP

2014-06-26 Thread Petr Vobornik
On 25.6.2014 19:41, Endi Sukma Dewata wrote: On 6/20/2014 10:18 AM, Petr Vobornik wrote: On 11.6.2014 15:19, Petr Vobornik wrote: Patch set contains both API/server and Web UI parts. [PATCH] 659 ldap2: add otp support to modify_password [PATCH] 660 rpcserver: add otp support

Re: [Freeipa-devel] [PATCH 0078-0079] DNSEC: Add TLSA record

2014-06-26 Thread Petr Vobornik
dependencies? I'm missing necessary blobs.. (current master). Also it requires rebase because of today's pushes to master (VERSION conflict). -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo

[Freeipa-devel] [PATCH] 691 webui-ci: fix action list action visibility and enablement assertion

2014-06-26 Thread Petr Vobornik
Fixes CA-less CI test fail The new html structure was not addressed properly. -- Petr Vobornik From a0e2e83470d1ca2c5f6f286e59588b10eb5f75bc Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 26 Jun 2014 14:38:05 +0200 Subject: [PATCH] webui-ci: fix action list action

[Freeipa-devel] [PATCH] 678-679 webui: send API version in RPC requests and adapt to new response format

2014-06-25 Thread Petr Vobornik
as the latest client. Server then sends data in correct format. It also removes the unknown version warning from each RPC response. == [PATCH] 679 webui: extract rpc value from object envelope == adapt Web UI to a newer style of encapsulation object data -- Petr Vobornik From

Re: [Freeipa-devel] [PATCH] 667 webui-ci: adjust tests to dns changes

2014-06-25 Thread Petr Vobornik
On 25.6.2014 15:30, Endi Sukma Dewata wrote: On 6/18/2014 6:22 AM, Petr Vobornik wrote: All DNS Zone names must be fully qualified. Assuming test works, ACK. pushed to master: 15374cf58fe26396be7bc70d7133b501b11dad6d webui-ci: adjust tests to dns changes -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 668 webui: fix field's default value

2014-06-25 Thread Petr Vobornik
On 25.6.2014 15:30, Endi Sukma Dewata wrote: On 6/18/2014 6:22 AM, Petr Vobornik wrote: Fields with default value, such as DNS Zone's idnsforwardpolicy, were marked as dirty when no value was loaded and when default value of input control was other than empty. Fixes regression in DNS Zone

Re: [Freeipa-devel] [PATCH] 669 webui: don't limit permission search in privileges

2014-06-25 Thread Petr Vobornik
On 25.6.2014 15:31, Endi Sukma Dewata wrote: On 6/23/2014 11:09 AM, Petr Vobornik wrote: Search for privileges was limited to bindruletype==permission. There was no reason to do that. This patch removes the restriction. Related to: https://fedorahosted.org/freeipa/ticket/4079 ACK. pushed

[Freeipa-devel] [PATCH] 680-682 webui: validation reporting improvements

2014-06-25 Thread Petr Vobornik
: focus invalid widget on validation error -- Petr Vobornik From 5c3fcd240d61f378a8bb7e8cd4c2129cd11930df Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 25 Jun 2014 15:17:26 +0200 Subject: [PATCH] webui: focus invalid widget on validation error --- install/ui/src/freeipa

Re: [Freeipa-devel] [PATCH] 647-651 [webui] Make utility section of navigation extensible

2014-06-24 Thread Petr Vobornik
On 23.6.2014 18:35, Endi Sukma Dewata wrote: On 6/23/2014 8:15 AM, Petr Vobornik wrote: 1. I'm not sure if we really need a HashCreator. Ideally the router should map a hash to a page. Links to another page can be hardcoded too (and substitute the parameters). The main purpose of a hash

Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu

2014-06-24 Thread Petr Vobornik
On 12.6.2014 14:53, Endi Sukma Dewata wrote: On 6/11/2014 10:17 AM, Endi Sukma Dewata wrote: On 6/11/2014 6:06 AM, Petr Vobornik wrote: 1. If I recall correctly, a new user is required to change the password upon the initial login. This can be done with kinit, but can this be done via UI too

[Freeipa-devel] [PATCH] 676 rpcserver: fix local vs utc time comparison

2014-06-24 Thread Petr Vobornik
login_password did not work properly in timezones other than +0h because local time was compared with utc time. Bug introduced in: https://fedorahosted.org/freeipa/ticket/4339 We should review other code for invalid usage of datetime.now() -- Petr Vobornik From

Re: [Freeipa-devel] [PATCH] 670-675 webui: dns forward zones

2014-06-24 Thread Petr Vobornik
On 24.6.2014 13:02, Petr Vobornik wrote: ticket: https://fedorahosted.org/freeipa/ticket/4357 - patch 673 is compressed - CI patches functionally depends on #667, #668 == PATCH] 670 webui: add confirmation for dns zone permission actions == All header actions should require confirmation

[Freeipa-devel] [PATCH] 677 webui: support unlock user command

2014-06-24 Thread Petr Vobornik
Call user-unlock command from Web UI. It will unlock displayed user on current master. related to: https://fedorahosted.org/freeipa/ticket/2792 -- Petr Vobornik From 1d39ac323d3c5975a6725bac50c81f655606f9b2 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 24 Jun 2014

Re: [Freeipa-devel] [PATCH] 647-651 [webui] Make utility section of navigation extensible

2014-06-23 Thread Petr Vobornik
On 20.6.2014 18:18, Endi Sukma Dewata wrote: On 6/18/2014 6:11 AM, Petr Vobornik wrote: 1. As discussed on IRC, the plugin is causing an error due to missing extend.js. This needs to be fixed. Fixed 4. I agree that the facet shouldn't define the hash. The hash should be part of the plugin

[Freeipa-devel] [PATCH] 669 webui: don't limit permission search in privileges

2014-06-23 Thread Petr Vobornik
Search for privileges was limited to bindruletype==permission. There was no reason to do that. This patch removes the restriction. Related to: https://fedorahosted.org/freeipa/ticket/4079 -- Petr Vobornik From 213e6d486c42bd1ccc38bf9597fe9ad6821ec9ee Mon Sep 17 00:00:00 2001 From: Petr Vobornik

Re: [Freeipa-devel] [PATCHES] 0052-0055 Separate master and forward DNS zones to separate objectClasses

2014-06-20 Thread Petr Vobornik
On 19.6.2014 16:55, Martin Basti wrote: On Thu, 2014-06-19 at 15:16 +0200, Petr Vobornik wrote: On 18.6.2014 13:42, Martin Basti wrote: Rebased patches with pep8 fixes attached git diff HEAD~4 -U0 | pep8 --diff --ignore=E501,E126,E128,E124 ./ipalib/plugins/dns.py:1754:9: E265 block comment

Re: [Freeipa-devel] [PATCH] 0059-0063 Update DNSSEC attributes/record types

2014-06-20 Thread Petr Vobornik
On 20.6.2014 14:35, Martin Basti wrote: On Thu, 2014-06-19 at 18:37 +0200, Martin Basti wrote: On Fri, 2014-06-13 at 09:55 +0200, Martin Basti wrote: On Thu, 2014-06-12 at 16:20 +0200, Martin Basti wrote: On Thu, 2014-06-12 at 13:17 +0200, Petr Vobornik wrote: On 9.6.2014 17:28, Martin Basti

Re: [Freeipa-devel] [PATCH] 0059-0063 Update DNSSEC attributes/record types

2014-06-20 Thread Petr Vobornik
On 20.6.2014 15:30, Petr Vobornik wrote: On 20.6.2014 14:35, Martin Basti wrote: On Thu, 2014-06-19 at 18:37 +0200, Martin Basti wrote: On Fri, 2014-06-13 at 09:55 +0200, Martin Basti wrote: On Thu, 2014-06-12 at 16:20 +0200, Martin Basti wrote: On Thu, 2014-06-12 at 13:17 +0200, Petr

Re: [Freeipa-devel] [PATCHES 0072-0075] Add DLV record (Update DNSSEC attributes in LDAP schema)

2014-06-20 Thread Petr Vobornik
: DLV record * 2229e89bbb2b89ad72e467de83f735b308a7bca1 Digest part in DLV/DS records allows only heaxadecimal characters * 0eef37908c580f4550618244e661594138f7b382 DNSSEC: WebUI add DLV record type -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa

Re: [Freeipa-devel] [PATCH] 659-666 Support of password reset with OTP

2014-06-20 Thread Petr Vobornik
On 11.6.2014 15:19, Petr Vobornik wrote: Patch set contains both API/server and Web UI parts. [PATCH] 659 ldap2: add otp support to modify_password [PATCH] 660 rpcserver: add otp support to change_password handler [PATCH] 661 ipa-passwd: add OTP support [PATCH] 662 webui: support password

Re: [Freeipa-devel] [PATCHES] 0052-0055 Separate master and forward DNS zones to separate objectClasses

2014-06-19 Thread Petr Vobornik
, especially the `--name=DNSNAMEPARAM`, I wonder if have somewhere documented the formats of various param types. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 667 webui-ci: adjust tests to dns changes

2014-06-18 Thread Petr Vobornik
All DNS Zone names must be fully qualified. -- Petr Vobornik From c5b7d6c24224c999d17a9676627ead7af63a2ea5 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 10 Jun 2014 19:04:49 +0200 Subject: [PATCH] webui-ci: adjust tests to dns changes All DNS Zone names must

[Freeipa-devel] [PATCH] 668 webui: fix field's default value

2014-06-18 Thread Petr Vobornik
Fields with default value, such as DNS Zone's idnsforwardpolicy, were marked as dirty when no value was loaded and when default value of input control was other than empty. Fixes regression in DNS Zone details facet - facet is always dirty. -- Petr Vobornik From

Re: [Freeipa-devel] [PATCH] 655 webui: move RPC result extraction logic to Adapter

2014-06-16 Thread Petr Vobornik
On 12.6.2014 14:40, Endi Sukma Dewata wrote: On 6/11/2014 8:05 AM, Petr Vobornik wrote: It enables declarative extraction of values from partial results of a batch commands and also further extensibility in custom adapters. The default adapter has detection logic for this extraction so it can

Re: [Freeipa-devel] [PATCH] 546 webui: expose krbprincipalexpiration

2014-06-16 Thread Petr Vobornik
On 12.6.2014 14:40, Endi Sukma Dewata wrote: On 2/25/2014 11:07 AM, Petr Vobornik wrote: Depends on tbabej's patches # 137, 138 and my 546. https://fedorahosted.org/freeipa/ticket/3306 ACK on #547. Pushed to master: 4de9c5fc51c1e9a07a23b430ba531eb096960732 -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 654 webui: fix SSH Key widget update

2014-06-12 Thread Petr Vobornik
On 11.6.2014 18:03, Nathaniel McCallum wrote: On Wed, 2014-06-11 at 15:04 +0200, Petr Vobornik wrote: Update widget status text on update. ACK Pushed to master: 352ef8428c8e2faef8b93b8ecbee9db7e40e1ab6 -- Petr Vobornik ___ Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] 656 webui: handle unknown result of automember-default-group-show

2014-06-12 Thread Petr Vobornik
On 11.6.2014 18:02, Nathaniel McCallum wrote: On Wed, 2014-06-11 at 15:07 +0200, Petr Vobornik wrote: Interface for setting default group is hidden when user doesn't have necessary rights or if there is some error while loading the state. https://fedorahosted.org/freeipa/ticket/4356 ACK

Re: [Freeipa-devel] [PATCH] 657 webui: control sudo rule deny command tables by category switch

2014-06-12 Thread Petr Vobornik
On 11.6.2014 18:30, Nathaniel McCallum wrote: On Wed, 2014-06-11 at 15:08 +0200, Petr Vobornik wrote: `memberdenycmd_sudocmd` and `memberdenycmd_sudocmdgroup` tables are now enabled/disabled based on `cmdcategory` as well. https://fedorahosted.org/freeipa/ticket/4361 ACK Pushed to master

Re: [Freeipa-devel] [PATCH] 658 webui: add sudoorder field to sudo rule page

2014-06-12 Thread Petr Vobornik
On 11.6.2014 18:01, Nathaniel McCallum wrote: On Wed, 2014-06-11 at 15:09 +0200, Petr Vobornik wrote: part of https://fedorahosted.org/freeipa/ticket/2348 ACK Pushed to master: 8f286d5c510c30f2319a8b0142cb68ee8e81f664 -- Petr Vobornik ___ Freeipa

Re: [Freeipa-devel] [PATCH] 0059-0064 Update DNSSEC attributes/record types

2014-06-12 Thread Petr Vobornik
are there the idnafsdbrec1 variables? 4. related to ^^: ./ipatests/test_xmlrpc/test_dns_plugin.py:199:33: E231 missing whitespace after ',' Patch #0063: LGTM IDK if they work because I'm experiencing some weird issues with xmlrpc_tests in general. -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 631 webui: fix regression: enabled gid field on group add

2014-06-11 Thread Petr Vobornik
On 10.6.2014 23:10, Endi Sukma Dewata wrote: On 5/14/2014 9:41 AM, Petr Vobornik wrote: GID field should be enabled by default since the default group is posix. Was caused by option_widget_base not properly reporting value change while selecting the default value. It has to be notified

Re: [Freeipa-devel] [PATCH] 591 webui: add idnsSecInlineSigning option to DNS zone details facet

2014-06-11 Thread Petr Vobornik
On 10.6.2014 23:10, Endi Sukma Dewata wrote: On 4/30/2014 5:28 AM, Petr Vobornik wrote: Web UI part of pviktori-543 https://fedorahosted.org/freeipa/ticket/3801 ACK. Pushed to master: 9c97bbd347b89634a844726c5d1f0ef39df4d139 -- Petr Vobornik

[Freeipa-devel] [PATCH] 654 webui: fix SSH Key widget update

2014-06-11 Thread Petr Vobornik
Update widget status text on update. -- Petr Vobornik From f03a810d7faa7981c750a61f4cbf6af5924744e4 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 28 May 2014 16:08:23 +0200 Subject: [PATCH] webui: fix SSH Key widget update Update widget status text on update

[Freeipa-devel] [PATCH] 655 webui: move RPC result extraction logic to Adapter

2014-06-11 Thread Petr Vobornik
plugin fixed: https://fedorahosted.org/freeipa/ticket/4355 -- Petr Vobornik From b90d2760c64992ef8303ad0bc674dcd695d4e8fe Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 28 May 2014 14:45:57 +0200 Subject: [PATCH] webui: move RPC result extraction logic to Adapter

[Freeipa-devel] [PATCH] 656 webui: handle unknown result of automember-default-group-show

2014-06-11 Thread Petr Vobornik
Interface for setting default group is hidden when user doesn't have necessary rights or if there is some error while loading the state. https://fedorahosted.org/freeipa/ticket/4356 -- Petr Vobornik From 317d407dbb76a0a6d54075eea435d2809314ce9b Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo

Re: [Freeipa-devel] [PATCH 0064] python-kerberos update in freeipa.spec.in

2014-06-11 Thread Petr Vobornik
On 9.6.2014 16:08, Nathaniel McCallum wrote: On Mon, 2014-06-09 at 15:59 +0200, Martin Basti wrote: Patch attached. View the patch for more details. ACK Pushed to master: d2d0da01526af41739e0eeef4273fcb71e40abc9 -- Petr Vobornik ___ Freeipa

Re: [Freeipa-devel] [PATCH] 592-628 Update to PatternFly

2014-06-10 Thread Petr Vobornik
On 10.6.2014 01:52, Endi Sukma Dewata wrote: On 6/9/2014 8:46 AM, Petr Vobornik wrote: I've fixed issues #4, #2, #20 and #18. Commits in the branch, no rebase. With these 4 changes we are ready for the push. I'll squash them, if necessary. You mean #11 instead of #2? The fixes are confirmed

Re: [Freeipa-devel] [PATCHES] Update plugins to use Registry API

2014-06-10 Thread Petr Vobornik
comments? Note that there is quite a lot of `api.register(cls)` calls outside of ipalib/plugins dir. IMHO it's OK since it's not a subject of this patch. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman

Re: [Freeipa-devel] [PATCH] 592-628 Update to PatternFly

2014-06-09 Thread Petr Vobornik
On 6.6.2014 20:35, Endi Sukma Dewata wrote: On 6/6/2014 10:43 AM, Petr Vobornik wrote: On 6.6.2014 15:45, Endi Sukma Dewata wrote: On 6/5/2014 9:25 AM, Endi Sukma Dewata wrote: ACK for patches #592-#628. I'll continue reviewing the rest. ACK for patches #633-639, #642, #644, #652, and #653

Re: [Freeipa-devel] Reorganization of Web UI navigation items

2014-06-09 Thread Petr Vobornik
On 9.6.2014 16:42, Simo Sorce wrote: On Mon, 2014-06-09 at 16:08 +0200, Petr Vobornik wrote: Accounts/Identity (7): - Users - Groups - Hosts - Host Groups - Netgroups - Services - Automember ^ These are all identity or identity-grouping related objects/actions +1 What are the chances

Re: [Freeipa-devel] [PATCH] 592-628 Update to PatternFly

2014-06-06 Thread Petr Vobornik
with the Service page. 22. The add dialog for RADIUS Server uses a field label Secret. Everywhere else in the RADIUS Server page it's called Password (e.g. Verify Password, Reset Password). -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] Reorganization of Web UI navigation items

2014-06-04 Thread Petr Vobornik
topology could be here because it configures the tool and not the data, similar to other items under this category. But I think that many users would try to find it in infrastructure. - Global - Access Control (RBAC) - Realm Domains - ID Ranges -- Petr Vobornik

<    5   6   7   8   9   10   11   12   13   14   >