gged. Other than that, the changes look good to me.
Regards,
--
Tomas Hozza
Senior Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
UTC+1 (CET)
Red Hat Inc. http://cz.redhat.com
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo
configure forward
zone and you have global forwarding turned off. In case you configure a forward
zone with forward "only" and it conflicts with an empty zone, you can get
SERVFAIL from the server for hostname from such zone. It is reproducible only
if you are quick enough. The next qu
how_bug.cgi?id=20144
>
ACK.
I was not able to reproduce the issues. However the changes look good to me. I
tested the plugin on Fedora 24 with basic tasks (query, zone transfer, DNS
update) without DNSSEC signing.
Regards,
--
Tomas Hozza
Senior Software Engineer - EMEA ENG Developer Experience
PGP
/pspacek/bind-dyndb-ldap/commits/atomic_to_refcnt
Thank you for review!
I did formal review of patches 384 and 385. The fixed version looks good.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
--
Manage your
On 08.06.2015 14:08, Petr Spacek wrote:
Hello,
Fix metadb_iterator_destroy() to accept NULL iterators.
This prevents potential crash in error handling, e.g. if memory
allocation failed.
Hi.
I did formal review. The patch looks good.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA
as LDAP URI to
/etc/named.conf and then simulate changes by killing and restarting socat.
Let me know if you need any assistance!
Hi.
I did a formal review of the code. Everything looks good.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat
set depends on 'metadb' branch. It is also available from:
https://github.com/pspacek/bind-dyndb-ldap/tree/modrdn
Thank you for your time!
I did formal review. Everything looks OK.
ACK
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc
On 05/21/2015 12:42 PM, Petr Spacek wrote:
Hello,
Add schema for unknown record types.
This patch complements my previous patch 367.
The change was pushed to
https://github.com/pspacek/bind-dyndb-ldap/tree/unknown_record_types , too.
ACK
Tomas
--
Tomas Hozza
Software Engineer
NULL pointers in second
iteration of while loops.
I did only formal review. Didn't find any issues.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
--
Manage your subscription for the Freeipa-devel mailing list
... It compiled, functional testing done by others.
ACK
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com
/blob/d616021d6665ebab97035efb687a88a4a139f636/src/ldap_helper.c#L4038
Other than that, patches look good. I tested them and reviewed from
https://github.com/pspacek/bind-dyndb-ldap/commits/t155.syncptr
ACK with the fix for unused variable.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG
On 02/24/2015 03:01 PM, Petr Spacek wrote:
Hello,
On 18.2.2015 10:36, Tomas Hozza wrote:
On 12/16/2014 04:32 PM, Petr Spacek wrote:
Hello,
Fix crash triggered by zone objects with unexpected DN.
https://fedorahosted.org/bind-dyndb-ldap/ticket/148
NACK.
The patch seems
0x720a7f3b in ldap_syncrepl_watcher (arg=0x77fa3160) at
ldap_helper.c:5247
#9 0x75dda52a in start_thread (arg=0x7fffea7cd700) at
pthread_create.c:310
#10 0x7508d79d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109
--
Tomas Hozza
Software Engineer - EMEA ENG
,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
dynamic updates work.
I did not test other features yet.
ACK.
The driver compiles with BIND 9.10 and works with IPA. I tested basic usage.
BTW available in COPR:
http://copr-fe.cloud.fedoraproject.org/coprs/thozza/bind-9.10/
Tomas
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
. Works for me...
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
into account during libdns version check so it actually did not
work at all :-)
Please review it (and send me a modified patch if you see a problem).
Thank you for your time!
ACK.
No need to export CPPFLAGS any more!
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP
warning there.
ACK.
Works for me, too.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman
On 11/07/2014 01:33 PM, Petr Spacek wrote:
Hello,
Improve info messages about number of defined/loaded zones.
ACK.
The new message looks good.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
.
The patch looks good.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa
work even without explicit CFLAGS and it
should also detect that bind-devel or bind-lite-devel packages are missing.
Works for me
ACK.
Works for me, too.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
it prints message:
forward zone 'fw.example.com': loaded
Log looks better now, ACK if Tomas has no objections.
ACK.
Looks good.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
to determine if network-provided DNS
forwarders are DNSSEC enabled before configuring unbound server.
Therefore I agree with the idea, however it is up to IPA developers
how they end up implementing the probing.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP
On 09/17/2014 01:33 PM, Petr Spacek wrote:
Hello,
Add log message about initial LDAP synchronization.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
and Martin, please communicate who is going to review what :-)
Thank you for your time!
The code seems to be fine.
ACK.
Regards,
- --
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
-BEGIN PGP
On Thu 18 Sep 2014 08:49:05 AM CEST, Petr Spacek wrote:
On 17.9.2014 20:04, Tomas Hozza wrote:
On Tue 16 Sep 2014 07:32:39 PM CEST, Petr Spacek wrote:
Hello,
attached patches fix
https://bugzilla.redhat.com/show_bug.cgi?id=1142150
https://bugzilla.redhat.com/show_bug.cgi?id=1142152
);
dns_dyndb_set_task(args, NULL);
dns_dyndb_set_timermgr(args, NULL);
isc_mem_put(mctx, args, sizeof(*args));
+
+ *argsp = NULL;
}
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
- Original Message -
On 28.5.2014 13:26, Tomas Hozza wrote:
On 05/27/2014 03:59 PM, Petr Spacek wrote:
On 27.5.2014 15:54, Petr Spacek wrote:
Fix race condition during zone loading.
DNS zone has to be added to DNS view before dns_zone_load() is called.
It is necessary
://fedorahosted.org/bind-dyndb-ldap/ticket/56
--
Petr^2 Spacek
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
___
Freeipa-devel mailing list
,
Fix run-time zone addition for secure zones.
Here comes fix for the fix ...
We really need a test-suite for bind-dyndb-ldap.
https://fedorahosted.org/bind-dyndb-ldap/ticket/56
--
Petr^2 Spacek
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
- Original Message -
Hello,
Add wrappers for isc_task_*exclusive().
This patch replaces scattered isc_task_* calls and associated locking to one
place. It helps with debugging sometimes.
--
Petr^2 Spacek
Looks good.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA
- Original Message -
Hello,
This patch set allows you to change DNSSEC zone configuration at run-time.
--
Petr^2 Spacek
Looks good.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http
to LDAP. This write generates LDAP modify event which
again triggers ldap_parse_master_zoneentry() and so on.
https://fedorahosted.org/bind-dyndb-ldap/ticket/56
--
Petr^2 Spacek
Looks good.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat
Spacek
Looks good.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https
On 05/27/2014 03:59 PM, Petr Spacek wrote:
On 27.5.2014 15:54, Petr Spacek wrote:
Fix race condition during zone loading.
DNS zone has to be added to DNS view before dns_zone_load() is called.
It is necessary to prevent dns_zone_load() from racing with
dns_zone_setview().
This race
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 05/21/2014 11:33 AM, Petr Spacek wrote:
On 7.5.2014 15:27, Petr Spacek wrote:
On 29.4.2014 23:34, Petr Spacek wrote:
This patch set adds support for NSEC3. See commit messages for details.
Patch 253 was obsoleted by patches 244v2 and 246v2.
needn't be exported.
LS
ACK.
Works like a charm... Thanks!
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
___
Freeipa-devel mailing list
242 will follow. The patch 243 introduced new
compilation
warning that Peter is aware of. Unfortunately we are unable to find the root
cause of it,
so leaving it as is for now...
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc
-Refactor-master-zone-configuration.patch fixes
zone loading for zones without idnsAllowTransfer attribute in LDAP.
Previously, the plugin refused to load such zones with error ISC_R_NOTFOUND -
missing attribute was treated as fatal error.
--
Petr^2 Spacek
ACK.
Regards,
--
Tomas Hozza
encountered
it during work on new DNSSEC code ...
--
Petr^2 Spacek
Looks good.
ACK.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
___
Freeipa
- Original Message -
Hello,
Handle paths without trailing / in fs_dirs_create().
This patch should go to all branches with fs_dirs_create() function.
--
Petr^2 Spacek
Looks good.
ACK
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
- Original Message -
Hello,
Update .gitignore to skip Eclipse and Autotools files.
--
Petr^2 Spacek
ACK
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
by update_records()
instead of delegation records in the parent zone.
https://fedorahosted.org/bind-dyndb-ldap/ticket/134
ACK
Solves the problem described in the ticket.
Regards,
Tomas Hozza
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net
.
Sometimes it shutdowns cleanly and sometimes you can see a crash:
Thank you for your time!
ACK.
I'm not able to reproduce the issue, but the patch looks reasonable and
should not break anything.
Regards,
Tomas Hozza
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Peter.
See comments below...
On 02/21/2014 10:46 AM, Petr Spacek wrote:
Hello list,
I want to release bind-dyndb-ldap 4.0 to Fedora 20+ but I have found that we
need to enable SELinux boolean named_write_master_zones otherwise the plugin
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/21/2014 12:10 PM, Petr Spacek wrote:
On 21.2.2014 11:05, Tomas Hozza wrote:
On 02/21/2014 10:46 AM, Petr Spacek wrote:
I want to release bind-dyndb-ldap 4.0 to Fedora 20+ but I have found
that we
need to enable SELinux boolean
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/21/2014 12:54 PM, Tomas Hozza wrote:
On 02/21/2014 12:10 PM, Petr Spacek wrote:
On 21.2.2014 11:05, Tomas Hozza wrote:
On 02/21/2014 10:46 AM, Petr Spacek wrote:
I want to release bind-dyndb-ldap 4.0 to Fedora 20+ but I have found
that we
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/21/2014 01:37 PM, Petr Spacek wrote:
On 21.2.2014 13:02, Tomas Hozza wrote:
On 02/21/2014 12:54 PM, Tomas Hozza wrote:
On 02/21/2014 12:10 PM, Petr Spacek wrote:
On 21.2.2014 11:05, Tomas Hozza wrote:
On 02/21/2014 10:46 AM, Petr Spacek
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/18/2014 10:34 AM, Petr Spacek wrote:
ewer GCC complains that I didn't check return value from getcwd() ...
Hi.
I reviewed all patches from PATCH 0181 to the latest one PATCH 0221
and tested the bind-dyndb-ldap on Fedora 20 (adding/removing
/2008/07/18/reading-c-type-declarations/
Simple patch is attached.
LS
ACK.
Looks good.
Regards,
Tomas Hozza
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJS2UbdAAoJEMWIetUdnzwtqKIIAKEnhrYiT85yvGYkMVUjGZ5Y
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/11/2013 12:53 PM, Petr Spacek wrote:
Hello,
Remove obsolete zr_get_rbt() function from zone register.
ACK.
Patch looks good.
Regards,
Tomas Hozza
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird
- Original Message -
Hello,
Improve performance of initial LDAP synchronization.
Changes are not journaled and SOA serial is not incremented during initial
LDAP synchronization.
This eliminates unnecessary synchronous writes to journal and also
unnecessary SOA serial writes to
server?
ACK.
Patch works and looks good.
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 10/10/2013 06:58 PM, Petr Spacek wrote:
On 8.10.2013 12:00, Tomas Hozza wrote:
On 10/02/2013 12:57 PM, Petr Spacek wrote:
On 13.9.2013 15:31, Petr Spacek wrote:
On 14.8.2013 16:42, Petr Spacek wrote:
On 14.8.2013 16:25, Petr Spacek wrote:
On 1.8.2013 15:57, Petr Spacek wrote:
Hello
On 10/10/2013 07:05 PM, Petr Spacek wrote:
Hello,
this patch set adds journaling to bind-dyndb-ldap.
Journaling requires proper SOA serial maintenance, so from now
SOA serial auto-incrementation is mandatory.
Journal file is deleted on each start, so IXFR is limited to time frame
from
On 10/11/2013 03:35 PM, Petr Spacek wrote:
Hello,
update documentation and schema files for upcoming version 4.0.
This fixes typo in schema file:
https://fedorahosted.org/bind-dyndb-ldap/ticket/121
Have a nice weekend!
ACK.
Looks good.
Regards,
Tomas
On 10/02/2013 12:57 PM, Petr Spacek wrote:
On 13.9.2013 15:31, Petr Spacek wrote:
On 14.8.2013 16:42, Petr Spacek wrote:
On 14.8.2013 16:25, Petr Spacek wrote:
On 1.8.2013 15:57, Petr Spacek wrote:
Hello,
attached monster patches replace our internal cache/database with
RBTDB
On 08/01/2013 03:48 PM, Petr Spacek wrote:
Hello,
Fix false error messages when nonexistent object/attribute is deleted.
This patch should go to branches v3 and master.
ACK.
Tested Patch bundle 181 - 185. Common tasks like
adding/deleting/updating records work fine. Also PTR sync,
On 07/22/2013 03:16 PM, Petr Spacek wrote:
On 22.7.2013 13:23, Petr Spacek wrote:
Hello,
Replace LDAP persistent search with syncrepl (RFC 4533).
All direct operations with LDAP Persistent Search control are replaced
by ldap_sync_* calls.
Syncrepl code works in exactly same way as old
On 08/01/2013 03:49 PM, Petr Spacek wrote:
Hello,
Move data structures for parser from ldap_qresult_t to ldap_entry_t.
The target branch is master.
ACK.
Tested Patch bundle 181 - 185. Common tasks like
adding/deleting/updating records work fine. Also PTR sync, zone serial
number
On 08/01/2013 03:51 PM, Petr Spacek wrote:
Hello,
Use DNS_RDATA_MAXLENGTH from rdata.h instead of own definition.
This minor fix could go to v3 and master.
ACK.
Tested Patch bundle 181 - 185. Common tasks like
adding/deleting/updating records work fine. Also PTR sync, zone serial
On 08/01/2013 03:52 PM, Petr Spacek wrote:
Hello,
Do not execute new LDAP search for each updated object.
Syncrepl delivers notification about change in particular object
along with all data from the object. Resource Records are parsed out
from this data instead of data obtained via
On 09/26/2013 03:11 PM, Petr Spacek wrote:
Hello,
attached patch prevents/hides deadlock in plugin versions versions = 2.x.
I plan to push it to v2 branch. Branches v3 and newer shouldn't be
affected.
https://fedorahosted.org/bind-dyndb-ldap/ticket/113
ACK.
I tested the patch with:
On 07/22/2013 01:23 PM, Petr Spacek wrote:
Hello,
Remove support for zone_refresh mode and options cache_ttl and psearch.
All three options are ignored and persistent search is always enabled.
ACK.
Looks good and plugin works well with the change.
Anyway I think it would be good to
,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 07/16/2013 10:04 AM, Petr Spacek wrote:
Hello,
this patch set changes default configuration to 'psearch yes' and
changes README and informational messages accordingly.
ACK.
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel
On 07/16/2013 10:13 AM, Petr Spacek wrote:
Hello,
I plan to release 3.5 as soon as all previous patches are ACKed.
ACK.
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa
On 07/11/2013 12:24 PM, Petr Spacek wrote:
Hello,
Improve logging for cases where SOA serial autoincrementation failed.
ACK
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo
/automake/2012-05/msg00014.html
Thank you for catching this. Fixed patch is attached.
ACK
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 07/08/2013 10:51 AM, Petr Spacek wrote:
Hello,
several warnings from Clang static analyzer popped up after upgrade to
Fedora 19. Attached patches should fix all problems found by
clang-analyzer-3.3-0.6.rc3.fc19.x86_64.
ACK
Regards,
Tomas Hozza
ACK.
Works as expected.
Regards,
Tomas Hozza
- Original Message -
Hello,
Fix crash caused by race-condition between shutdown and update processing.
Variable 'name' was uninitialized when manager_get_ldap_instance() returned
ISC_R_NOTFOUND. The successive call
ACK
The patch looks good.
Regards,
Tomas Hozza
- Original Message -
Hello,
Fix minor coding style issue in update_config().
--
Petr^2 Spacek
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman
ACK.
The change looks reasonable and I'm not able to come up with
a better macro name... :)
Regards,
Tomas Hozza
- Original Message -
Hello,
Mark function arguments with __attribute__((nonnull)) when appropriate.
This patch prevents bugs like
https://git.fedorahosted.org/cgit
ACK
Works as expected.
Regards,
Tomas Hozza
- Original Message -
Hello,
Fix crash triggered by missing sasl_user parameter.
--
Petr^2 Spacek
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman
ACK.
Works OK.
Regards,
Tomas Hozza
- Original Message -
Hello,
Validate authentication settings strictly.
- auth_method 'SASL' do not accept bind_dn and password options
- auth_method 'simple' do not accept sasl_* and krb5_* options
- auth_method 'none' do not accept any
ACK.
Looks good.
Regards,
Tomas Hozza
- Original Message -
On 28.5.2013 15:55, Petr Spacek wrote:
Hello,
Deprecate configuration without persistent search.
https://fedorahosted.org/bind-dyndb-ldap/ticket/120
This version of the patch adds notice to the README.
--
Petr
ACK.
Patches look good and work as expected!
Regards,
Tomas Hozza
- Original Message -
Hello,
this patch set enables bind-dyndb-ldap to automatically unload empty zone
(see
RFC 6303) if an explicit configuration for this zone is present in LDAP.
Please test it with idnsZone
ACK
The patch looks good and works as expected.
Regards,
Tomas Hozza
- Original Message -
Hello,
Fix IPv6 handling in PTR record synchronization.
https://fedorahosted.org/bind-dyndb-ldap/ticket/118
--
Petr^2 Spacek
___
Freeipa
reasonable. (I didn't do functional test)
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
be good to explicitly return SERVFAIL also if dynamic
updates in PTR zone are disabled and modify the commit message to
better express what this patch does.
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com
,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 04/18/2013 04:58 PM, Petr Spacek wrote:
Hello,
Do not delete whole node during PTR record synchronization.
https://fedorahosted.org/bind-dyndb-ldap/ticket/115
ACK.
The patch looks good.
Regards,
Tomas Hozza
___
Freeipa-devel mailing
ACK.
Patch looks OK!
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
char *format, ...) ISC_FORMAT_PRINTF(2, 3);
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 04/16/2013 10:40 AM, Petr Spacek wrote:
Hello,
Disallow all dynamic updates if update policy configuration failed.
Without this patch the old update policy stays in effect
when re-configuration failed.
ACK.
The patch looks good. (I didn't do functional test)
Regards,
Tomas Hozza
memory freeing in
free_ldapmod() function. Now one has to be be careful when it is
statically or dynamically allocated. Before it was static in every case.
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com
reasoning. There is also
an error logged when the TTL has MSB set, so one can notice there is a bad
TTL value set in LDAP.
Regards,
Tomas Hozza
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
87 matches
Mail list logo
