Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-16 Thread Martin Basti
On 09/15/2015 11:18 AM, Milan Kubík wrote: On 09/14/2015 05:47 PM, Martin Basti wrote: On 09/14/2015 01:49 PM, Lenka Doudova wrote: All good, ACK On 09/14/2015 11:54 AM, Milan Kubík wrote: On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-15 Thread Milan Kubík
On 09/14/2015 05:47 PM, Martin Basti wrote: On 09/14/2015 01:49 PM, Lenka Doudova wrote: All good, ACK On 09/14/2015 11:54 AM, Milan Kubík wrote: On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Lenka Doudova
All good, ACK On 09/14/2015 11:54 AM, Milan Kubík wrote: On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc/test_certprofile_plugin.py:213:8: E121 continuation line under-indented for hanging indent (just a

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Martin Basti
On 09/14/2015 01:49 PM, Lenka Doudova wrote: All good, ACK On 09/14/2015 11:54 AM, Milan Kubík wrote: On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc/test_certprofile_plugin.py:213:8: E121 continuation

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Lenka Doudova
NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc/test_certprofile_plugin.py:213:8: E121 continuation line under-indented for hanging indent (just a missing space in the indent) Lenka On 09/11/2015 01:47 PM, Milan Kubík wrote: On 09/11/2015 12:43 PM,

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Milan Kubík
On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc/test_certprofile_plugin.py:213:8: E121 continuation line under-indented for hanging indent (just a missing space in the indent) Lenka On 09/11/2015 01:47

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Lenka Doudova
On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm running it through lite-server, so here's the traceback from there:

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Martin Basti
On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm running it through lite-server, so here's

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Milan Kubík
On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Milan Kubík
On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Milan Kubík
On 09/11/2015 12:43 PM, Lenka Doudova wrote: On 09/11/2015 11:45 AM, Milan Kubík wrote: On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Lenka Doudova
On 09/11/2015 11:45 AM, Milan Kubík wrote: On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-10 Thread Milan Kubík
On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm running it through lite-server, so here's the traceback from there: http://pastebin.test.redhat.com/310598 I can't really get to the

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-04 Thread Lenka Doudova
Hi, there's no traceback in the file you mentioned, but I'm running it through lite-server, so here's the traceback from there: http://pastebin.test.redhat.com/310598 I can't really get to the problem. What I forgot to mention in the previous email was that the tests fail when attempting to

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-04 Thread Martin Babinsky
On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm running it through lite-server, so here's the traceback from there: http://pastebin.test.redhat.com/310598 I can't really get to the problem. What I forgot to mention in the previous email

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-03 Thread Lenka Doudova
Hi, I took a look at it at Milan's request. patch 0008 - tracker looks ok, ACK patch 0009 - test cases look ok as well, but can't get it to run, 10 out of 14 tests fail, starting with internal error, which I haven't been able to track down, nor fix it. Lenka

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-03 Thread Tomas Babej
On 09/03/2015 01:40 PM, Lenka Doudova wrote: > Hi, > > I took a look at it at Milan's request. > > patch 0008 - tracker looks ok, ACK > patch 0009 - test cases look ok as well, but can't get it to run, 10 out > of 14 tests fail, starting with internal error, which I haven't been > able to

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-03 Thread Martin Basti
On 09/03/2015 01:40 PM, Lenka Doudova wrote: Hi, I took a look at it at Milan's request. patch 0008 - tracker looks ok, ACK patch 0009 - test cases look ok as well, but can't get it to run, 10 out of 14 tests fail, starting with internal error, which I haven't been able to track down, nor

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-31 Thread Martin Basti
On 08/18/2015 04:06 PM, Milan Kubík wrote: On 08/11/2015 03:17 AM, Fraser Tweedale wrote: On Mon, Aug 10, 2015 at 11:36:31AM +0200, Milan Kubík wrote: On 08/05/2015 02:57 PM, Milan Kubík wrote: Hi list, I'm sending the test plan [1] for certificate profiles and preliminary patches for it.

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-31 Thread Fraser Tweedale
On Mon, Aug 31, 2015 at 12:24:13PM +0200, Martin Basti wrote: > > > On 08/18/2015 04:06 PM, Milan Kubík wrote: > >On 08/11/2015 03:17 AM, Fraser Tweedale wrote: > >>On Mon, Aug 10, 2015 at 11:36:31AM +0200, Milan Kubík wrote: > >>>On 08/05/2015 02:57 PM, Milan Kubík wrote: > Hi list, >

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-18 Thread Milan Kubík
On 08/11/2015 03:17 AM, Fraser Tweedale wrote: On Mon, Aug 10, 2015 at 11:36:31AM +0200, Milan Kubík wrote: On 08/05/2015 02:57 PM, Milan Kubík wrote: Hi list, I'm sending the test plan [1] for certificate profiles and preliminary patches for it. The plan covers basic CRUD test and some

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-10 Thread Milan Kubík
Hi, On 08/10/2015 05:24 PM, Scott Poore wrote: - Original Message - From: Milan Kubík mku...@redhat.com To: freeipa-devel freeipa-devel@redhat.com, Scott Poore spo...@redhat.com, Fraser Tweedale ftwee...@redhat.com Cc: Namita Soman nso...@redhat.com, Ales Marecek amare...@redhat.com

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-10 Thread Kaleemullah Siddiqui
On 08/10/2015 08:54 PM, Scott Poore wrote: - Original Message - From: Milan Kubík mku...@redhat.com To: freeipa-devel freeipa-devel@redhat.com, Scott Poore spo...@redhat.com, Fraser Tweedale ftwee...@redhat.com Cc: Namita Soman nso...@redhat.com, Ales Marecek amare...@redhat.com

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-10 Thread Scott Poore
- Original Message - From: Milan Kubík mku...@redhat.com To: freeipa-devel freeipa-devel@redhat.com, Scott Poore spo...@redhat.com, Fraser Tweedale ftwee...@redhat.com Cc: Namita Soman nso...@redhat.com, Ales Marecek amare...@redhat.com Sent: Monday, August 10, 2015 4:36:31 AM

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-10 Thread Fraser Tweedale
On Mon, Aug 10, 2015 at 06:50:57PM +0200, Milan Kubík wrote: Hi, On 08/10/2015 05:24 PM, Scott Poore wrote: - Original Message - From: Milan Kubík mku...@redhat.com To: freeipa-devel freeipa-devel@redhat.com, Scott Poore spo...@redhat.com, Fraser Tweedale ftwee...@redhat.com

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-10 Thread Fraser Tweedale
On Mon, Aug 10, 2015 at 11:36:31AM +0200, Milan Kubík wrote: On 08/05/2015 02:57 PM, Milan Kubík wrote: Hi list, I'm sending the test plan [1] for certificate profiles and preliminary patches for it. The plan covers basic CRUD test and some corner cases. I'm open to more suggestions.

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-10 Thread Milan Kubík
On 08/05/2015 02:57 PM, Milan Kubík wrote: Hi list, I'm sending the test plan [1] for certificate profiles and preliminary patches for it. The plan covers basic CRUD test and some corner cases. I'm open to more suggestions. More complicated tests involving certificate profiles will require

[Freeipa-devel] cert profiles - test plan + patches

2015-08-05 Thread Milan Kubík
Hi list, I'm sending the test plan [1] for certificate profiles and preliminary patches for it. The plan covers basic CRUD test and some corner cases. I'm open to more suggestions. More complicated tests involving certificate profiles will require the code (and tests) for CA ACLs merged, so