Re: [Freeipa-devel] [PATCH] 0009 Detect and configure all usable IP addresses.

2014-09-25 Thread David Kupka
On 09/25/2014 04:17 PM, David Kupka wrote: On 09/24/2014 08:54 PM, Martin Basti wrote: On 24/09/14 15:44, David Kupka wrote: On 09/23/2014 08:25 PM, Martin Basti wrote: On 23/09/14 13:23, David Kupka wrote: On 09/18/2014 06:34 PM, Martin Basti wrote: ... 1) +if options.unattended: +

Re: [Freeipa-devel] [PATCH] 755 webui-ci: case-insensitive record check

2014-09-25 Thread Fraser Tweedale
On Thu, Sep 25, 2014 at 09:44:03AM +0200, Petr Viktorin wrote: > On 09/25/2014 03:30 AM, Fraser Tweedale wrote: > >On Wed, Sep 24, 2014 at 09:16:52AM -0500, Endi Sukma Dewata wrote: > >>On 9/24/2014 8:26 AM, Petr Vobornik wrote: > >>>On 24.9.2014 04:43, Endi Sukma Dewata wrote: > On 9/22/2014 9

Re: [Freeipa-devel] [PATCH] 749-754 webui: new ID views section

2014-09-25 Thread Petr Vobornik
All issues will be done separately as already stated in other sub-thread. I've removed issues which are discussed in the other sub-thread. On 25.9.2014 09:25, Alexander Bokovoy wrote: On Wed, 24 Sep 2014, Endi Sukma Dewata wrote: OK, some comments/questions: 1. For consistency, the "ID view"

Re: [Freeipa-devel] [PATCH] 749-754 webui: new ID views section

2014-09-25 Thread Endi Sukma Dewata
On 9/25/2014 10:23 AM, Petr Vobornik wrote: On 25.9.2014 16:40, Endi Sukma Dewata wrote: 4. If I understand correctly the description field for the User ID Overrides and Group ID Overrides should be optional too because it's also used to optionally override the description attribute of the origi

Re: [Freeipa-devel] [PATCH] 749-754 webui: new ID views section

2014-09-25 Thread Petr Vobornik
Note: I'll send response also to previous mail. On 25.9.2014 16:40, Endi Sukma Dewata wrote: On 9/25/2014 2:25 AM, Alexander Bokovoy wrote: On Wed, 24 Sep 2014, Endi Sukma Dewata wrote: 4. If I understand correctly the description field for the User ID Overrides and Group ID Overrides should b

Re: [Freeipa-devel] [PATCHES 0114-0115] DNS: allow to add root zone '.'

2014-09-25 Thread Martin Kosek
On 09/25/2014 04:39 PM, Petr Viktorin wrote: > On 09/25/2014 04:32 PM, Petr Spacek wrote: >> On 25.9.2014 10:31, Martin Basti wrote: >>> On 24/09/14 16:24, Martin Basti wrote: On 24/09/14 16:05, Martin Basti wrote: > On 23/09/14 17:45, Petr Vobornik wrote: >> On 25.8.2014 14:52, Martin

Re: [Freeipa-devel] [PATCH 0118] Allow to disable service (in LDAP)

2014-09-25 Thread Jan Cholasta
Dne 25.9.2014 v 16:15 Martin Basti napsal(a): On 22/09/14 19:30, Martin Basti wrote: On 19/09/14 14:47, Jan Cholasta wrote: Dne 19.9.2014 v 13:33 Martin Basti napsal(a): On 02/09/14 11:59, Martin Basti wrote: On 02/09/14 09:10, Jan Cholasta wrote: Hi, Dne 1.9.2014 v 16:57 Martin Basti napsa

Re: [Freeipa-devel] [PATCH] 749-754 webui: new ID views section

2014-09-25 Thread Endi Sukma Dewata
On 9/25/2014 2:25 AM, Alexander Bokovoy wrote: On Wed, 24 Sep 2014, Endi Sukma Dewata wrote: 4. If I understand correctly the description field for the User ID Overrides and Group ID Overrides should be optional too because it's also used to optionally override the description attribute of the o

Re: [Freeipa-devel] [PATCHES 0114-0115] DNS: allow to add root zone '.'

2014-09-25 Thread Petr Viktorin
On 09/25/2014 04:32 PM, Petr Spacek wrote: On 25.9.2014 10:31, Martin Basti wrote: On 24/09/14 16:24, Martin Basti wrote: On 24/09/14 16:05, Martin Basti wrote: On 23/09/14 17:45, Petr Vobornik wrote: On 25.8.2014 14:52, Martin Basti wrote: Patches attached. Ticket: https://fedorahosted.org

Re: [Freeipa-devel] [PATCHES 0114-0115] DNS: allow to add root zone '.'

2014-09-25 Thread Petr Spacek
On 25.9.2014 10:31, Martin Basti wrote: On 24/09/14 16:24, Martin Basti wrote: On 24/09/14 16:05, Martin Basti wrote: On 23/09/14 17:45, Petr Vobornik wrote: On 25.8.2014 14:52, Martin Basti wrote: Patches attached. Ticket: https://fedorahosted.org/freeipa/ticket/4149 There is a bug in bind

Re: [Freeipa-devel] [PATCH] 0009 Detect and configure all usable IP addresses.

2014-09-25 Thread David Kupka
On 09/24/2014 08:54 PM, Martin Basti wrote: On 24/09/14 15:44, David Kupka wrote: On 09/23/2014 08:25 PM, Martin Basti wrote: On 23/09/14 13:23, David Kupka wrote: On 09/18/2014 06:34 PM, Martin Basti wrote: ... 1) +if options.unattended: +for ip in ip_addresses: +

Re: [Freeipa-devel] [PATCH 0118] Allow to disable service (in LDAP)

2014-09-25 Thread Martin Basti
On 22/09/14 19:30, Martin Basti wrote: On 19/09/14 14:47, Jan Cholasta wrote: Dne 19.9.2014 v 13:33 Martin Basti napsal(a): On 02/09/14 11:59, Martin Basti wrote: On 02/09/14 09:10, Jan Cholasta wrote: Hi, Dne 1.9.2014 v 16:57 Martin Basti napsal(a): This patch allows to disable service in L

Re: [Freeipa-devel] [PATCH] 0645 ipa-replica-prepare: Wait for the DNS entry to be resolvable

2014-09-25 Thread Petr Viktorin
On 09/25/2014 03:23 PM, Petr Spacek wrote: On 25.9.2014 14:56, Petr Viktorin wrote: On 09/24/2014 02:07 PM, Petr Viktorin wrote: On 09/24/2014 01:54 PM, Petr Spacek wrote: On 24.9.2014 13:47, Petr Viktorin wrote: On 09/23/2014 06:00 PM, Petr Spacek wrote: On 22.9.2014 14:09, Petr Viktorin wr

Re: [Freeipa-devel] [PATCH] 0645 ipa-replica-prepare: Wait for the DNS entry to be resolvable

2014-09-25 Thread Petr Spacek
On 25.9.2014 14:56, Petr Viktorin wrote: On 09/24/2014 02:07 PM, Petr Viktorin wrote: On 09/24/2014 01:54 PM, Petr Spacek wrote: On 24.9.2014 13:47, Petr Viktorin wrote: On 09/23/2014 06:00 PM, Petr Spacek wrote: On 22.9.2014 14:09, Petr Viktorin wrote: On 09/22/2014 01:48 PM, Petr Spacek wr

Re: [Freeipa-devel] [PATCHES 0114-0115] DNS: allow to add root zone '.'

2014-09-25 Thread Martin Basti
On 25/09/14 14:56, Petr Vobornik wrote: Ticket: https://fedorahosted.org/freeipa/ticket/4149 5. You've removed 'idnssoamname' and 'force' from Web UI but dnszone-add precallback still uses these params. What is the intended purpose? User should use modify dialog in webUI for zones. Precallb

Re: [Freeipa-devel] [PATCH 0068] Move OTP synchronization step to after counter writeback

2014-09-25 Thread thierry bordaz
On 09/19/2014 07:53 PM, Nathaniel McCallum wrote: This prevents synchronization when an authentication collision occurs. https://fedorahosted.org/freeipa/ticket/4493 NOTE: this patch is related to the above ticket, but does not solve it. For the solution, please see patch 0064. This behavior fi

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-25 Thread Martin Basti
On 25/09/14 14:47, Jan Cholasta wrote: Dne 25.9.2014 v 10:51 Martin Basti napsal(a): On 19/09/14 14:30, Jan Cholasta wrote: Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti naps

Re: [Freeipa-devel] [PATCHES 0114-0115] DNS: allow to add root zone '.'

2014-09-25 Thread Petr Vobornik
Ticket: https://fedorahosted.org/freeipa/ticket/4149 5. You've removed 'idnssoamname' and 'force' from Web UI but dnszone-add precallback still uses these params. What is the intended purpose? User should use modify dialog in webUI for zones. Precallback fills default value for idnsmname fro

Re: [Freeipa-devel] [PATCH] 0645 ipa-replica-prepare: Wait for the DNS entry to be resolvable

2014-09-25 Thread Petr Viktorin
On 09/24/2014 02:07 PM, Petr Viktorin wrote: On 09/24/2014 01:54 PM, Petr Spacek wrote: On 24.9.2014 13:47, Petr Viktorin wrote: On 09/23/2014 06:00 PM, Petr Spacek wrote: On 22.9.2014 14:09, Petr Viktorin wrote: On 09/22/2014 01:48 PM, Petr Spacek wrote: On 22.9.2014 10:38, Martin Kosek wro

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-25 Thread Jan Cholasta
Dne 25.9.2014 v 10:51 Martin Basti napsal(a): On 19/09/14 14:30, Jan Cholasta wrote: Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please ren

Re: [Freeipa-devel] [PATCH 130] extdom: add support for new version

2014-09-25 Thread Sumit Bose
On Wed, Sep 24, 2014 at 03:23:54PM +0200, Jakub Hrozek wrote: > On Tue, Sep 23, 2014 at 05:11:01PM +0200, Sumit Bose wrote: > > Hi, > > > > this patch should fix https://fedorahosted.org/freeipa/ticket/4031 and > > with the corresponding SSSD part it would be possible to get the full > > list of g

Re: [Freeipa-devel] [PATCH 0067] Use stack allocation when writing values during otp auth

2014-09-25 Thread thierry bordaz
On 09/19/2014 07:49 PM, Nathaniel McCallum wrote: This is an optimization from patch 0062 (rescinded) which I think is worth keeping. There is no ticket for this. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/l

Re: [Freeipa-devel] [PATCH] 0637 upgradeinstance: Restore listeners on failure

2014-09-25 Thread Martin Kosek
On 09/24/2014 10:43 AM, Martin Kosek wrote: > On 08/22/2014 06:07 PM, Petr Viktorin wrote: >> https://fedorahosted.org/freeipa/ticket/4499 >> >> Actually I wonder why we use backup_state/restore_state for these settings. >> Rob, was there a reason for not just always setting nsslapd-port: 389 and >

Re: [Freeipa-devel] [PATCH] 0647 test_permission_plugin: Check legacy permissions

2014-09-25 Thread Martin Kosek
On 09/19/2014 08:31 PM, Petr Viktorin wrote: > This has been wrong for some time, now I got around to fixing it properly. > It should go to all branches (4.0, 4.1, master). Thank you! This should make our unit tests more stable :-) Worked fine, ACK. Pushed to: master: f3b1471af946c7231447b36ea41

Re: [Freeipa-devel] [PATCH] 0105 FIX: LDAP_updater

2014-09-25 Thread Petr Viktorin
On 09/25/2014 12:13 PM, Petr Spacek wrote: On 24.9.2014 12:06, Petr Viktorin wrote: On 09/23/2014 02:51 PM, Martin Basti wrote: On 22/09/14 14:04, Petr Viktorin wrote: On 09/01/2014 04:31 PM, Martin Basti wrote: On 24/07/14 09:06, Martin Basti wrote: On 23/07/14 15:17, Martin Basti wrote: T

Re: [Freeipa-devel] [PATCH] 0105 FIX: LDAP_updater

2014-09-25 Thread Martin Kosek
On 09/25/2014 12:13 PM, Petr Spacek wrote: > On 24.9.2014 12:06, Petr Viktorin wrote: >> On 09/23/2014 02:51 PM, Martin Basti wrote: >>> On 22/09/14 14:04, Petr Viktorin wrote: On 09/01/2014 04:31 PM, Martin Basti wrote: > On 24/07/14 09:06, Martin Basti wrote: >> On 23/07/14 15:17, Ma

Re: [Freeipa-devel] FreeIPA on RHEL/CentOS 7.0

2014-09-25 Thread Martin Kosek
On 09/25/2014 11:09 AM, Jan Pazdziora wrote: > On Thu, Sep 25, 2014 at 08:55:46AM +0200, Martin Kosek wrote: >> >>> I'd like to use these yum repos for Docker images and I wonder what >>> naming I should use for the branches and tags -- centos-7-upstream, >>> centos-7-4.0.3, or something else? >> >

Re: [Freeipa-devel] [PATCH] 0105 FIX: LDAP_updater

2014-09-25 Thread Petr Spacek
On 24.9.2014 12:06, Petr Viktorin wrote: On 09/23/2014 02:51 PM, Martin Basti wrote: On 22/09/14 14:04, Petr Viktorin wrote: On 09/01/2014 04:31 PM, Martin Basti wrote: On 24/07/14 09:06, Martin Basti wrote: On 23/07/14 15:17, Martin Basti wrote: This patch fixes ordering problem of schema u

Re: [Freeipa-devel] [PATCH 0126 - 0127] DNS: remove --class option

2014-09-25 Thread Petr Vobornik
On 25.9.2014 11:03, Martin Basti wrote: On 24/09/14 16:07, Martin Basti wrote: I didn't notice, but changes in VERSION is not required anymore. Updated patch attached ACK pushed to master: * 7325983a48c9cf9300d046260c98253b6dae2dbc DNS: remove --class option * 180414d64d992f80e03d0627deff7

Re: [Freeipa-devel] [PATCHES] 0633-0634 Move setting SELinux booleans to platform code; Set SELinux booleans when restoring

2014-09-25 Thread thierry bordaz
On 09/25/2014 10:58 AM, Petr Viktorin wrote: On 09/24/2014 06:02 PM, thierry bordaz wrote: On 08/15/2014 10:40 PM, Petr Viktorin wrote: A fix for https://fedorahosted.org/freeipa/ticket/4157 This depends on my patches 0631-0632 (for backup/restore integration tests). Our setsebool code was r

Re: [Freeipa-devel] FreeIPA on RHEL/CentOS 7.0

2014-09-25 Thread Jan Pazdziora
On Thu, Sep 25, 2014 at 08:55:46AM +0200, Martin Kosek wrote: > > > I'd like to use these yum repos for Docker images and I wonder what > > naming I should use for the branches and tags -- centos-7-upstream, > > centos-7-4.0.3, or something else? > > centos-7-latest (with mkosek/freeipa copr) > c

Re: [Freeipa-devel] [PATCH 0126 - 0127] DNS: remove --class option

2014-09-25 Thread Martin Basti
On 24/09/14 16:07, Martin Basti wrote: On 23/09/14 18:53, Martin Basti wrote: On 23/09/14 18:35, Petr Spacek wrote: On 22.9.2014 19:21, Martin Basti wrote: On 22/09/14 13:17, Petr Vobornik wrote: On 19.9.2014 16:15, Martin Basti wrote: Ticket: https://fedorahosted.org/freeipa/ticket/3414 Pat

Re: [Freeipa-devel] [PATCHES] 0633-0634 Move setting SELinux booleans to platform code; Set SELinux booleans when restoring

2014-09-25 Thread Petr Viktorin
On 09/24/2014 06:02 PM, thierry bordaz wrote: On 08/15/2014 10:40 PM, Petr Viktorin wrote: A fix for https://fedorahosted.org/freeipa/ticket/4157 This depends on my patches 0631-0632 (for backup/restore integration tests). Our setsebool code was repeated a few times. Instead of adding another

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-25 Thread Martin Basti
On 19/09/14 14:30, Jan Cholasta wrote: Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please rename object_exists to entry_exists. 2) Use emp

Re: [Freeipa-devel] [PATCH] 755 webui-ci: case-insensitive record check

2014-09-25 Thread Petr Vobornik
On 24.9.2014 16:16, Endi Sukma Dewata wrote: On 9/24/2014 8:26 AM, Petr Vobornik wrote: On 24.9.2014 04:43, Endi Sukma Dewata wrote: On 9/22/2014 9:49 AM, Petr Vobornik wrote: [PATCH] webui-ci: case-insensitive record check Indirect association are no longer lower cased, which caused a issue

Re: [Freeipa-devel] [PATCH] 756 webui: fix regression in association facet preop

2014-09-25 Thread Petr Vobornik
On 24.9.2014 04:43, Endi Sukma Dewata wrote: On 9/22/2014 9:50 AM, Petr Vobornik wrote: Association facet specs use 'add_method' instead of 'add_command' origin: https://fedorahosted.org/freeipa/ticket/4507 ACK. Pushed to: master: a56c1e58696a2489bf5bf8dd5aca603977c76a1c ipa-4-1: 18cb8d773

Re: [Freeipa-devel] [PATCH 0128] dnszone-remove-permission should raise NotFound if permission doesn't exist

2014-09-25 Thread Martin Basti
On 25/09/14 09:59, Martin Kosek wrote: On 09/24/2014 06:22 PM, Martin Basti wrote: On 24/09/14 17:30, Martin Kosek wrote: On 09/24/2014 04:55 PM, Martin Basti wrote: Patch attached This probably should go to 4.0.x, 4.1 and master It is obvious that this interface was designed this way. So yo

Re: [Freeipa-devel] [PATCH 0128] dnszone-remove-permission should raise NotFound if permission doesn't exist

2014-09-25 Thread Martin Kosek
On 09/24/2014 06:22 PM, Martin Basti wrote: > On 24/09/14 17:30, Martin Kosek wrote: >> On 09/24/2014 04:55 PM, Martin Basti wrote: >>> Patch attached >>> >>> This probably should go to 4.0.x, 4.1 and master >> It is obvious that this interface was designed this way. So you should >> elaborate more

Re: [Freeipa-devel] [PATCH] 755 webui-ci: case-insensitive record check

2014-09-25 Thread Petr Viktorin
On 09/25/2014 03:30 AM, Fraser Tweedale wrote: On Wed, Sep 24, 2014 at 09:16:52AM -0500, Endi Sukma Dewata wrote: On 9/24/2014 8:26 AM, Petr Vobornik wrote: On 24.9.2014 04:43, Endi Sukma Dewata wrote: On 9/22/2014 9:49 AM, Petr Vobornik wrote: [PATCH] webui-ci: case-insensitive record check

Re: [Freeipa-devel] [PATCH] 749-754 webui: new ID views section

2014-09-25 Thread Alexander Bokovoy
On Wed, 24 Sep 2014, Endi Sukma Dewata wrote: On 9/24/2014 9:43 AM, Petr Vobornik wrote: On 24.9.2014 16:30, Endi Sukma Dewata wrote: On 9/19/2014 7:29 AM, Petr Vobornik wrote: Hello, attached patches implements Web UI part of ID Views. Backend is currently on review as well - thread "[PATCHE