[Freeipa-devel] [PATCH] 324 Fixed I18n labels for HBAC Test

2011-12-07 Thread Endi Sukma Dewata
Hard-coded labels in HBAC Test have been moved into internal.py to allow translation. Ticket #388 -- Endi S. Dewata From 7cd17ee7fc9562f61b3626796458f75db30db56f Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Wed, 7 Dec 2011 02:46:08 -0600 Subject: [PATCH] Fixed I18n labels for HBAC

Re: [Freeipa-devel] [PATCH] 321 Fixed search filter in HBAC Test.

2011-12-07 Thread Endi Sukma Dewata
On 12/6/2011 9:19 AM, Petr Vobornik wrote: ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 322 Added external fields for HBAC Test.

2011-12-07 Thread Endi Sukma Dewata
On 12/7/2011 8:08 AM, Petr Vobornik wrote: ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 320 Fixed navigation buttons for HBAC Test.

2011-12-07 Thread Endi Sukma Dewata
On 12/7/2011 8:08 AM, Petr Vobornik wrote: ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 323 Fixed CSS for HBAC Test

2011-12-07 Thread Endi Sukma Dewata
On 12/7/2011 8:16 AM, Petr Vobornik wrote: ACK Pushed to master. Assuming that some following patch would add functionality to 'matched' and 'unmatched' checkboxes which were added to test_run_facet. Yes, coming up next. -- Endi S. Dewata ___ Fr

Re: [Freeipa-devel] [PATCH] 324 Fixed I18n labels for HBAC Test

2011-12-07 Thread Endi Sukma Dewata
On 12/7/2011 8:18 AM, Petr Vobornik wrote: ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 051 Search facets show translated boolean values

2011-12-07 Thread Endi Sukma Dewata
On 12/7/2011 10:00 AM, Petr Vobornik wrote: New version attached. ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 326 Added HBAC Test input validation.

2011-12-07 Thread Endi Sukma Dewata
The HBAC Test pages have been modified to validate required input before executing the test. Ticket #388 -- Endi S. Dewata From 2f5f4eeeb2e1d0e26e4a3fb4ce27b3c2cffccf9d Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Wed, 7 Dec 2011 20:39:52 -0600 Subject: [PATCH] Added HBAC Test input

Re: [Freeipa-devel] [PATCH] [WIP] 172+173 Create per-type DNS API

2011-12-08 Thread Endi Sukma Dewata
On 11/28/2011 10:35 AM, Martin Kosek wrote: I have prepared a working prototype of the new structured DNS API. It may still have rough edges (and unit tests are not ready), but it will provide a base for discussion and for WebUI folks - so that they can start development of the new DNS WebUI API.

Re: [Freeipa-devel] [PATCH] 052 Better displaying of long names in tables and facet headers

2011-12-08 Thread Endi Sukma Dewata
On 12/8/2011 8:31 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1890 This is an improvement, so it's ACKed. There are some other issues, they can be done separately: 1. Create an HBAC service with a very long name. Open an HBAC rule, add the service, it will widen the tab

[Freeipa-devel] [PATCH] 327 Fixed problem loading DNS records.

2011-12-08 Thread Endi Sukma Dewata
The DNS records list page was not loaded correctly due to a recent change in HBAC Test. The page has been updated to use the load_all() to show all records in the zone. Ticket #388 -- Endi S. Dewata From 72a3c6f33e9c2054b208ed4ac9e7a3237d371b0d Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata

Re: [Freeipa-devel] [PATCH] 178+179 Add missing managing hosts filtering options

2011-12-09 Thread Endi Sukma Dewata
On 12/8/2011 10:45 AM, Martin Kosek wrote: Host object has a virtual attribute "managing" containing all hosts it manages (governed by managedBy attribute). This patch also adds standard membership filtering options: --man-hosts=HOSTS: Only hosts managing _all_ HOSTS are returned --not-man-

Re: [Freeipa-devel] [PATCH] 178+179 Add missing managing hosts filtering options

2011-12-09 Thread Endi Sukma Dewata
On 12/9/2011 3:21 PM, Endi Sukma Dewata wrote: On 12/8/2011 10:45 AM, Martin Kosek wrote: Host object has a virtual attribute "managing" containing all hosts it manages (governed by managedBy attribute). This patch also adds standard membership filtering options: --man-hosts=HOSTS:

Re: [Freeipa-devel] [PATCH] 052 Better displaying of long names in tables and facet headers

2011-12-09 Thread Endi Sukma Dewata
On 12/9/2011 7:29 AM, Petr Vobornik wrote: Attaching new patch which addresses following issues: ACK and pushed to master. 7. When a column has a width set, there is a line (widget.js:1098): width += 16; Why is it there? I'd rather subtract it. I used git blame to find this. According to re

Re: [Freeipa-devel] [PATCH] 054 Reordered facets in ACI

2011-12-09 Thread Endi Sukma Dewata
On 12/9/2011 9:43 AM, Petr Vobornik wrote: Facets in ACI have new order: * Roles: members, privileges, settings * Privileges: permissions, settings, roles * Permissions: settings, privileges https://fedorahosted.org/freeipa/ticket/2104 ACK and pushed to master. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 325 Fixed matched/unmatched checkboxes in HBAC Test

2011-12-09 Thread Endi Sukma Dewata
On 12/9/2011 8:58 AM, Petr Vobornik wrote: Existing minor issue which can be fixed later: 1) matched checkbox has name 'disabled' Fixed and pushed to master under one-liner rule. -- Endi S. Dewata From 93aed745ec60f83ada4dc94f51e59c9e342a9847 Mon Sep 17 00:00:00 2001 From: Endi Su

[Freeipa-devel] [PATCH] 329 Fixed combobox icon position.

2011-12-09 Thread Endi Sukma Dewata
A recent CSS change inadvertently changes position of the combobox icon. This has been fixed now. Ticket #388 Pushed to master under one-liner rule. -- Endi S. Dewata From 3192474f7ef1d2e974c2a34e6d104b6e7ad92300 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Fri, 9 Dec 2011 15:26:19

Re: [Freeipa-devel] [PATCH] 326 Added HBAC Test input validation.

2011-12-09 Thread Endi Sukma Dewata
On 12/9/2011 8:58 AM, Petr Vobornik wrote: Possible future enhancement: I would rather see more specific error message. The message should contain which values are missing. In this implementation if user misses to fill more than one value, he is informed only about the first missing value (by red

Re: [Freeipa-devel] [PATCH] 327 Fixed problem loading DNS records.

2011-12-09 Thread Endi Sukma Dewata
On 12/9/2011 8:58 AM, Petr Vobornik wrote: The HBAC test page is completed, right? Can I add all commit ids to trac and close the ticket? The functionality is pretty much complete and the regressions found have been fixed, so I've closed the bug. -- Endi S. Dewata __

[Freeipa-devel] [PATCH] 330 Fixed combobox search icon position.

2011-12-09 Thread Endi Sukma Dewata
A recent CSS change inadvertently changes position of the combobox search icon. This has been fixed now. Ticket #388 Pushed to master under one-liner rule. -- Endi S. Dewata From 1ea1ea205cbd6da4892a8668d5e91f26de6e4ecb Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Fri, 9 Dec 2011 19

Re: [Freeipa-devel] [PATCH] 180 Add missing --pkey-only option for selfservice and

2011-12-09 Thread Endi Sukma Dewata
On 12/9/2011 9:47 AM, Martin Kosek wrote: pkey-only functionality has to be implemented separately for these modules as they are based on crud.Search instead of standard LDAPSearch. Delegation commands were modified in the process to allow ACIs without 'memberof' as delegation ACIs. This check i

[Freeipa-devel] [PATCH] 331 Enabled paging on self-service permissions and delegations.

2011-12-09 Thread Endi Sukma Dewata
ewata From e731e78e7c02cbf176722c8ba47c36f67dd7e9dd Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Fri, 9 Dec 2011 18:12:25 -0600 Subject: [PATCH] Enabled paging on self-service permissions and delegations. Paging has been enabled on self-service permissions and delegations list pages. The search facet&#

Re: [Freeipa-devel] [PATCH] [WIP] 172+173 Create per-type DNS API

2011-12-12 Thread Endi Sukma Dewata
On 12/12/2011 7:32 AM, Petr Vobornik wrote: The first option is we could modify this page to use a table for each type, similar to HBAC/sudo rule. For example: SRV Records x | Priority | Weight | Port | Target [Delete] [Add] --- x | 0 | 100 |

Re: [Freeipa-devel] [PATCH] 055 Association facets are read only in self service

2011-12-12 Thread Endi Sukma Dewata
On 12/12/2011 9:27 AM, Petr Vobornik wrote: This patch works with assumption that user in self-service mode doesn't have rights for enrolling/un-enrolling himself to/from group, role, hbac rule, net group, sudo rule. He can only read the attributes. Therefore in self service mode all user associa

Re: [Freeipa-devel] [PATCH] 056 Added facet tabs coloring

2011-12-12 Thread Endi Sukma Dewata
On 12/12/2011 12:21 PM, Petr Vobornik wrote: Facet tabs are now colored according to their group. https://fedorahosted.org/freeipa/ticket/1976 This is how it looks: http://edewata.fedorapeople.org/freeipa/install/ui/#identity=group&navigation=identity&group-facet=default&group-pkey=editors S

Re: [Freeipa-devel] [PATCH] 056 Added facet tabs coloring

2011-12-14 Thread Endi Sukma Dewata
On 12/13/2011 3:49 AM, Petr Vobornik wrote: 1. The original code uses different background images for active/inactive tabs. I think the mockup in the ticket is also showing different backgrounds. The new code uses the same background. Fixed, using the background from mockup - but honestly I don

Re: [Freeipa-devel] [PATCH] [WIP] 172+173+175 Create per-type DNS API

2011-12-14 Thread Endi Sukma Dewata
On 12/14/2011 12:53 AM, Martin Kosek wrote: I found this works ok and adding records is definitely clearer but it seems odd to add with one command and delete/find with another. I could get used to it I suppose. Hm, we could add dnsrecord--del ZONE RECORD VALUE command, but this would increase

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0019-associations.patch

2010-09-03 Thread Endi Sukma Dewata
pa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel >From 08623db1acd6a5b890abf5f9d401a3dedb3c3829 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Thu, 2 Sep 2010 04:14:57 -0400 Subject: [PATCH] Added Services tab. ---

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0021-local-param-for-this-in-closure

2010-09-07 Thread Endi Sukma Dewata
- "Adam Young" wrote: > This addresses Endi's comment regarding the 'this' pointer from path > admiyo-0019. This patch is required to get the associations working. ACK. Thanks! -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redh

[Freeipa-devel] [PATCH] 0001-Added-Services-tab.patch

2010-09-07 Thread Endi Sukma Dewata
Hi, This patch adds the Service tab using Adam's association classes. It also contains the sample data for some service operations. Thanks! -- Endi S. Dewata >From 3258e05bd5777e6ca31369491a964d8335452b55 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Thu, 2 Sep 2010 04:14:

Re: [Freeipa-devel] [PATCH] 0001-Added-Services-tab.patch

2010-09-08 Thread Endi Sukma Dewata
ces-tab.patch The new patch has been renamed as such. Thanks! -- Endi S. Dewata >From 5811592834890584bdc5f42e58f8e767fb71278f Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Thu, 2 Sep 2010 04:14:57 -0400 Subject: [PATCH] Added Services tab. --- install/static/Makefile.am

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0022-netgroup-associations.patch

2010-09-09 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Netgroup associations: > netgroups -> users, groups,hosts,hostgroups > > https://fedorahosted.org/freeipa/attachment/ticket/96/admiyo-freeipa-0022-netgroup-associations.patch ACK, but there are typos on lines 153, 167, 180 in the patch. Thanks! -- Endi S. Dewata __

[Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

2010-09-09 Thread Endi Sukma Dewata
take service name and hostname and combine them to generate the service principal by overriding the getPKey(). -- Endi S. Dewata >From cb6ee37caa2790ed2f7b6eca1158ec5c146e1ef8 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Thu, 9 Sep 2010 22:21:29 -0400 Subject: [PATCH] Splitting serv

Re: [Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

2010-09-10 Thread Endi Sukma Dewata
n; > } OK, fixed in the new attachment. Thanks! -- Endi S. Dewata >From cee21193e33900c2abaab6a581bc70baacfc1d83 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Thu, 9 Sep 2010 22:21:29 -0400 Subject: [PATCH] Splitting service principal into service name and hostname. The EntityBuilder h

Re: [Freeipa-devel] QUnit and unit testing

2010-09-13 Thread Endi Sukma Dewata
- "Adam Young" wrote: > I've started playing around with QUnit. I think it is the right too > for Unit testing in q JQuery based application. > > One thing that has become clear pretty quickly is that most of our > code is dependant upon ipa_cmd. We are going to need to have a more > flexi

Re: [Freeipa-devel] QUnit and unit testing

2010-09-13 Thread Endi Sukma Dewata
- "Adam Young" wrote: > > IPA class: > > - IPA(path, type): Construct IPA object given a path to server's JSON-RPC or > >static files. > > - success(): Default success handler. > > - error(): Default error handler. > > - failure(): Default failure handler. > > - execute(met

Re: [Freeipa-devel] QUnit and unit testing

2010-09-13 Thread Endi Sukma Dewata
- "Endi Sukma Dewata" wrote: > var addCmd = ipa.createCommand("user-add"); The createCommand() could be implemented like this: ipa.createCommand = function(method) { return new IPACommand(this, method); } The QUnit test could be implemented like this: test("

Re: [Freeipa-devel] Proposed Javascript coding standards

2010-09-13 Thread Endi Sukma Dewata
Hi Adam, - "Adam Young" wrote: > https://fedorahosted.org/freeipa/wiki/Javascript_Coding_Standards Whitespace: Do we put a space in function definition between the () and {}? function(){...} vs. function() {...} Or does it matter? Compound statement: This is probably Python syntax. if f

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0023-user-whoami.patch

2010-09-14 Thread Endi Sukma Dewata
- "Adam Young" wrote: > user whoami > Added a whoami option to the user, allows the user to query their > own information based on their Kerberos principal > https://fedorahosted.org/freeipa/attachment/ticket/47/admiyo-freeipa-0023-user-whoami.patch > > This will be used to return the u

[Freeipa-devel] [PATCH] Adding quick links in user and group search results.

2010-09-14 Thread Endi Sukma Dewata
for user and group entities. -- Endi S. Dewata >From bef6aa95bdfd13d360e4a0420d467915330db833 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Tue, 14 Sep 2010 22:26:15 -0400 Subject: [PATCH] Adding quick links in user and group search results. The render_call() signature has been modif

Re: [Freeipa-devel] [PATCH] Adding quick links in user and group search results.

2010-09-15 Thread Endi Sukma Dewata
- "Adam Young" wrote: > ACK, but change the Column heading to Quick Links first OK, fixed. Thanks. -- Endi S. Dewata >From 5b04bc19d2d639da0f7814e901f15814eea7c354 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Tue, 14 Sep 2010 22:26:15 -0400 Subject: [PATCH] Addin

[Freeipa-devel] [PATCH] Restoring Services tab

2010-09-17 Thread Endi Sukma Dewata
tails fields. Callbacks are used to add quick links and generate pkey dynamically. The webui.js has been modified to add the Services tab. Thanks! -- Endi S. Dewata >From cf4703e9e62cfddbdfeceb21d811e0ece1c00886 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Fri, 17 Sep 2010 19:03:

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0025-remove-pagaparams.patch

2010-09-17 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Fixes a minor glitch in pzuna-freeipa-0022-4-BIG which re-introduced > > the pageparams.js entry into the Makefile.am ACK -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Endi Sukma Dewata
- "Adam Young" wrote: > On 09/20/2010 08:10 AM, Pavel Zuna wrote: > > On 09/17/2010 04:38 PM, Adam Young wrote: > >> moved images up > >> Adding an 'images' subdir was proliferating changes throughout the > build > >> system > >> this seemed easier > >> > >> Submitted as a separate patch to s

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Endi Sukma Dewata
- "Adam Young" wrote: > moved images up > Adding an 'images' subdir was proliferating changes throughout the > build system > this seemed easier > > Submitted as a separate patch to signify where wea re departing from > what is generated by theme-roller admiyo-freeipa-0030-moved-image

[Freeipa-devel] [PATCH] Rolegroups tab.

2010-09-20 Thread Endi Sukma Dewata
group operations have been added. -- Endi S. Dewata >From 09cc9d1ceb6259472739afdc767cc502ff9f2484 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Mon, 20 Sep 2010 20:05:03 -0400 Subject: [PATCH] Rolegroups tab. The Makefile.am and index.xhtml has been modified to include rolegroup.js. The webu

[Freeipa-devel] [PATCH] Modal dialog for enrollment

2010-09-22 Thread Endi Sukma Dewata
changes were also made to improve code clarity. -- Endi S. Dewata >From 2a87079d6940d601c066b5b6259e60ece423532d Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Wed, 22 Sep 2010 21:22:31 -0400 Subject: [PATCH] Modal dialog for enrollment The enroll facet has been converted into a dia

Re: [Freeipa-devel] [PATCH]admiyo-freeipa-0041-self-service.patch

2010-09-23 Thread Endi Sukma Dewata
- "Adam Young" wrote: > self-service > Selects the site map based on the presence or absense of rolegroups for > the current user. If the user has no rolegroups, UI defaults to > the Details page for that user. NACK. The window_hashchange() is expecting 2 levels of tabs: va

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0043-Whoami-link.patch

2010-09-24 Thread Endi Sukma Dewata
- "Adam Young" wrote: > On 09/24/2010 10:53 AM, Adam Young wrote: > > Whoami link > > The 'logged in as' message in the header into an active hypoerlink > > that loads the details page for the current user. > > Also fixed a bug where, when reloading, the search page would fail > > d

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0043-Whoami-link.patch

2010-09-24 Thread Endi Sukma Dewata
- "Adam Young" wrote: > >>> Whoami link > >>> The 'logged in as' message in the header into an active hypoerlink > >>> that loads the details page for the current user. > >>> Also fixed a bug where, when reloading, the search page would fail > >>> due to scl being undefined > >>>

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0043-Whoami-link.patch

2010-09-24 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Fixed admiyo-freeipa-0043-3-Whoami-link.patch ACK, sorry didn't see this one before replying. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Test suite for ipa.js and entity.js.

2010-09-27 Thread Endi Sukma Dewata
- "Rob Crittenden" wrote: > Is there any documentation on how to run the tests? You just need to open install/static/test/index.html in the browser and click the test you want to run. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel

[Freeipa-devel] [PATCH] Test suite for association.

2010-09-27 Thread Endi Sukma Dewata
. Updated the test case to validate click event on facets. -- Endi S. Dewata >From 8e23c7983f5841e74611cc40077a88d8afee4836 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Mon, 27 Sep 2010 22:13:17 -0400 Subject: [PATCH] Test suite for association. New test cases have been added to t

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0045-Fix-the-add-button.patch

2010-09-28 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Fix the 'add' button > > The Add button was located using the Dom, and the scheme used to > find it was fragile enough to be broken by the I18N approach. This is a > little more robust, using a JQuery selector based on the class of the > controls, and the entit

[Freeipa-devel] [PATCH] Fixed tab selection on page reload.

2010-09-28 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! jQuery tabs by default will display the first tab, so reloading a page or opening a page from bookmark may not show the active tab correctly. The nav_select_tabs() has been added to get the list of active tabs from the hash values in the URL and then

[Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-28 Thread Endi Sukma Dewata
Hi, Please review the attached patch. It can be tested by moving one of the JSON files in test/data somewhere else. Thanks! The ipa_cmd() has been modified such that when an error occurs a dialog box will appear showing the error message with 2 buttons: Retry and Cancel. If Retry is clicked, it w

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0046-Corrected-Language-Codes.patch

2010-09-28 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Corrected Language Codes > The Gnu document incorrectly listed Japanese as jp and Hebrew as iw. > That was why the Plurals line passed through directly from the template. > > > ___ > Freeipa-devel mailing list > F

Re: [Freeipa-devel] [PATCH]admiyo-freeipa-0047-tab-objects.patch

2010-09-28 Thread Endi Sukma Dewata
- "Adam Young" wrote: > tab objects > Convert the tab lists to arrays of objects with four potential fields: > > tab[0] -> tab.name > tab[1] -> tab.label > tab[2] -> tab.setup or tab.children > Added unit tests ACK, but could you add the unit tests into the index.html and all_tests.html? I

Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Endi, can you add in a Unit test for this? If need be, extend the > ipa_cmd so that it looks for an optional command line param that makes > it try to fetch a .json file that doesn't exist: > > > Something like > var suffix = $.bbq.get("cmd_suffix"); > if (suffix){ >

Re: [Freeipa-devel] admiyo-freeipa-0048-Item-Level-Undo.patch

2010-09-29 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Item Level Undo > > Also adding some unit tests for details. > Using JQuery UI buttons for update and reset > > This has the added benefit of letting the user know when the screen > has been submitted, as the "undo" buttons go away. > Rebased on top > of Endi's last

[Freeipa-devel] [PATCH] Checking empty AJAX response in ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! Some errors (e.g. server down) are reported as AJAX success with empty data and/or HTTP error code != 200. The ipa_cmd() has been modified so that it will detect such errors and invoke the error handler. -- Endi S. Dewata >From 6b04c0f28cfd369f77c8f4

Re: [Freeipa-devel] [PATCH] Checking empty AJAX response in ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
- "Endi Sukma Dewata" wrote: > Some errors (e.g. server down) are reported as AJAX success with > empty data and/or HTTP error code != 200. The ipa_cmd() has been > modified so that it will detect such errors and invoke the error > handler. It turns out that pulling

Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Should have remembered this approach, standard JS way to deal with > undefined values. admiyo-freeipa-0048-3-Item-Level-Undo.patch A few notes: 1. You're replying to the wrong thread :) 2. The undo button will only appear when the input field loses focus. Ideally

[Freeipa-devel] [PATCH] Refactoring navigation.js.

2010-09-30 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The navigation.js has been modified to make it more abstract, i.e. unaware of entity facets. The nav_update_tabs() has been modified such that it activates and updates the tabs based on the current state stored in the URL. The facets are now handled

[Freeipa-devel] [PATCH] Autogenerating Quick Links.

2010-10-01 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! ipa_entity_quick_links() has been added to generate quick links automatically from object's attribute_members, the same logic used for generating facet list. The search definition for each entity has been updated to use the new function. A unit test h

[Freeipa-devel] [PATCH] Entity association configuration.

2010-10-01 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The ipa_entity_set_association_definition() has been added to configure the association between 2 entitites. By default the associator is BulkAssociator and the method is add_member. The entities have been updated to use the right configurations. The

[Freeipa-devel] [PATCH] Tooltips for quick links.

2010-10-04 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The ipa_entity_quick_links() has been modified to show tooltips when hovering on quick links. -- Endi S. Dewata >From 98a75d0b1d72f8d10f1a741aac3b12de71a6f655 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 4 Oct 2010 12:51:51 -0500 Subject

Re: [Freeipa-devel] [PATCH] Tooltips for quick links.

2010-10-04 Thread Endi Sukma Dewata
- "Adam Young" wrote: > ACK Thanks. Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] UI Unit Tests Docs

2010-10-05 Thread Endi Sukma Dewata
Hi, Here are the docs for the UI Unit Tests: http://www.freeipa.org/page/UI_Unit_Tests Any comments are welcome. Thanks! -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] UI Unit Tests Docs

2010-10-05 Thread Endi Sukma Dewata
- "Rob Crittenden" wrote: > Endi Sukma Dewata wrote: > > Hi, > > > > Here are the docs for the UI Unit Tests: > > http://www.freeipa.org/page/UI_Unit_Tests > > > > Any comments are welcome. Thanks! > > Looks good to me. Can you add a

Re: [Freeipa-devel] UI Unit Tests Docs

2010-10-05 Thread Endi Sukma Dewata
- "Rob Crittenden" wrote: > >>> http://www.freeipa.org/page/UI_Unit_Tests > >> > >> Looks good to me. Can you add a link from the Testing page here? > > > > You mean the index.html in install/static/test, right? > > OK, I will do that after this. Do we need to store the > > source of this wik

Re: [Freeipa-devel] [PATCH] Fix attribute callbacks on details pages in the webUI.

2010-10-06 Thread Endi Sukma Dewata
- "Pavel Zuna" wrote: > Fixes bug reported by Adam in internal discussion. > > Ticket #326 > > Pavel ACK'd and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/f

[Freeipa-devel] [PATCH] Displaying AJAX URL in error message.

2010-10-06 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The ipa_error_handler() has been modified to display the AJAX URL that is having a problem. The ipa_cmd() error handler is now invoked using call() to pass 'this' object which contains the URL. -- Endi S. Dewata >From febd03de235e5a2a458944c77fe2b214

Re: [Freeipa-devel] [PATCH] 564 fix some aci typos

2010-10-06 Thread Endi Sukma Dewata
- "Rob Crittenden" wrote: > I mis-spelled the admins group with an extra s which was causing some > things to not work as admin. > > I also noticed a couple of spurious 'aci' in some descriptions, remove > those as well. > > rob NACK. The spurious 'aci' should have been 'acl' according to

Re: [Freeipa-devel] [PATCH] Displaying AJAX URL in error message.

2010-10-06 Thread Endi Sukma Dewata
- "Adam Young" wrote: > On 10/06/2010 05:00 PM, Endi Sukma Dewata wrote: > > The ipa_error_handler() has been modified to display the AJAX URL > that is having a problem. The ipa_cmd() error handler is now invoked > using call() to pass 'this' object whi

Re: [Freeipa-devel] [PATCH] 564 fix some aci typos

2010-10-06 Thread Endi Sukma Dewata
- "Rob Crittenden" wrote: > >> I mis-spelled the admins group with an extra s which was causing some > >> things to not work as admin. > >> > >> I also noticed a couple of spurious 'aci' in some descriptions, remove > >> those as well. > > > > NACK. The spurious 'aci' should have been 'acl' a

Re: [Freeipa-devel] [PATCH] 563 use unique names for acis

2010-10-06 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Copy/paste error where I didn't replace Hosts with Hostgroups in aci > name. > ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeip

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0053-policy-and-config-sample-data.patch

2010-10-06 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Sample data for config and policy entities. ACK with note: Rob fixed ACI duplicates in his patch #564 so the aci_find.json will need to be fixed later. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.c

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0052-policy-and-config.patch

2010-10-07 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Population of the policy and entities tabs. > DNS and ACI are broken due to Plugin issues > Fix for entities without search > Added new files to Makefile.am > used rolegroup.js file as the start point, renamed to serverconfig.js > > Missed the Makefile.am additions ne

Re: [Freeipa-devel] [PATCH] 565 handle both DER and base64 encoded certs in service plugin

2010-10-08 Thread Endi Sukma Dewata
- "Rob Crittenden" wrote: > Accept an incoming certificate as either DER or base64 in the service > plugin. > > The plugin required a base64-encoded certificate and always decoded it > before processing. This doesn't work with the UI because the json module > decodes binary values already.

Re: [Freeipa-devel] [PATCH]admiyo-freeipa-0055-record-limit.patch

2010-10-08 Thread Endi Sukma Dewata
- "Rob Crittenden" wrote: > Adam Young wrote: > > This patch hard codes the record limit for the UI to 100. Next step is > > to make it configurable. This patch is necessary, as without it, some > > customers with large records will have problems with default queries. > > ack Pushed to mas

[Freeipa-devel] [PATCH] Certificate management for services.

2010-10-08 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! This is an initial implementation of certificate management for services. It addresses the mechanism required to view and update certificates. The complete UI implementation will be addressed in subsequent patches. On the server side, the service.py

Re: [Freeipa-devel] [PATCH] 567 fix group deletion

2010-10-13 Thread Endi Sukma Dewata
- "Pavel Zuna" wrote: > On 10/09/2010 04:47 AM, Rob Crittenden wrote: > > Group deletion was failing with an error about too many values. > ACK. Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://

[Freeipa-devel] [PATCH] Service certificate UI.

2010-10-14 Thread Endi Sukma Dewata
l/static/certificate.js b/install/static/certificate.js new file mode 100755 index 000..4302e2f --- /dev/null +++ b/install/static/certificate.js @@ -0,0 +1,381 @@ +/* Authors: + * Endi Sukma Dewata + * + * Copyright (C) 2010 Red Hat + * see file 'COPYING' for use and wa

Re: [Freeipa-devel] [PATCH] Service certificate UI.

2010-10-15 Thread Endi Sukma Dewata
,0 +1,381 @@ +/* Authors: + *Endi Sukma Dewata + * + * Copyright (C) 2010 Red Hat + * see file 'COPYING' for use and warranty information + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0056-removing-dead-files

2010-10-15 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Like the journey song, these should have been gone, long ago. ACKed and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Service certificate status.

2010-10-15 Thread Endi Sukma Dewata
ndi S. Dewata From 23bfa0d6d33cb397e25bd19d319e2c7904fbcc77 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Fri, 15 Oct 2010 20:51:52 -0400 Subject: [PATCH] Service certificate status. The service details page has been modified to show certificate status using bullets. It will also sho

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0056-removing-dead-files

2010-10-18 Thread Endi Sukma Dewata
On 10/18/2010 9:38 AM, Adam Young wrote: On 10/15/2010 06:56 PM, Simo Sorce wrote: Endi Sukma Dewata wrote: ACKed and pushed to master. >> This patch broke the build ... fix coming, but guys, please, verify stuff builds from scratch before pushing patches. Simo, very sorry about this

Re: [Freeipa-devel] [PATCH] Service certificate status.

2010-10-18 Thread Endi Sukma Dewata
On 10/18/2010 12:58 PM, Adam Young wrote: ACK. Please file a ticket for throwing the error message when installed without dogtag I see this has been pushed. Thanks! I closed this ticket: https://fedorahosted.org/freeipa/ticket/276 and opened these tickets: https://fedorahosted.org/freeipa/tic

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0058-password-dialog.patch

2010-10-18 Thread Endi Sukma Dewata
On 10/18/2010 1:53 PM, Adam Young wrote: Now check the principal prior to calling passwd, and add that as a parameter for non-selfservice case. ACK with note that there's an outstanding bug on password reset: https://fedorahosted.org/freeipa/ticket/390 -- Endi S. Dewata __

[Freeipa-devel] [PATCH] Host certificate management

2010-10-19 Thread Endi Sukma Dewata
, -'value': 'View', -'click': function() { -ipa_cmd('service_show', [krbprincipalname], {}, -function(data, text_status, xhr) { -view_certificate(data.result.result); -} -

[Freeipa-devel] [PATCH] Dialog boxes for AJAX, HTTP, and IPA errors.

2010-10-19 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/95/ The ipa_cmd() has been modified to identity the type of the error it has received and display the error using the right dialog box. The dialog box can be customized further to display the appropriate amount

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0061-Remove-size-limits.patch

2010-10-19 Thread Endi Sukma Dewata
On 10/19/2010 3:57 PM, Adam Young wrote: Remove size limits. Now use the system wide settings instead of hardcoded size limits. ACKed and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redh

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0062-removing-icons.patch

2010-10-19 Thread Endi Sukma Dewata
On 10/19/2010 4:07 PM, Adam Young wrote: Removing icons We'll later replace them with a new scheme. For now, this is the simplest UI The intention is to look unfinished, so people don't comment on how poor it looks. But still, it looks better than with the oddly spaced icons. Already ACKed and

Re: [Freeipa-devel] [PATCH] Host certificate management

2010-10-19 Thread Endi Sukma Dewata
-); -} -}).appendTo(td); - -$('', { -'type': 'button', -'value': 'View', -'click': function() { -ipa_cmd('service_show', [krbprincipalname], {}, - function(data, text_sta

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0063-dns-work.patch

2010-10-25 Thread Endi Sukma Dewata
On 10/25/2010 1:10 PM, Adam Young wrote: On 10/25/2010 11:26 AM, Adam Young wrote: On 10/25/2010 10:52 AM, Rob Crittenden wrote: Adam Young wrote: Implementation of the UI for DNS records. Search uses filters. Much of the code has been cut and pasted from search.js and add.js, but then signi

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0068-association-header.patch

2010-10-26 Thread Endi Sukma Dewata
On 10/25/2010 8:39 PM, Adam Young wrote: https://fedorahosted.org/freeipa/ticket/338 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACKed and pushed to master. -- Endi S. Dewata _

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0069-Field-Errors.patch

2010-10-27 Thread Endi Sukma Dewata
On 10/27/2010 12:44 PM, Adam Young wrote: Field Errors Uses the pattern field of the metat data to see if the input for a given field is valid. If not, displays a red box with the contents of pattern_msg To test this, I artificially modified the meta data for the Group description ACKed and pu

Re: [Freeipa-devel] [PATCH] Dialog boxes for AJAX, HTTP, and IPA errors.

2010-10-28 Thread Endi Sukma Dewata
On 10/19/2010 4:28 PM, Endi Sukma Dewata wrote: https://fedorahosted.org/reviewboard/r/95/ The ipa_cmd() has been modified to identity the type of the error it has received and display the error using the right dialog box. The dialog box can be customized further to display the appropriate

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0070-delete-associations.patch

2010-10-29 Thread Endi Sukma Dewata
On 10/29/2010 10:33 AM, Adam Young wrote: On 10/28/2010 05:30 PM, Adam Young wrote: On 10/28/2010 05:22 PM, Adam Young wrote: delete associations Uses code very similar to the search code for deleting associations Only uses the serial means of deletion. While this works for all deletes, it is

<    1   2   3   4   5   6   7   8   9   10   >