Re: [Freeipa-devel] [PATCHES 0015-0019] changes to the way host TGT is obtained using keytab

2015-03-06 Thread Jan Cholasta
ccache_file (You don't need to prepend FILE:, as it is the default ccache type.) Honza -- Jan Cholasta -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] Password vault

2015-03-06 Thread Jan Cholasta
automatically created in vaultcontainer_find? 28) The vault and vaultcontainer plugins seem to be pretty similar, I think it would make sense to put common stuff in a base class and inherit vault and vaultcontainer from that. More later. Honza -- Jan Cholasta

Re: [Freeipa-devel] [PATCH] 0040 Add realm name to backup header file.

2015-03-05 Thread Jan Cholasta
. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Thanks, ACK! Pushed to: master: 4a20115ce8a3d90afec827d356edecc7834a0684 ipa-4-1: 253f9adae7968af8df8aab0ae2441d26112deb2b Honza -- Jan Cholasta

Re: [Freeipa-devel] [PATCH] 0006 Limit deadlocks between DS plugin DNA and slapi-nis

2015-03-05 Thread Jan Cholasta
Hi Thierry, Dne 4.3.2015 v 15:54 thierry bordaz napsal(a): https://fedorahosted.org/freeipa/ticket/4927 Thanks, ACK. Added ticket URL to commit message and pushed to: master: 6e00f7318230781debd9952c6f2a3d924f35688a ipa-4-1: 5c3611481a5e0a4974ee368c60b8ef9ca34ea38a Honza -- Jan Cholasta

Re: [Freeipa-devel] [PATCHES 399-401] Allow multiple API instances

2015-03-04 Thread Jan Cholasta
Dne 3.3.2015 v 16:11 Martin Kosek napsal(a): On 03/03/2015 04:09 PM, Jan Cholasta wrote: Dne 3.3.2015 v 16:04 Tomas Babej napsal(a): On 03/03/2015 04:01 PM, Martin Kosek wrote: On 03/03/2015 03:49 PM, Jan Cholasta wrote: Hi, the attached patches provide an attempt to fix https

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-03 Thread Jan Cholasta
Dne 3.3.2015 v 10:55 Martin Kosek napsal(a): On 03/03/2015 09:55 AM, Martin Basti wrote: On 03/03/15 09:33, Jan Cholasta wrote: Dne 3.3.2015 v 09:06 Martin Basti napsal(a): On 03/03/15 07:31, Jan Cholasta wrote: Dne 2.3.2015 v 13:51 Martin Basti napsal(a): On 02/03/15 13:12, Jan Cholasta

Re: [Freeipa-devel] [PATCHES 399-401] Allow multiple API instances

2015-03-03 Thread Jan Cholasta
Dne 3.3.2015 v 16:04 Tomas Babej napsal(a): On 03/03/2015 04:01 PM, Martin Kosek wrote: On 03/03/2015 03:49 PM, Jan Cholasta wrote: Hi, the attached patches provide an attempt to fix https://fedorahosted.org/freeipa/ticket/3090. Patch 401 serves as an example and modifies ipa-advise to use

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-03 Thread Jan Cholasta
Dne 3.3.2015 v 11:04 Petr Spacek napsal(a): On 3.3.2015 10:58, Martin Kosek wrote: On 03/03/2015 09:36 AM, Petr Spacek wrote: On 3.3.2015 09:33, Jan Cholasta wrote: Dne 3.3.2015 v 09:06 Martin Basti napsal(a): On 03/03/15 07:31, Jan Cholasta wrote: Dne 2.3.2015 v 13:51 Martin Basti napsal

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-03 Thread Jan Cholasta
Dne 3.3.2015 v 12:08 Martin Kosek napsal(a): On 03/03/2015 11:06 AM, Jan Cholasta wrote: Dne 3.3.2015 v 11:04 Petr Spacek napsal(a): On 3.3.2015 10:58, Martin Kosek wrote: On 03/03/2015 09:36 AM, Petr Spacek wrote: On 3.3.2015 09:33, Jan Cholasta wrote: Dne 3.3.2015 v 09:06 Martin Basti

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-03 Thread Jan Cholasta
Dne 3.3.2015 v 09:06 Martin Basti napsal(a): On 03/03/15 07:31, Jan Cholasta wrote: Dne 2.3.2015 v 13:51 Martin Basti napsal(a): On 02/03/15 13:12, Jan Cholasta wrote: Dne 2.3.2015 v 12:23 Martin Kosek napsal(a): On 03/02/2015 07:49 AM, Jan Cholasta wrote: Hi, Dne 24.2.2015 v 19:10 Martin

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-03 Thread Jan Cholasta
Dne 3.3.2015 v 10:58 Martin Kosek napsal(a): On 03/03/2015 09:36 AM, Petr Spacek wrote: On 3.3.2015 09:33, Jan Cholasta wrote: Dne 3.3.2015 v 09:06 Martin Basti napsal(a): On 03/03/15 07:31, Jan Cholasta wrote: Dne 2.3.2015 v 13:51 Martin Basti napsal(a): On 02/03/15 13:12, Jan Cholasta

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-03 Thread Jan Cholasta
Dne 3.3.2015 v 11:00 Martin Basti napsal(a): On 03/03/15 10:55, Jan Cholasta wrote: Dne 3.3.2015 v 09:55 Martin Basti napsal(a): On 03/03/15 09:33, Jan Cholasta wrote: Dne 3.3.2015 v 09:06 Martin Basti napsal(a): On 03/03/15 07:31, Jan Cholasta wrote: Dne 2.3.2015 v 13:51 Martin Basti

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-03 Thread Jan Cholasta
Dne 3.3.2015 v 09:55 Martin Basti napsal(a): On 03/03/15 09:33, Jan Cholasta wrote: Dne 3.3.2015 v 09:06 Martin Basti napsal(a): On 03/03/15 07:31, Jan Cholasta wrote: Dne 2.3.2015 v 13:51 Martin Basti napsal(a): On 02/03/15 13:12, Jan Cholasta wrote: Dne 2.3.2015 v 12:23 Martin Kosek

[Freeipa-devel] [PATCHES 399-401] Allow multiple API instances

2015-03-03 Thread Jan Cholasta
Hi, the attached patches provide an attempt to fix https://fedorahosted.org/freeipa/ticket/3090. Patch 401 serves as an example and modifies ipa-advise to use its own API instance for Advice plugins. Honza -- Jan Cholasta From 3715c9b4ca43eab6c5ad01b34cd1b14838241bde Mon Sep 17 00:00:00

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-02 Thread Jan Cholasta
Dne 2.3.2015 v 13:51 Martin Basti napsal(a): On 02/03/15 13:12, Jan Cholasta wrote: Dne 2.3.2015 v 12:23 Martin Kosek napsal(a): On 03/02/2015 07:49 AM, Jan Cholasta wrote: Hi, Dne 24.2.2015 v 19:10 Martin Basti napsal(a): Hello all, please read the design page, any objections/suggestions

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-02 Thread Jan Cholasta
Dne 2.3.2015 v 12:23 Martin Kosek napsal(a): On 03/02/2015 07:49 AM, Jan Cholasta wrote: Hi, Dne 24.2.2015 v 19:10 Martin Basti napsal(a): Hello all, please read the design page, any objections/suggestions appreciated http://www.freeipa.org/page/V4/Server_Upgrade_Refactoring 1) * Merge

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-03-01 Thread Jan Cholasta
work overall! Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0182] Fix pkcs11 python extension reference counting

2015-02-10 Thread Jan Cholasta
) In P11_Helper_find_keys, you sometimes return without decreasing reference count on result_list or any items it may contain. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0182] Fix pkcs11 python extension reference counting

2015-02-10 Thread Jan Cholasta
Dne 10.2.2015 v 14:56 Martin Basti napsal(a): On 10/02/15 10:11, Jan Cholasta wrote: Hi, Dne 12.1.2015 v 13:11 Martin Basti napsal(a): Part of DNSSEC (https://fedorahosted.org/freeipa/ticket/4657) Patch attached. 1) In P11_Helper_set_attribute, the return value can be only Py_None or NULL

[Freeipa-devel] [PATCH] 398 Bump 389-ds-base and pki-ca dependencies for POODLE fixes

2015-02-09 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4653. Honza -- Jan Cholasta From 808f0bcfa15936dd573c9093c9fdf7d097512dad Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 12 Jan 2015 09:01:09 + Subject: [PATCH] Bump 389-ds-base and pki-ca

Re: [Freeipa-devel] [PATCH] 0003-2 User life cycle: new stageuser plugin with add verb

2015-02-04 Thread Jan Cholasta
in it. We usually don't do that and IMHO we shouldn't do that. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCHES 301-302] ID override sshpubkey handling

2015-01-27 Thread Jan Cholasta
: 3b87302f5a280c044a8e6a8b4aa08a29e3b4b0d5 ipa-4-1: 0dc7448b3634be443806db45ffead57107213ad6 Your patches will latter go into ipa-4-2. +1 -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo

[Freeipa-devel] [PATCH] 397 Do not crash when replica is unreachable in ipa-restore

2015-01-26 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4857. Honza -- Jan Cholasta From 6270155705249b6b6bcb4665156d73f2f14edb86 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 27 Jan 2015 07:38:06 + Subject: [PATCH] Do not crash when replica

Re: [Freeipa-devel] [PATCH] 396 Create correct log directories during full restore in ipa-restore

2015-01-26 Thread Jan Cholasta
Dne 26.1.2015 v 17:22 Martin Kosek napsal(a): On 01/26/2015 12:12 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4865. Honza I tested the use case and log directories were properly created. So ACK, works for me. Martin Thanks. Pushed

[Freeipa-devel] [PATCH] 396 Create correct log directories during full restore in ipa-restore

2015-01-26 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4865. Honza -- Jan Cholasta From 2cdb9f96c94c146805f43f38b5b93d48c95eecdb Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 26 Jan 2015 10:39:48 + Subject: [PATCH] Create correct log directories

Re: [Freeipa-devel] [PATCH 0184] Always return absolute idnsname in dnszone commands

2015-01-25 Thread Jan Cholasta
Dne 23.1.2015 v 15:51 Martin Basti napsal(a): On 23/01/15 08:22, Jan Cholasta wrote: Dne 20.1.2015 v 12:49 Martin Basti napsal(a): On 15/01/15 16:07, Jan Cholasta wrote: Dne 15.1.2015 v 15:39 Martin Basti napsal(a): On 15/01/15 15:07, Jan Cholasta wrote: Dne 15.1.2015 v 14:58 Martin Basti

Re: [Freeipa-devel] [PATCHES 0187, 0188] DNSSEC ipa-dnskeysyncd fixes

2015-01-23 Thread Jan Cholasta
Dne 23.1.2015 v 10:13 Martin Basti napsal(a): On 23/01/15 08:04, Jan Cholasta wrote: Hi, Dne 21.1.2015 v 13:39 Martin Basti napsal(a): Patch 188 catch ldap exceptions to prevent false positive abrt reports Patch 187 fixes issues with removing root zone Patches attached. Patch 187

Re: [Freeipa-devel] [PATCHES 0187, 0188] DNSSEC ipa-dnskeysyncd fixes

2015-01-23 Thread Jan Cholasta
Dne 23.1.2015 v 10:25 Martin Basti napsal(a): On 23/01/15 10:23, Jan Cholasta wrote: Dne 23.1.2015 v 10:13 Martin Basti napsal(a): On 23/01/15 08:04, Jan Cholasta wrote: Hi, Dne 21.1.2015 v 13:39 Martin Basti napsal(a): Patch 188 catch ldap exceptions to prevent false positive abrt reports

Re: [Freeipa-devel] [PATCHES 0187, 0188] DNSSEC ipa-dnskeysyncd fixes

2015-01-22 Thread Jan Cholasta
? Patch 188: IMO it would be slightly better to do it like this: -name = name.relativize(dns.name.root) +if name != dns.name.root: +name = name.relativize(dns.name.root) Honza -- Jan Cholasta ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH 0184] Always return absolute idnsname in dnszone commands

2015-01-22 Thread Jan Cholasta
Dne 20.1.2015 v 12:49 Martin Basti napsal(a): On 15/01/15 16:07, Jan Cholasta wrote: Dne 15.1.2015 v 15:39 Martin Basti napsal(a): On 15/01/15 15:07, Jan Cholasta wrote: Dne 15.1.2015 v 14:58 Martin Basti napsal(a): On 15/01/15 14:25, Jan Cholasta wrote: Hi, Dne 15.1.2015 v 13:27 Martin

[Freeipa-devel] [PATCH] 395 Revert Make all ipatokenTOTP attributes mandatory

2015-01-21 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4833. Honza -- Jan Cholasta From f5e6e45977b699bada1990f8231d0f142ab6fc61 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Wed, 21 Jan 2015 07:57:03 + Subject: [PATCH] Revert Make all ipatokenTOTP

Re: [Freeipa-devel] [PATCH] 395 Revert Make all ipatokenTOTP attributes mandatory

2015-01-21 Thread Jan Cholasta
Dne 21.1.2015 v 09:09 Martin Kosek napsal(a): On 01/21/2015 09:02 AM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4833. Honza Please also add the reason why we are reverting the change (see details https://bugzilla.redhat.com/show_bug.cgi?id

Re: [Freeipa-devel] [PATCH] 388 Remove RUV from LDIF files before using them in ipa-restore

2015-01-20 Thread Jan Cholasta
Dne 13.1.2015 v 17:58 Jan Cholasta napsal(a): Dne 13.1.2015 v 17:44 Petr Vobornik napsal(a): On 01/12/2015 05:46 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4822. Honza works for me, ACK Thanks, pushed to: master

Re: [Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

2015-01-20 Thread Jan Cholasta
Dne 13.1.2015 v 18:55 Jan Cholasta napsal(a): Dne 13.1.2015 v 18:46 David Kupka napsal(a): On 01/13/2015 05:55 PM, Jan Cholasta wrote: Dne 13.1.2015 v 12:12 Jan Cholasta napsal(a): Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4835. Honza Modified the fix to create

Re: [Freeipa-devel] [PATCH] 492 Add anonymous read ACI for DUA profile

2015-01-20 Thread Jan Cholasta
for me, ACK. Pushed to: master: 0a7a8d66040f7a5f0e55da4b01e614dd9b569a00 ipa-4-1: b54b740f7903a0722930cc281ccb5a2bece45aef Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0184] Always return absolute idnsname in dnszone commands

2015-01-15 Thread Jan Cholasta
Dne 15.1.2015 v 15:39 Martin Basti napsal(a): On 15/01/15 15:07, Jan Cholasta wrote: Dne 15.1.2015 v 14:58 Martin Basti napsal(a): On 15/01/15 14:25, Jan Cholasta wrote: Hi, Dne 15.1.2015 v 13:27 Martin Basti napsal(a): On 15/01/15 13:17, Martin Basti wrote: https://fedorahosted.org

Re: [Freeipa-devel] [PATCH 0184] Always return absolute idnsname in dnszone commands

2015-01-15 Thread Jan Cholasta
['idnsname'] = entry_attrs.single_value['idnsname'].make_absolute() Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0184] Always return absolute idnsname in dnszone commands

2015-01-15 Thread Jan Cholasta
Dne 15.1.2015 v 14:58 Martin Basti napsal(a): On 15/01/15 14:25, Jan Cholasta wrote: Hi, Dne 15.1.2015 v 13:27 Martin Basti napsal(a): On 15/01/15 13:17, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4722 Patch attached. Fast fix. Updated patch attached. 1) Forward zone

Re: [Freeipa-devel] [PATCH] 386 Fix CA certificate renewal syslog alert

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 18:46 David Kupka napsal(a): On 01/08/2015 05:04 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4820. Honza ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 17:45 Jan Cholasta napsal(a): Dne 13.1.2015 v 16:37 Petr Vobornik napsal(a): On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa

Re: [Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 18:46 David Kupka napsal(a): On 01/13/2015 05:55 PM, Jan Cholasta wrote: Dne 13.1.2015 v 12:12 Jan Cholasta napsal(a): Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4835. Honza Modified the fix to create only one service object in stopped_service

Re: [Freeipa-devel] [PATCHES] 391-392 Make certificate renewal process synchronized

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 18:47 David Kupka napsal(a): On 01/13/2015 12:17 PM, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/4803. Note that if you want to test upgrades on CA-less, you need to apply my patch 390 as well: https://www.redhat.com/archives

Re: [Freeipa-devel] [PATCH 0001] ipa-client-install: attempt to get host TGT several times before aborting client installation

2015-01-13 Thread Jan Cholasta
characters) ipa-client/ipa-install/ipa-client-install:2532:80: E501 line too long (81 79 characters) Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

2015-01-13 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4835. Honza -- Jan Cholasta From 09155e3546adbeededbd025dea631c2a5ac39cc6 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 13 Jan 2015 10:59:08 + Subject: [PATCH] Do not crash on unknown services

Re: [Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 10:46 Petr Vobornik napsal(a): On 01/12/2015 06:07 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4824. Honza Is there a reason why `installutils.check_server_configuration() ` is called in `cert_restore_prepare`, ie., method

[Freeipa-devel] [PATCHES] 391-392 Make certificate renewal process synchronized

2015-01-13 Thread Jan Cholasta
Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/4803. Note that if you want to test upgrades on CA-less, you need to apply my patch 390 as well: https://www.redhat.com/archives/freeipa-devel/2015-January/msg00103.html. Honza -- Jan Cholasta From

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4797. Note that --data with data-only backup and --logs-only with data-only restore are deliberately ignored and considered no-op

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 15:54 David Kupka napsal(a): On 01/13/2015 03:07 PM, David Kupka wrote: On 01/13/2015 02:57 PM, Jan Cholasta wrote: Dne 13.1.2015 v 14:44 David Kupka napsal(a): On 01/12/2015 04:50 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 12.1.2015 v 16:30 Rob Crittenden napsal

Re: [Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 16:47 Petr Vobornik napsal(a): On 01/13/2015 11:54 AM, Jan Cholasta wrote: Dne 13.1.2015 v 10:46 Petr Vobornik napsal(a): On 01/12/2015 06:07 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4824. Honza Is there a reason why

Re: [Freeipa-devel] [PATCH 0286] baseldap: Handle missing parent objects properly in *-find

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 16:04 Tomas Babej napsal(a): On 11/21/2014 01:46 PM, Jan Cholasta wrote: Dne 21.11.2014 v 11:28 Tomas Babej napsal(a): On 11/20/2014 04:01 PM, Jan Cholasta wrote: Dne 19.11.2014 v 15:12 Tomas Babej napsal(a): On 11/19/2014 02:03 PM, Jan Cholasta wrote: Dne 19.11.2014 v 13

Re: [Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 17:20 Petr Vobornik napsal(a): On 01/13/2015 05:06 PM, Jan Cholasta wrote: Dne 13.1.2015 v 16:47 Petr Vobornik napsal(a): On 01/13/2015 11:54 AM, Jan Cholasta wrote: Dne 13.1.2015 v 10:46 Petr Vobornik napsal(a): On 01/12/2015 06:07 PM, Jan Cholasta wrote: Hi, the attached

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 16:37 Petr Vobornik napsal(a): On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4797. Note that --data with data-only

Re: [Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 12:12 Jan Cholasta napsal(a): Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4835. Honza Modified the fix to create only one service object in stopped_service. Updated patch attached. -- Jan Cholasta From 2048ecf51b1bc40566abe7f267563aed7d46575e Mon

Re: [Freeipa-devel] [PATCH] 388 Remove RUV from LDIF files before using them in ipa-restore

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 17:44 Petr Vobornik napsal(a): On 01/12/2015 05:46 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4822. Honza works for me, ACK Thanks, pushed to: master: 05e6adecb51b93e9b9d2326df4eabee90c3dfe72 ipa-4-1

[Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-12 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4797. Note that --data with data-only backup and --logs-only with data-only restore are deliberately ignored and considered no-op. Honza -- Jan Cholasta From 6b14a609d726f5b6dc8e94b1d3d21123637599c1 Mon Sep 17 00:00:00

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-12 Thread Jan Cholasta
hostname-bound values? Just checking... IMO the error should be raised in both data-only and full restore, if in unattended mode or the user wishes not to continue. -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-12 Thread Jan Cholasta
Dne 12.1.2015 v 13:37 David Kupka napsal(a): On 01/12/2015 01:14 PM, Jan Cholasta wrote: Dne 12.1.2015 v 13:08 Martin Kosek napsal(a): On 01/12/2015 12:53 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4823 Looking at this patch, are data-only backups supposed to work

[Freeipa-devel] [PATCH] 388 Remove RUV from LDIF files before using them in ipa-restore

2015-01-12 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4822. Honza -- Jan Cholasta From 38223d7d7df123af672a303aa989fb8259e84384 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 12 Jan 2015 15:37:33 + Subject: [PATCH] Remove RUV from LDIF files

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-12 Thread Jan Cholasta
Dne 12.1.2015 v 16:30 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 12.1.2015 v 13:37 David Kupka napsal(a): On 01/12/2015 01:14 PM, Jan Cholasta wrote: Dne 12.1.2015 v 13:08 Martin Kosek napsal(a): On 01/12/2015 12:53 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4823

Re: [Freeipa-devel] [PATCH] 796 migrate-ds: fix compat plugin check

2015-01-12 Thread Jan Cholasta
subtree is present. https://fedorahosted.org/freeipa/ticket/4825 Works for me, ACK. Pushed to: master: e6beaaccceb01a3ce56cfa3edfc8ab0191d51bb1 ipa-4-1: 63ba17049e77dff33b9e2bc98f69976c1c8c24ee Honza -- Jan Cholasta ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

2015-01-12 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4824. Honza -- Jan Cholasta From 0189d9492412cb4f49982c6eba9440677666a358 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 12 Jan 2015 17:03:22 + Subject: [PATCH] Fix ipa-restore on systems

Re: [Freeipa-devel] [PATCH 0179] Fix traceback if zonemgr error message contains unicode characters

2015-01-09 Thread Jan Cholasta
within the terminal? -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 386 Fix CA certificate renewal syslog alert

2015-01-08 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4820. Honza -- Jan Cholasta From 22fa93d3a35321860c8a380b4ae57c7bbd8c8111 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 8 Jan 2015 16:01:42 + Subject: [PATCH] Fix CA certificate renewal syslog

Re: [Freeipa-devel] FreeIPA integration with external DNS services

2014-12-12 Thread Jan Cholasta
, this way admins can use ipa dnsrecod-add and friends w/o exposing the key. +1, we had a short discussion about external DNS with Petr yesterday and reached the same conclusion. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH 0177] Fix adding (warning) messages on client side

2014-12-11 Thread Jan Cholasta
support both lists and tuples, pick just one.) Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0168] Better workaround to get status of CA during upgrade

2014-12-11 Thread Jan Cholasta
Dne 11.12.2014 v 10:01 Martin Basti napsal(a): On 10/12/14 19:21, Jan Cholasta wrote: Dne 10.12.2014 v 18:01 Jan Cholasta napsal(a): Dne 1.12.2014 v 16:48 Martin Basti napsal(a): On 01/12/14 08:46, Jan Cholasta wrote: Hi, Dne 27.11.2014 v 14:24 Martin Basti napsal(a): Ticket: https

Re: [Freeipa-devel] [PATCH 0168] Better workaround to get status of CA during upgrade

2014-12-10 Thread Jan Cholasta
Dne 1.12.2014 v 16:48 Martin Basti napsal(a): On 01/12/14 08:46, Jan Cholasta wrote: Hi, Dne 27.11.2014 v 14:24 Martin Basti napsal(a): Ticket: https://fedorahosted.org/freeipa/ticket/4676 Replaces current workaround. Should go to 4.1.3. Patch attached. When constructing URLs with host:port

Re: [Freeipa-devel] [PATCH] 383 Check subject name encoding in ipa-cacert-manage renew

2014-12-10 Thread Jan Cholasta
Dne 9.12.2014 v 13:03 David Kupka napsal(a): On 12/04/2014 09:36 AM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4781. Honza ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 383 Check subject name encoding in ipa-cacert-manage renew

2014-12-10 Thread Jan Cholasta
Dne 10.12.2014 v 17:53 Martin Basti napsal(a): On 10/12/14 16:02, Martin Kosek wrote: On 12/10/2014 02:35 PM, Jan Cholasta wrote: Dne 10.12.2014 v 11:53 Martin Kosek napsal(a): On 12/09/2014 01:56 PM, Jan Cholasta wrote: Dne 5.12.2014 v 12:01 Jan Cholasta napsal(a): Dne 5.12.2014 v 11:43

Re: [Freeipa-devel] [PATCH 0168] Better workaround to get status of CA during upgrade

2014-12-10 Thread Jan Cholasta
Dne 10.12.2014 v 18:01 Jan Cholasta napsal(a): Dne 1.12.2014 v 16:48 Martin Basti napsal(a): On 01/12/14 08:46, Jan Cholasta wrote: Hi, Dne 27.11.2014 v 14:24 Martin Basti napsal(a): Ticket: https://fedorahosted.org/freeipa/ticket/4676 Replaces current workaround. Should go to 4.1.3. Patch

Re: [Freeipa-devel] [PATCH 0174] Show SSHFP record in CLI if contains space in fingerprint part

2014-12-10 Thread Jan Cholasta
. Pushed to: master: b5ff0b941efad5170ff5fdda4ab05b9f1c7a2113 ipa-4-1: d229c4a1cc397cfe6adf661b6bcc8360a758248c Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 383 Check subject name encoding in ipa-cacert-manage renew

2014-12-09 Thread Jan Cholasta
Dne 5.12.2014 v 12:01 Jan Cholasta napsal(a): Dne 5.12.2014 v 11:43 Martin Kosek napsal(a): On 12/05/2014 11:34 AM, Jan Cholasta wrote: Dne 5.12.2014 v 09:03 Martin Kosek napsal(a): On 12/04/2014 09:36 AM, Jan Cholasta wrote: +if x509.get_der_subject(cert, x509.DER

Re: [Freeipa-devel] [PATCH] 380 Improve validation of --instance and --backend options in ipa-restore

2014-12-09 Thread Jan Cholasta
Dne 9.12.2014 v 14:27 David Kupka napsal(a): On 12/01/2014 01:16 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4744. Honza ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 793-794 Fix schema related replication issues between IPA-3-0 and IPA-4-1

2014-12-09 Thread Jan Cholasta
/ticket/4794 Patch 793: Works for me, ACK. Pushed to: master: 489dfe64689f86f7ddc4ad0784de0636f8e6c1f8 ipa-4-1: 2fa07b1d24f61f9bcff5adb804a18c9eae72932d Patch 794: As Thierry pointed out, this patch is not necessary, as the bug is fixed by patch 793 alone. Not pushed. Honza -- Jan Cholasta

[Freeipa-devel] [PATCH] 384 Do not renew the IPA CA cert by serial number in dogtag-ipa-ca-renew-agent

2014-12-05 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4784. Honza -- Jan Cholasta From 1e268143669621c01973859590af0a22d80255bf Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 4 Dec 2014 15:34:55 + Subject: [PATCH] Do not renew the IPA CA cert

Re: [Freeipa-devel] [PATCH] 383 Check subject name encoding in ipa-cacert-manage renew

2014-12-05 Thread Jan Cholasta
Dne 5.12.2014 v 09:03 Martin Kosek napsal(a): On 12/04/2014 09:36 AM, Jan Cholasta wrote: +if x509.get_der_subject(cert, x509.DER) != der_subject: +raise admintool.ScriptError(Subject name encoding mismatch) I think we can expect this to be a pretty common error

Re: [Freeipa-devel] [PATCH] 383 Check subject name encoding in ipa-cacert-manage renew

2014-12-05 Thread Jan Cholasta
Dne 5.12.2014 v 11:43 Martin Kosek napsal(a): On 12/05/2014 11:34 AM, Jan Cholasta wrote: Dne 5.12.2014 v 09:03 Martin Kosek napsal(a): On 12/04/2014 09:36 AM, Jan Cholasta wrote: +if x509.get_der_subject(cert, x509.DER) != der_subject: +raise admintool.ScriptError

[Freeipa-devel] [PATCH] 383 Check subject name encoding in ipa-cacert-manage renew

2014-12-04 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4781. Honza -- Jan Cholasta From d1d323fa046a9aabed08571c2be2d91a02e866e0 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 4 Dec 2014 08:15:46 + Subject: [PATCH] Check subject name encoding

Re: [Freeipa-devel] [PATCH] 792 add --hosts option to allow/retrieve keytab methods

2014-12-03 Thread Jan Cholasta
Dne 1.12.2014 v 19:25 Petr Vobornik napsal(a): On 12/01/2014 02:33 PM, Jan Cholasta wrote: Hi, Dne 1.12.2014 v 14:17 Petr Vobornik napsal(a): `--hosts` option added to: * service-allow-create-keytab * service-allow-retrieve-keytab * service-disallow-create-keytab * service-disallow-retrieve

[Freeipa-devel] [PATCH] 382 Fix automatic CA cert renewal endless loop in dogtag-ipa-ca-renew-agent

2014-12-03 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4765. Honza -- Jan Cholasta From 5e541c915c3165328bca199f295164a2a9b509e2 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Wed, 3 Dec 2014 07:43:15 + Subject: [PATCH] Fix automatic CA cert renewal

Re: [Freeipa-devel] [PATCH 0288] certs: Fix incorrect flag handling in load_cacert

2014-12-02 Thread Jan Cholasta
of trust flags. For unknown CA certificates, you must keep the default ,, and explicitly override it where necessary. We don't want to trust *any* CA certificate to issue server certs. https://fedorahosted.org/freeipa/ticket/4779 Honza -- Jan Cholasta

Re: [Freeipa-devel] [PATCH 0288] certs: Fix incorrect flag handling in load_cacert

2014-12-02 Thread Jan Cholasta
Dne 2.12.2014 v 13:55 Tomas Babej napsal(a): On 12/02/2014 01:45 PM, Jan Cholasta wrote: Hi, Dne 2.12.2014 v 13:16 Tomas Babej napsal(a): Hi, For CA certificates that are not certificates of IPA CA, we incorrectly set the trust flags to ,,, regardless what the actual trust_flags parameter

Re: [Freeipa-devel] [PATCH 0288] certs: Fix incorrect flag handling in load_cacert

2014-12-02 Thread Jan Cholasta
Dne 2.12.2014 v 14:09 Tomas Babej napsal(a): On 12/02/2014 02:02 PM, Jan Cholasta wrote: Dne 2.12.2014 v 13:55 Tomas Babej napsal(a): On 12/02/2014 01:45 PM, Jan Cholasta wrote: Hi, Dne 2.12.2014 v 13:16 Tomas Babej napsal(a): Hi, For CA certificates that are not certificates of IPA CA

Re: [Freeipa-devel] [PATCH 0289] hosts: Display assigned ID view by default in host-find and show

2014-12-02 Thread Jan Cholasta
, the type of the ipassignedview param should be changed to Str, for consistency with existing code. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0289] hosts: Display assigned ID view by default in host-find and show

2014-12-02 Thread Jan Cholasta
Dne 2.12.2014 v 17:01 Tomas Babej napsal(a): On 12/02/2014 04:14 PM, Jan Cholasta wrote: Hi, Dne 2.12.2014 v 15:43 Tomas Babej napsal(a): Hi, Makes ipaassignedidview a default attribute and takes care about the conversion from the DN to the proper ID view name. https://fedorahosted.org

Re: [Freeipa-devel] [PATCH 0173] Throw zonemgr error message before installation proceeds

2014-12-01 Thread Jan Cholasta
dns.exception.DNSException as e: raise ValueError(e) Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 380 Improve validation of --instance and --backend options in ipa-restore

2014-12-01 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4744. Honza -- Jan Cholasta From 204a065d67a65d9ed43e5eaa22958cd8daf7b15f Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 1 Dec 2014 12:12:15 + Subject: [PATCH] Improve validation of --instance

Re: [Freeipa-devel] [PATCH 0173] Throw zonemgr error message before installation proceeds

2014-12-01 Thread Jan Cholasta
Dne 1.12.2014 v 09:10 Jan Cholasta napsal(a): Hi, Dne 27.11.2014 v 14:20 Martin Basti napsal(a): Ticket: https://fedorahosted.org/freeipa/ticket/4771 Patch attached. I would prefer if you did something like this instead: 1) Add validate_idn_normalized function with the normalized IDN

Re: [Freeipa-devel] [PATCH] 792 add --hosts option to allow/retrieve keytab methods

2014-12-01 Thread Jan Cholasta
importance compared to other fields. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0168] Better workaround to get status of CA during upgrade

2014-11-30 Thread Jan Cholasta
-python in the spec file. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCHES] 366-372 Additional Coverity fixes

2014-11-25 Thread Jan Cholasta
Dne 25.11.2014 v 09:19 Alexander Bokovoy napsal(a): On Tue, 11 Nov 2014, Jan Cholasta wrote: Dne 10.11.2014 v 19:25 Jan Cholasta napsal(a): Hi, the attached patches provide additional fixes for https://fedorahosted.org/freeipa/ticket/4651. I'm not 100% sure if the fixes for ipa-sam and ipa

Re: [Freeipa-devel] [PATCH] 1111 Use NSS protocol range setter

2014-11-25 Thread Jan Cholasta
Dne 24.11.2014 v 15:59 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 21.11.2014 v 16:09 Rob Crittenden napsal(a): Jan Cholasta wrote: Hi, Dne 20.11.2014 v 23:26 Rob Crittenden napsal(a): Use new capability in python-nss-0.16 to use the NSS protocol range setter. This lets us enable

Re: [Freeipa-devel] [PATCH 0172] Fix zonemgr option encoding detection

2014-11-25 Thread Jan Cholasta
Hi, Dne 25.11.2014 v 14:07 Martin Basti napsal(a): Ticket: https://fedorahosted.org/freeipa/ticket/4766 Patch attached. Thanks, ACK. Hopefully it's correct this time. Pushed to: master: c13862104ab64cda81c86c51b849c8d01c3c9187 ipa-4-1: e457a3e615b695cfd98e7d54594e5a3663562b06 Honza -- Jan

Re: [Freeipa-devel] [PATCH 0172] Fix zonemgr option encoding detection

2014-11-25 Thread Jan Cholasta
Hi, Dne 25.11.2014 v 14:07 Martin Basti napsal(a): Ticket: https://fedorahosted.org/freeipa/ticket/4766 Patch attached. Thanks, ACK. Hopefully it's correct this time. Pushed to: master: c13862104ab64cda81c86c51b849c8d01c3c9187 ipa-4-1: e457a3e615b695cfd98e7d54594e5a3663562b06 Honza -- Jan

Re: [Freeipa-devel] [PATCH] 1111 Use NSS protocol range setter

2014-11-24 Thread Jan Cholasta
Dne 21.11.2014 v 16:09 Rob Crittenden napsal(a): Jan Cholasta wrote: Hi, Dne 20.11.2014 v 23:26 Rob Crittenden napsal(a): Use new capability in python-nss-0.16 to use the NSS protocol range setter. This lets us enable TLSv1.1 and TLSv1.2 for client connections. I made this configurable via

Re: [Freeipa-devel] [PATCH 0171] Fix encoding detection of zonemgr option

2014-11-24 Thread Jan Cholasta
Hi, Dne 24.11.2014 v 14:01 Martin Basti napsal(a): Ticket: https://fedorahosted.org/freeipa/ticket/4762 Patch attached. Thanks, ACK. Pushed to: master: 230df95ed9e043069da0008d046b6b0135b0a8d1 ipa-4-1: 880f1e5c277a8826e3334723cd840cae4e65dfb8 Honza -- Jan Cholasta

Re: [Freeipa-devel] [PATCHES] 366-372 Additional Coverity fixes

2014-11-24 Thread Jan Cholasta
Dne 24.11.2014 v 14:44 Alexander Bokovoy napsal(a): On Tue, 18 Nov 2014, Jan Cholasta wrote: Dne 12.11.2014 v 08:58 Petr Spacek napsal(a): On 11.11.2014 12:27, Jan Cholasta wrote: Dne 11.11.2014 v 11:40 Alexander Bokovoy napsal(a): On Tue, 11 Nov 2014, Jan Cholasta wrote: From

Re: [Freeipa-devel] [PATCHES] 366-372 Additional Coverity fixes

2014-11-24 Thread Jan Cholasta
Dne 11.11.2014 v 11:13 Jan Cholasta napsal(a): Dne 10.11.2014 v 19:25 Jan Cholasta napsal(a): Hi, the attached patches provide additional fixes for https://fedorahosted.org/freeipa/ticket/4651. I'm not 100% sure if the fixes for ipa-sam and ipa-kdb are correct, please check them carefully

[Freeipa-devel] [PATCH] 377 Use correct service name in cainstance.backup_config

2014-11-21 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4754. Honza -- Jan Cholasta From c1db9d92088436234d2a00c946a8e470d740745b Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Fri, 21 Nov 2014 07:52:24 + Subject: [PATCH] Use correct service name

Re: [Freeipa-devel] [PATCH 0169] Fix: read_ip_address should return CheckedIPAddress instance instead of string

2014-11-21 Thread Jan Cholasta
Hi, Dne 20.11.2014 v 17:52 Martin Basti napsal(a): Ticket: https://fedorahosted.org/freeipa/ticket/4747 Patch attached: ACK! Pushed to: master: 7de424f42541e73ed24a95f1dd90ff4a61e111fa ipa-4-1: 5b397dced1ef4a1eea7b3636fc71c2b7108a0b25 Honza -- Jan Cholasta

<    6   7   8   9   10   11   12   13   14   15   >