Re: [Freeipa-devel] [PATCH 0149] Clean up PTR record synchronization code and make it more robust

On (06/05/13 14:03), Petr Spacek wrote: On 18.4.2013 11:04, Petr Spacek wrote: Hello, Clean up PTR record synchronization code and make it more robust. PTR record synchronization was split to smaller functions. Input validation, error handling and logging was improved significantly. Tbabej's

[Freeipa-devel] [PATCH] Use pkg-config to detect cmocka

ehlo, libcmocka-0.3 was released and package is available in fedore = 18. libcmocka-devel contains pkg-config file, therefore it is better to use pkg-config to detect this library. Patch is attached. LS From d1460ea58256d96a6cb834097a31d5235c7c0943 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik

Re: [Freeipa-devel] [PATCH] Use pkg-config to detect cmocka

On (04/07/13 13:10), Alexander Bokovoy wrote: On Thu, 04 Jul 2013, Lukas Slebodnik wrote: ehlo, libcmocka-0.3 was released and package is available in fedore = 18. libcmocka-devel contains pkg-config file, therefore it is better to use pkg-config to detect this library. Patch is attached. Few

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools configuration more modern. -- Petr^2 Spacek From 07caec808e394bfcbd898905e917731cb3778e68 Mon Sep 17 00:00:00 2001 From: Petr Spacek

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

On (10/07/13 10:48), Jakub Hrozek wrote: On Wed, Jul 10, 2013 at 10:29:35AM +0200, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools configuration more modern

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

On (10/07/13 11:14), Jakub Hrozek wrote: On Wed, Jul 10, 2013 at 10:59:10AM +0200, Lukas Slebodnik wrote: On (10/07/13 10:48), Jakub Hrozek wrote: On Wed, Jul 10, 2013 at 10:29:35AM +0200, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

On (10/07/13 12:27), Petr Spacek wrote: On 10.7.2013 10:29, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools configuration more modern. -- Petr^2 Spacek From

[Freeipa-devel] [PATCHES] Fix C compiler warnings

warrning and does not fix problem. LS From a186f016a6bbfec60cceacde82cf505ecef1b646 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Tue, 23 Jul 2013 00:37:32 +0200 Subject: [PATCH 1/3] Use right function prototype for thread function warning: passing argument from incompatible

Re: [Freeipa-devel] [PATCH] Debian client support

On (03/09/13 00:43), Timo Aaltonen wrote: This fixes https://fedorahosted.org/freeipa/ticket/1887 and https://fedorahosted.org/freeipa/ticket/2455 the first three patches fix some bugs in how python is used fourth patch checks if dbus is already running before trying to start it fifth fixes some

[Freeipa-devel] [PATCH][bind-dyndb-ldap] Fix warning duplicate 'const' declaration specifier

Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Wed, 30 Oct 2013 08:52:59 +0100 Subject: [PATCH] Fix warning duplicate 'const' declaration specifier It does not make sense to have const twice in declaration like a const settings_set_t const settings_default_set This one

Re: [Freeipa-devel] [PATCH] Debian client support

On (05/09/13 23:25), Lukas Slebodnik wrote: On (03/09/13 00:43), Timo Aaltonen wrote: This fixes https://fedorahosted.org/freeipa/ticket/1887 and https://fedorahosted.org/freeipa/ticket/2455 the first three patches fix some bugs in how python is used fourth patch checks if dbus is already

[Freeipa-devel] [PATCH] Fix linking ipa-otpd with broken hardened build

ehlo, How to test: -remove line %define _hardened_build 1 from spec file -build freeeipa package (it should fail) -apply patch -build freeeipa package (it should work ) simple patch attached. LS From 0ae1582770706f5a88980c0a16d4c64ce58c98e2 Mon Sep 17 00:00:00 2001 From: Lukas

Re: [Freeipa-devel] [PATCH] Fix linking ipa-otpd with broken hardened build

On (28/01/14 20:56), Lukas Slebodnik wrote: ehlo, How to test: -remove line %define _hardened_build 1 from spec file -build freeeipa package (it should fail) -apply patch -build freeeipa package (it should work ) simple patch attached. LS From

Re: [Freeipa-devel] [PATCH] Fix linking ipa-otpd with broken hardened build

On (29/01/14 09:46), Martin Kosek wrote: On 01/28/2014 08:59 PM, Lukas Slebodnik wrote: On (28/01/14 20:56), Lukas Slebodnik wrote: ehlo, How to test: -remove line %define _hardened_build 1 from spec file -build freeeipa package (it should fail) -apply patch -build freeeipa

Re: [Freeipa-devel] Reviewer in Trac

On (20/02/14 15:09), Martin Kosek wrote: On 02/20/2014 02:54 PM, Petr Spacek wrote: On 20.2.2014 14:47, Martin Kosek wrote: On 02/20/2014 02:31 PM, Jan Cholasta wrote: On 20.2.2014 13:14, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which

Re: [Freeipa-devel] [PATCH 0224-0225] Add function attributes warn_unused_result and nonnull and add missing CHECK()s to string operations

On (21/02/14 10:20), Nathaniel McCallum wrote: On Fri, 2014-02-21 at 16:17 +0100, Petr Spacek wrote: On 21.2.2014 16:16, Nathaniel McCallum wrote: On Fri, 2014-02-21 at 16:12 +0100, Petr Spacek wrote: Hello, Add function attributes warn_unused_result and nonnull where appropriate and

Re: [Freeipa-devel] [PATCH 0224-0225] Add function attributes warn_unused_result and nonnull and add missing CHECK()s to string operations

On (21/02/14 16:12), Petr Spacek wrote: Hello, Add function attributes warn_unused_result and nonnull where appropriate and add missing CHECK()s to string operations. Lukas, thanks for catching the missing CHECK() around str_new(). As a reward, you can review attached patches. Have fun! :-)

Re: [Freeipa-devel] [PATCH][bind-dyndb-ldap] Fix potential dereference of NULL pointer in sync_ctx_init

dcf99122eb33b63799be91d3c13a9967420880c3 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Fri, 21 Feb 2014 19:18:28 +0100 Subject: [PATCH] Fix potential dereference of NULL pointer in sync_ctx_init Value is asigned to the output argument sync_ctx_t **sctxp before returning ISC_R_SUCCESS. Thus we

Re: [Freeipa-devel] [PATCH 0225] Remove unused variables and dead code from syncrepl_update()

On (24/02/14 13:36), Petr Spacek wrote: Hello, Remove unused variables and dead code from syncrepl_update(). -- Petr^2 Spacek From 0a779d8cbf7a9d63567967600786202a060d7859 Mon Sep 17 00:00:00 2001 From: Petr Spacek pspa...@redhat.com Date: Mon, 24 Feb 2014 13:35:23 +0100 Subject: [PATCH]

Re: [Freeipa-devel] [PATCH 0228] Drop unnecessary #define _BSD_SOURCE

On (24/02/14 16:48), Petr Spacek wrote: Hello, Drop unnecessary #define _BSD_SOURCE. -- Petr^2 Spacek From 1b5105e3ab92f2a898313da5f7e20e6f3e9d1d2a Mon Sep 17 00:00:00 2001 From: Petr Spacek pspa...@redhat.com Date: Mon, 24 Feb 2014 16:48:09 +0100 Subject: [PATCH] Drop unnecessary #define

Re: [Freeipa-devel] [PATCH 0228] Drop unnecessary #define _BSD_SOURCE

On (25/02/14 09:54), Petr Spacek wrote: On 24.2.2014 18:56, Lukas Slebodnik wrote: On (24/02/14 16:48), Petr Spacek wrote: Hello, Drop unnecessary #define _BSD_SOURCE. -- Petr^2 Spacek From 1b5105e3ab92f2a898313da5f7e20e6f3e9d1d2a Mon Sep 17 00:00:00 2001 From: Petr Spacek pspa...@redhat.com

[Freeipa-devel] [PATCH][bind-dyndb-ldap] AUTOCONF: Improve detection of bind9 header files

118301596dadc2ef66437e7c6661c5fb84459611 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Tue, 25 Feb 2014 10:46:50 +0100 Subject: [PATCH] AUTOCONF: Improve detection of bind9 header files bind9 header files are stored in non-default path (/usr/include/bind9) There is an utility

Re: [Freeipa-devel] Daily build of the documentation?

On (04/03/14 13:48), Martin Kosek wrote: On 10/25/2013 05:22 PM, Jérôme Fenal wrote: 2013/10/25 Martin Basti mba...@redhat.com: On Fri, 2013-10-25 at 16:48 +0200, Jérôme Fenal wrote: Hi all, Do we have a place where we publish a daily build of the documentation? I'd like to send such a link

Re: [Freeipa-devel] FreeIPA repository and it's committers

On (28/03/14 13:14), Martin Kosek wrote: This week there was a request to be added to the list of FreeIPA committers, which I denied as the person was not a member of the short list of selected trusted active core upstream developers doing the pushes. When thinking about the request I realized we

Re: [Freeipa-devel] [PATCH 0234] Prevent NULL dereference before sync_concurr_limit_signal() calls

On (09/04/14 16:38), Petr Spacek wrote: On 9.4.2014 15:20, Tomas Hozza wrote: On 04/09/2014 02:07 PM, Petr Spacek wrote: Hello, Prevent NULL dereference before sync_concurr_limit_signal() calls. Missing check was causing NULL dereference in case where manager_get_ldap_instance() failed. This

Re: [Freeipa-devel] [PATCH 0239-0243] Refactor ldap_parse_master_zoneentry()

On (06/05/14 17:15), Petr Spacek wrote: On 6.5.2014 14:41, Tomas Hozza wrote: - Original Message - Hello, This patch set attempts to move ldap_parse_master_zoneentry() a little bit closer to sane code. It is preparation for https://fedorahosted.org/bind-dyndb-ldap/ticket/56 -- Petr^2

Re: [Freeipa-devel] [PATCH 0269] Silence GCC warning about uninitialized ldap_writeback

On (24/06/14 16:46), Petr Spacek wrote: Hello, Silence GCC warning about uninitialized ldap_writeback. It seems like false positive, I can't imagine how ldap_writeback could be used without prior initialization. -- Petr^2 Spacek From eb253b58d6214b3f94d22c3ec2dcf62d0103ad46 Mon Sep 17

Re: [Freeipa-devel] [PATCH 0267-0268] Preparation for 4.4 release

On (24/06/14 21:34), Martin Kosek wrote: On 06/24/2014 05:37 PM, Petr Spacek wrote: On 23.6.2014 17:12, Petr Spacek wrote: Hello, Bump NVR to 4.4. Update NEWS for upcoming 4.4 release. Pushed to master: 2cd574e90a9fdebdbeaab45ef335e7d63e85dfd7 3a705963ed575f01b792a7e89d825cf56ce99734 At this

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

: There is a missing break. Ithink it is a problem, because you do not want to fall through to the defaul and override errmsg. Smple patch is attached. LS From 2f9060c011e7dd719887d7935a809887e26ac1e5 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Sat, 12 Jul 2014 18:28:38

Re: [Freeipa-devel] Design Review Keytab Retrieval

rc; step 5: Variable enctypes going out of scope leaks the storage it points to. Patch0004 is attached. LS From 0f931433707d8a5ddbb9870192a28ce7bbd6a624 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Sat, 12 Jul 2014 18:31:42 +0200 Subject: [PATCH 3/4] Remove unsed

[Freeipa-devel] [PATCH] Fix warning: Using uninitialized value ld.

ehlo, If create_getkeytab_control fails variable uninitialized pointer 'ld' will be used in done section. Simple patch is attached. From 6d882d2ede4d639dde2883bb147f3921fc46ae1c Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Sat, 12 Jul 2014 18:18:21 +0200 Subject

Re: [Freeipa-devel] #4534: SSSD deref processing fail when entryusn can be read and objectclass doesn't

On (11/09/14 22:24), Martin Kosek wrote: On 09/11/2014 08:49 PM, Simo Sorce wrote: On Thu, 2014-09-11 at 20:28 +0200, Martin Kosek wrote: On 09/11/2014 05:37 PM, Simo Sorce wrote: On Thu, 2014-09-11 at 17:03 +0200, Martin Kosek wrote: Hello, We have another important issue to resolve. Current

Re: [Freeipa-devel] FreeIPA 4.1 release preparations

On (20/10/14 16:08), Martin Kosek wrote: On 10/20/2014 04:00 PM, Jan Pazdziora wrote: On Mon, Oct 20, 2014 at 03:58:27PM +0200, Petr Vobornik wrote: The plan is to release 4.1 and then 4.0.4. Besides usual tarballs, 4.1 will go into Fedora rawhide, f21-updates-testing and mkosek/freeipa copr

Re: [Freeipa-devel] FreeIPA 4.1 release preparations

On (09/11/14 10:09), Martin Kosek wrote: On 11/08/2014 02:43 PM, Lukas Slebodnik wrote: On (20/10/14 16:08), Martin Kosek wrote: On 10/20/2014 04:00 PM, Jan Pazdziora wrote: On Mon, Oct 20, 2014 at 03:58:27PM +0200, Petr Vobornik wrote: The plan is to release 4.1 and then 4.0.4. Besides usual

Re: [Freeipa-devel] FreeIPA Copr repo plan

On (10/11/14 07:53), John Dennis wrote: On 11/10/2014 06:07 AM, Martin Kosek wrote: c) Daily repos Should we deprecate old John's repos (http://www.freeipa.org/page/Downloads#Bleeding_Edge) which is difficult to maintain and replace them with Copr ones? I.e. to have common repo (e.g.

Re: [Freeipa-devel] [PATCH][bind-dyndb-ldap] AUTOCONF: Improve detection of bind9 header files

On (12/11/14 15:30), Petr Spacek wrote: On 24.7.2014 11:00, Petr Spacek wrote: On 27.2.2014 15:19, Lukas Slebodnik wrote: ehlo, I did some reviews of bind-dyndb-ldap last week and it was little bit annoying to export special CFLAGS for bind9 header files. It can be automatically detected

Re: [Freeipa-devel] [PATCH 0228] Drop unnecessary #define _BSD_SOURCE

On (12/11/14 16:34), Petr Spacek wrote: On 25.2.2014 15:05, Lukas Slebodnik wrote: On (25/02/14 09:54), Petr Spacek wrote: On 24.2.2014 18:56, Lukas Slebodnik wrote: On (24/02/14 16:48), Petr Spacek wrote: Hello, Drop unnecessary #define _BSD_SOURCE. -- Petr^2 Spacek From

Re: [Freeipa-devel] [PATCH 0228] Drop unnecessary #define _BSD_SOURCE

On (26/11/14 16:51), Petr Spacek wrote: On 26.11.2014 16:47, Lukas Slebodnik wrote: On (12/11/14 16:34), Petr Spacek wrote: On 25.2.2014 15:05, Lukas Slebodnik wrote: On (25/02/14 09:54), Petr Spacek wrote: On 24.2.2014 18:56, Lukas Slebodnik wrote: On (24/02/14 16:48), Petr Spacek wrote

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

On (02/12/14 21:13), Gabe Alford wrote: This patch removes the changelog and Makefile.am for ipaclient as well. Thanks, Gabe On Mon, Dec 1, 2014 at 8:28 AM, Martin Kosek mko...@redhat.com wrote: On 12/01/2014 04:25 PM, Rob Crittenden wrote: Gabe Alford wrote: On Mon, Dec 1, 2014 at 6:05

Re: [Freeipa-devel] [PATCH] 0035 client: Update DNS with all available local IP addresses.

On (15/01/15 20:38), Martin Basti wrote: On 15/01/15 20:24, Martin Basti wrote: On 15/01/15 17:13, David Kupka wrote: On 01/15/2015 03:22 PM, David Kupka wrote: On 01/15/2015 12:43 PM, David Kupka wrote: On 01/12/2015 06:34 PM, Martin Basti wrote: On 09/01/15 14:43, David Kupka wrote: On

Re: [Freeipa-devel] Build issues with IPA Server 4.1.99.201502010530GIT782ad36

On (01/02/15 18:26), Martin Basti wrote: On 01/02/15 06:38, William wrote: Running make in freeipa master: IPA Server 4.1.99.201502010530GIT782ad36 prefix: /usr exec_prefix:

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

On (06/03/15 15:05), Lukas Slebodnik wrote: On (05/03/15 16:20), Petr Vobornik wrote: On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: On (05/03/15 08:54), Petr Vobornik wrote: On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: ehlo, Please review attached patches and fix freeipa in fedora 22 ASAP. I

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

On (06/03/15 16:13), Alexander Bokovoy wrote: On Fri, 06 Mar 2015, Lukas Slebodnik wrote: On (05/03/15 16:20), Petr Vobornik wrote: On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: On (05/03/15 08:54), Petr Vobornik wrote: On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: ehlo, Please review attached

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

On (05/03/15 16:20), Petr Vobornik wrote: On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: On (05/03/15 08:54), Petr Vobornik wrote: On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: ehlo, Please review attached patches and fix freeipa in fedora 22 ASAP. I think the most critical is 1st patch sh

[Freeipa-devel] [RFC] COPR drop support for old distribution

ehlo, CentOS 7.1 was finally released[1]. Yupi. Fedora 21 was rewleased[2] few months ago. People can use FreeIPA 4.1 without any problem. So there's no more reason to maintain COPR repositories for older distributions. It will significantly reduce extra dependencies in repositories. It would

[Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Fri, 27 Feb 2015 20:40:06 +0100 Subject: [PATCH 1/3] SPEC: Explicitly requires python-sssdconfig Resolves: https://fedorahosted.org/freeipa/ticket/4929 --- freeipa.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

On (05/03/15 08:54), Petr Vobornik wrote: On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: ehlo, Please review attached patches and fix freeipa in fedora 22 ASAP. I think the most critical is 1st patch sh$ git grep SSSDConfig | grep import install/tools/ipa-upgradeconfig:import SSSDConfig ipa

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

On (29/01/15 12:57), Martin Babinsky wrote: Date: Wed, 28 Jan 2015 16:28:01 +0100 Subject: [PATCH 6/7] ipa-uuid: emit a message when unexpected mod type is encountered This patch is related to the following defect reported by covscan of FreeIPA master code: Error: DEADCODE (CWE-561):

Re: [Freeipa-devel] [PATCH 0364] Remove unused files rdlist.c and rdlist.h

On (15/05/15 11:44), Petr Spacek wrote: Hello, Remove unused files rdlist.c and rdlist.h. I noticed this cruft while preparing the previous patchset. This patch is independent and applicable directly to master branch. I had an issue with applicable directly to master branch :-) I had to use

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

On (08/04/15 10:22), David Kupka wrote: On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On 27.3.2015 14:58, David Kupka wrote: pylint changed slightly so we

Re: [Freeipa-devel] [PATCH 0050] Allow to skip lint when building FreeIPA.

On (04/06/15 12:20), David Kupka wrote: -- David Kupka From f68607e9a3db4cd8893c465d804615aac34afc29 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Thu, 4 Jun 2015 12:10:37 +0200 Subject: [PATCH] Allow to skip lint when building FreeIPA. Target 'lint' does nothing when

Re: [Freeipa-devel] [PATCH 0038] increase NSS memcache timeout for IPA server

On (27/05/15 13:25), Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/4964 -- Martin^3 Babinsky From ef8481ee0267a720551832baae9398b435b3c6c5 Mon Sep 17 00:00:00 2001 From: Martin Babinsky mbabi...@redhat.com Date: Tue, 26 May 2015 18:11:08 +0200 Subject: [PATCH] increase NSS

Re: [Freeipa-devel] [PATCH 0245] Fix uniqueness plugins vol. 2

On (12/05/15 21:03), Martin Basti wrote: On 12/05/15 18:23, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4921 To test this, the mkosek/freeipa-master copr repo with 389-ds-base 1.3.4.0 is needed. All previous changes to uniqueness plugins were made just in master branch so upgrade

Re: [Freeipa-devel] [PATCH 02261] Revert 389 DS BuildRequires version

On (29/05/15 10:33), Martin Basti wrote: On 29/05/15 09:23, Lukas Slebodnik wrote: On (12/05/15 21:03), Martin Basti wrote: On 12/05/15 18:23, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4921 To test this, the mkosek/freeipa-master copr repo with 389-ds-base 1.3.4.0 is needed

Re: [Freeipa-devel] [PATCH 02261] Revert 389 DS BuildRequires version

On (29/05/15 10:56), Ludwig Krispenz wrote: Hi, the topology plugin relies on a change in DS to be able to mark replication agreements, this fix is in master and will be in 1.3.3.11 (but I think it is not yet out) Do you mean a built time dependency or run time dependency? Because I didn't have

Re: [Freeipa-devel] [PATCH 0321] Update and standardize copyright headers; introduce AUTHORS file

On (28/04/15 14:50), Petr Spacek wrote: Hello, I'm going to add couple new files to the source tree and current copyright header drove me mad, so here is (finally) a clenaup. Update and standardize copyright headers; introduce AUTHORS file. Dates in all headers were harmonized with Git

Re: [Freeipa-devel] C coding style guide update

On (27/07/15 15:54), Michal Židek wrote: On 07/26/2015 10:09 PM, Jakub Hrozek wrote: - Variable Length arrays are very helpful, but explicitly mention they should be used with caution, especially if array size might come from the user +1 We overuse talloc for very small

Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch

On (10/08/15 15:22), Jan Cholasta wrote: Dne 7.8.2015 v 09:17 Martin Kosek napsal(a): On 08/07/2015 08:46 AM, Jan Cholasta wrote: Dne 7.8.2015 v 08:44 Martin Kosek napsal(a): On 08/06/2015 05:26 PM, Milan Kubík wrote: Hi list, I just noticed that the bits built from ipa-4-2 branch cannot be

[Freeipa-devel] [PATCH] BUILD: provide check target in custom Makefiles

ehlo, The automake generated makefiles have already a target check. We need to provide this target also to non-generated Makefiles so we can recursively call make check from top level Makefile. LS >From ba0e01bb8dd754b24580615decf54b718ba07b2e Mon Sep 17 00:00:00 2001 From: Lukas Slebod

[Freeipa-devel] [PATCH] ipa_kdb_tests: Fix test with default krb5.conf

ehlo, ipa_kdb_tests test failed for me on minimal f23. LS >From ba5ecf13cac1b4822651987ba5db9ed16214cb8f Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Thu, 12 Nov 2015 19:22:56 + Subject: [PATCH 1/8] ipa_kdb_tests: Fix test with default krb5.conf Def

[Freeipa-devel] [PATCHES] Fix few gcc warnings

ehlo, Few simple patches are attached. LS >From e7320a93df1f20e6f29e0a067187e70b41c10ef8 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Thu, 12 Nov 2015 19:25:15 + Subject: [PATCH 2/8] ipa_kdb_tests: Remove unused variables --- daemons/ipa-

[Freeipa-devel] [PATCH] cmocka_tests: Do not use deprecated cmocka interface

ehlo, The cmocka-1.0 introduced new interface for tests which is not compatible with the old one. And the old interface is deprecated which caused compiled warnings. LS >From 15c7610984f8561bceca2a729fc4cc7e81a1d2b1 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com>

[Freeipa-devel] [PATCH] SPEC: Run cmocka based uni test in %check phase

ehlo, this patch depends on freeipa-lslebodn-0007-BUILD-provide-check-target-in-custom-Makefile.patch LS >From 507b57b4a166b0490d4217a9603a67577bb36036 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Fri, 13 Nov 2015 07:11:38 + Subject: [PATCH 8/8] SPEC: R

Re: [Freeipa-devel] [PATCH] SPEC: Drop sssd from BuildRequires

On (05/11/15 09:24), Alexander Bokovoy wrote: >On Thu, 05 Nov 2015, Lukas Slebodnik wrote: >>On (04/11/15 18:12), Alexander Bokovoy wrote: >>>On Tue, 03 Nov 2015, Lukas Slebodnik wrote: >>>>>From c466be0e769a80fe204fc70675b8fa0ea3efb7b2 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] SPEC: Drop sssd from BuildRequires

On (04/11/15 18:12), Alexander Bokovoy wrote: >On Tue, 03 Nov 2015, Lukas Slebodnik wrote: >>>From c466be0e769a80fe204fc70675b8fa0ea3efb7b2 Mon Sep 17 00:00:00 2001 >>From: Lukas Slebodnik <lsleb...@redhat.com> >>Date: Mon, 2 Nov 2015 19:52:57 + >>S

Re: [Freeipa-devel] [PATCH] SPEC: Run cmocka based uni test in %check phase

On (13/11/15 09:37), Lukas Slebodnik wrote: >ehlo, > >this patch depends on >freeipa-lslebodn-0007-BUILD-provide-check-target-in-custom-Makefile.patch > >LS >>From 507b57b4a166b0490d4217a9603a67577bb36036 Mon Sep 17 00:00:00 2001 >From: Lukas Slebodnik <lsleb...@

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On (02/12/15 15:41), Tomas Babej wrote: > > >On 12/02/2015 09:24 AM, Tomas Babej wrote: >> >> >> On 12/01/2015 06:27 PM, Tomas Babej wrote: >>> >>> >>> On 11/30/2015 05:32 PM, Lukas Slebodnik wrote: >>>> On (30/11/15 13:09), To

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On (03/12/15 11:35), Tomas Babej wrote: > > >On 12/02/2015 05:25 PM, Lukas Slebodnik wrote: >> On (02/12/15 15:41), Tomas Babej wrote: >>> >>> >>> On 12/02/2015 09:24 AM, Tomas Babej wrote: >>>> >>>> >>>> On 12/01/201

Re: [Freeipa-devel] patch acceptance criteria

On (02/12/15 13:14), Rob Crittenden wrote: >Is it still mandatory that tests pass the unit tests before acceptance? Unit test could be executed as part of "%check" phase in spec files. I recently added C-base unit tests there. I was not bale to run "make tests" there because many tests failed. If

Re: [Freeipa-devel] patch acceptance criteria

On (03/12/15 09:59), Rob Crittenden wrote: >Lukas Slebodnik wrote: >> On (02/12/15 13:14), Rob Crittenden wrote: >>> Is it still mandatory that tests pass the unit tests before acceptance? >> Unit test could be executed as part of "%check" phase in spec files. >

Re: [Freeipa-devel] patch acceptance criteria

On (03/12/15 15:53), Petr Spacek wrote: >On 3.12.2015 15:34, Rob Crittenden wrote: >> Martin Kosek wrote: >>> On 12/03/2015 09:08 AM, Petr Spacek wrote: On 2.12.2015 19:14, Rob Crittenden wrote: > Is it still mandatory that tests pass the unit tests before acceptance? > I've seen a

Re: [Freeipa-devel] [PATCH 0392] tests: Fix incorrect uninstall method invocation

On (07/12/15 11:12), Oleg Fayans wrote: >Hi Tomaš, > >Could you please review my patch regarding caless tests. I's been on the >list since ages. It contains this particular change together with a lot >more of them. > We are used to sending "bump" mails on sssd-devel. It's better then sending mail

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On (10/12/15 11:40), Tomas Babej wrote: >On 12/10/2015 09:05 AM, Lukas Slebodnik wrote: >> On (08/12/15 14:47), Tomas Babej wrote: >>> >>> >>> On 12/03/2015 04:33 PM, Tomas Babej wrote: >>>> >>>> >>>> On 12/03/2015 04:26

Re: [Freeipa-devel] [PATCH 0069] Add 'review' target for make

On (11/12/15 09:46), Petr Spacek wrote: >On 11.12.2015 09:22, Lukas Slebodnik wrote: >> On (10/12/15 18:04), Petr Spacek wrote: >>> On 9.12.2015 15:30, Petr Spacek wrote: >>>> Hello, >>>> >>>> this patch automates some of sanity checks pro

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On (08/12/15 14:47), Tomas Babej wrote: > > >On 12/03/2015 04:33 PM, Tomas Babej wrote: >> >> >> On 12/03/2015 04:26 PM, Aleš Mareček wrote: >>> Hello, >>> >>> ACK for code >>> NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py >>> (this function should be in some more

Re: [Freeipa-devel] [PATCH 0069] Add 'review' target for make

On (10/12/15 18:04), Petr Spacek wrote: >On 9.12.2015 15:30, Petr Spacek wrote: >> Hello, >> >> this patch automates some of sanity checks proposed by Petr Vobornik. >> >> 'make review' should be used in root of clean Git tree which has patches >> under >> review applied. >> +1 for

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On (09/12/15 19:22), Martin Basti wrote: >https://fedorahosted.org/freeipa/ticket/5535 > >Patch attached. >From 8ef93485d61e8732166fb0c5b6c4559209740f3e Mon Sep 17 00:00:00 2001 >From: Martin Basti >Date: Wed, 9 Dec 2015 18:53:35 +0100 >Subject: [PATCH] Fix version comparison

Re: [Freeipa-devel] [PATCH 0115] fix error message assertion in negative forced client reenrollment tests

On (08/12/15 18:02), Martin Babinsky wrote: >This patch fixes the assertions in negative test cases of >'test_forced_client_reenrollment' CI test suite. > >On ipa-4-2 it fixes https://fedorahosted.org/freeipa/ticket/5511 and makes >all 8 tests in this suite green, shiny and happy again. > >It also

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

On (15/12/15 01:05), Petr Vobornik wrote: >Blocking patches for FreeIPA 4.3 were pushed, ipa-4-3 branch was created. >Master branch is ready for 4.4 development. > >A build is available for testing in my pvoborni/freeipa-4-3 COPR repo [1] >until the official 4.3 repo is created. The repo contains

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

On (15/12/15 01:05), Petr Vobornik wrote: >Blocking patches for FreeIPA 4.3 were pushed, ipa-4-3 branch was created. >Master branch is ready for 4.4 development. > >A build is available for testing in my pvoborni/freeipa-4-3 COPR repo [1] >until the official 4.3 repo is created. The repo contains

Re: [Freeipa-devel] [PATCH-0019][Tests]Enabled --auto-reverse by default for master installation

On (17/12/15 13:53), Oleg Fayans wrote: > >-- >Oleg Fayans >Quality Engineer >FreeIPA team >RedHat. >From ed4630140386c1043e36733eb42ec402cc276bee Mon Sep 17 00:00:00 2001 >From: Oleg Fayans >Date: Thu, 17 Dec 2015 13:50:19 +0100 >Subject: [PATCH] Enabled automatic creation

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

On (15/12/15 08:32), Lukas Slebodnik wrote: >On (15/12/15 01:05), Petr Vobornik wrote: >>Blocking patches for FreeIPA 4.3 were pushed, ipa-4-3 branch was created. >>Master branch is ready for 4.4 development. >> >>A build is available for testing in my pvoborni/freeip

Re: [Freeipa-devel] 4.3 on rawhide build task fail

replace macro "%python_provide" with manually generated "Provides" and "Obsoletes" It's up to you and discussion with python experts :-) LS >From 0674e1e6aae2423c050be520b9c1b13f8feeb3d8 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat

Re: [Freeipa-devel] 4.3 on rawhide build task fail

On (05/01/16 10:37), Lukas Slebodnik wrote: >On (22/12/15 16:31), Petr Vobornik wrote: >>Build of 4.3 on Fedora rawhide failed at the end on rpmdiff check. Builds for >>all arches were successful and also works in COPR. >> 0 free 1 open 4 done 0 failed >

Re: [Freeipa-devel] [PATCH 027] Require Dogtag 10.2.6-13 to fix KRA uninstall

On (05/01/16 12:24), Christian Heimes wrote: >The combination of a bug in Dogtag's sslget command and a new feature >in mod_nss causes an incomplete uninstallation of KRA. The bug has been >fixed in Dogtag 10.2.6-13. > and it ins in fedora 23 stable for a week

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On (30/11/15 13:09), Tomas Babej wrote: >Hi, > >IPA sudo tests worked under the assumption that the clients that >are executing the sudo commands have their IPs assigned within >255.255.255.0 hostmask. > >Removes this (invalid) assumption and adds a dynamic detection of >the hostmask of the IPA

Re: [Freeipa-devel] import rpm causes failure during IPA caless install

On (08/01/16 14:14), Jan Cholasta wrote: >On 8.1.2016 14:09, Martin Basti wrote: >> >> >>On 08.01.2016 14:00, Martin Kosek wrote: >>>On 01/08/2016 01:45 PM, Martin Basti wrote: Hello all, fix for ticket https://fedorahosted.org/freeipa/ticket/5535 requires to import rpm module

Re: [Freeipa-devel] git commit message

On (08/06/16 14:09), Petr Vobornik wrote: >On 06/08/2016 10:07 AM, Petr Spacek wrote: >> On 7.6.2016 15:11, Stanislav Laznicka wrote: >>> Hello, >>> >>> Thank you for your patch. As the thin-client patches were pushed in the >>> meantime, the patch won't apply. Could you please send a rebased

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

On (09/06/16 14:29), Martin Basti wrote: >On 09.06.2016 14:22, Alexander Bokovoy wrote: >> On Thu, 09 Jun 2016, Jakub Hrozek wrote: >> > On Fri, May 20, 2016 at 09:23:46PM +0200, Sumit Bose wrote: >> > > Hi, >> > > >> > > this patch allows the extom plugin to lookup users by certificate which >>

Re: [Freeipa-devel] [PATCH] 0203 adtrust: remove ipanttrustpartner parameter

On (10/06/16 11:01), Martin Kosek wrote: >On 06/10/2016 10:01 AM, Martin Basti wrote: >> >> >> On 09.06.2016 21:45, Alexander Bokovoy wrote: >>> On Thu, 09 Jun 2016, Martin Basti wrote: On 09.06.2016 17:56, Martin Babinsky wrote: > On 06/06/2016 01:37 PM, Alexander Bokovoy

Re: [Freeipa-devel] [PATCH 0492] Translations: update ipa-4-3 translations

On (09/06/16 12:32), Martin Basti wrote: > > >On 07.06.2016 12:51, Martin Babinsky wrote: >> On 06/01/2016 05:10 PM, Martin Basti wrote: >> > Patch attached. >> > >> ACK >> >Pushed to ipa-4-3: 22fcf65cd1b674b21496b677818a8c75adcd70a6 > I am not sure but it's very likely that this patch broke

Re: [Freeipa-devel] [PATCH 0133] Require 389-ds-base >= 1.3.5.6

On (16/06/16 12:00), Petr Spacek wrote: >Hello, > >Require 389-ds-base >= 1.3.5.6 > >Old DS handles LDAP filters incorrectly and breaks bind-dyndb-ldap. >See https://www.redhat.com/archives/freeipa-devel/2016-June/msg00477.html > >https://fedorahosted.org/freeipa/ticket/2008 > >-- >Petr^2 Spacek

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

On (22/06/16 11:57), Martin Basti wrote: > > >On 09.06.2016 21:02, Martin Basti wrote: >> >> >> On 09.06.2016 14:45, Martin Basti wrote: >> > >> > >> > On 09.06.2016 14:42, Martin Basti wrote: >> > > >> > >

Re: [Freeipa-devel] [PATCH] 498 Update Contributors.txt

On (23/06/16 15:22), Martin Kosek wrote: >Update .mailmap to fix wrong commit author and re-generate >the Developer contributor list. > >-- >Martin Kosek >Manager, Software Engineering - Identity Management Team >Red Hat, Inc. >From 4271bdb36d111b90da3daf3f4312ec40d7db590f

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

On (24/06/16 17:53), Martin Basti wrote: > > >On 24.06.2016 15:09, Martin Basti wrote: >> >> >> On 24.06.2016 14:59, Sumit Bose wrote: >> > On Fri, Jun 24, 2016 at 02:00:24PM +0200, Martin Basti wrote: >> > > >> > > On 22.06.20

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

gt; On 24.06.2016 14:59, Sumit Bose wrote: >> > > > On Fri, Jun 24, 2016 at 02:00:24PM +0200, Martin Basti wrote: >> > > > > >> > > > > On 22.06.2016 23:20, Lukas Slebodnik wrote: >> > > > > > On (22/06

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

On (24/06/16 20:43), Alexander Bokovoy wrote: >On Fri, 24 Jun 2016, Lukas Slebodnik wrote: >> On (24/06/16 20:00), Alexander Bokovoy wrote: >> > On Fri, 24 Jun 2016, Sumit Bose wrote: >> > > On Fri, Jun 24, 2016 at 05:53:27PM +0200, Martin Basti wrote: >> >

Re: [Freeipa-devel] [PATCH] 0156 extdom: add certificate request

On (24/06/16 21:09), Alexander Bokovoy wrote: >On Fri, 24 Jun 2016, Lukas Slebodnik wrote: >> > > > > ah sorry, since 1.14.0 is not release yet we use 1.13.9x to track the >> > > > > alpha and beta releases and still have incrementing version numbers. >&

Re: [Freeipa-devel] import rpm causes failure during IPA caless install

On (08/01/16 14:18), Martin Babinsky wrote: >On 01/08/2016 02:14 PM, Jan Cholasta wrote: >>On 8.1.2016 14:09, Martin Basti wrote: >>> >>> >>>On 08.01.2016 14:00, Martin Kosek wrote: On 01/08/2016 01:45 PM, Martin Basti wrote: >Hello all, > >fix for ticket

Re: [Freeipa-devel] [PATCH 0122-0123] reimplementation of package version comparison code

On (08/01/16 16:59), Martin Babinsky wrote: >Patch 0122 reimplements version checking and fixes >https://fedorahosted.org/freeipa/ticket/5572 > >Patch 0123 contains unit test for version checking code. > >Thanks to Martin^1 for the idea of using CFFI for calling rpm C-API directly. > >--

  1   2   >