[Freeipa-devel] [PATCH] 120 Removal of memberofindirect_permissons from privileges

2012-04-10 Thread Petr Vobornik
. Solution: This patch removes the memberofindirect_persmission definition from server plugin. It fixes the problem in Web UI. https://fedorahosted.org/freeipa/ticket/2611 -- Petr Vobornik From 8db7bc4e665c7bbd8baaba4e6d4f6925e1936139 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 10 Apr 2012 14:40:4

Re: [Freeipa-devel] [PATCH] 1006 detect expired passwords in forms login

2012-04-16 Thread Petr Vobornik
Not sure if it is a problem, GC and __del__ should take care of it. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 1006 detect expired passwords in forms login

2012-04-16 Thread Petr Vobornik
On 04/16/2012 03:34 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Vobornik wrote: On 04/13/2012 09:28 PM, Rob Crittenden wrote: When doing a forms-based login there is no notification that a password needs to be reset. We don't currently provide a facility for that but we shou

[Freeipa-devel] [PATCH] 121 User is notified that password needs to be reset in, forms-based login

2012-04-17 Thread Petr Vobornik
This solution depends on Rob's patch #1006-2 Forms-based login procedure detects if 401 unauthorized message contains 'Expired Password' message. If so it displays an error message that user needs to reset his password. https://fedorahosted.org/freeipa/ticket/2608 -- Pet

Re: [Freeipa-devel] [PATCH] 121 User is notified that password needs to be reset in, forms-based login

2012-04-17 Thread Petr Vobornik
Updated patch attached. It's modified according to Rob's patch #1006-3 which uses 'X-rejection-reason' to notify expired password. On 04/17/2012 11:17 AM, Petr Vobornik wrote: This solution depends on Rob's patch #1006-2 Forms-based login procedure detects if 401 unau

[Freeipa-devel] [PATCH] 122 Added permission field to delegation

2012-04-17 Thread Petr Vobornik
/fedorahosted.org/freeipa/ticket/2635 -- Petr Vobornik From 5e97d89201292b90b0427ca8b801ab8c5c776a7b Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 17 Apr 2012 18:15:00 +0200 Subject: [PATCH] Added permission field to delegation Permission field is missing in delegation so it can't be

Re: [Freeipa-devel] [PATCH] 254 Sort password policies properly with --pkey-only

2012-04-26 Thread Petr Vobornik
://fedorahosted.org/freeipa/ticket/2676 Attaching patch which disables paging in password policy page. More details in patch description. -- Petr Vobornik From 7eb92076c92be146efbb729eadd92e019e51bab7 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 26 Apr 2012 08:54:25 +0200 Subject: [PATCH] Paging

[Freeipa-devel] [PATCH] 133 Action list for user password

2012-05-03 Thread Petr Vobornik
(if set) Password: (if not set) Reset password action was moved to Action List. https://fedorahosted.org/freeipa/ticket/2248 Note: I will address enabling/disabling 'reset password' option in action list in ticket #2318. -- Petr Vobornik From 5c2c5321f04fdec8b4889e0461ebd3af7c

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-03 Thread Petr Vobornik
I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which actually calculates it. On 05/02/2012 03:33 PM, Petr Vobornik wrote: This bunch of patches are implementing ticket #2247. They introduce some new logic and types of internal objects

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-03 Thread Petr Vobornik
On 05/03/2012 03:19 PM, Petr Vobornik wrote: I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which actually calculates it. I found useless line in the patch. Corrected version attached. On 05/02/2012 03:33 PM, Petr Vobornik wrote

[Freeipa-devel] [PATCH] 135 Host page fixed to work with disabled DNS support

2012-05-04 Thread Petr Vobornik
no dns entity is initialized and therefore DNS tab in navigation is not displayed. https://fedorahosted.org/freeipa/ticket/2728 -- Petr Vobornik From 1fb864d7e300404fb48186213591b27dbaf3316b Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Fri, 4 May 2012 14:02:01 +0200 Subject: [PATCH] Host pag

[Freeipa-devel] [PATCH] 136 Correction of nested search facets tab labels

2012-05-10 Thread Petr Vobornik
Nested search facets were using 'search' tab label instead of their nested entity name. This patch is fixing that regression. https://fedorahosted.org/freeipa/ticket/2744 -- Petr Vobornik From d7ad53abc3f70da1408fb3421daa488bcab5dfcc Mon Sep 17 00:00:00 2001 From: Petr Vobornik Dat

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-10 Thread Petr Vobornik
Updated patch attached. See comments below. On 05/08/2012 04:23 AM, Endi Sukma Dewata wrote: On 5/3/2012 8:26 AM, Petr Vobornik wrote: On 05/03/2012 03:19 PM, Petr Vobornik wrote: I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which

[Freeipa-devel] [PATCH] 137 Instructions to generate cert use certutil instead of openssl

2012-05-11 Thread Petr Vobornik
Instructions to generate certificate were changed. Now they use certutil instead of openssl. In the example is also used option for specifying key size. https://fedorahosted.org/freeipa/ticket/2725 -- Petr Vobornik From db71ce6967d831200a1a0aaade690f8433269a19 Mon Sep 17 00:00:00 2001 From

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-11 Thread Petr Vobornik
On 05/08/2012 01:47 AM, Endi Sukma Dewata wrote: The code works, it's ACKed. Patches 124-132 pushed to master. I have some comments below: I'll address some points in separate patches. On 5/2/2012 8:33 AM, Petr Vobornik wrote: This bunch of patches are implementing ticket #

Re: [Freeipa-devel] [PATCH] 135 Host page fixed to work with disabled DNS support

2012-05-15 Thread Petr Vobornik
On 05/11/2012 06:46 PM, JR Aquino wrote: On May 4, 2012, at 5:18 AM, Petr Vobornik wrote: When DNS support was disabled there were following errors in Web UI: 1) Host details page was not filled with data 2) Host adder dialog was broken -> unusable 3) DNS tab was displayed in navigation

Re: [Freeipa-devel] [PATCH] 136 Correction of nested search facets tab labels

2012-05-15 Thread Petr Vobornik
On 05/14/2012 07:09 PM, Endi Sukma Dewata wrote: On 5/10/2012 5:29 AM, Petr Vobornik wrote: Nested search facets were using 'search' tab label instead of their nested entity name. This patch is fixing that regression. https://fedorahosted.org/freeipa/ticket/2744 ACK. Pushed

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-15 Thread Petr Vobornik
On 05/14/2012 07:08 PM, Endi Sukma Dewata wrote: On 5/10/2012 7:19 AM, Petr Vobornik wrote: Updated patch attached. See comments below. On 05/08/2012 04:23 AM, Endi Sukma Dewata wrote: Try adding a very long DNS zone, then open the zone. Compare the breadcrumbs in the DNS Resource Records

Re: [Freeipa-devel] [PATCH] 133 Action list for user password

2012-05-24 Thread Petr Vobornik
Just for record: this patch is replaced by my patches 141, 142 (sent to list on May 24). On 05/14/2012 07:12 PM, Endi Sukma Dewata wrote: On 5/3/2012 3:59 AM, Petr Vobornik wrote: Currently the user password is shown as follows in the details page: Password: Reset Password This is

[Freeipa-devel] [PATCH] 146 Added cancel button to service unprovision dialog

2012-05-24 Thread Petr Vobornik
Service unprovision dialog was missing a cancel button. The button was added. https://fedorahosted.org/freeipa/ticket/1811 -- Petr Vobornik From ce7d399b295cebc1477b2590102cf42089dadb2a Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 14 May 2012 08:40:41 +0200 Subject: [PATCH] Added

Re: [Freeipa-devel] [PATCH] 0050 Fail on unknown Command options

2012-05-25 Thread Petr Vobornik
t. It complains that 'key' is unknown option. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 148 Removal of illegal options in JSON-RPC calls

2012-05-25 Thread Petr Vobornik
7; option. https://fedorahosted.org/freeipa/ticket/2760 Note for reviewing: #2509 is partially done in Petr Viktorin's patch #35. At this time it has a small issue regarding automountmap_add_indirect command. -- Petr Vobornik From aaa2066e0885b6c856edbf6ee65c6e9ebeeece2d Mon Sep 17 00

Re: [Freeipa-devel] [PATCH] 148 Removal of illegal options in JSON-RPC calls

2012-05-25 Thread Petr Vobornik
On 05/25/2012 04:57 PM, Petr Vobornik wrote: Ticket https://fedorahosted.org/freeipa/ticket/2509 bans using non existent options. If such option is supplied command ends with error. It uncovered several cases in Web UI. This patch is fixing these cases. Automember, Self-service and Delegation

[Freeipa-devel] [PATCH] 149 Added links to netgroup member tables

2012-05-25 Thread Petr Vobornik
Tables with members in netgroup were missing links for navigation to associated details pages. This patch adds these links. https://fedorahosted.org/freeipa/ticket/2670 -- Petr Vobornik From c89f67b1a457e99fa3ee0f2be89250222f5b1f52 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Fri, 25 May

[Freeipa-devel] [PATCH] 150 Text widget's dirty state is changed on various input methods

2012-05-28 Thread Petr Vobornik
ce but so far it shouldn't cause troubles. https://fedorahosted.org/freeipa/ticket/2647 -- Petr Vobornik From cb89604fb89bc46a87de89bd35188d0e45d44f60 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 28 May 2012 13:24:54 +0200 Subject: [PATCH] Text widget's dirty state is changed on

Re: [Freeipa-devel] [PATCH] 0050 Fail on unknown Command options

2012-05-28 Thread Petr Vobornik
On 05/25/2012 09:20 AM, Petr Vobornik wrote: On 05/16/2012 02:11 PM, Martin Kosek wrote: On Wed, 2012-05-16 at 10:37 +0200, Petr Viktorin wrote: On 05/16/2012 09:58 AM, Martin Kosek wrote: On Tue, 2012-05-15 at 13:35 +0200, Petr Viktorin wrote: On 05/15/2012 09:55 AM, Martin Kosek wrote: On

Re: [Freeipa-devel] [PATCHES] 138-145 Action panel for user password reset

2012-06-04 Thread Petr Vobornik
); that.observer.notify(arg1, arg2); I like this idea. It simplifies things. On 5/24/2012 3:54 AM, Petr Vobornik wrote: This bunch of patches implements new concept: action panel and it's implementation in user page. First two patches refactorizes current action-list/control-buttons code

Re: [Freeipa-devel] [PATCH] 150 Text widget's dirty state is changed on various input methods

2012-06-04 Thread Petr Vobornik
On 06/01/2012 02:46 AM, Endi Sukma Dewata wrote: On 5/28/2012 6:44 AM, Petr Vobornik wrote: on_value_changed event in textboxes and textareas was raised only on keyboard input. If user used different input method such as paste or browser undo and redo functions widget's on_value_changed

Re: [Freeipa-devel] [PATCH] 149 Added links to netgroup member tables

2012-06-04 Thread Petr Vobornik
On 06/01/2012 02:44 AM, Endi Sukma Dewata wrote: On 5/25/2012 11:23 AM, Petr Vobornik wrote: Tables with members in netgroup were missing links for navigation to associated details pages. This patch adds these links. https://fedorahosted.org/freeipa/ticket/2670 ACK. Pushed to master

Re: [Freeipa-devel] [PATCH] 148 Removal of illegal options in JSON-RPC calls

2012-06-04 Thread Petr Vobornik
On 06/01/2012 02:44 AM, Endi Sukma Dewata wrote: On 5/25/2012 9:57 AM, Petr Vobornik wrote: Ticket https://fedorahosted.org/freeipa/ticket/2509 bans using non existent options. If such option is supplied command ends with error. It uncovered several cases in Web UI. This patch is fixing these

Re: [Freeipa-devel] [PATCH] 146 Added cancel button to service unprovision dialog

2012-06-04 Thread Petr Vobornik
On 06/01/2012 02:40 AM, Endi Sukma Dewata wrote: On 5/24/2012 4:11 AM, Petr Vobornik wrote: Service unprovision dialog was missing a cancel button. The button was added. https://fedorahosted.org/freeipa/ticket/1811 ACK. Pushed to master. -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 147 Set network.http.sendRefererHeader to 2 on browser config

2012-06-04 Thread Petr Vobornik
On 05/29/2012 11:29 PM, Rob Crittenden wrote: Petr Vobornik wrote: IPA web UI isn't functional when browser doesn't send http headers. This patch adds a functionality which sets Firefox network.http.sendRefererHeader configuration option to value '2' which enables it. P

[Freeipa-devel] [PATCH] 151, 152 Removal of illegal options in association dialog

2012-06-04 Thread Petr Vobornik
. It finally sends usefull option collection for commands part of metadata. In the end the raw amount of data send is aproximately the same. This patch is needed for Web UI to determine which option it can use in which commands. https://fedorahosted.org/freeipa/ticket/2760 -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 147 Set network.http.sendRefererHeader to 2 on browser config

2012-06-05 Thread Petr Vobornik
On 06/05/2012 05:01 AM, Rob Crittenden wrote: Petr Vobornik wrote: On 05/29/2012 11:29 PM, Rob Crittenden wrote: Petr Vobornik wrote: IPA web UI isn't functional when browser doesn't send http headers. This patch adds a functionality which sets Firefox network.http.sendRef

Re: [Freeipa-devel] [PATCH] 272-273 Add service membership to host objects

2012-06-06 Thread Petr Vobornik
tab with a list of services for a selected host. I will check with Petr if the information we provide are enough. Martin Provided information is sufficient for implementation of UI part. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] [PATCH] 492 Add options to reduce writes from KDC

2012-06-06 Thread Petr Vobornik
,$SUFFIX These are: KDC:Disable Last Success KDC:Disable Lockout 8><-- Simo. Attaching patch which adds these two new configuration values to Web UI. -- Petr Vobornik From 48c809ac12568958982ac3f3142761aabc2b71a1 Mon Sep 17 00:00:00 2001 From: Petr Vo

Re: [Freeipa-devel] [PATCH] 151, 152 Removal of illegal options in association dialog

2012-06-06 Thread Petr Vobornik
on files. I haven't put to git because of my frequent personal changes which might not be useful for others. On 6/4/2012 11:05 AM, Petr Vobornik wrote: [PATCH] 152 Removal of illegal options in association dialog: Association dialogs were using non-existent options for find commands. It

[Freeipa-devel] [PATCH] 155 Action panel for host enrollment

2012-06-06 Thread Petr Vobornik
section. https://fedorahosted.org/freeipa/ticket/2251 -- Petr Vobornik From 83cafa76316efe492d5cba308245f0c9db64c296 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 6 Jun 2012 17:52:15 +0200 Subject: [PATCH] Action panel for host enrollment Widgets in host enrollment sections were modified

[Freeipa-devel] [PATCH] 156 Action panel for service provisioning

2012-06-07 Thread Petr Vobornik
w separate dialog. Action for action panel and all required status evaluators for enabling/disabling of that action were also created. https://fedorahosted.org/freeipa/ticket/2252 -- Petr Vobornik From a760fda79133edc5b71b12b8b26a06d29e462abc Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date:

Re: [Freeipa-devel] [PATCH] 0050 Fail on unknown Command options

2012-06-07 Thread Petr Vobornik
On 05/28/2012 04:16 PM, Martin Kosek wrote: On Mon, 2012-05-28 at 15:46 +0200, Petr Vobornik wrote: On 05/25/2012 09:20 AM, Petr Vobornik wrote: On 05/16/2012 02:11 PM, Martin Kosek wrote: On Wed, 2012-05-16 at 10:37 +0200, Petr Viktorin wrote: On 05/16/2012 09:58 AM, Martin Kosek wrote: On

[Freeipa-devel] [PATCH] 157 Added password reset capabilities to unauthorized dialog

2012-06-08 Thread Petr Vobornik
values entered for password reset is performed. It should login the user. In password reset form user can click on back button or hit escape on keyboard to go back to login form. https://fedorahosted.org/freeipa/ticket/2755 -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 157 Added password reset capabilities to unauthorized dialog

2012-06-08 Thread Petr Vobornik
and now the patch... On 06/08/2012 05:51 PM, Petr Vobornik wrote: For those of you who are only interest in user perspective I prepared a set of screenshots to demonstrate workflow of password reset: http://pvoborni.fedorapeople.org/ux/reset_password_workflow.png Patch depends on mkosek #274

[Freeipa-devel] [PATCH] 158 Separate reset password page

2012-06-08 Thread Petr Vobornik
o for users who are using the separate login page. https://fedorahosted.org/freeipa/ticket/2755 -- Petr Vobornik From 597c567114d9913acb3cad0924b1eeba6d367573 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Fri, 8 Jun 2012 16:38:17 +0200 Subject: [PATCH] Separate reset password page This patch

Re: [Freeipa-devel] [PATCH] 157 Added password reset capabilities to unauthorized dialog

2012-06-13 Thread Petr Vobornik
I'll address all issues once we decide on the solution. On 06/13/2012 01:24 AM, Endi Sukma Dewata wrote: On 6/8/2012 10:52 AM, Petr Vobornik wrote: and now the patch... On 06/08/2012 05:51 PM, Petr Vobornik wrote: For those of you who are only interest in user perspective I prepared a s

Re: [Freeipa-devel] [PATCH] 158 Separate reset password page

2012-06-13 Thread Petr Vobornik
On 06/13/2012 01:25 AM, Endi Sukma Dewata wrote: On 6/8/2012 10:54 AM, Petr Vobornik wrote: This patch adds separate reset password page. It is a complement to separate login page. It differentiate from reset password capabilities in Web UI's anauthorized dialog by not performing login. Th

Re: [Freeipa-devel] [PATCH] 155 Action panel for host enrollment

2012-06-13 Thread Petr Vobornik
On 06/13/2012 01:24 AM, Endi Sukma Dewata wrote: On 6/6/2012 10:59 AM, Petr Vobornik wrote: Widgets in host enrollment sections were modified. They now serve only for displaying of has_key and has_password status. Functionality for setting otp and unprovisioning was moved to separate dialogs

Re: [Freeipa-devel] [PATCH] 156 Action panel for service provisioning

2012-06-13 Thread Petr Vobornik
On 06/13/2012 01:24 AM, Endi Sukma Dewata wrote: On 6/7/2012 3:52 AM, Petr Vobornik wrote: Service provisioning status widget was modified only to display the has_keytab status. Button for 'delete key,unprovision' was moved as action to newly created action panel in the same sec

Re: [Freeipa-devel] [PATCH] 158 Separate reset password page

2012-06-18 Thread Petr Vobornik
On 06/13/2012 07:22 PM, Endi Sukma Dewata wrote: On 6/13/2012 8:32 AM, Petr Vobornik wrote: On 06/13/2012 01:25 AM, Endi Sukma Dewata wrote: On 6/8/2012 10:54 AM, Petr Vobornik wrote: This patch adds separate reset password page. It is a complement to separate login page. It differentiate

Re: [Freeipa-devel] [PATCH] 157 Added password reset capabilities to unauthorized dialog

2012-06-19 Thread Petr Vobornik
m not sure about the position though. Updated patch attached. On 06/13/2012 07:18 PM, Endi Sukma Dewata wrote: On 6/13/2012 8:15 AM, Petr Vobornik wrote: I'll address all issues once we decide on the solution. 1. If you click 'form-based authentication the dialog title still shows

Re: [Freeipa-devel] [PATCH] 158 Separate reset password page

2012-06-21 Thread Petr Vobornik
On 06/20/2012 07:00 PM, Endi Sukma Dewata wrote: On 6/19/2012 1:22 AM, Petr Vobornik wrote: Updated patch attached. Sorry for late update, I was working on trust UI and didn't want to switch context. No problem. It would be nicer if this page can use the same fonts as the login dial

Re: [Freeipa-devel] [PATCH] 157 Added password reset capabilities to unauthorized dialog

2012-06-21 Thread Petr Vobornik
On 06/20/2012 06:46 PM, Endi Sukma Dewata wrote: ACK, but feel free to make additional minor changes as suggested below before push. Pushed to master. I added some of the minor changes (patch attached for completeness). On 6/19/2012 9:01 AM, Petr Vobornik wrote: In general I like

Re: [Freeipa-devel] [PATCH] 147 Set network.http.sendRefererHeader to 2 on browser config

2012-06-22 Thread Petr Vobornik
On 06/21/2012 06:41 PM, Endi Sukma Dewata wrote: On 6/21/2012 11:29 AM, Petr Vobornik wrote: I modified the patch to set it in old browsers. Patch attached. I tested it in Firefox 3.6.17 in fresh install of RHEL 6.1. ACK. Patches #147-1 and #137 pushed to master. -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 159 Action panel for certificates

2012-06-26 Thread Petr Vobornik
Updated patch attached. On 06/25/2012 05:09 PM, Endi Sukma Dewata wrote: On 6/12/2012 7:48 AM, Petr Vobornik wrote: This is a continuation of effort which transforms status widgets with buttons executing actions to separate status widget and action panels. This patch strips certificate status

[Freeipa-devel] [PATCH] 162 Web UI password is going to expire in n days notification

2012-06-26 Thread Petr Vobornik
xpire in less or equal than configure days a bold red text 'Your password expires in N days' is shown in Web UI's header (on the left next to 'Logged in as...'). https://fedorahosted.org/freeipa/ticket/2625 -- Petr Vobornik From bf386e2bcdb13e8115a0927d24e256ed4b16b4d4 M

Re: [Freeipa-devel] [PATCH] 159 Action panel for certificates

2012-06-27 Thread Petr Vobornik
On 06/26/2012 08:51 PM, Endi Sukma Dewata wrote: On 6/26/2012 12:36 PM, Petr Vobornik wrote: I'm testing using self-signed CA. When I open the host/service details page there's a JS error at certificate.js:928 (undefined status_revoked), so the page seems to hang and looks blank.

Re: [Freeipa-devel] [PATCH] 162 Web UI password is going to expire in n days notification

2012-06-27 Thread Petr Vobornik
On 06/27/2012 03:54 AM, Endi Sukma Dewata wrote: On 6/26/2012 9:46 AM, Petr Vobornik wrote: This is patch is more like a draft. I'm not sure where to display the 'password is going to expire' notification. I was deciding between: 1) red bold text in Web UI header 2) popup dial

[Freeipa-devel] [PATCH] 163 Refactored association facet to use facet buttons with actions

2012-06-27 Thread Petr Vobornik
Association facet was refactored to use new concept of control buttons. It is the last facet type which don't use this concept. It fixes regression introduced by previous refactoring of table facet (delete button was never enabled). https://fedorahosted.org/freeipa/ticket/2876 -- Petr Vob

[Freeipa-devel] [PATCH] 164 Continuation of removing of not supported command options from Web UI

2012-06-27 Thread Petr Vobornik
This patch removes following non-existing command options: * all,rights in host_disable * record_type in dns_record_add * all,rights in various xxx_remove_xxx commands used in rule_association_table_field (removing association) https://fedorahosted.org/freeipa/ticket/2878 -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 162 Web UI password is going to expire in n days notification

2012-06-28 Thread Petr Vobornik
On 06/27/2012 04:33 PM, Petr Vobornik wrote: On 06/27/2012 03:54 AM, Endi Sukma Dewata wrote: On 6/26/2012 9:46 AM, Petr Vobornik wrote: This is patch is more like a draft. I'm not sure where to display the 'password is going to expire' notification. I was deciding between: 1

[Freeipa-devel] [PATCH] 165 Display loginas information only after login

2012-06-28 Thread Petr Vobornik
Message 'Logged in as: u...@freeipa.org' was displayed before user was logged in. It was wrong. Now 'Logged in as: XXX' is displayed only when user XXX is logged in. So no more u...@freeipa.org :) . https://fedorahosted.org/freeipa/ticket/2882 -

Re: [Freeipa-devel] [PATCH] 164 Continuation of removing of not supported command options from Web UI

2012-06-29 Thread Petr Vobornik
On 06/28/2012 09:30 PM, Endi Sukma Dewata wrote: On 6/27/2012 11:22 AM, Petr Vobornik wrote: This patch removes following non-existing command options: * all,rights in host_disable * record_type in dns_record_add * all,rights in various xxx_remove_xxx commands used in

Re: [Freeipa-devel] [PATCH] 163 Refactored association facet to use facet buttons with actions

2012-06-29 Thread Petr Vobornik
On 06/28/2012 09:30 PM, Endi Sukma Dewata wrote: On 6/27/2012 11:19 AM, Petr Vobornik wrote: Association facet was refactored to use new concept of control buttons. It is the last facet type which don't use this concept. It fixes regression introduced by previous refactoring of table

Re: [Freeipa-devel] [PATCH] 162 Web UI password is going to expire in n days notification

2012-06-29 Thread Petr Vobornik
en you login with expired password, after you reset the password it will briefly show the login page again before showing the UI. I think the login dialog should close immediately once you click the button. In my environment it's usually so fast I can't notice it. I have to try it on

Re: [Freeipa-devel] [PATCH] 165 Display loginas information only after login

2012-07-02 Thread Petr Vobornik
On 06/28/2012 10:47 PM, Endi Sukma Dewata wrote: On 6/28/2012 9:07 AM, Petr Vobornik wrote: Message 'Logged in as: u...@freeipa.org' was displayed before user was logged in. It was wrong. Now 'Logged in as: XXX' is displayed only when user XXX is logged in. So no m

Re: [Freeipa-devel] [PATCH] 165 Display loginas information only after login

2012-07-04 Thread Petr Vobornik
On 07/02/2012 05:49 PM, Endi Sukma Dewata wrote: ACK. Some more comments below. Feel free to fix before push or later separately. Implemented most of the issues, look bellow. Update patch attached. On 7/2/2012 2:55 AM, Petr Vobornik wrote: On 06/28/2012 10:47 PM, Endi Sukma Dewata wrote

[Freeipa-devel] [PATCH] 166 Moved configuration to last position in navigation

2012-07-04 Thread Petr Vobornik
icket/2900 -- Petr Vobornik From 50c4ecb82d03aba48261dea2bc14964ac272f225 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 4 Jul 2012 15:15:10 +0200 Subject: [PATCH] Moved configuration to last position in navigation Configaration was the last navigation item in IPA server tab. Trusts changed

[Freeipa-devel] [PATCH] 167 Add and remove dns per-domain permission in Web UI

2012-07-09 Thread Petr Vobornik
single command execution. New actions should be enabled only for users with appropriate rights. It is not possible to obtain rights for certain action in advance so an approximation is used: write right for dns zones' managedby attribute. https://fedorahosted.org/freeipa/ticket/2851 --

[Freeipa-devel] [PATCH] 168 Password policy measurement units

2012-07-09 Thread Petr Vobornik
Failure reset interval' and 'Lockout duration' fields. https://fedorahosted.org/freeipa/ticket/2437 -- Petr Vobornik From 0b71cf86d033ec0a86386fb1851424d0d8584823 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 9 Jul 2012 16:58:00 +0200 Subject: [PATCH] Password polic

[Freeipa-devel] [PATCH] 169 Web UI: kerberos ticket policy measurement units

2012-07-09 Thread Petr Vobornik
Added measurement units for kerberos ticket policy. https://fedorahosted.org/freeipa/ticket/2444 Note: patch depends on pvoborni-0168. -- Petr Vobornik From 7bfff70733b061ebd832c706d98cbb5f5521a4dc Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 9 Jul 2012 17:28:08 +0200 Subject

Re: [Freeipa-devel] [PATCH] 165 Display loginas information only after login

2012-07-10 Thread Petr Vobornik
On 07/10/2012 07:40 AM, Endi Sukma Dewata wrote: On 7/4/2012 8:08 AM, Petr Vobornik wrote: On 07/02/2012 05:49 PM, Endi Sukma Dewata wrote: ACK. Some more comments below. Feel free to fix before push or later separately. Implemented most of the issues, look bellow. Update patch attached

Re: [Freeipa-devel] [PATCH] 168 Password policy measurement units

2012-07-10 Thread Petr Vobornik
On 07/10/2012 07:41 AM, Endi Sukma Dewata wrote: On 7/9/2012 10:21 AM, Petr Vobornik wrote: Note: I think we should improve handling of measurement units in server plugins. Label and measurement unit should be separated and send in metadata. Client - Web UI or CLI would then decide when and

Re: [Freeipa-devel] [PATCH] 169 Web UI: kerberos ticket policy measurement units

2012-07-10 Thread Petr Vobornik
On 07/10/2012 07:41 AM, Endi Sukma Dewata wrote: On 7/9/2012 10:32 AM, Petr Vobornik wrote: Added measurement units for kerberos ticket policy. https://fedorahosted.org/freeipa/ticket/2444 Note: patch depends on pvoborni-0168. ACK. Pushed to master. -- Petr Vobornik

[Freeipa-devel] [PATCH] [solarus] 001 Indirect roles in WebUI

2012-07-11 Thread Petr Vobornik
admin users. We only checked for memberof_role and not memberofindirect_role. This patch adds a check for memberofindirect_role. -- Petr Vobornik From e82fee46327a16525c4dc0d35d1cbc541662542c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Sp=C3=A5ngberg?= Date: Wed, 4 Jul 2012 10:28:43 +0200 Su

Re: [Freeipa-devel] [PATCH] 167 Add and remove dns per-domain permission in Web UI

2012-07-11 Thread Petr Vobornik
On 07/10/2012 07:40 AM, Endi Sukma Dewata wrote: On 7/9/2012 6:55 AM, Petr Vobornik wrote: Patch functionality depends on not yet posted pviktori's patch which adds error_code (in case of command error) to batch response. Patch description: This patch adds support for new per-d

[Freeipa-devel] [PATCH] 170 Differentiation of widget type and text_widget input type

2012-07-12 Thread Petr Vobornik
_type' which removes the collision and hence fixes the problem. https://fedorahosted.org/freeipa/ticket/2806 and half of: https://fedorahosted.org/freeipa/ticket/2834 -- Petr Vobornik From f2ed7294fb558895ea9d84d30b010f56069d88a8 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Dat

Re: [Freeipa-devel] DHCP support - Request for review

2012-07-13 Thread Petr Vobornik
X-show $CN` command. What is not have to be displayed by `XXX-show $CN --all` command. 7) In labels you use 'Dhcp'. IMO it should be all uppercase. Regards -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree

2012-07-16 Thread Petr Vobornik
textareas are browser-specific. We can do it in code too but I don't think it is worth the effort. Textarea in IE still seems smaller than in Firefox, but it has the same number of rows and cols. I think it has enough space for defining the filter so it should be fixing the problem. -- Petr Vob

Re: [Freeipa-devel] [PATCH] 170 Differentiation of widget type and text_widget input type

2012-07-17 Thread Petr Vobornik
On 07/17/2012 01:09 AM, Endi Sukma Dewata wrote: On 7/12/2012 8:10 AM, Petr Vobornik wrote: There was a clash of 'type' attribute in widget's spec. Usually 'type' is used for telling a builder which field and widget to build. Text widget used this attribute also for de

Re: [Freeipa-devel] [PATCH] 171 Fixed display of attributes_widget in IE9

2012-07-17 Thread Petr Vobornik
On 07/17/2012 01:10 AM, Endi Sukma Dewata wrote: On 7/16/2012 3:56 AM, Petr Vobornik wrote: Attributes widget is using overflow css rule in tbody element. IE9 doesn't handle it well. To fix the issue, attributes widget was slightly modified and conditional css stylesheet was added jus

Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree

2012-07-17 Thread Petr Vobornik
On 07/17/2012 01:10 AM, Endi Sukma Dewata wrote: On 7/16/2012 6:53 AM, Petr Vobornik wrote: Patch description: Adder dialog and details facet for permission type=subtree have small textarea for defining subtree filter. It was unconfortable to define the filter. This difference was removed

Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree

2012-07-18 Thread Petr Vobornik
On 07/17/2012 04:57 PM, Endi Sukma Dewata wrote: On 7/17/2012 9:25 AM, Petr Vobornik wrote: Possible improvement, instead of using a fixed column size the text area also could be made to occupy 100% of available width. Ideally it should have the same width as the text field or drop down list in

[Freeipa-devel] [PATCH] 173 IDs and names for dialogs

2012-07-19 Thread Petr Vobornik
amework can search more reliable by using this attribute instead of id. https://fedorahosted.org/freeipa/ticket/2853 -- Petr Vobornik From 5da4131fbdaed5c13e94afae040db243becfd06a Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 19 Jul 2012 14:47:48 +0200 Subject: [PATCH] IDs and names for

[Freeipa-devel] [PATCH] 174 Fix autoscroll to top in tables in IE

2012-07-23 Thread Petr Vobornik
s://fedorahosted.org/freeipa/ticket/2835 -- Petr Vobornik From 8791f87f6fa5a8747b64ce3c34528f7815086124 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 23 Jul 2012 10:32:26 +0200 Subject: [PATCH] Fix autoscroll to top in tables in IE In IE when a window is small (horizontal scrollbar is

Re: [Freeipa-devel] [PATCH] 174 Fix autoscroll to top in tables in IE

2012-07-25 Thread Petr Vobornik
On 07/24/2012 05:25 AM, Endi Sukma Dewata wrote: On 7/23/2012 9:05 AM, Petr Vobornik wrote: In IE when a window is small (horizontal scrollbar is displayed) click or keyboard input on various parts of UI makes search tables scroll to top. It prevents from selecting items in a table. This issue

Re: [Freeipa-devel] [PATCH] 173 IDs and names for dialogs

2012-07-25 Thread Petr Vobornik
On 07/24/2012 05:24 AM, Endi Sukma Dewata wrote: On 7/19/2012 8:07 AM, Petr Vobornik wrote: It's hard to detect if or which type of dialog is displayed because not all dialogs have IDs. On dialog open, it's id or name (if id is not set) is used for containing element id. Many of di

[Freeipa-devel] [PATCH] 175, 176 Fixed: Unable to select option in combobox in IE and Chrome

2012-07-27 Thread Petr Vobornik
ice adder dialog First select's content is displayed under second comboxes content when select is opened when second combobox is opened Bonus for: https://fedorahosted.org/freeipa/ticket/2834 -- Petr Vobornik From 8a835bc1d03355eb41a7f62ba0c45eba782caa78 Mon Sep 17 00:00:00 2001 From: P

Re: [Freeipa-devel] [PATCH] 175, 176 Fixed: Unable to select option in combobox in IE and Chrome

2012-08-01 Thread Petr Vobornik
On 07/31/2012 09:33 PM, Endi Sukma Dewata wrote: On 7/27/2012 10:55 AM, Petr Vobornik wrote: [PATCH] 175 Fixed: Unable to select option in combobox in IE and Chrome There's probably a bug regarding z-index stacking in Chrome and IE. It appears when combobox is used in dialog. Combobox

Re: [Freeipa-devel] [PATCH] 185 PAC Type options for services in Web UI

2012-08-02 Thread Petr Vobornik
On 08/02/2012 04:42 AM, Endi Sukma Dewata wrote: On 8/1/2012 11:04 AM, Petr Vobornik wrote: Following options were added to Web UI * PAC Type in service * PAC Type in configuration Testing metadata for objects and commands were regenerated. https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [PATCHES] 177-184 Rebase of jquery and jquery-ui libs

2012-08-02 Thread Petr Vobornik
On 08/02/2012 04:42 AM, Endi Sukma Dewata wrote: On 8/1/2012 8:43 AM, Petr Vobornik wrote: Silly mistake. I should test builds more often when playing with files... Updated patch 178 attached. Build and install should work. ACK. Patches 177,178-1,179-184 pushed to master. -- Petr Vobornik

[Freeipa-devel] [PATCH] 186-192 Web UI: Group external member support

2012-08-03 Thread Petr Vobornik
rights. Default values serves well for group's external member. https://fedorahosted.org/freeipa/ticket/2895 -- Petr Vobornik From c12ffdbbd3121e2577d82398723e5f7848b2eee7 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 30 Jul 2012 13:31:11 +0200 Subject: [PATCH] Add external grou

[Freeipa-devel] [PATCH] 193 Range Web UI

2012-08-06 Thread Petr Vobornik
all be there or should I remove some? And also labels seems to long. 2) FreeIPA creates default range. This range doesn't have required attribute 'First RID of the corresponding RID range'. It prevents from editing the range in Web UI until a some value is set. Not sure if even sh

Re: [Freeipa-devel] DN patch and documentation

2012-08-10 Thread Petr Vobornik
caused by the DN refactoring, I am attaching a patch fixing the issue. With this patch, ipa-replica-prepare issue disappears. Petr Vobornik also noticed an issue with trust-show command. I am attaching a patch with fix as well. We push the patches when we are pushing your work. I have not found any

Re: [Freeipa-devel] [PATCH] 186-192 Web UI: Group external member support

2012-08-10 Thread Petr Vobornik
but I couldn't reproduce it anymore. When I specified a GID in the group adder dialog, the value seemed to be ignored, so the GID would always be generated. Also the GID wasn't validated. Probably just a glitch. I didn't notice it. -- Petr Vobornik From ec010b95e19e8b1e0e49c0d173

[Freeipa-devel] [PATCH] 194 Handle case when trusted domain user access the Web UI

2012-08-10 Thread Petr Vobornik
ementation much. Problem is that we don't separate state variables and framework objects in IPA object. It is probably a topic for fixing in 3.2. -- Petr Vobornik From 90d9b019dac5d6f8f7f0b5d810277b2fcdc0fc27 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 9 Aug 2012 14:16:58 +0200

[Freeipa-devel] [PATCH] 195 Disable caching of Web UI login_kerberos request

2012-08-10 Thread Petr Vobornik
IE caches login_kerberos request so SSO doesn't work after logout. This patch disables the caching. https://fedorahosted.org/freeipa/ticket/2991 -- Petr Vobornik From 9c9741eee72168da6f841ec8d8342cb7f4deda61 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 9 Aug 2012 16:18:46

[Freeipa-devel] [PATCH] 196 Update other facets on delete from search page

2012-08-10 Thread Petr Vobornik
ipa/ticket/2618 Note: I found a refresh issue in search facet while using 'Add and edit' in adder dialog. This will be fixed separately. -- Petr Vobornik From afe6f6d892d6991ed4c597f11df8cb871052587e Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 8 Aug 2012 18:20:57 +0200 Sub

Re: [Freeipa-devel] [PATCH] 0007 Adds dependency on samba4-windbind.

2012-08-20 Thread Petr Vobornik
Dependency on samba4-winbind has been added to the package freeipa-server-trust-ad. Tomas +* Mon Aug 20 2012 Tomas Babej - 3.0.0-1 +- Add samba4-winbind to build dependencies for AD server-side code + Maybe a nitpick: Shouldn't the version be 2.99.0-42? -

Re: [Freeipa-devel] [PATCH] 193 Range Web UI

2012-08-20 Thread Petr Vobornik
012 2:08 AM, Petr Vobornik wrote: Range web UI was implemented. It consist of: * new menu item - 'ranges' in 'IPA Server' tab * new search page * new details page https://fedorahosted.org/freeipa/ticket/2894 Some comments/questions: 1) I'm not sure about opt

Re: [Freeipa-devel] [PATCH] 193 Range Web UI

2012-08-21 Thread Petr Vobornik
On 08/21/2012 09:00 AM, Sumit Bose wrote: On Mon, Aug 20, 2012 at 04:53:50PM -0500, Endi Sukma Dewata wrote: On 8/20/2012 10:49 AM, Petr Vobornik wrote: Updated patch attached. Preview can be seen at: http://pvoborni.fedorapeople.org/ranges/#ipaserver=range&navigation=ipaserver&ran

[Freeipa-devel] [PATCH] 197 Fixed search in HBAC test

2012-08-21 Thread Petr Vobornik
dd refresh button along with a) I prefer leave it as is or b) -- Petr Vobornik From adf5382a48a3ecc28f0f397385ff576e7d465326 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 21 Aug 2012 15:52:30 +0200 Subject: [PATCH] Fixed search in HBAC test Search in HBAC test wasn't working beca

<    3   4   5   6   7   8   9   10   11   12   >