URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
>Thanks for your contribution. I added your patch to my PR. On my system I ran
>into a minor issue. >Some C99 types like uint8_t were not defined and I had to
>include
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
Also I added section to FreeIPA wiki:
http://www.freeipa.org/page/V4/Build_system_refactoring#Packager_-_client_only_build
"""
See the full comment at
https://github.
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/70554938d4f9ba5b347cd4bc8001428e905198e4
https://fedorahosted.org/freeipa/changeset/41d7ae54fafc6deb602
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (22/02/17 06:16), Simo Sorce wrote:
>So this is the reasoning and why I am approving this PR and not #494.
>
>When you build all components, including server bits, te
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
simo5 commented:
"""
So this is the reasoning and why I am approving this PR and not #494.
When you build all components, including server bits, tests are installed,
therefore when we build j
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
>Thanks for your contribution. I added your patch to my PR. On my system I ran
>into a minor issue. >Some C99 types like uint8_t were not defined and I had to
>include
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tomaskrizek commented:
"""
The PR works and the `--without-ipatests` option omits the ipatests directory.
However, #494 doesn't install extra dependencies with `mock --without=server`.
"""
Se
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
>Thanks for your contribution. I added your patch to my PR. On my system I ran
>into a minor issue. >Some C99 types like uint8_t were not defined and I had to
>include
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
>Thanks for your contribution. I added your patch to my PR. On my system I ran
>into a minor issue. >Some C99 types like uint8_t were not defined and I had to
>include
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
HonzaCholasta commented:
"""
@tiran, not just for @lslebodn, `--without-ipatests` will be very useful to me
for RHEL and Arch Linux packaging as well 😉.
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Now ```-without-ipatests``` argument for @lslebodn
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/364#issuecomment-281478186
--
Manage your subscri
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Now ```-without-ipatests``` argument for @lslebodn
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/364#issuecomment-281478186
--
Manage your subscri
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Thanks for your contribution. I added your patch to my PR. On my system I ran
into a minor issue. Some C99 types like ```uint8_t``` were not defined and I
had to include
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
It looks like @tiran does not want to move this PR forward.
So here is a link to patch which does not misuse client-only
build and add configure time option to install
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (17/02/17 01:12), Petr Vobornik wrote:
>I still fail to see why we should care about `make dist` with `configure
>--disable-server` this is not a combination of opti
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
I still fail to see why we should care about `make dist` with `configure
--disable-server` this is not a combination of options which should be used
together, there is
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
I have to validate client-only Python wheel packages any way. We can just reuse
the same infrastructure to test client-only RPMs later. See PR #475.
By the way, validatio
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
martbab commented:
"""
Well you won't, and they were not tested automatically before AFAIK (checked
with FreeIPA 4.2.0 sources). We can agree that they *should* be, but since this
eventuality
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
I have one very important question: Without ipatests, how are you going to
automatically test client-only builds?
"""
See the full comment at
https://github.com/freeipa/
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (16/02/17 02:30), Christian Heimes wrote:
>Lukas, you are wasting both my and your precious time with a needless
>bike-shedding discussion about semantics. The ```--
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tomaskrizek commented:
"""
ACK, I'm fine with pushing this PR.
`make install` does install ipatests for client-only build, other
server-related packages are omitted.
Server build work like b
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
I think it is OK to keep the behavior of the patch and go with it provided that
the behavior is properly document in the design page after push.
The only reason to bl
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Lukas, you are wasting both my and your precious time with a needless
bike-shedding discussion about semantics. The ```--disable-server``` option
skips all parts of the b
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (16/02/17 00:57), Christian Heimes wrote:
>You are missing the point. Obviously tests are an important part of building.
>I can't test the client bits when ipatests
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
You are missing the point. Obviously tests are an important part of building. I
can't test the client bits when ipatests is not available.
Let's do small, incremental imp
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (14/02/17 02:29), Christian Heimes wrote:
>I'm following a different design and development philosophy. In my experience
>an iterative approach with small, increment
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
I'm following a different design and development philosophy. In my experience
an iterative approach with small, incremental improvements is often better and
faster than s
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 05:05), Christian Heimes wrote:
>I'm following the development principals of **minimum viable product**. This
>PR solves a critical use case for me. With t
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
I'm following the development principals of **minimum viable product**. This PR
solves a critical use case for me. With the PR I can build FreeIPA client
packages in a le
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 04:32), Christian Heimes wrote:
>No, the test runner should either detect missing packages and skip tests
>automatically, or should grow an option to load
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
No, the test runner should either detect missing packages and skip tests
automatically, or should grow an option to load and execute client tests only.
It's a separate is
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 03:56), Christian Heimes wrote:
>Two reasons
>
>1. ```make install```
>2. I need ipatests to be part of the build process in order to get a Python
>package
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Two reasons
1. ```make install```
2. I need ipatests to be part of the build process in order to get a Python
package for tox later.
"""
See the full comment at
https:/
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 03:08), Christian Heimes wrote:
>Packaging is a different issue. The PR does not provide RPM packaging for
>client-only build. It merely implements configu
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Packaging is a different issue. The PR does not provide RPM packaging for
client-only build. It merely implements configuration and building without
server components.
F
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (13/02/17 01:25), Christian Heimes wrote:
>@lslebodn it works even better without your proposed changes. Parts
>```ipatests``` work fine for ```--disable-server``` b
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
@lslebodn it works even better without your proposed changes. Parts
```ipatests``` work fine for ```--disable-server``` builds. I need the package
to run tests.
"""
See
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
It works quite good with the following change
```
diff --git a/Makefile.am b/Makefile.am
index 311f6121f..13e5a87b0 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,13
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
In the latest version, ```--disable-server``` does not affect ```make dist```.
It only changes the components that are built by ```make``` and installed by
```make instal
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
On (10/02/17 06:11), Petr Vobornik wrote:
>I still think that this use case needs to be documented in
>http://www.freeipa.org/page/V4/Build_system_refactoring#How_to_Us
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
I still think that this use case needs to be documented in
http://www.freeipa.org/page/V4/Build_system_refactoring#How_to_Use .
IMHO `make dist` can fail with --disab
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
I followed @lslebodn advice and changed the PR a bit. I now generate all
Makefiles again to fix the ```make dist``` issue. Some of the Makefile are not
working correctly
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tomaskrizek commented:
"""
Server build works now, but there's still the `make dist` issue discussed above.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/364#issuecommen
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
@tomaskrizek @lslebodn Although I don't need ```make dist```, you made me aware
of a bug in ```Makefile.am```. automake and ```+=``` do not mix well. I moved
the list int
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tomaskrizek commented:
"""
@tiran Do you need `make dist` for anything?
I'm not aware of any plans to release client-only IPA sources, so I don't think
it's needed.
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
See inline comment and issue above; otherwise LGTM.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/364#issuecomment-278405529
--
Manage your subs
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
`make dist` failed if configure was executed with `--disable-server`
```
make[3]: Leaving directory '/workdir/freeipa/po'
make[2]: Leaving directory '/workdir/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
@lslebodn I think you misunderstood me. The PR adds a new build flavor that
ignores and skips the any server-related steps of the build process. The fact
that this PR ign
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
I fine with ignoring python related parts; but it should be documented. But you
might ask other freeIPA developers. (maybe on freeipa-devel)
"""
See the full comment a
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
@lslebodn I like the idea to move the server related header and lib detection
to a separate m4 file.
In server-less mode, I plan to ignore the Python server part complete
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
lslebodn commented:
"""
I think it would be simpler to read the code without to many `AM_COND_IF()`.
IMHO it would be simpler to move C-related part to separate file (e.g.
`server_daemons.m4`
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tomaskrizek commented:
"""
I'm not really experienced with autotools, so I do not want to ack this PR
without someone else taking a look. I'm also not sure about the best practices
in this ar
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Nit-pick: A build does not produce any files outside the build environment. Of
course **make install** produces the files -- unless you change the prefix with
```./config
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tomaskrizek commented:
"""
The extra dependencies are indeed not necessary with this change.
However, `make install` produces directories like
`/usr/lib/python2.7/site-packages/ipaserver`,
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
The PR only affects ```make install```, Python packaging and integration
efforts. The goal is to reduce the amount of necessary build dependencies for
installation and pa
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tomaskrizek commented:
"""
Could you please extend [V4/Build system
refactoring](http://www.freeipa.org/page/V4/Build_system_refactoring) to
include steps describing how to perform client-onl
56 matches
Mail list logo
