---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2301/#review5200
---
I'm sorry I didn't spot this earlier, but it seems like you forgot to
On July 17, 2014, 10:35 a.m., Andreas Sandberg wrote:
I'm sorry I didn't spot this earlier, but it seems like you forgot to
include the ethernet device's interrupt in the MP table. See the interrupt
declaration for pci_dev4_inta for an example. Without that entry, Linux
won't be able
On July 15, 2014, 1:26 p.m., Andreas Sandberg wrote:
configs/common/FSConfig.py, line 431
http://reviews.gem5.org/r/2301/diff/3/?file=40047#file40047line431
I might be wrong here, but I think the InterruptLine is actually the
interrupt line as seen by the APIC. It doesn't have
On July 15, 2014, 1:26 p.m., Andreas Sandberg wrote:
Could you split this into two (or potentially three) different patches?
The PCI/ISA bus ID fixes look fine and should definitely go upstream ASAP.
As far as I'm concerned that particular part of the patch can be submitted
On 16/07/14 11:01, Jiuyue Ma via gem5-dev wrote:
On July 15, 2014, 1:26 p.m., Andreas Sandberg wrote:
Could you split this into two (or potentially three) different patches?
The PCI/ISA bus ID fixes look fine and should definitely go upstream ASAP. As
far as I'm concerned that particular
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2301/
---
(Updated July 17, 2014, 4:35 a.m.)
Review request for Default.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2301/#review5190
---
Could you split this into two (or potentially three) different patches?
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2301/#review5139
---
configs/common/FSConfig.py
http://reviews.gem5.org/r/2301/#comment4659
On June 17, 2014, 2:54 p.m., Andreas Hansson wrote:
configs/common/FSConfig.py, line 348
http://reviews.gem5.org/r/2301/diff/2/?file=39993#file39993line348
I do not understand why this is not covered by the last statement, i.e.
the Pci config space until the end of 64-bit space.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2301/
---
(Updated June 18, 2014, 1:42 a.m.)
Review request for Default.
Changes
---
On June 17, 2014, 2:54 p.m., Andreas Hansson wrote:
configs/common/FSConfig.py, line 429
http://reviews.gem5.org/r/2301/diff/2/?file=39993#file39993line429
It would be good to add a line describing where the values come from.
Change InterruptLine from IRQ13(reserved for
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2301/#review5136
---
configs/common/FSConfig.py
http://reviews.gem5.org/r/2301/#comment4657
12 matches
Mail list logo
