Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

[Anastasiia Butko]

> On oct. 17, 2016, 2:12 après-midi, Jason Lowe-Power wrote:
> > The diff doesn't apply correctly. Could you fix and re-upload?

I've combined both patches in one. And these changes do not include the 
MemConfig support.


- Anastasiia


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3666/#review8856
---


On oct. 18, 2016, 4:08 matin, Anastasiia Butko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3666/
> ---
> 
> (Updated oct. 18, 2016, 4:08 matin)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11670:c9fd4bc4a0cf
> ---
> arm, config: added support for ex5 model of big.LITTLE
> 
> This patch enables using calibrated big and LITTLE
> cores, ex5_big and ex5_LITTLE instead of the default
> 'arm_detailed' and 'minor' cpus. The ex5 model is based
> on the Samsung Exynos 5 Octa (5422) SoC. Operation and
> memory hierarchy latencies have been calibrated using the
> lmbench micro-benchmark suite. The preliminary validation
> results have been published as:
> 'Full-System Simulation of big.LITTLE Multicore Architecture
> for Performance and Energy Exploration', in International
> Symposium on Embedded Multicore/Many-core Systems-on-Chip
> (MCSoC'16), Lyon, France (Sep, 2016).
> 
> lat_ops bench results:
> --
>  bigLITTLE
> ops   SoC gem5SoC gem5
> --
> integer   bit:0.5 0.480.720.7
> integer   add:0.5 0.550.720.4
> integer   mul:1.561.682.161.87
> integer   div:45.36   36.32   53.347.32
> integer   mod:6.5618.55   17.37   18.02
> int64 bit:0.510.981.451.42
> uint64add:0.630.981.560.93
> int64 mul:2.522.133.644.68
> int64 div:92.61   195.52  213.14  197.63
> int64 mod:47.91   146.78  135.41  138.91
> float add:2.522.712.882.61
> float mul:3.022.842.882.73
> float div:9.078.9412.98   2.82
> doubleadd:2.522.712.882.61
> doublemul:3.022.845.042.73
> doublediv:16.13   10.43   23.03   2.81
> 
> lat_mem_rd bench results:
> --
>  bigLITTLE
> cache mem SoC gem5SoC gem5
> --
> l1/l1 0.5K4   4   3   3
>   1K  4   4   3   3
>   2K  4   4   3   3
>   3K  4   4   3   3
>   4K  4   4   3   3
>   6K  4   4   3   3
>   8K  4   4   3   3
>   12K 4   4   3   3
>   16K 4   18  3   3
>   24K 13  17  3   3
>   32K 18  18  6   11
> l2/l2 48K 23  20  9   14
>   64K 22  23  11  14
>   96K 23  23  13  14
>   128K23  23  14  15
>   192K23  23  15  17
>   256K23  23  17  17
>   384K23  24  29  17
>   512K23  24  59  39
> l2/Mem768K23  24  86  97
>   1M  23  24  112 110
>   1.5M35  25  153 147
>   2M  81  56  165 172
> Mem/Mem   3M  167 162 170 179
>   4M  217 213 171 182
>   6M  251 247 171 182
>   8M  260 257 171 182
>   12M 263 261 171 182
>   16M 265 261 171 182
> 
> Reported-by: Anastasiia Butko 
> 
> 
> Diffs
> -
> 
>   configs/common/ex5_big.py PRE-CREATION 
>   configs/example/arm/fs_bigLITTLE.py 220fa4099b9a 
>   configs/common/CpuConfig.py 220fa4099b9a 
>   configs/common/ex5_LITTLE.py PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3666/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anastasiia Butko
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

[Anastasiia Butko]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3666/
---

(Updated Oct. 18, 2016, 4:08 a.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11670:c9fd4bc4a0cf
---
arm, config: added support for ex5 model of big.LITTLE

This patch enables using calibrated big and LITTLE
cores, ex5_big and ex5_LITTLE instead of the default
'arm_detailed' and 'minor' cpus. The ex5 model is based
on the Samsung Exynos 5 Octa (5422) SoC. Operation and
memory hierarchy latencies have been calibrated using the
lmbench micro-benchmark suite. The preliminary validation
results have been published as:
'Full-System Simulation of big.LITTLE Multicore Architecture
for Performance and Energy Exploration', in International
Symposium on Embedded Multicore/Many-core Systems-on-Chip
(MCSoC'16), Lyon, France (Sep, 2016).

lat_ops bench results:
--
   bigLITTLE
ops SoC gem5SoC gem5
--
integer bit:0.5 0.480.720.7
integer add:0.5 0.550.720.4
integer mul:1.561.682.161.87
integer div:45.36   36.32   53.347.32
integer mod:6.5618.55   17.37   18.02
int64   bit:0.510.981.451.42
uint64  add:0.630.981.560.93
int64   mul:2.522.133.644.68
int64   div:92.61   195.52  213.14  197.63
int64   mod:47.91   146.78  135.41  138.91
float   add:2.522.712.882.61
float   mul:3.022.842.882.73
float   div:9.078.9412.98   2.82
double  add:2.522.712.882.61
double  mul:3.022.845.042.73
double  div:16.13   10.43   23.03   2.81

lat_mem_rd bench results:
--
   bigLITTLE
cache   mem SoC gem5SoC gem5
--
l1/l1   0.5K4   4   3   3
1K  4   4   3   3
2K  4   4   3   3
3K  4   4   3   3
4K  4   4   3   3
6K  4   4   3   3
8K  4   4   3   3
12K 4   4   3   3
16K 4   18  3   3
24K 13  17  3   3
32K 18  18  6   11
l2/l2   48K 23  20  9   14
64K 22  23  11  14
96K 23  23  13  14
128K23  23  14  15
192K23  23  15  17
256K23  23  17  17
384K23  24  29  17
512K23  24  59  39
l2/Mem  768K23  24  86  97
1M  23  24  112 110
1.5M35  25  153 147
2M  81  56  165 172
Mem/Mem 3M  167 162 170 179
4M  217 213 171 182
6M  251 247 171 182
8M  260 257 171 182
12M 263 261 171 182
16M 265 261 171 182

Reported-by: Anastasiia Butko 


Diffs (updated)
-

  configs/common/ex5_big.py PRE-CREATION 
  configs/example/arm/fs_bigLITTLE.py 220fa4099b9a 
  configs/common/CpuConfig.py 220fa4099b9a 
  configs/common/ex5_LITTLE.py PRE-CREATION 

Diff: http://reviews.gem5.org/r/3666/diff/


Testing
---


Thanks,

Anastasiia Butko

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

[Anastasiia Butko]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3666/
---

(Updated Oct. 18, 2016, 4:04 a.m.)


Review request for Default.


Summary (updated)
-

arm, config: added support for ex5 model of big.LITTLE


Repository: gem5


Description (updated)
---

Changeset 11670:cccf07bc045e
---
arm, config: added support for ex5 model of big.LITTLE

This patch enables using calibrated big and LITTLE
cores, ex5_big and ex5_LITTLE instead of the default
'arm_detailed' and 'minor' cpus. The ex5 model is based
on the Samsung Exynos 5 Octa (5422) SoC. Operation and
memory hierarchy latencies have been calibrated using the
lmbench micro-benchmark suite. The preliminary validation
results have been published as:
'Full-System Simulation of big.LITTLE Multicore Architecture
for Performance and Energy Exploration', in International
Symposium on Embedded Multicore/Many-core Systems-on-Chip
(MCSoC'16), Lyon, France (Sep, 2016).

lat_ops bench results:
--
   bigLITTLE
ops SoC gem5SoC gem5
--
integer bit:0.5 0.480.720.7
integer add:0.5 0.550.720.4
integer mul:1.561.682.161.87
integer div:45.36   36.32   53.347.32
integer mod:6.5618.55   17.37   18.02
int64   bit:0.510.981.451.42
uint64  add:0.630.981.560.93
int64   mul:2.522.133.644.68
int64   div:92.61   195.52  213.14  197.63
int64   mod:47.91   146.78  135.41  138.91
float   add:2.522.712.882.61
float   mul:3.022.842.882.73
float   div:9.078.9412.98   2.82
double  add:2.522.712.882.61
double  mul:3.022.845.042.73
double  div:16.13   10.43   23.03   2.81

lat_mem_rd bench results:
--
   bigLITTLE
cache   mem SoC gem5SoC gem5
--
l1/l1   0.5K4   4   3   3
1K  4   4   3   3
2K  4   4   3   3
3K  4   4   3   3
4K  4   4   3   3
6K  4   4   3   3
8K  4   4   3   3
12K 4   4   3   3
16K 4   18  3   3
24K 13  17  3   3
32K 18  18  6   11
l2/l2   48K 23  20  9   14
64K 22  23  11  14
96K 23  23  13  14
128K23  23  14  15
192K23  23  15  17
256K23  23  17  17
384K23  24  29  17
512K23  24  59  39
l2/Mem  768K23  24  86  97
1M  23  24  112 110
1.5M35  25  153 147
2M  81  56  165 172
Mem/Mem 3M  167 162 170 179
4M  217 213 171 182
6M  251 247 171 182
8M  260 257 171 182
12M 263 261 171 182
16M 265 261 171 182

Reported-by: Anastasiia Butko 


Diffs (updated)
-

  configs/common/ex5_LITTLE.py PRE-CREATION 
  configs/common/ex5_big.py PRE-CREATION 
  configs/example/arm/fs_bigLITTLE.py 220fa4099b9a 

Diff: http://reviews.gem5.org/r/3666/diff/


Testing
---


Thanks,

Anastasiia Butko

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

[Anastasiia Butko]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3665/#review8886
---

Ship it!


Ship It!

- Anastasiia Butko


On oct. 18, 2016, 3:43 matin, Anastasiia Butko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3665/
> ---
> 
> (Updated oct. 18, 2016, 3:43 matin)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11670:e69eb8bb1e2c
> ---
> arm, config: Enabled MemConfig usage for the example big.LITTLE
> 
> This patch replaces the SimpleMemory with the MemConfig
> function. Additional parser arguments are added
> (TODO: improve with addCommonOptions & addFSOptions).
> 
> Reported-by: Anastasiia Butko 
> 
> 
> Diffs
> -
> 
>   configs/example/arm/fs_bigLITTLE.py 220fa4099b9a 
> 
> Diff: http://reviews.gem5.org/r/3665/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anastasiia Butko
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

[Anastasiia Butko]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3665/
---

(Updated Oct. 18, 2016, 3:43 a.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11670:e69eb8bb1e2c
---
arm, config: Enabled MemConfig usage for the example big.LITTLE

This patch replaces the SimpleMemory with the MemConfig
function. Additional parser arguments are added
(TODO: improve with addCommonOptions & addFSOptions).

Reported-by: Anastasiia Butko 


Diffs (updated)
-

  configs/example/arm/fs_bigLITTLE.py 220fa4099b9a 

Diff: http://reviews.gem5.org/r/3665/diff/


Testing
---


Thanks,

Anastasiia Butko

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3671/#review8885
---


Seems reasonable to me, but do we have any historical context for "LiveProcess"?

Couple of small things below.


src/sim/Process.py (line 61)


Why this change?



src/sim/process.cc (line 564)


Any reason not to move this code into ProcessParams::create(), and 
eliminate this static function?


- Jason Lowe-Power


On Oct. 17, 2016, 3:17 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3671/
> ---
> 
> (Updated Oct. 17, 2016, 3:17 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11693:05fc28ce62a5
> ---
> syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead
> 
> The EIOProcess class was removed recently and it was the only other class
> which derived from Process. Since every Process invocation is also a
> LiveProcess invocation, it makes sense to simplify the who organization
> by combining the fields from LiveProcess into Process.
> 
> 
> Diffs
> -
> 
>   src/arch/sparc/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/freebsd/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/tru64/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/splash2/run.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/splash2/cluster.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/learning_gem5/part1/two_level.py 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/learning_gem5/part1/simple.py 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/example/se.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/example/apu_se.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/common/cpu2000.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_desc.cc PRE-CREATION 
>   src/sim/syscall_desc.hh PRE-CREATION 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/emul_driver.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/operatingsystem.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/operatingsystem.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/linux/linux.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/freebsd/freebsd.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/gpu-compute/cl_driver.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/gpu-compute/cl_driver.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3676/#review8881
---



src/sim/fd_array.hh (line 109)


This seems weird.  I'm pretty sure the '=' operator has access to all the 
private members and that this is not needed.



src/sim/fd_array.cc (line 75)


Do you need to cast here?



src/sim/fd_array.cc (line 88)


same here



src/sim/fd_array.cc (line 99)


same here



src/sim/fd_entry.hh (line 67)


Maybe mark as TODO?  Should also put a warn when trying to (un)serialize if 
you don't think it will work correctly.



src/sim/fd_entry.hh (line 128)


Can you rename this to something more descriptive, like HostMappedFDEntry?



src/sim/fd_entry.hh (line 156)


If you move simFD to the base class you can avoid a lot of your downcasts 
later.  I don't think it's a big deal that DeviceFDEntry doesn't use it.



src/sim/fd_entry.cc (line 33)


Should probably just add your name here, not delete the others.



src/sim/process.cc (line 245)


Why remove?  Does this not work anymore?



src/sim/syscall_emul.hh (line 631)


These downcasts are messy, see above for suggestion on getting rid of them.


- Michael LeBeane


On Oct. 17, 2016, 3:41 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3676/
> ---
> 
> (Updated Oct. 17, 2016, 3:41 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11698:502f94aa9638
> ---
> syscall_emul: [patch 10/22] refactor fdentry and add fdarray class
> 
> Several large changes happen in this patch.
> 
> The FDEntry class is rewritten so that file descriptors now correspond to
> types: 'Regular' which is normal file-backed file with the file open on the
> host machine, 'Pipe' which is a pipe that has been opened on the host machine,
> and 'Device' which does not have an open file on the host yet acts as a pseudo
> device with which to issue ioctls. Other types which might be added in the
> future are directory entries and sockets (off the top of my head).
> 
> The FDArray class was create to hold most of the file descriptor handling
> that was stuffed into the Process class. It uses shared pointers and
> the std::array type to hold the FDEntries mentioned above. The implementation
> could use a review; I feel that there's some room for improvement, but it
> seems like a decent first step.
> 
> The changes to these two classes needed to be propagated out to the rest
> of the code so there were quite a few changes for that. Also, comments were
> added where I thought they were needed to help others and extend our
> DOxygen coverage.
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/fd_array.hh PRE-CREATION 
>   src/sim/fd_array.cc PRE-CREATION 
>   src/sim/fd_entry.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/fd_entry.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3676/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3662/#review8884
---

Ship it!


Ship It!

- Jason Lowe-Power


On Oct. 17, 2016, 3:08 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3662/
> ---
> 
> (Updated Oct. 17, 2016, 3:08 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11690:4bd82b7d3c09
> ---
> syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc
> 
> The class was crammed into syscall_emul.hh which has tons of forward
> declarations and template definitions. To clean it up a bit, moved the
> class into separate files and commented the class with doxygen style
> comments. Also, provided some encapsulation by adding some accessors and
> a mutator.
> 
> The syscallreturn.hh file was renamed syscall_return.hh to make it consistent
> with other similarly named files in the src/sim directory.
> 
> The DPRINTF_SYSCALL macro was moved into its own header file with the
> include the Base and Verbose flags as well.
> 
> 
> Diffs
> -
> 
>   src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/solaris/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_debug_macros.hh PRE-CREATION 
>   src/sim/syscall_desc.hh PRE-CREATION 
>   src/sim/syscall_desc.cc PRE-CREATION 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscallreturn.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3662/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/#review8883
---

Ship it!


Ship It!

- Jason Lowe-Power


On Oct. 17, 2016, 3:07 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3660/
> ---
> 
> (Updated Oct. 17, 2016, 3:07 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11689:579f5d74b7a6
> ---
> style: [patch 1/22] use /r/3648/ to reorganize includes
> 
> 
> Diffs
> -
> 
>   src/cpu/static_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/DirectedGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/InvalidateGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/RubyDirectedTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/memtest/memtest.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/CheckTable.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/RubyTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/traffic_gen/generators.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_context.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_state.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/timing_expr.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/backdoor.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/a9scu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/energy_ctrl.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/gic_pl390.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/hdlcd.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/kmi.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl011.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl111.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/realview.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/rtc_pl031.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_cpulocal.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_sp804.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/vgic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/baddev.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/intel_8254_timer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/io_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/isa_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mc146818.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/host.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/platform.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/dtod.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/iob.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/mm_disk.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/t1000.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart8250.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/block.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/console.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/fs9p.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/pci.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/x86/cmos.cc 

Re: [gem5-dev] Review Request 3682: syscall_emul: remove TGT_MMAP_* flags that break OSX build

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3682/#review8882
---

Ship it!


Ship It!

- Jason Lowe-Power


On Oct. 17, 2016, 7:47 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3682/
> ---
> 
> (Updated Oct. 17, 2016, 7:47 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11687:f8a5cb63b09f
> ---
> syscall_emul: remove TGT_MMAP_* flags that break OSX build
> 
> Turns out that the flags weren't even used by any of the system
> call code so it's trivial to remove them.
> 
> 
> Diffs
> -
> 
>   src/arch/sparc/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/solaris/solaris.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/solaris/solaris.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/tru64/tru64.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3682/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

[Gutierrez, Anthony]

Agreed. I certainly prefer to simply remove it, and I think I speak for most 
folks at AMD (although I'd need to double check), but I'm not going to force 
the issue if others still use it and would like to keep it around.

-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Andreas Hansson
Sent: Monday, October 17, 2016 1:31 PM
To: gem5 Developer List 
Subject: Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

Hi all,

Why not grab the opportunity? Jason, what is the reason for the weeks/months? 
Why couldn’t we remove Alpha this week if we decide that’s the right thing to 
do?

Andreas

On 17/10/2016, 16:37, "gem5-dev on behalf of Gutierrez, Anthony"
 wrote:

>I would like to see this clarified before we ask Brandon to go work on 
>fixing ALPHA. If it is going to be phased out in a matter of months, I 
>don't think we should be asking him to waste his time on fixing it.
>
>-Original Message-
>From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason 
>Lowe-Power
>Sent: Monday, October 17, 2016 7:34 AM
>To: gem5 Developer List 
>Subject: Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 
>2.0
>
>Hi Brandon,
>
>We've had this discussion before. See this thread:
>http://www.mail-archive.com/gem5-dev@gem5.org/msg19380.html
>
>In summary... I think we're planning on phasing out ALPHA, but that 
>won't happen in the very short term (weeks), but may happen in the 
>medium term (months).
>
>Cheers,
>Jason
>
>On Mon, Oct 17, 2016 at 9:28 AM Potter, Brandon 
>
>wrote:
>
>> Switching this over to the dev mailing list since it seems more  
>>suitable (and I don’t have a user account; need to rectify that at 
>>some point).
>>
>> -Brandon
>>
>> From: Potter, Brandon
>> Sent: Monday, October 17, 2016 9:25 AM
>> To: 'Andreas Hansson' ; gem5 users mailing 
>> list < gem5-us...@gem5.org>
>> Subject: RE: [gem5-users] scons build error for Garnet 2.0
>>
>> Yes, I can fix it, but it’s difficult to know what values are for Tru64.
>>
>> Can we deprecate Alpha already?  It looks like the last commercial 
>> product that came out with Alpha was in 2007, almost a decade ago. I 
>> don’t think that I know anyone personally who uses a 10 year old 
>> computer.  I don’t think that I’ve ever used an Alpha either to boot; 
>> wondering why I need to go out of my way to try to support it.
>>
>> Does anyone use Alpha outside of running our regressions?
>>
>> -Brandon
>>
>> From: Andreas Hansson [mailto:andreas.hans...@arm.com]
>> Sent: Monday, October 17, 2016 3:29 AM
>> To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Cc: Potter, Brandon
>> > >>
>> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>>
>> My bad, this is properly broken for ALPHA and tru64.
>>
>> In fact this was broken as part of:
>>
>> changeset:   11383:5ac090acd180
>> user:Brandon Potter  brandon.pot...@amd.com>>
>> date:Thu Mar 17 10:24:17 2016 -0700
>> summary: syscall_emul: extend mmap system call to support file
>>backed
>> mmap
>>
>> It was later fixed for Linux, but not tru64 it appears.
>>
>> Brandon, could you get this resolved?
>>
>> Thanks,
>>
>> Andreas
>>
>> From: gem5-users  gem5-users-boun...@gem5.org>> on behalf of Andreas Hansson < 
>> andreas.hans...@arm.com>
>> Reply-To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Date: Monday, 17 October 2016 at 08:54
>> To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>>
>> Just use clang (i.e. the default OSX compiler).
>>
>> Andreas
>>
>> From: gem5-users  gem5-users-boun...@gem5.org>> on behalf of "F. A. Faisal" < 
>> dipu.7...@gmail.com>
>> Reply-To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Date: Saturday, 15 October 2016 at 14:22
>> To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>>
>>
>> I tried with another gcc, but the result is the same...
>>
>>
>>
>> $ port select --set gccmp-gcc49
>>
>>
>>
>> $ port select --list gcc
>>
>> Warning: port definitions are more than two weeks old, consider 
>> updating them by running 'port selfupdate'.
>>
>> Available versions for gcc:
>>
>> apple-gcc42
>>
>> mp-gcc47
>>
>> mp-gcc49 (active)
>>
>> none
>>
>>
>>
>> $ scons build/ALPHA_MOESI_hammer/gem5.debug
>>
>> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:82:21: error:
>> 'MAP_LOCKED' was not declared in this scope
>>
>>{ TGT_MAP_LOCKED, MAP_LOCKED },
>>
>>  ^
>>
>> 

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

[Jason Lowe-Power]

I just copied it from the previous email conversation, no real reason.

Digging through that chain I found this from Steve:
>
>
> 1. Let's prune a lot of the long regressions that don't add much value,
> particularly for less-supported ISAs.  Concretely, getting rid of all the
> long SE-mode ALPHA tests is pretty low-hanging fruit here.
> 2. Let's make sure the wiki is up-to-date on the level of support provided
> for various ISAs.
> 3. Let's add warnings, ideally at both compile time and run time, letting
> users know when they are using a less-supported ISA.
> 4. Let's make the default Ruby protocol something useful, so that we can do
> basic testing of both classic and Ruby memory systems with a single
> compile.
> 5. Let's only compile that one version of less-supported ISAs (read:
> ALPHA), instead of compiling it with four (!) different extra Ruby
> protocols.  If we really want to test multiple Ruby protocols, we might as
> well at least do it using a well-supported ISA.
> 6. Let's give it another few days, but unless someone responds to my
> pleading EIO email from 6/3, let's go ahead and ditch EIO support.


We did #6, but nothing else, as far as I know.

Also, Andreas S. suggested this, which we also ignored:

The ideal outcome of this discussion would be that we formalise
> maintainers for all of the ISAs and come up with a plan for unmaintained
> ISAs.


I have no problem removing ALPHA support now. Do you want to take the
responsibility, Andreas? We should first send a message to users giving
them a week or so to respond in case there's someone out there that's
actually using ALPHA. We should also make sure that most of the developers
are behind this idea. Maybe send out a vote email on gem5-dev and we can
hope for at least 4-5 +1 votes?

It would be great to get these other things done too, but I can't take the
responsibility right now. Maybe in a couple of months ;).

Cheers,
Jason


On Mon, Oct 17, 2016 at 3:30 PM Andreas Hansson 
wrote:

> Hi all,
>
> Why not grab the opportunity? Jason, what is the reason for the
> weeks/months? Why couldn’t we remove Alpha this week if we decide that’s
> the right thing to do?
>
> Andreas
>
> On 17/10/2016, 16:37, "gem5-dev on behalf of Gutierrez, Anthony"
>  wrote:
>
> >I would like to see this clarified before we ask Brandon to go work on
> >fixing ALPHA. If it is going to be phased out in a matter of months, I
> >don't think we should be asking him to waste his time on fixing it.
> >
> >-Original Message-
> >From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason
> >Lowe-Power
> >Sent: Monday, October 17, 2016 7:34 AM
> >To: gem5 Developer List 
> >Subject: Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0
> >
> >Hi Brandon,
> >
> >We've had this discussion before. See this thread:
> >http://www.mail-archive.com/gem5-dev@gem5.org/msg19380.html
> >
> >In summary... I think we're planning on phasing out ALPHA, but that won't
> >happen in the very short term (weeks), but may happen in the medium term
> >(months).
> >
> >Cheers,
> >Jason
> >
> >On Mon, Oct 17, 2016 at 9:28 AM Potter, Brandon 
> >wrote:
> >
> >> Switching this over to the dev mailing list since it seems more
> >> suitable (and I don’t have a user account; need to rectify that at some
> >>point).
> >>
> >> -Brandon
> >>
> >> From: Potter, Brandon
> >> Sent: Monday, October 17, 2016 9:25 AM
> >> To: 'Andreas Hansson' ; gem5 users mailing
> >> list < gem5-us...@gem5.org>
> >> Subject: RE: [gem5-users] scons build error for Garnet 2.0
> >>
> >> Yes, I can fix it, but it’s difficult to know what values are for Tru64.
> >>
> >> Can we deprecate Alpha already?  It looks like the last commercial
> >> product that came out with Alpha was in 2007, almost a decade ago. I
> >> don’t think that I know anyone personally who uses a 10 year old
> >> computer.  I don’t think that I’ve ever used an Alpha either to boot;
> >> wondering why I need to go out of my way to try to support it.
> >>
> >> Does anyone use Alpha outside of running our regressions?
> >>
> >> -Brandon
> >>
> >> From: Andreas Hansson [mailto:andreas.hans...@arm.com]
> >> Sent: Monday, October 17, 2016 3:29 AM
> >> To: gem5 users mailing list > gem5-us...@gem5.org>>
> >> Cc: Potter, Brandon
> >>  >> >>
> >> Subject: Re: [gem5-users] scons build error for Garnet 2.0
> >>
> >> My bad, this is properly broken for ALPHA and tru64.
> >>
> >> In fact this was broken as part of:
> >>
> >> changeset:   11383:5ac090acd180
> >> user:Brandon Potter > brandon.pot...@amd.com>>
> >> date:Thu Mar 17 10:24:17 2016 -0700
> >> summary: syscall_emul: extend mmap system call to support file
> >>backed
> >> mmap
> >>
> >> It was later fixed for 

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

[Andreas Hansson]

Hi all,

Why not grab the opportunity? Jason, what is the reason for the
weeks/months? Why couldn’t we remove Alpha this week if we decide that’s
the right thing to do?

Andreas

On 17/10/2016, 16:37, "gem5-dev on behalf of Gutierrez, Anthony"
 wrote:

>I would like to see this clarified before we ask Brandon to go work on
>fixing ALPHA. If it is going to be phased out in a matter of months, I
>don't think we should be asking him to waste his time on fixing it.
>
>-Original Message-
>From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason
>Lowe-Power
>Sent: Monday, October 17, 2016 7:34 AM
>To: gem5 Developer List 
>Subject: Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0
>
>Hi Brandon,
>
>We've had this discussion before. See this thread:
>http://www.mail-archive.com/gem5-dev@gem5.org/msg19380.html
>
>In summary... I think we're planning on phasing out ALPHA, but that won't
>happen in the very short term (weeks), but may happen in the medium term
>(months).
>
>Cheers,
>Jason
>
>On Mon, Oct 17, 2016 at 9:28 AM Potter, Brandon 
>wrote:
>
>> Switching this over to the dev mailing list since it seems more
>> suitable (and I don’t have a user account; need to rectify that at some
>>point).
>>
>> -Brandon
>>
>> From: Potter, Brandon
>> Sent: Monday, October 17, 2016 9:25 AM
>> To: 'Andreas Hansson' ; gem5 users mailing
>> list < gem5-us...@gem5.org>
>> Subject: RE: [gem5-users] scons build error for Garnet 2.0
>>
>> Yes, I can fix it, but it’s difficult to know what values are for Tru64.
>>
>> Can we deprecate Alpha already?  It looks like the last commercial
>> product that came out with Alpha was in 2007, almost a decade ago. I
>> don’t think that I know anyone personally who uses a 10 year old
>> computer.  I don’t think that I’ve ever used an Alpha either to boot;
>> wondering why I need to go out of my way to try to support it.
>>
>> Does anyone use Alpha outside of running our regressions?
>>
>> -Brandon
>>
>> From: Andreas Hansson [mailto:andreas.hans...@arm.com]
>> Sent: Monday, October 17, 2016 3:29 AM
>> To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Cc: Potter, Brandon
>> > >>
>> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>>
>> My bad, this is properly broken for ALPHA and tru64.
>>
>> In fact this was broken as part of:
>>
>> changeset:   11383:5ac090acd180
>> user:Brandon Potter  brandon.pot...@amd.com>>
>> date:Thu Mar 17 10:24:17 2016 -0700
>> summary: syscall_emul: extend mmap system call to support file
>>backed
>> mmap
>>
>> It was later fixed for Linux, but not tru64 it appears.
>>
>> Brandon, could you get this resolved?
>>
>> Thanks,
>>
>> Andreas
>>
>> From: gem5-users  gem5-users-boun...@gem5.org>> on behalf of Andreas Hansson <
>> andreas.hans...@arm.com>
>> Reply-To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Date: Monday, 17 October 2016 at 08:54
>> To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>>
>> Just use clang (i.e. the default OSX compiler).
>>
>> Andreas
>>
>> From: gem5-users  gem5-users-boun...@gem5.org>> on behalf of "F. A. Faisal" <
>> dipu.7...@gmail.com>
>> Reply-To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Date: Saturday, 15 October 2016 at 14:22
>> To: gem5 users mailing list  gem5-us...@gem5.org>>
>> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>>
>>
>> I tried with another gcc, but the result is the same...
>>
>>
>>
>> $ port select --set gccmp-gcc49
>>
>>
>>
>> $ port select --list gcc
>>
>> Warning: port definitions are more than two weeks old, consider
>> updating them by running 'port selfupdate'.
>>
>> Available versions for gcc:
>>
>> apple-gcc42
>>
>> mp-gcc47
>>
>> mp-gcc49 (active)
>>
>> none
>>
>>
>>
>> $ scons build/ALPHA_MOESI_hammer/gem5.debug
>>
>> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:82:21: error:
>> 'MAP_LOCKED' was not declared in this scope
>>
>>{ TGT_MAP_LOCKED, MAP_LOCKED },
>>
>>  ^
>>
>> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:83:23: error:
>> 'MAP_NONBLOCK' was not declared in this scope
>>
>>{ TGT_MAP_NONBLOCK, MAP_NONBLOCK },
>>
>>^
>>
>> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:85:23: error:
>> 'MAP_POPULATE' was not declared in this scope
>>
>>{ TGT_MAP_POPULATE, MAP_POPULATE },
>>
>>^
>>
>> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:86:20: error:
>> 'MAP_STACK' was not declared in this scope
>>
>>{ TGT_MAP_STACK, 

[gem5-dev] Review Request 3682: syscall_emul: remove TGT_MMAP_* flags that break OSX build

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3682/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11687:f8a5cb63b09f
---
syscall_emul: remove TGT_MMAP_* flags that break OSX build

Turns out that the flags weren't even used by any of the system
call code so it's trivial to remove them.


Diffs
-

  src/arch/sparc/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/solaris/solaris.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/solaris/solaris.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/tru64/tru64.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3682/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3674/#review8879
---

Ship it!


Ship It!

- Michael LeBeane


On Oct. 17, 2016, 3:23 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3674/
> ---
> 
> (Updated Oct. 17, 2016, 3:23 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11696:c48d378a972a
> ---
> syscall_emul: [patch 8/22] refactor process class
> 
> Moves aux_vector into its own .hh and .cc files just to get it out of the
> already crowded Process files. Arguably, it could stay there, but it's
> probably better just to move it and give it files.
> 
> The changeset looks ugly around the Process header file, but the goal here is
> to move methods and members around so that they're not defined randomly
> throughout the entire header file. I expect this is likely one of the reasons
> why I several unused variables related to this class. So, the methods are
> declared first followed by members. I've tried to aggregate them together
> so that similar entries reside near one another.
> 
> There are other changes coming to this code so this is by no means the
> final product.
> 
> 
> Diffs
> -
> 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/aux_vector.cc PRE-CREATION 
>   src/sim/aux_vector.hh PRE-CREATION 
>   src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3674/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3673: syscall_emul: [patch 7/22] remove numCpus method

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3673/#review8878
---



src/sim/process.hh 


Can you just rename this to numThreads() instead of making the num_threads 
variable?


- Michael LeBeane


On Oct. 17, 2016, 3:20 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3673/
> ---
> 
> (Updated Oct. 17, 2016, 3:20 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11695:b71b3bd60a70
> ---
> syscall_emul: [patch 7/22] remove numCpus method
> 
> The numCpus method is misleading in that it's not really a measure of
> how many CPUs might be executing a process, but how many thread contexts
> are assigned to the process at any given point in time.
> 
> It's nice to highlight this distinction because thread contexts are never
> reused in the same way that a CPU can be reused for multiple processes.
> The reason that there is no reuse is that there is no CPU scheduler for SE.
> 
> The tru64 code intends to use this method and the accompanying contextIDs
> field to support SMT and track the number of threads with some system calls.
> With the up coming clone and exec patches, this paradigm must change. There
> needs to be a 1:1 mapping between the thread contexts and processes so that
> the process state between threads is allowed to vary when needed by Linux.
> This should not break SMT for tru64 if the Process class is refactored so that
> multiple Processes can share state between themselves. The following patches
> will do the refactoring incrementally as features are added.
> 
> 
> Diffs
> -
> 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3673/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3679: style: [patch 12/22] fix preliminary style issues for subsequent fault patch

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3679/#review8877
---

Ship it!


Ship It!

- Michael LeBeane


On Oct. 17, 2016, 4:11 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3679/
> ---
> 
> (Updated Oct. 17, 2016, 4:11 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11700:db830c773c2d
> ---
> style: [patch 12/22] fix preliminary style issues for subsequent fault patch
> 
> This changeset add spaces in a few spots and removes an unnecessary comment.
> 
> 
> Diffs
> -
> 
>   src/sim/faults.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3679/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3675: syscall_emul: [patch 9/22] remove unused global variable (num_processes)

[Tony Gutierrez]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3675/#review8875
---

Ship it!


Ship It!

- Tony Gutierrez


On Oct. 17, 2016, 8:25 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3675/
> ---
> 
> (Updated Oct. 17, 2016, 8:25 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11697:e818bb00b9ea
> ---
> syscall_emul: [patch 9/22] remove unused global variable (num_processes)
> 
> 
> Diffs
> -
> 
>   src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

[Alexandru Dutu]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3672/#review8876
---

Ship it!


Ship It!

- Alexandru Dutu


On Oct. 17, 2016, 3:19 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3672/
> ---
> 
> (Updated Oct. 17, 2016, 3:19 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11694:ebff480ad584
> ---
> syscall_emul: [patch 6/22] remove unused fields from Process class
> 
> It looks like tru64 has some nxm* system calls, but the two fields that
> are defined in the Process class are unused by any of the code. There doesn't
> appear to be any reference in the tru64 code.
> 
> 
> Diffs
> -
> 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3672/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

[Alexandru Dutu]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3670/#review8873
---



src/sim/process.cc 


Even if we are serializing nextPid in the System object, shouldn't we still 
serialize _pid? We might need to have the same pids restored and not reassign 
different ones.



src/sim/process.cc 


Same goes for unserialization.


- Alexandru Dutu


On Oct. 17, 2016, 3:14 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3670/
> ---
> 
> (Updated Oct. 17, 2016, 3:14 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11692:ba60e4ae816f
> ---
> syscall_emul: [patch 4/22] remove redundant M5_pid field from process
> 
> 
> Diffs
> -
> 
>   src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

[Tony Gutierrez]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3672/#review8872
---

Ship it!


Ship It!

- Tony Gutierrez


On Oct. 17, 2016, 8:19 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3672/
> ---
> 
> (Updated Oct. 17, 2016, 8:19 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11694:ebff480ad584
> ---
> syscall_emul: [patch 6/22] remove unused fields from Process class
> 
> It looks like tru64 has some nxm* system calls, but the two fields that
> are defined in the Process class are unused by any of the code. There doesn't
> appear to be any reference in the tru64 code.
> 
> 
> Diffs
> -
> 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3672/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

[Alexandru Dutu]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3662/#review8871
---

Ship it!


Ship It!

- Alexandru Dutu


On Oct. 17, 2016, 3:08 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3662/
> ---
> 
> (Updated Oct. 17, 2016, 3:08 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11690:4bd82b7d3c09
> ---
> syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc
> 
> The class was crammed into syscall_emul.hh which has tons of forward
> declarations and template definitions. To clean it up a bit, moved the
> class into separate files and commented the class with doxygen style
> comments. Also, provided some encapsulation by adding some accessors and
> a mutator.
> 
> The syscallreturn.hh file was renamed syscall_return.hh to make it consistent
> with other similarly named files in the src/sim directory.
> 
> The DPRINTF_SYSCALL macro was moved into its own header file with the
> include the Base and Verbose flags as well.
> 
> 
> Diffs
> -
> 
>   src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/solaris/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_debug_macros.hh PRE-CREATION 
>   src/sim/syscall_desc.hh PRE-CREATION 
>   src/sim/syscall_desc.cc PRE-CREATION 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscallreturn.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3662/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

[Tony Gutierrez]

> On Oct. 17, 2016, 7:15 a.m., Jason Lowe-Power wrote:
> > With this patch, if you run multiple processes in SE mode they all have the 
> > same PID (100) by default. Will this cause issues? I haven't tested a 
> > pthreads application, but that seems like it might cause problems.
> > 
> > Would you just suggest that we make sure to assign different PIDs in the 
> > Python config file (where we create the Process object) to get around this 
> > issue? If so, we should have a fatal if there are multiple Processes with 
> > the same PID.
> 
> Brandon Potter wrote:
> I have another patch that I haven't posted yet that used to rely on the 
> incrementing PID that I deleted here. I haven't figured out how I want to 
> address the issue yet. The two obvious ways are to make the changes in Python 
> or make the changes in C++ and use the counter to increment the value when 
> new Process classes are created. I think that I might have to use the 
> incrementing version with clone and I might add that functionality back in 
> with C++, but I'll increment the _pid field that you see here in this patch 
> rather than having nextPID, M5_pid, and _pid. We don't need several versions 
> of the same thing to make it work.
> 
> Jason Lowe-Power wrote:
> One option from the Python side is to use a static class variable in 
> Process.py to automatically assign it. I think there's an example of this in 
> configs/topologies/Cluster.py (and other places, too).

If it is going to be auto-assigned, I think it would be better to add the 
static variable in the C++. I see no need to expose auto-assigned vars in the 
python configs, unless there are cases where users would need to assign a 
specific PID to a process?


- Tony


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3670/#review8858
---


On Oct. 17, 2016, 8:14 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3670/
> ---
> 
> (Updated Oct. 17, 2016, 8:14 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11692:ba60e4ae816f
> ---
> syscall_emul: [patch 4/22] remove redundant M5_pid field from process
> 
> 
> Diffs
> -
> 
>   src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3680: syscall_emul: [patch 13/22] add system call retry capability

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3680/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11701:93773f0980da
---
syscall_emul: [patch 13/22] add system call retry capability

This changeset adds functionality that allows system calls to retry without
affecting system state during on system call returns.

We need this functionality to solve problems with blocking system calls
in multi-process or multi-threaded simulations where information is passed
between processes/threads.

For example, consider two processes that are producer/consumer. They can
use file descriptors and read/write to pass the information between one
another. However if the consumer calls the blocking read system call before
the producer has produced anything, the call will block the event queue and
deadlock the simulation. The trick it to recognize that the system calls will
block and then reschedule at some later point when the call would succeed
without blocking. In subsequent patches, we recognize that a syscall will'
block by calling a non-blocking poll and check for events.

This version only supports X86 and will break the other ISAs. I am posting it
with the hope that someone can tell me which instructions the other ISAs
use to implement their system calls and also to get feedback on the general
methodology.


Diffs
-

  configs/example/se.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/isa/decoder/one_byte_opcodes.isa 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/isa/decoder/two_byte_opcodes.isa 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/pseudo_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/BaseCPU.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/base.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/checker/cpu.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/checker/thread_context.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/exec_context.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/o3/commit.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/o3/commit_impl.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/o3/cpu.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/o3/cpu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/o3/dyn_inst.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/o3/dyn_inst_impl.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/o3/thread_context.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/o3/thread_state.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/simple/atomic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/simple/exec_context.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/simple/timing.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/simple_thread.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/thread_context.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/faults.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_desc.hh PRE-CREATION 
  src/sim/syscall_desc.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3680/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

[Tony Gutierrez]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3662/#review8869
---

Ship it!


Ship It!

- Tony Gutierrez


On Oct. 17, 2016, 8:08 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3662/
> ---
> 
> (Updated Oct. 17, 2016, 8:08 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11690:4bd82b7d3c09
> ---
> syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc
> 
> The class was crammed into syscall_emul.hh which has tons of forward
> declarations and template definitions. To clean it up a bit, moved the
> class into separate files and commented the class with doxygen style
> comments. Also, provided some encapsulation by adding some accessors and
> a mutator.
> 
> The syscallreturn.hh file was renamed syscall_return.hh to make it consistent
> with other similarly named files in the src/sim directory.
> 
> The DPRINTF_SYSCALL macro was moved into its own header file with the
> include the Base and Verbose flags as well.
> 
> 
> Diffs
> -
> 
>   src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/solaris/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_debug_macros.hh PRE-CREATION 
>   src/sim/syscall_desc.hh PRE-CREATION 
>   src/sim/syscall_desc.cc PRE-CREATION 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscallreturn.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3662/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3675: syscall_emul: [patch 9/22] remove unused global variable (num_processes)

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3675/#review8867
---

Ship it!


Ship It!

- Michael LeBeane


On Oct. 17, 2016, 3:25 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3675/
> ---
> 
> (Updated Oct. 17, 2016, 3:25 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11697:e818bb00b9ea
> ---
> syscall_emul: [patch 9/22] remove unused global variable (num_processes)
> 
> 
> Diffs
> -
> 
>   src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

[Tony Gutierrez]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/#review8868
---

Ship it!


Ship It!

- Tony Gutierrez


On Oct. 17, 2016, 8:07 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3660/
> ---
> 
> (Updated Oct. 17, 2016, 8:07 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11689:579f5d74b7a6
> ---
> style: [patch 1/22] use /r/3648/ to reorganize includes
> 
> 
> Diffs
> -
> 
>   src/cpu/static_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/DirectedGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/InvalidateGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/RubyDirectedTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/memtest/memtest.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/CheckTable.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/RubyTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/traffic_gen/generators.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_context.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_state.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/timing_expr.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/backdoor.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/a9scu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/energy_ctrl.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/gic_pl390.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/hdlcd.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/kmi.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl011.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl111.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/realview.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/rtc_pl031.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_cpulocal.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_sp804.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/vgic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/baddev.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/intel_8254_timer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/io_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/isa_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mc146818.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/host.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/platform.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/dtod.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/iob.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/mm_disk.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/t1000.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart8250.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/block.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/console.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/fs9p.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/pci.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/x86/cmos.cc 

Re: [gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3672/#review8865
---

Ship it!


Ship It!

- Michael LeBeane


On Oct. 17, 2016, 3:19 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3672/
> ---
> 
> (Updated Oct. 17, 2016, 3:19 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11694:ebff480ad584
> ---
> syscall_emul: [patch 6/22] remove unused fields from Process class
> 
> It looks like tru64 has some nxm* system calls, but the two fields that
> are defined in the Process class are unused by any of the code. There doesn't
> appear to be any reference in the tru64 code.
> 
> 
> Diffs
> -
> 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3672/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3671/#review8864
---



src/arch/arm/process.hh (line 54)


I don't think this is needed.



src/arch/mips/process.hh (line 41)


I don't think this is needed.



src/arch/power/process.hh (line 42)


I don't think this is needed.



src/arch/sparc/faults.cc (line 673)


Why remove comment?


- Michael LeBeane


On Oct. 17, 2016, 3:17 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3671/
> ---
> 
> (Updated Oct. 17, 2016, 3:17 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11693:05fc28ce62a5
> ---
> syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead
> 
> The EIOProcess class was removed recently and it was the only other class
> which derived from Process. Since every Process invocation is also a
> LiveProcess invocation, it makes sense to simplify the who organization
> by combining the fields from LiveProcess into Process.
> 
> 
> Diffs
> -
> 
>   src/arch/sparc/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/freebsd/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/tru64/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/splash2/run.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/splash2/cluster.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/learning_gem5/part1/two_level.py 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/learning_gem5/part1/simple.py 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/example/se.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/example/apu_se.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   configs/common/cpu2000.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_desc.cc PRE-CREATION 
>   src/sim/syscall_desc.hh PRE-CREATION 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/emul_driver.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/operatingsystem.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/operatingsystem.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/linux/linux.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/freebsd/freebsd.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/gpu-compute/cl_driver.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/gpu-compute/cl_driver.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   

[gem5-dev] Review Request 3679: style: [patch 12/22] fix preliminary style issues for subsequent fault patch

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3679/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11700:db830c773c2d
---
style: [patch 12/22] fix preliminary style issues for subsequent fault patch

This changeset add spaces in a few spots and removes an unnecessary comment.


Diffs
-

  src/sim/faults.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3679/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3643: style: [patch 3/22] reduce include dependencies in some headers

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3643/#review8863
---

Ship it!


Ship It!

- Michael LeBeane


On Oct. 17, 2016, 3:12 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3643/
> ---
> 
> (Updated Oct. 17, 2016, 3:12 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11691:ba6ddbf68d8c
> ---
> style: [patch 3/22] reduce include dependencies in some headers
> 
> Used cppclean to help identify useless includes and removed them. This
> involved erroneously included headers, but also cases where forward
> declarations could have been used rather than a full include.
> 
> 
> Diffs
> -
> 
>   src/arch/alpha/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/interrupts.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/remote_gdb.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/isa_traits.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/pagetable.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/pseudo_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/tlb.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/tlb.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/utility.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/utility.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/base/bitfield.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/base/bitunion.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/base/time.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/base/vnc/vncinput.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/minor/buffers.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/InvalidateGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/RubyDirectedTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/CheckTable.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/flash_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mc146818.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/net/dist_iface.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/net/etherbus.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/net/etherswitch.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/linux/linux.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/cache/prefetch/stride.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/external_master.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/external_slave.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/mem_checker.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/multi_level_page_table.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/multi_level_page_table_impl.hh 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/page_table.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/page_table.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/ruby/network/MessageBuffer.hh 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/ruby/structures/AbstractReplacementPolicy.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/se_translating_port_proxy.hh 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/mem/simple_mem.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/python/swig/pyevent.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3662/#review8862
---

Ship it!


Ship It!

- Michael LeBeane


On Oct. 17, 2016, 3:08 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3662/
> ---
> 
> (Updated Oct. 17, 2016, 3:08 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11690:4bd82b7d3c09
> ---
> syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc
> 
> The class was crammed into syscall_emul.hh which has tons of forward
> declarations and template definitions. To clean it up a bit, moved the
> class into separate files and commented the class with doxygen style
> comments. Also, provided some encapsulation by adding some accessors and
> a mutator.
> 
> The syscallreturn.hh file was renamed syscall_return.hh to make it consistent
> with other similarly named files in the src/sim directory.
> 
> The DPRINTF_SYSCALL macro was moved into its own header file with the
> include the Base and Verbose flags as well.
> 
> 
> Diffs
> -
> 
>   src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/solaris/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_debug_macros.hh PRE-CREATION 
>   src/sim/syscall_desc.hh PRE-CREATION 
>   src/sim/syscall_desc.cc PRE-CREATION 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscallreturn.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3662/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/#review8861
---

Ship it!


Ship It!

- Michael LeBeane


On Oct. 17, 2016, 3:07 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3660/
> ---
> 
> (Updated Oct. 17, 2016, 3:07 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11689:579f5d74b7a6
> ---
> style: [patch 1/22] use /r/3648/ to reorganize includes
> 
> 
> Diffs
> -
> 
>   src/cpu/static_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/DirectedGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/InvalidateGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/RubyDirectedTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/memtest/memtest.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/CheckTable.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/RubyTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/traffic_gen/generators.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_context.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_state.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/timing_expr.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/backdoor.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/a9scu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/energy_ctrl.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/gic_pl390.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/hdlcd.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/kmi.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl011.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl111.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/realview.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/rtc_pl031.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_cpulocal.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_sp804.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/vgic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/baddev.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/intel_8254_timer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/io_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/isa_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mc146818.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/host.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/platform.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/dtod.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/iob.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/mm_disk.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/t1000.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart8250.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/block.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/console.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/fs9p.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/pci.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/x86/cmos.cc 

[gem5-dev] Review Request 3677: syscall_emul: [patch 11/22] extend functionality of fcntl

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3677/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11699:0d1798da97c9
---
syscall_emul: [patch 11/22] extend functionality of fcntl

This changeset adds defines for new Linux flags for the fcntl system call,
moves the fcntl implementation from syscall_emul.cc to syscall_emul.cc, and
rewrites the system call.


Diffs
-

  src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3677/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3676/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11698:502f94aa9638
---
syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

Several large changes happen in this patch.

The FDEntry class is rewritten so that file descriptors now correspond to
types: 'Regular' which is normal file-backed file with the file open on the
host machine, 'Pipe' which is a pipe that has been opened on the host machine,
and 'Device' which does not have an open file on the host yet acts as a pseudo
device with which to issue ioctls. Other types which might be added in the
future are directory entries and sockets (off the top of my head).

The FDArray class was create to hold most of the file descriptor handling
that was stuffed into the Process class. It uses shared pointers and
the std::array type to hold the FDEntries mentioned above. The implementation
could use a review; I feel that there's some room for improvement, but it
seems like a decent first step.

The changes to these two classes needed to be propagated out to the rest
of the code so there were quite a few changes for that. Also, comments were
added where I thought they were needed to help others and extend our
DOxygen coverage.


Diffs
-

  src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/fd_array.hh PRE-CREATION 
  src/sim/fd_array.cc PRE-CREATION 
  src/sim/fd_entry.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/fd_entry.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3676/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

[Gutierrez, Anthony]

I would like to see this clarified before we ask Brandon to go work on fixing 
ALPHA. If it is going to be phased out in a matter of months, I don't think we 
should be asking him to waste his time on fixing it.

-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason Lowe-Power
Sent: Monday, October 17, 2016 7:34 AM
To: gem5 Developer List 
Subject: Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

Hi Brandon,

We've had this discussion before. See this thread:
http://www.mail-archive.com/gem5-dev@gem5.org/msg19380.html

In summary... I think we're planning on phasing out ALPHA, but that won't 
happen in the very short term (weeks), but may happen in the medium term 
(months).

Cheers,
Jason

On Mon, Oct 17, 2016 at 9:28 AM Potter, Brandon 
wrote:

> Switching this over to the dev mailing list since it seems more 
> suitable (and I don’t have a user account; need to rectify that at some 
> point).
>
> -Brandon
>
> From: Potter, Brandon
> Sent: Monday, October 17, 2016 9:25 AM
> To: 'Andreas Hansson' ; gem5 users mailing 
> list < gem5-us...@gem5.org>
> Subject: RE: [gem5-users] scons build error for Garnet 2.0
>
> Yes, I can fix it, but it’s difficult to know what values are for Tru64.
>
> Can we deprecate Alpha already?  It looks like the last commercial 
> product that came out with Alpha was in 2007, almost a decade ago. I 
> don’t think that I know anyone personally who uses a 10 year old 
> computer.  I don’t think that I’ve ever used an Alpha either to boot; 
> wondering why I need to go out of my way to try to support it.
>
> Does anyone use Alpha outside of running our regressions?
>
> -Brandon
>
> From: Andreas Hansson [mailto:andreas.hans...@arm.com]
> Sent: Monday, October 17, 2016 3:29 AM
> To: gem5 users mailing list >
> Cc: Potter, Brandon 
>  >>
> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>
> My bad, this is properly broken for ALPHA and tru64.
>
> In fact this was broken as part of:
>
> changeset:   11383:5ac090acd180
> user:Brandon Potter >
> date:Thu Mar 17 10:24:17 2016 -0700
> summary: syscall_emul: extend mmap system call to support file backed
> mmap
>
> It was later fixed for Linux, but not tru64 it appears.
>
> Brandon, could you get this resolved?
>
> Thanks,
>
> Andreas
>
> From: gem5-users > on behalf of Andreas Hansson < 
> andreas.hans...@arm.com>
> Reply-To: gem5 users mailing list >
> Date: Monday, 17 October 2016 at 08:54
> To: gem5 users mailing list >
> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>
> Just use clang (i.e. the default OSX compiler).
>
> Andreas
>
> From: gem5-users > on behalf of "F. A. Faisal" < 
> dipu.7...@gmail.com>
> Reply-To: gem5 users mailing list >
> Date: Saturday, 15 October 2016 at 14:22
> To: gem5 users mailing list >
> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>
>
> I tried with another gcc, but the result is the same...
>
>
>
> $ port select --set gccmp-gcc49
>
>
>
> $ port select --list gcc
>
> Warning: port definitions are more than two weeks old, consider 
> updating them by running 'port selfupdate'.
>
> Available versions for gcc:
>
> apple-gcc42
>
> mp-gcc47
>
> mp-gcc49 (active)
>
> none
>
>
>
> $ scons build/ALPHA_MOESI_hammer/gem5.debug
>
> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:82:21: error:
> 'MAP_LOCKED' was not declared in this scope
>
>{ TGT_MAP_LOCKED, MAP_LOCKED },
>
>  ^
>
> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:83:23: error:
> 'MAP_NONBLOCK' was not declared in this scope
>
>{ TGT_MAP_NONBLOCK, MAP_NONBLOCK },
>
>^
>
> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:85:23: error:
> 'MAP_POPULATE' was not declared in this scope
>
>{ TGT_MAP_POPULATE, MAP_POPULATE },
>
>^
>
> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:86:20: error:
> 'MAP_STACK' was not declared in this scope
>
>{ TGT_MAP_STACK, MAP_STACK },
>
> ^
>
> scons: *** [build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.do] Error 
> 1
>
> scons: building terminated because of errors.
>
>
>
> Thanks...
>
>
> On Sat, Oct 15, 2016 at 10:06 PM, Abdul Mutaal  > wrote:
>
> Try with >=4.5
>
> On Oct 15, 2016 2:56 PM, "F. A. Faisal" > wrote:
>
> $ g++ -v
>
> Configured with: 
> 

[gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3674/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11696:c48d378a972a
---
syscall_emul: [patch 8/22] refactor process class

Moves aux_vector into its own .hh and .cc files just to get it out of the
already crowded Process files. Arguably, it could stay there, but it's
probably better just to move it and give it files.

The changeset looks ugly around the Process header file, but the goal here is
to move methods and members around so that they're not defined randomly
throughout the entire header file. I expect this is likely one of the reasons
why I several unused variables related to this class. So, the methods are
declared first followed by members. I've tried to aggregate them together
so that similar entries reside near one another.

There are other changes coming to this code so this is by no means the
final product.


Diffs
-

  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/aux_vector.cc PRE-CREATION 
  src/sim/aux_vector.hh PRE-CREATION 
  src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3674/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3675: syscall_emul: [patch 9/22] remove unused global variable (num_processes)

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3675/
---

(Updated Oct. 17, 2016, 3:25 p.m.)


Review request for Default.


Summary (updated)
-

syscall_emul: [patch 9/22] remove unused global variable (num_processes)


Repository: gem5


Description (updated)
---

Changeset 11697:e818bb00b9ea
---
syscall_emul: [patch 9/22] remove unused global variable (num_processes)


Diffs (updated)
-

  src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3675/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3673: syscall_emul: [patch 7/22] remove numCpus method

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3673/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11695:b71b3bd60a70
---
syscall_emul: [patch 7/22] remove numCpus method

The numCpus method is misleading in that it's not really a measure of
how many CPUs might be executing a process, but how many thread contexts
are assigned to the process at any given point in time.

It's nice to highlight this distinction because thread contexts are never
reused in the same way that a CPU can be reused for multiple processes.
The reason that there is no reuse is that there is no CPU scheduler for SE.

The tru64 code intends to use this method and the accompanying contextIDs
field to support SMT and track the number of threads with some system calls.
With the up coming clone and exec patches, this paradigm must change. There
needs to be a 1:1 mapping between the thread contexts and processes so that
the process state between threads is allowed to vary when needed by Linux.
This should not break SMT for tru64 if the Process class is refactored so that
multiple Processes can share state between themselves. The following patches
will do the refactoring incrementally as features are added.


Diffs
-

  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3673/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3672/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11694:ebff480ad584
---
syscall_emul: [patch 6/22] remove unused fields from Process class

It looks like tru64 has some nxm* system calls, but the two fields that
are defined in the Process class are unused by any of the code. There doesn't
appear to be any reference in the tru64 code.


Diffs
-

  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3672/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3671/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11693:05fc28ce62a5
---
syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

The EIOProcess class was removed recently and it was the only other class
which derived from Process. Since every Process invocation is also a
LiveProcess invocation, it makes sense to simplify the who organization
by combining the fields from LiveProcess into Process.


Diffs
-

  src/arch/sparc/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/freebsd/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/tru64/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  configs/splash2/run.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  configs/splash2/cluster.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  configs/learning_gem5/part1/two_level.py 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  configs/learning_gem5/part1/simple.py 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  configs/example/se.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  configs/example/apu_se.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  configs/common/cpu2000.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_desc.cc PRE-CREATION 
  src/sim/syscall_desc.hh PRE-CREATION 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/emul_driver.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/operatingsystem.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/operatingsystem.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/linux/linux.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/freebsd/freebsd.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/gpu-compute/cl_driver.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/gpu-compute/cl_driver.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/linux/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/solaris/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/solaris/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3671/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3670/
---

(Updated Oct. 17, 2016, 3:14 p.m.)


Review request for Default.


Summary (updated)
-

syscall_emul: [patch 4/22] remove redundant M5_pid field from process


Repository: gem5


Description (updated)
---

Changeset 11692:ba60e4ae816f
---
syscall_emul: [patch 4/22] remove redundant M5_pid field from process


Diffs (updated)
-

  src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3670/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3662/
---

(Updated Oct. 17, 2016, 3:08 p.m.)


Review request for Default.


Summary (updated)
-

syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc


Repository: gem5


Description (updated)
---

Changeset 11690:4bd82b7d3c09
---
syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

The class was crammed into syscall_emul.hh which has tons of forward
declarations and template definitions. To clean it up a bit, moved the
class into separate files and commented the class with doxygen style
comments. Also, provided some encapsulation by adding some accessors and
a mutator.

The syscallreturn.hh file was renamed syscall_return.hh to make it consistent
with other similarly named files in the src/sim directory.

The DPRINTF_SYSCALL macro was moved into its own header file with the
include the Base and Verbose flags as well.


Diffs (updated)
-

  src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/solaris/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_debug_macros.hh PRE-CREATION 
  src/sim/syscall_desc.hh PRE-CREATION 
  src/sim/syscall_desc.cc PRE-CREATION 
  src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscallreturn.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3662/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/
---

(Updated Oct. 17, 2016, 3:07 p.m.)


Review request for Default.


Summary (updated)
-

style: [patch 1/22] use /r/3648/ to reorganize includes


Repository: gem5


Description (updated)
---

Changeset 11689:579f5d74b7a6
---
style: [patch 1/22] use /r/3648/ to reorganize includes


Diffs (updated)
-

  src/cpu/static_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/DirectedGenerator.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/InvalidateGenerator.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/RubyDirectedTester.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/memtest/memtest.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/rubytest/CheckTable.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/rubytest/RubyTester.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/traffic_gen/generators.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/thread_context.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/thread_state.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/timing_expr.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/alpha/backdoor.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/alpha/tsunami.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/alpha/tsunami_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/alpha/tsunami_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/a9scu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/amba_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/amba_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/energy_ctrl.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/gic_pl390.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/hdlcd.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/kmi.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/pl011.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/pl111.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/realview.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/rtc_pl031.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/timer_cpulocal.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/timer_sp804.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/vgic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/baddev.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/intel_8254_timer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/io_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/isa_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/mc146818.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/mips/malta.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/mips/malta_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/mips/malta_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/pci/device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/pci/host.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/platform.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/ps2.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/ps2.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/sparc/dtod.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/sparc/iob.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/sparc/mm_disk.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/sparc/t1000.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/uart.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/uart8250.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/block.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/console.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/fs9p.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/pci.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/cmos.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i8042.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i82094aa.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i8237.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i8254.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i8259.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/pc.cc 

Re: [gem5-dev] Review Request 3643: style: [patch 3/22] reduce include dependencies in some headers

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3643/
---

(Updated Oct. 17, 2016, 3:12 p.m.)


Review request for Default.


Summary (updated)
-

style: [patch 3/22] reduce include dependencies in some headers


Repository: gem5


Description (updated)
---

Changeset 11691:ba6ddbf68d8c
---
style: [patch 3/22] reduce include dependencies in some headers

Used cppclean to help identify useless includes and removed them. This
involved erroneously included headers, but also cases where forward
declarations could have been used rather than a full include.


Diffs (updated)
-

  src/arch/alpha/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/interrupts.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/remote_gdb.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/isa_traits.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/pagetable.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/pseudo_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/tlb.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/tlb.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/utility.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/utility.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/base/bitfield.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/base/bitunion.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/base/time.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/base/vnc/vncinput.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/minor/buffers.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/InvalidateGenerator.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/RubyDirectedTester.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/rubytest/CheckTable.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/flash_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/mc146818.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/net/dist_iface.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/net/etherbus.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/net/etherswitch.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/linux/linux.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/linux/linux.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/cache/prefetch/stride.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/external_master.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/external_slave.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/mem_checker.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/multi_level_page_table.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/multi_level_page_table_impl.hh 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/page_table.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/page_table.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/MessageBuffer.hh 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/AbstractReplacementPolicy.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/se_translating_port_proxy.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/simple_mem.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/python/swig/pyevent.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/arguments.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/arguments.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/byteswap.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/clock_domain.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/clocked_object.hh 

Re: [gem5-dev] Review Request 3660: style: [patch 1/~22] use /r/3648/ to reorganize includes

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/
---

(Updated Oct. 17, 2016, 3:03 p.m.)


Review request for Default.


Summary (updated)
-

style: [patch 1/~22] use /r/3648/ to reorganize includes


Repository: gem5


Description (updated)
---

Changeset 11689:36fcc24cd120
---
style: [patch 1/~22] use /r/3648/ to reorganize includes


Diffs (updated)
-

  src/mem/ruby/network/Network.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/Topology.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/PerfectSwitch.hh 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/PerfectSwitch.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/SimpleNetwork.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/Switch.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/Throttle.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/profiler/AccessTraceForAddress.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/profiler/AddressProfiler.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/profiler/StoreTrace.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/slicc_interface/AbstractController.hh 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/slicc_interface/AbstractController.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/slicc_interface/RubyRequest.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/BankedArray.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/CacheMemory.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/DirectoryMemory.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/LRUPolicy.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/Prefetcher.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/PseudoLRUPolicy.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/RubyMemoryControl.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/WireBuffer.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/system/CacheRecorder.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/system/DMASequencer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/system/RubyPort.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/system/Sequencer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/se_translating_port_proxy.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/serial_link.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/simple_mem.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/slicc/symbols/StateMachine.py 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/snoop_filter.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/tport.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/xbar.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/proto/protoio.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/python/swig/pyevent.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/python/swig/pyevent.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/python/swig/pyobject.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/arguments.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/backtrace_glibc.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/clock_domain.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/core.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/cxx_manager.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/debug.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/dvfs_handler.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/init.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/probe/probe.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/pseudo_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/py_interact.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/root.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/serialize.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/sim_events.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/sim_object.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/simulate.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/stat_control.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/stat_control.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/sub_system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/voltage_domain.cc 

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

[Potter, Brandon]

Well, it's good that someone else has similar feelings, but I feel that Alpha 
is more of a drag on development than Power or MIPS. I've run into several 
issues where I'd like to change a system call to be templated to give it more 
functionality and then I run into the issue of needing to a) keep the old 
non-templated version around for operating system where I cannot figure out the 
flags; b) search in dark places on the internet for said flags; c) make up 
values for said flags to make the compiler stop complaining. I haven't done c) 
yet with anything other than hacks, but it seems more and more appealing. At 
least with Linux, I can pull up the source, examine it, and try to reason about 
what the values for flags will be even if I can't run test programs to verify.

I don't know how anyone could actually use Tru64 or Alpha for research; one 
eventually needs to compile new applications and that seems like it would 
require a machine with the Alpha ISA (and Tru64). Cross compiling especially 
for older architectures is a headache so I'm at a loss as to why anyone would 
want to even bother with it.

-Brandon

-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason Lowe-Power
Sent: Monday, October 17, 2016 9:34 AM
To: gem5 Developer List 
Subject: Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

Hi Brandon,

We've had this discussion before. See this thread:
http://www.mail-archive.com/gem5-dev@gem5.org/msg19380.html

In summary... I think we're planning on phasing out ALPHA, but that won't 
happen in the very short term (weeks), but may happen in the medium term 
(months).

Cheers,
Jason

On Mon, Oct 17, 2016 at 9:28 AM Potter, Brandon 
wrote:

> Switching this over to the dev mailing list since it seems more 
> suitable (and I don’t have a user account; need to rectify that at some 
> point).
>
> -Brandon
>
> From: Potter, Brandon
> Sent: Monday, October 17, 2016 9:25 AM
> To: 'Andreas Hansson' ; gem5 users mailing 
> list < gem5-us...@gem5.org>
> Subject: RE: [gem5-users] scons build error for Garnet 2.0
>
> Yes, I can fix it, but it’s difficult to know what values are for Tru64.
>
> Can we deprecate Alpha already?  It looks like the last commercial 
> product that came out with Alpha was in 2007, almost a decade ago. I 
> don’t think that I know anyone personally who uses a 10 year old 
> computer.  I don’t think that I’ve ever used an Alpha either to boot; 
> wondering why I need to go out of my way to try to support it.
>
> Does anyone use Alpha outside of running our regressions?
>
> -Brandon
>
> From: Andreas Hansson [mailto:andreas.hans...@arm.com]
> Sent: Monday, October 17, 2016 3:29 AM
> To: gem5 users mailing list >
> Cc: Potter, Brandon 
>  >>
> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>
> My bad, this is properly broken for ALPHA and tru64.
>
> In fact this was broken as part of:
>
> changeset:   11383:5ac090acd180
> user:Brandon Potter >
> date:Thu Mar 17 10:24:17 2016 -0700
> summary: syscall_emul: extend mmap system call to support file backed
> mmap
>
> It was later fixed for Linux, but not tru64 it appears.
>
> Brandon, could you get this resolved?
>
> Thanks,
>
> Andreas
>
> From: gem5-users > on behalf of Andreas Hansson < 
> andreas.hans...@arm.com>
> Reply-To: gem5 users mailing list >
> Date: Monday, 17 October 2016 at 08:54
> To: gem5 users mailing list >
> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>
> Just use clang (i.e. the default OSX compiler).
>
> Andreas
>
> From: gem5-users > on behalf of "F. A. Faisal" < 
> dipu.7...@gmail.com>
> Reply-To: gem5 users mailing list >
> Date: Saturday, 15 October 2016 at 14:22
> To: gem5 users mailing list >
> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>
>
> I tried with another gcc, but the result is the same...
>
>
>
> $ port select --set gccmp-gcc49
>
>
>
> $ port select --list gcc
>
> Warning: port definitions are more than two weeks old, consider 
> updating them by running 'port selfupdate'.
>
> Available versions for gcc:
>
> apple-gcc42
>
> mp-gcc47
>
> mp-gcc49 (active)
>
> none
>
>
>
> $ scons build/ALPHA_MOESI_hammer/gem5.debug
>
> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:82:21: error:
> 'MAP_LOCKED' was not declared in this scope
>
>{ TGT_MAP_LOCKED, MAP_LOCKED },
>
>  ^
>
> 

Re: [gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

[Brandon Potter]

> On Oct. 17, 2016, 2:15 p.m., Jason Lowe-Power wrote:
> > With this patch, if you run multiple processes in SE mode they all have the 
> > same PID (100) by default. Will this cause issues? I haven't tested a 
> > pthreads application, but that seems like it might cause problems.
> > 
> > Would you just suggest that we make sure to assign different PIDs in the 
> > Python config file (where we create the Process object) to get around this 
> > issue? If so, we should have a fatal if there are multiple Processes with 
> > the same PID.

I have another patch that I haven't posted yet that used to rely on the 
incrementing PID that I deleted here. I haven't figured out how I want to 
address the issue yet. The two obvious ways are to make the changes in Python 
or make the changes in C++ and use the counter to increment the value when new 
Process classes are created. I think that I might have to use the incrementing 
version with clone and I might add that functionality back in with C++, but 
I'll increment the _pid field that you see here in this patch rather than 
having nextPID, M5_pid, and _pid. We don't need several versions of the same 
thing to make it work.


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3670/#review8858
---


On Oct. 17, 2016, 1:06 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3670/
> ---
> 
> (Updated Oct. 17, 2016, 1:06 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11692:b3d8b57ab6a7
> ---
> syscall_emul: remove redundant M5_pid field from process class
> 
> 
> Diffs
> -
> 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

[Jason Lowe-Power]

> On Oct. 17, 2016, 2:15 p.m., Jason Lowe-Power wrote:
> > With this patch, if you run multiple processes in SE mode they all have the 
> > same PID (100) by default. Will this cause issues? I haven't tested a 
> > pthreads application, but that seems like it might cause problems.
> > 
> > Would you just suggest that we make sure to assign different PIDs in the 
> > Python config file (where we create the Process object) to get around this 
> > issue? If so, we should have a fatal if there are multiple Processes with 
> > the same PID.
> 
> Brandon Potter wrote:
> I have another patch that I haven't posted yet that used to rely on the 
> incrementing PID that I deleted here. I haven't figured out how I want to 
> address the issue yet. The two obvious ways are to make the changes in Python 
> or make the changes in C++ and use the counter to increment the value when 
> new Process classes are created. I think that I might have to use the 
> incrementing version with clone and I might add that functionality back in 
> with C++, but I'll increment the _pid field that you see here in this patch 
> rather than having nextPID, M5_pid, and _pid. We don't need several versions 
> of the same thing to make it work.

One option from the Python side is to use a static class variable in Process.py 
to automatically assign it. I think there's an example of this in 
configs/topologies/Cluster.py (and other places, too).


- Jason


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3670/#review8858
---


On Oct. 17, 2016, 1:06 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3670/
> ---
> 
> (Updated Oct. 17, 2016, 1:06 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11692:b3d8b57ab6a7
> ---
> syscall_emul: remove redundant M5_pid field from process class
> 
> 
> Diffs
> -
> 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

[Jason Lowe-Power]

Hi Brandon,

We've had this discussion before. See this thread:
http://www.mail-archive.com/gem5-dev@gem5.org/msg19380.html

In summary... I think we're planning on phasing out ALPHA, but that won't
happen in the very short term (weeks), but may happen in the medium term
(months).

Cheers,
Jason

On Mon, Oct 17, 2016 at 9:28 AM Potter, Brandon 
wrote:

> Switching this over to the dev mailing list since it seems more suitable
> (and I don’t have a user account; need to rectify that at some point).
>
> -Brandon
>
> From: Potter, Brandon
> Sent: Monday, October 17, 2016 9:25 AM
> To: 'Andreas Hansson' ; gem5 users mailing list <
> gem5-us...@gem5.org>
> Subject: RE: [gem5-users] scons build error for Garnet 2.0
>
> Yes, I can fix it, but it’s difficult to know what values are for Tru64.
>
> Can we deprecate Alpha already?  It looks like the last commercial product
> that came out with Alpha was in 2007, almost a decade ago. I don’t think
> that I know anyone personally who uses a 10 year old computer.  I don’t
> think that I’ve ever used an Alpha either to boot; wondering why I need to
> go out of my way to try to support it.
>
> Does anyone use Alpha outside of running our regressions?
>
> -Brandon
>
> From: Andreas Hansson [mailto:andreas.hans...@arm.com]
> Sent: Monday, October 17, 2016 3:29 AM
> To: gem5 users mailing list >
> Cc: Potter, Brandon  >>
> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>
> My bad, this is properly broken for ALPHA and tru64.
>
> In fact this was broken as part of:
>
> changeset:   11383:5ac090acd180
> user:Brandon Potter >
> date:Thu Mar 17 10:24:17 2016 -0700
> summary: syscall_emul: extend mmap system call to support file backed
> mmap
>
> It was later fixed for Linux, but not tru64 it appears.
>
> Brandon, could you get this resolved?
>
> Thanks,
>
> Andreas
>
> From: gem5-users > on behalf of Andreas Hansson <
> andreas.hans...@arm.com>
> Reply-To: gem5 users mailing list >
> Date: Monday, 17 October 2016 at 08:54
> To: gem5 users mailing list >
> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>
> Just use clang (i.e. the default OSX compiler).
>
> Andreas
>
> From: gem5-users > on behalf of "F. A. Faisal" <
> dipu.7...@gmail.com>
> Reply-To: gem5 users mailing list >
> Date: Saturday, 15 October 2016 at 14:22
> To: gem5 users mailing list >
> Subject: Re: [gem5-users] scons build error for Garnet 2.0
>
>
> I tried with another gcc, but the result is the same...
>
>
>
> $ port select --set gccmp-gcc49
>
>
>
> $ port select --list gcc
>
> Warning: port definitions are more than two weeks old, consider updating
> them by running 'port selfupdate'.
>
> Available versions for gcc:
>
> apple-gcc42
>
> mp-gcc47
>
> mp-gcc49 (active)
>
> none
>
>
>
> $ scons build/ALPHA_MOESI_hammer/gem5.debug
>
> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:82:21: error:
> 'MAP_LOCKED' was not declared in this scope
>
>{ TGT_MAP_LOCKED, MAP_LOCKED },
>
>  ^
>
> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:83:23: error:
> 'MAP_NONBLOCK' was not declared in this scope
>
>{ TGT_MAP_NONBLOCK, MAP_NONBLOCK },
>
>^
>
> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:85:23: error:
> 'MAP_POPULATE' was not declared in this scope
>
>{ TGT_MAP_POPULATE, MAP_POPULATE },
>
>^
>
> build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.cc:86:20: error:
> 'MAP_STACK' was not declared in this scope
>
>{ TGT_MAP_STACK, MAP_STACK },
>
> ^
>
> scons: *** [build/ALPHA_MOESI_hammer/arch/alpha/tru64/tru64.do] Error 1
>
> scons: building terminated because of errors.
>
>
>
> Thanks...
>
>
> On Sat, Oct 15, 2016 at 10:06 PM, Abdul Mutaal  > wrote:
>
> Try with >=4.5
>
> On Oct 15, 2016 2:56 PM, "F. A. Faisal" > wrote:
>
> $ g++ -v
>
> Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr
> --with-gxx-include-dir=/usr/include/c++/4.2.1
>
> Apple LLVM version 7.3.0 (clang-703.0.29)
>
> Target: x86_64-apple-darwin15.4.0
>
> Thread model: posix
>
> On Sat, Oct 15, 2016 at 9:53 PM, Abdul Mutaal  > wrote:
> C++ version ?
>
> Thanks
>
> On Sat, Oct 15, 2016 at 2:01 PM, F. A. Faisal > wrote:
> Dear All,
>
> I found the below errors while 

Re: [gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3670/#review8858
---


With this patch, if you run multiple processes in SE mode they all have the 
same PID (100) by default. Will this cause issues? I haven't tested a pthreads 
application, but that seems like it might cause problems.

Would you just suggest that we make sure to assign different PIDs in the Python 
config file (where we create the Process object) to get around this issue? If 
so, we should have a fatal if there are multiple Processes with the same PID.

- Jason Lowe-Power


On Oct. 17, 2016, 1:06 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3670/
> ---
> 
> (Updated Oct. 17, 2016, 1:06 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11692:b3d8b57ab6a7
> ---
> syscall_emul: remove redundant M5_pid field from process class
> 
> 
> Diffs
> -
> 
>   src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3669: arm, config: [2/2] added support for ex5 model of big.LITTLE

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3669/#review8857
---


No diff uploaded?

- Jason Lowe-Power


On Oct. 17, 2016, 3:32 a.m., Anastasiia Butko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3669/
> ---
> 
> (Updated Oct. 17, 2016, 3:32 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11672:efd0d0343ee9
> ---
> arm, config: [2/2] added support for ex5 model of big.LITTLE
> 
> This patch enables using calibrated big and LITTLE
> cores, ex5_big and ex5_LITTLE instead of the default
> 'arm_detailed' and 'minor' cpus. The ex5 model is based
> on the Samsung Exynos 5 Octa (5422) SoC. Operation and
> memory hierarchy latencies have been calibrated using the
> lmbench micro-benchmark suite (lat_ops and lat_mem_rd).
> NOTE: appropriate dtb files are required to support the big.LITTLE_fs device 
> tree. 
> 
> lat_ops bench results:
> --
>big  LITTLE
> ops   SoC gem5SoC gem5
> --
> integer   bit:0.5 0.480.720.7
> integer   add:0.5 0.550.720.4
> integer   mul:1.561.682.161.87
> integer   div:45.36   36.32   53.347.32
> integer   mod:6.5618.55   17.37   18.02
> int64 bit:0.510.981.451.42
> uint64add:0.630.981.560.93
> int64 mul:2.522.133.644.68
> int64 div:92.61   195.52  213.14  197.63
> int64 mod:47.91   146.78  135.41  138.91
> float add:2.522.712.882.61
> float mul:3.022.842.882.73
> float div:9.078.9412.98   2.82
> doubleadd:2.522.712.882.61
> doublemul:3.022.845.042.73
> doublediv:16.13   10.43   23.03   2.81
> 
> lat_mem_rd bench results:
> --
>  bigLITTLE
> cache mem SoC gem5SoC gem5
> --
> l1/l1 0.5K4   4   3   3
>   1K  4   4   3   3
>   2K  4   4   3   3
>   3K  4   4   3   3
>   4K  4   4   3   3
>   6K  4   4   3   3
>   8K  4   4   3   3
>   12K 4   4   3   3
>   16K 4   18  3   3
>   24K 13  17  3   3
>   32K 18  18  6   11
> l2/l2 48K 23  20  9   14
>   64K 22  23  11  14
>   96K 23  23  13  14
>   128K23  23  14  15
>   192K23  23  15  17
>   256K23  23  17  17
>   384K23  24  29  17
>   512K23  24  59  39
> l2/Mem768K23  24  86  97
>   1M  23  24  112 110
>   1.5M35  25  153 147
>   2M  81  56  165 172
> Mem/Mem   3M  167 162 170 179
>   4M  217 213 171 182
>   6M  251 247 171 182
>   8M  260 257 171 182
>   12M 263 261 171 182
>   16M 265 261 171 182
> 
> Reported-by: Anastasiia Butko 
> 
> 
> Diffs
> -
> 
> 
> Diff: http://reviews.gem5.org/r/3669/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anastasiia Butko
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3666: arm, config: [1/2] added support for ex5 model of big.LITTLE

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3666/#review8856
---


The diff doesn't apply correctly. Could you fix and re-upload?

- Jason Lowe-Power


On Oct. 17, 2016, 2:21 a.m., Anastasiia Butko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3666/
> ---
> 
> (Updated Oct. 17, 2016, 2:21 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11671:11597c9e6f31
> ---
> arm, config: [1/2] added support for ex5 model of big.LITTLE
> 
> This patch enables using calibrated big and LITTLE cores, ex5_big and 
> ex5_LITTLE instead of the default
> 'arm_detailed' and 'minor' cpus. The ex5 model is based on the Samsung Exynos 
> 5 Octa (5422) SoC. Operation and
> memory hierarchy latencies have been calibrated using the lmbench 
> micro-benchmark suite. The preliminary validation
> results have been published as: 'Full-System Simulation of big.LITTLE 
> Multicore Architecture
> for Performance and Energy Exploration', in International Symposium on 
> Embedded Multicore/Many-core Systems-on-Chip
> (MCSoC'16), Lyon, France (Sep, 2016).
> 
> Reported-by: Anastasiia Butko 
> 
> 
> Diffs
> -
> 
>   configs/common/CpuConfig.py b33e4c1cf21c 
>   configs/example/arm/fs_bigLITTLE.py b33e4c1cf21c 
> 
> Diff: http://reviews.gem5.org/r/3666/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anastasiia Butko
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3665/#review8855
---

Ship it!


One small thing and a comment below.


configs/example/arm/fs_bigLITTLE.py (line 143)


There's no change needed here. However, this is a potential problem in the 
future. We're basically re-creating the options that are in 
configs/common/Option.py:addCommonOptions(). I don't think there is a simple 
solution to this right now, but we need to think about a fix for this in the 
future.



configs/example/arm/fs_bigLITTLE.py (line 157)


Triple quotes aren't necessary here.


- Jason Lowe-Power


On Oct. 17, 2016, 2:19 a.m., Anastasiia Butko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3665/
> ---
> 
> (Updated Oct. 17, 2016, 2:19 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11670:b33e4c1cf21c
> ---
> arm, config: Enabled MemConfig usage for the example big.LITTLE
> 
> This patch replaces the SimpleMemory with the MemConfig function. Additional 
> parser arguments are added
> (TODO: improve with addCommonOptions & addFSOptions).
> 
> Reported-by: Anastasiia Butko 
> 
> 
> Diffs
> -
> 
>   configs/example/arm/fs_bigLITTLE.py 220fa4099b9a 
> 
> Diff: http://reviews.gem5.org/r/3665/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anastasiia Butko
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3675: syscall_emul: remove unused global variable (num_processes)

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3675/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11697:6cea7986bd7e
---
syscall_emul: remove unused global variable (num_processes)


Diffs
-

  src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3675/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3670/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11692:b3d8b57ab6a7
---
syscall_emul: remove redundant M5_pid field from process class


Diffs
-

  src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3670/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3662: syscall_emul: move SyscallDesc into its own .hh and .cc files

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3662/
---

(Updated Oct. 17, 2016, 12:49 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11690:6520221e2308
---
syscall_emul: move SyscallDesc into its own .hh and .cc files

The class was crammed into syscall_emul.hh which has tons of forward
declarations and template definitions. To clean it up a bit, moved the
class into separate files and commented the class with doxygen style
comments. Also, provided some encapsulation by adding some accessors and
a mutator.

The syscallreturn.hh file was renamed syscall_return.hh to make it consistent
with other similarly named files in the src/sim directory.

The DPRINTF_SYSCALL macro was moved into its own header file with the
include the Base and Verbose flags as well.


Diffs (updated)
-

  src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/freebsd/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/mips/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/linux/syscalls.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/sparc/solaris/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_debug_macros.hh PRE-CREATION 
  src/sim/syscall_desc.hh PRE-CREATION 
  src/sim/syscall_desc.cc PRE-CREATION 
  src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscallreturn.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3662/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

[Andreas Sandberg]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3665/#review8853
---


Thanks for submitting this! The change looks good other than a coupld of 
redundant imports.


configs/example/arm/fs_bigLITTLE.py (lines 55 - 57)


These two imports aren't needed.


- Andreas Sandberg


On Oct. 17, 2016, 3:19 a.m., Anastasiia Butko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3665/
> ---
> 
> (Updated Oct. 17, 2016, 3:19 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11670:b33e4c1cf21c
> ---
> arm, config: Enabled MemConfig usage for the example big.LITTLE
> 
> This patch replaces the SimpleMemory with the MemConfig function. Additional 
> parser arguments are added
> (TODO: improve with addCommonOptions & addFSOptions).
> 
> Reported-by: Anastasiia Butko 
> 
> 
> Diffs
> -
> 
>   configs/example/arm/fs_bigLITTLE.py 220fa4099b9a 
> 
> Diff: http://reviews.gem5.org/r/3665/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anastasiia Butko
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3662: syscall_emul: move SyscallDesc into its own .hh and .cc files

[Brandon Potter]

> On Oct. 11, 2016, 11:43 p.m., Tony Gutierrez wrote:
> > src/sim/syscall_desc.hh, line 66
> > 
> >
> > (void) is not necessary in c++. also this is not gem5 convention.

I tried to get the same change past Steve once and he shot me down with the 
same response. __Sigh__, I prefer my void being there (and it's completely 
legal), but I'll change it for make benefit of glorious gem5.

Another common but unnecessary habit which I see quite a bit is using "unsigned 
int" instead of just "unsigned". We'll have to crack down on those folks now 
while we're at it. :)


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3662/#review8819
---


On Oct. 11, 2016, 9:06 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3662/
> ---
> 
> (Updated Oct. 11, 2016, 9:06 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11674:30214967f119
> ---
> syscall_emul: move SyscallDesc into its own .hh and .cc files
> 
> The class was crammed into syscall_emul.hh which has tons of forward
> declarations and template definitions. To clean it up a bit, moved the
> class into separate files and commented the class with doxygen style
> comments. Also, provided some encapsulation by adding some accessors and
> a mutator.
> 
> The syscallreturn.hh file was renamed syscall_return.hh to make it consistent
> with other similarly named files in the src/sim directory.
> 
> The DPRINTF_SYSCALL macro was moved into its own header file with the
> include the Base and Verbose flags as well.
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_desc.cc PRE-CREATION 
>   src/sim/syscall_emul.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/sim/syscall_emul.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/sim/syscallreturn.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/alpha/linux/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/arm/freebsd/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/arm/linux/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/mips/linux/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/power/linux/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/sparc/linux/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/sparc/linux/syscalls.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/sparc/solaris/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/x86/linux/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/arch/x86/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/kern/tru64/tru64.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/sim/SConscript 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/sim/process.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/sim/process.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 
>   src/sim/syscall_debug_macros.hh PRE-CREATION 
>   src/sim/syscall_desc.hh PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3662/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

[Cron Daemon]

* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic: 
CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing: 
CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby: 
CHANGED!*** diff[simout]: SKIPPED
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/minor-timing: CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/o3-timing: CHANGED!
*** diff[simerr]: SKIPPED* 
build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing: CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-atomic: 
CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby: 
CHANGED!
* build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt: 
CHANGED!
* 
build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-simple:
 CHANGED!
* 
build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-two-level:
 CHANGED!
* build/ALPHA/tests/opt/quick/se/30.eon/alpha/tru64/simple-atomic: CHANGED!
* build/ALPHA/tests/opt/quick/se/50.vortex/alpha/tru64/simple-atomic: 
CHANGED!
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic: 
CHANGED!
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic-dual:
 CHANGED!
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing: 
CHANGED!
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing-dual:
 CHANGED!
* 
build/ALPHA/tests/opt/quick/fs/80.netperf-stream/alpha/linux/twosys-tsunami-simple-atomic:
 CHANGED!
* build/ALPHA/tests/opt/quick/se/70.twolf/alpha/tru64/simple-timing: 
CHANGED!
* build/ALPHA/tests/opt/quick/se/50.vortex/alpha/tru64/simple-timing: 
CHANGED!
* build/ALPHA/tests/opt/quick/se/70.twolf/alpha/tru64/simple-atomic: 
CHANGED!
* 
build/ALPHA_MOESI_hammer/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MOESI_hammer:
 CHANGED!
* 
build/ALPHA_MOESI_hammer/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_hammer:
 CHANGED!
* 
build/ALPHA_MESI_Two_Level/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MESI_Two_Level:
 CHANGED!
* 
build/ALPHA_MESI_Two_Level/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MESI_Two_Level:
 CHANGED!
* 
build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory:
 CHANGED!
* 
build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_directory:
 CHANGED!
* 
build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_token:
 CHANGED!
* 
build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_token:
 CHANGED!
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing: CHANGED!
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-atomic: CHANGED!
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/o3-timing: CHANGED!
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing-ruby: 
CHANGED!
* 
build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-simple:
 CHANGED!* 
build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-two-level:
 CHANGED!
* build/POWER/tests/opt/quick/se/00.hello/power/linux/o3-timing: CHANGED!
* build/POWER/tests/opt/quick/se/00.hello/power/linux/simple-atomic: 
CHANGED!
* build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-atomic: 
CHANGED!
* build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-timing: 
CHANGED!
* build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-timing-ruby: 
CHANGED!
* build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/o3-timing: CHANGED!
*** gem5: OK* 
build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/simple-atomic: CHANGED!
* build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/simple-timing: 
CHANGED!
* 
build/SPARC/tests/opt/quick/se/03.learning-gem5/sparc/linux/learning-gem5-p1-simple:
 CHANGED!
* 
build/SPARC/tests/opt/quick/se/03.learning-gem5/sparc/linux/learning-gem5-p1-two-level:
 CHANGED!
* build/SPARC/tests/opt/quick/se/10.mcf/sparc/linux/simple-atomic: CHANGED!
* 
build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/o3-timing-mp:
 CHANGED!
* 
build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/simple-atomic-mp:
 CHANGED!
* 
build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/simple-timing-mp:
 CHANGED!
* build/SPARC/tests/opt/quick/se/50.vortex/sparc/linux/simple-atomic: 
CHANGED!
*