subject:"\[VOTE\] Release Apache Netbeans 11.0 \(incubating\) \[vote candidate 4\]"

One also has to see that NetBeans is an exceptionally big and complex podling!

For most other projects the existing process works really fine.

LieGrue,
strub


> Am 01.04.2019 um 11:35 schrieb Geertjan Wielenga 
> :
> 
> On Mon, Apr 1, 2019 at 11:27 AM Mark Struberg 
> wrote:
> 
>> We have also previously already checked those files and also have the
>> sources at hand afaict.
>> So they should be perfectly fine - as they have been in older NB releases
>> (where we had the question as well).
>> 
> 
> 
> I think this is the biggest problem with the incubator -- the fact that one
> constantly needs to re-litigate decisions and agreements that have already
> been made in previous releases.
> 
> Pointing to a list of issues, or a Wiki where these items are listed, is
> clearly not a solution -- the fact that we have been making use of Apache
> Rat from the very beginning and that we have a Rat exclusions file was also
> missed, a whole thread was started to bring our intransigence to the
> attention of the world was started, etc etc. So, I don't see a solution
> here and it is the IPMC vote that -- while being immensely valuable for
> being the most detailed -- that invariable causes the most confusion and
> wasting of time in re-litigating things.
> 
> So, though I'd like to bring a solution to this, I do not have one.
> 
> Gj
> 
> 
> 
> 
>> 
>> LieGrue,
>> strub
>> 
>> 
>>> Am 30.03.2019 um 07:23 schrieb Wade Chandler :
>>> 
>>> On Fri, Mar 29, 2019, 21:43 Justin Mclean 
>> wrote:
>>> 
 
 Theres are the binary inclusions that seem to contain compiled code, an
 ASF release should not include this:
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/com-example-testmodule-cluster.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-brokendepending.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending_on_new_one_engine.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-1.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-2.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-executable-permissions.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-fragment.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent-1-1.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent.nbm
 B
 
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-refresh_providers_test.nbm
 
>>> 
>>> To be clear, this is test data; not binary dependencies. Note the names
>> of
>>> those files. NetBeans has a module system, and those have nbm extensions.
>>> These nbms are made to test very specific things that can be wrong in
>>> modules. This would be like having tests for C/C++ linkers and object
>> files
>>> etc where you just want to validate the linking not rebuilding object
>> files
>>> for tests; rebuilding those every test run adds build time for no gain.
>>> Make sense, and Ok?
>>> 
>>> Thanks
>>> 
>>> Wade
>> 
>> 
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-04-01 Thread Geertjan Wielenga

On Mon, Apr 1, 2019 at 11:27 AM Mark Struberg 
wrote:

> We have also previously already checked those files and also have the
> sources at hand afaict.
> So they should be perfectly fine - as they have been in older NB releases
> (where we had the question as well).
>


I think this is the biggest problem with the incubator -- the fact that one
constantly needs to re-litigate decisions and agreements that have already
been made in previous releases.

Pointing to a list of issues, or a Wiki where these items are listed, is
clearly not a solution -- the fact that we have been making use of Apache
Rat from the very beginning and that we have a Rat exclusions file was also
missed, a whole thread was started to bring our intransigence to the
attention of the world was started, etc etc. So, I don't see a solution
here and it is the IPMC vote that -- while being immensely valuable for
being the most detailed -- that invariable causes the most confusion and
wasting of time in re-litigating things.

So, though I'd like to bring a solution to this, I do not have one.

Gj




>
> LieGrue,
> strub
>
>
> > Am 30.03.2019 um 07:23 schrieb Wade Chandler :
> >
> > On Fri, Mar 29, 2019, 21:43 Justin Mclean 
> wrote:
> >
> >>
> >> Theres are the binary inclusions that seem to contain compiled code, an
> >> ASF release should not include this:
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/com-example-testmodule-cluster.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-brokendepending.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending_on_new_one_engine.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-1.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-2.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-executable-permissions.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-fragment.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent-1-1.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent.nbm
> >>  B
> >>
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-refresh_providers_test.nbm
> >>
> >
> > To be clear, this is test data; not binary dependencies. Note the names
> of
> > those files. NetBeans has a module system, and those have nbm extensions.
> > These nbms are made to test very specific things that can be wrong in
> > modules. This would be like having tests for C/C++ linkers and object
> files
> > etc where you just want to validate the linking not rebuilding object
> files
> > for tests; rebuilding those every test run adds build time for no gain.
> > Make sense, and Ok?
> >
> > Thanks
> >
> > Wade
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Indeed, and thanks again for jumping in and pushing the review forward!
NB is such a huge codebase that it is really hard to do a full cycle review. 
So any attempt is really appreciated!

LieGrue,
strub


> Am 31.03.2019 um 10:04 schrieb Justin Mclean :
> 
> Hi,
> 
>> It has never been a practice or assumption in Apache NetBeans that all our
>> mentors vote on all our releases. We do explicitly ask our mentors to vote
>> in the podling dev list, normally at least one (in this case Ate) does,
>> while at least two of the other three tend to vote in the IPMC thread.
> 
> Your mentors know your project well and would have know some of the quicks in 
> that release, having them vote there  probably would have saved some 
> discussion. 
> 
> The incubator is trying to encourage mentor to vote on releases before they 
> come to up for an IPMC and hopefully by that time with will already have 3 +1 
> votes, but this is a recent thing.
> 
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

I started my review on the IPMC list but did also test-drive NB11 for a few 
days because I had functional issues (quirks with missing JavaFX on Fedora). 
Thus I only casted my +1 only after the vote got moved to general@a.o.
Trying to move faster in the future.

txs and LieGrue,
strub

> Am 31.03.2019 um 09:35 schrieb Justin Mclean :
> 
> Hi,
> 
>>> I will again raise the question of why the mentors failed to vote on the
>>> release. I'd like to make it a stronger suggestion that Mentors SHOULD vote
>>> on releases prior to sending the release vote to the IPMC.
>>> 
>> 
>> For the record, we have 4 mentors, two of which have voted +1 on this
>> release so far.
> 
> One voted on the IPMC list (right?). I think Graig was asking why they didn’t 
> vote on the podling dev list.
> 
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

We have also previously already checked those files and also have the sources 
at hand afaict.
So they should be perfectly fine - as they have been in older NB releases 
(where we had the question as well).

LieGrue,
strub


> Am 30.03.2019 um 07:23 schrieb Wade Chandler :
> 
> On Fri, Mar 29, 2019, 21:43 Justin Mclean  wrote:
> 
>> 
>> Theres are the binary inclusions that seem to contain compiled code, an
>> ASF release should not include this:
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/com-example-testmodule-cluster.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-brokendepending.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending_on_new_one_engine.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-1.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-2.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-executable-permissions.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-fragment.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent-1-1.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent.nbm
>>  B
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-refresh_providers_test.nbm
>> 
> 
> To be clear, this is test data; not binary dependencies. Note the names of
> those files. NetBeans has a module system, and those have nbm extensions.
> These nbms are made to test very specific things that can be wrong in
> modules. This would be like having tests for C/C++ linkers and object files
> etc where you just want to validate the linking not rebuilding object files
> for tests; rebuilding those every test run adds build time for no gain.
> Make sense, and Ok?
> 
> Thanks
> 
> Wade


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

[RESULT][VOTE] Release Apache NetBeans 11.0 (incubating) [vote candidate 4]

2019-03-31 Thread Laszlo Kishalmi


Dear all,

By Justin's leave, I'm ignoring my previous cancel thread on this vote 
and announce the results after a very eventful voting period.


I'd wished for another code drop, to address the arisen issues, though 
perfection is the greatest enemy of good enough, and I'm still 
traveling, just having some online time between two hops.


So the result is: We have 4 IPMC +1 vote, 0 0-s ans 0 -1s, the vote was 
open for more than 72 hours, meaning that we are going to release Apache 
NetBeans 11.0 (incubating) [vote candidate 4] as Apache NetBeans 11.0 
(incubating). I'm going to commence with the release procedure and 
announce the release, once I finally touch the ground later this week.


Details, +1 IPMC binding votes:

 * Ate Douma (http://people.apache.org/phonebook.html?uid=ate) (carried
over from the PPMC thread)
 * Justin Mclean (http://people.apache.org/phonebook.html?uid=jmclean)
 * Mark Struberg (http://people.apache.org/phonebook.html?uid=struberg)
 * Craig Russel (http://people.apache.org/phonebook.html?uid=clr)

P.S.:
The cat and rabbit image will be 
resolvedhttps://issues.apache.org/jira/browse/NETBEANS-1820  before the next 
release.


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [CANCELLED][VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-31 Thread Laszlo Kishalmi


Thank you Justin!

Since I'm still, traveling with little or none internet access, I'm 
going to ignore this thread and publish the result of the vote thread.


On 3/30/19 2:17 PM, Justin Mclean wrote:

Hi,

I think it was a bit hasty to cancel this vote, after as I said, a -1 vote is 
not a veto and people can change their minds and revote. If you wan to ignore 
the cancel vote please go ahead and do so.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-31 Thread Jan Lahoda

On Sun, Mar 31, 2019 at 10:08 AM Justin Mclean 
wrote:

> Hi,
>
> > The LICENSE file has a table that maps a file to its license "key" and
> the
> > license is then stored in the (top-level) "licenses" directory (in the
> > header of the table, there is a note about that: "text is in file in
> > licenses directory"). We used to put all the licenses into the LICENSE
> > file, but we were told that is confusing (as the LICENSE file gets fairly
> > huge, esp. for the convenience binary), so the licenses were put into a
> > separate directory.
>
> Yep that the recommended way i.e. add a pointer to where the license is
> located rather than the full license text when there are many licenses. I
> think you are missing a couple, give me a couple of days and I’ll come up
> with a list for you.
>

Thanks!


> > Or we can change the reference in the table in the LICENSE file to
> > read like "licenses/CDDL-1.0" instead of "CDDL-1.0”.
>
> That I think would make it clearer.
>

Ok, I think that will be easy to do.

>
> > Do you mean licenses under nbbuild/licenses and under the modules, like:
> > java/maven.embedder/external? The LICENSE file should not refer to them
> > (that only ever refers to the top-level licenses directory), so these
> > should be OK?
>
> It OK it just makes it very hard to check the release for what is bundled
> and not and what needs to go in LICENSE.
>
> >> 1.
> >>
> ./ide/css.editor/test/unit/src/org/netbeans/modules/css/editor/module/main/properties/PropertiesATest.java
> >>
> >
> > What is the problem with this file? Looking at the file, I am not sure
> > what's the problem.
>
> May of been a false positive as it contains the text:
> "/*!* Many thanks to Sorin Stefan and Nicole Sullivan!*(Refers to section
> A. Libraries) * Copyright(c) 2007,Yahoo!Inc. All rights reserved. * Code
> licensed under the BSD License:*
> http://developer.yahoo.net/yui/license.txt * version:2.2.1 */“
>

Hmm, true. Looking at the history, it does not reveal much. We might want
to simply include the license to be on the safe side (assuming we can find
it the proper version.)

Thanks,
Jan


> But it seems odd to have that in there.
>
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi,

> The LICENSE file has a table that maps a file to its license "key" and the
> license is then stored in the (top-level) "licenses" directory (in the
> header of the table, there is a note about that: "text is in file in
> licenses directory"). We used to put all the licenses into the LICENSE
> file, but we were told that is confusing (as the LICENSE file gets fairly
> huge, esp. for the convenience binary), so the licenses were put into a
> separate directory.

Yep that the recommended way i.e. add a pointer to where the license is located 
rather than the full license text when there are many licenses. I think you are 
missing a couple, give me a couple of days and I’ll come up with a list for you.

> Or we can change the reference in the table in the LICENSE file to
> read like "licenses/CDDL-1.0" instead of "CDDL-1.0”. 

That I think would make it clearer.

> Do you mean licenses under nbbuild/licenses and under the modules, like:
> java/maven.embedder/external? The LICENSE file should not refer to them
> (that only ever refers to the top-level licenses directory), so these
> should be OK?

It OK it just makes it very hard to check the release for what is bundled and 
not and what needs to go in LICENSE.

>> 1.
>> ./ide/css.editor/test/unit/src/org/netbeans/modules/css/editor/module/main/properties/PropertiesATest.java
>> 
> 
> What is the problem with this file? Looking at the file, I am not sure
> what's the problem.

May of been a false positive as it contains the text:
"/*!* Many thanks to Sorin Stefan and Nicole Sullivan!*(Refers to section A. 
Libraries) * Copyright(c) 2007,Yahoo!Inc. All rights reserved. * Code licensed 
under the BSD License:* http://developer.yahoo.net/yui/license.txt * 
version:2.2.1 */“

But it seems odd to have that in there.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi,

> It has never been a practice or assumption in Apache NetBeans that all our
> mentors vote on all our releases. We do explicitly ask our mentors to vote
> in the podling dev list, normally at least one (in this case Ate) does,
> while at least two of the other three tend to vote in the IPMC thread.

Your mentors know your project well and would have know some of the quicks in 
that release, having them vote there  probably would have saved some 
discussion. 

The incubator is trying to encourage mentor to vote on releases before they 
come to up for an IPMC and hopefully by that time with will already have 3 +1 
votes, but this is a recent thing.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-31 Thread Geertjan Wielenga

On Sun, Mar 31, 2019 at 9:36 AM Justin Mclean 
wrote:

>
> >
> > For the record, we have 4 mentors, two of which have voted +1 on this
> > release so far.
>
> One voted on the IPMC list (right?). I think Graig was asking why they
> didn’t vote on the podling dev list.
>
>
It has never been a practice or assumption in Apache NetBeans that all our
mentors vote on all our releases. We do explicitly ask our mentors to vote
in the podling dev list, normally at least one (in this case Ate) does,
while at least two of the other three tend to vote in the IPMC thread.

The above is how things have transpired, indeed it would be great to have
all mentors voting in the PPMC vote thread, we'd end up very strongly at
the start of the IPMC vote thread in that case, however I don't believe
there's any rule or requirement for that nor an expectation -- and we tend
to have dozens of +1 votes within 72 hours from our community and so we
move on from there to the IPMC thread.

All this is a bit moot at this point since as soon as this release is
completed (which I believe it now is at least in terms of voting), we'll be
discussing to leave the incubator.

Thanks for all the work and support, your reviews of our releases have
always sparked the most discussion. :-)

Gj

> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi,

> Would you please have a list? I tried this:
> java -jar ~/Downloads/apache-rat-0.12.jar . >rat
> cat rat | grep '== File:' | grep -e '\.java$' -e '\.jsp$' -e '\.php$' -e
> '\.js$' | grep -v 'test/unit/data' | grep -v 'test/qa-functional/data’

You might want to add .sh and .xml files to that list to grep for.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi,

>> I will again raise the question of why the mentors failed to vote on the
>> release. I'd like to make it a stronger suggestion that Mentors SHOULD vote
>> on releases prior to sending the release vote to the IPMC.
>> 
> 
> For the record, we have 4 mentors, two of which have voted +1 on this
> release so far.

One voted on the IPMC list (right?). I think Graig was asking why they didn’t 
vote on the podling dev list.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-31 Thread Jan Lahoda

Hi Justin,

Some more questions on the LICENSE(/NOTICE).

On Sat, Mar 30, 2019 at 2:43 AM Justin Mclean 
wrote:

> I think there some more work to do on licensing here, and these will be
> needed to be fixed in a later release:
> - You are not compiling with the terms of the licenses of the software you
> have bundled. Most licenses need for you to include the full text of the
> license and not just list it license. This is an issue with most of the dtd
> files, note that some licenses include a copyright line so a single copy of
> that type of license is not enough.
>

The LICENSE file has a table that maps a file to its license "key" and the
license is then stored in the (top-level) "licenses" directory (in the
header of the table, there is a note about that: "text is in file in
licenses directory"). We used to put all the licenses into the LICENSE
file, but we were told that is confusing (as the LICENSE file gets fairly
huge, esp. for the convenience binary), so the licenses were put into a
separate directory. We could easily place everything to the LICENSE file
again. Or we can change the reference in the table in the LICENSE file to
read like "licenses/CDDL-1.0" instead of "CDDL-1.0". Either of these should
be a fairly easy thing.

> - As well as listing  the 3rd party files it would be to also see the
> product and version number included.
> - As it is currently structured it’s not easily possible to check if you
> are including all of the needed licenses in LICENSES as you are also
> including the text of licenses of things that are not bundled but are
> dependancies, so I’m been unable to check if LICENSE and NOTICE are correct.
>

Do you mean licenses under nbbuild/licenses and under the modules, like:
java/maven.embedder/external? The LICENSE file should not refer to them
(that only ever refers to the top-level licenses directory), so these
should be OK? (We need them so that we can construct the correct LICENSE
file for the convenience binaries.)

> - A spot check show that things are bundled but not mentioned in LICENSE
> as they need to be, for example [1][2]. I would expect there to be others.
> - It also look like you are including image file that you do not have
> permission to distribute
>
> Give all of the above this release is almost impossible to check if it in
> compliance with ASF release, distribution or legal policies and some
> improvement need to be made so that it can be.
>
> Thanks,
> Justin
>
> 1.
> ./ide/css.editor/test/unit/src/org/netbeans/modules/css/editor/module/main/properties/PropertiesATest.java
>

What is the problem with this file? Looking at the file, I am not sure
what's the problem.

> 2.
> ./php/php.editor/test/unit/data/testfiles/actions/testImportData/libs/nette.min.php
>

Yes, this definitely should be included in LICENSE.

Thanks,
Jan

> 3.
> https://lists.apache.org/thread.html/2b6ad0d98a9342595da27902f25e7c43c4291738154eedc8b33afb5e@%3Cgeneral.incubator.apache.org%3E
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-31 Thread Jan Lahoda

Hi Justin,

On Sat, Mar 30, 2019 at 7:58 AM Justin Mclean 
wrote:

> HI,
>
> > I assume we are taking about files like:
> >
> https://github.com/apache/incubator-netbeans/blob/master/java/java.hints/test/unit/data/org/netbeans/test/java/hints/AddCast1.java
>
> Those are some of the files yes but there are a few not in test
> directories. Does the project use rat to look for issues? By my very rough
> count there are 5,000 +  source files without ASF headers,


Yes, we use rat. We have exclusions here:
https://github.com/apache/incubator-netbeans/blob/master/nbbuild/rat-exclusions.txt

Annotated with a reason why the given exclusion (or a set of exclustions)
is there.

(13,000+ if you include the .pass files), but only two dozen files of those
> source file are out side of test directories.
>

Would you please have a list? I tried this:
java -jar ~/Downloads/apache-rat-0.12.jar . >rat
cat rat | grep '== File:' | grep -e '\.java$' -e '\.jsp$' -e '\.php$' -e
'\.js$' | grep -v 'test/unit/data' | grep -v 'test/qa-functional/data'

And it yields the following list for me:
== File:
./enterprise/web.jsf/src/org/netbeans/modules/web/jsf/facelets/resources/templates/forward.jsp
== File:
./enterprise/web.jsf/src/org/netbeans/modules/web/jsf/resources/jsfcrud.js
== File:
./enterprise/web.primefaces/src/org/netbeans/modules/web/primefaces/templates/jsfcrud.js
== File:
./php/php.atoum/src/org/netbeans/modules/php/atoum/ui/resources/AtoumTest.php
== File:
./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/BlankLines.php
== File:
./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Braces.php
== File:
./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Spaces.php
== File:
./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/TabsIndents.php
== File:
./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Uses.php
== File:
./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Wrapping.php

With some work, these should be handlable.

Thanks,
Jan


>
> BTW  If this was the only issue I’d would have voted differently, although
> the question needs to be asked why this issue has been raised previously on
> this list and no response given?
>
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [CANCELLED][VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-31 Thread Geertjan Wielenga

Yes, we have -- after a bit of to and fro -- now 4 IPMC votes: Craig,
Justin, Ate, and Mark.

And we have the right amount of time, i.e., 72 hours.

Let's mark the items listed by Justin as blockers for the next release (the
cat picture deletion is a PR already).

I'd say there's nothing stopping us from releasing Apache NetBeans 11.0!

Gj


On Sat, Mar 30, 2019 at 10:19 PM Craig Russell  wrote:

> It appears to me that there has been some miscommunication and/or missing
> documentation of the issues raised earlier.
>
> In case it needs to be said, if the PPMC and Justin can come to an
> agreement, there is no need for another build and vote.
>
> I'd encourage the Mentors to engage with Justin to resolve these issues.
> Specifically, for each item that Justin raised, make sure there is a JIRA.
> Then work through all of the JIRA issues individually. As a community. The
> Apache Way.
>
> Craig
>
> > On Mar 30, 2019, at 2:01 PM, Justin Mclean 
> wrote:
> >
> > Hi,
> >
> >> We need to have clarity on what exactly we need to work on in relation
> to
> >> licensing -- we are definitely not going to license data files because
> (a)
> >> Apache does not require it and (2) it would break our tests, which is
> why
> >> Apache does not require it. That's the bulk of the issues raised by
> Justin.
> >
> > The missing headers are not major issue it was the other issues
> concerning binaries, copyright issues, and missing license text that are
> the concerns.
> >
> > Thanks,
> > Justin
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
>
> Craig L Russell
> c...@apache.org
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-31 Thread Geertjan Wielenga

On Sat, Mar 30, 2019 at 10:05 PM Craig Russell  wrote:

>
>
> I will again raise the question of why the mentors failed to vote on the
> release. I'd like to make it a stronger suggestion that Mentors SHOULD vote
> on releases prior to sending the release vote to the IPMC.
>

For the record, we have 4 mentors, two of which have voted +1 on this
release so far.

Gj



>
> It looks to me like the issues raised on this vote thread have been
> discussed before and resolved. The right place to resolve issues is, well,
> on JIRA.
>
> > On Mar 30, 2019, at 7:03 AM, Geertjan Wielenga
>  wrote:
> >
> > And here is the list of items specifically how we dealt with each from
> > Justin's previous list of comments with the +1 from the 10.0 IPMC vote
> > thread, in other words, we have taken his issues and concerns seriously
> and
> > discussed them and dealt with them:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/10.0-vc5 <
> https://cwiki.apache.org/confluence/display/NETBEANS/10.0-vc5>
> >
> > How much better a citizen of the Apache Way can one be than we have been
> in
> > responding and dealing with licensing concerns of all shapes and sizes.
> >
> > Gj
> >
>
> Craig L Russell
> Secretary, Apache Software Foundation
> c...@apache.org  http://db.apache.org/jdo <
> http://db.apache.org/jdo>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-30 Thread Wade Chandler

Thanks so much Justin and for your involvement.

Wade

On Sat, Mar 30, 2019, 17:21 Justin Mclean  wrote:

> Hi,
>
> Changing my vote to:
> +1 (binding)
>
> And I’m sorry for any upset my first vote caused.
>
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi,

Changing my vote to:
+1 (binding)

And I’m sorry for any upset my first vote caused.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [CANCELLED][VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-30 Thread Craig Russell

It appears to me that there has been some miscommunication and/or missing 
documentation of the issues raised earlier.

In case it needs to be said, if the PPMC and Justin can come to an agreement, 
there is no need for another build and vote. 

I'd encourage the Mentors to engage with Justin to resolve these issues. 
Specifically, for each item that Justin raised, make sure there is a JIRA. Then 
work through all of the JIRA issues individually. As a community. The Apache 
Way.

Craig

> On Mar 30, 2019, at 2:01 PM, Justin Mclean  wrote:
> 
> Hi,
> 
>> We need to have clarity on what exactly we need to work on in relation to
>> licensing -- we are definitely not going to license data files because (a)
>> Apache does not require it and (2) it would break our tests, which is why
>> Apache does not require it. That's the bulk of the issues raised by Justin.
> 
> The missing headers are not major issue it was the other issues concerning 
> binaries, copyright issues, and missing license text that are the concerns.
> 
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 

Craig L Russell
c...@apache.org

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [CANCELLED][VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi,

I think it was a bit hasty to cancel this vote, after as I said, a -1 vote is 
not a veto and people can change their minds and revote. If you wan to ignore 
the cancel vote please go ahead and do so.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-30 Thread Craig Russell

+1 (binding IPMC) to release

Downloaded release artifacts
Imported KEYS
Verified signatures and checksums
Reviewed rat exclusion list
I still want to see the cat and rabbit image resolved 
https://issues.apache.org/jira/browse/NETBEANS-1820 before the next release

Craig

P.S.

I will again raise the question of why the mentors failed to vote on the 
release. I'd like to make it a stronger suggestion that Mentors SHOULD vote on 
releases prior to sending the release vote to the IPMC.

It looks to me like the issues raised on this vote thread have been discussed 
before and resolved. The right place to resolve issues is, well, on JIRA. 

> On Mar 30, 2019, at 7:03 AM, Geertjan Wielenga 
>  wrote:
> 
> And here is the list of items specifically how we dealt with each from
> Justin's previous list of comments with the +1 from the 10.0 IPMC vote
> thread, in other words, we have taken his issues and concerns seriously and
> discussed them and dealt with them:
> 
> https://cwiki.apache.org/confluence/display/NETBEANS/10.0-vc5 
> 
> 
> How much better a citizen of the Apache Way can one be than we have been in
> responding and dealing with licensing concerns of all shapes and sizes.
> 
> Gj
> 

Craig L Russell
Secretary, Apache Software Foundation
c...@apache.org  http://db.apache.org/jdo

Re: [CANCELLED][VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi,

> We need to have clarity on what exactly we need to work on in relation to
> licensing -- we are definitely not going to license data files because (a)
> Apache does not require it and (2) it would break our tests, which is why
> Apache does not require it. That's the bulk of the issues raised by Justin.

The missing headers are not major issue it was the other issues concerning 
binaries, copyright issues, and missing license text that are the concerns.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

And here is the list of items specifically how we dealt with each from
Justin's previous list of comments with the +1 from the 10.0 IPMC vote
thread, in other words, we have taken his issues and concerns seriously and
discussed them and dealt with them:

https://cwiki.apache.org/confluence/display/NETBEANS/10.0-vc5

How much better a citizen of the Apache Way can one be than we have been in
responding and dealing with licensing concerns of all shapes and sizes.

Gj


On Sat, Mar 30, 2019 at 1:46 PM Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:

> I’m fine with retreating and getting the work done that needs to be done.
> However, before retreating we need to know exactly and specifically what we
> are agreed on that we are going to do. E.g., we are not going to license
> heaps of files that are data and that Apache explicitly for that reason
> allows us to keep unlicensed.
>
> Gj
>
>
> On Sat, 30 Mar 2019 at 13:33, Laszlo Kishalmi 
> wrote:
>
>> Thank you Justin, for the really in-depth analysis!
>>
>> I'm traveling right now with very limited internet access.
>>
>> I think, regarding that we are about to graduate soon, we need to
>> address these concerns. Retreat, and get that work done.
>>
>> I'm going to call off the vote.
>>
>> A prompt action plan:
>>
>> 1. We need to include another build step, for creating those binaries
>> form some kind of source.
>>
>> 2. The crafted parser/compiler/code completion test data shall be left
>> as it is, I do not know better solution than add their license as we do
>> with images in license-info.xml. We have many of tests placing the
>> cursor directly at a place of these input files then test an IDE action
>> (that's just an example)
>>
>> 3. I think we need further guidance what to do with 3rd party licenses
>> which are refering to libraries which are not present in the source
>> distribution but pulled in build time. We obviously need to include
>> those into the convenience binaries.
>>
>> Laszlo Kishalmi
>>
>> On 3/29/19 6:43 PM, Justin Mclean wrote:
>> > Hi,
>> >
>> > Sorry but I’m -1 as there is binary code in the source release and
>> possible copyright issues and there are a number of other issues as well.
>> Most of these issues have been brought up before on previous releases and
>> have not been addressed e.g. [3] While each incubating release doesn’t need
>> to be perfect, issues found, particularly serious ones, do need to be
>> fixed. I suggest you speak to your mentors on how to correct this issues.
>> >
>> > I will not however that my -1 vote is not a veto, and you can still
>> release the software if you get 3 +1 IPMC votes and more +1’s than -1’s.
>> >
>> > I checked:
>> > - incubating in name
>> > - DISCLAIMER exists
>> > - LICENSE and NOTICE need more work (see below)
>> > - There are a number (100’s) of source files that do not have ASF
>> headers, Please run rat and please add headers to .java, .jsp and .php
>> files that are missing the ASF headers.
>> > - Compiled code is included in the source release  (see below)
>> > - I didn’t try to compile
>> >
>> > Theres are the binary inclusions that seem to contain compiled code, an
>> ASF release should not include this:
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/com-example-testmodule-cluster.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-brokendepending.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending_on_new_one_engine.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-1.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-2.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-executable-permissions.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-fragment.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent-1-1.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent.nbm
>> >B
>>  
>> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-refresh_providers_test.nbm
>> >
>> > There are a number of other suspicious binary files as well, include
>> one mentioned in [3].
>> >
>> > I think there some more work to do on licensing here, and these will be
>> needed to be fixed in a later

Re: [CANCELLED][VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

We need to have clarity on what exactly we need to work on in relation to
licensing -- we are definitely not going to license data files because (a)
Apache does not require it and (2) it would break our tests, which is why
Apache does not require it. That's the bulk of the issues raised by Justin.
We need to have clarity from him, at least, about what we actually need to
achieve otherwise there's no point trying to do another vote which will
fail again for the same questionable reasons.

On Sat, Mar 30, 2019 at 1:58 PM Laszlo Kishalmi 
wrote:

> Dear all,
>
> It seems we need to have some heavy lifting on the licensing side, so I'm
> canceling this vote.
>
> Laszlo Kishalmi
> Volunteer Release Manager of Apache NetBeans 11.0
>
>

[CANCELLED][VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-30 Thread Laszlo Kishalmi


Dear all,

It seems we need to have some heavy lifting on the licensing side, so I'm 
canceling this vote.

Laszlo Kishalmi
Volunteer Release Manager of Apache NetBeans 11.0

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

I’m fine with retreating and getting the work done that needs to be done.
However, before retreating we need to know exactly and specifically what we
are agreed on that we are going to do. E.g., we are not going to license
heaps of files that are data and that Apache explicitly for that reason
allows us to keep unlicensed.

Gj


On Sat, 30 Mar 2019 at 13:33, Laszlo Kishalmi 
wrote:

> Thank you Justin, for the really in-depth analysis!
>
> I'm traveling right now with very limited internet access.
>
> I think, regarding that we are about to graduate soon, we need to
> address these concerns. Retreat, and get that work done.
>
> I'm going to call off the vote.
>
> A prompt action plan:
>
> 1. We need to include another build step, for creating those binaries
> form some kind of source.
>
> 2. The crafted parser/compiler/code completion test data shall be left
> as it is, I do not know better solution than add their license as we do
> with images in license-info.xml. We have many of tests placing the
> cursor directly at a place of these input files then test an IDE action
> (that's just an example)
>
> 3. I think we need further guidance what to do with 3rd party licenses
> which are refering to libraries which are not present in the source
> distribution but pulled in build time. We obviously need to include
> those into the convenience binaries.
>
> Laszlo Kishalmi
>
> On 3/29/19 6:43 PM, Justin Mclean wrote:
> > Hi,
> >
> > Sorry but I’m -1 as there is binary code in the source release and
> possible copyright issues and there are a number of other issues as well.
> Most of these issues have been brought up before on previous releases and
> have not been addressed e.g. [3] While each incubating release doesn’t need
> to be perfect, issues found, particularly serious ones, do need to be
> fixed. I suggest you speak to your mentors on how to correct this issues.
> >
> > I will not however that my -1 vote is not a veto, and you can still
> release the software if you get 3 +1 IPMC votes and more +1’s than -1’s.
> >
> > I checked:
> > - incubating in name
> > - DISCLAIMER exists
> > - LICENSE and NOTICE need more work (see below)
> > - There are a number (100’s) of source files that do not have ASF
> headers, Please run rat and please add headers to .java, .jsp and .php
> files that are missing the ASF headers.
> > - Compiled code is included in the source release  (see below)
> > - I didn’t try to compile
> >
> > Theres are the binary inclusions that seem to contain compiled code, an
> ASF release should not include this:
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/com-example-testmodule-cluster.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-brokendepending.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending_on_new_one_engine.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-1.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-2.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-executable-permissions.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-fragment.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent-1-1.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent.nbm
> >B
>  
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-refresh_providers_test.nbm
> >
> > There are a number of other suspicious binary files as well, include one
> mentioned in [3].
> >
> > I think there some more work to do on licensing here, and these will be
> needed to be fixed in a later release:
> > - You are not compiling with the terms of the licenses of the software
> you have bundled. Most licenses need for you to include the full text of
> the license and not just list it license. This is an issue with most of the
> dtd files, note that some licenses include a copyright line so a single
> copy of that type of license is not enough.
> > - As well as listing  the 3rd party files it would be to also see the
> product and version number included.
> > - As it is currently structured it’s not easily possible to check if you
> are including all of the needed licenses in LICENSES as you are also
> including the text of licenses of things that are not bundled

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

2019-03-30 Thread Laszlo Kishalmi

Thank you Justin, for the really in-depth analysis!

I'm traveling right now with very limited internet access.

I think, regarding that we are about to graduate soon, we need to
address these concerns. Retreat, and get that work done.

I'm going to call off the vote.

A prompt action plan:

1. We need to include another build step, for creating those binaries
form some kind of source.

2. The crafted parser/compiler/code completion test data shall be left
as it is, I do not know better solution than add their license as we do
with images in license-info.xml. We have many of tests placing the
cursor directly at a place of these input files then test an IDE action
(that's just an example)

3. I think we need further guidance what to do with 3rd party licenses
which are refering to libraries which are not present in the source
distribution but pulled in build time. We obviously need to include
those into the convenience binaries.

Laszlo Kishalmi

On 3/29/19 6:43 PM, Justin Mclean wrote:

Hi,

Sorry but I’m -1 as there is binary code in the source release and possible
copyright issues and there are a number of other issues as well. Most of these
issues have been brought up before on previous releases and have not been
addressed e.g. [3] While each incubating release doesn’t need to be perfect,
issues found, particularly serious ones, do need to be fixed. I suggest you
speak to your mentors on how to correct this issues.

I will not however that my -1 vote is not a veto, and you can still release the
software if you get 3 +1 IPMC votes and more +1’s than -1’s.

I checked:
- incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE need more work (see below)
- There are a number (100’s) of source files that do not have ASF headers,
Please run rat and please add headers to .java, .jsp and .php files that are
missing the ASF headers.
- Compiled code is included in the source release (see below)
- I didn’t try to compile

Theres are the binary inclusions that seem to contain compiled code, an ASF
release should not include this:
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/com-example-testmodule-cluster.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-brokendepending.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-depending_on_new_one_engine.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-1.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine-1-2.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-engine.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-executable-permissions.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-fragment.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent-1-1.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-independent.nbm
B
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/org-yourorghere-refresh_providers_test.nbm

There are a number of other suspicious binary files as well, include one
mentioned in [3].

I think there some more work to do on licensing here, and these will be needed
to be fixed in a later release:
- You are not compiling with the terms of the licenses of the software you have
bundled. Most licenses need for you to include the full text of the license and
not just list it license. This is an issue with most of the dtd files, note
that some licenses include a copyright line so a single copy of that type of
license is not enough.
- As well as listing the 3rd party files it would be to also see the product
and version number included.
- As it is currently structured it’s not easily possible to check if you are
including all of the needed licenses in LICENSES as you are also including the
text of licenses of things that are not bundled but are dependancies, so I’m
been unable to check if LICENSE and NOTICE are correct.
- A spot check show that things are bundled but not mentioned in LICENSE as
they need to be, for example [1][2]. I would expect there to be others.
- It also look like you are including image file that you do not have
permission to distribute

Give all of the above this release is almost impossible to check if it in
compliance with ASF release, distribution or legal policies and some
improvement need to be made so that it can be.

Thanks,
Justin

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Sure, but this image thing is trivial, we should simply remove those and we
don’t care about the sample that contains them anyway. Also, again, note
that we had not ignored or dismissed your comments from the previous
release.

So, to your question whether we have a Rat report, we do have one as
pointed out in my response, as well as in the initial vote thread where
that was very explicitly stated and linked. We also have an exclusions
file, which I have pointed to explicitly and which is the same as when you
looked at it in the previous release, with items agreed upon over previous
releases.

It seems that the majority if not all items you have raised are files in
the ‘data’ category which we have excluded via Rat, an accepted approach in
accordance with Apache guidelines.

Now, what specific items remain blocking the release? Note we are as always
trying to do everything as best we can, following all requirements to the
best of our abilities, doing all we can to comply, acting in good faith,
and simply asking you to weigh up these considerations with all due respect
and hoping you will be explicit on, bearing the above in mind, which are
the true blockers from your point of view.

Thanks again,

Gj

On Sat, 30 Mar 2019 at 10:48, Justin Mclean 
wrote:

> HI,
>
> > Note also that we have worked on the items that you mentioned in the
> > previous release, e.g.:
> >
> > https://issues.apache.org/jira/browse/NETBEANS-1820
> >
> > But if you disagree with the above, no prob, we can simply delete those
> > images or replace them with something or remove the whole sample -- it
> uses
> > outdated code anyway.
>
> If you want to keep them I suggest you ask on legal discuss and when doing
> so, point them to this web site [1]. Just becomes they were in the donation
> don’t mean that they don’t have IP issues.
>
> Thanks,
> Justin
>
>
> 1. https://www.warrenphotographic.co.uk/10542-kitten-and-rabbit
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

HI,

> Note also that we have worked on the items that you mentioned in the
> previous release, e.g.:
> 
> https://issues.apache.org/jira/browse/NETBEANS-1820
> 
> But if you disagree with the above, no prob, we can simply delete those
> images or replace them with something or remove the whole sample -- it uses
> outdated code anyway.

If you want to keep them I suggest you ask on legal discuss and when doing so, 
point them to this web site [1]. Just becomes they were in the donation don’t 
mean that they don’t have IP issues.

Thanks,
Justin


1. https://www.warrenphotographic.co.uk/10542-kitten-and-rabbit
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi Justin,

Note also that we have worked on the items that you mentioned in the
previous release, e.g.:

https://issues.apache.org/jira/browse/NETBEANS-1820

But if you disagree with the above, no prob, we can simply delete those
images or replace them with something or remove the whole sample -- it uses
outdated code anyway.

Based on the above responses is there a chance you could change your vote
to 0 or +1, i.e., what would be needed for you to do that -- we do value
your vote and would of course prefer to not continue with the release while
it remains -1.

Gj

On Sat, Mar 30, 2019 at 9:37 AM Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:

> Hi Justin,
>
> Note also that we have worked on the items that you mentioned in the
> previous release, e.g.:
>
>
> On Sat, Mar 30, 2019 at 8:24 AM Geertjan Wielenga <
> geertjan.wiele...@googlemail.com> wrote:
>
>> We have spent a lot of time on that, documenting them in detail:
>>
>>
>> https://github.com/apache/incubator-netbeans/blob/master/nbbuild/rat-exclusions.txt
>>
>> Gj
>>
>> On Sat, 30 Mar 2019 at 08:16, Justin Mclean 
>> wrote:
>>
>>> Hi,
>>>
>>> >
>>> https://builds.apache.org/job/incubator-netbeans-release/404/artifact/rat-release-temp/nbbuild/build/rat-report.txt
>>>
>>> You may want to check that your rat excursions are not ignoring too
>>> much, that can be a common problem.
>>>
>>> Thanks,
>>> Justin
>>> -
>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>>> For additional commands, e-mail: general-h...@incubator.apache.org
>>>
>>>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi Justin,

Note also that we have worked on the items that you mentioned in the
previous release, e.g.:


On Sat, Mar 30, 2019 at 8:24 AM Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:

> We have spent a lot of time on that, documenting them in detail:
>
>
> https://github.com/apache/incubator-netbeans/blob/master/nbbuild/rat-exclusions.txt
>
> Gj
>
> On Sat, 30 Mar 2019 at 08:16, Justin Mclean 
> wrote:
>
>> Hi,
>>
>> >
>> https://builds.apache.org/job/incubator-netbeans-release/404/artifact/rat-release-temp/nbbuild/build/rat-report.txt
>>
>> You may want to check that your rat excursions are not ignoring too much,
>> that can be a common problem.
>>
>> Thanks,
>> Justin
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>>
>>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

We have spent a lot of time on that, documenting them in detail:

https://github.com/apache/incubator-netbeans/blob/master/nbbuild/rat-exclusions.txt

Gj

On Sat, 30 Mar 2019 at 08:16, Justin Mclean 
wrote:

> Hi,
>
> >
> https://builds.apache.org/job/incubator-netbeans-release/404/artifact/rat-release-temp/nbbuild/build/rat-report.txt
>
> You may want to check that your rat excursions are not ignoring too much,
> that can be a common problem.
>
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

Hi,

> https://builds.apache.org/job/incubator-netbeans-release/404/artifact/rat-release-temp/nbbuild/build/rat-report.txt

You may want to check that your rat excursions are not ignoring too much, that 
can be a common problem.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

https://builds.apache.org/job/incubator-netbeans-release/404/artifact/rat-release-temp/nbbuild/build/rat-report.txt

Gj

On Sat, 30 Mar 2019 at 07:58, Justin Mclean 
wrote:

> HI,
>
> > I assume we are taking about files like:
> >
> https://github.com/apache/incubator-netbeans/blob/master/java/java.hints/test/unit/data/org/netbeans/test/java/hints/AddCast1.java
>
> Those are some of the files yes but there are a few not in test
> directories. Does the project use rat to look for issues? By my very rough
> count there are 5,000 +  source files without ASF headers, (13,000+ if you
> include the .pass files), but only two dozen files of those source file are
> out side of test directories.
>
> BTW  If this was the only issue I’d would have voted differently, although
> the question needs to be asked why this issue has been raised previously on
> this list and no response given?
>
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]

HI,

> I assume we are taking about files like:
> https://github.com/apache/incubator-netbeans/blob/master/java/java.hints/test/unit/data/org/netbeans/test/java/hints/AddCast1.java

Those are some of the files yes but there are a few not in test directories. 
Does the project use rat to look for issues? By my very rough count there are 
5,000 +  source files without ASF headers, (13,000+ if you include the .pass 
files), but only two dozen files of those source file are out side of test 
directories.

BTW  If this was the only issue I’d would have voted differently, although the 
question needs to be asked why this issue has been raised previously on this 
list and no response given?

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Netbeans 11.0 (incubating) [vote candidate 4]