On Fri, 11 Mar 2022 10:25:19 -0800
Alec Warner wrote:
> On Fri, Mar 11, 2022 at 9:14 AM Peter Stuge wrote:
> >
> > Matt Turner wrote:
> > > repoman is inferior to other tooling mentioned. The other tooling
> > > is actually run in CI.
> >
> > The problem seems to be that CI is running
On Thu, 10 Mar 2022 12:07:40 -0600
William Hubbs wrote:
> On Thu, Mar 10, 2022 at 09:29:59AM -0800, Matt Turner wrote:
> > On Wed, Mar 9, 2022 at 11:09 PM Joonas Niilola
> > wrote:
> > >
> > > On 9.3.2022 23.00, Matt Turner wrote:
> > > > I'd like to deprecate and ultimately remove repoman.
On Sat, 30 Jan 2021 04:59:32 -0800
Zac Medico wrote:
> Call os.getpid() lazily, which eliminates getpid calls when possible
> after os.fork() in the portage.process module.
>
> Bug: https://bugs.gentoo.org/767913
> Signed-off-by: Zac Medico
> ---
> lib/portage/__init__.py | 4 +++-
> 1 file
On Sat, 30 Jan 2021 03:49:41 -0800
Zac Medico wrote:
> Disable --autounmask-license by default, in order to limit user
> exposure to risks associated with package.license changes.
> The changes that this option suggests are only intended to be
> accepted when a user has made a conscious decision
On Sat, 23 Jan 2021 15:38:49 -0800
Zac Medico wrote:
> Since the emaint --fix merges uses emerge --ask, add
> a -y, --yes option to use --ask=n instead.
Looks good to me
>
> Bug: https://bugs.gentoo.org/766767
> Signed-off-by: Zac Medico
> ---
>
On Sun, 16 Aug 2020 20:26:56 -0700
Zac Medico wrote:
> Add --jobs and --load-average options which allow dependency checks
> for multiple profiles to run in parallel. The increase in performance
> is non-linear for the number of jobs, but it can be worthwhile
> (I measured a 35% decrease in time
On Sat, 15 Aug 2020 12:26:42 -0700
Zac Medico wrote:
> Add a short -l option for --load-average just like make(1) has.
>
> Bug: https://bugs.gentoo.org/699256
> Signed-off-by: Zac Medico
>
> Zac Medico (2):
> emerge: Remove deprecated --changelog option (bug 699256)
> emerge: Add short -l
On Tue, 11 Aug 2020 23:41:33 + (UTC)
"Thomas Mueller" wrote:
> > Hi, everyone.
>
> > TL;DR: we might keep Python 2.7 supported as a build-time dependency
> > of a few packages as necessary, while removing the eclass support
> > for installing packages for py2.7.
>
>
> > As I've
On Tue, 4 Aug 2020 21:56:08 -0400
Aaron Bauman wrote:
> On Tue, Aug 04, 2020 at 09:43:03PM -0400, Aaron Bauman wrote:
> > * This fixes the one instance of a trailing comma in the repo which
> > actually causes a tuple to be created.
> >
> > Signed-off-by: Aaron Bauman
> > ---
> >
On Sun, 2 Aug 2020 16:38:06 -0700
Zac Medico wrote:
> Add an egencache --update-pkg-desc-index example for users
> of app-portage/esearch to migrate to.
>
> Bug: https://bugs.gentoo.org/735626
> Signed-off-by: Zac Medico
> ---
> cnf/repo.postsync.d/example | 15 ++-
> 1 file
On Mon, 6 Jul 2020 11:42:06 -0700
Zac Medico wrote:
> It should be pretty safe to drop support for python2.7 at this point.
>
> Bug: https://bugs.gentoo.org/731114
> Signed-off-by: Zac Medico
> ---
> .travis.yml | 1 -
> tox.ini | 6 ++
> 2 files changed, 2 insertions(+), 5
On Thu, 25 Jun 2020 23:23:29 +0100
Samuel Bernardo wrote:
> Hi Brian
>
> On 6/25/20 11:18 PM, Brian Dolbec wrote:
> > You add yourself as primary maintainer. The proxy maintainers will
> > add themselves for the merge to the repo after all review is done.
> > This w
On Thu, 25 Jun 2020 23:11:29 +0100
Samuel Bernardo wrote:
> Hi,
>
> I send this email to ask for your help on selecting the project
> maintainer for a new ebuild.
>
> I created a pull request for the ebuild in subject[1] and the QA
> reports complaints about missing project maintainer[2]. What
On Fri, 19 Jun 2020 13:39:19 -0700
Zac Medico wrote:
> This variable specifies a command that filters build log output to a
> log file. The plan is to extend this to support a separate filter for
> tty output in the future.
>
> In order to enable the EbuildPhase class to write elog messages to
On Fri, 19 Jun 2020 13:39:18 -0700
Zac Medico wrote:
> Add support to write to a non-blocking pipe instead of a
> log file. This is needed for the purposes of bug 709746,
> where PipeLogger will write to a pipe that is drained
> by anoher PipeLogger instance which is running in the same
>
On Thu, 18 Jun 2020 00:35:48 -0700
Zac Medico wrote:
> In the coroutine finally clause, do not call remove_writer in cases
> where fd has been closed and then re-allocated to a concurrent
> coroutine as in bug 716636.
>
> Also, assume that the caller will put the file in non-blocking mode
> and
On Tue, 16 Jun 2020 20:43:44 +0200 (CEST)
"michael.lienhardt" wrote:
> Dear all,
> My bad for not noticing it sooner, but when there is a dependency
> like "=sys-fs/udev-208-r1:0/0[static-libs?]" (that occurs in
> virtual/libgudev-215-r3), since 'static-libs' is not a use flags of
>
On Fri, 12 Jun 2020 16:51:51 -0700
Zac Medico wrote:
> Add a sync-openpgp-key-refresh option that makes it possible to
> disable key refresh, which may be useful in cases when it is not
> possible to refresh keys.
>
> Key refresh is enabled by default, and if it is disabled then
> the
On Fri, 5 Jun 2020 18:27:51 -0700
Christopher Head wrote:
> On Fri, 5 Jun 2020 12:40:17 -0700
> Matt Turner wrote:
>
> > With that in mind, I don't expect it to gain Python 3 support, nor
> > do I expect an additional 15 days of waiting time to change that
> > fact. 15 vs 30 days doesn't seem
On Wed, 27 May 2020 01:28:02 -0700
Alec Warner wrote:
> On Wed, May 27, 2020 at 1:09 AM Brian Dolbec
> wrote:
>
> > On Tue, 26 May 2020 20:24:56 -0700
> > Alec Warner wrote:
> >
> > > The TL;DR is that a crack team of infra-folks[0] have been putting
On Wed, 27 May 2020 17:39:21 +0200
Piotr Karbowski wrote:
> Hi,
>
> On 27/05/2020 01.31, Brian Dolbec wrote:
> > * dev-python/boto3
> > * dev-python/botocore
>
> Do you mind if I join you on those? I use them a lot, and I planned to
> comaintain awscli since P
On Tue, 26 May 2020 20:24:56 -0700
Alec Warner wrote:
> The TL;DR is that a crack team of infra-folks[0] have been putting
> together demos of CI services and things like gitlab / gitea / gerrit
> and so on.
>
> Some of these come in combined (e.g. gitlab offers repo hosting, code
> review /
On Tue, 26 May 2020 23:12:06 +0100
Andrey Utkin wrote:
> I have transitioned to "away" state as I have to reclaim my time for
> other uses. Here I am trying to reduce the scope of my Gentoo
> responsibilities to make potential return to activity less dreadful
> and overwhelming.
>
> Call for
On Sat, 23 May 2020 07:20:22 +1200
Kent Fredric wrote:
> On Thu, 21 May 2020 10:47:07 +0200
> Michał Górny wrote:
>
> > Other ideas
> > ===
> > Do you have any other ideas on how we could resolve this?
>
> And a question I'd like to revisit, because nobody responded to it:
>
> -
On Sun, 10 May 2020 19:29:34 -0700
Zac Medico wrote:
> This includes a _compat_upgrade.binpkg_compression script that the
> ebuild can call in pkg_preinst in order to maintain a
> backward-compatible bzip2 default when appropriate, ensuring that
> binary package consumers are not caught off
On Sun, 10 May 2020 21:32:25 -0700
Zac Medico wrote:
> The feature enables finer grained locks for install operations, and
> everyone agrees that it's safe to enable by default.
>
> Bug: https://bugs.gentoo.org/715110
> Signed-off-by: Zac Medico
> ---
> cnf/make.globals | 2 +-
> 1 file
On Wed, 6 May 2020 17:02:42 -0500
William Hubbs wrote:
> All,
>
> I know that most of our documentation tells people to use "emerge
> --sync"; however, today I heard about "emaint sync" for the first
> time. ;-)
>
> Which one should we use? Will there be a phase-out for "emerge
> --sync" or
On Sun, 3 May 2020 08:37:27 -0400
Brian Evans wrote:
> On 5/3/20 2:58 AM, Fabian Groffen wrote:
> > On 02-05-2020 23:24:42 -0700, Brian Dolbec wrote:
> >> On Sun, 3 May 2020 07:28:50 +0200
> >> Viktar Patotski wrote:
> >>
> >>> Hi all,
>
On Sun, 3 May 2020 07:28:50 +0200
Viktar Patotski wrote:
> Hi all,
>
> I'd also like to clean my system and have it Python 2.7 free. Are
> there any guidelines to check which packages are still using pyton2_7
> in my system?
>
> Thanks,
> Viktar
>
There are both equery and enalyze commands
On Sun, 26 Apr 2020 14:57:32 -0700
Zac Medico wrote:
> The ebuild will have a default enabled USE=zstd which changes the
> default to zstd here.
>
> Bug: https://bugs.gentoo.org/715108
> Bug: https://bugs.gentoo.org/719456
> Signed-off-by: Zac Medico
> ---
> cnf/make.globals | 5 -
> 1
On Sun, 26 Apr 2020 17:43:16 +0200
Michał Górny wrote:
> The Python team will no longer maintain the following packages. They
> all need porting to Python 3.7 and newer, and have some obstacle
> in doing so. They have only few revdeps which we do not maintain.
>
> dev-python/pythondialog
>
On Sun, 26 Apr 2020 14:49:25 +0200
Michał Górny wrote:
> # Michał Górny (2020-04-26)
> # Unmaintained. Stuck on Python 3.6. No revdeps.
> # Removal in 30 days. Bug #719604.
> dev-python/txtorcon
>
I'm taking maintainence back, is a dependency for crossbar which I am
bringing back too.
On Sun, 26 Apr 2020 11:32:06 +0200
Toralf Förster wrote:
> On 4/26/20 11:09 AM, Ulrich Mueller wrote:
> > Instead of using the IP address, you could generate a UUID when
> > installing the tool.
>
> like the pfl tool did ?
>
Like the last gentoostats gsoc project did.
As for
On Fri, 24 Apr 2020 08:22:47 +0200
Michał Górny wrote:
> Hi,
>
> The following packages will no longer be maintained by the Python
> team:
>
> dev-python/autobahn
> dev-python/cbor
I'll maintain these again along with buildbot now that I am back.
> dev-python/girder-client
>
On Sat, 11 Apr 2020 17:39:53 -0700
Zac Medico wrote:
> When searching for slot operator rebuilds, respect non slot-operator
> components of parent dependencies, so that a like the not be completely ignored. This will prevent erroneous attempts to
> trigger slot operator rebuilds for upgrades
On Tue, 16 Apr 2019 13:05:40 -0700
Zac Medico wrote:
> Hi all,
>
> We're due for a Portage project lead election [1] which is required by
> GLEP 39 [2]. Please reply with nominations. Thanks!
>
> [1] https://bugs.gentoo.org/683510
> [2] https://www.gentoo.org/glep/glep-0039.html
Well, as Zac
On Sat, 13 Apr 2019 23:03:53 +0200
Michał Górny wrote:
> On Sat, 2019-04-13 at 22:27 +0200, Ralph Seichter wrote:
> > Hi folks,
> >
> > imagine a Python application "monty" with the following requirements
> > listed in setup.py:
> >
> > install_requires=[
> > 'ham>=1.0',
> >
On Tue, 19 Feb 2019 23:03:51 -0600
Matthew Thode wrote:
> On 19-02-20 00:00:04, Michael Orlitzky wrote:
> > On 2/19/19 11:21 PM, Matthew Thode wrote:
> > >>
> > >> What problem would this solve? (Is adding gentoo-keys to @system
> > >> the least bad way to solve it?)
> > >>
> > >
> > > It'd
On Sun, 17 Feb 2019 15:04:29 -0800
Zac Medico wrote:
> Since hardlinks on sshfs do not have matching inode numbers, detect
> this behavior and use a simple stat call to detect if lock_path has
> been removed.
>
> Bug: https://bugs.gentoo.org/678218
> Signed-off-by: Zac Medico
> ---
>
On Sun, 13 Jan 2019 16:27:21 -0800
Zac Medico wrote:
> Execute pid-ns-init as the first fork after unshare, as
> required for it to have pid 1 and become the default reaper
> of orphaned descendant processes. In _exec, exec a separate
> pid-ns-init process to behave as a supervisor which will
>
On Sun, 2 Dec 2018 23:55:23 -0800
Zac Medico wrote:
> Make child processes inherit the current process's environment by
> default, so that behavior is equivalent to the standard library's
> subprocess module.
>
> Bug: https://bugs.gentoo.org/672440
> Signed-off-by: Zac Medico
> ---
>
On Fri, 23 Nov 2018 16:15:23 -0800
Zac Medico wrote:
> Use portage.process.spawn (with new cwd parameter) and
> self.spawn_kwargs to drop privileges for git gc and merge commands.
>
> Fixes: 3cd8cf93abb6 ("GitSync: abort checkout for signature problem
> (bug 660372)") Fixes: 903c4b1a6768
On Sun, 2 Sep 2018 15:03:28 -0700
Zac Medico wrote:
> Since BROOT is only defined in src_* phases, make has/best_version -b
> use the equivalent /${PORTAGE_OVERRIDE_EPREFIX#/} value that is
> defined in all phases. This makes has/best_version -b in EAPI 7
> behave exactly the same as
On Mon, 6 Aug 2018 00:40:29 -0700
Zac Medico wrote:
> Add a boolean sync-rcu repos.conf setting that behaves as follows:
>
> sync-rcu = yes|no
>
> Enable read-copy-update (RCU) behavior for sync operations. The
> current latest immutable version of a repository will be
> referenced by
On Mon, 6 Aug 2018 00:40:32 -0700
Zac Medico wrote:
> Since there aremany ways to manage repository storage, split out a
> repo storage framework. The HardlinkQuarantineRepoStorage class
> implements the existing default behavior, and the InplaceRepoStorage
> class implements the legacy
On Thu, 9 Aug 2018 16:04:42 -0700
Zac Medico wrote:
> For USERLAND=BSD, set XARGS="gxargs -r" if gxargs is available,
> so the code from bug 630292 works for USERLAND=BSD.
>
> Fixes: 50283f1abb77 (install-qa-check.d/60pngfix: parallel support
> (bug 630292)) Reported-by: Michał Górny
> Bug:
On Sun, 5 Aug 2018 22:32:34 -0700
Zac Medico wrote:
> Update all relevant references in docs, messages, and comments
> to refer to /var/db/repos/gentoo instead of /usr/portage. Also
> update DISTDIR and PKGDIR references to refer to the new
> /var/cache/{distfiles,binpkgs} locations.
>
> Bug:
On Sun, 5 Aug 2018 22:46:58 -0700
Zac Medico wrote:
> On 08/05/2018 09:59 PM, Ulrich Mueller wrote:
> >> On Sun, 5 Aug 2018, Zac Medico wrote:
> >
> >> --- a/cnf/make.conf.example
> >> +++ b/cnf/make.conf.example
> >> [...]
> >
> >> @@ -119,16 +119,16 @@
> >> # fetched on
On Sun, 15 Jul 2018 16:02:03 -0700
Zac Medico wrote:
> For the empty profile that's used to check dependencies of
> ebuilds that have empty KEYWORDS, populate implicit IUSE
> from all of the make.defaults files found in the relevant
> repositories (this should take less than 1 second on most
>
On Sun, 15 Jul 2018 14:09:24 -0700
Zac Medico wrote:
> Pass the main-repo name from repos.conf as the repository name
> for the PORTDIR RepoConfig constructor, so that it can override
> the main repo location even if the profiles/repo_name file does
> not exist yet (like in a stage3 tarball).
>
On Fri, 27 Jul 2018 00:56:40 -0700
Zac Medico wrote:
> Add repos.conf settings that enable sync-openpgp-key-path support for
> both emerge-webrsync and emerge-delta-webrsync:
>
> sync-webrsync-delta = true|false
> Use app-portage/emerge-delta-webrsync to minimize
> bandwidth.
On Fri, 27 Jul 2018 16:31:15 +0200
Ulrich Mueller wrote:
> > On Fri, 27 Jul 2018, Corentin “Nado” Pazdera wrote:
>
> > July 27, 2018 4:07 PM, "William Hubbs"
> > wrote:
>
> >> Section 5.5.2 describes the directory structure of /var/cache.
> >> These paths are all optional [1].
> >>
>
On Thu, 19 Jul 2018 10:10:11 +0200
Michał Górny wrote:
> Hello,
>
> Due to Markos Chandras' prolonged absence, the following packages are
> up for grabs now:
>
> dev-util/buildbot-slave
I've taken over all buildbot maintenance. This one will be tree-cleaned
soon. The old buildbot-0.8
On Tue, 17 Jul 2018 13:28:05 -0700
Zac Medico wrote:
> Are there any objections to renaming the pym directory to lib [1]?
> Note that the git log --follow option makes this kind of rename
> fairly painless.
>
> [1] https://github.com/gentoo/portage/pull/343
is fine with me
pgpewJwnz8KUC.pgp
f os.path.exists(profile_bashrc):
> - bashrc_files.append(profile_bashrc)
> + for profile, profile_bashrc in
> zip(self._locations_manager.profiles_complex, self._profile_bashrc):
> + if profile_bashrc:
> +
> bashrc_files.append(os.path.join(profile.location, 'profile.bashrc'))
> if profile in self._pbashrcdict: cpdict =
> self._pbashrcdict[profile].get(cp) if cpdict:
looks good
--
Brian Dolbec
gt; self.settings["PORTAGE_CONFIGROOT"]), noiselevel=-1) mylist = []
> - else:
> - mylist = list(d)
> - # Always sort in ascending order here since it's
> handy
> - # and the result can be easily cached and reused.
> + # Always sort in ascending order here since it's
> handy and
> + # the result can be easily cached and reused. Since
> mylist
> + # is initially in ascending order by repo.priority,
> stable
> + # sort by version produces results in ascending
> order by
> + # (pkg.version, repo.priority).
> self._cpv_sort_ascending(mylist)
> if self.frozen and mytree is None:
> cachelist = mylist[:]
looks fine
--
Brian Dolbec
=
> []
> + for parent in
> set(parents):
> + while parent
> in revisit:
> +
> recursive_parents.append(parent)
> +
> parent = os.path.dirname(parent) +
> + for parent in
> sorted(set(recursive_parents)):
> +
> dirs.append((parent, revisit.pop(parent)))
> def isowner(self, filename, destroot=None):
> """
LGTM
--
Brian Dolbec
On Thu, 12 Jul 2018 17:35:41 -0700
Raymond Jennings wrote:
> On Thu, Jul 12, 2018 at 12:47 PM Brian Dolbec
> wrote:
> >
> > On Thu, 12 Jul 2018 11:49:37 -0700
> > Raymond Jennings wrote:
> >
> > > In that case, I vote for /var/cache/portage, si
ckage manager.
PLUS, it has been decided already long ago that the directory name
should reflect the repository name. We have been enforcing that rule
for overlays for a long time. It has just been taking a long time to
get our tooling in order so that we can change our own to follow that
rule.
So, "portage" should not be a directory name in the new default path.
--
Brian Dolbec
t_match(flag))
> + return iuse_implicit_match
> +
> def _iuse_implicit_cnstr(self, pkg, metadata):
> """
> Construct a callable that checks if a given USE flag
> should
looks good thanks.
Please add the test case ebuild that was supplied to the repoman
gen-b0rk repo "not-broken" category.
https://gitweb.gentoo.org/repo/proj/gen-b0rk.git/
--
Brian Dolbec
catalyst-3 for all arches, but
I don't know about some of the lesser used arches as some of those are
older dates.
That and a portage release with the new default location set in it's
backup configs.
So, it should be ready to convert if the minor arches stage are being
generated
cause how does
> someone dare remind very important developer who was planning to do it
> week before expiration, and now he needed to waste his precious time
> reading your mail.
>
I never experienced a single developer show or say anything like you
are suggesting. Most, thanked me for the reminder whether it was in
IRC or email. And since I always cc'd the gkeys alias (most needed
changes to meet the spec too), I'm sure Kristian will confirm this.
--
Brian Dolbec
pgp5aZWnCcqDB.pgp
Description: OpenPGP digital signature
spec-check start warning at 30 days, and it has been my
experience that often it only gets renewed last minute (depends on how
active the developer is. As it is one of those things that gets put
off thinking there is still lots of time... But also, many of those had
keys that did not meet the spec requirements.
--
Brian Dolbec
pgphYyrmtOdFC.pgp
Description: OpenPGP digital signature
# Brian Dolbec (4 July 2018)
# No longer needed, newer app-crypt/gnupg-2 versions have simple cli options
# for generating new keys and doing key maintenance. Removal in a month
app-crypt/gkeys-gen
--
Brian Dolbec
emplates for a go-jira command line interface so a visually impaired
co-worker could interact with those systems.
--
Brian Dolbec
pgp2ADbD_1YTy.pgp
Description: OpenPGP digital signature
ate me on that, and is it worth considering moving
> away from rsync distribution?
>
> Thanks,
>
> William
>
because:
1) it is still the most bandwidth economical means of distributing the
tree
2) we have a large infrastructure of rsync mirrors, which we do not for
git.
3) see #1
-
ted?
>
> Cheers,
> R0b0t1
>
app-crypt/gentoo-keys has been updated yesterday.
with renewed interest in gpg signatures, I will endeavor to keep it
updated until is fully automated.
--
Brian Dolbec
flags according to the
video card(s) you have.
This would be along the same lines as the
app-portage/cpuid2cpuflags pkg. Then the pkg is updated as new drivers
and combinations are changed. Perhaps have it run in pkg_postisnt to
print any irregularities it finds and ewarn they need fixing.
--
Brian Dolbec
er outing Wednesday evening. If you're
> interested, privately email me. Please include a mention of specific
> dietary requirements if any.
>
I am also local to Vancouver, but won't be at the event. Wednesday
works better for me too. My daughter has ball games Tuesday and
Thursday.
--
Brian Dolbec
pgphPm7lUDY8d.pgp
Description: OpenPGP digital signature
ould be good to merge unless anyone else objects...
--
Brian Dolbec
automation. (I am not familiar with any of that tooling)
I would then suggest the dependency depth check to default to one (or
two) so as to not slow things down drastically. Perhaps a Q/A check
report to scan the whole tree on a weekly basis.
But that would also require PMS to be updated for the new file,
ROOT=/ interacts badly with
> autotools.eclass (bug 654600),
> + # and no EAPI expects SYSROOT to have a trailing
> slash, always strip
> + # the trailing slash from SYSROOT.
> + if 'SYSROOT' in mydict:
> + mydict['SYSROOT'] =
> mydict['SYSROOT'].rstrip(os.path.sep) +
> try:
> builddir = mydict["PORTAGE_BUILDDIR"]
> distdir = mydict["DISTDIR"]
looks good
--
Brian Dolbec
> pym/portage/dbapi/porttree.py | 75 +++--- 3
> files changed, 146 insertions(+), 42 deletions(-)
>
I didn't see any errors glaring at me... :)
looks like it should be good
--
Brian Dolbec
e %s"
> + % (async_lock.returncode,)))
>
> - self._lock_obj = async_lock
> - self.locked = True
> + self._lock_obj = AsynchronousLock(path=self.pkg_path,
> + scheduler=self.scheduler)
> + self._lock_obj.addExitListener(acquired_lock)
> + self._lock_obj.start()
> + return result
>
> class AlreadyLocked(portage.exception.PortageException):
> pass
Looks fine to me :)
--
Brian Dolbec
lass)?
>
> 4. is the "masters" attribute in /etc/portage/repos.conf make the
> repository inherit other data than the eclasses?
>
> 5. since every repos can have a profiles/categories file, is the
> file /etc/portage/categories obsolete (or should it be)?
>
>
> Best Regards,
> Michael Lienhardt
>
>
--
Brian Dolbec
series looks good, thank you :)
--
Brian Dolbec
l can be
> deprecated
> + # after this is available in a stable version of
> portage).
> + if '/' in self.searchkey:
> + match_category = 1
> fuzzy = False
> if regexsearch:
> self.searchre=re.compile(self.searchkey,re.I)
looks fine
--
Brian Dolbec
s/file that can be
added to easily. And just run it from the Actions class as M.J.
Everitt suggested.
--
Brian Dolbec
ld,
> > test_ebuild[:-8] + "3.ebuild")), ("", git_cmd + ("add",
> > test_ebuild[:-8] + "3.ebuild")),
> > - ("dev-libs", repoman_cmd + ("commit",
> > "-m", "bump to version 3")),
> > + ("dev-libs", repoman_cmd + ("commit",
> > "-m", "cat/pkg: bump to version 3")), ("", cp_cmd + (test_ebuild,
> > test_ebuild[:-8] + "4.ebuild")), ("", git_cmd + ("add",
> > test_ebuild[:-8] + "4.ebuild")),
> > - ("dev-libs/A", repoman_cmd + ("commit",
> > "-m", "bump to version 4")),
> > + ("dev-libs/A", repoman_cmd + ("commit",
> > "-m", "cat/pkg: bump to version 4")), )
> >
> > env = {
> Might I suggest breaking out checks into a separate module? I think
> that hard-coding it all is likely to become a pain as time goes on,
> more checks get added, etc ...
>
So, you would like the commit message checks to be a plug-in system
like the ebuild checks are now.
Yes that is possible, that would also allow overlays and sub-distros
to customize it to their liking. But you do realize it would be a
module system with only the one plug-in. It would add a slight amount
of overhead and subsequently a tiny bit more time. Although it is not
much as I remember when I first developed the plug-in system for emaint.
I will consider that for the stage3 work in progress, but for the
master branch of repoman, the hard-coded version above would be fine.
--
Brian Dolbec
pgprVkLpLeUb3.pgp
Description: OpenPGP digital signature
ts) and
> - deep is True and '--update' in myopts):
> + changed_deps_report = myopts.get('--changed-deps-report',
> 'n') == 'y'
> + if changed_deps_report:
> myparams['changed_deps_report'] = True
>
> if myopts.get("--selective") == "n":
looks good, if not already merged.
--
Brian Dolbec
On Sun, 04 Feb 2018 18:58:21 +0100
Michał Górny <mgo...@gentoo.org> wrote:
> W dniu nie, 04.02.2018 o godzinie 09∶51 -0800, użytkownik Brian Dolbec
> napisał:
> >
> > I know there are not a lot of repoman unit tests, but, can you
> > please create some to test this
+ return (False, '\n'.join('- %s' % x for x in
> problems))
> + return (True, None)
I know there are not a lot of repoman unit tests, but, can you please
create some to test this? That way it doesn't get any worse.
In the PR, you mentioned adding in an editor call to re-edit the
message. This would be a good thing and I know is not that difficult
to accomplish. Is this coming in another patch?
--
Brian Dolbec
ave been maintaining
buildbot in gentoo for awhile and my day job is working on/developing
buildbot scripts. I am planning out some pkg bumping scripts to help
with regular pkg maintenance. I hope to have some initial code running
during the holiday break.
There should be a bunch of shared factory code possible as there will
be some overlap in their needs.
--
Brian Dolbec
gt; +#if gcrypt_algos.difference(hashfunc_map):
> try:
> import binascii
> import pygcrypt.hashcontext
looks good thanks, merge please
--
Brian Dolbec
On Tue, 5 Dec 2017 08:42:43 -0800
Brian Dolbec <dol...@gentoo.org> wrote:
> On Tue, 5 Dec 2017 17:34:23 +0100
> Michał Górny <mgo...@gentoo.org> wrote:
>
> > Closes: https://bugs.gentoo.org/615620
> > ---
> > pym/portage/checksum.py | 5 -
> >
ydeps": True,
> "--onlydeps-with-rdeps":
> "y" },
> - mergelist = ["dev-libs/B-1",
> + ambiguous_merge_order = True,
> + mergelist = [("dev-libs/B-1",
>"dev-libs/C-1",
> - "dev-libs/D-1"]),
> + "dev-libs/D-1")]),
> ResolverPlaygroundTestCase(
> ["dev-libs/A"],
> all_permutations = True,
looks good
--
Brian Dolbec
a tradeoff between space and
robustness. If one .keepdir is lost, it may only affect a few
packages. If the database becomes corrupted. It could potentially
mean the loss of much more of your installed pkg data. Spanning a
great deal of the installed pkgs. In this case simplicity
of .keepdir is in my opinion, much better than a single db.
--
Brian Dolbec
ibs/glibc-2.24',
> + 'net-misc/foo-1',
> + ],
> + ),
> + )
> +
> + playground = ResolverPlayground(debug=False,
> + ebuilds=ebuilds, installed=installed,
> world=world,
> + user_config=user_config)
> +
> + try:
> + for test_case in test_cases:
> + playground.run_TestCase(test_case)
> +
> self.assertEqual(test_case.test_success, True,
> + test_case.fail_msg)
> + finally:
> + playground.debug = False
> + playground.cleanup()
looks good
--
Brian Dolbec
(errno == EINVAL && !offset_out) {
> -sendfile_works = 0;
> -}
> -break;
> +if (copyfunc_ret < 0) {
> +error = errno;
> +if (errno == EINVAL && !offset_out) {
> +sendfile_works = 0;
> }
> +break;
> }
> }
> }
Looks good, has been checked by chutzpah
--
Brian Dolbec
<(scanelf -qyRF '#s%p' -s
> __gentoo_check_ldflags__ "${ED}" | LC_ALL=C sort)) if [[ -n ${f} ]] ;
> then echo "${f}" > "${T}"/scanelf-ignored-LDFLAGS.log
> if [ "${QA_STRICT_FLAGS_IGNORED-unset}" =
> unset ] ; then
looks good
--
Brian Dolbec
> @@ -112,7 +124,7 @@ save_elf_sources() {
> # since we're editing the ELF here, we should recompute the
> build-id # (the -i flag below). save that output so we don't need to
> recompute # it later on in the save_elf_debug step.
> - buildid=$(debugedit -i \
> + buildid=$("${debugedit}" -i \
> -b "${WORKDIR}" \
> -d "${prepstrip_sources_dir}" \
> -l
> "${tmpdir}/sources/${x##*/}.${BASHPID:-$(__bashpid)}" \
Looks fine to me
--
Brian Dolbec
playground = ResolverPlayground(
> + ebuilds=ebuilds, installed=installed,
> world=world) +
> + try:
> + for test_case in test_cases:
> + playground.run_TestCase(test_case)
> +
> self.assertEqual(test_case.test_success, True,
> + test_case.fail_msg)
> + finally:
> + playground.cleanup()
Looks fine
--
Brian Dolbec
is_arg_parent = isinstance(parent,
> AtomArg)
> + is_arg_parent = (inst_pkg is not
> None and
> + not
> self._want_installed_pkg(inst_pkg)) is_non_conflict_parent = parent
> not in conflict_pkgs and \ parent not in indirect_conflict_pkgs
>
looks good
--
Brian Dolbec
tConflictMaskUpdateTestCase # fail.
> ResolverPlaygroundTestCase(
> - world,
> + ['@world'],
> all_permutations = True,
> options = {"--update": True,
> "--deep": True}, success = True,
looks good
--
Brian Dolbec
d(pkg for pkg in pkgs if
> pkg.installed) +
> + sorted(pkg for pkg in pkgs if not
> pkg.installed)) +
> for pkg in pkgs:
> eliminate_pkg = True
> for atom in
> atom_pkg_graph.parent_nodes(pkg):
Looks good
--
Brian Dolbec
d to find any wayward writes that had occurred...
>
> This would not require LD_PRELOAD or ptrace eliminating most of the
> "high magic" currently used.
>
> Just yesterday I had a lot of ptrace failures while trying something
> odd with ROOT= and custom USE
>
> Jim McMechan
I kinda like this idea, It looks to me to have pretty much all the
benefits of a sandbox and nearly none of the drawbacks.
Sounds like it should get more research into this idea, figure out it's
limitations and if there are any caveats.
--
Brian Dolbec
name '*.svg'
> + -o -name '*.xpm' -o -name '*.icon'
> ')'
> + )
> # if the cache does not exist at all, we complain
> for any file # otherwise, we look for files newer than the cache
> [[ -f ${d}/icon-theme.cache ]] &&
Works for me, since Gilles approved the change :)
--
Brian Dolbec
there are
> any unrecognized options, so the intention is for 100% compatibility.
>
> > I take issue with the copyright assignment, as I believe the
> > legal .. err .. IANAL devs are campaigning for full rights to be
> > owned and enforced by Gentoo Inc LLC in the US .. even if they have
> > no idea what that means or does .. :]
>
> Since it's a BSD-style license, we can copy the code into our project
> as long as we retain the copyright notice.
Patches look fine to me, glad for the speedup :)
--
Brian Dolbec
> + @returns: bool, True if ssl certificate verification is
> enabled by
> + default
> + """
> + return hasattr(__import__('ssl'),
> '_create_unverified_context') +
> +
> def urlopen(url, if_modified_since=None):
> parse_result = urllib_parse.urlparse(url)
> if parse_result.scheme not in ("http", "https"):
looks fine
--
Brian Dolbec
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Sun, 2 Jul 2017 11:28:09 -0700
Brian Dolbec <dol...@gentoo.org> wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> On Sat, 24 Jun 2017 20:20:16 -0700
> Brian Dolbec <dol...@gentoo.org> wrote:
>
&g
1 - 100 of 768 matches
Mail list logo
