Change in openbsc[master]: tests: Mute stdout during db_prepare()

2019-05-23 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/14140 Change subject: tests: Mute stdout during db_prepare() .. tests: Mute stdout during db_prepare() libdbi on debian unstable (at least) outputs

Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

2019-05-18 Thread Keith Whyte
-Id: I184dcce27b26104c61d80b2d910388d5d3323def Gerrit-Change-Number: 13929 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: lynxis lazus Gerrit-CC: Vadim Yanitskiy

Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

2019-05-18 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/13929/4/src

Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

2019-05-18 Thread Keith Whyte
-Id: I184dcce27b26104c61d80b2d910388d5d3323def Gerrit-Change-Number: 13929 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: lynxis lazus

Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

2019-05-18 Thread Keith Whyte
nge-Number: 13929 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: lynxis lazus

Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx

2019-05-10 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx .. Patch Set 2: > I think the problem lies somewhere else. Agreed. &g

Change in libosmocore[master]: Add expect script: 'vty' for easy access to all vtys

2019-05-08 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13756 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Add expect script: 'vty' for easy access to all vtys

Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx

2019-05-08 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx .. Patch Set 1: Code-Review-1 see OS#3956 I don't know if this would deal

Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx

2019-05-08 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/13929 Change subject: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx .. libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx On receipt of DELETE

Change in osmo-sgsn[master]: Echo zero byte XID-Field of Type L3_PAR

2019-05-01 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 ) Change subject: Echo zero byte XID-Field of Type L3_PAR .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13811

Change in osmo-sgsn[master]: Echo zero byte XID-Field of Type L3_PAR

2019-05-01 Thread Keith Whyte
filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Harald Welte

Change in osmo-sgsn[master]: Echo zero byte XID-Field of Type L3_PAR

2019-05-01 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 ) Change subject: Echo zero byte XID-Field of Type L3_PAR .. Patch Set 6: Code-Review+1 I'm now proposing this for merge. -- To view, visit

Change in osmo-sgsn[master]: Echo zero byte XID-Field of Type L3_PAR

2019-05-01 Thread Keith Whyte
https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 6 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer

Change in osmo-sgsn[master]: Echo zero byte XID-Field of Type L3_PAR

2019-05-01 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 ) Change subject: Echo zero byte XID-Field of Type L3_PAR .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/13811/4/src/gprs

Change in osmo-sgsn[master]: Echo zero byte XID-Field of Type L3_PAR

2019-05-01 Thread Keith Whyte
https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-30 Thread Keith Whyte
mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Harald

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-30 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 ) Change subject: Echo XID-Field of Type L3_PAR even when zero length .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/13811/4/src

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-30 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 ) Change subject: Echo XID-Field of Type L3_PAR even when zero length .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.osmocom.org

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-30 Thread Keith Whyte
mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Harald

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-30 Thread Keith Whyte
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-30 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 ) Change subject: Echo XID-Field of Type L3_PAR even when zero length .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13811/1/src

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-30 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 ) Change subject: Echo XID-Field of Type L3_PAR even when zero length .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13811/1/src

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-29 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 ) Change subject: Echo XID-Field of Type L3_PAR even when zero length .. Patch Set 1: BTW, This would close #OS3426 when done -- To view

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-29 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 ) Change subject: Echo XID-Field of Type L3_PAR even when zero length .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org

Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

2019-04-29 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/13811 Change subject: Echo XID-Field of Type L3_PAR even when zero length .. Echo XID-Field of Type L3_PAR even when zero length After Activate PDP

Change in osmo-sgsn[master]: LLC: Avoid NOTICE message on LLC NULL

2019-04-24 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13765 ) Change subject: LLC: Avoid NOTICE message on LLC NULL .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13765

Change in osmo-sgsn[master]: LLC: Don't blindly assume all LLC frames have data payload

2019-04-24 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13764 ) Change subject: LLC: Don't blindly assume all LLC frames have data payload .. Patch Set 3: Code-Review+1 This solves #OS3952 of course. I

Change in libosmocore[master]: Add expect script: 'vty' for easy access to all vtys

2019-04-24 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13756 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Patch Set 1: > The more "canonical" way for the port

Change in libosmocore[master]: Add expect script: 'vty' for easy access to all vtys

2019-04-24 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13756 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Patch Set 1: > > [...] but I cannot think of any better

Change in osmo-dev[master]: Add expect script: 'vty' for easy access to all vtys

2019-04-23 Thread Keith Whyte
Keith Whyte has abandoned this change. ( https://gerrit.osmocom.org/11811 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Abandoned Moved to libosmocore -- To view, visit https://gerrit.osmocom.org

Change in osmo-dev[master]: Add expect script: 'vty' for easy access to all vtys

2019-04-23 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11811 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Patch Set 2: Code-Review-1 posted to libosmocore

Change in libosmocore[master]: Add expect script: 'vty' for easy access to all vtys

2019-04-23 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/13756 Change subject: Add expect script: 'vty' for easy access to all vtys .. Add expect script: 'vty' for easy access to all vtys This expect

Change in openbsc[master]: Fixed MNCC_RTP_CREATE after MNCC_DISC_IND.

2019-04-23 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13703 ) Change subject: Fixed MNCC_RTP_CREATE after MNCC_DISC_IND. .. Patch Set 2: Code-Review+1 Rafael, Harald gave this a +2 so you can hit

Change in openbsc[master]: Fixed MNCC_RTP_CREATE after MNCC_DISC_IND.

2019-04-21 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13703 ) Change subject: Fixed MNCC_RTP_CREATE after MNCC_DISC_IND. .. Patch Set 1: > Uploaded patch set 1. This seems to catch the problem. Peo

Change in osmo-msc[master]: Move enum definition to header file

2019-04-20 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12598 ) Change subject: Move enum definition to header file .. Patch Set 1: Code-Review-2 This is not needed as it turned out we don't want to check

Change in osmo-msc[master]: Move enum definition to header file

2019-04-20 Thread Keith Whyte
Keith Whyte has abandoned this change. ( https://gerrit.osmocom.org/12598 ) Change subject: Move enum definition to header file .. Abandoned -- To view, visit https://gerrit.osmocom.org/12598 To unsubscribe, or for help writing

Change in osmo-sip-connector[master]: MNCC: Do not continue with B leg if A leg is cancelled.

2019-04-20 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11194 ) Change subject: MNCC: Do not continue with B leg if A leg is cancelled. .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in osmo-sip-connector[master]: MNCC: Do not continue with B leg if A leg is cancelled.

2019-04-20 Thread Keith Whyte
://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0eca9a741f7924c2fc32c503dd1a0fc083f94f37 Gerrit-Change-Number: 11194 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins

Change in osmo-sip-connector[master]: MNCC: Do not continue with B leg if A leg is cancelled.

2019-04-20 Thread Keith Whyte
/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0eca9a741f7924c2fc32c503dd1a0fc083f94f37 Gerrit-Change-Number: 11194 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder

Change in osmo-sip-connector[master]: MNCC: Do not continue with B leg if A leg is cancelled.

2019-04-20 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11194 ) Change subject: MNCC: Do not continue with B leg if A leg is cancelled. .. Patch Set 2: > @Keith: If you would have time to t

Change in osmo-sip-connector[master]: MNCC: Do not continue with B leg if A leg is cancelled.

2019-04-19 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11194 ) Change subject: MNCC: Do not continue with B leg if A leg is cancelled. .. Patch Set 2: Code-Review+1 > Uploaded patch set 2. I have

Change in osmo-msc[master]: sms queue: avoid repeated Paging for a failed SMS

2019-03-30 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13173 ) Change subject: sms queue: avoid repeated Paging for a failed SMS .. Patch Set 2: Code-Review+1 This is something I've intended to look

Change in osmo-msc[master]: Write configuration correctly from vty (alert notifications)

2019-03-29 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13321 ) Change subject: Write configuration correctly from vty (alert notifications) .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-msc[master]: Write configuration correctly from vty (alert notifications)

2019-03-29 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13321 ) Change subject: Write configuration correctly from vty (alert notifications) .. Write configuration correctly from vty (alert

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-29 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13320 ) Change subject: Write configuration correctly from vty (alert notifications) .. Write configuration correctly from vty (alert

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13320 ) Change subject: Write configuration correctly from vty (alert notifications) .. Patch Set 3: > Please re-trigger tests once it's resol

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-03-19 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Support Emergency Calling LCR supports emergency calling by sending the string

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-19 Thread Keith Whyte
smocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4b0363fa34dd9ac0a221844974e4ebf7465b56f4 Gerrit-Change-Number: 13320 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102)

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-19 Thread Keith Whyte
smocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4b0363fa34dd9ac0a221844974e4ebf7465b56f4 Gerrit-Change-Number: 13320 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-03-19 Thread Keith Whyte
: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 12 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-CC: Harald Welte

Change in osmo-msc[master]: Write configuration correctly from vty (alert notifications)

2019-03-19 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/13321 Change subject: Write configuration correctly from vty (alert notifications) .. Write configuration correctly from vty (alert notifications

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-19 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/13320 Change subject: Write configuration correctly from vty (alert notifications) .. Write configuration correctly from vty (alert notifications

Change in osmo-msc[master]: Don't deliver alert notifications to ESME not yet bound.

2019-02-28 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12599 ) Change subject: Don't deliver alert notifications to ESME not yet bound. .. Don't deliver alert notifications to ESME not yet bound

Change in openbsc[master]: Don't deliver alert notifications to an ESME that is not yet bound.

2019-02-28 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12602 ) Change subject: Don't deliver alert notifications to an ESME that is not yet bound. .. Don't deliver alert notifications to an ESME

Change in openbsc[master]: Don't deliver alert notifications to an ESME that is not yet bound.

2019-02-28 Thread Keith Whyte
bbf Gerrit-Change-Number: 12602 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-CC: Harald Welte

Change in openbsc[master]: Make alert notifications vty configurable per ESME

2019-02-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12601 ) Change subject: Make alert notifications vty configurable per ESME .. Patch Set 1: > To be fair, this wasn't really obvious or otherw

Change in osmo-msc[master]: Don't deliver alert notifications to ESME not yet bound.

2019-02-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12599 ) Change subject: Don't deliver alert notifications to ESME not yet bound. .. Set Ready For Review -- To view, visit https

Change in openbsc[master]: Don't deliver alert notifications to an ESME that is not yet bound.

2019-02-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12602 ) Change subject: Don't deliver alert notifications to an ESME that is not yet bound. .. Patch Set 2: (1 comment) https://gerrit.osmocom.org

Change in openbsc[master]: Don't deliver alert notifications to an ESME that is not yet bound.

2019-02-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12602 ) Change subject: Don't deliver alert notifications to an ESME that is not yet bound. .. Set Ready For Review -- To view, visit https

Change in openbsc[master]: Make alert notifications vty configurable per ESME

2019-02-11 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12601 ) Change subject: Make alert notifications vty configurable per ESME .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12601/1

Change in openbsc[master]: Make alert notifications vty configurable per ESME

2019-02-11 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12601 ) Change subject: Make alert notifications vty configurable per ESME .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12601/1

Change in osmo-sip-connector[master]: Support International Caller ID

2019-01-29 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12706 ) Change subject: Support International Caller ID .. Patch Set 4: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/12706/3/src/mncc.c

Change in osmo-sip-connector[master]: Support International Caller ID

2019-01-29 Thread Keith Whyte
-Change-Id: Idcfa31aff90e04dd0aa3583957f29b1bbefe Gerrit-Change-Number: 12706 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr

Change in osmo-pcu[master]: Added support for daemonize to osmo-pcu.

2019-01-29 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12718 ) Change subject: Added support for daemonize to osmo-pcu. .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12718/1/src

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-29 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 11: (1 comment) https://gerrit.osmocom.org/#/c/12682/11/src/mncc.c File src/mncc.c

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 1: > (1 comment) Maybe see https://www.emergency-services-coordination.info/2008

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c File src/mncc.c

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 8 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: Max Gerrit-CC: Harald Welte

Change in osmo-sip-connector[master]: Support International Caller ID

2019-01-28 Thread Keith Whyte
: Idcfa31aff90e04dd0aa3583957f29b1bbefe Gerrit-Change-Number: 12706 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-CC: Max

Change in osmo-sip-connector[master]: Support International Caller ID

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12706 ) Change subject: Support International Caller ID .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12706/2/src/mncc.c File src

Change in osmo-sip-connector[master]: Support International Caller ID

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12706 ) Change subject: Support International Caller ID .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12706/2/src/mncc.c File src

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 7: Not ignoring what Harald commented about implementing emergency calling support

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: Max Gerrit-CC: Harald Welte

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 6: > maybe just if.. else the block with the > subsequent checks for the calle

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 6: > (2 comments) > > It kinda feels like you're "cheating&quo

Change in osmo-sip-connector[master]: Support International Caller ID

2019-01-28 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/12706 Change subject: Support International Caller ID .. Support International Caller ID When the SIP call source contains + as first character

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 6 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-CC: Harald Welte Gerrit-CC: Max

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-CC: Harald Welte Gerrit-CC: Max

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c File src/mncc.c

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c File

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-CC: Harald Welte Gerrit-CC: Max

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-CC: Harald Welte Gerrit-CC: Max

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12682/2/src/mncc.c File

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-28 Thread Keith Whyte
: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-CC: Harald Welte Gerrit-CC: Max

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-25 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c File src/mncc.c

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-23 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c File src/mncc.c

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-22 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c File

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-01-22 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/12682 Change subject: Support Emergency Calling .. Support Emergency Calling LCR supports emergency calling by sending the string 'emergency

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12603 ) Change subject: Cosmetic: Fix spelling in smpp vty .. Cosmetic: Fix spelling in smpp vty Change-Id

Change in openbsc[master]: Make alert notifications vty configurable per ESME

2019-01-17 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12601 ) Change subject: Make alert notifications vty configurable per ESME .. Make alert notifications vty configurable per ESME OSMO-MSC

Change in osmo-msc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12600 ) Change subject: Cosmetic: Fix spelling in smpp vty .. Cosmetic: Fix spelling in smpp vty Change-Id

Change in osmo-msc[master]: Make alert notifications vty configurable per ESME

2019-01-17 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12597 ) Change subject: Make alert notifications vty configurable per ESME .. Make alert notifications vty configurable per ESME Adds

Change in osmo-msc[master]: Don't send Alert Notifications to ESME not bound for RX

2019-01-17 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12599 ) Change subject: Don't send Alert Notifications to ESME not bound for RX .. Patch Set 2: > Why is that? In short, I guess I was think

Change in openbsc[master]: Make alert notifications vty configurable per ESME

2019-01-16 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/12601 Change subject: Make alert notifications vty configurable per ESME .. Make alert notifications vty configurable per ESME OSMO-MSC backport

Change in openbsc[master]: Don't deliver alert notification to ESME not bound for RX

2019-01-16 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/12602 Change subject: Don't deliver alert notification to ESME not bound for RX .. Don't deliver alert notification to ESME not bound for RX Change

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-16 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/12603 Change subject: Cosmetic: Fix spelling in smpp vty .. Cosmetic: Fix spelling in smpp vty Change-Id: If2180828e2acd28d96754c593c317c2868644c4b

Change in osmo-msc[master]: Don't send Alert Notifications to ESME not bound for RX

2019-01-16 Thread Keith Whyte
Keith Whyte has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/12599 ) Change subject: Don't send Alert Notifications to ESME not bound for RX .. Don't send Alert Notifications to ESME not bound for RX Change-Id

Change in osmo-msc[master]: Make alert notifications vty configurable per ESME

2019-01-16 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12597 ) Change subject: Make alert notifications vty configurable per ESME .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12597/1/src

Change in osmo-msc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-16 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/12600 Change subject: Cosmetic: Fix spelling in smpp vty .. Cosmetic: Fix spelling in smpp vty Change-Id: Id3fa3f26c333bf445590fd75ad7a08be68fed3e2

Change in osmo-msc[master]: Don't send Alert Notifications to ESME not bound for RX

2019-01-16 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/12599 Change subject: Don't send Alert Notifications to ESME not bound for RX .. Don't send Alert Notifications to ESME not bound for RX Change-Id

  1   2   3   >