Change in libosmocore[master]: msgb: add test helpers

2018-12-04 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 ) Change subject: msgb: add test helpers .. Patch Set 5: (1 comment) > I usually end up tailoring the debug output to the specific test. You

Change in libosmocore[master]: msgb: add test helpers

2018-12-04 Thread Max
-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5 Gerrit-Change-Number: 12017 Gerrit-PatchSet: 9 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit

Change in libosmocore[master]: Logging: don't print hex category by default

2018-12-04 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12095 Change subject: Logging: don't print hex category by default .. Logging: don't print hex category by default This information is of little use

Change in libosmocore[master]: LCLS: add gsm0808_create_ass2()

2018-12-04 Thread Max
-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id89765df3f8c12f55f73f1d7a9d90c8883eb3bba Gerrit-Change-Number: 11826 Gerrit-PatchSet: 22 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr

Change in libosmocore[master]: msgb: add test helpers

2018-12-04 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 ) Change subject: msgb: add test helpers .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/12017 To unsubscribe, or for help

Change in libosmocore[master]: Add osmo_init_logging_std*()

2018-12-04 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12094 Change subject: Add osmo_init_logging_std*() .. Add osmo_init_logging_std*() The osmo_init_logging_stdout() function is similar to osmo_init_logging2

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-12-04 Thread Max
Gerrit-Change-Number: 11827 Gerrit-PatchSet: 17 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: Add msgb_tl_put() helper

2018-12-04 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12080 ) Change subject: Add msgb_tl_put() helper .. Add msgb_tl_put() helper When adding complex TLV structures where length of V is not known

Change in libosmocore[master]: LCLS: update osmo_lcls struct

2018-12-04 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12019 ) Change subject: LCLS: update osmo_lcls struct .. LCLS: update osmo_lcls struct * use pointer to proper struct type for GCR * update comments

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-12-04 Thread Max
Gerrit-Change-Number: 11827 Gerrit-PatchSet: 16 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: LCLS: add gsm0808_create_ass2()

2018-12-04 Thread Max
-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id89765df3f8c12f55f73f1d7a9d90c8883eb3bba Gerrit-Change-Number: 11826 Gerrit-PatchSet: 21 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

2018-12-04 Thread Max
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d Gerrit-Change-Number: 12020 Gerrit-PatchSet: 10 Gerrit-Owner: Max

Change in libosmocore[master]: ctrl: use #define for TRAP id

2018-12-03 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11926 ) Change subject: ctrl: use #define for TRAP id .. ctrl: use #define for TRAP id We always use id = 0 when sending TRAP messages. Let's make

Change in libosmocore[master]: msgb: add test helpers

2018-12-03 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 ) Change subject: msgb: add test helpers .. Patch Set 5: > I think we should avoid using printf() in libosmocore In general I'd agree but th

Change in libosmocore[master]: LCLS: add gsm0808_create_ass2()

2018-12-03 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11826 ) Change subject: LCLS: add gsm0808_create_ass2() .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11826 To unsubscribe

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

2018-12-03 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 ) Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/12020

Change in libosmocore[master]: Add msgb_tl_put() helper

2018-12-03 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12080 Change subject: Add msgb_tl_put() helper .. Add msgb_tl_put() helper When adding complex TLV structures where length of V is not known in advance it's

Change in libosmocore[master]: LCLS: update osmo_lcls struct

2018-12-03 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12019 ) Change subject: LCLS: update osmo_lcls struct .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/12019 To unsubscribe, or for help

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-12-03 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 ) Change subject: LCLS, TS 29.205: add GCR routines .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11827 To unsubscribe

Change in libosmocore[master]: msgb: add test helpers

2018-12-03 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 ) Change subject: msgb: add test helpers .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/12017 To unsubscribe, or for help

Change in libosmocore[master]: Update msgb Lx helpers

2018-12-03 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12079 Change subject: Update msgb Lx helpers .. Update msgb Lx helpers * add missing L1 and L4 hexdump * add msgb_l4() for consistency and convert msgb_sms

Change in libosmocore[master]: Move BSSMAP_MSG_* defines to header file

2018-11-30 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12018 ) Change subject: Move BSSMAP_MSG_* defines to header file .. Move BSSMAP_MSG_* defines to header file This will be reused be several tests

Change in libosmocore[master]: LCLS: fix GCR parameter type

2018-11-30 Thread Max
: I8ccfbd0c146e462e599e5305520cc89602364ec3 Gerrit-Change-Number: 12019 Gerrit-PatchSet: 4 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-11-30 Thread Max
: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf Gerrit-Change-Number: 11827 Gerrit-PatchSet: 12 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: LCLS: fix GCR parameter name

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12019 ) Change subject: LCLS: fix GCR parameter name .. Patch Set 3: (1 comment) It's kinda confusing when you complain about presence and absence of "

Change in libosmocore[master]: gsm0808: add encoder for cause codes and use it

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12044 ) Change subject: gsm0808: add encoder for cause codes and use it .. Patch Set 1: (3 comments) I think the test should be added as well. It's rather

Change in libosmocore[master]: LCLS: add gsm0808_create_ass_ext()

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11826 ) Change subject: LCLS: add gsm0808_create_ass_ext() .. Patch Set 10: (1 comment) I've tried to address other comments in extended patch series. Let

Change in libosmocore[master]: msgb: add test helpers

2018-11-30 Thread Max
/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5 Gerrit-Change-Number: 12017 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau

Change in libosmocore[master]: LCLS: fix GCR parameter name

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12019 ) Change subject: LCLS: fix GCR parameter name .. Patch Set 1: (1 comment) Or did I misunderstood your question? https://gerrit.osmocom.org/#/c/12019

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 ) Change subject: LCLS, TS 29.205: add GCR routines .. Patch Set 9: (3 comments) The rest should be addressed in next revision. https

Change in libosmocore[master]: msgb: add test helpers

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 ) Change subject: msgb: add test helpers .. Patch Set 2: > what about having it return an int like memcmp? What for? > after all we are using

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-11-30 Thread Max
: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf Gerrit-Change-Number: 11827 Gerrit-PatchSet: 10 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

2018-11-30 Thread Max
, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d Gerrit-Change-Number: 12020 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer

Change in libosmocore[master]: LCLS: add gsm0808_create_ass_ext()

2018-11-30 Thread Max
Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id89765df3f8c12f55f73f1d7a9d90c8883eb3bba Gerrit-Change-Number: 11826 Gerrit-PatchSet: 14 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels

Change in libosmocore[master]: msgb: add test helpers

2018-11-30 Thread Max
/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5 Gerrit-Change-Number: 12017 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: Move BSSMAP_MSG_* defines to header file

2018-11-30 Thread Max
Gerrit-Change-Id: I4d8cc05b8df8e70c1f6257e53ae3acec7901681f Gerrit-Change-Number: 12018 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11728/4/src

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 6: (2 comments) https://gerrit.osmocom.org/#/c/11728/6

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 ) Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/12020

Change in libosmocore[master]: LCLS: add gsm0808_create_ass_ext()

2018-11-30 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11826 ) Change subject: LCLS: add gsm0808_create_ass_ext() .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11826 To unsubscribe

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-11-29 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 ) Change subject: LCLS, TS 29.205: add GCR routines .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11827 To unsubscribe

Change in libosmocore[master]: LCLS: add gsm0808_create_ass_ext()

2018-11-29 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11826 ) Change subject: LCLS: add gsm0808_create_ass_ext() .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11826 To unsubscribe

Change in libosmocore[master]: LCLS: fix GCR parameter name

2018-11-29 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12019 Change subject: LCLS: fix GCR parameter name .. LCLS: fix GCR parameter name * use proper struct pointer * update comments to be useful for doxygen

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

2018-11-29 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12020 Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. LCLS, TS 48.008: add GCR IE encoding/decoding * add functions to encode Global Call

Change in libosmocore[master]: msgb: add test helper

2018-11-29 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12017 Change subject: msgb: add test helper .. msgb: add test helper It's often handy to compare msgb to a given array and print the position where

Change in libosmocore[master]: Move BSSMAP_MSG_* defines to header file

2018-11-29 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12018 Change subject: Move BSSMAP_MSG_* defines to header file .. Move BSSMAP_MSG_* defines to header file Change-Id

Change in osmo-pcu[master]: EDGE: fix wrong encoding of LH bits

2018-11-29 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/3991 ) Change subject: EDGE: fix wrong encoding of LH bits .. Patch Set 3: Note to self: re-test after https://osmocom.org/issues/3014 is resolved

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-28 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11953 ) Change subject: ctrl2cgi: fix deferred callbacks .. Patch Set 4: > I'd like to stop seeing code being moved somewhere and then moved back I'd l

Change in python/osmo-python-tests[master]: Improve code style

2018-11-28 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11975 ) Change subject: Improve code style .. Improve code style * reorder imports to make pylint3 happy * drop unused imports * use proper spacing

Change in python/osmo-python-tests[master]: Move command processing into shared function

2018-11-28 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11974 ) Change subject: Move command processing into shared function .. Move command processing into shared function Change-Id

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-28 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11953 ) Change subject: ctrl2cgi: fix deferred callbacks .. ctrl2cgi: fix deferred callbacks Previously handle_reply() was marked as deferred

Change in python/osmo-python-tests[master]: Drop unused Trap() class

2018-11-28 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11973 ) Change subject: Drop unused Trap() class .. Drop unused Trap() class Change-Id: Ic2066a66f99a059fc65cf3092170e248288c04d4 --- M osmopy

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-28 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: I mean gsm0808_create_handover_performed() of course

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-28 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: Actually, could we add "const struct osmo_lcls

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-28 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11953 ) Change subject: ctrl2cgi: fix deferred callbacks .. Patch Set 3: (1 comment) The very point of this commit is to get rid of "yield&q

Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

2018-11-28 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11909 ) Change subject: osmo_ctrl.py: properly ignore out-of-order traps .. osmo_ctrl.py: properly ignore out-of-order traps Sometimes when we set

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-28 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. ctrl: add function to skip TRAP messages This allows to easy skip TRAP messages

Change in python/osmo-python-tests[master]: ctrl: cosmetic cleanup

2018-11-28 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11930 ) Change subject: ctrl: cosmetic cleanup .. ctrl: cosmetic cleanup * remove unused function * move internal function call outside of main

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-28 Thread Max
/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I51ce207c19a1ca96c3e2af7d5efd64f79b02fbb4 Gerrit-Change-Number: 11929 Gerrit-PatchSet: 4 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-28 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11953 ) Change subject: ctrl2cgi: fix deferred callbacks .. Patch Set 2: (1 comment) Logging should be fixed in follow-up patches. https

Change in python/osmo-python-tests[master]: Move command processing into shared function

2018-11-28 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11974 Change subject: Move command processing into shared function .. Move command processing into shared function Change-Id

Change in python/osmo-python-tests[master]: Improve code style

2018-11-28 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11975 Change subject: Improve code style .. Improve code style * reorder imports to make pylint3 happy * drop unused imports * use proper spacing for list

Change in python/osmo-python-tests[master]: Drop unused Trap() class

2018-11-28 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11973 Change subject: Drop unused Trap() class .. Drop unused Trap() class Change-Id: Ic2066a66f99a059fc65cf3092170e248288c04d4 --- M osmopy/trap_helper.py

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-28 Thread Max
: 11953 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: daniel

Change in python/osmo-python-tests[master]: Move Trap class back to separate files

2018-11-27 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11952 ) Change subject: Move Trap class back to separate files .. Move Trap class back to separate files After further testing it turns out

Change in python/osmo-python-tests[master]: Update trap helper

2018-11-27 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11951 ) Change subject: Update trap helper .. Update trap helper * add missing import * update docs * add helper functions Change-Id

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11953 ) Change subject: ctrl2cgi: fix deferred callbacks .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11953 To unsubscribe

Change in python/osmo-python-tests[master]: Move Trap class back to separate files

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11952 ) Change subject: Move Trap class back to separate files .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11952 To unsubscribe

Change in python/osmo-python-tests[master]: Update trap helper

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11951 ) Change subject: Update trap helper .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11951 To unsubscribe, or for help writing

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-27 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11953 Change subject: ctrl2cgi: fix deferred callbacks .. ctrl2cgi: fix deferred callbacks Previously handle_reply() was marked as deferred callback unlike

Change in python/osmo-python-tests[master]: Update trap helper

2018-11-27 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11951 Change subject: Update trap helper .. Update trap helper * add missing import * update docs * add helper functions Change-Id

Change in python/osmo-python-tests[master]: Move Trap class back to separate files

2018-11-27 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11952 Change subject: Move Trap class back to separate files .. Move Trap class back to separate files After further testing it turns out that Trap() have

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11943 ) Change subject: fix file descriptor leak in osysmon_file_read .. Patch Set 2: Code-Review+1 (2 comments) Just a minor thing though - can be merged

Change in python/osmo-python-tests[master]: Re-apply changes to trap_helper.py

2018-11-27 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11948 ) Change subject: Re-apply changes to trap_helper.py .. Re-apply changes to trap_helper.py Due to changes getting out of sync, changes from

Change in python/osmo-python-tests[master]: Re-apply changes to trap_helper.py

2018-11-27 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11948 Change subject: Re-apply changes to trap_helper.py .. Re-apply changes to trap_helper.py Due to changes getting out of sync, changes from

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11728/4/src

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: On another note - most likely I'll need to add LCLS

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 3: > if you'd receive an IPA message with len(payload) == 0 followed by an

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Move common Trap-related code into separate file The ctrl2cgi.py

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11943 ) Change subject: fix file descriptor leak in osysmon_file_read .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11943/1/osysmon_file.c

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: (1 comment) Please elaborate - either complete function as you'd like

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: We might want to bump the .deb version to match the python one

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: > Did you try actually the script can be imported if instal

Change in python/osmo-python-tests[master]: osmo_ipa: update split_combined docs

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11938 ) Change subject: osmo_ipa: update split_combined docs .. osmo_ipa: update split_combined docs Change-Id

Change in python/osmo-python-tests[master]: osmo_ipa: update split_combined docs

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11938 ) Change subject: osmo_ipa: update split_combined docs .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11938 To unsubscribe

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: (1 comment) Having said that, I'd very much welcome your patch which would

Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

2018-11-26 Thread Max
gs Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia6de02c2f13a56f0381c97a9ab02c6c7a31cc32f Gerrit-Change-Number: 11909 Gerrit-PatchSet: 4 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerri

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py File

Change in python/osmo-python-tests[master]: osmo_ipa: add extended checks

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11937 ) Change subject: osmo_ipa: add extended checks .. osmo_ipa: add extended checks Make sure we properly handle None objects. Change-Id

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11936

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11929 To unsubscribe

Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11909 ) Change subject: osmo_ctrl.py: properly ignore out-of-order traps .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11909

Change in python/osmo-python-tests[master]: ctrl: cosmetic cleanup

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11930 ) Change subject: ctrl: cosmetic cleanup .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11930 To unsubscribe, or for help

Change in python/osmo-python-tests[master]: osmo_ipa: add extended checks

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11937 Change subject: osmo_ipa: add extended checks .. osmo_ipa: add extended checks Make sure we properly handle None objects. Change-Id

Change in python/osmo-python-tests[master]: osmo_ipa: update split_combined docs

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11938 Change subject: osmo_ipa: update split_combined docs .. osmo_ipa: update split_combined docs Change-Id: I1cc6dc314fa0f147ab64ad29d9b892c3637a51c7

Change in osmo-gsm-manuals[master]: ctrl: clarify use of id = 0

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11927 ) Change subject: ctrl: clarify use of id = 0 .. ctrl: clarify use of id = 0 Change-Id: Ic00de5023e7a1ec6426a0178778d35b13c337271 --- M common

Change in python/osmo-python-tests[master]: ctrl: introduce constant for TRAP id

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11928 ) Change subject: ctrl: introduce constant for TRAP id .. ctrl: introduce constant for TRAP id Use it for TRAP message parsing and generation

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11936 Change subject: Move common Trap-related code into separate file .. Move common Trap-related code into separate file The ctrl2cgi.py is heavily based

Change in python/osmo-python-tests[master]: ctrl2cgi: remove unused function

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11935 ) Change subject: ctrl2cgi: remove unused function .. ctrl2cgi: remove unused function Change-Id: I1bff680b301b06e3b178d59bdcb86c4773ad9296

Change in python/osmo-python-tests[master]: ctrl2cgi: remove unused function

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11935 Change subject: ctrl2cgi: remove unused function .. ctrl2cgi: remove unused function Change-Id: I1bff680b301b06e3b178d59bdcb86c4773ad9296 --- M

<    7   8   9   10   11   12   13   14   15   16   >