Change in libosmo-abis[master]: WIP: Add new TRAU frame sync code

[laforge]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmo-abis/+/18250

to look at the new patch set (#3).

Change subject: WIP: Add new TRAU frame sync code
..

WIP: Add new TRAU frame sync code

This code is able to detect and sync against a variety of TRAU
frame sync patterns.  Focus is so far on those patterns present on
16k sub-slots, but 8k sub-slots are expected to be supported soon,
too.

A new codebase for this is required as the old OsmoNITB code had
conflated a 16k sub-slot multiplexer with TRAU frame synchronization,
so there was no way to separate those two parts and hence no way to
support 8k sub-slots.

Change-Id: Ia6fe6228b0b8b9a27999f37ce1115ed5558881ea
---
M include/Makefile.am
A include/osmocom/trau/trau_sync.h
M src/Makefile.am
A src/trau/trau_sync.c
A src/trau/ubit_buf.h
M tests/Makefile.am
M tests/testsuite.at
A tests/trau_sync/trau_sync_test.c
A tests/trau_sync/trau_sync_test.err
A tests/trau_sync/trau_sync_test.ok
10 files changed, 703 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/50/18250/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18250
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ia6fe6228b0b8b9a27999f37ce1115ed5558881ea
Gerrit-Change-Number: 18250
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

[laforge]

Hello tnt, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/18247

to look at the new patch set (#10).

Change subject: Implement ITU-T I.460 multiplex / demultiplex
..

Implement ITU-T I.460 multiplex / demultiplex

This implements a multiplexer and de-multiplexer for the ITU-T I.460
standard.  The latter covers the transmission of sub-slots of 32/16/8k
inside 64k timeslots.

Change-Id: Id522f06e73b77332b437b7a27e4966872da70eda
---
M include/Makefile.am
A include/osmocom/gsm/i460_mux.h
M src/gsm/Makefile.am
A src/gsm/i460_mux.c
M src/gsm/libosmogsm.map
M tests/Makefile.am
A tests/i460_mux/i460_mux_test.c
A tests/i460_mux/i460_mux_test.ok
M tests/testsuite.at
9 files changed, 999 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/18247/10
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18247
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id522f06e73b77332b437b7a27e4966872da70eda
Gerrit-Change-Number: 18247
Gerrit-PatchSet: 10
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: tnt 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

[laforge]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/18247

to look at the new patch set (#9).

Change subject: Implement ITU-T I.460 multiplex / demultiplex
..

Implement ITU-T I.460 multiplex / demultiplex

This implements a multiplexer and de-multiplexer for the ITU-T I.460
standard.  The latter covers the transmission of sub-slots of 32/16/8k
inside 64k timeslots.

Change-Id: Id522f06e73b77332b437b7a27e4966872da70eda
---
M include/Makefile.am
A include/osmocom/gsm/i460_mux.h
M src/gsm/Makefile.am
A src/gsm/i460_mux.c
M src/gsm/libosmogsm.map
M tests/Makefile.am
A tests/i460_mux/i460_mux_test.c
A tests/i460_mux/i460_mux_test.ok
M tests/testsuite.at
9 files changed, 951 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/18247/9
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18247
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id522f06e73b77332b437b7a27e4966872da70eda
Gerrit-Change-Number: 18247
Gerrit-PatchSet: 9
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: tnt 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/18247 )

Change subject: Implement ITU-T I.460 multiplex / demultiplex
..


Patch Set 9:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/18247/5/src/gsm/i460_mux.c
File src/gsm/i460_mux.c:

https://gerrit.osmocom.org/c/libosmocore/+/18247/5/src/gsm/i460_mux.c@208
PS5, Line 208: static uint8_t mux_timeslot_provide_bits(struct 
osmo_i460_timeslot *ts)
> According to the specs, any bits that's not used by a subchannel should be 
> set to 1. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18247
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id522f06e73b77332b437b7a27e4966872da70eda
Gerrit-Change-Number: 18247
Gerrit-PatchSet: 9
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: tnt 
Gerrit-Comment-Date: Thu, 21 May 2020 06:24:05 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt 
Gerrit-MessageType: comment

Build failure of network:osmocom:nightly/osmo-trx in openSUSE_Factory_ARM/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/openSUSE_Factory_ARM/armv7l

Package network:osmocom:nightly/osmo-trx failed to build in 
openSUSE_Factory_ARM/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  416s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread 
-I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall 
-D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables 
-fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type 
-flto=auto -flto=auto -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o  
./device/usrp1/.libs/libdevice.a ./.libs/libtransceiver_common.a 
../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a 
../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm 
-ltalloc -losmovty -losmocore -lusrp -lusb-1.0 -pthread
[  416s] 
/usr/lib/gcc/armv7hl-suse-linux-gnueabi/9/../../../../armv7hl-suse-linux-gnueabi/bin/ld:
 cannot find -losmogsm
[  416s] collect2: error: ld returned 1 exit status
[  416s] make[3]: *** [Makefile:678: osmo-trx-lms] Error 1
[  416s] make[3]: *** Waiting for unfinished jobs
[  416s] 
/usr/lib/gcc/armv7hl-suse-linux-gnueabi/9/../../../../armv7hl-suse-linux-gnueabi/bin/ld:
 cannot find -losmogsm
[  416s] collect2: error: ld returned 1 exit status
[  416s] 
/usr/lib/gcc/armv7hl-suse-linux-gnueabi/9/../../../../armv7hl-suse-linux-gnueabi/bin/ld:
 cannot find -losmogsm
[  416s] collect2: error: ld returned 1 exit status
[  416s] make[3]: *** [Makefile:686: osmo-trx-usrp1] Error 1
[  416s] make[3]: *** [Makefile:682: osmo-trx-uhd] Error 1
[  416s] make[3]: Leaving directory 
'/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.35.7bbe/Transceiver52M'
[  416s] make[2]: *** [Makefile:821: all-recursive] Error 1
[  416s] make[2]: Leaving directory 
'/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.35.7bbe/Transceiver52M'
[  416s] make[1]: *** [Makefile:515: all-recursive] Error 1
[  416s] make[1]: Leaving directory 
'/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.35.7bbe'
[  416s] make: *** [Makefile:446: all] Error 2
[  416s] error: Bad exit status from /var/tmp/rpm-tmp.VI0Qkf (%build)
[  416s] 
[  416s] 
[  416s] RPM build errors:
[  416s] Bad exit status from /var/tmp/rpm-tmp.VI0Qkf (%build)
[  416s] ### VM INTERACTION START ###
[  419s] [  379.548073] sysrq: Power Off
[  419s] [  379.558306] reboot: Power down
[  420s] ### VM INTERACTION END ###
[  420s] 
[  420s] obs-arm-5 failed "build osmo-trx.spec" at Thu May 21 07:55:39 UTC 2020.
[  420s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

[tnt]

tnt has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/18247 )

Change subject: Implement ITU-T I.460 multiplex / demultiplex
..


Patch Set 9: Code-Review+1

(1 comment)

lgtm !

https://gerrit.osmocom.org/c/libosmocore/+/18247/7/tests/i460_mux/i460_mux_test.c
File tests/i460_mux/i460_mux_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/18247/7/tests/i460_mux/i460_mux_test.c@179
PS7, Line 179:  /* pull byteso out of mux (should be all 0xff) */
typo



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18247
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id522f06e73b77332b437b7a27e4966872da70eda
Gerrit-Change-Number: 18247
Gerrit-PatchSet: 9
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: tnt 
Gerrit-Comment-Date: Thu, 21 May 2020 06:37:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-abis[master]: WIP: trau_frame: New API

[laforge]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmo-abis/+/18249

to look at the new patch set (#3).

Change subject: WIP: trau_frame: New API
..

WIP: trau_frame: New API

The old TRAU frame code in src/trau_frame.c (which is for some strange
reason part of libosmo-abis, and not libosmo-trau!) was introduced more
than a decade ago for the needs of bs11_abis AKA OpenBSC aka OsmoNITB.

It is too constrained to implement TRAU frame parsing in a generic way,
including:
* no way to add support for 8k sub-slots
* no way to handle CRC bits or UFI (i.e. no AMR)
* no real API design, it was just ripped out from OsmoNITB and moved into
  a library (even the wrong one)

For those reasons, let's introduce a new API for TRAU frame
encoding/decoding - one that supports all the relevant use cases.

This is marked WIP until the part handling T-bits is properly
implemented.

Change-Id: I5cf42e6c445d9224be18503cebc7584b3beba08c
---
A include/osmocom/trau/trau_frame.h
M src/Makefile.am
A src/trau/trau_frame.c
3 files changed, 1,444 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/49/18249/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18249
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I5cf42e6c445d9224be18503cebc7584b3beba08c
Gerrit-Change-Number: 18249
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in libosmo-abis[master]: WIP: TRAU frame RTP conversion

[laforge]

laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/18382 )


Change subject: WIP: TRAU frame RTP conversion
..

WIP: TRAU frame RTP conversion

This adds code that converts codec frames between (decoded) TRAU format
and RTP payload format.  The FR + EFR functions have been lifted from
OsmoNITB.

Change-Id: I7f6993cce2b95318203043e2e14952e581941b79
---
M src/Makefile.am
A src/trau/trau_rtp_conv.c
2 files changed, 483 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/82/18382/1

diff --git a/src/Makefile.am b/src/Makefile.am
index 0134b00..4254428 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -37,6 +37,7 @@
 libosmotrau_la_LIBADD = $(COMMONLIBS) $(ORTP_LIBS)
 libosmotrau_la_SOURCES = trau/osmo_ortp.c \
 trau/trau_frame.c \
-trau/trau_sync.c
+trau/trau_sync.c \
+trau/trau_rtp_conv.c

 noinst_HEADERS = trau/ubit_buf.h
diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c
new file mode 100644
index 000..c3007ad
--- /dev/null
+++ b/src/trau/trau_rtp_conv.c
@@ -0,0 +1,481 @@
+/* TRAU frame to RTP conversion */
+
+/* (C) 2009,2020 by Harald Welte 
+ * All Rights Reserved
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see .
+ *
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include 
+
+/* this corresponds to the bit-lengths of the individual codec
+ * parameters as indicated in Table 1.1 of TS 46.010 */
+static const uint8_t gsm_fr_map[] = {
+   6, 6, 5, 5, 4, 4, 3, 3,
+   7, 2, 2, 6, 3, 3, 3, 3,
+   3, 3, 3, 3, 3, 3, 3, 3,
+   3, 7, 2, 2, 6, 3, 3, 3,
+   3, 3, 3, 3, 3, 3, 3, 3,
+   3, 3, 7, 2, 2, 6, 3, 3,
+   3, 3, 3, 3, 3, 3, 3, 3,
+   3, 3, 3, 7, 2, 2, 6, 3,
+   3, 3, 3, 3, 3, 3, 3, 3,
+   3, 3, 3, 3
+};
+
+
+/*
+ * EFR TRAU parity
+ *
+ * g(x) = x^3 + x^1 + 1
+ */
+static const struct osmo_crc8gen_code gsm0860_efr_crc3 = {
+   .bits = 3,
+   .poly = 0x3,
+   .init = 0x0,
+   .remainder = 0x7,
+};
+
+/* re-combine EFR parity bits */
+static inline void efr_parity_bits_1(ubit_t *check_bits, const ubit_t *d_bits)
+{
+   memcpy(check_bits + 0 , d_bits + 0, 22);
+   memcpy(check_bits + 22 , d_bits + 24, 3);
+   check_bits[25] = d_bits[28];
+}
+
+static inline void efr_parity_bits_2(ubit_t *check_bits, const ubit_t *d_bits)
+{
+   memcpy(check_bits + 0 , d_bits + 42, 10);
+   memcpy(check_bits + 10 , d_bits + 90, 2);
+}
+
+static inline void efr_parity_bits_3(ubit_t *check_bits, const ubit_t *d_bits)
+{
+   memcpy(check_bits + 0 , d_bits + 98, 5);
+   check_bits[5] = d_bits[104];
+   memcpy(check_bits + 6 , d_bits + 143, 2);
+}
+
+static inline void efr_parity_bits_4(ubit_t *check_bits, const ubit_t *d_bits)
+{
+   memcpy(check_bits + 0 , d_bits + 151, 10);
+   memcpy(check_bits + 10 , d_bits + 199, 2);
+}
+
+static inline void efr_parity_bits_5(ubit_t *check_bits, const ubit_t *d_bits)
+{
+   memcpy(check_bits + 0 , d_bits + 207, 5);
+   check_bits[5] = d_bits[213];
+   memcpy(check_bits + 6 , d_bits + 252, 2);
+}
+
+//static const uint8_t c_bits_check_fr[] = { 0, 0, 0, 1, 0 };
+//static const uint8_t c_bits_check_efr[] = { 1, 1, 0, 1, 0 };
+
+/*! Generate the 33 bytes RTP payload for GSM-FR from a decoded TRAU frame.
+ *  \param[out] out caller-provided output buffer
+ *  \param[in] out_len length of out buffer in bytes
+ *  \param[in] fr input TRAU frame in decoded form
+ *  \returns number of bytes generated in 'out'; negative on error. */
+int trau2rtp_fr(uint8_t *out, size_t out_len, const struct osmo_trau_frame *tf)
+{
+   int i, j, k, l, o;
+
+   if (tf->type != OSMO_TRAU16_FT_FR)
+   return -EINVAL;
+
+   /* FR Data Bits according to TS 48.060 Section 5.5.1.1.2 */
+
+   if (tf->c_bits[11]) /* BFI */
+   return 0;
+
+   if (out_len < GSM_FR_BYTES)
+   return -ENOSPC;
+
+   out[0] = 0xd << 4;
+   /* reassemble d-bits */
+   i = 0; /* counts bits */
+   j = 4; /* counts output bits */
+   k = gsm_fr_map[0]-1; /* current number bit in element */
+   l = 0; /* counts element bits */
+   o = 

Change in osmo-gsm-tester[master]: ms_srs.py: Fix typos in comments

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18383 )


Change subject: ms_srs.py: Fix typos in comments
..

ms_srs.py: Fix typos in comments

Change-Id: Iaa09ed696eb58e63c366f26e94c66f27b5f733bf
---
M src/osmo_gsm_tester/obj/ms_srs.py
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/83/18383/1

diff --git a/src/osmo_gsm_tester/obj/ms_srs.py 
b/src/osmo_gsm_tester/obj/ms_srs.py
index 4790e76..b494c54 100644
--- a/src/osmo_gsm_tester/obj/ms_srs.py
+++ b/src/osmo_gsm_tester/obj/ms_srs.py
@@ -157,7 +157,7 @@
 self.rem_host.set_remote_env({'PATCHELF_BIN': 
'/opt/bin/patchelf-v0.10' })
 self.rem_host.change_elf_rpath(remote_binary, remote_lib)

-# srsue requires CAP_SYS_ADMIN to cjump to net network namespace: 
netns(CLONE_NEWNET):
+# srsue requires CAP_SYS_ADMIN to jump to net network namespace: 
netns(CLONE_NEWNET):
 # srsue requires CAP_NET_ADMIN to create tunnel devices: 
ioctl(TUNSETIFF):
 self.log('Applying CAP_SYS_ADMIN+CAP_NET_ADMIN capability to srsue')
 self.rem_host.setcap_netsys_admin(remote_binary)
@@ -182,7 +182,7 @@
 self.log('Setting RPATH for srsue')
 util.change_elf_rpath(binary, util.prepend_library_path(lib), 
self.run_dir.new_dir('patchelf'))

-# srsue requires CAP_SYS_ADMIN to cjump to net network namespace: 
netns(CLONE_NEWNET):
+# srsue requires CAP_SYS_ADMIN to jump to net network namespace: 
netns(CLONE_NEWNET):
 # srsue requires CAP_NET_ADMIN to create tunnel devices: 
ioctl(TUNSETIFF):
 self.log('Applying CAP_SYS_ADMIN+CAP_NET_ADMIN capability to srsue')
 util.setcap_netsys_admin(binary, 
self.run_dir.new_dir('setcap_netsys_admin'))

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18383
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Iaa09ed696eb58e63c366f26e94c66f27b5f733bf
Gerrit-Change-Number: 18383
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Tumbleweed/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Tumbleweed/i586

Package network:osmocom:nightly/libosmo-sccp failed to build in 
openSUSE_Tumbleweed/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-sccp

Last lines of build log:
[   80s] libosmo-sccp.src: W: no-changelogname-tag
[   80s] libosmo-sigtran-devel.i586: W: no-changelogname-tag
[   80s] libosmo-sigtran5.i586: W: no-changelogname-tag
[   80s] libosmo-xua-devel.i586: W: no-changelogname-tag
[   80s] osmo-stp.i586: W: no-changelogname-tag
[   80s] There is no changelog. Please insert a '%changelog' section heading in 
your
[   80s] spec file and prepare your changes file using e.g. the 'osc vc' 
command.
[   80s] 
[   80s] osmo-stp.i586: W: suse-missing-rclink osmo-stp
[   80s] The package contains an init script or systemd service file but lacks 
the
[   80s] symlink /usr/sbin/rcFOO -> /usr/sbin/service
[   80s] 
[   80s] libosmo-mtp-devel.i586: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib/libmtp.a
[   80s] libosmo-sigtran-devel.i586: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib/libosmo-sigtran.a
[   80s] libosmo-sccp-devel.i586: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib/libsccp.a
[   80s] libosmo-xua-devel.i586: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib/libxua.a
[   80s] This archive does not contain a non-empty .text section.  The archive 
was not
[   80s] created with -ffat-lto-objects option.
[   80s] 
[   80s] (none): E: badness 4 exceeds threshold 1000, aborting.
[   80s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings.
[   80s] 
[   80s] ### VM INTERACTION START ###
[   83s] [   76.498323] sysrq: Power Off
[   83s] [   76.504255] reboot: Power down
[   83s] ### VM INTERACTION END ###
[   83s] 
[   83s] lamb01 failed "build libosmo-sccp.spec" at Fri May 22 01:34:49 UTC 
2020.
[   83s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Tumbleweed/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Tumbleweed/x86_64

Package network:osmocom:nightly/libosmo-sccp failed to build in 
openSUSE_Tumbleweed/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-sccp

Last lines of build log:
[   53s] libosmo-sccp.src: W: no-changelogname-tag
[   53s] libosmo-sigtran-devel.x86_64: W: no-changelogname-tag
[   53s] libosmo-sigtran5.x86_64: W: no-changelogname-tag
[   53s] libosmo-xua-devel.x86_64: W: no-changelogname-tag
[   53s] osmo-stp.x86_64: W: no-changelogname-tag
[   53s] There is no changelog. Please insert a '%changelog' section heading in 
your
[   53s] spec file and prepare your changes file using e.g. the 'osc vc' 
command.
[   53s] 
[   53s] osmo-stp.x86_64: W: suse-missing-rclink osmo-stp
[   53s] The package contains an init script or systemd service file but lacks 
the
[   53s] symlink /usr/sbin/rcFOO -> /usr/sbin/service
[   53s] 
[   53s] libosmo-mtp-devel.x86_64: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib64/libmtp.a
[   53s] libosmo-sigtran-devel.x86_64: E: lto-no-text-in-archive (Badness: 
1) /usr/lib64/libosmo-sigtran.a
[   53s] libosmo-sccp-devel.x86_64: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib64/libsccp.a
[   53s] libosmo-xua-devel.x86_64: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib64/libxua.a
[   53s] This archive does not contain a non-empty .text section.  The archive 
was not
[   53s] created with -ffat-lto-objects option.
[   53s] 
[   53s] (none): E: badness 4 exceeds threshold 1000, aborting.
[   53s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings.
[   53s] 
[   53s] ### VM INTERACTION START ###
[   56s] [   50.611339] sysrq: Power Off
[   56s] [   50.615701] reboot: Power down
[   56s] ### VM INTERACTION END ###
[   56s] 
[   56s] sheep85 failed "build libosmo-sccp.spec" at Fri May 22 01:35:33 UTC 
2020.
[   56s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Factory_ARM/aarch64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Factory_ARM/aarch64

Package network:osmocom:nightly/libosmo-sccp failed to build in 
openSUSE_Factory_ARM/aarch64

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-sccp

Last lines of build log:
[  139s] libosmo-sccp.src: W: no-changelogname-tag
[  139s] libosmo-sigtran-devel.aarch64: W: no-changelogname-tag
[  139s] libosmo-sigtran5.aarch64: W: no-changelogname-tag
[  139s] libosmo-xua-devel.aarch64: W: no-changelogname-tag
[  139s] osmo-stp.aarch64: W: no-changelogname-tag
[  139s] There is no changelog. Please insert a '%changelog' section heading in 
your
[  139s] spec file and prepare your changes file using e.g. the 'osc vc' 
command.
[  139s] 
[  139s] osmo-stp.aarch64: W: suse-missing-rclink osmo-stp
[  139s] The package contains an init script or systemd service file but lacks 
the
[  139s] symlink /usr/sbin/rcFOO -> /usr/sbin/service
[  139s] 
[  139s] libosmo-mtp-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib64/libmtp.a
[  139s] libosmo-sigtran-devel.aarch64: E: lto-no-text-in-archive (Badness: 
1) /usr/lib64/libosmo-sigtran.a
[  139s] libosmo-sccp-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib64/libsccp.a
[  139s] libosmo-xua-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib64/libxua.a
[  139s] This archive does not contain a non-empty .text section.  The archive 
was not
[  139s] created with -ffat-lto-objects option.
[  139s] 
[  139s] (none): E: badness 4 exceeds threshold 1000, aborting.
[  139s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings.
[  139s] 
[  139s] ### VM INTERACTION START ###
[  142s] [  129.883659] sysrq: Power Off
[  142s] [  129.887127] reboot: Power down
[  142s] ### VM INTERACTION END ###
[  142s] 
[  142s] obs-arm-2 failed "build libosmo-sccp.spec" at Fri May 22 01:37:44 UTC 
2020.
[  142s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ttcn3-hacks[master]: pcu: Refactor GPRS infrastructure to keep state and simplify tests

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 )

Change subject: pcu: Refactor GPRS infrastructure to keep state and simplify 
tests
..


Patch Set 5:

(24 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@78
PS5, Line 78: uint8_t
> boolean? Ideally, we should use something like "bitstring length (8.. […]
I iitially used a boolean but then had issues passing it to some lower layer 
template in RAW_PCUIF or alike because it also expected an uint8_t, so I left 
is as uint8_t. It can be moved to boolean together with lower layers later if 
we want.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@79
PS5, Line 79: PCUIF_BurstType
> Not sure if access burst type should be stored here, as you don't really need 
> to match it in the ass […]
Ack, will simply apply it when needed.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@160
PS5, Line 160: dynamic
> It also makes sense to parse both 'usf' and 'usf_granularity' here. Can be 
> done later though.
it's done for usf in later commit in the patchset. usf_granularity is TBH for 
later.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@169
PS5, Line 169: dynamic
> It also makes sense to parse both 'usf' and 'usf_granularity' here. Can be 
> done later though.
Same as above.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@204
PS5, Line 204: dl_ass
> This template is not used in this function...
ack, will check it.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@249
PS5, Line 249: ms.burst_type := BURST_TYPE_0;
> This should be kept as a parameter of the function that actually sends 
> RACH.ind to the IUT.
I will simply do this check before sending RACH.ind to send the correct 
BURST_TYPE.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@294
PS5, Line 294: tr_RLCMAC_DL_PACKET_ASS
> So by default, this function would match DL Assignment, while it can also 
> handle UL Assignment. […]
ack


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@294
PS5, Line 294: imm_ass_rlcmac
> This name is confusing as there is no RLC/MAC version of the RR Immediate 
> Assignment.
ack, should be named f_ms_rc_ass_pacch


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@299
PS5, Line 299: f_rx_rlcmac_dl_block
> Please add a TODO/FIXME here stating that we need an alt statement here.
for what exactly? I could start adding TODOs everywhere, but I won't add it 
unless there's something specific which makes sense here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@310
PS5, Line 310: Wrong TLLI
> This probably means that received assignment is not for us, and we should 
> wait for another one? At l […]
Right now we are only supporting 1 MS and checking for 1 TLLI, so the message 
is fine.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@327
PS5, Line 327: uint16_t
> Why 16 bits? Should be 8 I believe.
will check the template.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@353
PS5, Line 353: establish
> This name is confusing. […]
ok will change the name,


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@362
PS5, Line 362: uint32_t fn := 0
> template uint32_t fn := ?
no, fn=0 is fine here, iirc it's a special value meaning "next one".


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@381
PS5, Line 381: data := f_pad_oct(data, 23, '00'O); /* CS-1 */
> There must be a comment that padding only works for CS-1. […]
Indeed I know it only works for CS1, but it was always the case. I will add a 
TODO.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@405
PS5, Line 405: f_ms_tx_ul_data_block_multi
> Maybe call it f_ms_tx_rand_ul_data_blocks()? The point is that the function 
> generates payload itself […]
ACK


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@a811
PS5, Line 811: bsn := 0;
> Are you sure?
Yes it's fine, I changed the test a bit so it makes more sense from a real MS 
point of view.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@269
PS5, Line 269: f_ms_establish_ul_tbf
> U, such an overhead... […]
Come on, it was already calling f_establish_tbf, there's no much new overhead.
Let's use same infra so people can easily understand other tests once you have 
seen one.

Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Factory_ARM/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Factory_ARM/armv7l

Package network:osmocom:nightly/libosmo-sccp failed to build in 
openSUSE_Factory_ARM/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-sccp

Last lines of build log:
[  156s] libosmo-sccp.src: W: no-changelogname-tag
[  156s] libosmo-sigtran-devel.armv7hl: W: no-changelogname-tag
[  156s] libosmo-sigtran5.armv7hl: W: no-changelogname-tag
[  156s] libosmo-xua-devel.armv7hl: W: no-changelogname-tag
[  156s] osmo-stp.armv7hl: W: no-changelogname-tag
[  156s] There is no changelog. Please insert a '%changelog' section heading in 
your
[  156s] spec file and prepare your changes file using e.g. the 'osc vc' 
command.
[  156s] 
[  156s] osmo-stp.armv7hl: W: suse-missing-rclink osmo-stp
[  156s] The package contains an init script or systemd service file but lacks 
the
[  156s] symlink /usr/sbin/rcFOO -> /usr/sbin/service
[  156s] 
[  156s] libosmo-mtp-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib/libmtp.a
[  156s] libosmo-sigtran-devel.armv7hl: E: lto-no-text-in-archive (Badness: 
1) /usr/lib/libosmo-sigtran.a
[  156s] libosmo-sccp-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib/libsccp.a
[  156s] libosmo-xua-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) 
/usr/lib/libxua.a
[  156s] This archive does not contain a non-empty .text section.  The archive 
was not
[  156s] created with -ffat-lto-objects option.
[  156s] 
[  156s] (none): E: badness 4 exceeds threshold 1000, aborting.
[  156s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings.
[  157s] 
[  157s] ### VM INTERACTION START ###
[  160s] [  147.162981] sysrq: Power Off
[  160s] [  147.172424] reboot: Power down
[  160s] ### VM INTERACTION END ###
[  160s] 
[  160s] armbuild01 failed "build libosmo-sccp.spec" at Fri May 22 02:21:40 UTC 
2020.
[  160s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ttcn3-hacks[master]: pcu: Refactor GPRS infrastructure to keep state and simplify tests

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 )

Change subject: pcu: Refactor GPRS infrastructure to keep state and simplify 
tests
..


Patch Set 5:

(8 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@78
PS5, Line 78: uint8_t
> I iitially used a boolean but then had issues passing it to some lower layer 
> template in RAW_PCUIF o […]
Ah, yeah, TITAN does not support implicit boolean-integer conversion. Neither 
there are functions for that like int2bool() and bool2int(). We should just 
change the field type in PCUFI_Types to boolean with FIELDLENGTH(8). I am fine 
with doing it later, in a separate change.

On the other hand, using bitstring would simplify the things - it's easy to 
convert it to what PCUIF needs:

  type bitstring GsmRa length(8..11) with { variant "" };

  const GsmRa chan_req_def := '0000'B;

  // Just before sending RACH.ind
  var uint16_t ra := bit2int(chan_req_def);
  var uint8_t is_11bit;

  if (lengthof(chan_req_def) == 11) { is_11bit := 1 } else { is_11bit := 0 }


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@79
PS5, Line 79: PCUIF_BurstType
> Ack, will simply apply it when needed.
Thanks!


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@249
PS5, Line 249: ms.burst_type := BURST_TYPE_0;
> I will simply do this check before sending RACH.ind to send the correct 
> BURST_TYPE.
Just let the caller some freedom, there is also BURST_TYPE_2 (and even more in 
the specs).


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@327
PS5, Line 327: uint16_t
> will check the template.
Actually, template wants type integer TimingAdvance (0..219).


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@362
PS5, Line 362: uint32_t fn := 0
> no, fn=0 is fine here, iirc it's a special value meaning "next one".
Ah, right. Nevermind.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@269
PS5, Line 269: f_ms_establish_ul_tbf
> it was already calling f_establish_tbf, there's no much new overhead.

Well, f_establish_tbf() has a bit inaccurate name. Under the hood there is no 
TBF establishment, it simply sends RACH.ind, receives DATA.req on AGCH, matches 
it against tr_IMM_TBF_ASS and returns to the caller. This is exactly what's 
needed here. So there is overhead. Please keep low level API for small and 
simple test cases.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@584
PS5, Line 584: if (match(dl_block, tr_RLCMAC_DUMMY_CTRL())) {
 :  continue;
 :  }
 :  if (not match(dl_block, 
tr_RLCMAC_UL_ACK_NACK_GPRS(ul_tfi := ?)) and
 :  not match(dl_block, 
tr_RLCMAC_UL_ACK_NACK_EGPRS(ul_tfi := ?))) {
 :  setverdict(fail, "Failed to match Packet Uplink 
ACK / NACK:", dl_block);
 :  f_shutdown(__BFILE__, __LINE__);
 :  }
> Not really, I'm fixing the test since it was not behaving correctly as an MS 
> would. […]
I would prefer this to be done in a separate change, but if it's really needed 
here - let's keep it.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@609 
PS5, Line 609: f_shutdown
> I think this is fine. You want me to remove it? ok, I will remove it.
The proble is that I don't see how it's related to this patch. Feel free to do 
in a separate change with some description of its purpose.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib3fee37580f0ea0530a659dec83656799bf57288
Gerrit-Change-Number: 18370
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 22 May 2020 05:18:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-gsm-tester[master]: iperf3: Support using configuring UDP protocol

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18389 )


Change subject: iperf3: Support using configuring UDP protocol
..

iperf3: Support using configuring UDP protocol

Change-Id: I0b3545847b01ae3d029881f243fea276f0fa39de
---
M doc/examples/4g_srsLTE/suites/4g/iperf3_dl.py
M doc/examples/4g_srsLTE/suites/4g/iperf3_ul.py
M src/osmo_gsm_tester/obj/iperf3.py
A sysmocom/scenarios/cfg-iperf3-proto@.conf
M sysmocom/suites/4g/iperf3_dl.py
M sysmocom/suites/4g/iperf3_ul.py
M sysmocom/suites/gprs/lib/testlib.py
7 files changed, 82 insertions(+), 73 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/89/18389/1

diff --git a/doc/examples/4g_srsLTE/suites/4g/iperf3_dl.py 
b/doc/examples/4g_srsLTE/suites/4g/iperf3_dl.py
index d4fa649..bcc569a 100755
--- a/doc/examples/4g_srsLTE/suites/4g/iperf3_dl.py
+++ b/doc/examples/4g_srsLTE/suites/4g/iperf3_dl.py
@@ -1,17 +1,6 @@
 #!/usr/bin/env python3
 from osmo_gsm_tester.testenv import *

-def print_result_node(result, node_str):
-sent = result['end']['sum_sent']
-recv = result['end']['sum_received']
-print("Result %s:" % node_str)
-print("\tSEND: %d KB, %d kbps, %d seconds (%s retrans)" % 
(sent['bytes']/1000, sent['bits_per_second']/1000, sent['seconds'], 
str(sent.get('retransmits', 'unknown'
-print("\tRECV: %d KB, %d kbps, %d seconds" % (recv['bytes']/1000, 
recv['bits_per_second']/1000, recv['seconds']))
-
-def print_results(cli_res, srv_res):
-print_result_node(cli_res, 'client')
-print_result_node(srv_res, 'server')
-
 epc = tenv.epc()
 enb = tenv.enb()
 ue = tenv.modem()
@@ -41,7 +30,9 @@
 print("Running iperf3 client to %s through %s" % (str(iperf3cli), ue.netns()))
 proc.launch_sync()
 iperf3srv.stop()
-print_results(iperf3cli.get_results(), iperf3srv.get_results())
+
+iperf3cli.print_results()
+iperf3srv.print_results(iperf3cli.proto() == iperf3cli.PROTO_UDP)

 max_rate = enb.ue_max_rate(downlink=True)
 res_str = ue.verify_metric(max_rate * 0.8, operation='avg', metric='dl_brate', 
criterion='gt')
diff --git a/doc/examples/4g_srsLTE/suites/4g/iperf3_ul.py 
b/doc/examples/4g_srsLTE/suites/4g/iperf3_ul.py
index 64d476b..a92a658 100755
--- a/doc/examples/4g_srsLTE/suites/4g/iperf3_ul.py
+++ b/doc/examples/4g_srsLTE/suites/4g/iperf3_ul.py
@@ -1,17 +1,6 @@
 #!/usr/bin/env python3
 from osmo_gsm_tester.testenv import *

-def print_result_node(result, node_str):
-sent = result['end']['sum_sent']
-recv = result['end']['sum_received']
-print("Result %s:" % node_str)
-print("\tSEND: %d KB, %d kbps, %d seconds (%s retrans)" % 
(sent['bytes']/1000, sent['bits_per_second']/1000, sent['seconds'], 
str(sent.get('retransmits', 'unknown'
-print("\tRECV: %d KB, %d kbps, %d seconds" % (recv['bytes']/1000, 
recv['bits_per_second']/1000, recv['seconds']))
-
-def print_results(cli_res, srv_res):
-print_result_node(cli_res, 'client')
-print_result_node(srv_res, 'server')
-
 epc = tenv.epc()
 enb = tenv.enb()
 ue = tenv.modem()
@@ -41,7 +30,9 @@
 print("Running iperf3 client to %s through %s" % (str(iperf3cli), ue.netns()))
 proc.launch_sync()
 iperf3srv.stop()
-print_results(iperf3cli.get_results(), iperf3srv.get_results())
+
+iperf3cli.print_results()
+iperf3srv.print_results(iperf3cli.proto() == iperf3cli.PROTO_UDP)

 max_rate = enb.ue_max_rate(downlink=False)
 res_str = ue.verify_metric(max_rate * 0.8, operation='avg', metric='ul_brate', 
criterion='gt')
diff --git a/src/osmo_gsm_tester/obj/iperf3.py 
b/src/osmo_gsm_tester/obj/iperf3.py
index 2901e79..b7694bf 100644
--- a/src/osmo_gsm_tester/obj/iperf3.py
+++ b/src/osmo_gsm_tester/obj/iperf3.py
@@ -25,8 +25,13 @@
 from . import pcap_recorder, run_node

 def on_register_schemas():
+schema_types = {
+'iperf3_protocol': IPerf3Client.validate_protocol,
+}
+schema.register_schema_types(schema_types)
 config_schema = {
 'time': schema.DURATION,
+'protocol': 'iperf3_protocol',
 }
 schema.register_config_schema('iperf3cli', config_schema)

@@ -45,6 +50,25 @@
 log_obj.log('failed parsing iperf3 output: "%s"' % data)
 raise e

+def print_result_node_udp(result, node_str):
+try:
+sum = result['end']['sum']
+print("Result %s:" % node_str)
+print("\tSUM: %d KB, %d kbps, %d seconds %d/%d lost" % 
(sum['bytes']/1000, sum['bits_per_second']/1000, sum['seconds'], 
sum['lost_packets'], sum['packets']))
+except Exception as e:
+print("Exception while using iperf3 %s results: %r" % (node_str, 
repr(result)))
+raise e
+
+def print_result_node_tcp(result, node_str):
+try:
+sent = result['end']['sum_sent']
+recv = result['end']['sum_received']
+print("Result %s:" % node_str)
+print("\tSEND: %d KB, %d kbps, %d seconds (%s retrans)" % 
(sent['bytes']/1000, sent['bits_per_second']/1000, 

Change in osmo-gsm-tester[master]: schema: Allow objects registering their own schema types

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18388 )


Change subject: schema: Allow objects registering their own schema types
..

schema: Allow objects registering their own schema types

Change-Id: I998c8674a55531909bfeac420064c3f238cea126
---
A selftest/schema_test/schema_case_06.conf
M selftest/schema_test/schema_test.ok
M selftest/schema_test/schema_test.py
M src/osmo_gsm_tester/core/schema.py
4 files changed, 90 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/88/18388/1

diff --git a/selftest/schema_test/schema_case_06.conf 
b/selftest/schema_test/schema_case_06.conf
new file mode 100644
index 000..ea7f45f
--- /dev/null
+++ b/selftest/schema_test/schema_case_06.conf
@@ -0,0 +1,29 @@
+schema:
+  handover:
+threshold: 'uint'
+myvar: 'test_type'
+anothervar: 'another_type'
+
+tests:
+   - foobar:
+   prefix:
+ handover:
+   myvar: 'valid_value1'
+   anothervar: 'unique_val_ok'
+   threshold: 2
+   - foobar:
+   prefix:
+ handover:
+   myvar: 'valid_value2'
+   - foobar:
+   prefix:
+ handover:
+   threshold: 0
+   - foobar:
+   prefix:
+ handover:
+ myvar: 'invalid_val'
+   - foobar:
+   prefix:
+ handover:
+ anothervar: 'another_invalid_val'
diff --git a/selftest/schema_test/schema_test.ok 
b/selftest/schema_test/schema_test.ok
index 2c4cd6a..846caae 100644
--- a/selftest/schema_test/schema_test.ok
+++ b/selftest/schema_test/schema_test.ok
@@ -61,3 +61,20 @@
 --- -: ERR: ValueError: config item is a list, should be 'str': 
'foobar.prefix.hey.ho.letsgo[]'
 Validation: Error
 --
+schema_case_06.conf:
+{'foobar.prefix.handover.anothervar': 'another_type',
+ 'foobar.prefix.handover.myvar': 'test_type',
+ 'foobar.prefix.handover.threshold': 'uint'}
+validating tests[0]
+Validation: OK
+validating tests[1]
+Validation: OK
+validating tests[2]
+Validation: OK
+validating tests[3]
+--- foobar.prefix.handover.myvar: ERR: ValueError: Invalid value 'invalid_val' 
for schema type 'test_type' (validator: test_validator)
+Validation: Error
+validating tests[4]
+--- foobar.prefix.handover.anothervar: ERR: ValueError: Invalid value 
'another_invalid_val' for schema type 'another_type' (validator: )
+Validation: Error
+--
diff --git a/selftest/schema_test/schema_test.py 
b/selftest/schema_test/schema_test.py
index 3cf2799..bffa601 100755
--- a/selftest/schema_test/schema_test.py
+++ b/selftest/schema_test/schema_test.py
@@ -25,6 +25,13 @@
 li.append(f)
 return sorted(li)

+def test_validator(val):
+return val in ('valid_value1', 'valid_value2')
+
+schema.register_schema_types({'test_type': test_validator,
+  'another_type': lambda val: val == 
'unique_val_ok'})
+
+
 print(' Testing dynamically generated schemas ')
 for f in get_case_list(_prep.script_dir):
 print('%s:' % f)
diff --git a/src/osmo_gsm_tester/core/schema.py 
b/src/osmo_gsm_tester/core/schema.py
index 9055c5b..70b4c8c 100644
--- a/src/osmo_gsm_tester/core/schema.py
+++ b/src/osmo_gsm_tester/core/schema.py
@@ -36,12 +36,12 @@
 break;
 if not regex.fullmatch(val):
 break;
-return
+return True
 raise ValueError('Invalid %s: %r' % (name, val))

 def band(val):
 if val in ('GSM-900', 'GSM-1800', 'GSM-1900'):
-return
+return True
 raise ValueError('Unknown GSM band: %r' % val)

 def ipv4(val):
@@ -49,27 +49,30 @@
 els = [int(el) for el in val.split('.')]
 if not all([el >= 0 and el <= 255 for el in els]):
 raise ValueError('Invalid IPv4 address: %r' % val)
+return True

 def hwaddr(val):
-match_re('hardware address', HWADDR_RE, val)
+return match_re('hardware address', HWADDR_RE, val)

 def imsi(val):
-match_re('IMSI', IMSI_RE, val)
+return match_re('IMSI', IMSI_RE, val)

 def ki(val):
-match_re('KI', KI_RE, val)
+return match_re('KI', KI_RE, val)

 def msisdn(val):
-match_re('MSISDN', MSISDN_RE, val)
+return match_re('MSISDN', MSISDN_RE, val)

 def auth_algo(val):
 if val not in util.ENUM_OSMO_AUTH_ALGO:
 raise ValueError('Unknown Authentication Algorithm: %r' % val)
+return True

 def uint(val):
 n = int(val)
 if n < 0:
 raise ValueError('Positive value expected instead of %d' % n)
+return True

 def uint8(val):
 n = int(val)
@@ -77,6 +80,7 @@
 raise ValueError('Positive value expected instead of %d' % n)
 if n > 255: # 2^8 - 1
 raise ValueError('Value %d too big, max value is 255' % n)
+return True

 def uint16(val):
 n = int(val)
@@ -84,57 +88,64 @@
 raise ValueError('Positive value expected instead of %d' % n)
 if n > 65535: # 2^16 - 1
 

Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17718 )

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 17:25:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18387 )

Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel 
Request
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp@719
PS2, Line 719:  /* TODO: IIUC, signalling needs only one block */
> These sub-types contain nothing else but RandBits, so what am I supposed to 
> do/log here? I am still  […]
Then please at least log something here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7
Gerrit-Change-Number: 18387
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 17:25:08 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: manuals: generate vty reference xml at build time

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/18374 )

Change subject: manuals: generate vty reference xml at build time
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18374/2/doc/manuals/Makefile.am
File doc/manuals/Makefile.am:

https://gerrit.osmocom.org/c/osmo-bsc/+/18374/2/doc/manuals/Makefile.am@24
PS2, Line 24: $(top_builddir)/src/osmo-bsc/osmo-bsc
> > Are you sure that makes sense when building with -j8? […]
Then afaiu Make should already handle dependencies correctly and there's no 
need for this patch?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5dc872149154e1a949bb6a2b9bbc1461e0fc51f6
Gerrit-Change-Number: 18374
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 17:43:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18387 )

Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel 
Request
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp@719
PS2, Line 719:  /* TODO: IIUC, signalling needs only one block */
please log something here, and do something. You are returning fine but leaving 
the chan_req untouched.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7
Gerrit-Change-Number: 18387
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 15:54:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17718 )

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h
File src/gsm_rlcmac.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h@5347
PS2, Line 5347: extern struct value_string egprs_pkt_ch_req_type_names[];
> Further below, were all our encode/decode specific function are :)
Then we would also need to move EGPRS_PacketChannelRequestType_t, because it's 
not going to make to Wireshark. That would break everything, because this enum 
is needed by EGPRS_PacketChannelRequest_t. I believe git is smart enough to 
highlight this little piece of code properly in the diff, isn't it?



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 16:06:55 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: manuals: generate vty reference xml at build time

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/18374 )

Change subject: manuals: generate vty reference xml at build time
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18374/2/doc/manuals/Makefile.am
File doc/manuals/Makefile.am:

https://gerrit.osmocom.org/c/osmo-bsc/+/18374/2/doc/manuals/Makefile.am@24
PS2, Line 24: $(top_builddir)/src/osmo-bsc/osmo-bsc
> Are you sure that makes sense when building with -j8?

I think it's ok since we depend on the target binary here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5dc872149154e1a949bb6a2b9bbc1461e0fc51f6
Gerrit-Change-Number: 18374
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 17:35:08 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18385 )

Change subject: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g
..


Patch Set 1: -Code-Review

Just noticed your comment. Will do.


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4ab710ba026315301cc6970263967616401a9fc8
Gerrit-Change-Number: 18385
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 16:37:35 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18387 )

Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel 
Request
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp@719
PS2, Line 719:  /* TODO: IIUC, signalling needs only one block */
> Then please at least log something here.
That's my question, what is this magic 'something' I should log? :P
I'll update a new change assuming single block here as it seems logical to me.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7
Gerrit-Change-Number: 18387
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 19:03:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-pcu[master]: fixup: for "bts: refactor handling and parsing of RACH.ind"

[fixeria]

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18390 )


Change subject: fixup: for "bts: refactor handling and parsing of RACH.ind"
..

fixup: for "bts: refactor handling and parsing of RACH.ind"

Change-Id: I34c39fd4734b2d33a58381170e06dcbdada48b47
---
M src/pcu_l1_if.cpp
1 file changed, 7 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/90/18390/1

diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index fb07337..4439d7a 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -432,12 +432,13 @@
 /* C -> C++ adapter for direct DSP access code (e.g. osmo-bts-sysmo) */
 extern "C" int pcu_rx_rach_ind_ptcch(uint8_t trx_nr, uint8_t ts_nr, uint32_t 
fn, int16_t qta)
 {
-   struct rach_ind_params rip = {
-   trx_nr  : trx_nr,
-   ts_nr   : ts_nr,
-   rfn : fn,
-   qta : qta,
-   };
+   /* C++/G++: "non-trivial designated initializers not supported" */
+   struct rach_ind_params rip = { 0 };
+
+   rip.trx_nr = trx_nr;
+   rip.ts_nr = ts_nr;
+   rip.rfn = fn;
+   rip.qta = qta;

return BTS::main_bts()->rcv_ptcch_rach();
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18390
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I34c39fd4734b2d33a58381170e06dcbdada48b47
Gerrit-Change-Number: 18390
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18387 )

Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel 
Request
..


Patch Set 3:

(1 comment)

Does it really deserve CR-1?

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp@719
PS2, Line 719:  /* TODO: IIUC, signalling needs only one block */
> please log something here, and do something. […]
These sub-types contain nothing else but RandBits, so what am I supposed to 
do/log here? I am still trying to find whether we should allocate only one 
block for them or not.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7
Gerrit-Change-Number: 18387
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 16:32:00 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: add osmo-bsc -X: dump VTY ref XML to stdout

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/18347 )

Change subject: add osmo-bsc -X: dump VTY ref XML to stdout
..


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18347/4/src/osmo-bsc/osmo_bsc_main.c
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18347/4/src/osmo-bsc/osmo_bsc_main.c@113
PS4, Line 113: -X
Are you sure '-X' is not used anywhere else in osmo-* projects? Maybe 
introducing only the long option ('--vty-ref-xml') would be enough?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18347
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
Gerrit-Change-Number: 18347
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 21 May 2020 17:28:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Refactor GPRS infrastructure to keep state and simplify tests

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 )

Change subject: pcu: Refactor GPRS infrastructure to keep state and simplify 
tests
..


Patch Set 5: Code-Review-1

(12 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@a811
PS5, Line 811: bsn := 0;
Are you sure?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@259
PS5, Line 259: f_init_gprs_ms();
 :  ms := g_ms[0]; /* We only use first MS in this test */
I am still not happy about this approach. There is no real need to keep the MS 
state in component we're running on. All functions are supposed to accept a 
'pointer' to ms anyway. If a test case needs more than one MS... it just 
allocates an array of GprsMS, locally.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@269
PS5, Line 269: f_ms_establish_ul_tbf
U, such an overhead... This is what I was afraid of, the API is loosing 
simplicity and flexibility. We don't really want a TBF here, we don't want 
+100500 more checks, we don't even need an MS here - we just need to send 
RACH.ind and check Timing Advance in the response. Everything else is behind 
the scope of this test case.

The new API is probably fine for complex test cases, but here it just 
complicates things.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@310
PS5, Line 310: f_ms_rx_imm_ass_ccch
Same problem here, what would be the failure reason? Right, "failed to match 
Immediate Assignment". In this case, again, you're adding more (less than in 
previous test case, but still) complexity to a simple test case...


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@584
PS5, Line 584: if (match(dl_block, tr_RLCMAC_DUMMY_CTRL())) {
 :  continue;
 :  }
 :  if (not match(dl_block, 
tr_RLCMAC_UL_ACK_NACK_GPRS(ul_tfi := ?)) and
 :  not match(dl_block, 
tr_RLCMAC_UL_ACK_NACK_EGPRS(ul_tfi := ?))) {
 :  setverdict(fail, "Failed to match Packet Uplink 
ACK / NACK:", dl_block);
 :  f_shutdown(__BFILE__, __LINE__);
 :  }
This goes behind the scope of the test case.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@609
PS5, Line 609: f_shutdown
Unrelated change. AFAIR, I intentionally did not break here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@685 
PS5, Line 685: f_shutdown
Again unrelated. Please submit a separate patch, describe why it's needed and 
which problem it solves.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@700
PS5, Line 700: ms := g_ms[0]; /* We only use first MS in this test */
This is copy-pasted, again and again...


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@730
PS5, Line 730: f_shutdown
Same.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@747
PS5, Line 747: ms := g_ms[0]; /* We only use first MS in this test */
While it could be just one line: var GprsMS ms := valueof(t_GprsMS_def) or so.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@835
PS5, Line 835: TC_countdown_procedure
For this test case, the new API really does the magic. The impact is noticeable.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/PCU_Tests.ttcn@1511
PS5, Line 1511: f_TC_egprs_pkt_chan_req
Same here, we don't really need MS/TBF/... abstraction here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib3fee37580f0ea0530a659dec83656799bf57288
Gerrit-Change-Number: 18370
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 18:50:08 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: fixup: for "bts: refactor handling and parsing of RACH.ind"

[fixeria]

fixeria has abandoned this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18390 )

Change subject: fixup: for "bts: refactor handling and parsing of RACH.ind"
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18390
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I34c39fd4734b2d33a58381170e06dcbdada48b47
Gerrit-Change-Number: 18390
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: abandon

Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

[fixeria]

Hello pespin, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/18387

to look at the new patch set (#4).

Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel 
Request
..

BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7
---
M src/bts.cpp
1 file changed, 67 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/18387/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7
Gerrit-Change-Number: 18387
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

[tnt]

tnt has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/18247 )

Change subject: Implement ITU-T I.460 multiplex / demultiplex
..


Patch Set 10: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18247
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id522f06e73b77332b437b7a27e4966872da70eda
Gerrit-Change-Number: 18247
Gerrit-PatchSet: 10
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: tnt 
Gerrit-Comment-Date: Thu, 21 May 2020 16:33:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17718 )

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h
File src/gsm_rlcmac.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h@5347
PS2, Line 5347: extern struct value_string egprs_pkt_ch_req_type_names[];
> It's not even in Wireshark yet... […]
Further below, were all our encode/decode specific function are :)



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 15:55:17 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Refactor GPRS infrastructure to keep state and simplify tests

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 )

Change subject: pcu: Refactor GPRS infrastructure to keep state and simplify 
tests
..


Patch Set 5:

(16 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@78
PS5, Line 78: uint8_t
boolean? Ideally, we should use something like "bitstring length (8..11)" or a 
union of BIT8 abd BIT11 here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@79
PS5, Line 79: PCUIF_BurstType
Not sure if access burst type should be stored here, as you don't really need 
to match it in the assignment message.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@160
PS5, Line 160: dynamic
It also makes sense to parse both 'usf' and 'usf_granularity' here. Can be done 
later though.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@169
PS5, Line 169: dynamic
It also makes sense to parse both 'usf' and 'usf_granularity' here. Can be done 
later though.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@204
PS5, Line 204: dl_ass
This template is not used in this function...


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@249
PS5, Line 249: ms.burst_type := BURST_TYPE_0;
This should be kept as a parameter of the function that actually sends RACH.ind 
to the IUT.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@294
PS5, Line 294: tr_RLCMAC_DL_PACKET_ASS
So by default, this function would match DL Assignment, while it can also 
handle UL Assignment. Maybe using '?' by default would make more sense?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@294
PS5, Line 294: imm_ass_rlcmac
This name is confusing as there is no RLC/MAC version of the RR Immediate 
Assignment.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@299
PS5, Line 299: f_rx_rlcmac_dl_block
Please add a TODO/FIXME here stating that we need an alt statement here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@310
PS5, Line 310: Wrong TLLI
This probably means that received assignment is not for us, and we should wait 
for another one? At least a comment is needed here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@327
PS5, Line 327: uint16_t
Why 16 bits? Should be 8 I believe.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@334
PS5, Line 334: 871
TODO (separate change idea): use mp_trx0_arfcn here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@353
PS5, Line 353: establish
This name is confusing. Without looking at the code, I would think that it 
somehow establishes a Downlink TBF, but actually we *expect* DL TBF assignment 
here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@362
PS5, Line 362: uint32_t fn := 0
template uint32_t fn := ?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@381
PS5, Line 381: data := f_pad_oct(data, 23, '00'O); /* CS-1 */
There must be a comment that padding only works for CS-1. A payload of more 
than 23 octets would be sent unaligned.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/5/pcu/GPRS_Components.ttcn@405
PS5, Line 405: f_ms_tx_ul_data_block_multi
Maybe call it f_ms_tx_rand_ul_data_blocks()? The point is that the function 
generates payload itself, so it should be reflected in its name.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib3fee37580f0ea0530a659dec83656799bf57288
Gerrit-Change-Number: 18370
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 18:21:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17718 )

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h
File src/gsm_rlcmac.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h@5347
PS2, Line 5347: extern struct value_string egprs_pkt_ch_req_type_names[];
> Then we would also need to move EGPRS_PacketChannelRequestType_t, because 
> it's not going to make to  […]
Why isn't getting to wireshark? So nothoing of these new additions is going 
there? If everything's specific for us then it's fine keeping it as it is here 
at the end.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 16:11:13 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17718 )

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h
File src/gsm_rlcmac.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h@5347
PS2, Line 5347: extern struct value_string egprs_pkt_ch_req_type_names[];
> Why isn't getting to wireshark?

Because EGPRS_PacketChannelRequestType_t is not actually needed in Wireshark...



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 16:43:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Build failure of network:osmocom:nightly/limesuite in Debian_Unstable/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/limesuite/Debian_Unstable/x86_64

Package network:osmocom:nightly/limesuite failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly limesuite

Last lines of build log:
[  178s] SIOCSIFADDR: File exists
[  178s] dpkg-source: warning: extracting unsigned source package 
(/usr/src/packages/SOURCES/limesuite_20.01.0-1.dsc)
[  178s] dpkg-source: info: extracting limesuite in /usr/src/packages/BUILD
[  178s] dpkg-source: info: unpacking limesuite_20.01.0.orig.tar.gz
[  178s] dpkg-source: info: unpacking limesuite_20.01.0-1.debian.tar.xz
[  178s] -
[  178s] - building limesuite_20.01.0-1.dsc (user abuild)
[  178s] -
[  178s] -
[  179s] dpkg-buildpackage: warning: debian/changelog(l5): badly formatted 
trailer line
[  179s] LINE:  -- Lime Microsystems  Thu, 28 Feb 2020 
15:00:00 +0300
[  179s] dpkg-buildpackage: info: source package limesuite
[  179s] dpkg-buildpackage: info: source version 20.01.0-1
[  179s] dpkg-buildpackage: info: source distribution unstable
[  179s] dpkg-buildpackage: info: source changed by Lime Microsystems 

[  179s]  dpkg-source --before-build .
[  179s] dpkg-buildpackage: info: host architecture amd64
[  179s] dpkg-source: warning: BUILD/debian/changelog(l5): badly formatted 
trailer line
[  179s] LINE:  -- Lime Microsystems  Thu, 28 Feb 2020 
15:00:00 +0300
[  179s] dpkg-checkbuilddeps: error: Unmet build dependencies: libwxgtk3.0-dev
[  179s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; 
aborting
[  179s] dpkg-buildpackage: warning: (Use -d flag to override.)
[  179s] ### VM INTERACTION START ###
[  180s] Powering off.
[  180s] [  168.003667] reboot: Power down
[  180s] ### VM INTERACTION END ###
[  180s] 
[  180s] build77 failed "build limesuite_20.01.0-1.dsc" at Thu May 21 13:14:30 
UTC 2020.
[  180s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18384 )

Change subject: ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18384
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0cc77b4de764c7afd6416512a181c4c1610ce369
Gerrit-Change-Number: 18384
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 13:45:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Build failure of network:osmocom:latest/limesuite in Debian_Unstable/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/limesuite/Debian_Unstable/x86_64

Package network:osmocom:latest/limesuite failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest limesuite

Last lines of build log:
[  201s] SIOCSIFADDR: File exists
[  201s] dpkg-source: warning: extracting unsigned source package 
(/usr/src/packages/SOURCES/limesuite_20.01.0-1.dsc)
[  201s] dpkg-source: info: extracting limesuite in /usr/src/packages/BUILD
[  201s] dpkg-source: info: unpacking limesuite_20.01.0.orig.tar.gz
[  201s] dpkg-source: info: unpacking limesuite_20.01.0-1.debian.tar.xz
[  201s] -
[  201s] - building limesuite_20.01.0-1.dsc (user abuild)
[  201s] -
[  201s] -
[  201s] dpkg-buildpackage: warning: debian/changelog(l5): badly formatted 
trailer line
[  201s] LINE:  -- Lime Microsystems  Thu, 28 Feb 2020 
15:00:00 +0300
[  201s] dpkg-buildpackage: info: source package limesuite
[  201s] dpkg-buildpackage: info: source version 20.01.0-1
[  201s] dpkg-buildpackage: info: source distribution unstable
[  201s] dpkg-buildpackage: info: source changed by Lime Microsystems 

[  201s]  dpkg-source --before-build .
[  201s] dpkg-buildpackage: info: host architecture amd64
[  202s] dpkg-source: warning: BUILD/debian/changelog(l5): badly formatted 
trailer line
[  202s] LINE:  -- Lime Microsystems  Thu, 28 Feb 2020 
15:00:00 +0300
[  202s] dpkg-checkbuilddeps: error: Unmet build dependencies: libwxgtk3.0-dev
[  202s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; 
aborting
[  202s] dpkg-buildpackage: warning: (Use -d flag to override.)
[  202s] ### VM INTERACTION START ###
[  203s] Powering off.
[  203s] [  187.046080] reboot: Power down
[  203s] ### VM INTERACTION END ###
[  203s] 
[  203s] lamb08 failed "build limesuite_20.01.0-1.dsc" at Thu May 21 13:12:28 
UTC 2020.
[  203s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors

[fixeria]

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18384 )


Change subject: ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors
..

ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors

This change enables interpretation of backslash escapes for echo,
so the test case execution summary is always printed in color.

Change-Id: I0cc77b4de764c7afd6416512a181c4c1610ce369
---
M ttcn3-tcpdump-stop.sh
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/84/18384/1

diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh
index 1f4da3d..30d331d 100755
--- a/ttcn3-tcpdump-stop.sh
+++ b/ttcn3-tcpdump-stop.sh
@@ -22,9 +22,9 @@
 date

 if [ x"$VERDICT" = x"pass" ]; then
-   echo "\033[1;32m== $TESTCASE $VERDICT ==\033[0m"
+   echo -e "\033[1;32m== $TESTCASE $VERDICT ==\033[0m"
 else
-   echo "\033[1;31m-- $TESTCASE $VERDICT --\033[0m"
+   echo -e "\033[1;31m-- $TESTCASE $VERDICT --\033[0m"
 fi
 echo


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18384
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0cc77b4de764c7afd6416512a181c4c1610ce369
Gerrit-Change-Number: 18384
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17718 )

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
..


Patch Set 2:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 15:10:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-pcu[master]: bts: refactor handling and parsing of RACH.ind

[fixeria]

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18386 )


Change subject: bts: refactor handling and parsing of RACH.ind
..

bts: refactor handling and parsing of RACH.ind

Change-Id: I5fe7e0f51bf5c9eac073935cc4f4edd667c67c6e
---
M src/bts.cpp
M src/bts.h
M src/pcu_l1_if.cpp
M tests/tbf/TbfTest.err
4 files changed, 232 insertions(+), 264 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/86/18386/1

diff --git a/src/bts.cpp b/src/bts.cpp
index 2cf219a..934bdef 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -665,191 +665,168 @@
 }

 /* 3GPP TS 44.060:
- *   Table 11.2.5.3: PACKET CHANNEL REQUEST
- *   Table 11.2.5a.3: EGPRS PACKET CHANNEL REQUEST
- * Both GPRS and EGPRS use same MultislotClass coding, but since use of PCCCH 
is
+ *   Table 11.2.5.2: PACKET CHANNEL REQUEST
+ *   Table 11.2.5a.2: EGPRS PACKET CHANNEL REQUEST
+ * Both GPRS and EGPRS use same MultislotClass coding, but since PRACH is
  * deprecated, no PACKET CHANNEL REQUEST exists, which means for GPRS we will
  * receive CCCH RACH which doesn't contain any mslot class. Hence in the end we
- * can only receive EGPRS mslot class through 11-bit EGPRS PACKET CHANNEL
- * REQUEST.
- */
-static inline uint8_t egprs_mslot_class_from_ra(uint16_t ra, bool is_11bit)
+ * can only receive EGPRS mslot class through 11-bit EGPRS PACKET CHANNEL 
REQUEST. */
+static int parse_rach_ind(const struct rach_ind_params *rip,
+ struct chan_req_params *chan_req)
 {
-   /* EGPRS multislot class is only present in One Phase Access Request */
-   if (is_11bit && (ra >> 10) == 0x00) /* .0xx xxx.  */
-   return ((ra & 0x3e0) >> 5) + 1;
-
-   /* set EGPRS multislot class to 0 for 8-bit RACH, since we don't know 
it yet */
-   return 0;
-}
-
-static inline uint16_t priority_from_ra(uint16_t ra, bool is_11bit)
-{
-   if (is_11bit)
-   return (ra & 0x18) >> 3;
-
-   return 0;
-}
-
-static inline bool is_single_block(bool force_two_phase, uint16_t ra, enum 
ph_burst_type burst_type, bool is_11bit)
-{
-   bool sb = false;
-
-   if ((ra & 0xf8) == 0x70)
-   LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block 
allocation\n");
-   else if (force_two_phase)
-   LOGP(DRLCMAC, LOGL_DEBUG,
-"MS requests single phase access, but we force two phase 
access [RACH is %s bit]\n",
-is_11bit ? "11" : "8");
-
-   switch(burst_type) {
-   case GSM_L1_BURST_TYPE_ACCESS_0:
-   if (is_11bit) {
-   LOGP(DRLCMAC, LOGL_ERROR, "Error: GPRS 11 bit RACH not 
supported\n");
-   return false;
-   }
-
-   if ((ra & 0xf8) == 0x70)
-   return true;
-
-   if (force_two_phase)
-   return true;
-   break;
-   case GSM_L1_BURST_TYPE_ACCESS_1: /* deliberate fall-through */
-   case GSM_L1_BURST_TYPE_ACCESS_2:
-   if (is_11bit) {
-   if (!(ra & (1 << 10))) {
-   if (force_two_phase)
-   return true;
-
-   return false;
-   }
-
-   return true;
-   }
-   LOGP(DRLCMAC, LOGL_ERROR, "Unexpected RACH burst type %u for 
8-bit RACH\n", burst_type);
-   break;
+   switch (rip->burst_type) {
case GSM_L1_BURST_TYPE_NONE:
-   LOGP(DRLCMAC, LOGL_ERROR, "PCU has not received burst type from 
BTS\n");
+   LOGP(DRLCMAC, LOGL_ERROR, "RACH.ind contains no burst type, 
assuming TS0\n");
+   /* fall-through */
+   case GSM_L1_BURST_TYPE_ACCESS_0:
+   if (rip->is_11bit) { /* 11 bit Access Burst with TS0 => Packet 
Channel Request */
+   LOGP(DRLCMAC, LOGL_ERROR, "11 bit Packet Channel 
Request "
+"is not supported (PBCCH is deprecated)\n");
+   return -ENOTSUP;
+   }
+
+   /* 3GPP TS 44.018, table 9.1.8.1: 8 bit CHANNEL REQUEST.
+* Mask 01110xxx indicates single block packet access. */
+   chan_req->single_block = ((rip->ra & 0xf8) == 0x70);
+   break;
+   case GSM_L1_BURST_TYPE_ACCESS_1:
+   case GSM_L1_BURST_TYPE_ACCESS_2:
+   if (!rip->is_11bit) { /* TS1/TS2 => EGPRS Packet Channel 
Request (always 11 bit) */
+   LOGP(DRLCMAC, LOGL_ERROR, "11 bit Packet Channel 
Request "
+"is not supported (PBCCH is deprecated)\n");
+   return -ENOTSUP;
+   }
+
+   /* EGPRS multislot class is only present in One Phase Access 
Request */
+   /* FIXME: properly parse EGPRS Packet Channel Request */
+  

Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

[fixeria]

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18387 )


Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel 
Request
..

BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7
---
M src/bts.cpp
1 file changed, 67 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/18387/1

diff --git a/src/bts.cpp b/src/bts.cpp
index 934bdef..c305e22 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -671,9 +671,68 @@
  * deprecated, no PACKET CHANNEL REQUEST exists, which means for GPRS we will
  * receive CCCH RACH which doesn't contain any mslot class. Hence in the end we
  * can only receive EGPRS mslot class through 11-bit EGPRS PACKET CHANNEL 
REQUEST. */
+static int parse_egprs_pkt_ch_req(uint16_t ra11, struct chan_req_params 
*chan_req)
+{
+   EGPRS_PacketChannelRequest_t req;
+   int rc;
+
+   rc = decode_egprs_pkt_ch_req(ra11, );
+   if (rc) {
+   LOGP(DRLCMAC, LOGL_NOTICE, "Failed to decode "
+"EGPRS Packet Channel Request: rc=%d", rc);
+   return rc;
+   }
+
+   LOGP(DRLCMAC, LOGL_INFO, "Rx EGPRS Packet Channel Request: %s\n",
+get_value_string(egprs_pkt_ch_req_type_names, req.Type));
+
+   switch (req.Type) {
+   case EGPRS_PKT_CHAN_REQ_ONE_PHASE:
+   chan_req->egprs_mslot_class = req.Content.MultislotClass + 1;
+   chan_req->priority = req.Content.Priority + 1;
+   break;
+   case EGPRS_PKT_CHAN_REQ_SHORT:
+   chan_req->priority = req.Content.Priority + 1;
+   if (req.Content.NumberOfBlocks == 0)
+   chan_req->single_block = true;
+   break;
+   case EGPRS_PKT_CHAN_REQ_ONE_PHASE_RED_LATENCY:
+   chan_req->priority = req.Content.Priority + 1;
+   break;
+   /* Two phase access => single block is needed */
+   case EGPRS_PKT_CHAN_REQ_TWO_PHASE:
+   case EGPRS_PKT_CHAN_REQ_TWO_PHASE_IPA:
+   chan_req->priority = req.Content.Priority + 1;
+   chan_req->single_block = true;
+   break;
+
+   /* Neither unacknowledged RLC mode, nor emergency calls are supported */
+   case EGPRS_PKT_CHAN_REQ_ONE_PHASE_UNACK:
+   case EGPRS_PKT_CHAN_REQ_EMERGENCY_CALL:
+   LOGP(DRLCMAC, LOGL_NOTICE, "%s is not supported, rejecting\n",
+get_value_string(egprs_pkt_ch_req_type_names, req.Type));
+   return -ENOTSUP;
+
+   case EGPRS_PKT_CHAN_REQ_SIGNALLING:
+   case EGPRS_PKT_CHAN_REQ_SIGNALLING_IPA:
+   case EGPRS_PKT_CHAN_REQ_DEDICATED_CHANNEL:
+   /* TODO: IIUC, signalling needs only one block */
+   break;
+
+   default:
+   LOGP(DRLCMAC, LOGL_ERROR, "Unknown EGPRS Packet Channel Request 
"
+"type=0x%02x, probably a bug in CSN.1 codec\n", req.Type);
+   return -EINVAL;
+   }
+
+   return 0;
+}
+
 static int parse_rach_ind(const struct rach_ind_params *rip,
  struct chan_req_params *chan_req)
 {
+   int rc;
+
switch (rip->burst_type) {
case GSM_L1_BURST_TYPE_NONE:
LOGP(DRLCMAC, LOGL_ERROR, "RACH.ind contains no burst type, 
assuming TS0\n");
@@ -697,10 +756,9 @@
return -ENOTSUP;
}

-   /* EGPRS multislot class is only present in One Phase Access 
Request */
-   /* FIXME: properly parse EGPRS Packet Channel Request */
-   if ((rip->ra >> 10) == 0x00) /* .0xx xxx.  */
-   chan_req->egprs_mslot_class = ((rip->ra & 0x3e0) >> 5) 
+ 1;
+   rc = parse_egprs_pkt_ch_req(rip->ra, chan_req);
+   if (rc)
+   return rc;
break;
default:
LOGP(DRLCMAC, LOGL_ERROR, "RACH.ind contains unknown burst type 
0x%02x "
@@ -766,6 +824,11 @@
chan_req.single_block = true;
}

+   /* TODO: handle Radio Priority (see 3GPP TS 44.060, table 11.2.5a.5) */
+   if (chan_req.priority > 0)
+   LOGP(DRLCMAC, LOGL_NOTICE, "EGPRS Packet Channel Request 
indicates "
+"Radio Priority %u, however we ignore it\n", 
chan_req.priority);
+
/* Should we allocate a single block or an Uplink TBF? */
if (chan_req.single_block) {
rc = sba()->alloc(_no, _no, _fn, ta);

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7
Gerrit-Change-Number: 18387
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 

Change in osmo-pcu[master]: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g

[fixeria]

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18385 )


Change subject: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g
..

l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g

Change-Id: I4ab710ba026315301cc6970263967616401a9fc8
---
M src/osmo-bts-litecell15/lc15_l1_if.c
M src/osmo-bts-oc2g/oc2g_l1_if.c
M src/osmo-bts-sysmo/sysmo_l1_if.c
M src/pcu_l1_if.cpp
M src/pcu_l1_if.h
5 files changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/85/18385/1

diff --git a/src/osmo-bts-litecell15/lc15_l1_if.c 
b/src/osmo-bts-litecell15/lc15_l1_if.c
index 24eb0fa..0fcd7cf 100644
--- a/src/osmo-bts-litecell15/lc15_l1_if.c
+++ b/src/osmo-bts-litecell15/lc15_l1_if.c
@@ -254,7 +254,7 @@
  qta2ta(ra_ind->measParam.i16BurstTiming), 
true);
break;
case GsmL1_Sapi_Ptcch:
-   pcu_rx_rach_ind_pdtch(fl1h->trx_no, ra_ind->u8Tn, ra_ind->u32Fn,
+   pcu_rx_rach_ind_ptcch(fl1h->trx_no, ra_ind->u8Tn, ra_ind->u32Fn,
  ra_ind->measParam.i16BurstTiming);
break;
default:
diff --git a/src/osmo-bts-oc2g/oc2g_l1_if.c b/src/osmo-bts-oc2g/oc2g_l1_if.c
index 11fecba..6c1e0f8 100644
--- a/src/osmo-bts-oc2g/oc2g_l1_if.c
+++ b/src/osmo-bts-oc2g/oc2g_l1_if.c
@@ -253,7 +253,7 @@
  qta2ta(ra_ind->measParam.i16BurstTiming), 
true);
break;
case GsmL1_Sapi_Ptcch:
-   pcu_rx_rach_ind_pdtch(fl1h->trx_no, ra_ind->u8Tn, ra_ind->u32Fn,
+   pcu_rx_rach_ind_ptcch(fl1h->trx_no, ra_ind->u8Tn, ra_ind->u32Fn,
  ra_ind->measParam.i16BurstTiming);
break;
default:
diff --git a/src/osmo-bts-sysmo/sysmo_l1_if.c b/src/osmo-bts-sysmo/sysmo_l1_if.c
index 751629c..5e743db 100644
--- a/src/osmo-bts-sysmo/sysmo_l1_if.c
+++ b/src/osmo-bts-sysmo/sysmo_l1_if.c
@@ -243,7 +243,7 @@
  qta2ta(ra_ind->measParam.i16BurstTiming), 
true);
break;
case GsmL1_Sapi_Ptcch:
-   pcu_rx_rach_ind_pdtch(fl1h->trx_no, ra_ind->u8Tn, ra_ind->u32Fn,
+   pcu_rx_rach_ind_ptcch(fl1h->trx_no, ra_ind->u8Tn, ra_ind->u32Fn,
  ra_ind->measParam.i16BurstTiming);
break;
default:
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 30d22bd..977a519 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -430,7 +430,7 @@
 }

 /* C -> C++ adapter for direct DSP access code (e.g. osmo-bts-sysmo) */
-extern "C" int pcu_rx_rach_ind_pdtch(uint8_t trx_nr, uint8_t ts_nr, uint32_t 
fn, int16_t qta)
+extern "C" int pcu_rx_rach_ind_ptcch(uint8_t trx_nr, uint8_t ts_nr, uint32_t 
fn, int16_t qta)
 {
return BTS::main_bts()->rcv_ptcch_rach(trx_nr, ts_nr, fn, qta);
 }
diff --git a/src/pcu_l1_if.h b/src/pcu_l1_if.h
index 35643da..f86e708 100644
--- a/src/pcu_l1_if.h
+++ b/src/pcu_l1_if.h
@@ -178,7 +178,7 @@
 int pcu_rx_rts_req_ptcch(uint8_t trx, uint8_t ts,
uint32_t fn, uint8_t block_nr);

-int pcu_rx_rach_ind_pdtch(uint8_t trx_nr, uint8_t ts_nr, uint32_t fn, int16_t 
qta);
+int pcu_rx_rach_ind_ptcch(uint8_t trx_nr, uint8_t ts_nr, uint32_t fn, int16_t 
qta);
 int pcu_rx_data_ind_pdtch(uint8_t trx, uint8_t ts, uint8_t *data,
uint8_t len, uint32_t fn, struct pcu_l1_meas *meas);


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4ab710ba026315301cc6970263967616401a9fc8
Gerrit-Change-Number: 18385
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in osmo-pcu[master]: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18385 )

Change subject: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g
..


Patch Set 1: Code-Review+1

May be worth describing this is actually not a functional change, because 
overloading features were still picking the correct function.


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4ab710ba026315301cc6970263967616401a9fc8
Gerrit-Change-Number: 18385
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 15:22:44 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17718 )

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h
File src/gsm_rlcmac.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h@5347
PS2, Line 5347: extern struct value_string egprs_pkt_ch_req_type_names[];
Please avoid mixing our stuff from stuff shared with wireshark, so it's easier 
to spot differences over time.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 15:28:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request

[fixeria]

Hello pespin, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/17718

to look at the new patch set (#3).

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
..

RLC/MAC: implement decoding of EGPRS Packet Channel Request

According to 3GPP TS 44.004, section 7.4a, two alternative RACH block
formats are specified: 8 bit (1 octet) and 11 bit. This change adds
CSN.1 definitions for 11 bit EGPRS Packet Channel Request as per
3GPP TS 44.060, table 11.2.5a.2.

Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Related: OS#1548
---
M src/gsm_rlcmac.c
M src/gsm_rlcmac.h
M tests/rlcmac/RLCMACTest.cpp
M tests/rlcmac/RLCMACTest.err
M tests/rlcmac/RLCMACTest.ok
5 files changed, 222 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/18/17718/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17718 )

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h
File src/gsm_rlcmac.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h@5347
PS2, Line 5347: extern struct value_string egprs_pkt_ch_req_type_names[];
> Please avoid mixing our stuff from stuff shared with wireshark, so it's 
> easier to spot differences o […]
It's not even in Wireshark yet... Where am I supposed to place this declaration?



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 15:33:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-pcu[master]: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18385 )

Change subject: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4ab710ba026315301cc6970263967616401a9fc8
Gerrit-Change-Number: 18385
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 21 May 2020 15:34:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment