Change in osmo-ttcn3-hacks[master]: regen-makefile.sh: add link to related Debian bug in comment

2018-12-11 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12239 ) Change subject: regen-makefile.sh: add link to related Debian bug in comment .. regen-makefile.sh: add link to related Debian bug in comment

Change in osmo-ttcn3-hacks[master]: WIP: MSC_Tests: Add SGs testcases

2018-12-11 Thread dexter
dexter has uploaded a new patch set (#16) to the change originally created by Harald Welte. ( https://gerrit.osmocom.org/11488 ) Change subject: WIP: MSC_Tests: Add SGs testcases .. WIP: MSC_Tests: Add SGs testcases This

Change in osmo-ttcn3-hacks[master]: Remove -Wall for autogenerated code

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12241 ) Change subject: Remove -Wall for autogenerated code .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12241

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

2018-12-11 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12242 Change subject: remove pointless declaration of struct gsm_network .. remove pointless declaration of struct gsm_network Stop passing a

Change in osmo-pcu[master]: cosmetic: move bit counter outside of egprs_window_size()

2018-12-11 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12247 Change subject: cosmetic: move bit counter outside of egprs_window_size() .. cosmetic: move bit counter outside of egprs_window_size() As a

Change in osmo-pcu[master]: cosmetic: use const pointer for bts_data

2018-12-11 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12246 Change subject: cosmetic: use const pointer for bts_data .. cosmetic: use const pointer for bts_data It's used several time for logging so let's call

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12245 ) Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg .. Patch Set 2: Code-Review-1 (6 comments)

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

2018-12-11 Thread osmith
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/12245 ) Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg .. LMSDevice: make use of dev-args in osmo-trx.cfg Allow selecting a specific

Change in osmo-ttcn3-hacks[master]: MGCP: remove commented variants

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12238 ) Change subject: MGCP: remove commented variants .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12238 To

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12237 ) Change subject: MGCP: fix pattern warning .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12237 To

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12237 ) Change subject: MGCP: fix pattern warning .. Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/12237 To

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has removed a vote on this change. Change subject: MGCP: fix pattern warning .. Removed Code-Review-1 by Pau Espin Pedrol -- To view, visit https://gerrit.osmocom.org/12237 To unsubscribe, or for help writing

Change in osmo-trx[master]: tests: rename convolve_test -> ConvolveTest

2018-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12244 Change subject: tests: rename convolve_test -> ConvolveTest .. tests: rename convolve_test -> ConvolveTest Make the test's name consistent with all

Change in osmo-bsc[master]: bsc: dtap: Set subscr log context

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12255 Change subject: bsc: dtap: Set subscr log context .. bsc: dtap: Set subscr log context Change-Id:

Change in osmo-bsc[master]: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12250 Change subject: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet .. VTY: Allow logging filter imsi statements for

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12256 Change subject: bsc: bssap: Set subscr log context during paging .. bsc: bssap: Set subscr log context during paging Change-Id:

Change in osmo-trx[master]: tests: rename convolve_test -> ConvolveTest

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12244 ) Change subject: tests: rename convolve_test -> ConvolveTest .. Patch Set 1: Code-Review-1 > hmm, the others are *.cpp files and this is

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-11 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12243 Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. make gsup ipa name configurable in osmo-sgsn.cfg Add a 'ipa-name' VTY

Change in docker-playground[master]: osmo-msc: set bind ip for SGs-interface

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12248 ) Change subject: osmo-msc: set bind ip for SGs-interface .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

2018-12-11 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12242 ) Change subject: remove pointless declaration of struct gsm_network .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

2018-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12245 Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg .. LMSDevice: make use of dev-args in osmo-trx.cfg Allow selecting a specific

Change in osmo-trx[master]: tests: rename convolve_test -> ConvolveTest

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12244 ) Change subject: tests: rename convolve_test -> ConvolveTest .. Patch Set 1: Code-Review-1 hmm, the others are *.cpp files and this is a

Change in docker-playground[master]: osmo-msc: set bind ip for SGs-interface

2018-12-11 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12248 Change subject: osmo-msc: set bind ip for SGs-interface .. osmo-msc: set bind ip for SGs-interface By default the SGs interface binds on 127.0.0.1

Change in osmo-msc[master]: fix regression: mgcp FSM: accept Assignment Complete early

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12257 Change subject: fix regression: mgcp FSM: accept Assignment Complete early .. fix regression: mgcp FSM: accept Assignment Complete early In

Change in osmo-bsc[master]: bsc: Set subscr log context during complete_layer3

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12253 Change subject: bsc: Set subscr log context during complete_layer3 .. bsc: Set subscr log context during complete_layer3 Change-Id:

Change in osmo-bsc[master]: paging: fix whitespace

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12249 Change subject: paging: fix whitespace .. paging: fix whitespace Change-Id: I81c4a9f0dbd708df27a485ef764c9524a36d548a --- M

Change in osmo-bsc[master]: bsc_main: filter_fn: Compare imsi values instead of subscr pointers

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12252 Change subject: bsc_main: filter_fn: Compare imsi values instead of subscr pointers .. bsc_main: filter_fn: Compare imsi values instead

Change in osmo-bsc[master]: bsc: rsl: Set subscr log context during meas report

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12254 Change subject: bsc: rsl: Set subscr log context during meas report .. bsc: rsl: Set subscr log context during meas report Change-Id:

Change in osmo-bsc[master]: paging: Properly enclose logging imsi filter scope

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12251 Change subject: paging: Properly enclose logging imsi filter scope .. paging: Properly enclose logging imsi filter scope Otherwise all

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7408

2018-12-11 Thread jenkins
See -- [...truncated 24.06 KB...] CC bits.lo CC bitcomp.lo CC

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12256 to look at the new patch set (#2). Change subject: bsc: bssap: Set subscr log context during paging .. bsc: bssap:

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12256 ) Change subject: bsc: bssap: Set subscr log context during paging .. Patch Set 2: Code-Review+2 Adding +2 myself since I fixed the

Jenkins build is back to normal : master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7409

2018-12-11 Thread jenkins
See

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. Patch Set 1: (1 comment)

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12258 ) Change subject: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling .. trx_toolkit/ctrl_if_bb.py: fix SETTA command handling

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. trx_toolkit/ctrl_if_*.py: transparently pass

Change in osmocom-bb[master]: trx_toolkit/ctrl_if.py: read data from socket in handle_rx()

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12260 ) Change subject: trx_toolkit/ctrl_if.py: read data from socket in handle_rx() .. trx_toolkit/ctrl_if.py: read data from socket in

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add optional legacy message coding flag

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12262 ) Change subject: trx_toolkit/data_if.py: add optional legacy message coding flag .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12250 ) Change subject: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet .. VTY: Allow logging filter imsi

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12256 ) Change subject: bsc: bssap: Set subscr log context during paging .. bsc: bssap: Set subscr log context during paging Change-Id:

Change in osmo-bsc[master]: bsc: rsl: Set subscr log context during meas report

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12254 ) Change subject: bsc: rsl: Set subscr log context during meas report .. bsc: rsl: Set subscr log context during meas report

Change in osmo-bsc[master]: bsc: Set subscr log context during complete_layer3

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12253 ) Change subject: bsc: Set subscr log context during complete_layer3 .. bsc: Set subscr log context during complete_layer3

Change in osmo-bsc[master]: paging: Properly enclose logging imsi filter scope

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12251 ) Change subject: paging: Properly enclose logging imsi filter scope .. paging: Properly enclose logging imsi filter scope

Change in osmo-bsc[master]: bsc_main: filter_fn: Compare imsi values instead of subscr pointers

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12252 ) Change subject: bsc_main: filter_fn: Compare imsi values instead of subscr pointers .. bsc_main: filter_fn: Compare imsi values

Change in osmo-bsc[master]: bsc: dtap: Set subscr log context

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12255 ) Change subject: bsc: dtap: Set subscr log context .. bsc: dtap: Set subscr log context Change-Id:

Change in osmo-bsc[master]: paging: fix whitespace

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12249 ) Change subject: paging: fix whitespace .. paging: fix whitespace Change-Id: I81c4a9f0dbd708df27a485ef764c9524a36d548a --- M

Change in osmo-mgw[master]: check_rtp: on IP:port errors, log the IP and port

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12265 Change subject: check_rtp: on IP:port errors, log the IP and port .. check_rtp: on IP:port errors, log the IP and port Half of those are

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12258 ) Change subject: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add message parsing methods

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12261 ) Change subject: trx_toolkit/data_if.py: add message parsing methods .. trx_toolkit/data_if.py: add message parsing methods This

Change in osmo-ttcn3-hacks[master]: MGCP: remove commented variants

2018-12-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12238 ) Change subject: MGCP: remove commented variants .. MGCP: remove commented variants It's unclear why those variants were commented -

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add message parsing methods

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12261 ) Change subject: trx_toolkit/data_if.py: add message parsing methods .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: move ASS-COMPL MGCP handling out of a_iface_bssap.c

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12201 ) Change subject: move ASS-COMPL MGCP handling out of a_iface_bssap.c .. Patch Set 3: (1 comment) This patch was reverted in

Change in osmo-bsc[master]: paging: Properly enclose logging imsi filter scope

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12251 ) Change subject: paging: Properly enclose logging imsi filter scope .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12250 ) Change subject: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add optional legacy message coding flag

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12262 ) Change subject: trx_toolkit/data_if.py: add optional legacy message coding flag .. Patch Set 1: (1 comment)

Change in docker-playground[master]: osmo-msc: set bind ip for SGs-interface

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12248 ) Change subject: osmo-msc: set bind ip for SGs-interface .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: jenkins: always enable -Werror

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12263 Change subject: jenkins: always enable -Werror .. jenkins: always enable -Werror Change-Id: If7cf70641114482b42b36489ec8562e5c069825b --- M

Change in osmo-bsc[master]: paging: fix whitespace

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12249 ) Change subject: paging: fix whitespace .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12249 To unsubscribe, or

Change in osmo-bsc[master]: bsc: Set subscr log context during complete_layer3

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12253 ) Change subject: bsc: Set subscr log context during complete_layer3 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12256 ) Change subject: bsc: bssap: Set subscr log context during paging .. Patch Set 1: (1 comment) cosmetic issue, otherwise fine with me.

Change in osmo-msc[master]: log: by default start with all categories on LOGL_NOTICE

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12267 Change subject: log: by default start with all categories on LOGL_NOTICE .. log: by default start with all categories on LOGL_NOTICE They

Change in libosmocore[master]: add to osmo_sock_get_name*() API

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12268 Change subject: add to osmo_sock_get_name*() API .. add to osmo_sock_get_name*() API Basically, I am applying code review that I would have

Change in osmo-mgw[master]: drop/replace very weird logging in mgcp_client.c

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12269 Change subject: drop/replace very weird logging in mgcp_client.c .. drop/replace very weird logging in mgcp_client.c mgcp_do_write() is the

Change in osmo-mgw[master]: mgcp_client: logging tweaks

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12270 Change subject: mgcp_client: logging tweaks .. mgcp_client: logging tweaks Fix typos, use osmo_sock_get_name2() to show the tx source and

Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12266 Change subject: vty: show subscriber: put() before printing the use count .. vty: show subscriber: put() before printing the use count Do

Change in osmo-msc[master]: LU: do not always invoke sub_pres_vlr_fsm_start()

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12233 ) Change subject: LU: do not always invoke sub_pres_vlr_fsm_start() .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: tweak comment to indicate sub_pres_vlr fsm as dead code

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12234 ) Change subject: tweak comment to indicate sub_pres_vlr fsm as dead code .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2018-12-11 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12237 Change subject: MGCP: fix pattern warning .. MGCP: fix pattern warning Remove implied \r to fix following warnings: "Duplicate character `\r' in the

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10185 to look at the new patch set (#5). Change subject: port arfcn range encode support from osmo-bsc

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

2018-12-11 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12226 ) Change subject: Add tests for IMSI ACLs .. Patch Set 5: (1 comment) Please keep comments constructive and actionable - things like "super ugly"

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12177 ) Change subject: make gsup ipa name configurable in osmo-msc.cfg .. Patch Set 6: Code-Review+2 (2 comments) nice! maybe fix that space

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11751 ) Change subject: GSUP/SMS: introduce READY-FOR-SM message .. Patch Set 5: Code-Review+1 -- To view, visit

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

2018-12-11 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12226 to look at the new patch set (#4). Change subject: Add tests for IMSI ACLs .. Add tests for IMSI ACLs Change-Id:

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

2018-12-11 Thread Max
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12227 to look at the new patch set (#4). Change subject: ACL: integrate sanitize check into sgsn_acl_* functions

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

2018-12-11 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12221 ) Change subject: Use explicit parameter for sgsn_auth_init() .. Patch Set 2: > Patch Set 2: Code-Review+1 > > Can you provide some patches to get rid

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12236 ) Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-ttcn3-hacks[master]: MGCP: remove commented variants

2018-12-11 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12238 Change subject: MGCP: remove commented variants .. MGCP: remove commented variants It's unclear why those variants were commented - looks like

Change in osmo-bsc[master]: Add VTY option to avoid sending empty Full BCCH Info for disabled SI

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12133 ) Change subject: Add VTY option to avoid sending empty Full BCCH Info for disabled SI .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12221 ) Change subject: Use explicit parameter for sgsn_auth_init() .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

2018-12-11 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12226 to look at the new patch set (#5). Change subject: Add tests for IMSI ACLs .. Add tests for IMSI ACLs Change-Id:

Change in docker-playground[master]: cosmetic: gerrit: use variables for the files to patch

2018-12-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12205 ) Change subject: cosmetic: gerrit: use variables for the files to patch .. Patch Set 2: Verified+1 -- To view, visit

Change in docker-playground[master]: cosmetic: gerrit: use variables for the files to patch

2018-12-11 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/12205 ) Change subject: cosmetic: gerrit: use variables for the files to patch .. cosmetic: gerrit: use variables for the files to patch Make the

Change in docker-playground[master]: gerrit: fix libopenid path

2018-12-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12204 ) Change subject: gerrit: fix libopenid path .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/12204 To unsubscribe, or for

Change in docker-playground[master]: gerrit: fix libopenid path

2018-12-11 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/12204 ) Change subject: gerrit: fix libopenid path .. gerrit: fix libopenid path Update the path to libopenid.jar, to fix the following error and

Change in osmo-msc[master]: detach cancelled subscribers from VLR

2018-12-11 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12232 ) Change subject: detach cancelled subscribers from VLR .. detach cancelled subscribers from VLR When a subscriber is cancelled,

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add message parsing methods

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12261 Change subject: trx_toolkit/data_if.py: add message parsing methods .. trx_toolkit/data_if.py: add message parsing methods This change

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add optional legacy message coding flag

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12262 Change subject: trx_toolkit/data_if.py: add optional legacy message coding flag .. trx_toolkit/data_if.py: add optional legacy message

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12258 Change subject: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling .. trx_toolkit/ctrl_if_bb.py: fix SETTA command handling Since

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12259 Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. trx_toolkit/ctrl_if_*.py: transparently pass UDPLink

Change in osmocom-bb[master]: trx_toolkit/ctrl_if.py: read data from socket in handle_rx()

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12260 Change subject: trx_toolkit/ctrl_if.py: read data from socket in handle_rx() .. trx_toolkit/ctrl_if.py: read data from socket in

Change in osmocom-bb[master]: trx_toolkit/ctrl_if.py: read data from socket in handle_rx()

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12260 ) Change subject: trx_toolkit/ctrl_if.py: read data from socket in handle_rx() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: fix regression: mgcp FSM: accept Assignment Complete early

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/12257 ) Change subject: fix regression: mgcp FSM: accept Assignment Complete early .. Abandoned reverted original patch instead -- To view, visit

Change in osmo-bsc[master]: bsc_main: filter_fn: Compare imsi values instead of subscr pointers

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12252 ) Change subject: bsc_main: filter_fn: Compare imsi values instead of subscr pointers .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: bsc: dtap: Set subscr log context

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12255 ) Change subject: bsc: dtap: Set subscr log context .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12255 To

Change in osmo-bsc[master]: bsc: rsl: Set subscr log context during meas report

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12254 ) Change subject: bsc: rsl: Set subscr log context during meas report .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12236 ) Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI .. Patch Set 1: Code-Review+1 -- To view, visit

  1   2   >