Re: perl script question

2000-08-31 Thread Kevin Turner
On Wed, Aug 30, 2000 at 05:16:48PM -0500, Michael J. Hammel wrote: Is there a way to open an image in Gimp Perl and run filters on it without opening a Canvas window? IIRC, you don't get a canvas window when you call image_new unless you deliberately create a new display (that's a seperate

Code cleanup

2000-08-31 Thread Maurits Rijk
I just had a look at the code of some of the plug-ins and I noticed that there is often lot's of room for improvement: 1) some constructions are plain clumsy, for example somewhere I saw: for (k = 0; k bytes; k++) destline++; instead of simply: destline += bytes; 2) a lot

Re: Code cleanup

2000-08-31 Thread Austin Donnelly
On Thursday, 31 Aug 2000, Maurits Rijk wrote: 3) sometimes it's just lack of C knowledge: if (p) free(p); can be simply replaced by just: free(p); I would not assume that it is safe to free() a NULL pointer in _all_ vendor's libc implementations. That's why

Re: Code cleanup

2000-08-31 Thread Maurits Rijk
Federico Mena Quintero wrote: snip 3) sometimes it's just lack of C knowledge: if (p) free(p); can be simply replaced by just: free(p); If p is a null pointer then "free (p)" may (and should!) crash. You are incorrect here. Hm. According to most (all?)

Re: Code cleanup

2000-08-31 Thread David Odin
On Thu, Aug 31, 2000 at 03:48:37PM -0400, Federico Mena Quintero wrote: Maurits Rijk [EMAIL PROTECTED] writes: [ ... ] 3) sometimes it's just lack of C knowledge: if (p) free(p); can be simply replaced by just: free(p); If p is a null pointer then "free

Plugins - what they can and cannot do.

2000-08-31 Thread david rohde
I was recently looking at the possibility of a gimp tile editor. After looking in to it I have found that this is really quite difficult to do with the plugin api. As far as I can see it would be possible but at the user end it would be messy. The plugin would have to create a new canvas,

Re: Code cleanup

2000-08-31 Thread Marc Lehmann
On Thu, Aug 31, 2000 at 09:22:56PM +0200, Mail Delivery System [EMAIL PROTECTED] wrote: if (p) free(p); I would not assume that it is safe to free() a NULL pointer in _all_ True. OTOH, this has been an internationally accepted standard since 11 years. The question is

Re: Plugins - what they can and cannot do.

2000-08-31 Thread pixel fairy
tile editor? you so you can make seamles tiles? (im guessing here, dont know what you mean by tile editor) maybe just make a plug in that displays the drawable(s) in an offset view. of course you would have to have an update button or poll the image regularly or something silly like that (which

Re: Code cleanup

2000-08-31 Thread Nick Lamb
On Thu, Aug 31, 2000 at 03:48:37PM -0400, Federico Mena Quintero wrote: If p is a null pointer then "free (p)" may (and should!) crash. You are incorrect here. sigh You are completely wrong, see KR's treatment of ANSI C Standard Library, Section B6 void free(void *p) free deallocates the

Re: Code cleanup

2000-08-31 Thread Garry R. Osgood
Maurits Rijk wrote: I just had a look at the code of some of the plug-ins and I noticed that there is often lot's of room for improvement: Yep. snipped... So my question: is it worth the effort to carefully go through all the code (not only plug-ins) and clean things up? Worth relates to

minor terminology clarification

2000-08-31 Thread Michael J. Hammel
I've been under the assumption that the term "image window" was changed to "Canvas window" for 1.2. If this is true, the Preferences dialog needs to be updated, as there are a few places where it refers to "Image Windows". I haven't checked if there are other places with similar issues.