Re: Request To Revert Curve Tool
After some offline discussion with Garry, we have jointly agreed to propose the following (my wording, don't blame him): The curves and levels tools should reset when called, and this behaviour should be reinstated before 1.2. The reasons are as follows: * consistency with all other colour tools. * both tools allow the user to save and load settings, so users can still apply the same effect to multiple images. * the reset button only resets a single channel, so manually resetting the tool is not as simple as it should be. * a common scheme for loading / saving / repeating settings would be useful, but should be implemented across all (appropriate) tools (and cannot be done for 1.2). Comments? (Dons asbestos suit, cowers and waits.) -- David Hodson -- [EMAIL PROTECTED] -- this night wounds time
Re: Request To Revert Curve Tool
"Garry R. Osgood" wrote: Here is what I propose: 1. There is now a "latency" bug where, when the curve tool is brought up with a non-identity transform, it is not immediately applied (when preview is on) - yes, this is indeed easily fixable. Although if we reset, it doesn't matter ... 2. Among the interactive tools, the curve tool has a now-activated and unique "persistence" feature that some people like and others don't. In the course of fixing 1., I propose adding a "Persist?" setting. Or perhaps OK / Apply / Cancel buttons? "Go back to last applied setting" button? Is this a reasonable course? Yes it is, but then we would want to change all the other tools to be consistent. I don't know about you, but I'm getting sick of waiting for 1.2! My suggestion is: reset the sucker, in line with all the other tools, and think about introducing a streamined and consistent method for saving "favourite" parameter settings for tools (and plugins!) in 1.3. Anything else would be running awfully close to adding new features, and we wouldn't want to do that. So, who decides? -- David Hodson -- [EMAIL PROTECTED] -- this night wounds time
Re: Request To Revert Curve Tool
"Garry R. Osgood" wrote: Well, after two weeks of trying the new behaviour, I find myself not liking it and request that the initial range transform from old to new just be the identity transform, as it was before. I'm not in front of my Linux box right now, and I was changing the levels and curves tools at the same time, so these comments may apply to either or both, I'm not sure ... The reason I made the change is that: * the tool (one of them, at least) _did_ actually keep the old settings, it just didn't display the parameters correctly; and * the reset button is right there, if you need it. I also figured that it's easier to reset if you don't want the old settings, than it is to find them again if you do. The bug report specifically talked about applying the same transform to multiple images, so at least one person uses that facility. -- David Hodson -- [EMAIL PROTECTED] -- this night wounds time
Re: Request To Revert Curve Tool
David Hodson wrote: The reason I made the change is that: * the tool (one of them, at least) _did_ actually keep the old settings, [The curve tool ], it just didn't display the parameters correctly; and * the reset button is right there, if you need it. True, almost -- never displayed nor applied parameters initially. A "feature-in-waiting" I think, I also figured that it's easier to reset if you don't want the old settings, than it is to find them again if you do. Also true. The bug report specifically talked about applying the same transform to multiple images, so at least one person uses that facility. This, I gather, is Cooper [EMAIL PROTECTED], his first point in #33399. The change certain makes that workflow easier to perform (See http://bugs.gnome.org/db/33/33399.html). I certainly glad you've done the spadework (Thank you, again, David) and your interpretation of what to do is certainly reasonable, but I now find the tool less facile for my work, where I really *don't* like a setting that I've "disposed" of suddenly come back to life, and now have to explicitly reset it away. Here is what I propose: 1. There is now a "latency" bug where, when the curve tool is brought up with a non-identity transform, it is not immediately applied, so the setting of the tool is not reflected in the state of the image. That becomes the basis of a (minor, almost cosmetic, and easily corrected) bug report. The image should immediately align with whatever transform is being applied by any interactive, image_map-based tool (curves, levels, color balance, hue-saturation, brightness-contrast, threshold, posterize). 2. Among the interactive tools, the curve tool has a now-activated and unique "persistence" feature that some people like and others don't. In the course of fixing 1., I propose adding a "Persist?" setting. For those who prefer to start their search for a nice transform from the identity transform, they can disable this toggle and get the older behavior. Is this a reasonable course? Thank you all, for your time. Be good, be well Garry
Request To Revert Curve Tool
2000-11-29 Austin Donnelly [EMAIL PROTECTED] * app/curves.c: Applied patch from David Hodson [EMAIL PROTECTED] to fix Bug#33399: GIMP crashes when applying curve to Grayscaled image when preview is off. Previously the curves tool attempted a reset when changing image, but didn't correctly do this. Now it has the (more useful) behaviour of doing a partial reset, where the curve remains the same across multiple invocations, allowing you to apply the same tweak to multiple images. The internal state relevant to image type/depth is correctly reset, stopping the segfault behaviour seen before. Well, after two weeks of trying the new behaviour, I find myself not liking it and request that the initial range transform from old to new just be the identity transform, as it was before. Alternately, I request an added toggle button to set the preferred kinds of initial state. 1. I find the new behaviour useful only when my intended effect is "something like" what I tried before, but this is not always the case. Often, my intent from one invocation of the curve tool to the next is along different lines, and in those (very frequent, for me) disjoint cases, I find the best starting point is the one that applies no transform to the image at all: the (former) identity mappings. This permits me to start my explorations from the image I have to what I think I possibly want. Now I have to somewhat unapply the old transform before intuiting what the new transform should be. 2. Individuals interested in applying similar transforms to a variety of images already had a remedy (which is still in place), saving a particular transform to file and then reloading it again. The current interface change does make this work flow more efficient (no save/load), but, I claim, at the cost of the disjoint case workflow, the one I frequently (typically) follow. 3. The change in interface has introduced something of an initial state bug, which I will report if the group thinks the new behaviour should remain in place. When the curve tool recalls the previous (not identity) transform, the image itself remains unchanged, as if the identity transform is in place, and not the actual transform manifest in the curve tool. The tranform ought to be applied so that the image state matches the setting of the curve tool. The "flash" of tiles suddenly updating would also furnish a visual cue to the user that the transform inside the curve tool is currently something other than the identity transform. This is a fairly trivial bug to fix; one applies a "pseudo mouse move" to invoke image_map.c logic. If I fall into the minority in this issue, then I (alternately) request that a toggle button, somewhat like the preview toggle button, be put in place so that those of us who prefer the old behaviour (start from the identity transform) can put the policy in place. Thank you for your attention; I hope to hear alternate opinions. Be good, be well, Garry Osgood
Re: [gimp-devel] Request To Revert Curve Tool
Garry R. Osgood ([EMAIL PROTECTED]) wrote: 2000-11-29 Austin Donnelly [EMAIL PROTECTED] * app/curves.c: Applied patch from David Hodson [...] image, but didn't correctly do this. Now it has the (more useful) behaviour of doing a partial reset, where the curve remains the same across multiple invocations, allowing Well, after two weeks of trying the new behaviour, I find myself not liking it and request that the initial range transform from old to new just be the identity transform, as it was before. Add me! Alternately, I request an added toggle button to set the preferred kinds of initial state. Maybe a better Idea would be (but this is definitely a new feature) to have some kind of history, where you can recall the last three (or so) curves... Bye, Simon -- [EMAIL PROTECTED] http://www.home.unix-ag.org/simon/