Re: [msysGit] Re: [PATCH 00/13] mingw unicode environment

2014-07-18 Thread Stepan Kasal
Hello Karsten, you wrote: However, if it *did* compile for you, I wonder where ALLOC_GROW (as of #02/13) and alloc_nr (as of #10/13) came from? Or did we recently remove '#include cache.h' from upstream mingw.c? you are right, the include needs to be added. To test my modifications, I

[PATCH 00/13] mingw unicode environment

2014-07-17 Thread Stepan Kasal
Hello, this is the remainder of Karsten's unicode branch, that is a time proven part of msysGit. (If this code is accepted, only one patch would only remain: gitk and git-gui fixes.) When rebasing Karsten's work, I have eliminated two commits: https://github.com/msysgit/git/commit/f967550

Re: [PATCH 00/13] mingw unicode environment

2014-07-17 Thread Junio C Hamano
Stepan Kasal ka...@ucw.cz writes: ... only one patch would only remain: gitk and git-gui fixes.) Nice. Will queue. When rebasing Karsten's work, I have eliminated two commits: https://github.com/msysgit/git/commit/f967550 https://github.com/msysgit/git/commit/290bf81 These commits only

Re: [PATCH 00/13] mingw unicode environment

2014-07-17 Thread Karsten Blees
Am 17.07.2014 17:37, schrieb Stepan Kasal: Hello, this is the remainder of Karsten's unicode branch, that is a time proven part of msysGit. (If this code is accepted, only one patch would only remain: gitk and git-gui fixes.) Thank you so much! I had to add '#include ../cache.h' to

Re: [PATCH 00/13] mingw unicode environment

2014-07-17 Thread Junio C Hamano
Karsten Blees karsten.bl...@gmail.com writes: Am 17.07.2014 17:37, schrieb Stepan Kasal: I believe we prefer moving code to the right place over forward declarations (IIRC I got bashed for the latter in one of the first rounds of this patch series). If only to justify 'git-blame -M' :-D

Re: [PATCH 00/13] mingw unicode environment

2014-07-17 Thread Stepan Kasal
Hi, Karsten Blees karsten.bl...@gmail.com writes: I believe we prefer moving code to the right place over forward declarations (IIRC I got bashed for the latter in one of the first rounds of this patch series). If only to justify 'git-blame -M' :-D indeed, my position is the same,

Re: [PATCH 00/13] mingw unicode environment

2014-07-17 Thread Junio C Hamano
Stepan Kasal ka...@ucw.cz writes: If anyone thinks the resulting ordering is not OK, they can propose one re-order patch on top of this series. I agree that that would be a good way to go. Junio wrote: OK, so the series may need further re-polishing of the polishing done by Stepan

Re: [PATCH 00/13] mingw unicode environment

2014-07-17 Thread Karsten Blees
Am 17.07.2014 21:00, schrieb Stepan Kasal: Hi, Karsten Blees karsten.bl...@gmail.com writes: I believe we prefer moving code to the right place over forward declarations (IIRC I got bashed for the latter in one of the first rounds of this patch series). If only to justify 'git-blame -M' :-D