Am 11/26/2013 0:43, schrieb Jonathan Nieder:
> Heikki Hokkanen wrote:
>
>> If running git config on each prompt seems too expensive, do you have
>> any better ideas?
>
> Perhaps a GIT_PS1_NOT_FOR_THESE_REPOS=repo1:repo2:repo3 setting would
> work.
Yeah, but... I find the wish to show the bash pr
On Sun, Nov 24, 2013 at 10:55 PM, Nguyễn Thái Ngọc Duy
wrote:
> If we borrow objects from another repository, we should also pay
> attention to their $GIT_DIR/shallow (and even info/grafts). But
> current alternates code does not.
>
> Reject alternate repos that are shallow because we do not do it
On Mon, Nov 25, 2013 at 4:03 PM, Jonathan Nieder wrote:
> A #! line in these files is misleading, since these scriptlets are
> meant to be sourced with '.' (using whatever shell sources them)
> instead of run directly using the interpreter named on the #! line.
>
> Removing the #! line shouldn't h
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 11/25/2013 10:13 PM, Duy Nguyen wrote:
> There's a difference between "skip commits that touch anything
> directory foo even if it also touches something outside of foo" and
> "skip commits that _only_ touches something in foo". Not sure which
> w
On Tue, Nov 26, 2013 at 3:35 AM, Junio C Hamano wrote:
> Phillip Susi writes:
>
>> I can't seem to find a way to invert the meaning of a pathspec given
>> to git log in order to find commits touching anything BUT a given
>> path. Does such a thing exist?
>
> Not yet (look for "negative pathspec"
On Tue, Nov 26, 2013 at 6:34 AM, "Andrés G. Aragoneses"
wrote:
> On 22/11/13 02:18, Duy Nguyen wrote:
>> On Fri, Nov 22, 2013 at 3:18 AM, Junio C Hamano wrote:
>>> Have you run the tests with this patch? It seems that it breaks
>>> quite a lot of them, including t5500, t5503, t5510, among others
All,
My first git patch - so shout out if I’ve got the etiquette wrong! Or of course
if I’ve missed something.
I googled around looking for solutions to my problem but just came up with a
few shell-scripts
that didn’t quite get the functionality I needed.
The first patch fixes some typos that cre
On Mon, Nov 25, 2013 at 03:43:44PM -0800, Jonathan Nieder wrote:
> Heikki Hokkanen wrote:
>
> > If running git config on each prompt seems too expensive, do you have
> > any better ideas?
>
> Perhaps a GIT_PS1_NOT_FOR_THESE_REPOS=repo1:repo2:repo3 setting would
> work.
>
> __git_ps1 would do the
Heikki Hokkanen wrote:
> If running git config on each prompt seems too expensive, do you have
> any better ideas?
Perhaps a GIT_PS1_NOT_FOR_THESE_REPOS=repo1:repo2:repo3 setting would
work.
__git_ps1 would do the one 'git rev-parse --git-dir --...' to find the
repo corresponding to the cwd and
On 22/11/13 02:18, Duy Nguyen wrote:
> On Fri, Nov 22, 2013 at 3:18 AM, Junio C Hamano wrote:
>> Have you run the tests with this patch? It seems that it breaks
>> quite a lot of them, including t5500, t5503, t5510, among others.
>
> I guess it's caused by builtin/fetch.c:backfill_tags(). And th
Junio C Hamano writes:
> Perhaps a preparatory patch needs to rename the structure type to
> object_name_list or something. And then we can make the variable
> names, not typenames, responsible for signalling what they mean,
> i.e.
>
> get_remote_heads(...
> struct list_of_ob
Nguyễn Thái Ngọc Duy writes:
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> commit.h | 8 +---
> fetch-pack.c | 5 +++--
> shallow.c | 20 +++-
> upload-pack.c | 2 +-
> 4 files changed, 24 insertions(+), 11 deletions(-)
>
> diff --git a/commit.h b/commit.h
> in
Nguyễn Thái Ngọc Duy writes:
> When we receive a pack and the shallow points from another repository,
> we may need to add more shallow points to current repo to make sure no
> commits point to nowhere. But usually we don't want to do so because
> (in future) new shallow points invalidate pack b
Nguyễn Thái Ngọc Duy writes:
> When we receive a pack and the shallow points from another repository,
> we may want to add more shallow points to current repo to make sure no
> commits point to nowhere. However we do not want to add unnecessary
> shallow points and cut our history short because
Nguyễn Thái Ngọc Duy writes:
> No callers pass a non-empty pointer as shallow_points at this
> stage. As a result, all clients still refuse to talk to shallow
> repository on the other end.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> builtin/fetch-pack.c | 2 +-
> builtin/send-pack.c |
In a shell snippet meant to be sourced by other shell scripts, an
opening #! line does more harm than good.
The harm:
- When the shell library is sourced, the interpreter and options from
the #! line are not used. Specifying a particular shell can
confuse the reader into thinking it is sa
A #! line in these files is misleading, since these scriptlets are
meant to be sourced with '.' (using whatever shell sources them)
instead of run directly using the interpreter named on the #! line.
Removing the #! line shouldn't hurt syntax highlighting since
these files have filenames ending wi
This way, test authors don't need to remember to source
lib-prereq-FILEMODE.sh before using the FILEMODE prereq to guard tests
that rely on the executable bit being honored when checking out files.
Signed-off-by: Jonathan Nieder
---
t/lib-prereq-FILEMODE.sh | 11 ---
t/t3701-add-in
Jens Lehmann writes:
> Looking good to me. Please add tests for "diff.ignoreSubmodules"
> and "submodule..ignore", the latter both in .gitmodules and
> .git/config. While doing some testing for this thread I found an
> inconsistency in git show which currently honors the submodule
> specific opti
On Windows the convention is to rely on filename extensions to decide
whether a file is executable so Windows users are probably not relying
on the executable bit of these scripts, but on other platforms it can
be useful documentation.
Signed-off-by: Jonathan Nieder
---
compat/vcbuild/scripts/cl
The Makefile only runs po/po2msg.sh using tclsh, but because the
script has the usual tcl preamble starting with #!/bin/sh it can also
be run directly.
The Windows git-gui wrapper is usable in-place for the same reason.
Signed-off-by: Jonathan Nieder
---
po/po2msg.sh | 0
windows/git-gui.
The Makefile only runs it using tclsh, but because the fallback po2msg
script has the usual tcl preamble starting with #!/bin/sh it can also
be run directly.
Signed-off-by: Jonathan Nieder
---
po/po2msg.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 po/po2m
The git p4import documentation has suggested git p4 as a better
alternative for more than 6 years. (According to the mailing list
discussion when it was moved to contrib/, git-p4import has serious
bugs --- e.g., its incremental mode just doesn't work.) Since then,
git p4 has been actively develope
The docs in contrib/hooks/pre-auto-gc-battery suggest:
For example, if the hook is stored in
/usr/share/git-core/contrib/hooks/pre-auto-gc-battery:
chmod a+x pre-auto-gc-battery
cd /path/to/your/repository.git
ln -sf /usr/share/git-core/contrib/hooks/pre-au
Heiko Voigt writes:
> What I think needs fixing here first is that the ignore setting should not
> apply to any diffs between HEAD and index. IMO, it should only apply
> to the diff between worktree and index.
Hmph. How about "git diff $commit", the diff between the worktree and
a named commit
These scripts are not run directly as part of a normal build, so no
one noticed that they did not have the +x bit. Mark them executable
to make it more obvious that they can be run directly (when debugging,
for example).
Signed-off-by: Jonathan Nieder
---
t/Git-SVN/00compile.t | 0
Hi,
This is an old series that I just wanted to flush out of my working
directory. It does two things:
On one hand, it replaces the line
#!/bin/sh
at the start of shell libraries with a simple comment
# Shell library for
to avoid confusing readers into thinking the shell lib
Thomas Rast writes:
> The clear_$slabname() function was only documented by source code so
> far. Write something about it.
>
> Signed-off-by: Thomas Rast
> ---
> commit-slab.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/commit-slab.h b/commit-slab.h
> index d4c8286..d77aaea 1
Thomas Rast wrote:
> Jonathan Nieder writes:
>> Thomas Rast wrote:
>>> This shuts up compiler warnings about unused functions.
>>
>> If that is the only goal, I think it would be cleaner to use
>>
>> #define MAYBE_UNUSED __attribute__((__unused__))
>>
>> static MAYBE_UNUSED void init_ .
Phillip Susi writes:
> I can't seem to find a way to invert the meaning of a pathspec given
> to git log in order to find commits touching anything BUT a given
> path. Does such a thing exist?
Not yet (look for "negative pathspec").
--
To unsubscribe from this list: send the line "unsubscribe g
Jonathan Nieder writes:
> Thomas Rast wrote:
>
>> This shuts up compiler warnings about unused functions.
>
> If that is the only goal, I think it would be cleaner to use
>
> #define MAYBE_UNUSED __attribute__((__unused__))
>
> static MAYBE_UNUSED void init_ ...
>
> like was done in t
Thomas Rast wrote:
> The clear_$slabname() function was only documented by source code so
> far. Write something about it.
Good idea.
[...]
> --- a/commit-slab.h
> +++ b/commit-slab.h
> @@ -24,6 +24,10 @@
> * to each commit. 'stride' specifies how big each array is. The slab
> * that i
Thomas Rast writes:
> Here's a version that has a fat comment instead of the removal.
>
> Also, since I was rerolling anyway I put a reason why we need this.
> In the original motivation I actually created more functions
> afterwards, which made it more convincing, but the problem already
> exist
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I can't seem to find a way to invert the meaning of a pathspec given
to git log in order to find commits touching anything BUT a given
path. Does such a thing exist?
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG w
Jonathan Nieder writes:
> Thomas Rast wrote:
>
>> This shuts up compiler warnings about unused functions.
>
> If that is the only goal, I think it would be cleaner to use
>
> #define MAYBE_UNUSED __attribute__((__unused__))
>
> static MAYBE_UNUSED void init_ ...
>
> like was done in t
Thomas Rast wrote:
> This shuts up compiler warnings about unused functions.
If that is the only goal, I think it would be cleaner to use
#define MAYBE_UNUSED __attribute__((__unused__))
static MAYBE_UNUSED void init_ ...
like was done in the vcs-svn/ directory until cba3546 (d
Nguyễn Thái Ngọc Duy writes:
> Dumb commit walker does not care about .git/shallow and until someone
> steps up to make it happen, let's not publish shallow clones using
> dumb protocols.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> server-info.c | 9 +
> 1 file changed, 9 insertion
This shuts up compiler warnings about unused functions. No such
warnings are currently triggered, but if someone were to actually use
init_NAME_with_stride() as documented, they would get a warning about
init_NAME() being unused.
While there, write a comment about why we need two declarations of
Junio C Hamano writes:
> Thomas Rast writes:
>
>> This shuts up compiler warnings about unused functions.
>
> Thanks.
>
>> While there, also remove the redundant second declaration of
>> stat_##slabname##realloc.
>
> I think the latter was done very much deliberately to allow the
> using code to
Thomas Rast writes:
> This shuts up compiler warnings about unused functions.
Thanks.
> While there, also remove the redundant second declaration of
> stat_##slabname##realloc.
I think the latter was done very much deliberately to allow the
using code to say:
define_commit_slab(name,
Krzesimir Nowak writes:
> On Fri, 2013-11-22 at 09:34 -0800, Junio C Hamano wrote:
>> Krzesimir Nowak writes:
>>
>> > Running 'make GITWEB_WANTED_REFS="heads wip" gitweb.cgi' will create a
>> > gitweb CGI script showing branches that appear in refs/heads/ and in
>> > refs/wip/. Might be useful
Duy Nguyen wrote:
> Do you think it's ok to revert the workaround if we detect
> the running glibc is fixed (or if it does not run glibc at all)? I
> think we could use gnu_get_libc_version() to detect it.
That would be wonderful.
Thanks,
Jonathan
--
To unsubscribe from this list: se
I gathered these while writing an "all merge bases simultaneously"
algorithm. Turns out this fancy algorithm loses vs. simply calling
get_merge_bases() a lot, so I dropped that. But the cleanups seem
valid anyway.
Thomas Rast (2):
commit-slab: document clear_$slabname()
commit-slab: declare
The clear_$slabname() function was only documented by source code so
far. Write something about it.
Signed-off-by: Thomas Rast
---
commit-slab.h | 4
1 file changed, 4 insertions(+)
diff --git a/commit-slab.h b/commit-slab.h
index d4c8286..d77aaea 100644
--- a/commit-slab.h
+++ b/commit-s
This shuts up compiler warnings about unused functions.
While there, also remove the redundant second declaration of
stat_##slabname##realloc.
Signed-off-by: Thomas Rast
---
commit-slab.h | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/commit-slab.h b/commi
Jeff King writes:
> On Sun, Nov 24, 2013 at 03:44:44AM -0500, Jeff King wrote:
>
>> In any code path where we call parse_object, we double-check that the
>> result matches the sha1 we asked for. But low-level commands like
>> cat-file just call read_sha1_file directly, and do not have such a
>> c
Jeff King wrote:
> I think it makes sense to be able to show it as part of "git branch",
> but the verbose branch listing there is a bit of a mess. Doing it
> cleanly would probably involve refactoring the branch-display code to
> allow users to specify more flexible formats.
Certainly. I'm quite
On Mon, Nov 25, 2013 at 11:57:45PM +0600, Sergey Sharybin wrote:
> Heiko, yeah sure see what you mean. Changing existing behavior is pretty PITA.
>
> Just one more question for now, are you referencing to the patch "[RFC
> PATCH] disable complete ignorance of submodules for index <-> HEAD
> diff"?
Heiko, yeah sure see what you mean. Changing existing behavior is pretty PITA.
Just one more question for now, are you referencing to the patch "[RFC
PATCH] disable complete ignorance of submodules for index <-> HEAD
diff"? Coz i tested it and seems it doesn't change behavior of
add/commit.
Also,
On Mon, Nov 25, 2013 at 03:02:51PM +0600, Sergey Sharybin wrote:
> Am i right the intention is to make it so `git add .` and `git commit
> .` doesn't include changes to submodule hash unless -f argument is
> provided?
Yes thats the goal. My patch currently only disables it when ignore is
set to al
Paweł Sikora writes:
> On Sunday 24 of November 2013 19:47:10 Duy Nguyen wrote:
>> On Sun, Nov 24, 2013 at 5:45 PM, Paweł Sikora wrote:
>> > i've recently reinstalled a fresh system (fc20-beta) on my workstation
>> > and observing a big slowdown on git cherry-pick operation (git-1.8.4.2-1).
>> >
Hello,
On Sat, Nov 23, 2013 at 6:35 PM, SZEDER Gábor wrote:
> Hm, strange. I wonder what can cause performance problems in big
> repositories.
>
> Sure, there are status indicators that can be expensive, in particular
> the indicators for dirty index/worktree, untracked files, and
> divergence f
Antoine Pelisse writes:
> On Fri, Nov 22, 2013 at 1:19 AM, Junio C Hamano wrote:
>> * rh/remote-hg-bzr-updates (2013-11-18) 9 commits
>> (merged to 'next' on 2013-11-20 at a36f3c4)
>> + remote-bzr, remote-hg: fix email address regular expression
>> + test-hg.sh: help user correlate verbose o
полезный рецепт спасти глазики http://goo.gl/csFULt
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Duy Nguyen writes:
> On Mon, Aug 19, 2013 at 2:42 AM, Thomas Gummerer wrote:
>> +/*
>> + * This function modifies the directory argument that is given to it.
>> + * Don't use it if the directory entries are still needed after.
>> + */
>
> There goes my hope of keeping directory_entry* in core so
[sorry about taking so much time to get back to you, was too busy with
other stuff to work on git]
Duy Nguyen writes:
> On Mon, Aug 19, 2013 at 2:42 AM, Thomas Gummerer wrote:
>> +char *super_directory(const char *filename)
>> +{
>> + char *slash;
>> +
>> + slash = strrchr(filename
Hi,
tl;dr: The filesystem used as temporary space for the Git test suite
must not be mounted "noexec".
It took me a while to figure out why many tests in the Git test suite
were failing on my new notebook computer. The failures started right in
test t:
[15:06:31] t-basic.sh
For squashing into a commit that adds khash.h.
Signed-off-by: Thomas Rast
---
> I think I'll also lend you a hand writing
> Documentation/technical/api-khash.txt
> (expect it tomorrow) so that we also have documentation in the git
> style, where gitters can be expected to find it on their own.
On 2013-11-25 15:55, Johan Herland wrote:
> "git branch --edit-description" allows you to write a descriptive
> string for your branch. AFAICS, however, it currently only shows up
> when using request-pull. It does not show up in any git branch
> command. IMHO that should be fixed.
>
> As a workar
On Mon, Nov 25, 2013 at 08:46:44AM -0600, Tim Chase wrote:
> Is there any way to associate some sort of note with a branch that
> would be shown when listing them? While I currently have things like
> "issue/QA-42", it would be nice to have a note associated with it so
> I could do something like
On Mon, Nov 25, 2013 at 3:46 PM, Tim Chase wrote:
> Is there any way to associate some sort of note with a branch that
> would be shown when listing them? While I currently have things like
> "issue/QA-42", it would be nice to have a note associated with it so
> I could do something like
>
> $
On Mon, Nov 25, 2013 at 09:32:13AM -0500, Jeff King wrote:
> > But I then decided that if a 3rd library has one way to generate
> > SIGPIPE it may very well have another in a separate spot so I decided
> > to do the wrap at the top level immediately in the entry point when
> > getting called by th
Is there any way to associate some sort of note with a branch that
would be shown when listing them? While I currently have things like
"issue/QA-42", it would be nice to have a note associated with it so
I could do something like
$ git branch --show-notes
issue/CR-88: make sure NoSQL engin
This is an extension to the fix in 7d80ed64e43515. We may
call Curl_disconnect() while cleaning up the multi handle,
which could lead to openssl sending packets, which could get
a SIGPIPE.
Signed-off-by: Jeff King
---
I really am just cargo-culting here. I have no idea what
multi->closure_handle
Commit 7d80ed64e43515 introduced some helpers to handle
sigpipe in easy.c. However, that fix was incomplete, and we
need to add more callers in other files. The first step is
making the helpers globally accessible.
Since the functions are small and should generally end up
inlined anyway, we simply
On Mon, Nov 25, 2013 at 08:20:18AM +0100, Daniel Stenberg wrote:
> >Daniel, does the call to Curl_disconnect need to be wrapped with
> >sigpipe_ignore/reset, similar to 7d80ed64e435155?
>
> Yes. It very much looks like that. The SSL "closing" is what was the
> problem I had to adress.
>
> But I
On Fri, 2013-11-22 at 09:34 -0800, Junio C Hamano wrote:
> Krzesimir Nowak writes:
>
> > Running 'make GITWEB_WANTED_REFS="heads wip" gitweb.cgi' will create a
> > gitweb CGI script showing branches that appear in refs/heads/ and in
> > refs/wip/. Might be useful for gerrit setups where user bran
Hi,
Tested the patch. `git status` now shows the changes to the
submodules, which is nice :)
However, is it possible to make it so `git commit` lists submodules in
"changes to be committed" section, so you'll see what's gonna to be in
the commit while typing the commit message as well?
On Sat, N
Hey!
Sorry for the delayed reply.
Am i right the intention is to make it so `git add .` and `git commit
.` doesn't include changes to submodule hash unless -f argument is
provided?
On Sun, Nov 24, 2013 at 10:29 PM, Jens Lehmann wrote:
> Am 24.11.2013 01:52, schrieb Heiko Voigt:
>> Hi,
>>
>> On
69 matches
Mail list logo
