Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-05 Thread Karsten Blees
Am 05.06.2014 14:03, schrieb Johannes Schindelin: > Hi Karsten, > > On Thu, 5 Jun 2014, Karsten Blees wrote: > >> After a bit of digging in the history and the old googlegroups issue >> tracker, I think this patch is completely unrelated to the non-ASCII >> problems. > > Actually, the non-ASCII

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-05 Thread Stepan Kasal
Hi, On Thu, Jun 05, 2014 at 02:03:39PM +0200, Johannes Schindelin wrote: > Render me even more convinced that the API call is the cleanest way to go, But not me. In a paralel post, Duy Nguyen wrote: > Thank you for working on pushing msysgit patches upstream. I don't use > git on windows, but

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-05 Thread Johannes Schindelin
Hi Karsten, On Thu, 5 Jun 2014, Karsten Blees wrote: > After a bit of digging in the history and the old googlegroups issue > tracker, I think this patch is completely unrelated to the non-ASCII > problems. Actually, the non-ASCII problems were the trigger for my patch. > In summary, this patch

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Karsten Blees
Am 04.06.2014 17:46, schrieb Johannes Schindelin: > Hi kusma, > > On Wed, 4 Jun 2014, Johannes Schindelin wrote: > >> The problem arises whenever git.exe calls subprocesses. You can pollute >> the environment by setting HOME, I do not recall the details, but I >> remember that we had to be very c

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Duy Nguyen
On Wed, Jun 4, 2014 at 11:16 PM, Stepan Kasal wrote: > Hi dscho, > > your arguments seem really strong. (Especially the four years of > battle testing, with the memories of constant problems with HOME before.) > > I hope they are strong enough to convince Junio to accept this patch; > that would

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Johannes Schindelin
Hi Stepan, On Wed, 4 Jun 2014, Stepan Kasal wrote: > PS (about mingwGitDevEnv): > > plan is to switch to mingwGitDevEnv for said release. No more msysGit. > > Like, bu-bye. Thanks for all the fish. > > Interesting. > > With msysgit, there is the "net installer" - first time I installed > msys/m

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Stepan Kasal
Hi dscho, your arguments seem really strong. (Especially the four years of battle testing, with the memories of constant problems with HOME before.) I hope they are strong enough to convince Junio to accept this patch; that would help. Stepan PS (about mingwGitDevEnv): > plan is to switch to m

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Johannes Schindelin
Hi Stepan, On Wed, 4 Jun 2014, Stepan Kasal wrote: > > > On Wed, Jun 4, 2014 at 5:14 PM, Johannes Schindelin > > > wrote: > > > > No. Git is not always called through Bash or the git-wrapper, > > > > unfortunately. > > but you have to admit, that in most cases it is called through bash or > the

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Johannes Schindelin
Hi kusma, On Wed, 4 Jun 2014, Johannes Schindelin wrote: > The problem arises whenever git.exe calls subprocesses. You can pollute > the environment by setting HOME, I do not recall the details, but I > remember that we had to be very careful *not* to do that, hence the patch. > Sorry, has been a

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Stepan Kasal
Hi dscho, > > On Wed, Jun 4, 2014 at 5:14 PM, Johannes Schindelin > > wrote: > > > No. Git is not always called through Bash or the git-wrapper, > > > unfortunately. but you have to admit, that in most cases it is called through bash or the git wrapper. > The problem arises whenever git.exe cal

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Johannes Schindelin
Hi kusma, On Wed, 4 Jun 2014, Erik Faye-Lund wrote: > On Wed, Jun 4, 2014 at 5:14 PM, Johannes Schindelin > wrote: > > > > On Wed, 4 Jun 2014, Erik Faye-Lund wrote: > > > >> On Wed, Jun 4, 2014 at 3:47 PM, Duy Nguyen wrote: > >> > On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal wrote: > >> >> @@

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Erik Faye-Lund
On Wed, Jun 4, 2014 at 5:14 PM, Johannes Schindelin wrote: > Hi Erik, > > On Wed, 4 Jun 2014, Erik Faye-Lund wrote: > >> On Wed, Jun 4, 2014 at 3:47 PM, Duy Nguyen wrote: >> > On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal wrote: >> >> @@ -133,7 +133,7 @@ char *git_path(const char *fmt, ...) >> >>

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Johannes Schindelin
Hi Erik, On Wed, 4 Jun 2014, Erik Faye-Lund wrote: > On Wed, Jun 4, 2014 at 3:47 PM, Duy Nguyen wrote: > > On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal wrote: > >> @@ -133,7 +133,7 @@ char *git_path(const char *fmt, ...) > >> void home_config_paths(char **global, char **xdg, char *file) > >>

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Johannes Schindelin
Hi Duy, On Wed, 4 Jun 2014, Duy Nguyen wrote: > On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal wrote: > > @@ -133,7 +133,7 @@ char *git_path(const char *fmt, ...) > > void home_config_paths(char **global, char **xdg, char *file) > > { > > char *xdg_home = getenv("XDG_CONFIG_HOME"); > > -

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Karsten Blees
Am 04.06.2014 16:05, schrieb Erik Faye-Lund: > On Wed, Jun 4, 2014 at 3:47 PM, Duy Nguyen wrote: >> On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal wrote: >>> @@ -133,7 +133,7 @@ char *git_path(const char *fmt, ...) >>> void home_config_paths(char **global, char **xdg, char *file) >>> { >>>

Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

2014-06-04 Thread Erik Faye-Lund
On Wed, Jun 4, 2014 at 3:47 PM, Duy Nguyen wrote: > On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal wrote: >> @@ -133,7 +133,7 @@ char *git_path(const char *fmt, ...) >> void home_config_paths(char **global, char **xdg, char *file) >> { >> char *xdg_home = getenv("XDG_CONFIG_HOME"); >> -