[GitHub] [activemq-artemis] asfgit closed pull request #2600: ARTEMIS-2289 SUBSCRIBE w/receipt returns 2 receipt-ids

2019-04-02 Thread GitBox
asfgit closed pull request #2600: ARTEMIS-2289 SUBSCRIBE w/receipt returns 2 receipt-ids URL: https://github.com/apache/activemq-artemis/pull/2600 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] gaohoward opened a new pull request #2601: NO-JIRA Fix test ReplicatedAsynchronousFailoverTest.testTransactional

2019-04-01 Thread GitBox
gaohoward opened a new pull request #2601: NO-JIRA Fix test ReplicatedAsynchronousFailoverTest.testTransactional URL: https://github.com/apache/activemq-artemis/pull/2601 Fix random failures. This is an automated message

[GitHub] [activemq-artemis] franz1981 commented on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler

2019-03-29 Thread GitBox
franz1981 commented on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler URL: https://github.com/apache/activemq-artemis/pull/2598#issuecomment-478081106 I'm writing a test for it :+1:

[GitHub] [activemq-artemis] franz1981 opened a new pull request #2597: ARTEMIS-2291 ClassCastException on JMSBridgeImpl::stop leaks bridge resources

2019-03-29 Thread GitBox
franz1981 opened a new pull request #2597: ARTEMIS-2291 ClassCastException on JMSBridgeImpl::stop leaks bridge resources URL: https://github.com/apache/activemq-artemis/pull/2597 This is an automated message from the Apache

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler

2019-03-29 Thread GitBox
michaelandrepearce commented on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler URL: https://github.com/apache/activemq-artemis/pull/2598#issuecomment-478086256 > I'm writing a test for it  :)

[GitHub] [activemq-artemis] franz1981 opened a new pull request #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler

2019-03-29 Thread GitBox
franz1981 opened a new pull request #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler URL: https://github.com/apache/activemq-artemis/pull/2598 This is an automated message from the Apache

[GitHub] [activemq-artemis] franz1981 commented on issue #2597: ARTEMIS-2291 ClassCastException on JMSBridgeImpl::stop leaks bridge resources

2019-03-29 Thread GitBox
franz1981 commented on issue #2597: ARTEMIS-2291 ClassCastException on JMSBridgeImpl::stop leaks bridge resources URL: https://github.com/apache/activemq-artemis/pull/2597#issuecomment-478080246 Not sure if is possible to provide a test for this, but I'll try :+1:

[GitHub] [activemq-artemis] michaelandrepearce opened a new pull request #2603: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
michaelandrepearce opened a new pull request #2603: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2603 Additional bits missed This is an

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
clebertsuconic commented on issue #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#issuecomment-479017322 @jbertram topic subscriptions are not really auto-created, the client performs a create...

[GitHub] [activemq-artemis] jbertram commented on issue #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
jbertram commented on issue #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#issuecomment-479021319 Fair enough. This is an automated

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
michaelandrepearce commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#discussion_r271326552 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
michaelandrepearce commented on issue #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#issuecomment-479018894 Correct @clebertsuconic , also that would mean a change in behaviour for existing users,

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
clebertsuconic commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#discussion_r271325506 ## File path:

[GitHub] [activemq-artemis] asfgit closed pull request #2601: NO-JIRA Fix test ReplicatedAsynchronousFailoverTest.testTransactional

2019-04-02 Thread GitBox
asfgit closed pull request #2601: NO-JIRA Fix test ReplicatedAsynchronousFailoverTest.testTransactional URL: https://github.com/apache/activemq-artemis/pull/2601 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
michaelandrepearce commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#discussion_r271323828 ## File path:

[GitHub] [activemq-artemis] asfgit closed pull request #2594: ARTEMIS-2286 AMQP to Core Conversion doesn't map routing type always

2019-04-02 Thread GitBox
asfgit closed pull request #2594: ARTEMIS-2286 AMQP to Core Conversion doesn't map routing type always URL: https://github.com/apache/activemq-artemis/pull/2594 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
clebertsuconic commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#discussion_r271321054 ## File path:

[GitHub] [activemq-artemis] jbertram commented on issue #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
jbertram commented on issue #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#issuecomment-479016337 Could this issue be addressed a bit more simply by just marking the queues backing JMS topic

[GitHub] [activemq-artemis] asfgit closed pull request #2599: NO-JIRA Fixing markdown format in intercepting-operations.md

2019-04-02 Thread GitBox
asfgit closed pull request #2599: NO-JIRA Fixing markdown format in intercepting-operations.md URL: https://github.com/apache/activemq-artemis/pull/2599 This is an automated message from the Apache Git Service. To respond

[GitHub] [activemq-artemis] asfgit closed pull request #2596: NO-JIRA Avoid NPE during backup shutdown

2019-04-02 Thread GitBox
asfgit closed pull request #2596: NO-JIRA Avoid NPE during backup shutdown URL: https://github.com/apache/activemq-artemis/pull/2596 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2603: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
michaelandrepearce commented on issue #2603: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2603#issuecomment-479054328 @clebertsuconic just realized i missed a commit in squashed version in the prev pr you just

[GitHub] [activemq-artemis] asfgit merged pull request #2603: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
asfgit merged pull request #2603: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2603 This is an automated message from the Apache Git Service.

[GitHub] [activemq-artemis] asfgit closed pull request #2595: ARTEMIS-2288 add remote IP to handshake timeout error

2019-04-02 Thread GitBox
asfgit closed pull request #2595: ARTEMIS-2288 add remote IP to handshake timeout error URL: https://github.com/apache/activemq-artemis/pull/2595 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] asfgit closed pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
asfgit closed pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602 This is an automated message from the Apache Git Service.

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
clebertsuconic commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#discussion_r271332851 ## File path:

[GitHub] [activemq-website] jbertram opened a new pull request #5: Updating base URL

2019-04-02 Thread GitBox
jbertram opened a new pull request #5: Updating base URL URL: https://github.com/apache/activemq-website/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [activemq-website] jbertram merged pull request #5: Updating base URL

2019-04-02 Thread GitBox
jbertram merged pull request #5: Updating base URL URL: https://github.com/apache/activemq-website/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [activemq-artemis] asfgit closed pull request #2604: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-02 Thread GitBox
asfgit closed pull request #2604: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2604 This is an automated message from the Apache Git Service.

[GitHub] [activemq-artemis] gaohoward commented on issue #2592: ARTEMIS-2285 Sorting by user column in connections view not working

2019-04-02 Thread GitBox
gaohoward commented on issue #2592: ARTEMIS-2285 Sorting by user column in connections view not working URL: https://github.com/apache/activemq-artemis/pull/2592#issuecomment-479313849 looking good. Could you add a unit test?

[GitHub] [activemq] alexndr79 opened a new pull request #352: Applied fix for data writer thread dying an early death

2019-04-03 Thread GitBox
alexndr79 opened a new pull request #352: Applied fix for data writer thread dying an early death URL: https://github.com/apache/activemq/pull/352 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2590: ARTEMIS-2282 QueueImpl::addTail of a management message could throw NPE

2019-03-27 Thread GitBox
michaelandrepearce commented on issue #2590: ARTEMIS-2282 QueueImpl::addTail of a management message could throw NPE URL: https://github.com/apache/activemq-artemis/pull/2590#issuecomment-477043990 Thanks @franz1981 lgtm now

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2593: ARTEMIS-2264 Added test that receive all messages instead of remove

2019-03-27 Thread GitBox
michaelandrepearce commented on issue #2593: ARTEMIS-2264 Added test that receive all messages instead of remove URL: https://github.com/apache/activemq-artemis/pull/2593#issuecomment-477043503 Lgtm This is an automated

[GitHub] [activemq-website] asfgit merged pull request #4: Update structure of repo and script site generation

2019-03-27 Thread GitBox
asfgit merged pull request #4: Update structure of repo and script site generation URL: https://github.com/apache/activemq-website/pull/4 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-artemis] asfgit closed pull request #2590: ARTEMIS-2282 QueueImpl::addTail of a management message could throw NPE

2019-03-27 Thread GitBox
asfgit closed pull request #2590: ARTEMIS-2282 QueueImpl::addTail of a management message could throw NPE URL: https://github.com/apache/activemq-artemis/pull/2590 This is an automated message from the Apache Git Service.

[GitHub] [activemq-website] gemmellr edited a comment on issue #4: Update structure of repo and script site generation

2019-03-26 Thread GitBox
gemmellr edited a comment on issue #4: Update structure of repo and script site generation URL: https://github.com/apache/activemq-website/pull/4#issuecomment-476771372 The README's "Install ruby" should maybe note that includes the devel headers. It might be worth linking to the

[GitHub] [activemq-website] gemmellr commented on issue #4: Update structure of repo and script site generation

2019-03-26 Thread GitBox
gemmellr commented on issue #4: Update structure of repo and script site generation URL: https://github.com/apache/activemq-website/pull/4#issuecomment-476771372 The README's "Install ruby" should maybe note that includes the devel headers. It might be worth linking to the Jekyll

[GitHub] [activemq-website] tabish121 opened a new pull request #4: Update structure of repo and script site generation

2019-03-26 Thread GitBox
tabish121 opened a new pull request #4: Update structure of repo and script site generation URL: https://github.com/apache/activemq-website/pull/4 Reorganize a bit and create a build script for building the site and preparing the contents for publish from the asf-site branch. Adds a

[GitHub] [activemq-artemis] asfgit merged pull request #2587: ARTEMIS-2280 Add new test for moving message to FQQN

2019-03-21 Thread GitBox
asfgit merged pull request #2587: ARTEMIS-2280 Add new test for moving message to FQQN URL: https://github.com/apache/activemq-artemis/pull/2587 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] gaohoward commented on a change in pull request #2587: ARTEMIS-2280 Add new test for moving message to FQQN

2019-03-21 Thread GitBox
gaohoward commented on a change in pull request #2587: ARTEMIS-2280 Add new test for moving message to FQQN URL: https://github.com/apache/activemq-artemis/pull/2587#discussion_r267676836 ## File path:

[GitHub] [activemq-artemis] zschwarz commented on a change in pull request #2587: ARTEMIS-2280 Add new test for moving message to FQQN

2019-03-21 Thread GitBox
zschwarz commented on a change in pull request #2587: ARTEMIS-2280 Add new test for moving message to FQQN URL: https://github.com/apache/activemq-artemis/pull/2587#discussion_r267684197 ## File path:

[GitHub] [activemq-artemis] gaohoward commented on a change in pull request #2587: ARTEMIS-2280 Add new test for moving message to FQQN

2019-03-21 Thread GitBox
gaohoward commented on a change in pull request #2587: ARTEMIS-2280 Add new test for moving message to FQQN URL: https://github.com/apache/activemq-artemis/pull/2587#discussion_r267676395 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues

2019-04-03 Thread GitBox
michaelandrepearce commented on a change in pull request #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues URL: https://github.com/apache/activemq-artemis/pull/2605#discussion_r271812855 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce opened a new pull request #2606: NO-JIRA - Add missing docs for Group Rebalancing

2019-04-03 Thread GitBox
michaelandrepearce opened a new pull request #2606: NO-JIRA - Add missing docs for Group Rebalancing URL: https://github.com/apache/activemq-artemis/pull/2606 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] asfgit merged pull request #2606: NO-JIRA - Add missing docs for Group Rebalancing

2019-04-03 Thread GitBox
asfgit merged pull request #2606: NO-JIRA - Add missing docs for Group Rebalancing URL: https://github.com/apache/activemq-artemis/pull/2606 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues

2019-04-03 Thread GitBox
clebertsuconic commented on issue #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues URL: https://github.com/apache/activemq-artemis/pull/2605#issuecomment-479544808 @michaelandrepearce can you check this please?

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues

2019-04-03 Thread GitBox
clebertsuconic opened a new pull request #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues URL: https://github.com/apache/activemq-artemis/pull/2605 This is an automated message from the Apache Git

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue

2019-04-03 Thread GitBox
clebertsuconic commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#discussion_r271803384 ## File path:

[GitHub] [activemq-artemis] asfgit merged pull request #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues

2019-04-03 Thread GitBox
asfgit merged pull request #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues URL: https://github.com/apache/activemq-artemis/pull/2605 This is an automated message from the Apache Git Service. To respond

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues

2019-04-03 Thread GitBox
clebertsuconic commented on a change in pull request #2605: ARTEMIS-2292 Fix default on XSD for auto-delete-created-queues URL: https://github.com/apache/activemq-artemis/pull/2605#discussion_r271807595 ## File path:

[GitHub] [activemq-artemis] franz1981 opened a new pull request #2607: ARTEMIS-2291 Added test for ClassCastException on JMSBridgeImpl::stop

2019-04-04 Thread GitBox
franz1981 opened a new pull request #2607: ARTEMIS-2291 Added test for ClassCastException on JMSBridgeImpl::stop URL: https://github.com/apache/activemq-artemis/pull/2607 This is an automated message from the Apache Git

[GitHub] [activemq-artemis] franz1981 commented on issue #2607: ARTEMIS-2291 Added test for ClassCastException on JMSBridgeImpl::stop

2019-04-04 Thread GitBox
franz1981 commented on issue #2607: ARTEMIS-2291 Added test for ClassCastException on JMSBridgeImpl::stop URL: https://github.com/apache/activemq-artemis/pull/2607#issuecomment-479873109 @clebertsuconic @jbertram I'm not very happy about this test, because I've modified the running

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ

2019-04-04 Thread GitBox
clebertsuconic commented on issue #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ URL: https://github.com/apache/activemq-artemis/pull/2608#issuecomment-479957703 I was working on a test to validate an user's issue, and I had to write a test to prove it was a non

[GitHub] [activemq-artemis] jbertram commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-479978220 The duplicate detection is done by the broker as that is the only reliable place for the duplicate to be detected. See

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272269532 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272269532 ## File path:

[GitHub] [activemq-artemis] gemmellr commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
gemmellr commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-479986758 I'd guess that Tim probably meant that doing it in the broker still requires the application to generate unique details

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ

2019-04-04 Thread GitBox
clebertsuconic opened a new pull request #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ URL: https://github.com/apache/activemq-artemis/pull/2608 This is an automated message from the Apache Git

[GitHub] [activemq-artemis] jbertram opened a new pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram opened a new pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609 I'm not entirely sure this should be an application property. Will someone with more expertise with AMQP weigh in? @tabish121? Should it

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272269532 ## File path:

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272271119 ## File path:

[GitHub] [activemq-artemis] tabish121 commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
tabish121 commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-479976744 @jbertram Given there's no requirements laid out in the issue I can't say for sure other than to say that if you want it

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272321577 ## File path:

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272323801 ## File path:

[GitHub] [activemq-artemis] jbertram commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-480028367 To the point about application requirements in this use-case, there are definitely requirements for the application if it

[GitHub] [activemq-artemis] jbertram edited a comment on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram edited a comment on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-480028367 To the point about application requirements in this use-case, there are definitely requirements for the

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2588: NO-JIRA Fix log statement in sessions.js

2019-04-04 Thread GitBox
michaelandrepearce commented on issue #2588: NO-JIRA Fix log statement in sessions.js URL: https://github.com/apache/activemq-artemis/pull/2588#issuecomment-480109681 @sebthom nice! will merge in soon. This is an automated

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2588: NO-JIRA Fix log statement in sessions.js

2019-04-04 Thread GitBox
michaelandrepearce edited a comment on issue #2588: NO-JIRA Fix log statement in sessions.js URL: https://github.com/apache/activemq-artemis/pull/2588#issuecomment-480109681 @sebthom nice catch! will merge in soon. This is

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2589: ARTEMIS-2281 Enhancements for addresses/queues of web console

2019-04-04 Thread GitBox
michaelandrepearce commented on issue #2589: ARTEMIS-2281 Enhancements for addresses/queues of web console URL: https://github.com/apache/activemq-artemis/pull/2589#issuecomment-480109849 @sebthom looks good to me, will merge in tomorrow, if no other comments.

[GitHub] [activemq-website] michaelandrepearce commented on a change in pull request #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#discussion_r27240 ## File path: src/.htaccess ## @@ -2,5 +2,6 @@ RewriteEngine On RewriteRule ^camel/(.*)$

[GitHub] [activemq-website] michaelandrepearce commented on a change in pull request #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#discussion_r27240 ## File path: src/.htaccess ## @@ -2,5 +2,6 @@ RewriteEngine On RewriteRule ^camel/(.*)$

[GitHub] [activemq-website] jbertram commented on a change in pull request #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
jbertram commented on a change in pull request #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#discussion_r272412403 ## File path: src/.htaccess ## @@ -2,5 +2,6 @@ RewriteEngine On RewriteRule ^camel/(.*)$

[GitHub] [activemq-website] jbertram commented on issue #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
jbertram commented on issue #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#issuecomment-480108807 Squash and I'll merge. This is an automated message from the Apache Git Service. To

[GitHub] [activemq-website] michaelandrepearce commented on issue #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
michaelandrepearce commented on issue #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#issuecomment-480100558 @jbertram wdyt? This is an automated message from the Apache Git Service.

[GitHub] [activemq-website] michaelandrepearce opened a new pull request #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
michaelandrepearce opened a new pull request #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-website] michaelandrepearce commented on issue #6: Add Artemis Docs ReWrite rule

2019-04-05 Thread GitBox
michaelandrepearce commented on issue #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#issuecomment-480206330 @jbertram squashed cheers. This is an automated message from the Apache Git

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-05 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272542023 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-05 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272542023 ## File path:

[GitHub] [activemq-website] cshannon opened a new pull request #7: Add documentation for 2.7.0

2019-04-05 Thread GitBox
cshannon opened a new pull request #7: Add documentation for 2.7.0 URL: https://github.com/apache/activemq-website/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [activemq-website] jbertram merged pull request #6: Add Artemis Docs ReWrite rule

2019-04-05 Thread GitBox
jbertram merged pull request #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-05 Thread GitBox
michaelandrepearce commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-480237413 +1 This is an automated message from the

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-05 Thread GitBox
michaelandrepearce edited a comment on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-480237413 Based on discussions, it seems this is the best way forwards for now, as such +1

[GitHub] [activemq-website] cshannon removed a comment on issue #7: Add documentation for 2.7.0

2019-04-05 Thread GitBox
cshannon removed a comment on issue #7: Add documentation for 2.7.0 URL: https://github.com/apache/activemq-website/pull/7#issuecomment-480253309 I'm going to close this and create a new one This is an automated message from

[GitHub] [activemq-website] cshannon commented on issue #7: Add documentation for 2.7.0

2019-04-05 Thread GitBox
cshannon commented on issue #7: Add documentation for 2.7.0 URL: https://github.com/apache/activemq-website/pull/7#issuecomment-480246102 Don't merge yet, I am going to update with all the missing docs as there is more than just 2.7.0

[GitHub] [activemq-website] cshannon closed pull request #7: Add documentation for 2.7.0

2019-04-05 Thread GitBox
cshannon closed pull request #7: Add documentation for 2.7.0 URL: https://github.com/apache/activemq-website/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [activemq-website] cshannon commented on issue #7: Add documentation for 2.7.0

2019-04-05 Thread GitBox
cshannon commented on issue #7: Add documentation for 2.7.0 URL: https://github.com/apache/activemq-website/pull/7#issuecomment-480253309 I'm going to close this and create a new one This is an automated message from the

[GitHub] [activemq-website] cshannon removed a comment on issue #7: Add documentation for 2.7.0

2019-04-05 Thread GitBox
cshannon removed a comment on issue #7: Add documentation for 2.7.0 URL: https://github.com/apache/activemq-website/pull/7#issuecomment-480246102 Don't merge yet, I am going to update with all the missing docs as there is more than just 2.7.0

[GitHub] [activemq-website] cshannon opened a new pull request #8: Add 2.7.0 docs and javadocs

2019-04-05 Thread GitBox
cshannon opened a new pull request #8: Add 2.7.0 docs and javadocs URL: https://github.com/apache/activemq-website/pull/8 I added 2.7.0 docs and javadocs from our SVN repo so this should be good to go now This is an

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing

2019-04-05 Thread GitBox
clebertsuconic commented on a change in pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing URL: https://github.com/apache/activemq-artemis/pull/2610#discussion_r272731288 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing

2019-04-05 Thread GitBox
michaelandrepearce commented on a change in pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing URL: https://github.com/apache/activemq-artemis/pull/2610#discussion_r272737781 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing

2019-04-05 Thread GitBox
clebertsuconic commented on a change in pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing URL: https://github.com/apache/activemq-artemis/pull/2610#discussion_r272732154 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing

2019-04-05 Thread GitBox
clebertsuconic opened a new pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing URL: https://github.com/apache/activemq-artemis/pull/2610 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] asfgit merged pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing

2019-04-05 Thread GitBox
asfgit merged pull request #2610: ARTEMIS-2295 fix IBM JDK schema parsing URL: https://github.com/apache/activemq-artemis/pull/2610 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [activemq-artemis] asfgit closed pull request #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ

2019-04-04 Thread GitBox
asfgit closed pull request #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ URL: https://github.com/apache/activemq-artemis/pull/2608 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] franz1981 commented on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler

2019-03-29 Thread GitBox
franz1981 commented on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler URL: https://github.com/apache/activemq-artemis/pull/2598#issuecomment-478148417 I understand this and I would say that logic and scalability of JMSBridge could be improved for

[GitHub] [activemq-artemis] franz1981 commented on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler

2019-03-29 Thread GitBox
franz1981 commented on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler URL: https://github.com/apache/activemq-artemis/pull/2598#issuecomment-478110766 @clebertsuconic @michaelandrepearce I need to understand a thing first: I see that the bridge

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler

2019-03-29 Thread GitBox
michaelandrepearce edited a comment on issue #2598: ARTEMIS-2290 JMSBridgeImpl::stop is failing when called from FailureHandler URL: https://github.com/apache/activemq-artemis/pull/2598#issuecomment-478136439 @franz1981 i honestly dont know. We had some early issues with the jmsbridge so

[GitHub] [activemq-artemis] jbertram opened a new pull request #2600: ARTEMIS-2289 SUBSCRIBE w/receipt returns 2 receipt-ids

2019-03-30 Thread GitBox
jbertram opened a new pull request #2600: ARTEMIS-2289 SUBSCRIBE w/receipt returns 2 receipt-ids URL: https://github.com/apache/activemq-artemis/pull/2600 This is an automated message from the Apache Git Service. To respond

[GitHub] [activemq-artemis] jdanekrh opened a new pull request #2599: NO-JIRA Fixing markdown format in intercepting-operations.md

2019-03-30 Thread GitBox
jdanekrh opened a new pull request #2599: NO-JIRA Fixing markdown format in intercepting-operations.md URL: https://github.com/apache/activemq-artemis/pull/2599 Both the old and new versions render OK on GitHub, but on

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2591: ARTEMIS-2283 Bad WARN message "AMQ222211: Storage is back to stable now"

2019-03-28 Thread GitBox
franz1981 edited a comment on issue #2591: ARTEMIS-2283 Bad WARN message "AMQ11: Storage is back to stable now" URL: https://github.com/apache/activemq-artemis/pull/2591#issuecomment-476777451 @ehsavoie I've changed my mind: I have noticed that we already have some test to cover

[GitHub] [activemq-artemis] gaohoward opened a new pull request #2596: NO-JIRA Avoid NPE during backup shutdown

2019-03-29 Thread GitBox
gaohoward opened a new pull request #2596: NO-JIRA Avoid NPE during backup shutdown URL: https://github.com/apache/activemq-artemis/pull/2596 When a backup starts without a live, it's nodeID is null. Added a null check in ClusterConnection's stop() to avoid NPE if it's shut down.

  1   2   3   4   5   6   7   8   9   10   >