[GitHub] clebertsuconic opened a new pull request #1: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-02-28 Thread GitBox
clebertsuconic opened a new pull request #1: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis-native/pull/1 On LibAIO is possible to retrieve the I/O completion events without using io_getevents sys-calls by reading the u

[GitHub] clebertsuconic merged pull request #1: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-02-28 Thread GitBox
clebertsuconic merged pull request #1: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis-native/pull/1 This is an automated message from the Apache Git Service.

[GitHub] clebertsuconic opened a new pull request #2: NO-JIRA Addressing a few minor issues

2019-03-01 Thread GitBox
clebertsuconic opened a new pull request #2: NO-JIRA Addressing a few minor issues URL: https://github.com/apache/activemq-artemis-native/pull/2 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] clebertsuconic merged pull request #2: NO-JIRA Addressing a few minor issues

2019-03-01 Thread GitBox
clebertsuconic merged pull request #2: NO-JIRA Addressing a few minor issues URL: https://github.com/apache/activemq-artemis-native/pull/2 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

2019-03-04 Thread GitBox
michaelandrepearce commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-469176168 @k-wall for CoreAmqpConverter and AmpqCoreConverter if the method is now in core, for translat

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

2019-03-04 Thread GitBox
michaelandrepearce commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r261974837 ## File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication

2019-03-04 Thread GitBox
clebertsuconic commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication URL: https://github.com/apache/activemq-artemis/pull/2572#issuecomment-469292426 Squash the test and the fix together? -

[GitHub] [activemq-artemis] franz1981 commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication

2019-03-04 Thread GitBox
franz1981 commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication URL: https://github.com/apache/activemq-artemis/pull/2572#issuecomment-469293005 @clebertsuconic Sure! let me do it now -

[GitHub] [activemq-artemis] aferre opened a new pull request #2574: modified ubuntu install instructions for libaio

2019-03-04 Thread GitBox
aferre opened a new pull request #2574: modified ubuntu install instructions for libaio URL: https://github.com/apache/activemq-artemis/pull/2574 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication

2019-03-04 Thread GitBox
michaelandrepearce commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication URL: https://github.com/apache/activemq-artemis/pull/2572#issuecomment-469403292 @franz1981 seems a test failure. PagingStoreImplTest.testConcurrentDepage:370->

[GitHub] [activemq-artemis] franz1981 commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication

2019-03-04 Thread GitBox
franz1981 commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication URL: https://github.com/apache/activemq-artemis/pull/2572#issuecomment-469413874 @michaelandrepearce I've runs full CI and I've got the common intermittent failures as always bu

[GitHub] [activemq-artemis] asfgit closed pull request #2574: modified ubuntu install instructions for libaio

2019-03-04 Thread GitBox
asfgit closed pull request #2574: modified ubuntu install instructions for libaio URL: https://github.com/apache/activemq-artemis/pull/2574 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication

2019-03-04 Thread GitBox
clebertsuconic commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication URL: https://github.com/apache/activemq-artemis/pull/2572#issuecomment-46901 Franz.. rebase to kick in a new job? I 've run this locally and no failures...

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-04 Thread GitBox
clebertsuconic commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-469444506 I will review this in detail tomorrow.. leave it with me please. ---

[GitHub] [activemq-artemis] MrEasy opened a new pull request #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-05 Thread GitBox
MrEasy opened a new pull request #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575 Karaf config should use predefined etc-dir instead of hard-coded etc This is a

[GitHub] [activemq-artemis] andytaylor commented on issue #2546: ARTEMIS-2249 - update cpp example to use correct client libs

2019-03-05 Thread GitBox
andytaylor commented on issue #2546: ARTEMIS-2249 - update cpp example to use correct client libs URL: https://github.com/apache/activemq-artemis/pull/2546#issuecomment-469628786 This must be env related, I only changed an example ---

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2546: ARTEMIS-2249 - update cpp example to use correct client libs

2019-03-05 Thread GitBox
clebertsuconic commented on issue #2546: ARTEMIS-2249 - update cpp example to use correct client libs URL: https://github.com/apache/activemq-artemis/pull/2546#issuecomment-469685894 I will merge this today. This is an autom

[GitHub] [activemq-artemis] franz1981 commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication

2019-03-05 Thread GitBox
franz1981 commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication URL: https://github.com/apache/activemq-artemis/pull/2572#issuecomment-469700071 @clebertsuconic This time seems to have worked fine :+1: --

[GitHub] [activemq-artemis] asfgit closed pull request #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication

2019-03-05 Thread GitBox
asfgit closed pull request #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication URL: https://github.com/apache/activemq-artemis/pull/2572 This is an automated message from the Apache Git Servic

[GitHub] [activemq-artemis] asfgit closed pull request #2546: ARTEMIS-2249 - update cpp example to use correct client libs

2019-03-05 Thread GitBox
asfgit closed pull request #2546: ARTEMIS-2249 - update cpp example to use correct client libs URL: https://github.com/apache/activemq-artemis/pull/2546 This is an automated message from the Apache Git Service. To respond to

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-05 Thread GitBox
clebertsuconic commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575#issuecomment-469907684 how karaf.etc is translated by default? This is an aut

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-05 Thread GitBox
clebertsuconic commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-469923260 I looked into this.. and I need a training class on the new feature :) this is great stuff indeed... the only

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-05 Thread GitBox
michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-469988807 Ok i can do a call tonight at 21:00 GMT. Ill send a link here later today. -

[GitHub] [activemq-artemis] MrEasy commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-05 Thread GitBox
MrEasy commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575#issuecomment-469991250 > how karaf.etc is translated by default? karaf.etc (along with its variants karaf.data, karaf.home, karaf.base and in l

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-05 Thread GitBox
michaelandrepearce commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575#issuecomment-469994813 So this def needs a default please This is an auto

[GitHub] [activemq-artemis] MrEasy commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-05 Thread GitBox
MrEasy commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575#issuecomment-470002715 > So this def needs a default please With def you mean a default like in this construct? `${karaf.etc:etc}` This un

[GitHub] [activemq-artemis] MrEasy edited a comment on issue #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-05 Thread GitBox
MrEasy edited a comment on issue #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575#issuecomment-470002715 > So this def needs a default please You mean a default like in this construct? `${karaf.etc:etc}` This unfo

[GitHub] [activemq-artemis] MrEasy edited a comment on issue #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-05 Thread GitBox
MrEasy edited a comment on issue #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575#issuecomment-470002715 > So this def needs a default please You mean a default like in this construct? `${karaf.etc:etc}` This unfo

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-06 Thread GitBox
michaelandrepearce commented on issue #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575#issuecomment-470006980 So what i would do next is work out how to make that supported. Im sure it will be possible. Having a config

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-06 Thread GitBox
michaelandrepearce edited a comment on issue #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575#issuecomment-470006980 So what i would do next is work out how to make that supported. Im sure it will be possible. Having a

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2575: ARTEMIS-2269 Using karaf.etc for config location

2019-03-06 Thread GitBox
michaelandrepearce edited a comment on issue #2575: ARTEMIS-2269 Using karaf.etc for config location URL: https://github.com/apache/activemq-artemis/pull/2575#issuecomment-470006980 So what i would do next is work out how to make that supported. Im sure it will be possible with a little sc

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470064190 https://meet.lync.com/iggroup/michael.pearce/CJG399AB --

[GitHub] [activemq] cshannon commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…

2019-03-06 Thread GitBox
cshannon commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s… URL: https://github.com/apache/activemq/pull/349#discussion_r262898876 ## File path: activemq-broker/src/main/java/org/apache/activemq/broker/jmx/PersistenceA

[GitHub] [activemq] cshannon commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…

2019-03-06 Thread GitBox
cshannon commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s… URL: https://github.com/apache/activemq/pull/349#discussion_r262899222 ## File path: activemq-broker/src/main/java/org/apache/activemq/store/PersistenceAdapte

[GitHub] [activemq] cshannon commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…

2019-03-06 Thread GitBox
cshannon commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s… URL: https://github.com/apache/activemq/pull/349#discussion_r262901153 ## File path: activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/Mess

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470209666 @clebertsuconic if you can confirm you saw this. Ill be online in 3 hours ---

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470209666 @clebertsuconic if you can confirm you saw this

[GitHub] [activemq] alanprot commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…

2019-03-06 Thread GitBox
alanprot commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s… URL: https://github.com/apache/activemq/pull/349#discussion_r263076055 ## File path: activemq-broker/src/main/java/org/apache/activemq/broker/jmx/PersistenceA

[GitHub] [activemq] alanprot commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…

2019-03-06 Thread GitBox
alanprot commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s… URL: https://github.com/apache/activemq/pull/349#discussion_r263099683 ## File path: activemq-broker/src/main/java/org/apache/activemq/store/PersistenceAdapte

[GitHub] [activemq] asfgit merged pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…

2019-03-06 Thread GitBox
asfgit merged pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s… URL: https://github.com/apache/activemq/pull/349 This is an automated message from the Apache Git Service. To respond to

[GitHub] [activemq] alanprot commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…

2019-03-06 Thread GitBox
alanprot commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s… URL: https://github.com/apache/activemq/pull/349#discussion_r263106882 ## File path: activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/Mess

[GitHub] [activemq-artemis] cshannon commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
cshannon commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470259178 @michaelandrepearce - I won't be able to make the call but thanks for starting work on this feature. This should be quite

[GitHub] [activemq-artemis] cshannon edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
cshannon edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470259178 @michaelandrepearce - I won't be able to make the call but thanks for starting work on this feature. This should be

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470271914 @cshannon indeed this is entirely where this hopes to go. Atm its single way, as like network brokers achieved f

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470271914 @cshannon indeed this is entirely where this hopes to go to cover off some of that need. Atm its single w

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
clebertsuconic commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470273134 It's in 4 minutes from now.. are you still available? --

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470273257 @clebertsuconic im on the call already This

[GitHub] [activemq] alanprot opened a new pull request #350: AMQ-7163 - If the broker had an unclean shutdown and number of free p…

2019-03-06 Thread GitBox
alanprot opened a new pull request #350: AMQ-7163 - If the broker had an unclean shutdown and number of free p… URL: https://github.com/apache/activemq/pull/350 …ages is Zero after the recovery, the next shutdown will also be 'unclean' --

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470338229 @clebertsuconic examples done, but **do not** merge still please, as just need to fix up the docs on the

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470338229 @clebertsuconic examples done, but **do not** merge still, as just need to fix up the docs on the example

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470338229 @clebertsuconic examples done, but do not merge still please, as just need to fix up the docs on the examples.

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-06 Thread GitBox
clebertsuconic commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470344286 @michaelandrepearce ok.. let me know when this is ready.. this is really good stuff. --

[GitHub] [activemq-artemis] wy96f commented on issue #2561: ARTEMIS-2259 Client session not exist if reattach timeout

2019-03-07 Thread GitBox
wy96f commented on issue #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#issuecomment-470436946 @clebertsuconic @michaelandrepearce Hi, we have added test. Please review it :) --

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2558: ARTEMIS-2257 Race condition when calling shutdownGracefully in SharedEventLoopGroup

2019-03-07 Thread GitBox
michaelandrepearce commented on issue #2558: ARTEMIS-2257 Race condition when calling shutdownGracefully in SharedEventLoopGroup URL: https://github.com/apache/activemq-artemis/pull/2558#issuecomment-470453745 Whats occuring on this on? Im keen we get bug fix prs closed before 2.7 cut. ---

[GitHub] [activemq-artemis] gtully commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-07 Thread GitBox
gtully commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470455007 This looks great. bravo! From my perspective it needs two capabilities that would make it a "better bridge" than the 5.x

[GitHub] [activemq-artemis] franz1981 commented on issue #2479: ARTEMIS-2211 Refactor ByteBuffer pooling, alignment and zeroing

2019-03-07 Thread GitBox
franz1981 commented on issue #2479: ARTEMIS-2211 Refactor ByteBuffer pooling, alignment and zeroing URL: https://github.com/apache/activemq-artemis/pull/2479#issuecomment-470456911 @michaelandrepearce > also whats occuring with the possible leakage has that been addressed We have

[GitHub] [activemq] gtully merged pull request #350: AMQ-7163 - If the broker had an unclean shutdown and number of free p…

2019-03-07 Thread GitBox
gtully merged pull request #350: AMQ-7163 - If the broker had an unclean shutdown and number of free p… URL: https://github.com/apache/activemq/pull/350 This is an automated message from the Apache Git Service. To respond to

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-07 Thread GitBox
michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470476817 Was great to have you on the call and get future feature enhancements for this and the feedback. We disc

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-07 Thread GitBox
michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470476817 Was great to have you on the call and get future feature enhancements for this and the feedback.

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-07 Thread GitBox
michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470476817 Was great to have you on the call and get future feature enhancements for this and the feedback.

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-07 Thread GitBox
michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470499637 @clebertsuconic examples docs done. will leave with you now. ---

[GitHub] [activemq-artemis] cshannon commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-07 Thread GitBox
cshannon commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-470515574 +1 for some of Gary's suggestions, they sound like a good idea as future enhancements. Maybe we can look at making the tr

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2570: ARTEMIS-1977 Stripping activemq-artemis-native as a separated project

2019-03-07 Thread GitBox
clebertsuconic commented on issue #2570: ARTEMIS-1977 Stripping activemq-artemis-native as a separated project URL: https://github.com/apache/activemq-artemis/pull/2570#issuecomment-470591353 This is now ready to be merged. T

[GitHub] [activemq-artemis] asfgit closed pull request #2570: ARTEMIS-1977 Stripping activemq-artemis-native as a separated project

2019-03-07 Thread GitBox
asfgit closed pull request #2570: ARTEMIS-1977 Stripping activemq-artemis-native as a separated project URL: https://github.com/apache/activemq-artemis/pull/2570 This is an automated message from the Apache Git Service. To r

[GitHub] [activemq-artemis] asfgit closed pull request #2573: ARTEMIS-2265 Support Federated Queues and Addresses

2019-03-07 Thread GitBox
asfgit closed pull request #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2547: Patched with live lock evaluation

2019-03-07 Thread GitBox
michaelandrepearce commented on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-470836227 @emagiz if you havent seen on dev list, we are looking to release 2.7.0 within the week, how are you progressing? Do you think your

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-03-07 Thread GitBox
michaelandrepearce commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-470836491 @clebertsuconic bump on this. ---

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2479: ARTEMIS-2211 Refactor ByteBuffer pooling, alignment and zeroing

2019-03-08 Thread GitBox
michaelandrepearce commented on issue #2479: ARTEMIS-2211 Refactor ByteBuffer pooling, alignment and zeroing URL: https://github.com/apache/activemq-artemis/pull/2479#issuecomment-470951396 @franz1981 cool, as per my original comment as this is journal area its a bit out my league so ill l

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

2019-03-08 Thread GitBox
clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-471002737 this seems ready...??? This is an

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

2019-03-08 Thread GitBox
clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-471003930 I will merge this... if there's anything to be amended here, it can be a separate commit

[GitHub] [activemq-artemis] asfgit closed pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

2019-03-08 Thread GitBox
asfgit closed pull request #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568 This is an automated message from the Apache Git Service. To r

[GitHub] [activemq-artemis] michaelandrepearce opened a new pull request #2576: ARTEMIS-2271 - Upgrade to Netty Libs to Latest 4.1.34.FINAL

2019-03-08 Thread GitBox
michaelandrepearce opened a new pull request #2576: ARTEMIS-2271 - Upgrade to Netty Libs to Latest 4.1.34.FINAL URL: https://github.com/apache/activemq-artemis/pull/2576 Also upgrade netty-tcnative along with it. This is an a

[GitHub] [activemq-artemis] k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

2019-03-08 Thread GitBox
k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-471015062 Glad to see the feature accepted. If the coding can be improved along the lines @michaelandrepearce sugge

[GitHub] [activemq-artemis] asfgit merged pull request #2576: ARTEMIS-2271 - Upgrade to Netty Libs to Latest 4.1.34.FINAL

2019-03-08 Thread GitBox
asfgit merged pull request #2576: ARTEMIS-2271 - Upgrade to Netty Libs to Latest 4.1.34.FINAL URL: https://github.com/apache/activemq-artemis/pull/2576 This is an automated message from the Apache Git Service. To respond to

[GitHub] [activemq-artemis] emagiz commented on issue #2547: Patched with live lock evaluation

2019-03-11 Thread GitBox
emagiz commented on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-471465165 Will be working on it today and afterwards until it is done. Comments should be done quickly because there are few and they are not hard to imp

[GitHub] [activemq-artemis] franz1981 opened a new pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 opened a new pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577 Direct and async deliveries lock QueueImpl::this and ServerConsumerImpl::this in different order causing deadlock: has been introduced

[GitHub] [activemq-artemis] franz1981 commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471530701 I'm working to add a reproducer (not easy TBH, but possible and useful), but the referenced issue already report a stac

[GitHub] [activemq-artemis] franz1981 commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471629420 @clebertsuconic I have found another issue, probably the most important one!! Both Stomp and MQTT are supporting direct d

[GitHub] [activemq-artemis] franz1981 commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471637567 @clebertsuconic So it is fine that I have overridden supportDirectDelivery in order to return false? -

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471629420 @clebertsuconic I have found another issue, probably the most important one!! Both Stomp and MQTT are supporting d

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471629420 @clebertsuconic I have found another issue, probably the most important one!! Both Stomp and MQTT are supporting d

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471637567 @clebertsuconic So it is fine that I have overridden supportDirectDelivery in order to return false? By default,

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
michaelandrepearce edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471647209 Surprised that disabling direct here is needed as using netty mqtt protocol support. -

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
michaelandrepearce commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471647209 Surprised that disabling direct here is needed as using netty mqtt protocol --

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
michaelandrepearce edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471647209 Surprised that disabling direct here is needed as using netty mqtt protocol support. Also if is in t

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
michaelandrepearce edited a comment on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471647209 Surprised that disabling direct here is needed as using netty mqtt protocol support. Also if is in t

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264353630 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264360104 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264353630 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264367521 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264370764 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264370764 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264370764 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264400159 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/

[GitHub] [activemq-artemis] franz1981 commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on issue #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#issuecomment-471696183 Re the performance impacts I cannot see any evident ones, because tryLock will cost just a volatile load + a compareAndSwap

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264402128 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264402308 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264402128 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264402128 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

2019-03-11 Thread GitBox
franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264403335 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl

  1   2   3   4   5   6   7   8   9   10   >