aweltsch commented on code in PR #7021:
URL: https://github.com/apache/arrow-rs/pull/7021#discussion_r1952088694
##
arrow-cast/src/cast/decimal.rs:
##
@@ -99,10 +100,24 @@ where
I::Native: DecimalCast + ArrowNativeTypeOp,
O::Native: DecimalCast + ArrowNativeTypeOp,
{
lidavidm opened a new pull request, #2520:
URL: https://github.com/apache/arrow-adbc/pull/2520
Fixes #2519.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
github-actions[bot] commented on PR #45509:
URL: https://github.com/apache/arrow/pull/45509#issuecomment-2652841595
Revision: 01ae806c96691ea2e76a7e171401527e5c2a8798
Submitted crossbow builds: [ursacomputing/crossbow @
actions-fcebef6eff](https://github.com/ursacomputing/crossbow/bra
aweltsch commented on code in PR #7021:
URL: https://github.com/apache/arrow-rs/pull/7021#discussion_r1952088694
##
arrow-cast/src/cast/decimal.rs:
##
@@ -99,10 +100,24 @@ where
I::Native: DecimalCast + ArrowNativeTypeOp,
O::Native: DecimalCast + ArrowNativeTypeOp,
{
kou commented on PR #45509:
URL: https://github.com/apache/arrow/pull/45509#issuecomment-2652838140
@github-actions crossbow submit test-ubuntu-r-sanitizer test-r-linux-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on PR #45509:
URL: https://github.com/apache/arrow/pull/45509#issuecomment-2652837161
:warning: GitHub issue #45508 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou opened a new pull request, #45509:
URL: https://github.com/apache/arrow/pull/45509
### Rationale for this change
Ubuntu 20.04 will reach EOL on 2025-05.
### What changes are included in this PR?
Use Ubuntu 22.04 instead of 20.04.
### Are these changes tested?
aweltsch commented on code in PR #7021:
URL: https://github.com/apache/arrow-rs/pull/7021#discussion_r1952088694
##
arrow-cast/src/cast/decimal.rs:
##
@@ -99,10 +100,24 @@ where
I::Native: DecimalCast + ArrowNativeTypeOp,
O::Native: DecimalCast + ArrowNativeTypeOp,
{
github-actions[bot] commented on PR #45492:
URL: https://github.com/apache/arrow/pull/45492#issuecomment-2652822558
Revision: 2ec2bdf75ec77f3f7ae5edccf591068508491ebd
Submitted crossbow builds: [ursacomputing/crossbow @
actions-bd4e727286](https://github.com/ursacomputing/crossbow/bra
kou commented on issue #45377:
URL: https://github.com/apache/arrow/issues/45377#issuecomment-2652824347
Issue resolved by pull request 45464
https://github.com/apache/arrow/pull/45464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #45464:
URL: https://github.com/apache/arrow/pull/45464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
github-actions[bot] commented on PR #45507:
URL: https://github.com/apache/arrow/pull/45507#issuecomment-2652811982
Revision: be959e5ae1b8849321383398835668ff63497fb1
Submitted crossbow builds: [ursacomputing/crossbow @
actions-b1cf7ac8c9](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #45492:
URL: https://github.com/apache/arrow/pull/45492#issuecomment-2652818418
@github-actions crossbow submit -g linux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou opened a new pull request, #45507:
URL: https://github.com/apache/arrow/pull/45507
### Rationale for this change
Ubuntu 20.04 will reach EOL on 2025-05.
### What changes are included in this PR?
Use Ubuntu 22.04 instead of Ubuntu 20.04.
### Are these changes te
kou commented on code in PR #45507:
URL: https://github.com/apache/arrow/pull/45507#discussion_r1952074149
##
dev/tasks/r/github.packages.yml:
##
@@ -313,8 +313,8 @@ jobs:
# fedora-clang-devel cannot use binaries bc of libc++ (uncomment to
see the error)
#
kou commented on PR #45507:
URL: https://github.com/apache/arrow/pull/45507#issuecomment-2652808540
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] commented on PR #45507:
URL: https://github.com/apache/arrow/pull/45507#issuecomment-2652808892
:warning: GitHub issue #45505 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
aweltsch commented on code in PR #7021:
URL: https://github.com/apache/arrow-rs/pull/7021#discussion_r1952068132
##
arrow-cast/src/cast/decimal.rs:
##
@@ -99,10 +100,24 @@ where
I::Native: DecimalCast + ArrowNativeTypeOp,
O::Native: DecimalCast + ArrowNativeTypeOp,
{
kou commented on PR #602:
URL: https://github.com/apache/arrow-java/pull/602#issuecomment-2652756827
We should rebase on main after we merge GH-595.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
amoeba commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652748345
> (We need to specify `--arrow-version 19.0.1-rc1` too in [#45502
(comment)](https://github.com/apache/arrow/pull/45502#issuecomment-2652429450)
when we want to submit binary build jobs by
shuozel opened a new pull request, #7122:
URL: https://github.com/apache/arrow-rs/pull/7122
# Which issue does this PR close?
Closes #7121.
# Rationale for this change
Refer to the comment from @tustvold in
[issue#7121](https://github.com/apache/arrow-rs
singh1203 commented on code in PR #250:
URL: https://github.com/apache/arrow-go/pull/250#discussion_r1952032400
##
.github/workflows/benchmark.yml:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See t
lidavidm merged PR #600:
URL: https://github.com/apache/arrow-java/pull/600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
lidavidm merged PR #2515:
URL: https://github.com/apache/arrow-adbc/pull/2515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.a
kou commented on issue #45486:
URL: https://github.com/apache/arrow/issues/45486#issuecomment-2652727017
Issue resolved by pull request 45490
https://github.com/apache/arrow/pull/45490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou commented on PR #45490:
URL: https://github.com/apache/arrow/pull/45490#issuecomment-2652725979
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
kou merged PR #45490:
URL: https://github.com/apache/arrow/pull/45490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou merged PR #607:
URL: https://github.com/apache/arrow-java/pull/607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.o
kou merged PR #608:
URL: https://github.com/apache/arrow-java/pull/608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.o
kou merged PR #606:
URL: https://github.com/apache/arrow-java/pull/606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.o
jecsand838 commented on PR #6965:
URL: https://github.com/apache/arrow-rs/pull/6965#issuecomment-2652692978
> Thank you for this, I wonder if there is some way we might break this up
into smaller pieces. A single 5000 line diff is not something I can
realistically review...
@tustvold
mapleFU commented on code in PR #45498:
URL: https://github.com/apache/arrow/pull/45498#discussion_r1951999114
##
cpp/src/arrow/csv/parser.cc:
##
@@ -171,12 +186,26 @@ class ResizableValueDescWriter : public
ValueDescWriter {
public:
+ // The number of offsets being written
lidavidm commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2652695936
Looks like one more minor CI nit:
```
Error:
/home/runner/work/arrow-java/arrow-java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterProjectTest.java:37:8:
lidavidm commented on PR #602:
URL: https://github.com/apache/arrow-java/pull/602#issuecomment-2652695110
@lriggs since you've been working on Gandiva lately, would you be able to
help take a look at the changes here?
--
This is an automated message from the Apache Git Service.
To respond
lidavidm commented on issue #601:
URL: https://github.com/apache/arrow-java/issues/601#issuecomment-2652694707
Ah I see it looks like we upgraded LLVM instead
https://github.com/apache/arrow/pull/45114
--
This is an automated message from the Apache Git Service.
To respond to the message,
kou commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652685007
Ah, I saw wrong jobs:
https://github.com/apache/arrow/pull/45502#issuecomment-2652433232
(We need to specify `--arrow-version 19.0.1-rc1` too in
https://github.com/apache/arrow/pull/45502#
JOBIN-SABU commented on code in PR #45443:
URL: https://github.com/apache/arrow/pull/45443#discussion_r1951983136
##
cpp/tests/test_file_json.cc:
##
@@ -0,0 +1,81 @@
+#include
Review Comment:
Hi @raulcd a
I hope you're doing well.
I've made progress on fixing
kou commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652673093
Hmm. Versions for binary artifacts aren't correct:
https://github.com/ursacomputing/crossbow/actions/runs/13276018747/workflow#L95
```text
ARROW_VERSION: 20.0.1.dev0
```
kou opened a new pull request, #608:
URL: https://github.com/apache/arrow-java/pull/608
Fixes GH-605.
If `dev/release/release.sh` shows what should we do at
repository.apache.org, it's helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message,
kou commented on PR #607:
URL: https://github.com/apache/arrow-java/pull/607#issuecomment-2652657679
Example:
https://dist.apache.org/repos/dist/release/arrow/apache-arrow-java-18.2.0/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kou opened a new pull request, #607:
URL: https://github.com/apache/arrow-java/pull/607
Fixes GH-604.
For example, here are target files for 18.2.0:
* apache-arrow-java-18.2.0.tar.gz
* apache-arrow-java-18.2.0.tar.gz.asc
* apache-arrow-java-18.2.0.tar.gz.sha256
* apache
zanmato1984 merged PR #45268:
URL: https://github.com/apache/arrow/pull/45268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.a
kou opened a new pull request, #606:
URL: https://github.com/apache/arrow-java/pull/606
Fixes GH-603.
Message from Git:
hint: You have created a nested tag. The object referred to by your new
tag is
hint: already a tag. If you meant to tag the object that it points t
zanmato1984 commented on issue #45266:
URL: https://github.com/apache/arrow/issues/45266#issuecomment-2652646781
Issue resolved by pull request 45268
https://github.com/apache/arrow/pull/45268
--
This is an automated message from the Apache Git Service.
To respond to the message, please
zanmato1984 commented on PR #45268:
URL: https://github.com/apache/arrow/pull/45268#issuecomment-2652645699
Thank you @pitrou for reviewing. And I take this as an approval to merge so
I'm doing it.
Also thank you @wuzhoupei for spotting and fixing this!
--
This is an automated mess
lidavidm commented on issue #601:
URL: https://github.com/apache/arrow-java/issues/601#issuecomment-2652623793
I believe there's efforts to revert back to the old JIT due to various
problems with the new one
--
This is an automated message from the Apache Git Service.
To respond to the me
mapleFU commented on code in PR #45498:
URL: https://github.com/apache/arrow/pull/45498#discussion_r1951932595
##
cpp/src/arrow/csv/parser.cc:
##
@@ -158,7 +173,7 @@ class ResizableValueDescWriter : public
ValueDescWriterResize(values_capacity_ *
sizeof(*values_)));
+ sta
shuozel commented on issue #7121:
URL: https://github.com/apache/arrow-rs/issues/7121#issuecomment-2652610025
It seems the `NullBufferBuilder` is calling the
`BooleanBufferBuilder.capacity()` here [1], and we are directly returning the
capacity in bits returend by the BooleanBufferBuilder.
timothydijamco commented on issue #45287:
URL: https://github.com/apache/arrow/issues/45287#issuecomment-2652600667
Yes I think it makes sense to close this now. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
conbench-apache-arrow[bot] commented on PR #45500:
URL: https://github.com/apache/arrow/pull/45500#issuecomment-2652585137
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 13940cdc7e463eff8001e05b86be62a7c0e4c189.
There were no
kou commented on issue #574:
URL: https://github.com/apache/arrow-java/issues/574#issuecomment-2652552318
Done.
@jbonofre Could you do
https://github.com/apache/arrow-java/blob/main/dev/release/README.md#bump-version-for-new-development
?
--
This is an automated message from the A
WillAyd commented on PR #45441:
URL: https://github.com/apache/arrow/pull/45441#issuecomment-2652532774
Sure no problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
kou commented on issue #574:
URL: https://github.com/apache/arrow-java/issues/574#issuecomment-2652532113
The vote passed:
https://lists.apache.org/thread/9c8ckosvyrlj4shw0rpfkcj4qmsgwc00
I'll do
https://github.com/apache/arrow-java/blob/main/dev/release/README.md#publish .
--
kou commented on code in PR #45441:
URL: https://github.com/apache/arrow/pull/45441#discussion_r1951843281
##
cpp/meson.build:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
Xuanwo commented on issue #7117:
URL: https://github.com/apache/arrow-rs/issues/7117#issuecomment-2652454800
> [https://avatars.githubusercontent.com/u/5351546?u=e4630f76ef9a4ac33b5bb9af04043b636bef167c&v=4&size=80";>@Xuanwo](https://github.com/Xuanwo?rgh-link-date=2025-02-11T15%3A38%3A59.000
conbench-apache-arrow[bot] commented on PR #45330:
URL: https://github.com/apache/arrow/pull/45330#issuecomment-2652448113
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit f8a0902cbbfea46396e2fc0cbd2a88f6f3b04018.
There were no
kou commented on issue #275:
URL: https://github.com/apache/arrow-go/issues/275#issuecomment-2652400165
I think that we need to mention all
https://github.com/apache/arrow-go/blob/main/arrow/flight/cookie_middleware.go#L33
like files (files that include copied codes) in `LICENSE.txt` explic
conbench-apache-arrow[bot] commented on PR #45444:
URL: https://github.com/apache/arrow/pull/45444#issuecomment-2652440958
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit b1e822ae1e99a64762f8d61696f75243e7dd2ba7.
There were no
amoeba commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652437204
I re-ran packaging jobs because so many of them were failing due to network
issues, for example:
> E: Failed to fetch
http://ports.ubuntu.com/ubuntu-ports/pool/main/r/ruby3.0/ruby3.
github-actions[bot] commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652433232
Revision: 272715f6df2a042d69881ffa03d5078c58e4b345
Submitted crossbow builds: [ursacomputing/crossbow @
actions-851d691819](https://github.com/ursacomputing/crossbow/bra
amoeba commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652430098
@github-actions crossbow submit wheel-manylinux-2014-cp313-cp313t-arm64
--param release=19.0.1 --param rc=1
--
This is an automated message from the Apache Git Service.
To respond to the
amoeba commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652429450
@github-actions crossbow submit --group packaging --param release=19.0.1
--param rc=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
amoeba commented on PR #45501:
URL: https://github.com/apache/arrow/pull/45501#issuecomment-2652426052
The Windows jobs look good. RC1 verification PR is now open at
https://github.com/apache/arrow/pull/45502.
--
This is an automated message from the Apache Git Service.
To respond to the
amoeba closed pull request #45501: WIP: Testing-only PR to check maint-19.0.1
status
URL: https://github.com/apache/arrow/pull/45501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
kassane commented on PR #44536:
URL: https://github.com/apache/arrow/pull/44536#issuecomment-2652425414
External enhancement for Arrow support:
**GiD bindings**
-
https://github.com/Kymorphia/gid/commit/afd41bd398bb6e8e92ef23ce7e9335ca8b0f8a8f
-
https://github.com/Kymorphia/gid
paleolimbot commented on issue #2508:
URL: https://github.com/apache/arrow-adbc/issues/2508#issuecomment-2652413581
Thanks for the updates!
`read_adbc()` will always be fast (it's returning a lazy stream)...I should
have remembered that you'd need to `collect_array_stream()` to actual
alamb commented on PR #7089:
URL: https://github.com/apache/arrow-rs/pull/7089#issuecomment-2652409818
Thanks @tustvold and @Jefffrey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lriggs opened a new pull request, #602:
URL: https://github.com/apache/arrow-java/pull/602
### Rationale for this change
Multiple threads can attempt to create the same llvm expression in Gandiva.
This isn't allowed with the new JIT compiler, so synchronizing will prevent
this scenario.
lriggs commented on issue #601:
URL: https://github.com/apache/arrow-java/issues/601#issuecomment-2652399104
```
diff --git
a/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/Projector.java
b/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/Projector.java
ind
kou commented on code in PR #45498:
URL: https://github.com/apache/arrow/pull/45498#discussion_r1951796744
##
cpp/src/arrow/csv/parser_test.cc:
##
@@ -621,6 +645,25 @@ TEST(BlockParser, MismatchingNumColumns) {
EXPECT_RAISES_WITH_MESSAGE_THAT(
Invalid, testing::Has
kou commented on PR #277:
URL: https://github.com/apache/arrow-go/pull/277#issuecomment-2652374690
I think that we can use x86_64 ubuntu-latest runner for it.
In general, x86_64 Linux kernel can execute i386 binary. Go can build i386
binary on x86_64 by `GOARCH=386`, right?
--
This
kou commented on code in PR #250:
URL: https://github.com/apache/arrow-go/pull/250#discussion_r1951789530
##
.github/workflows/benchmark.yml:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOT
lriggs commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2652348914
Thanks. I updated vcpkg as well now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
scovich commented on issue #7119:
URL: https://github.com/apache/arrow-rs/issues/7119#issuecomment-2652344533
> I think what might help is adding a representation section, similar to we
have for
[ListArray](https://docs.rs/arrow-array/latest/arrow_array/array/struct.GenericListArray.html#re
kou commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652327505
Revision: apache-arrow-19.0.1-rc1
Submitted crossbow builds: [ursacomputing/crossbow @
release-19.0.1-rc1-0](https://github.com/ursacomputing/crossbow/branches/all?query=release-19.0.1-
kou commented on issue #42111:
URL: https://github.com/apache/arrow/issues/42111#issuecomment-2652322656
OK. Thanks for working on this so far!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lidavidm commented on PR #277:
URL: https://github.com/apache/arrow-go/pull/277#issuecomment-2652313986
https://github.com/docker/setup-qemu-action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652313480
Revision: 272715f6df2a042d69881ffa03d5078c58e4b345
Submitted crossbow builds: [ursacomputing/crossbow @
actions-ba3bdf5e63](https://github.com/ursacomputing/crossbow/bra
kou opened a new pull request, #45502:
URL: https://github.com/apache/arrow/pull/45502
PR to verify Release Candidate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
kou commented on PR #45502:
URL: https://github.com/apache/arrow/pull/45502#issuecomment-2652310293
@github-actions crossbow submit --group verify-rc-source --param
release=19.0.1 --param rc=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rshkv commented on code in PR #7101:
URL: https://github.com/apache/arrow-rs/pull/7101#discussion_r1951745762
##
arrow-array/src/builder/map_builder.rs:
##
@@ -107,13 +108,29 @@ impl MapBuilder {
field_names: field_names.unwrap_or_default(),
key_builder
conbench-apache-arrow[bot] commented on PR #45489:
URL: https://github.com/apache/arrow/pull/45489#issuecomment-2652285365
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 3b29833e51a737a4475c815067904d4e18b6947e.
There were no
tustvold commented on code in PR #7101:
URL: https://github.com/apache/arrow-rs/pull/7101#discussion_r1951733793
##
arrow-array/src/builder/map_builder.rs:
##
@@ -377,4 +400,54 @@ mod tests {
)
);
}
+
+#[test]
+fn test_with_keys_field() {
+
tustvold commented on code in PR #7101:
URL: https://github.com/apache/arrow-rs/pull/7101#discussion_r1951734144
##
arrow-array/src/builder/map_builder.rs:
##
@@ -107,13 +108,29 @@ impl MapBuilder {
field_names: field_names.unwrap_or_default(),
key_buil
tustvold commented on PR #7104:
URL: https://github.com/apache/arrow-rs/pull/7104#issuecomment-2652264441
I've filed #7121 to change the allocated_size to be in bytes, going to mark
this as a draft in the meantime
--
This is an automated message from the Apache Git Service.
To respond to
tustvold commented on code in PR #7089:
URL: https://github.com/apache/arrow-rs/pull/7089#discussion_r1951731323
##
arrow-buffer/src/builder/null.rs:
##
@@ -217,7 +217,7 @@ impl NullBufferBuilder {
self.bitmap_builder.as_mut().map(|b| b.as_slice_mut())
}
-///
tustvold opened a new issue, #7121:
URL: https://github.com/apache/arrow-rs/issues/7121
**Describe the bug**
As documented in https://github.com/apache/arrow-rs/pull/7089,
NullBufferBuilder::allocated_size returns the size in bits. Given no reasonable
allocator allocates memory i
tustvold commented on issue #7005:
URL: https://github.com/apache/arrow-rs/issues/7005#issuecomment-2652255998
> Anyway, what do you think about the right place for integrating this?
from_env? The builder with_config method?
The correct thing is probably for `AmazonS3ConfigKey` to be
tustvold commented on PR #6965:
URL: https://github.com/apache/arrow-rs/pull/6965#issuecomment-2652250207
Thank you for this, I wonder if there is some way we might break this up
into smaller pieces. A single 5000 line diff is not something I can
realistically review...
--
This is an aut
tustvold closed issue #1697: MapArray Additional Nullability
URL: https://github.com/apache/arrow-rs/issues/1697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tustvold commented on code in PR #7101:
URL: https://github.com/apache/arrow-rs/pull/7101#discussion_r1951722391
##
arrow-array/src/builder/map_builder.rs:
##
@@ -107,13 +108,31 @@ impl MapBuilder {
field_names: field_names.unwrap_or_default(),
key_buil
tustvold commented on PR #7015:
URL: https://github.com/apache/arrow-rs/pull/7015#issuecomment-2652236729
I'm a bit swamped at the moment, but I'll try to take a look this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
tustvold commented on code in PR #7096:
URL: https://github.com/apache/arrow-rs/pull/7096#discussion_r1951714472
##
arrow-ipc/src/reader.rs:
##
@@ -2472,4 +2512,109 @@ mod tests {
assert_eq!(decoded_batch.expect("Failed to read RecordBatch"),
batch);
tustvold commented on code in PR #7096:
URL: https://github.com/apache/arrow-rs/pull/7096#discussion_r1951712655
##
arrow-ipc/src/reader.rs:
##
@@ -1744,27 +1745,73 @@ mod tests {
});
}
-fn roundtrip_ipc(rb: &RecordBatch) -> RecordBatch {
+/// Write the r
zeroshade commented on issue #2508:
URL: https://github.com/apache/arrow-adbc/issues/2508#issuecomment-2652228253
> 99% of the profile was spent on the `as_tibble()` interval (traced through
`as_tibble` -> `as_tibble.default` -> `as_tibble` -> `as.data.frame` ->
`as.data.frame.nanoarrow_arr
tustvold commented on issue #7119:
URL: https://github.com/apache/arrow-rs/issues/7119#issuecomment-2652226633
Given that `Array::is_null` refers to logical_nulls, I think adding the
below to `Array::logical_nulls` should be sufficient
> WARNING: The logical nullability of a nested co
zeroshade commented on PR #2494:
URL: https://github.com/apache/arrow-adbc/pull/2494#issuecomment-2652226100
@Niivii @davlee1972 I think i figured it out without needing a larger
refactor here's a built version that you can try and hopefully fixes the
issue on your end, it fixed my repr
scovich commented on issue #7119:
URL: https://github.com/apache/arrow-rs/issues/7119#issuecomment-2652217498
> if you wanted to add a section documenting nested nullability, I'm sure
that would be well received.
For
[`Array::is_null`](https://docs.rs/arrow/latest/arrow/array/trait.A
tustvold commented on issue #7119:
URL: https://github.com/apache/arrow-rs/issues/7119#issuecomment-2652202008
> That's surprising and painfully row-oriented for a column-oriented format
-- especially for wide schemas.
At least for StructArray, you can compute the combined null masks
scovich commented on issue #7119:
URL: https://github.com/apache/arrow-rs/issues/7119#issuecomment-2652194317
> When projecting a nested column, one must take into account the validity
masks of any parents.
That's surprising and painfully row-oriented for a column-oriented format --
esp
1 - 100 of 285 matches
Mail list logo
